platform/upstream/elementary.git
6 years agoentry: fix memory leak issue for atspi 28/153428/2
Youngbok Shin [Thu, 28 Sep 2017 10:13:05 +0000 (19:13 +0900)]
entry: fix memory leak issue for atspi

@tizne_fix

Change-Id: Ib7820537a74b504939c78848b03cf5f644e49970

6 years agoelm_win: prevent Null pointer ref. 93/153293/3
Woochan Lee [Thu, 28 Sep 2017 07:47:06 +0000 (16:47 +0900)]
elm_win: prevent Null pointer ref.

_elm_config could be null. in case launch the app using app_launch command in shell.

@tizen_fix

Change-Id: I27006548a32c56fffd6ff9aea98941b5e6036593

6 years agoelm_need_efret() - improve error handling according to coverity 65/153265/1
Hosang Kim [Thu, 28 Sep 2017 07:05:21 +0000 (16:05 +0900)]
elm_need_efret() - improve error handling according to coverity

fix CID 1360466, CID 1353589

we don't actually chekc if efreet inits right with elm_need_efreet()
as we just assume it inits (And there pretty much is no case where it
will not), but make coverity happy and check.

@fix
Change-Id: Ieb37ab35a6ebc3a7e30b9fd5be6bb0e5b06aa64f

6 years agoelm dbus menu - handle return value of eldbus_message_iter_arguments_get 51/153251/2
Hosang Kim [Thu, 28 Sep 2017 06:40:44 +0000 (15:40 +0900)]
elm dbus menu - handle return value of eldbus_message_iter_arguments_get

handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.

Change-Id: I213f644c6450e550f5a26fd9a0c11a707d71f94a

6 years agoelm_config: add since_tizen tags for language auto mirrored functions 56/153256/2
Taehyub Kim [Thu, 28 Sep 2017 06:02:45 +0000 (15:02 +0900)]
elm_config: add since_tizen tags for language auto mirrored functions

Change-Id: I855d620001346327358fffaa25f8073611b2fe5e

6 years agoelm_interface_atspi_accessible: modified since_tizen tags for relationships clear 54/153254/1
Taehyub Kim [Thu, 28 Sep 2017 05:56:20 +0000 (14:56 +0900)]
elm_interface_atspi_accessible: modified since_tizen tags for relationships clear

Change-Id: I772ca0b888cba32ed9d1b99ccddad6c9cc12ca1a

6 years agoadd color for build message(error:red, warning:ylw) 37/152237/2
JunsuChoi [Mon, 25 Sep 2017 09:58:23 +0000 (18:58 +0900)]
add color for build message(error:red, warning:ylw)

Change-Id: I6fe5cf69b56d99085fa2b8655e96e0c8121cd8ef

6 years agoelm image: Fix async open to avoid multiple mmap 90/151290/2 accepted/tizen/unified/20170929.081254 submit/tizen/20170928.042726
jiin.moon [Wed, 20 Sep 2017 10:18:07 +0000 (19:18 +0900)]
elm image: Fix async open to avoid multiple mmap

 From cb3b4cc8d7794bea575a85325c8a58f25f0507b2 Mon Sep 17 00:00:00 2001
 From: Jean-Philippe Andre <jp.andre@samsung.com>
 Date: Fri, 15 Sep 2017 14:39:14 +0900
 Subject: [PATCH] elm image: Fix async open to avoid multiple mmap

 Reported by @jiin.moon:

 In case of async_open for an elm_image, we try and open a file in a
 thread, then map it and populate a bit, as this may take some time
 (blocking I/O). This creates a mmap with eina_file_map_new. But later
 evas image loaders will (usually) try and map the entire file with
 eina_file_map_all() which creates another mmap. Since the size is
 different (32Kb first then all) the returned map might be different
 (it's up to the kernel to decide at this point).

 So, in order to avoid having multiple maps on the same file, and try to
 reduce the peak memory usage, we should prefer using the same map all
 the time, i.e. the global one returned by eina_file_map_all().

 This patch relies on the previous patch in eina_file which fixes
 eina_file_map_populate() for the global map.

 @fix

Change-Id: If27d42b89269493ac2425737198338689687459d

6 years agointerface_scrollable: Cast result of divide explicitly 28/148828/2 submit/tizen/20171012.121301
Wonki Kim [Mon, 11 Sep 2017 04:12:57 +0000 (13:12 +0900)]
interface_scrollable: Cast result of divide explicitly

cast from double to int explicitly to remove smell of code

Change-Id: Ic02d3c24f212be1d71ecb5a8b0e923795e8296d3
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agogenlist & gengrid : fix build warnings 57/151657/2
SangHyeon Jade Lee [Thu, 21 Sep 2017 10:52:33 +0000 (19:52 +0900)]
genlist & gengrid : fix build warnings

Change-Id: Ia356f41294f8e0bb84446699a7de87757d1b23b3
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoels_tooltip: Fix to use some functions before tooltip_test_set or tooltip_content_cb_set 01/151101/1
Jeonghyun Yun [Wed, 20 Sep 2017 01:02:56 +0000 (10:02 +0900)]
els_tooltip: Fix to use some functions before tooltip_test_set or tooltip_content_cb_set

Summary:
If user call tooltip_orient_set or tooltip_style_set or tooltip_window_mode_set
before tooltip_test_set or tooltip_content_cb_set, those functions doesn't work.
Because elm_tooltip will be created when tooltip_content_cb_set is called.
I fixed logic to use some functions before tooltip_test_set or tooltip_content_cb_set.

Test Plan: elementary_test -> Popups -> Tooltip

Reviewers: jpeg, Jaehyun

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5183

Change-Id: Ia058679cd1645a12e048d8c5b0db0566f2742fca
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
6 years agoelm_conform: consider window's geometry while reflecting keyboard conformant geometry 35/150235/1 accepted/tizen/unified/20170921.072252 submit/tizen/20170920.082902
Doyoun Kang [Fri, 15 Sep 2017 00:30:21 +0000 (09:30 +0900)]
elm_conform: consider window's geometry while reflecting keyboard conformant geometry

There was a bug that the partial window was resized when the keyboard was shown on landscape mode.
So, we add code to consider window's geometry while calculating conformant's geometry.

Change-Id: Iaa895335ddbc78697044f6712e7477317f4d3758

6 years agoatspi: enhance _accessible_at_point_get 95/149995/2 submit/tizen/20170915.074959
Shinwoo Kim [Wed, 13 Sep 2017 12:34:44 +0000 (21:34 +0900)]
atspi: enhance _accessible_at_point_get

The _elm_widget_elm_interface_atspi_component_accessible_at_point_get is
seaching accessible object from bottom of tree.

If elm_popup, or elm_panel comes as a root object, then
the _elm_widget_elm_interface_atspi_component_accessible_at_point_get does not
search from bottom of tree.

To make seach logic consistent, we are using bottom-up approach first for both
elm_popup and elm_panel from this patch.

Change-Id: I2a31725e8ff69455b836d6f888e0b42695ad2af5

6 years agoelm_win: do deferred resize job first before calling rotation change callback 62/149562/4
Doyoun Kang [Tue, 12 Sep 2017 12:20:17 +0000 (21:20 +0900)]
elm_win: do deferred resize job first before calling rotation change callback

there was a bug that the elm_win didn't resize when an user called evas_object_resize
with previous width and height in "wm,rotation,changed" smart callback function.

Change-Id: I8ac58abbb51e4e4135ff742c1c8a77e0c246ac7d

6 years agoatspi: enhance _accessible_at_point_top_down_get 32/149332/1
Shinwoo Kim [Tue, 12 Sep 2017 05:44:39 +0000 (14:44 +0900)]
atspi: enhance _accessible_at_point_top_down_get

If there is only one valid child at point, then return it.
The evas_tree_objects_at_xy_get could not find proper object,
if application does not have well aligned objects.

This could be a role of application, but this patch set could solve somehow.

Change-Id: I6326a23b88904f6003a99e8b17885452890c7222

6 years agogenlist: re-focus on genlist in item focus set when sub-object was focused 12/146412/9
SangHyeon Jade Lee [Mon, 28 Aug 2017 10:55:05 +0000 (19:55 +0900)]
genlist: re-focus on genlist in item focus set when sub-object was focused

Change-Id: I6de90b593dc0e251bc401bdd245dcfb507a90a98
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoatspi: enhance po file to translate "Alert" 83/148883/2
Shinwoo Kim [Mon, 11 Sep 2017 05:33:41 +0000 (14:33 +0900)]
atspi: enhance po file to translate "Alert"

There was no information to translate "Alert".

Change-Id: I339548b707d2d34df77dcc36774d0a4665854e63

6 years agoatspi: follow edje_entry logic to send anchor name 76/148876/2
Shinwoo Kim [Mon, 11 Sep 2017 05:29:46 +0000 (14:29 +0900)]
atspi: follow edje_entry logic to send anchor name

The edje_entry has logic remove unnecessary character.
The elm_entry is following the logic to give correct information.

Change-Id: I55114193d9b23117ddc8b9863c2b14741f42a215

6 years agoatspi: emit signal after atspi bridge is connected 70/148770/2
Shinwoo Kim [Sun, 10 Sep 2017 00:50:21 +0000 (09:50 +0900)]
atspi: emit signal after atspi bridge is connected

This patch set emitting popup SHOWING signal, and window ACTIVE signal after
the atspi bridge is connectted.

The SHOWING signal of popup does not work properly, if the popup shows before
the atspi bridge is not connected. In this case, the screen-reader cannot read
popup information. So the SHOWING signal should be emitted after the connection
is established.

The ACTIVE signal does not work properly in the following case.
There are two windows show in one process at the same time. In this case,
the ACTIVE signal was not emitted because window_activated_broadcast_needed is
set to EINA_FALSE. This would be a bug.

Change-Id: Ieb1883c94c2570fdb92b9770a1c20e7d95c27a60

6 years agoatspi : Fix "bring_in" of the genlist item in wearable profile 72/148672/2
JunsuChoi [Fri, 8 Sep 2017 09:13:05 +0000 (18:13 +0900)]
atspi : Fix "bring_in" of the genlist item in wearable profile

Change-Id: I440fa9e8583e6b8d0089c64c7d15bce717155ec1

6 years agogenlist: initialize process size when item is loaded 19/145119/5
SangHyeon Jade Lee [Mon, 21 Aug 2017 09:48:19 +0000 (18:48 +0900)]
genlist: initialize process size when item is loaded

Change-Id: I6d983a56fae403444ffe55a68e276a5e4e42355e
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agonaviframe: Fix to finish transition for newly pushed item 67/148067/2
Jaehyun Cho [Wed, 6 Sep 2017 11:04:41 +0000 (20:04 +0900)]
naviframe: Fix to finish transition for newly pushed item

Suppose naviframe top item is "A" and a new item "B" is newly pushed.
In this case, if "A" is deleted by elm_object_item_del() before
transition for "B" is started, then signal for "B" is also not sent and
"B" does not become visible.

The above issue happened if the transition effect was implemented by
using deferred signals (i.e. "pushed,deferred" and "popped,deferred").

To resolve the above issue, the signal only for the deleted item is not
sent.

Suppose naviframe top item is "A" and a new item "B" is newly pushed.
In this case, if "B" is deleted by elm_object_item_del() before
transition for "B" is started, then signal for "A" is still sent and "A"
becomes invisible.

To resolve the above issue, if the deleted item is the top item and it
is in the middle of item push, then all the signals related to the
deleted item are not sent.

Change-Id: I33c9f5039a8d3a3e5c60259a14edae395503ddd8

6 years agoatspi: remove unacceptable leaf node 13/148713/2
Shinwoo Kim [Fri, 8 Sep 2017 07:46:32 +0000 (16:46 +0900)]
atspi: remove unacceptable leaf node

An object could have children which have same position.
In this case, if first child of this object is not acceptable leaf node, then
there is no chance to find second child object.

Change-Id: If6887dc04bce4590ab4123cb79914172b5a4ca48

6 years agoelm_color_class: add missing return value 25/148625/1
Jaeun Choi [Fri, 8 Sep 2017 07:15:41 +0000 (16:15 +0900)]
elm_color_class: add missing return value

Change-Id: I76e3bf28d2269c68a88fa02118a554d1a7b727ec

6 years agoatspi: expose API 37/148437/1
Shinwoo Kim [Fri, 8 Sep 2017 02:30:30 +0000 (11:30 +0900)]
atspi: expose API

elm_atspi_accessible_relationships_clear

Change-Id: I297d379744f8df17d833d3b4172a0f70aba4e655

6 years agoatspi: remove memory leak 57/148057/2
Shinwoo Kim [Wed, 6 Sep 2017 11:09:26 +0000 (20:09 +0900)]
atspi: remove memory leak

The _elm_util_mkup_to_text gives alloacated plain text.
This plain text should be freed.

Change-Id: I4fe6443a2be78a80b00e79925b9ac968e489df76

6 years agoatspi: use entry text and parent accessible name 84/147784/2
Shinwoo Kim [Tue, 5 Sep 2017 13:42:50 +0000 (22:42 +0900)]
atspi: use entry text and parent accessible name

(1) The entry is using entry text for its accessible name.
(2) It is possible to overwrite default accessible name of entry by using
parent accessible name.

Change-Id: I29cdfe0fd6c517d9611ad46996eebe40c7be27e9

6 years agoatspi: find valid child of list item 61/147761/4
Shinwoo Kim [Tue, 5 Sep 2017 11:53:29 +0000 (20:53 +0900)]
atspi: find valid child of list item

This patch set is solving following case.
If genlist item uses evas_object_image_source_set to show item itself, then
evas_tree_objects_at_xy_get does not return below objects of image source.
So content objects of genlist item could not become cadicdates for
elm_interface_atspi_component_accessible_at_point_get.

@tizen_fix

Change-Id: I44e52b48054cf80fd102131c7f199a6b62a0464d

6 years agoelm_panel: set content as a sub object of panel object 39/147639/3
Jaeun Choi [Tue, 5 Sep 2017 07:14:37 +0000 (16:14 +0900)]
elm_panel: set content as a sub object of panel object

since sd->bx is not an elm object, it is excluded from parent-child tree.
in case of a non-scrollable panel, the content needs to be attached to the tree
as a child of panel object directly.

Change-Id: I32b65fc2e2b213e510c3060ac877a4361653191a
origin: upstream (61381f6e3584118a70565eea79c355dd049b9e28)

6 years agoatspi: use elm_entry to call smart callback 61/147561/4
Shinwoo Kim [Tue, 5 Sep 2017 02:13:28 +0000 (11:13 +0900)]
atspi: use elm_entry to call smart callback

This patch set is using elm_entry to call "anchor,clicked" smart callback.
The elm_access for anchor has been used so far, so the "anchor,clicked" smart
callback did not work.

Change-Id: If09400e78a9fc488e307fd46e67b39bf6beeca19

6 years ago[atspi][panel] Adds accessibility support for the panel widget. 66/143266/14 accepted/tizen/unified/20170907.060509 submit/tizen/20170906.050545
JunsuChoi [Wed, 9 Aug 2017 07:41:47 +0000 (16:41 +0900)]
[atspi][panel] Adds accessibility support for the panel widget.

   Panel handles similar popups.
   When open or close it sends signal to screen-reader.

Change-Id: Id4eade0d7989b17f3444ff794e812597859340dd

6 years ago[ATSPI] Add to find genlist item using proxy image 05/146905/6
JunsuChoi [Thu, 31 Aug 2017 05:56:37 +0000 (14:56 +0900)]
[ATSPI] Add to find genlist item using proxy image

   In a wearable profile, genlist displays the item using a proxy image.
   When a screen-reader finds an object in the top_down, it can not find the item.
   because, found item is proxy image.
   So, using evas_object_image_source_get and gets item view object from proxy image.

Change-Id: Ifbd278c30380d72c08ff5b86c9f12680bb0b7974

6 years agoatspi: make highlight frame be a smart member 62/147162/4
Shinwoo Kim [Fri, 1 Sep 2017 07:35:55 +0000 (16:35 +0900)]
atspi: make highlight frame be a smart member

Make highlight frame object be a smart member of target object.
There are two cases covered by this commit.

1. ctxpopup of copy & paste module.
The ctxpopup item has higher object layer than highlight frame object.
In this case, the highlight frame is covered by the ctxpopup item.

2. genlist item proxy object.
The genlist item shows its proxy object(handled by evas_object_image_source*).
In this case, the highlight frame has improper position, and size.

Change-Id: I2b6470a8a695ea3739ddf80832e837dbd2c0d1f8

6 years agonaviframe: Fix to load default style if the given style does not exist 34/146934/1
Jaehyun Cho [Thu, 31 Aug 2017 07:21:08 +0000 (16:21 +0900)]
naviframe: Fix to load default style if the given style does not exist

Naviframe item theme name is combined with item style name and widget
style name.
Therefore, if the item theme name is not found, then "item/basic" item
style name should be loaded as a default item style name.

Change-Id: I16d788ef41f2bd9668b50adf59175802dd715872

6 years agodocs: Add information about texture size limitations 67/145867/1 accepted/tizen/4.0/unified/20170901.203246 accepted/tizen/unified/20170825.043925 submit/tizen/20170824.100259 submit/tizen_4.0/20170830.022557 submit/tizen_4.0/20170901.042111
Myoungwoon Roy, Kim [Thu, 24 Aug 2017 04:57:05 +0000 (13:57 +0900)]
docs: Add information about texture size limitations

Summary: I had added some information about texture size limitations to Elm image API reference.

Test Plan: Doxygen Revision

Reviewers: raster, cedric, stefan, jpeg, Jaehyun_Cho

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D5106

Change-Id: I5372b83b4e9e736813a679da5c885a95b273a0f8

6 years agoelm_spinner: Maintainance API internal logic. 19/145819/1
Woochan Lee [Thu, 24 Aug 2017 04:27:47 +0000 (13:27 +0900)]
elm_spinner: Maintainance API internal logic.

Change fmt value in the API can break compatibility.

Change-Id: I94e2c9832f907c714653a43aa63cc9ac6c2584eb

6 years agoelm_spinner: Support min,max filter for float format case. 29/145729/2
Woochan Lee [Wed, 23 Aug 2017 11:40:25 +0000 (20:40 +0900)]
elm_spinner: Support min,max filter for float format case.

Summary: The previous min, max filter doesn't support float format case.

Test Plan: elementary_test -> spinner.

Reviewers: jpeg, cedric, woohyun, myoungwoon

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5016

Change-Id: I60f97c1e8e27f9c3d09f85a5a4e0ccbb347d28e2

6 years agoelm_datetime: Add 'O' character to ignore POSIX alternative format in format. 21/145721/2
Woochan Lee [Wed, 23 Aug 2017 10:52:14 +0000 (19:52 +0900)]
elm_datetime: Add 'O' character to ignore POSIX alternative format in format.

Summary:
_parse_format() function filtering "_/-/0/^/*" to filter POSIX alternatvie/extension formats,
But the Datetime do not appear in some locale(fa_IR, lzh_TW, my_MM, or_IN) with 'O'.

+ improve code. (not compare with all of the characters. instead of that using strchr)

https://lh.2xlibre.net/values/d_t_fmt/

@fix

Test Plan: Set locale as fa_IR and create DateTime. and see fields, not appears.

Reviewers: jpeg, cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5020

Change-Id: I5c64f301324834b771c452c9cf39da6faa782274

6 years agoelm_datetime: Parses the format recursively. 23/145723/2
Woochan Lee [Wed, 23 Aug 2017 11:02:38 +0000 (20:02 +0900)]
elm_datetime: Parses the format recursively.

Summary:
Some of locale formats convert as extension format.
For example,
             uk_UA d_t_fmt is "%a, %d-%b-%Y %X %z".
             The %X will convert as %T.
             The %T format has to convert one more time to convert as %H:%M:%S.

ref : https://lh.2xlibre.net/locale/uk_UA/

We need to parse the format recursively to support that kind of case.

@fix

Test Plan:
Change the locale as uk_UA.
Run elementary_test -> datetime
See the time field is not appear.

Reviewers: jpeg, cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5021

Change-Id: Ie088a4558d3688542e9bcf43dacd1a9a339b433e

6 years agotest_check: fix build warning 08/145608/1
JinYong Park [Wed, 23 Aug 2017 05:54:59 +0000 (14:54 +0900)]
test_check: fix build warning

In state_changed_cb2 callback function, obj is used. so it should not be EINA_UNUSED

https://phab.enlightenment.org/D5122

Change-Id: Ib6509a3bb895278aee03985f759a606b5adce31f
Signed-off-by: JinYong Park <j4939.park@samsung.com>
6 years agolayout: call size calculating after text_set(NULL) 02/143702/7
JinYong Park [Fri, 11 Aug 2017 04:51:26 +0000 (13:51 +0900)]
layout: call size calculating after text_set(NULL)

Summary

When text set NULL, size is not changed even text is removed.
So, fix that case logic

1. send text,hidden signal
2. remove text
3. call sizing eval to resize layout

Test Plan

1. run elementary_test -to check
2. change value last check object
3. compare before and after

https://phab.enlightenment.org/D5086

Change-Id: Ibe7450d3e8390a3f4bbb158f2d591236fc6de448
Signed-off-by: JinYong Park <j4939.park@samsung.com>
6 years agodocs: fix wrong descrpition in elm_progressbar API reference doxygen. 83/145383/1
Bowon Ryu [Tue, 22 Aug 2017 07:08:01 +0000 (16:08 +0900)]
docs: fix wrong descrpition in elm_progressbar API reference doxygen.

unit format default is NULL in Tizen.
so delete the description.

Change-Id: Ib2e7e9ed84fcd16bd88d8da64480800fcc685c4e
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
6 years agoelm_image: make "elm_image" visible in smart_show func regardless of preloading status 88/144888/1
Jaeun Choi [Fri, 6 Jan 2017 05:02:20 +0000 (14:02 +0900)]
elm_image: make "elm_image" visible in smart_show func regardless of preloading status

even though sd->img should be hidden while preloading,
the elm_image object itself need to be marked as visible
so related jobs can be done on elm_widget level.

Change-Id: I67e236df6d41e83bd7e9135e6005c05ea7a50728

6 years agoDatetime: Prevent null pointer reference. 55/144855/2
Woochan Lee [Fri, 18 Aug 2017 07:02:49 +0000 (16:02 +0900)]
Datetime: Prevent null pointer reference.

When _elm_datetime_items_get() calling with only time format after datetime creation.
The location has been swapped. so some of sorted_field index address gets a invalid
address. then it makes a crash.

@tizen_fix

Change-Id: I8e073237793d6af46a726be6cd51827f14c15661

6 years agonotify: fix show animation signal emit logic 34/141634/3
JinYong Park [Tue, 1 Aug 2017 07:27:18 +0000 (16:27 +0900)]
notify: fix show animation signal emit logic

Change-Id: Ia805528acfb3378af3cff68c249c1c86b8f55393
Signed-off-by: JinYong Park <j4939.park@samsung.com>
6 years agogenlist: process item block positioning before relative item deleted 34/144534/2
SangHyeon Jade Lee [Thu, 17 Aug 2017 06:14:46 +0000 (15:14 +0900)]
genlist: process item block positioning before relative item deleted

Change-Id: Iac552c946bd37e0abf551c1c74a6a08a3c6a5acc
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoelc_naviframe: set focus to new view immediately only for item push 63/143763/1 accepted/tizen/4.0/unified/20170828.222329 accepted/tizen/unified/20170821.051114 submit/tizen/20170816.060215 submit/tizen_4.0/20170828.100005
Jaehyun Cho [Fri, 11 Aug 2017 07:06:48 +0000 (16:06 +0900)]
elc_naviframe: set focus to new view immediately only for item push

Set focus to new item view immediately when new item is pushed to show
keypad fast. Otherwise, focus of new item view is set late and keypad is
shown late.

Setting focus to item view immediately is applied to item push only.
Because if this concept is applied to item pop, then the following focus
issue happens.

Reproduction path of the item pop focus issue
1. Naviframe first item view consists of two objects.
   Focus is in the second object of the first item view.
2. Naviframe push happens. (now two item views)
3. Popup appears and it gets the focus.
4. Popup button click pops the second naviframe item.
5. Focus goes to the naviframe and focus_next happens.
6. Focus is set to the first object of the first item view.
   (not to the second object of the first item view)

Change-Id: I1940831dbd9ce0cf8efcd6b2172203fa1ee277fc

6 years agoCast to double before division during region/coord calculation. 84/143684/3
Sungtaek Hong [Fri, 11 Aug 2017 02:59:34 +0000 (11:59 +0900)]
Cast to double before division during region/coord calculation.

int var devided by int is cast to double after devision.
This might cause wrong calculation result.

Change-Id: I32128f81cbfa78b1e42b3c03fa18e664e31732ef
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
6 years agoelm_scroller: focus_direction should not be called when scroller focusable and no... 01/143701/2
Jeonghyun Yun [Fri, 11 Aug 2017 04:48:06 +0000 (13:48 +0900)]
elm_scroller: focus_direction should not be called when scroller focusable and no focusable child

Summary:
when scroller can have focus and scroller's child can't have focus,
there is a problem that scroller is always selected to next focus object.
In this case, it should not enter into _elm_scroller_elm_widget_focus_direction()

Reviewers: woohyun

Reviewed By: woohyun

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5085

Change-Id: I235dbd87e28118295ef4150817deddec50c84fbe
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
6 years agoRevert "interface_scrollable: Fix not hold the flag on mouse down" 17/143717/1
Wonki Kim [Fri, 11 Aug 2017 05:16:48 +0000 (14:16 +0900)]
Revert "interface_scrollable: Fix not hold the flag on mouse down"

This reverts commit 012537f1e5cb2355940c7cf15c75027e3fbc6c2c.

Change-Id: I86e61f88c2cea008383ecb6fcd395c11a52c6b62
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agotest_gesture_layer3: fix typo 21/143021/2
Jaeun Choi [Tue, 8 Aug 2017 07:48:58 +0000 (16:48 +0900)]
test_gesture_layer3: fix typo

this typo was detected by SVACE

Change-Id: I3e32a058a0ddf7f4f22bac1106dc05698ff185a6
origin: upstream (52368bf463c2b5ea7b69e15a7e34b1ea13258ca1)

6 years agotest_gesture_layer: fix typo 99/142999/2
Jaeun Choi [Tue, 8 Aug 2017 06:43:15 +0000 (15:43 +0900)]
test_gesture_layer: fix typo

this typo was detected by SVACE

Change-Id: I6b005aede302598dfe1f4af7fb38199dc4371b12
origin: upstream (a9fdcc4cc2f5567fbc05ae418c4e3a4d13286f45)

6 years agoelm_color_class: add null checking after memory allocation 40/143240/2
Jaeun Choi [Wed, 9 Aug 2017 07:16:35 +0000 (16:16 +0900)]
elm_color_class: add null checking after memory allocation

origin: upstream (15bbf4712ee1e9356fa975de6f2861bc5ce3076a)

Change-Id: Id9b82282635f8b722f6d282f3d0e84ee98aafdb0

6 years agoelm_dbus_menu: add null checking after memory allocation 42/143242/2
Jaeun Choi [Wed, 9 Aug 2017 07:21:03 +0000 (16:21 +0900)]
elm_dbus_menu: add null checking after memory allocation

Change-Id: I43d0a47eb8d382007b6a9ed1d877415ad37ed52d
origin: upstream (0927221c1a0e26b7fe006eb3110ca2bffd671b89)

6 years agoelm_gesture_layer: add null checking after memory allocation 46/143246/2
Jaeun Choi [Wed, 9 Aug 2017 07:28:42 +0000 (16:28 +0900)]
elm_gesture_layer: add null checking after memory allocation

Change-Id: Ib504732e21203c414bb1e58936788e84da23cba9
origin: upstream (41ea255002d93d285da331e2452488c8f6088f1f)

6 years agoelm_gesture_layer_extra_gestures: add null checking after memory allocation 53/143253/2
Jaeun Choi [Wed, 9 Aug 2017 07:32:36 +0000 (16:32 +0900)]
elm_gesture_layer_extra_gestures: add null checking after memory allocation

Change-Id: Ifc32e16b0489685d154b35c2d3f7a4cd71409e14
origin: upstream (db33efb79238f5843251795ff193773bd36c83b1)

6 years agoelm_prefs_data: add null checking after memory allocation 55/143255/2
Jaeun Choi [Wed, 9 Aug 2017 07:36:13 +0000 (16:36 +0900)]
elm_prefs_data: add null checking after memory allocation

Change-Id: Ia14b6585a030fe598a9e09dc16ddc27dd1d789df
origin: upstream (38abae53c0a5aca320984475c82fc6f6f5ae048b)

6 years agotest_gesture_layer: add null checking after memory allocation 60/143260/2
Jaeun Choi [Wed, 9 Aug 2017 07:39:54 +0000 (16:39 +0900)]
test_gesture_layer: add null checking after memory allocation

Change-Id: Id45ecd0d3ebc4d49cab51f36f319feb813d2d828
origin: upstream (6641c07262085faf062679a21659ff7b45b05a67)

6 years agotest_gesture_layer2: add null checking after memory allocation 61/143261/2
Jaeun Choi [Wed, 9 Aug 2017 07:43:27 +0000 (16:43 +0900)]
test_gesture_layer2: add null checking after memory allocation

Change-Id: Ic733f8e173d1a0ca4c90479961b05fb27f8b3b4b
origin: upstream (530455fcee4767ce17ba56200b13dc688b64857a)

6 years agotest_gesture_layer3: add null checking after memory allocation 72/143272/2
Jaeun Choi [Wed, 9 Aug 2017 07:49:15 +0000 (16:49 +0900)]
test_gesture_layer3: add null checking after memory allocation

Change-Id: I0d189511e9c65496d23a7799631f37513f16c690
origin: upstream (c311dc638b8358f27664fba3985d9212748cf92a)

6 years agotizen_vector: Fixed the integer division issue. 47/143647/1
smohanty [Fri, 11 Aug 2017 00:14:08 +0000 (09:14 +0900)]
tizen_vector: Fixed the integer division issue.

Change-Id: Ib17b7a440cdc5807059774ddd0031e17b42be400

6 years agoelc_naviframe: Use tizen_effect_cancel from naviframe_effect module 05/143405/3
Jaehyun Cho [Wed, 9 Aug 2017 13:37:26 +0000 (22:37 +0900)]
elc_naviframe: Use tizen_effect_cancel from naviframe_effect module

Use tizen_effect_cancel API from naviframe_effect module to cancel push
effect when a newly pushed item is deleted before the push effect is
started.

Change-Id: Ia3d89bda1b4f128a80c1cf78e3ac33e34c564dc2

6 years agogenlist : fix re-calculate on language changed 12/143512/2
SangHyeon Jade Lee [Thu, 10 Aug 2017 07:37:04 +0000 (16:37 +0900)]
genlist : fix re-calculate on language changed

Change-Id: I3a599c45228e652624d38fa8f73db45de084c35e
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoelc_naviframe: Fix to handle item deletion right after item push 04/143404/2
Jaehyun Cho [Wed, 9 Aug 2017 14:32:35 +0000 (23:32 +0900)]
elc_naviframe: Fix to handle item deletion right after item push

If an item is deleted right after the item is newly pushed, the push
transition should not happen for both the new item and the current item.

Change-Id: Iba5b9547aae8b3916e76d9e7af3e9250229c563b

6 years agoelm_ctxpopup: Implemented elm_widget_item_del_pre for elm_ctxpopup_item 75/143475/1
Jeonghyun Yun [Thu, 10 Aug 2017 05:22:48 +0000 (14:22 +0900)]
elm_ctxpopup: Implemented elm_widget_item_del_pre for elm_ctxpopup_item

ctxpopup item have elm_list item internally.
But when elm_ctxpopup item was deleted, elm_list item was not deleted.
elm_list item in elm_ctxpopup item should be deleted in del_pre
when elm_ctxpopup item is deleted by elm_wdg_item_del()

Test Plan:
1. launch elementary_test - ctxpopup
2. click Ctxpopup with label only
3. "Never Show" item should not shown in ctxpopup

Reviewers: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5044

Change-Id: I2264a3efbb3050017b89cbbd087042d35eb8830d
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
6 years agoelm_object_item: update pre_notify_del document 58/142758/4 accepted/tizen/unified/20170810.172528 submit/tizen/20170810.044648
SangHyeon Jade Lee [Mon, 7 Aug 2017 07:36:47 +0000 (16:36 +0900)]
elm_object_item: update pre_notify_del document

Change-Id: Ie9a2e6e20fa60449b934c870b98e55aa82d2df5c
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agogengrid: fix integer division type casting warning 70/142070/2
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:50:20 +0000 (19:50 +0900)]
gengrid: fix integer division type casting warning

Change-Id: I1c7db5310a4edb16f4fda13e2ce19c71e8389741
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agogengrid: fix wrong access info returns in access info set 65/142065/3
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:31:10 +0000 (19:31 +0900)]
gengrid: fix wrong access info returns in access info set

Change-Id: I66478fee1468c1f57cddbf7ba9fd8c98344de161
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoAdd null check for svace issues 14/142914/2
JunsuChoi [Tue, 8 Aug 2017 01:17:39 +0000 (10:17 +0900)]
Add null check for svace issues

   Add null check because alloc function could return null

Change-Id: Ife8a3cc2cf48ba176e7e94c50c7d78bb2329fc6b

6 years agolayout: fix "elm,state,text,hidden" signal never be emitted 78/142878/2
JinYong Park [Mon, 7 Aug 2017 11:51:40 +0000 (20:51 +0900)]
layout: fix "elm,state,text,hidden" signal never be emitted

In _elm_layout_text_set function, text_signal_emit is called.
But in that case, check text whether it is null or not null before call signal_emit.
So "text" is not null always, and text_signal_emit's parameter "visible" is also always EINA_TRUE.

opensource link : https://phab.enlightenment.org/D5049

Change-Id: I0decfc0144c7e13e4706ca90aa38824921ee4673
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agoRevert "Fix Svace issuese." 76/142876/2
woochan lee [Mon, 7 Aug 2017 11:29:07 +0000 (11:29 +0000)]
Revert "Fix Svace issuese."

This reverts commit 7b2fe927cbf3bd4a50d9da61de48e437d81ee383.

Change-Id: I7fcfe87b8d0c8a340704f8eb67969df4cfbda3d1

6 years agoRevert "Fix Svace issue." 74/142874/1
woochan lee [Mon, 7 Aug 2017 11:28:56 +0000 (11:28 +0000)]
Revert "Fix Svace issue."

This reverts commit 3798e5047e98c27c62b483d3059ec2b23f8221ab.

Change-Id: I74e6d1970415337af0e73d3bbe0a5b66b5d1b92d

6 years agoFix Svace issue. 91/142791/2
Woochan Lee [Mon, 7 Aug 2017 08:31:04 +0000 (17:31 +0900)]
Fix Svace issue.

Change-Id: I5559eabddbb9bb3034ba9eea8fec1aadb2f6d3d8

6 years agoFix Svace issuese. 72/142772/2
Woochan Lee [Mon, 7 Aug 2017 08:07:00 +0000 (17:07 +0900)]
Fix Svace issuese.

Change-Id: I9a2f66edbe51908735315fbf859dc1a0d7641252

6 years agoDatetime: Apply UI Mirroring for Tizen 4.0 61/142761/1
Woochan Lee [Mon, 7 Aug 2017 07:42:35 +0000 (16:42 +0900)]
Datetime: Apply UI Mirroring for Tizen 4.0

The datetime is not including UI Mirroring feature.

Change-Id: Iacdf0bf589e328a7ef3902555e92d11f505492ff

6 years agoFix accessbility mode doxygen warning 75/142475/3
Myoungwoon Roy, Kim [Fri, 4 Aug 2017 05:20:03 +0000 (14:20 +0900)]
Fix accessbility mode doxygen warning

Summary:
Fix 4.0 API Reference Doxygen warnings.

Change-Id: I3f38685943efeb790422338de2c1f77311b686a0

6 years agoatspi: do not accept invisible object 43/142243/2
Shinwoo Kim [Thu, 3 Aug 2017 06:46:25 +0000 (15:46 +0900)]
atspi: do not accept invisible object

Issue:
If an object is child of scrollable parent, then the object is accepted even
though the object is invisible.

Solution:
Do not accept invisible object.

Change-Id: I0492eb9f5f265211521f066acd6f56d9c24356c0

6 years agoatspi: enhance elm_atspi_gesture_cb_set document 28/142228/3
Shinwoo Kim [Thu, 3 Aug 2017 06:23:13 +0000 (15:23 +0900)]
atspi: enhance elm_atspi_gesture_cb_set document

Change-Id: Ib6ff7016389bf9b6252c517c2565839e5f5943d1

6 years agoatspi: handle "gesture_required" attribute 05/142105/7
Shinwoo Kim [Wed, 2 Aug 2017 12:15:56 +0000 (21:15 +0900)]
atspi: handle "gesture_required" attribute

The elementary sends the "detail2" information highlight based on the attribute
"gesture_required" when an object grabs.

If an object has attribute key "gesture_required", and "scroll" for its value,
then the "detail2" is 1. Otherwise, the "detail2" is 0.

The screen-reader AT client calls "ObjectNeedsScrollGesture" method of
e-mod-tizen-screen-reader window manager module with object geometry value,
if the "detail2" is 1. Otherwise, the object geometry value is not used.

The e-mod-tizen-screen-reader window manager module will send mouse event
based on the object geometry.

Application side could use this feature setting attribute as below:
 - elm_atspi_accessible_attribute_append(btn, "gesture_required", "scroll");

This patch set depends on:
https://review.tizen.org/gerrit/#/c/142108/ (screen-reader)
https://review.tizen.org/gerrit/#/c/142107/ (e-mod-tizen-screen-reader)

Change-Id: I0b731ce947be569b2d782fdc21f18c79ffebf70e

6 years agolabel: set duration/speed for text marquee using internal functions 41/142441/2
Youngbok Shin [Fri, 4 Aug 2017 02:59:29 +0000 (11:59 +0900)]
label: set duration/speed for text marquee using internal functions

@tizen_feature

Change-Id: I3746364acd1818a9f0766ce18e029c8a3f70dc0d

6 years agocursor: remove a warning message from a unused static variable 37/142437/2
Youngbok Shin [Fri, 4 Aug 2017 02:45:14 +0000 (11:45 +0900)]
cursor: remove a warning message from a unused static variable

@tizen_fix

Change-Id: Icfcaf6e0c92aa259afae816313eb29550456d9f8

6 years agoelm_win: Match return type of function 01/142401/2
Wonki Kim [Thu, 3 Aug 2017 03:15:20 +0000 (12:15 +0900)]
elm_win: Match return type of function

this commit fix the svace warning

Change-Id: I9f3b00c35190808d1a2f641ed360bdb0d85f6dfe
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agoentry: remove a warning message caused by unused parameter for cbhm 63/142263/1
Youngbok Shin [Thu, 3 Aug 2017 07:39:18 +0000 (16:39 +0900)]
entry: remove a warning message caused by unused parameter for cbhm

@tizen_fix

Change-Id: Ib1f61049b4c7fc075ac9764642eca0a9e7cb358e

6 years agoatspi: suppress warning message 83/141983/3 accepted/tizen/4.0/unified/20170816.011516 accepted/tizen/4.0/unified/20170816.014745 accepted/tizen/unified/20170804.025559 submit/tizen/20170803.051344 submit/tizen_4.0/20170811.094300 submit/tizen_4.0/20170814.115522 submit/tizen_4.0_unified/20170814.115522
Shinwoo Kim [Wed, 2 Aug 2017 06:51:25 +0000 (15:51 +0900)]
atspi: suppress warning message

The following is warning message.

In function '_elm_genlist_elm_widget_screen_reader':
warning: declaration of 'l' shadows a previous local [-Wshadow]
              Eina_List *l;
                         ^
note: shadowed declaration is here
    Eina_List *l;

Change-Id: I8af5c5e4a49219bebccd2a51ddc0ddfc853f447f

6 years agoentry: remove unused label for goto 71/142071/1
Youngbok Shin [Wed, 2 Aug 2017 10:57:05 +0000 (19:57 +0900)]
entry: remove unused label for goto

@tizen_fix

Change-Id: I7ea5763432b9118eb7e33f20419be2e25ccf7a9f

6 years agoatspi: access overrides Accessible.state_set.get 76/141776/3
Shinwoo Kim [Tue, 1 Aug 2017 10:22:03 +0000 (19:22 +0900)]
atspi: access overrides Accessible.state_set.get

The elm_access a widget makes primitive object accessible. If a primitive
object is not visible, then the elm_access should NOT have state VISIBLE, and
SHOWING. From now the elm_access is checking visibility of primitive object.

Change-Id: I27c2f29d3346e03329784872281e4734ec753160

6 years ago elm_win: add ELM_WIN_SOCKET_IMAGE type check 14/142014/1
Jiyoun Park [Wed, 2 Aug 2017 08:04:06 +0000 (17:04 +0900)]
elm_win: add ELM_WIN_SOCKET_IMAGE type check

    elm_win_socket_listen api only work for ELM_WIN_SOCKET_IMAGE type window.
    So it is better to add type check code.

Change-Id: Id8b27ac5a7f78b7ac4bf97cf7b7fdd6a7a0b6ac0

6 years agoelm_win: Fix build warning 95/141995/2
Wonki Kim [Wed, 2 Aug 2017 07:23:02 +0000 (16:23 +0900)]
elm_win: Fix build warning

fix build warning on elm_win

Change-Id: I548a9d5bdfac569f3d97c07b48337ebb394aa9dc
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agoconform: Fix build warning 96/141996/2
Wonki Kim [Wed, 2 Aug 2017 07:22:30 +0000 (16:22 +0900)]
conform: Fix build warning

fix build warning on elm_conform

Change-Id: I61efd9675246a353e0f6fcdc35b8557455b77f74
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agointeface_scrollable: fix build warning 89/141989/2
Wonki Kim [Wed, 2 Aug 2017 07:06:29 +0000 (16:06 +0900)]
inteface_scrollable: fix build warning

fix build warning on interface_scrollable.c

Change-Id: I9f0d190b91bdda35a34b1d5bb9a8ec228ae6eae7
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agotoolbar: fix unused parameters. 69/141969/1
Bowon Ryu [Wed, 2 Aug 2017 06:30:54 +0000 (15:30 +0900)]
toolbar: fix unused parameters.

Change-Id: Iff64a42eb14f5ec25c773daebdeb09a809e4af12
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
6 years agogenlist : fix unused values and parameters 52/141952/2
SangHyeon Jade Lee [Wed, 2 Aug 2017 05:45:19 +0000 (14:45 +0900)]
genlist : fix unused values and parameters

Change-Id: Ic8bb3e04c275032afdfc26fefdae68df1f4a03aa
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agogenlist :fix wrong item paramenter pass on focus_set 31/141931/1
SangHyeon Jade Lee [Wed, 2 Aug 2017 04:46:00 +0000 (13:46 +0900)]
genlist :fix wrong item paramenter pass on focus_set

Change-Id: Ibe4e0e0709020e4d16788094854cb2ccdb187167
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoscroller: Initialize member variables which are used for unstable situation 78/140978/2
Wonki Kim [Thu, 8 Jun 2017 04:40:23 +0000 (13:40 +0900)]
scroller: Initialize member variables which are used for unstable situation

This commit inits member vars to set proper position
when scroller initialy comes out.

Change-Id: I3b5490cbcc38fe77e549d152a7e4c666b6c4a518
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agomultibuttonentry: Fix item resource clean up logic. 18/141018/1
Woochan Lee [Thu, 27 Jul 2017 13:08:22 +0000 (22:08 +0900)]
multibuttonentry: Fix item resource clean up logic.

Summary:
There are four cases where items are deleted.

1. Select item and push back button.
2. Delete "X" part of item.
3. Calling elm_object_item_del().
4. MBE deleted.

Previous logic is can't support for all cases.

below problems were there.

eina_list_remove() called twice.
list data free twice.

@fix

Test Plan: elementary_test -> multibuttonentry test.

Reviewers: jpeg, cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5030

Change-Id: I523afadb2c767b42ecc253f6b691e4de512c1199

6 years agoatspi: grab highlight using unrealized item 96/140296/2 accepted/tizen/unified/20170728.195337 submit/tizen/20170727.055818
Shinwoo Kim [Mon, 24 Jul 2017 10:11:48 +0000 (19:11 +0900)]
atspi: grab highlight using unrealized item

The looping naviation could make the first(or last) item grab highlight.
But the _elm_widget_item_elm_interface_atspi_component_highlight_grab returns
without setting highlight if sd->view is NULL that means the item is NOT
realized in case of genlist.
So the _elm_genlist_item_elm_interface_atspi_component_highlight_grab BRINGs
the first(or last) item IN first before grabbing highlight.

Change-Id: Id36716d1e2d6249532d67dede9357e152b3d3107

6 years agoatspi: genlist - remove unnecessary lines 47/139847/5
Shinwoo Kim [Thu, 20 Jul 2017 23:46:34 +0000 (08:46 +0900)]
atspi: genlist - remove unnecessary lines

Looping navigation could make first object grab highlight.
If the first object is unrealized genlist item, the genlist item will be
realized. While the first genlist item is realized, genlist calculation logic
makes the first genlist item unhighligted, and gives highlight to next proper
genlist item based on geometry value. See the following backtrace.

※ Backtrace
0  elm_interface_atspi_component_highlight_grab
1  in _item_position
2  in _item_all_position
3  in _item_block_realize
4  in _elm_genlist_pan_evas_object_smart_calculate
5  in evas_obj_smart_calculate
6  in ?? () from target:/lib/libevas.so.1
7  in ?? () from target:/lib/libevas.so.1
8  in ?? () from target:/lib/libevas.so.1
9  in evas_canvas_render_async
10 in evas_render_async
11 in ?? () from target:/lib/ecore_evas/engines/wayland/v-1.16/module.so
12 in ?? () from target:/lib/libecore_evas.so.1
13 in ?? () from target:/lib/libecore.so.1
14 in ?? () from target:/lib/libecore.so.1
15 in ecore_main_loop_begin () from target:/lib/libecore.so.1
16 in elm_run () at elm_main.c:1128
17 in ?? () from target:/usr/lib/libappcore-efl.so.1
18 in appcore_base_init () from target:/lib/libappcore-common.so.1
19 in appcore_ui_base_init () from target:/lib/libappcore-ui.so.1
20 in appcore_efl_base_init () from target:/usr/lib/libappcore-efl.so.1
21 in ?? () from target:/usr/lib/libcapi-appfw-application.so.0
22 in ui_app_main () from target:/usr/lib/libcapi-appfw-application.so.0
23 in main () from target:/usr/apps/org.tizen.watch-setting/bin/watch-setting
24 in _start ()

It seems that this is a mistake of commit migration from Tizen 3.0
to Tizen 4.0. So the lines should be removed.

※ migration commit: d8bdb91a65cb678258ac3704d11610520aa8948d

Change-Id: Ib5a58b8959828ad47867298338a40c76b4417bf7

6 years agogenlist : fix build warnings 14/140314/2
SangHyeon Jade Lee [Mon, 24 Jul 2017 11:30:42 +0000 (20:30 +0900)]
genlist : fix build warnings

Change-Id: I342307152e8eb94517a1d37b5d5ddc8625992262
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoelm_plug: remove unused variable 44/140344/1
Thiep Ha [Mon, 24 Jul 2017 22:35:49 +0000 (07:35 +0900)]
elm_plug: remove unused variable

Change-Id: Ifeabbe326dfdd82d1c3a3a12a945666a8e525c07

6 years agocopypaste: remove build warning 05/140305/2
Minchul Lee [Mon, 24 Jul 2017 11:02:22 +0000 (20:02 +0900)]
copypaste: remove build warning

Change-Id: I596f1080cd93d16d9154dcfe5649db9525eb9177
Signed-off-by: Minchul Lee <slotus.lee@samsung.com>