2003-10-14 Havoc Pennington <hp@redhat.com>
authorHavoc Pennington <hp@redhat.com>
Tue, 14 Oct 2003 22:16:03 +0000 (22:16 +0000)
committerHavoc Pennington <hp@redhat.com>
Tue, 14 Oct 2003 22:16:03 +0000 (22:16 +0000)
commit3251264ac483680b4a5fe808729f7e3b34f41fd4
tree0b2a953be7b1a858c5759158e834de3d2d1b763e
parentb704a068a92c00b50e7d5f33ef6c8e1c3a87ceae
2003-10-14  Havoc Pennington  <hp@redhat.com>

* bus/bus.c (bus_context_check_security_policy): revamp this to
work more sanely with new policy-based requested reply setup

* bus/connection.c (bus_transaction_send_from_driver): set bus
driver messages as no reply

* bus/policy.c (bus_client_policy_check_can_receive): handle a
requested_reply attribute on allow/deny rules

* bus/system.conf: add <allow requested_reply="true"/>

* bus/driver.c (bus_driver_handle_message): fix check for replies
sent to the bus driver, which was backward. How did this ever work
at all though? I think I'm missing something.

* dbus/dbus-message.c (decode_header_data): require error and
method return messages to have a reply serial field to be valid
(_dbus_message_loader_queue_messages): break up this function;
validate that reply serial and plain serial are nonzero;
clean up the OOM/error handling.
(get_uint_field): don't return -1 from this
(dbus_message_create_header): fix signed/unsigned bug

* bus/connection.c (bus_connections_expect_reply): save serial of
the incoming message, not reply serial
13 files changed:
ChangeLog
Makefile.am
bus/bus.c
bus/config-parser.c
bus/connection.c
bus/dbus-daemon-1.1.in
bus/driver.c
bus/policy.c
bus/policy.h
dbus/dbus-internals.c
dbus/dbus-message.c
doc/TODO
doc/dbus-specification.xml