Changelog
-Version 7.44.0 (11 Aug 2015)
+Version 7.59.0 (13 Mar 2018)
-Daniel Stenberg (11 Aug 2015)
-- RELEASE-NOTES: synced with c75a1e775061
+Daniel Stenberg (13 Mar 2018)
+- release: 7.59.0
-- [Svyatoslav Mishyn brought this change]
+Kamil Dudka (13 Mar 2018)
+- tests/.../spnego.py: fix identifier typo
+
+ Detected by Coverity Analysis:
+
+ Error: IDENTIFIER_TYPO:
+ curl-7.58.0/tests/python_dependencies/impacket/spnego.py:229: identifier_typo: Using "SuportedMech" appears to be a typo:
+ * Identifier "SuportedMech" is only known to be referenced here, or in copies of this code.
+ * Identifier "SupportedMech" is referenced elsewhere at least 4 times.
+ curl-7.58.0/tests/python_dependencies/impacket/smbserver.py:2651: identifier_use: Example 1: Using identifier "SupportedMech".
+ curl-7.58.0/tests/python_dependencies/impacket/smbserver.py:2308: identifier_use: Example 2: Using identifier "SupportedMech".
+ curl-7.58.0/tests/python_dependencies/impacket/spnego.py:252: identifier_use: Example 3: Using identifier "SupportedMech" (2 total uses in this function).
+ curl-7.58.0/tests/python_dependencies/impacket/spnego.py:229: remediation: Should identifier "SuportedMech" be replaced by "SupportedMech"?
+
+ Closes #2379
- curl_formget.3: correct return code
+Daniel Stenberg (13 Mar 2018)
+- CURLOPT_COOKIEFILE.3: "-" as file name means stdin
+
+ Reported-by: Aron Bergman
+ Bug: https://curl.haxx.se/mail/lib-2018-03/0049.html
- Closes #375
+ [ci skip]
-- [Svyatoslav Mishyn brought this change]
+- Revert "hostip: fix compiler warning: 'variable set but not used'"
+
+ This reverts commit a577059f92fc65bd6b81717f0737f897a5b34248.
+
+ The assignment really needs to be there or we risk working with an
+ uninitialized pointer.
- libcurl-tutorial.3: fix formatting
+Michael Kaufmann (12 Mar 2018)
+- limit-rate: fix compiler warning
- Closes #374
+ follow-up to 72a0f62
-- [Svyatoslav Mishyn brought this change]
+Viktor Szakats (12 Mar 2018)
+- checksrc.pl: add -i and -m options
+
+ To sync it with changes made for the libssh2 project.
+ Also cleanup some whitespace.
- curl_easy_recv.3: fix formatting
+- curl-openssl.m4: fix spelling [ci skip]
-- [Anders Bakken brought this change]
+- FAQ: fix a broken URL [ci skip]
- http2: discard frames with no SessionHandle
+Daniel Stenberg (12 Mar 2018)
+- http2: mark the connection for close on GOAWAY
- Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
- SessionHandle. Apparently mod_h2 will sometimes send a frame for a
- stream_id we're finished with.
+ ... don't consider it an error!
- Use nghttp2_session_get_stream_user_data and
- nghttp2_session_set_stream_user_data to identify SessionHandles instead
- of a hash.
-
- Closes #372
+ Assisted-by: Jay Satiro
+ Reported-by: Łukasz Domeradzki
+ Fixes #2365
+ Closes #2375
-- RELEASE-NOTES: synced with 9ee40ce2aba
+- credits: Viktor prefers without accent
-- [Viktor Szakats brought this change]
+- openldap: white space changes, fixed up the copyright years
- build: refer to fixed libidn versions
+- openldap: check ldap_get_attribute_ber() results for NULL before using
- closes #371
+ CVE-2018-1000121
+ Reported-by: Dario Weisser
+ Bug: https://curl.haxx.se/docs/adv_2018-97a2.html
-- Revert "configure: disable libidn by default"
+- FTP: reject path components with control codes
- This reverts commit e6749055d65398315fd77f5b5b8234c5552ac2d3.
+ Refuse to operate when given path components featuring byte values lower
+ than 32.
- ... since libidn has since been fixed.
-
-- [Jakub Zakrzewski brought this change]
-
- CMake: s/HAVE_GSS_API/HAVE_GSSAPI/ to match header define
+ Previously, inserting a %00 sequence early in the directory part when
+ using the 'singlecwd' ftp method could make curl write a zero byte
+ outside of the allocated buffer.
- Otherwise the build only pretended to use GSS-API
+ Test case 340 verifies.
- Closes #370
+ CVE-2018-1000120
+ Reported-by: Duy Phan Thanh
+ Bug: https://curl.haxx.se/docs/adv_2018-9cd6.html
-- SFTP: fix range request off-by-one in size check
+- readwrite: make sure excess reads don't go beyond buffer end
- Reported-by: Tim Stack
+ CVE-2018-1000122
+ Bug: https://curl.haxx.se/docs/adv_2018-b047.html
- Closes #359
+ Detected by OSS-fuzz
+
+- BUGS: updated link to security process
-- test46: update cookie expire time
+- limit-rate: kick in even before "limit" data has been received
- ... since it went old and thus was expired and caused the test to fail!
+ ... and make sure to avoid integer overflows with really large values.
+
+ Reported-by: 刘佩东
+ Fixes #2371
+ Closes #2373
-Steve Holme (9 Aug 2015)
-- generate.bat: Use buildconf.bat for prerequisite file generation
+- docs/SECURITY.md -> docs/SECURITY-PROCESS.md
-- buildconf.bat: Tidy up of comments after recent commits
+- SECURITY.md: call it the security process
-- buildconf.bat: Added full generation of src\tool_hugehelp.c
+Michael Kaufmann (11 Mar 2018)
+- Curl_range: fix FTP-only and FILE-only builds
- Added support for generating the full man page based on code from
- generate.bat.
+ follow-up to e04417d
+
+- hostip: fix compiler warning: 'variable set but not used'
-- buildconf.bat: Added detection of groff, nroff, perl and gzip
+Daniel Stenberg (11 Mar 2018)
+- HTTP: allow "header;" to replace an internal header with a blank one
- To allow for the full generation of tool_hugehelp.c added detection of
- the required programs - based on code from generate.bat.
+ Reported-by: Michael Kaufmann
+ Fixes #2357
+ Closes #2362
-- buildconf.bat: Move DOS variable clean-up code to separate function
+- http2: verbose output new MAX_CONCURRENT_STREAMS values
- Rather than duplicate future variables, during clean-up of both success
- and error conditions, use a common function that can be called by both.
+ ... as it is interesting for many users.
-- RELEASE-NOTES: Synced with 39dcf352d2
+- SECURITY: distros' max embargo time is 14 days now
-- buildconf.bat: Added error messages on failure
+Patrick Monnerat (8 Mar 2018)
+- curl tool: accept --compressed also if Brotli is enabled and zlib is not.
-- buildconf.bat: Generate and clean files in the same order
+Daniel Stenberg (5 Mar 2018)
+- THANKS + mailmap: remove duplicates, fixup full names
-- buildconf.bat: Maintain compatibility with DOS based systems
-
- Commit f08e30d7bc broke compatibility with DOS and non Windows NT based
- versions of Windows due to the use of the setlocal command.
+- [sergii.kavunenko brought this change]
-Jay Satiro (9 Aug 2015)
-- CURLOPT_RESOLVE.3: Note removal support was added in 7.42
+ WolfSSL: adding TLSv1.3
- Bug: http://curl.haxx.se/mail/lib-2015-08/0019.html
- Reported-by: Inca R
+ Closes #2349
-Steve Holme (8 Aug 2015)
-- checksrc.bat: Fixed error when missing *.c and *.h files
-
- File Not Found
+- RELEASE-NOTES/THANKS: synced with cc1d4c505
-- checksrc.bat: Fixed incorrect 'lib\vtls' path check in commit 333c36b276
+- [Richard Alcock brought this change]
-- checksrc.bat: Fixed error when [directory] isn't a curl source directory
+ winbuild: prefer documented zlib library names
- The system cannot find the file specified.
-
-- checksrc.bat: Added check for unknown arguments
-
-- scripts: Added missing comments
-
-- scripts: Always perform setlocal and endlocal calls in pairs
+ Check for existence of import and static libraries with documented names
+ and use them if they do. Fallback to previous names.
- Ensure that there isn't a mismatch between setlocal and endlocal calls,
- which could have happened due to setlocal being called after certain
- error conditions were checked for.
-
-- scripts: Allow -help to be specified in any argument
+ According to
+ https://github.com/madler/zlib/blob/master/win32/README-WIN32.txt on
+ Windows, the names of the import library is "zdll.lib" and static
+ library is "zlib.lib".
- Allow the -help command line argument to be specified in any argument
- and not just as the first.
+ closes #2354
-Daniel Stenberg (6 Aug 2015)
-- [juef brought this change]
-
- curl_multi_remove_handle.3: fix formatting
+Marcel Raad (4 Mar 2018)
+- krb5: use nondeprecated functions
- closes #366
-
-Steve Holme (6 Aug 2015)
-- README: Added notes about 'Running DLL based configurations'
+ gss_seal/gss_unseal have been deprecated in favor of
+ gss_wrap/gss_unwrap with GSS-API v2 from January 1997 [1]. The first
+ version of "The Kerberos Version 5 GSS-API Mechanism" [2] from June
+ 1996 already says "GSS_Wrap() (formerly GSS_Seal())" and
+ "GSS_Unwrap() (formerly GSS_Unseal())".
- ...as well as a TODO for a future enhancement to the project files.
+ Use the nondeprecated functions to avoid deprecation warnings.
- Thanks-to: Jay Satiro
+ [1] https://tools.ietf.org/html/rfc2078
+ [2] https://tools.ietf.org/html/rfc1964
+
+ Closes https://github.com/curl/curl/pull/2356
-- RELEASE-NOTES: Synced with cf8975387f
+Daniel Stenberg (4 Mar 2018)
+- curl.1: mention how to add numerical IP addresses in NO_PROXY
-- buildconf.bat: Synchronise no repository error with generate.bat
+- CURLOPT_NOPROXY.3: mention how to list numerical IPv6 addresses
-- generate.bat: Added a check for the presence of a git repository
+- NO_PROXY: fix for IPv6 numericals in the URL
+
+ Added test 1265 that verifies.
+
+ Reported-by: steelman on github
+ Fixes #2353
+ Closes #2355
-- [Jay Satiro brought this change]
+- build: get CFLAGS (including -werror) used for examples and tests
+
+ ... so that the CI and more detects compiler warnings/errors properly!
+
+ Closes #2337
- build: Added wolfSSL configurations to VC10+ project files
+Marcel Raad (3 Mar 2018)
+- curl_ctype: fix macro redefinition warnings
- URL: https://github.com/bagder/curl/pull/174
+ On MinGW and Cygwin, GCC and clang have been complaining about macro
+ redefinitions since 4272a0b0fc49a1ac0ceab5c4a365c9f6ab8bf8e2. Fix this
+ by undefining the macros before redefining them as suggested in
+ https://github.com/curl/curl/pull/2269.
+
+ Suggested-by: Daniel Stenberg
-- [Jay Satiro brought this change]
+Dan Fandrich (2 Mar 2018)
+- unit1307: proper cleanup on OOM to fix torture tests
- build: Added wolfSSL build script for Visual Studio projects
+Marcel Raad (28 Feb 2018)
+- unit1309: fix warning on Windows x64
- Added the wolfSSL build script, based on build-openssl.bat, as well as
- the property sheet and header file required for the upcoming additions
- to the Visual Studio project files.
+ When targeting x64, MinGW-w64 complains about conversions between
+ 32-bit long and 64-bit pointers. Fix this by reusing the
+ GNUTLS_POINTER_TO_SOCKET_CAST / GNUTLS_SOCKET_TO_POINTER_CAST logic
+ from gtls.c, moving it to warnless.h as CURLX_POINTER_TO_INTEGER_CAST /
+ CURLX_INTEGER_TO_POINTER_CAST.
+
+ Closes https://github.com/curl/curl/pull/2341
-Daniel Stenberg (6 Aug 2015)
-- CHANGES: refer to the online changelog
+- travis: update compiler versions
+
+ Update clang to version 3.9 and GCC to version 6.
- Suggested-by: mc0e
+ Closes https://github.com/curl/curl/pull/2345
-- [Isaac Boukris brought this change]
+Daniel Stenberg (26 Feb 2018)
+- docs/MANUAL: formfind.pl is not accessible on the site anymore
+
+ Fixes #2342
- NTLM: handle auth for only a single request
+Jay Satiro (24 Feb 2018)
+- curl-openssl.m4: Fix version check for OpenSSL 1.1.1
- Currently when the server responds with 401 on NTLM authenticated
- connection (re-used) we consider it to have failed. However this is
- legitimate and may happen when for example IIS is set configured to
- 'authPersistSingleRequest' or when the request goes thru a proxy (with
- 'via' header).
+ - Add OpenSSL 1.1.1 to the header/library version lists.
- Implemented by imploying an additional state once a connection is
- re-used to indicate that if we receive 401 we need to restart
- authentication.
+ - Detect OpenSSL 1.1.1 library using its function ERR_clear_last_mark,
+ which was added in that version.
- Closes #363
+ Prior to this change an erroneous header/library mismatch was caused by
+ lack of OpenSSL 1.1.1 detection. I tested using openssl-1.1.1-pre1.
-Steve Holme (5 Aug 2015)
-- RELEASE-NOTES: Synced with 473807b95f
-
-- generate.bat: Use buildconf.bat for prerequisite file clean-up
+Viktor Szakats (23 Feb 2018)
+- lib655: silence compiler warning
+
+ Closes https://github.com/curl/curl/pull/2335
-- buildconf.bat: Added support for file clean-up via -clean
+- spelling fixes
+
+ Detected using the `codespell` tool.
+
+ Also contains one URL protocol upgrade.
+
+ Closes https://github.com/curl/curl/pull/2334
-- buildconf.bat: Added progress output
+Daniel Stenberg (24 Feb 2018)
+- projects/README: remove reference to dead IDN link/package
+
+ Reported-by: Stefan Kanthak and Rod Widdowson
+
+ Fixes #2325
-- buildconf.bat: Avoid using goto for file not in repository
+Jay Satiro (23 Feb 2018)
+- [Rod Widdowson brought this change]
-Daniel Stenberg (5 Aug 2015)
-- curl_slist_append.3: add error checking to the example
+ winbuild: Use macros for the names of some build utilities
+
+ - Add macros to the top of the makefile for rc and mt utilities so that
+ it is easier to change their locations.
+
+ Bug: https://curl.haxx.se/mail/lib-2018-02/0075.html
+ Reported-by: Stefan Kanthak
+
+ Closes https://github.com/curl/curl/issues/2329
-Steve Holme (5 Aug 2015)
-- buildconf.bat: Added display of usage text with -help
+Daniel Stenberg (23 Feb 2018)
+- TODO: remove "sha-256 digest", added in 2b5b37cb9109e7c2
-- buildconf.bat: Added exit codes for error handling
+- curl_share_setopt.3: connection cache is shared within multi handles
-- buildconf.bat: Added our standard copyright header
+Jay Satiro (22 Feb 2018)
+- [Rod Widdowson brought this change]
-- buildconf.bat: Use lower-case for commands and reserved keywords
+ winbuild: Use CALL to run batch scripts
+
+ Co-authored-by: Stefan Kanthak
+
+ Closes https://github.com/curl/curl/issues/2330
+ Closes https://github.com/curl/curl/pull/2331
-- generate.bat: Only clean prerequisite files when in ALL mode
+Patrick Monnerat (22 Feb 2018)
+- os400: add curl_resolver_start_callback type to ILE/RPG binding
-- generate.bat: Moved error messages out of sub-routines
+Daniel Stenberg (22 Feb 2018)
+- form.d: rephrased somewhat, added two example command lines
-- generate.bat: More use of lower-case for commands and reserved keywords
+Jay Satiro (21 Feb 2018)
+- [Francisco Sedano brought this change]
-Daniel Stenberg (3 Aug 2015)
-- libcurl.3: fix a single typo
+ url: Add option CURLOPT_RESOLVER_START_FUNCTION
- Closes #361
-
-- RELEASE-NOTES: synced with c4eb10e2f06f
+ - Add new option CURLOPT_RESOLVER_START_FUNCTION to set a callback that
+ will be called every time before a new resolve request is started
+ (ie before a host is resolved) with a pointer to backend-specific
+ resolver data. Currently this is only useful for ares.
+
+ - Add new option CURLOPT_RESOLVER_START_DATA to set a user pointer to
+ pass to the resolver start callback.
+
+ Closes https://github.com/curl/curl/pull/2311
-- SSH: three state machine fixups
+- lib: CURLOPT_HAPPY_EYEBALLS_TIMEOUT => CURLOPT_HAPPY_EYEBALLS_TIMEOUT_MS
- The SSH state machine didn't clear the 'rc' variable appropriately in a
- two places which prevented it from looping the way it should. And it
- lacked an 'else' statement that made it possible to erroneously get
- stuck in the SSH_AUTH_AGENT state.
+ - In keeping with the naming of our other connect timeout options rename
+ CURLOPT_HAPPY_EYEBALLS_TIMEOUT to CURLOPT_HAPPY_EYEBALLS_TIMEOUT_MS.
- Reported-by: Tim Stack
+ This change adds the _MS suffix since the option expects milliseconds.
+ This is more intuitive for our users since other connect timeout options
+ that expect milliseconds use _MS such as CURLOPT_TIMEOUT_MS,
+ CURLOPT_CONNECTTIMEOUT_MS, CURLOPT_ACCEPTTIMEOUT_MS.
- Closes #357
-
-- curl_gssapi: remove 'const' to fix compiler warnings
+ The tool option already uses an -ms suffix, --happy-eyeballs-timeout-ms.
- initialization discards 'const' qualifier from pointer target type
-
-- docs: formpost needs the full size at start of upload
+ Follow-up to 2427d94 which added the lib and tool option yesterday.
- Closes #360
+ Ref: https://github.com/curl/curl/pull/2260
-Steve Holme (1 Aug 2015)
-- sspi: Fix typo from left over from old code which referenced NTLM
+Patrick Monnerat (21 Feb 2018)
+- sasl: prefer PLAIN mechanism over LOGIN
- References to NTLM in the identity generation should have been removed
- in commit c469941293 but not all were.
+ SASL PLAIN is a standard, LOGIN only a draft. The LOGIN draft says
+ PLAIN should be used instead if available.
+
+Daniel Stenberg (21 Feb 2018)
+- RELEASE-NOTES: synced with 2427d94c6
+
+Jay Satiro (20 Feb 2018)
+- [Anders Bakken brought this change]
-- win32: Fix compilation warnings from commit 40c921f8b8
+ url: Add option CURLOPT_HAPPY_EYEBALLS_TIMEOUT
- connect.c:953:5: warning: initializer element is not computable at load
- time
- connect.c:953:5: warning: missing initializer for field 'dwMinorVersion'
- of 'OSVERSIONINFOEX'
- curl_sspi.c:97:5: warning: initializer element is not computable at load
- time
- curl_sspi.c:97:5: warning: missing initializer for field 'szCSDVersion'
- of 'OSVERSIONINFOEX'
+ - Add new option CURLOPT_HAPPY_EYEBALLS_TIMEOUT to set libcurl's happy
+ eyeball timeout value.
+
+ - Add new optval macro CURL_HET_DEFAULT to represent the default happy
+ eyeballs timeout value (currently 200 ms).
+
+ - Add new tool option --happy-eyeballs-timeout-ms to expose
+ CURLOPT_HAPPY_EYEBALLS_TIMEOUT. The -ms suffix is used because the
+ other -timeout options in the tool expect seconds not milliseconds.
+
+ Closes https://github.com/curl/curl/pull/2260
-- schannel: Fix compilation warning from commit 7a8e861a56
+- hostip: fix 'potentially uninitialized variable' warning
+
+ Follow-up to 50d1b33.
- schannel.c:1125:5: warning: missing initializer for field 'dwMinorVersion'
- of 'OSVERSIONINFOEX' [-Wmissing-field-initializers
+ Caught by AppVeyor.
-Daniel Stenberg (31 Jul 2015)
-- libcurl-thread.3: minor reformatting
+Daniel Stenberg (20 Feb 2018)
+- TODO: warning if curl version is not in sync with libcurl version
-Jay Satiro (31 Jul 2015)
-- curl_global_init_mem.3: Warn threaded resolver needs thread safe funcs
-
- Bug: http://curl.haxx.se/mail/lib-2015-07/0149.html
- Reported-by: Eric Ridge
+Jay Satiro (20 Feb 2018)
+- [Anders Bakken brought this change]
-- libcurl-thread.3: Warn memory functions must be thread safe
+ CURLOPT_RESOLVE: Add support for multiple IP addresses per entry
- Bug: http://curl.haxx.se/mail/lib-2015-07/0149.html
- Reported-by: Eric Ridge
+ This enables users to preresolve but still take advantage of happy
+ eyeballs and trying multiple addresses if some are not connecting.
+
+ Ref: https://github.com/curl/curl/pull/2260
-Steve Holme (31 Jul 2015)
-- RELEASE-NOTES: Synced with 8b1d00ac1a
+Daniel Stenberg (20 Feb 2018)
+- [Sergio Borghese brought this change]
-- INSTALL: Minor formatting correction in 'Legacy Windows and SSL' section
+ examples/sftpuploadresume: resume upload via CURLOPT_APPEND
- ...as well as some rewording.
+ URL: https://curl.haxx.se/mail/lib-2018-02/0072.html
-Kamil Dudka (30 Jul 2015)
-- http: move HTTP/2 cleanup code off http_disconnect()
+- curl --version: show PSL if the run-time lib has it enabled
- Otherwise it would never be called for an HTTP/2 connection, which has
- its own disconnect handler.
+ ... not of the #define was set at build-time!
+
+- TODO: "Support in-memory certs/ca certs/keys"
- I spotted this while debugging <https://bugzilla.redhat.com/1248389>
- where the http_disconnect() handler was called on an FTP session handle
- causing 'dnf' to crash. conn->data->req.protop of type (struct FTP *)
- was reinterpreted as type (struct HTTP *) which resulted in SIGSEGV in
- Curl_add_buffer_free() after printing the "Connection cache is full,
- closing the oldest one." message.
+ removed SSLKEYLOGFILE support (fixed)
- A previously working version of libcurl started to crash after it was
- recompiled with the HTTP/2 support despite the HTTP/2 protocol was not
- actually used. This commit makes it work again although I suspect the
- root cause (reinterpreting session handle data of incompatible protocol)
- still has to be fixed. Otherwise the same will happen when mixing FTP
- and HTTP/2 connections and exceeding the connection cache limit.
+ removed "consider SSL patches" (outdated)
- Reported-by: Tomas Tomecek
- Bug: https://bugzilla.redhat.com/1248389
+ Closes #2310
-Daniel Stenberg (30 Jul 2015)
-- [Viktor Szakats brought this change]
+- CURLOPT_HEADER.3: clarify problems with different data sizes
- ABI doc: use secure URL
+- test1556: verify >16KB headers to the header callback
-- ABI: remove the ascii logo
+- header callback: don't chop headers into smaller pieces
- and made the indent level to 1
+ Reported-by: Guido Berhoerster
+ Fixes #2314
+ Closes #2316
+
+- test1154: verify that long HTTP headers get rejected
-- libcurl-multi.3: mention curl_multi_wait
+- http: fix the max header length detection logic
- ... and some general rewordings to improve this docs.
+ Previously, it would only check for max length if the existing alloc
+ buffer was to small to fit it, which often would make the header still
+ get used.
- Reported-by: Tim Stack
+ Reported-by: Guido Berhoerster
+ Bug: https://curl.haxx.se/mail/lib-2018-02/0056.html
- Closes #356
+ Closes #2315
-Steve Holme (30 Jul 2015)
-- maketgz: Fixed some VC makefiles missing from the release tarball
+- CURLOPT_HEADERFUNCTION.3: fix typo from d939226813
- VC7, VC11, VC12 and VC14 makefiles were missing from the release
- tarball.
-
-- RELEASE-NOTES: Synced with 2d7e165761
+ Reported-by: Erik Johansson
+ Bug: https://github.com/curl/curl/commit/d9392268131c1b8d18dec3fa30e0bded833a5db7#commitcomment-27607495
-- build: Added VC14 project files to Makefile.am
+- CURLOPT_HEADERFUNCTION.3: mention folded headers
-- build: Added VC14 project files
+- TODO: 1.1 Option to refuse usernames in URLs
- Updates to Makefile.am for the generation of the project files in
- the tarball to follow.
+ Also expanded the CURL_REFUSE_CLEARTEXT section with more ideas.
-Jay Satiro (29 Jul 2015)
-- libcurl-thread.3: Clarify CURLOPT_NOSIGNAL takes long value 1L
+- TODO: 1.7 Support HTTP/2 for HTTP(S) proxies
-Steve Holme (28 Jul 2015)
-- generate.bat: Use lower-case for commands and reserved keywords
+- ssh: add two missing state names
+
+ The list of state names (used in debug builds) was out of sync in
+ relation to the list of states (used in all builds).
+
+ I now added an assert to make sure the sizes of the two lists match, to
+ aid in detecting this mistake better in the future.
+
+ Regression since c92d2e14cf, shipped in 7.58.0.
+
+ Reported-by: Somnath Kundu
- Whilst there are no coding standards for the batch files used in curl,
- most tend to use lower-case for keywords and upper-case for variables.
+ Fixes #2312
+ Closes #2313
-- build: Added initial VC14 support to generate.bat
+- Revert "KNOWN_BUGS: 2.5 curl should not offer "ALPN: h2" when using https-proxy"
- Visual Studio project files and updates to makefile.am to follow.
+ This reverts commit de9fac00c40db321d44fa6fbab6eb62ec4c83998.
+
+ Reported-by: Jay Satiro
-- build: Fixed missing .opensdf files from VC10+ .gitignore files
+Jay Satiro (15 Feb 2018)
+- non-ascii: fix implicit declaration warning
+
+ Follow-up to b46cfbc.
+
+ Caught by Travis CI.
-- build: Use $(ProjectName) macro for curl.exe and curld.exe filenames
+Daniel Stenberg (15 Feb 2018)
+- travis: add build with iconv enabled
+
+ ... to verify it builds and works fine.
- This wasn't possible with the old curlsrc project filenames, but like
- commit 2a615a2b64 and 11397eb6dd for libcurl use the built in Visual
- Studio macros for the output filenames.
+ Ref: https://curl.haxx.se/mail/lib-2017-09/0031.html
+
+ Closes #1872
-- build: Renamed curl src Visual Studio project files
+- TODO: 18.18 retry on network is unreachable
- Following commit 957fcd9049 and in preparation for adding the VC14
- project files renamed the curl source project files.
+ Closes #1603
-Daniel Stenberg (28 Jul 2015)
-- [Jay Satiro brought this change]
+- KNOWN_BUGS: 2.5 curl should not offer "ALPN: h2" when using https-proxy
+
+ Closes #1254
- libcurl-thread.3: Revert to stricter handle wording
+Kamil Dudka (15 Feb 2018)
+- nss: use PK11_CreateManagedGenericObject() if available
+
+ ... so that the memory allocated by applications using libcurl does not
+ grow per each TLS connection.
- .. also update formatting and add WinSSL and wolfSSL to the SSL/TLS
- handlers list.
+ Bug: https://bugzilla.redhat.com/1510247
+
+ Closes #2297
-- [Jay Satiro brought this change]
+Daniel Stenberg (15 Feb 2018)
+- [Björn Stenberg brought this change]
- libcurl-thread.3: Consolidate thread safety info
+ TODO fixed: Detect when called from within callbacks
- This is a new document to consolidate our thread safety information from
- several documents (curl-www:features, libcurl.3, libcurl-tutorial.3).
- Each document's section on multi-threading will now point to this one.
+ Closes #2302
-Steve Holme (27 Jul 2015)
-- README: Corrected formatting for 'Legacy Windows and SSL' section
+- BINDINGS: fix curb link (and remove ruby-curl-multi)
- ...as well as some wording.
+ Reported-by: Klaus Stein
-- build-openssl.bat: Added support for VC14
+- curl_gssapi: make sure this file too uses our *printf()
-Daniel Stenberg (26 Jul 2015)
-- RELEASE-NOTES: synced with 0f645adc95390e8
+- libcurl-security.3: separate file:// section
+
+ ... just to make it more apparent. Even if it repeats
+ some pieces of information.
-- test1902: attempt to make the test more reliable
+- libcurl-security.3: the http://192.168.0.1/my_router_config case
- Closes #355
+ Mentioned-By: Rich Moore
+
+- libcurl-security.3: mention the URL standards problems too
-- comment: fix comment about adding new option support
+- libcurl-security.3: split out from libcurl-tutorial.3
+
+ To make more accessible.
+
+ Merged in some new language from "URLs are dangerous things" as discussed on
+ the mailing list a few days ago:
+
+ Bug: https://curl.haxx.se/mail/lib-2018-02/0013.html
-Jay Satiro (25 Jul 2015)
-- build-openssl.bat: Show syntax if required args are missing
+- RELEASE-NOTES: synced with e551910f8
-Daniel Stenberg (26 Jul 2015)
-- TODO: improve how curl works in a windows console window
+Patrick Monnerat (13 Feb 2018)
+- tests: new tests for http raw mode
+
+ Test 319 checks proper raw mode data with non-chunked gzip
+ transfer-encoded server data.
+ Test 326 checks raw mode with chunked server data.
- Closes #322 for now
+ Bug: #2303
+ Closes #2308
-- 1.11 minimize dependencies with dynamicly loaded modules
+Kamil Dudka (12 Feb 2018)
+- tlsauthtype.d: works only if libcurl is built with TLS-SRP support
- Closes #349 for now
+ Bug: https://bugzilla.redhat.com/1542256
+
+ Closes #2306
-Jay Satiro (25 Jul 2015)
-- tool_operate: Fix CURLOPT_SSL_OPTIONS for builds without HTTPS
+Patrick Monnerat (12 Feb 2018)
+- smtp: fix processing of initial dot in data
- - Set CURLOPT_SSL_OPTIONS only if the tool enabled an SSL option.
+ RFC 5321 4.1.1.4 specifies the CRLF terminating the DATA command
+ should be taken into account when chasing the <CRLF>.<CRLF> end marker.
+ Thus a leading dot character in data is also subject to escaping.
- Broken by me several days ago in 172b2be.
- https://github.com/bagder/curl/commit/172b2be#diff-70b44ee478e58d4e1ddcf9c9a73d257b
+ Tests 911 and test server are adapted to this situation.
+ New tests 951 and 952 check proper handling of initial dot in data.
- Bug: http://curl.haxx.se/mail/lib-2015-07/0119.html
- Reported-by: Dan Fandrich
+ Closes #2304
+
+Daniel Stenberg (12 Feb 2018)
+- sha256: avoid redefine
+
+- [Douglas Mencken brought this change]
-Daniel Stenberg (25 Jul 2015)
-- configure: check if OpenSSL linking wants -ldl
+ sha256: build with OpenSSL < 0.9.8 too
- To make it easier to link with static versions of OpenSSL, the configure
- script now checks if -ldl is needed for linking.
+ support for SHA-2 was introduced in OpenSSL 0.9.8
- Help-by: TJ Saunders
+ Closes #2305
-- [Michael Kaufmann brought this change]
+- [Bruno Grasselli brought this change]
+
+ README: language fix
+
+ s/off/from
+
+ Closes #2300
- HTTP: ignore "Content-Encoding: compress"
+Patrick Monnerat (12 Feb 2018)
+- http_chunks: don't write chunks twice with CURLOPT_HTTP_TRANSFER_DECODING on
- Currently, libcurl rejects responses with "Content-Encoding: compress"
- when CURLOPT_ACCEPT_ENCODING is set to "". I think that libcurl should
- treat the Content-Encoding "compress" the same as other
- Content-Encodings that it does not support, e.g. "bzip2". That means
- just ignoring it.
+ Bug: #2303
+ Reported-By: Henry Roeland
-- [Marcel Raad brought this change]
+Daniel Stenberg (9 Feb 2018)
+- get_posix_time: only check for overflows if they can happen!
- openssl: work around MSVC warning
+Michael Kaufmann (9 Feb 2018)
+- schannel: fix "no previous prototype" compiler warning
+
+Jay Satiro (9 Feb 2018)
+- [Mohammad AlSaleh brought this change]
+
+ content_encoding: Add "none" alias to "identity"
+
+ Some servers return a "content-encoding" header with a non-standard
+ "none" value.
+
+ Add "none" as an alias to "identity" as a work-around, to avoid
+ unrecognised content encoding type errors.
- MSVC 12 complains:
+ Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
- lib\vtls\openssl.c(1554): warning C4701: potentially uninitialized local
- variable 'verstr' used It's a false positive, but as it's normally not,
- I have enabled warning-as-error for that warning.
+ Closes https://github.com/curl/curl/pull/2298
-- [Michał Fita brought this change]
+Steve Holme (8 Feb 2018)
+- build-openssl.bat: Follow up to 648679ab8e to suppress copy/move output
- configure: add --disable-rt option
-
- This option disables any attempts in configure to create dependency on
- stuff requiring linking to librt.so and libpthread.so, in this case this
- means clock_gettime(CLOCK_MONOTONIC, &mt).
+- build-openssl.bat: Fixed incorrect move if destination build folder exists
+
+Michael Kaufmann (8 Feb 2018)
+- schannel: fix compiler warnings
- We were in need to build curl which doesn't link libpthread.so to avoid
- the following bug:
- https://sourceware.org/bugzilla/show_bug.cgi?id=16628.
+ Closes #2296
-Kamil Dudka (23 Jul 2015)
-- http2: verify success of strchr() in http2_send()
+Steve Holme (7 Feb 2018)
+- curl_addrinfo.c: Allow Unix Domain Sockets to compile under Windows
- Detected by Coverity.
+ Windows 10.0.17061 SDK introduces support for Unix Domain Sockets.
+ Added the necessary include file to curl_addrinfo.c.
- Error: NULL_RETURNS:
- lib/http2.c:1301: returned_null: "strchr" returns null (checked 103 out of 109 times).
- lib/http2.c:1301: var_assigned: Assigning: "hdbuf" = null return value from "strchr".
- lib/http2.c:1302: dereference: Incrementing a pointer which might be null: "hdbuf".
- 1300|
- 1301| hdbuf = strchr(hdbuf, 0x0a);
- 1302|-> ++hdbuf;
- 1303|
- 1304| authority_idx = 0;
+ Note: The SDK (which is considered beta) has to be installed, VS 2017
+ project file has to be re-targeted for Windows 10.0.17061 and #define
+ enabled in config-win32.h.
-Jay Satiro (22 Jul 2015)
-- Windows: Fix VerifyVersionInfo calls
+Patrick Monnerat (7 Feb 2018)
+- fnmatch: optimize processing of consecutive *s and ?s pattern characters
- - Fix the VerifyVersionInfo calls, which we use to test for the OS major
- version, to also test for the minor version as well as the service pack
- major and minor versions.
-
- MSDN: "If you are testing the major version, you must also test the
- minor version and the service pack major and minor versions."
+ Reported-By: Daniel Stenberg
+ Fixes #2291
+ Closes #2293
+
+Steve Holme (6 Feb 2018)
+- build-openssl.bat/build-wolfssl.bat: Build platform is optional
- https://msdn.microsoft.com/en-us/library/windows/desktop/ms725492.aspx
+ Whilst the compiler parameter is mandatory, platform is optional as it
+ is automatically calculated by the :configure section.
- Bug: https://github.com/bagder/curl/pull/353#issuecomment-123493098
- Reported-by: Marcel Raad <MarcelRaad@users.noreply.github.com>
+ This partially reverts commit 6d62d2c55d.
-- [Marcel Raad brought this change]
+Daniel Stenberg (6 Feb 2018)
+- [Patrick Schlangen brought this change]
- schannel: Replace deprecated GetVersion with VerifyVersionInfo
+ openssl: Don't add verify locations when verifypeer==0
+
+ When peer verification is disabled, calling
+ SSL_CTX_load_verify_locations is not necessary. Only call it when
+ verification is enabled to save resources and increase performance.
+
+ Closes #2290
-Steve Holme (21 Jul 2015)
-- makefile: Added support for VC14
+Steve Holme (5 Feb 2018)
+- build-wolfssl.bat: Extend VC15 support to include Enterprise and Professional
+
+ ...and not just the Community Edition.
-Patrick Monnerat (21 Jul 2015)
-- os400: ebcdic wrappers for new functions. Upgrade ILE/RPG bindings.
+- build-openssl.bat: Extend VC15 support to include Enterprise and Professional
+
+ ...and not just the Community Edition.
-- libcurl: VERSIONINFO update
- Addition of new procedures curl_pushheader_bynum and curl_pushheader_byname
- requires VERSIONINFO updating.
+Michael Kaufmann (5 Feb 2018)
+- time-cond: fix reading the file modification time on Windows
+
+ On Windows, stat() may adjust the unix file time by a daylight saving time
+ offset. Avoid this by calling GetFileTime() instead.
+
+ Fixes #2164
+ Closes #2204
-- http2: satisfy external references even if http2 is not compiled in.
+Daniel Stenberg (5 Feb 2018)
+- formdata: use the mime-content type function
+
+ Reduce code duplication by making Curl_mime_contenttype available and
+ used by the formdata function. This also makes the formdata function
+ recognize a set of more file extensions by default.
+
+ PR #2280 brought this to my attention.
+
+ Closes #2282
-Daniel Stenberg (20 Jul 2015)
-- http2: add stream != NULL checks for reliability
+- getdate: return -1 for out of range
+
+ ...as that's how the function is documented to work.
- They should not trigger, but in case of internal problems we at least
- avoid crashes this way.
+ Reported-by: Michael Kaufmann
+ Bug found in an autobuild with 32 bit time_t
+
+ Closes #2278
+
+- [Ben Greear brought this change]
-Jay Satiro (18 Jul 2015)
-- symbols-in-versions: Add new CURLSSLOPT_NO_REVOKE symbol
+ build: fix termios issue on android cross-compile
+
+ Bug: https://curl.haxx.se/mail/lib-2018-01/0122.html
+ Signed-off-by: Ben Greear <greearb@candelatech.com>
-- SSL: Add an option to disable certificate revocation checks
+- time_t-fixes: remove typecasts to 'long' for info.filetime
- New tool option --ssl-no-revoke.
- New value CURLSSLOPT_NO_REVOKE for CURLOPT_SSL_OPTIONS.
+ They're now wrong.
- Currently this option applies only to WinSSL where we have automatic
- certificate revocation checking by default. According to the
- ssl-compared chart there are other backends that have automatic checking
- (NSS, wolfSSL and DarwinSSL) so we could possibly accommodate them at
- some later point.
+ Reported-by: Michael Kaufmann
- Bug: https://github.com/bagder/curl/issues/264
- Reported-by: zenden2k <zenden2k@gmail.com>
+ Closes #2277
-- runtests: Allow for spaces in curl custom path
+- curl_setup: move the precautionary define of SIZEOF_TIME_T
+
+ ... up to before it may be used for the TIME_T_MAX/MIN logic.
- .. also fix some typos in test's FILEFORMAT spec.
+ Reported-by: Michael Kaufmann
-- [David Woodhouse brought this change]
+- parsedate: s/#if/#ifdef
+
+ Reported-by: Michael Kaufmann
+ Bug: https://github.com/curl/curl/commit/1c39128d974666107fc6d9ea15f294036851f224#commitcomment-27246479
- ntlm_wb: Fix theoretical memory leak
+Patrick Monnerat (31 Jan 2018)
+- fnmatch: pattern syntax can no longer fail
+
+ Whenever an expected pattern syntax rule cannot be matched, the
+ character starting the rule loses its special meaning and the parsing
+ is resumed:
+ - backslash at the end of pattern string matches itself.
+ - Error in [:keyword:] results in set containing :\[dekorwy.
- Static analysis indicated that my commit 9008f3d564 ("ntlm_wb: Fix
- hard-coded limit on NTLM auth packet size") introduced a potential
- memory leak on an error path, because we forget to free the buffer
- before returning an error.
+ Unit test 1307 updated for this new situation.
- Fix this.
+ Closes #2273
+
+- fnmatch: accept an alphanum to be followed by a non-alphanum in char set
- Although actually, it never happens in practice because we never *get*
- here with state == NTLMSTATE_TYPE1. The state is always zero. That
- might want cleaning up in a separate patch.
+ Also be more tolerant about set pattern syntax.
+ Update unit test 1307 accordingly.
- Reported-by: Terri Oda
+ Bug: https://curl.haxx.se/mail/lib-2018-01/0114.html
-- strerror: Add CRYPT_E_REVOKED to SSPI error strings
+- fnmatch: do not match the empty string with a character set
-Kamil Dudka (14 Jul 2015)
-- libtest: call PR_Cleanup() on exit if NSPR is used
+Jay Satiro (30 Jan 2018)
+- build: fix windows build methods for curl_ctype.c
- This prevents valgrind from reporting possibly lost memory that NSPR
- uses for file descriptor cache and other globally allocated internal
- data structures.
+ - Fix winbuild and the VS project generator to treat curl_ctype.{c,h} as
+ curlx files since they are required by both src and lib.
- Reported-by: Štefan Kremeň
-
-Jay Satiro (14 Jul 2015)
-- [John Malmberg brought this change]
+ Follow-up to 4272a0b which added curl_ctype.
- openssl: VMS support for SHA256
+Daniel Stenberg (30 Jan 2018)
+- progress-bar.d: update to match implementation
- setup-vms.h: More symbols for SHA256, hacks for older VAX
+ ... since commit 993dd5651a6
- openssl.h: Use OpenSSL OPENSSL_NO_SHA256 macro to allow building on VAX.
+ Reported-by: Martin Dreher
+ Bug: https://github.com/curl/curl/pull/2242#issuecomment-361059228
+
+ Closes #2271
+
+- http2: set DEBUG_HTTP2 to enable more HTTP/2 logging
- openssl.c: Use OpenSSL version checks and OPENSSL_NO_SHA256 macro to
- allow building on VAX and 64 bit VMS.
+ ... instead of doing it unconditionally in debug builds. It cluttered up
+ the output a little too much.
-- examples: Fix typo in multi-single.c
+- [Max Dymond brought this change]
-Daniel Stenberg (7 Jul 2015)
-- [Tatsuhiro Tsujikawa brought this change]
+ file: Check the return code from Curl_range and bail out on error
- http2: Fix memory leak in push header array
+- [Max Dymond brought this change]
-Dan Fandrich (2 Jul 2015)
-- test2041: fixed line endings in protocol part
+ Curl_range: add check to ensure "from <= to"
-- cyassl: fixed mismatched sha256sum function prototype
+- [Max Dymond brought this change]
-Daniel Stenberg (1 Jul 2015)
-- [moparisthebest brought this change]
+ Curl_range: commonize FTP and FILE range handling
+
+ Closes #2205
- SSL: Pinned public key hash support
+- RELEASE-NOTES: synced with 811beab9f
-- examples: provide <DESC> sections
+- curlver: next release will be 7.59.0
-- [John Malmberg brought this change]
+- [Michał Janiszewski brought this change]
- OpenVMS: VMS Software, Inc now the supplier.
-
- setup-vms.h: Symbol case fixups submitted by Michael Steve
+ curl/curl.h: fix comment typo for CURLOPT_DNS_LOCAL_IP6
- build_gnv_curl_pcsi_desc.com: VSI aka as VMS Software, is now the
- supplier of new versions of VMS. The install kit needs to accept
- VSI as a producer.
+ Closes #2275
-Jay Satiro (30 Jun 2015)
-- multi: Move http2 push function declarations to header end
+- time: support > year 2038 time stamps for system with 32bit long
- This change necessary for binary compatibility.
+ ... with the introduction of CURLOPT_TIMEVALUE_LARGE and
+ CURLINFO_FILETIME_T.
- Prior to this change test 1135 failed due to the order of functions.
+ Fixes #2238
+ Closes #2264
-- symbols-in-versions: Add new http2 push symbols
+- curl_easy_reset: clear digest auth state
- Prior to this change test 1119 failed due to the missing symbols.
+ Bug: https://curl.haxx.se/mail/lib-2018-01/0074.html
+ Reported-by: Ruurd Beerstra
+ Fixes #2255
+ Closes #2272
-Daniel Stenberg (30 Jun 2015)
-- RELEASE-NOTES: synced with e6749055d653
+- [Adam Marcionek brought this change]
-- configure: disable libidn by default
+ winbuild: make linker generate proper PDB
- For security reasons, until there is a fix.
+ Link.exe requires /DEBUG to properly generate a full pdb file on release
+ builds.
- Bug: http://curl.haxx.se/mail/lib-2015-06/0143.html
- Reported-by: Gustavo Grieco, Feist Josselin
+ Closes #2274
-- SSL-PROBLEMS: mention WinSSL problems in WinXP
+- curl: add --proxy-pinnedpubkey
+
+ To verify a proxy's public key. For when using HTTPS proxies.
+
+ Fixes #2192
+ Closes #2268
-- CODE_OF_CONDUCT.md: added
+- configure: set PATH_SEPARATOR to colon for PATH w/o separator
- Just to underscore how we treat each other in this project. Nothing new
- really, but could be useful for newcomers and outsiders to see our
- values.
+ The logic tries to figure out what the path separator in the $PATH
+ variable is, but if there's only one directory in the $PATH it
+ fails. This change make configure *guess* on colon instead of erroring
+ out, simply because that is probably the more common character.
+
+ PATH_SEPARATOR can always be set by the user to override the guessing.
+
+ (tricky bug to reproduce, as in my case for example the configure script
+ requires binaries in more than one directory so passing in a PATH with a
+ single dir fails.)
+
+ Reported-by: Earnestly on github
+ Fixes #2202
+ Closes #2265
-- tool_header_cb: fflush the header stream
+- curl_ctype: private is*() type macros and functions
- Flush the header stream when -D is used so that they are sent off
- earlier.
+ ... since the libc provided one are locale dependent in a way we don't
+ want. Also, the "native" isalnum() (for example) works differently on
+ different platforms which caused test 1307 failures on macos only.
- Bug: https://github.com/bagder/curl/issues/324
- Reported-by: Cédric Connes
+ Closes #2269
-- [Roger Leigh brought this change]
+Marcel Raad (29 Jan 2018)
+- build: open VC15 projects with VS 2017
+
+ Previously, they were opened with Visual Studio 2015 by default, which
+ cannot build them.
- tests: Distribute CMakeLists.txt files in subdirectories
+Daniel Stenberg (29 Jan 2018)
+- RELEASE-NOTES: synced with 094647fca
-- CURLOPT_FAILONERROR.3: mention that it closes the connection
+- TODO: UTF-8 filenames in Content-Disposition
- Reported-by: bemoody
- Bug: https://github.com/bagder/curl/issues/325
+ Closes #1888
-- curl_multi_setopt.3: alpha sort the options
+- KNOWN_BUGS: DICT responses show the underlying protocol
+
+ Closes #1809
-- curl_multi_setopt.3: add the new push options
+Jay Satiro (27 Jan 2018)
+- [Alessandro Ghedini brought this change]
-- [Tatsuhiro Tsujikawa brought this change]
+ docs: fix typos in man pages
+
+ Closes https://github.com/curl/curl/pull/2266
- http2: Use nghttp2 library error code for error return value
+Patrick Monnerat (26 Jan 2018)
+- lib555: drop text conversion and encode data as ascii codes
+
+ If CURL_DOES_CONVERSION is enabled, uploaded LFs are mapped to CRLFs,
+ giving a result that is different from what is expected.
+ This commit avoids using CURLOPT_TRANSFERTEXT and directly encodes data
+ to upload in ascii.
+
+ Bug: https://github.com/curl/curl/pull/1872
-- [Tatsuhiro Tsujikawa brought this change]
+Daniel Stenberg (26 Jan 2018)
+- lib517: make variable static to avoid compiler warning
+
+ ... with clang on macos
- http2: Harden header validation for curl_pushheader_byname
+Patrick Monnerat (26 Jan 2018)
+- lib544: sync ascii code data with textual data
+
+ Data mismatch caused test 545 to fail when character encoding
+ conversion is enabled.
- Since we do prefix match using given header by application code
- against header name pair in format "NAME:VALUE", and VALUE part can
- contain ":", we have to careful about existence of ":" in header
- parameter. ":" should be allowed to match HTTP/2 pseudo-header field,
- and other use of ":" in header must be treated as error, and
- curl_pushheader_byname should return NULL. This commit implements
- this behaviour.
+ Bug: https://github.com/curl/curl/pull/1872
-- [Tatsuhiro Tsujikawa brought this change]
+Daniel Stenberg (25 Jan 2018)
+- [Travis Burtrum brought this change]
- CURLMOPT_PUSHFUNCTION.3: Remove unused variable
+ GSKit: restore pinnedpubkey functionality
+
+ inadvertently removed in 283babfaf8d8f3bab9d3c63cea94eb0b84e79c37
+
+ Closes #2263
-- CURLMOPT_PUSHFUNCTION.3: added example
+- [Dair Grant brought this change]
-- http2: curl_pushheader_byname now takes a const char *
+ darwinssl: Don't import client certificates into Keychain on macOS
+
+ Closes #2085
-- http2-serverpush.c: example code
+- configure: fix the check for unsigned time_t
+
+ Assign the time_t variable negative value and then check if it is
+ greater than zero, which will evaluate true for unsigned time_t but
+ false for signed time_t.
-- http2: free all header memory after the push callback
+- parsedate: fix date parsing for systems with 32 bit long
+
+ Make curl_getdate() handle dates before 1970 as well (returning negative
+ values).
+
+ Make test 517 test dates for 64 bit time_t.
+
+ This fixes bug (3) mentioned in #2238
+
+ Closes #2250
-- http2: init the pushed transfer properly
+- [McDonough, Tim brought this change]
-- http2: fixed the header accessor functions for the push callback
+ openssl: fix pinned public key build error in FIPS mode
+
+ Here is a version that should work with all versions of openssl 0.9.7
+ through 1.1.0.
+
+ Links to the docs:
+ https://www.openssl.org/docs/man1.0.2/crypto/EVP_DigestInit.html
+ https://www.openssl.org/docs/man1.1.0/crypto/EVP_DigestInit.html
+
+ At the very bottom of the 1.1.0 documentation there is a history section
+ that states, " stack allocated EVP_MD_CTXs are no longer supported."
+
+ If EVP_MD_CTX_create and EVP_MD_CTX_destroy are not defined, then a
+ simple mapping can be used as described here:
+ https://wiki.openssl.org/index.php/Talk:OpenSSL_1.1.0_Changes
+
+ Closes #2258
-- http2: setup the new pushed stream properly
+- [Travis Burtrum brought this change]
-- http2: initial implementation of the push callback
+ SChannel/WinSSL: Replace Curl_none_md5sum with Curl_schannel_md5sum
-- http2: initial HTTP/2 server push types/docs
+- [Travis Burtrum brought this change]
-- test1531: verify POSTFIELDSIZE set after add_handle
+ SChannel/WinSSL: Implement public key pinning
- Following the fix made in 903b6e05565bf.
+ Closes #1429
+
+- bump: towards 7.58.1
-- pretransfer: init state.infilesize here, not in add_handle
+- cookies: remove verbose "cookie size:" output
- ... to properly support that options are set to the handle after it is
- added to the multi handle.
+ It was once used for some debugging/verifying logic but should never have
+ ended up in git!
+
+- TODO: hardcode the "localhost" addresses
+
+- TODO: CURL_REFUSE_CLEARTEXT
- Bug: http://curl.haxx.se/mail/lib-2015-06/0122.html
- Reported-by: Stefan Bühler
+ An idea that popped up in discussions on twitter.
-Jay Satiro (21 Jun 2015)
-- [Lior Kaplan brought this change]
+- progress-bar: don't use stderr explicitly, use bar->out
+
+ Reported-By: Gisle Vanem
+ Bug: https://github.com/curl/curl/commit/993dd5651a6c853bfe3870f6a69c7b329fa4e8ce#commitcomment-27070080
- tool_help: fix --tlsv1 help text to use >= for TLSv1
+GitHub (24 Jan 2018)
+- [Gisle Vanem brought this change]
-- INSTALL: Advise use of non-native SSL for Windows <= XP
+ Fixes for MSDOS etc.
- Advise that WinSSL in versions <= XP will not be able to connect to
- servers that no longer support the legacy handshakes and algorithms used
- by those versions, and to use an alternate backend like OpenSSL instead.
+ djgpp do have 'mkdir(dir, mode)'. Other DOS-compilers does not
+ But djgpp seems the only choice for MSDOS anyway.
- Bug: https://github.com/bagder/curl/issues/253
- Reported-by: zenden2k <zenden2k@gmail.com>
-
-Kamil Dudka (19 Jun 2015)
-- curl_easy_setopt.3: restore contents removed by mistake
+ PellesC do have a 'F_OK' defined in it's <unistd.h>.
- ... in commit curl-7_43_0-18-g570076e
+ Update year in Copyright.
+
+- [Gisle Vanem brought this change]
-Daniel Stenberg (19 Jun 2015)
-- curl_easy_setopt.3: mention CURLOPT_PIPEWAIT
+ Fix small typo.
-Jay Satiro (18 Jun 2015)
-- cookie: Fix bug in export if any-domain cookie is present
-
- In 3013bb6 I had changed cookie export to ignore any-domain cookies,
- however the logic I used to do so was incorrect, and would lead to a
- busy loop in the case of exporting a cookie list that contained
- any-domain cookies. The result of that is worse though, because in that
- case the other cookies would not be written resulting in an empty file
- once the application is terminated to stop the busy loop.
+Version 7.58.0 (23 Jan 2018)
-Dan Fandrich (18 Jun 2015)
-- FTP: fixed compiling with --disable-proxy, broken in b88f980a
+Daniel Stenberg (23 Jan 2018)
+- RELEASE: 7.58.0
-Daniel Stenberg (18 Jun 2015)
-- tool: always provide negotiate/kerberos options
-
- libcurl can still be built with it, even if the tool is not. Maintain
- independence!
+- [Gisle Vanem brought this change]
-- TODO: Support IDNA2008
+ progress-bar: get screen width on windows
-- [Viktor Szakats brought this change]
+- test1454: --connect-to with IPv6 address w/o IPv6 support!
- Makefile.m32: add support for CURL_LDFLAG_EXTRAS
+- CONNECT_TO: fail attempt to set an IPv6 numerical without IPv6 support
+
+ Bug: https://curl.haxx.se/mail/lib-2018-01/0087.html
+ Reported-by: John Hascall
- It is similar to existing CURL_CFLAG_EXTRAS, but for
- extra linker option.
+ Closes #2257
-- RTSP: removed another piece of dead code
+- docs: fix man page syntax to make test 1140 OK again
+
+- http: prevent custom Authorization headers in redirects
+
+ ... unless CURLOPT_UNRESTRICTED_AUTH is set to allow them. This matches how
+ curl already handles Authorization headers created internally.
- Coverity CID 1306668
+ Note: this changes behavior slightly, for the sake of reducing mistakes.
+
+ Added test 317 and 318 to verify.
+
+ Reported-by: Craig de Stigter
+ Bug: https://curl.haxx.se/docs/adv_2018-b3bf.html
-- openssl: fix use of uninitialized buffer
+- curl: progress bar refresh, get width using ioctl()
+
+ Get screen width from the environment variable COLUMNS first, if set. If
+ not, use ioctl(). If nether works, assume 79.
+
+ Closes #2242
- Make sure that the error buffer is always initialized and simplify the
- use of it to make the logic easier.
+ The "refresh" is for the -# output when no total transfer size is
+ known. It will now only use a single updated line even for this case:
- Bug: https://github.com/bagder/curl/issues/318
- Reported-by: sneis
+ The "-=O=-" ship moves when data is transferred. The four flying
+ "hashes" move (on a sine wave) on each refresh, independent of data.
-- examples: more descriptions
+- RELEASE-NOTES: synced with bb0ffcc36
-- examples: add descriptions with <DESC>
-
- Using this fixed format for example descriptions, we can generate a
- better list on the web site.
+- libcurl-env.3: first take
-- libcurl-errors.3: fix typo
+- TODO: two possible name resolver improvements
-- curl_easy_setopt.3: option order doesn't matter
+- [Kartik Mahajan brought this change]
-- openssl: fix build with BoringSSL
+ http2: don't close connection when single transfer is stopped
- OPENSSL_load_builtin_modules does not exist in BoringSSL. Regression
- from cae43a1
+ Fixes #2237
+ Closes #2249
-- [Paul Howarth brought this change]
+- test558: fix for multissl builds
+
+ vtls.c:multissl_init() might do a curl_free() call so strip that out to
+ make this work with more builds. We just want to verify that
+ memorytracking works so skipping one line is no harm.
- openssl: Fix build with openssl < ~ 0.9.8f
+- examples/url2file.c: add missing curl_global_cleanup() call
- The symbol SSL3_MT_NEWSESSION_TICKET appears to have been introduced at
- around openssl 0.9.8f, and the use of it in lib/vtls/openssl.c breaks
- builds with older openssls (certainly with 0.9.8b, which is the latest
- older version I have to try with).
+ Reported-by: XhstormR on github
+ Fixes #2245
+
+- [Michael Gmelin brought this change]
-- FTP: do the HTTP CONNECT for data connection blocking
+ SSH: Fix state machine for ssh-agent authentication
- ** WORK-AROUND **
+ In case an identity didn't match[0], the state machine would fail in
+ state SSH_AUTH_AGENT instead of progressing to the next identity in
+ ssh-agent. As a result, ssh-agent authentication only worked if the
+ identity required happened to be the first added to ssh-agent.
- The introduced non-blocking general behaviour for Curl_proxyCONNECT()
- didn't work for the data connection establishment unless it was very
- fast. The newly introduced function argument makes it operate in a more
- blocking manner, more like it used to work in the past. This blocking
- approach is only used when the FTP data connecting through HTTP proxy.
+ This was introduced as part of commit c4eb10e2f06fbd6cc904f1d78e4, which
+ stated that the "else" statement was required to prevent getting stuck
+ in state SSH_AUTH_AGENT. Given the state machine's logic and libssh2's
+ interface I couldn't see how this could happen or reproduce it and I
+ also couldn't find a more detailed description of the problem which
+ would explain a test case to reproduce the problem this was supposed to
+ fix.
- Blocking like this is bad. A better fix would make it work more
- asynchronously.
+ [0] libssh2_agent_userauth returning LIBSSH2_ERROR_AUTHENTICATION_FAILED
- Bug: https://github.com/bagder/curl/issues/278
+ Closes #2248
-- bump: start the journey toward 7.44.0
-
-Jay Satiro (17 Jun 2015)
-- CURLOPT_ERRORBUFFER.3: Fix example, escape backslashes
-
-- CURLOPT_ERRORBUFFER.3: Improve example
-
-Version 7.43.0 (17 Jun 2015)
+- openssl: fix potential memory leak in SSLKEYLOGFILE logic
+
+ Coverity CID 1427646.
-Daniel Stenberg (17 Jun 2015)
-- RELEASE-NOTES: 7.43.0 release
+- openssl: fix the libressl build again
+
+ Follow-up to 84fcaa2e7. libressl does not have the API even if it says it is
+ late OpenSSL version...
+
+ Fixes #2246
+ Closes #2247
+
+ Reported-by: jungle-boogie on github
-- THANKS: updated with 7.43.0 names
+- unit1307: test many wildcards too
-- [Kamil Dudka brought this change]
+- curl_fnmatch: only allow 5 '*' sections in a single pattern
+
+ ... to avoid excessive recursive calls. The number 5 is totally
+ arbitrary and could be modified if someone has a good motivation.
- http: do not leak basic auth credentials on re-used connections
+- ftp-wildcard: fix matching an empty string with "*[^a]"
- CVE-2015-3236
+ .... and avoid advancing the pointer to trigger an out of buffer read.
- This partially reverts commit curl-7_39_0-237-g87c4abb
+ Detected by OSS-fuzz
+ Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5251
+ Assisted-by: Max Dymond
+
+- SMB: fix numeric constant suffix and variable types
+
+ 1. don't use "ULL" suffix since unsupported in older MSVC
+ 2. use curl_off_t instead of custom long long ifdefs
+ 3. make get_posix_time() not do unaligned data access
- Reported-by: Tomas Tomecek, Kamil Dudka
- Bug: http://curl.haxx.se/docs/adv_20150617A.html
+ Fixes #2211
+ Closes #2240
+ Reported-by: Chester Liu
-- [Kamil Dudka brought this change]
+- [rouzier brought this change]
- test2040: verify basic auth on re-used connections
+ CURLOPT_TCP_NODELAY.3: fix typo
+
+ Closes #2239
-- SMB: rangecheck values read off incoming packet
+- smtp/pop3/imap_get_message: decrease the data length too...
- CVE-2015-3237
+ Follow-up commit to 615edc1f73 which was incomplete.
- Detected by Coverity. CID 1299430.
+ Assisted-by: Max Dymond
+ Detected by OSS-fuzz
+ Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5206
+
+- openssl: enable SSLKEYLOGFILE support by default
- Bug: http://curl.haxx.se/docs/adv_20150617B.html
+ Fixes #2210
+ Closes #2236
-Jay Satiro (17 Jun 2015)
-- schannel: schannel_recv overhaul
+Patrick Monnerat (14 Jan 2018)
+- mime: clone mime tree upon easy handle duplication.
- This commit is several drafts squashed together. The changes from each
- draft are noted below. If any changes are similar and possibly
- contradictory the change in the latest draft takes precedence.
+ A mime tree attached to an easy handle using CURLOPT_MIMEPOST is
+ strongly bound to the handle: there is a pointer to the easy handle in
+ each item of the mime tree and following the parent pointer list
+ of mime items ends in a dummy part stored within the handle.
- Bug: https://github.com/bagder/curl/issues/244
- Reported-by: Chris Araman
+ Because of this binding, a mime tree cannot be shared between different
+ easy handles, thus it needs to be cloned upon easy handle duplication.
- %%
- %% Draft 1
- %%
- - return 0 if len == 0. that will have to be documented.
- - continue on and process the caches regardless of raw recv
- - if decrypted data will be returned then set the error code to CURLE_OK
- and return its count
- - if decrypted data will not be returned and the connection has closed
- (eg nread == 0) then return 0 and CURLE_OK
- - if decrypted data will not be returned and the connection *hasn't*
- closed then set the error code to CURLE_AGAIN --only if an error code
- isn't already set-- and return -1
- - narrow the Win2k workaround to only Win2k
+ There is no way for the caller to get the duplicated mime tree
+ handle: it is then set to be automatically destroyed upon freeing the
+ new easy handle.
- %%
- %% Draft 2
- %%
- - Trying out a change in flow to handle corner cases.
+ New test 654 checks proper mime structure duplication/release.
- %%
- %% Draft 3
- %%
- - Back out the lazier decryption change made in draft2.
+ Add a warning note in curl_mime_data_cb() documentation about sharing
+ user data between duplicated handles.
- %%
- %% Draft 4
- %%
- - Some formatting and branching changes
- - Decrypt all encrypted cached data when len == 0
- - Save connection closed state
- - Change special Win2k check to use connection closed state
+ Closes #2235
+
+- docs: comment about CURLE_READ_ERROR returned by curl_mime_filedata
+
+Daniel Stenberg (13 Jan 2018)
+- test395: HTTP with overflow Content-Length value
+
+- test394: verify abort of rubbish in Content-Length: value
+
+- test393: verify --max-filesize with excessive Content-Length
+
+- HTTP: bail out on negative Content-Length: values
- %%
- %% Draft 5
- %%
- - Default to CURLE_AGAIN in cleanup if an error code wasn't set and the
- connection isn't closed.
+ ... and make the max filesize check trigger if the value is too big.
- %%
- %% Draft 6
- %%
- - Save the last error only if it is an unrecoverable error.
+ Updates test 178.
- Prior to this I saved the last error state in all cases; unfortunately
- the logic to cover that in all cases would lead to some muddle and I'm
- concerned that could then lead to a bug in the future so I've replaced
- it by only recording an unrecoverable error and that state will persist.
+ Reported-by: Brad Spencer
+ Fixes #2212
+ Closes #2223
+
+Marcel Raad (13 Jan 2018)
+- [Dan Johnson brought this change]
+
+ configure.ac: append extra linker flags instead of prepending them.
- - Do not recurse on renegotiation.
+ Link order should list libraries after the libraries that use them,
+ so when we're guessing that we might also need to add -ldl in order
+ to use -lssl, we should add -ldl after -lssl.
- Instead we'll continue on to process any trailing encrypted data
- received during the renegotiation only.
+ Closes https://github.com/curl/curl/pull/2234
+
+Daniel Stenberg (13 Jan 2018)
+- RELEASE-NOTES: synced with 6fa10c8fa
+
+Jay Satiro (13 Jan 2018)
+- setopt: fix SSLVERSION to allow CURL_SSLVERSION_MAX_ values
- - Move the err checks in cleanup after the check for decrypted data.
+ Broken since f121575 (precedes 7.56.1).
- In either case decrypted data is always returned but I think it's easier
- to understand when those err checks come after the decrypted data check.
+ Bug: https://github.com/curl/curl/issues/2225
+ Reported-by: cmfrolick@users.noreply.github.com
- %%
- %% Draft 7
- %%
- - Regardless of len value go directly to cleanup if there is an
- unrecoverable error or a close_notify was already received. Prior to
- this change we only acknowledged those two states if len != 0.
+ Closes https://github.com/curl/curl/pull/2227
+
+Patrick Monnerat (13 Jan 2018)
+- setopt: reintroduce non-static Curl_vsetopt() for OS400 support
- - Fix a bug in connection closed behavior: Set the error state in the
- cleanup, because we don't know for sure it's an error until that time.
+ This also upgrades ILE/RPG bindings with latest setopt options.
- - (Related to above) In the case the connection is closed go "greedy"
- with the decryption to make sure all remaining encrypted data has been
- decrypted even if it is not needed at that time by the caller. This is
- necessary because we can only tell if the connection closed gracefully
- (close_notify) once all encrypted data has been decrypted.
+ Reported-By: jonrumsey on github
+ Fixes #2230
+ Closes #2233
+
+Jay Satiro (11 Jan 2018)
+- [Zhouyihai Ding brought this change]
+
+ http2: fix incorrect trailer buffer size
- - Do not renegotiate when an unrecoverable error is pending.
+ Prior to this change the stored byte count of each trailer was
+ miscalculated and 1 less than required. It appears any trailer
+ after the first that was passed to Curl_client_write would be truncated
+ or corrupted as well as the size. Potentially the size of some
+ subsequent trailer could be erroneously extracted from the contents of
+ that trailer, and since that size is used by client write an
+ out-of-bounds read could occur and cause a crash or be otherwise
+ processed by client write.
- %%
- %% Draft 8
- %%
- - Don't show 'server closed the connection' info message twice.
+ The bug appears to have been born in 0761a51 (precedes 7.49.0).
- - Show an info message if server closed abruptly (missing close_notify).
+ Closes https://github.com/curl/curl/pull/2231
-Daniel Stenberg (16 Jun 2015)
-- [Paul Oliver brought this change]
+- [Basuke Suzuki brought this change]
- Fix typo in docs
+ easy: fix connection ownership in curl_easy_pause
- s/curret/current/
+ Before calling Curl_client_chop_write(), change the owner of connection
+ to the current Curl_easy handle. This will fix the issue #2217.
+
+ Fixes https://github.com/curl/curl/issues/2217
+ Closes https://github.com/curl/curl/pull/2221
-- [Viktor Szakats brought this change]
+Daniel Stenberg (9 Jan 2018)
+- [Dimitrios Apostolou brought this change]
- docs: update URLs
+ system.h: Additionally check __LONG_MAX__ for defining curl_off_t
+
+ __SIZEOF_LONG__ was introduced in GCC 4.4, __LONG_MAX__ was introduced
+ in GCC 3.3.
+
+ Closes #2216
-- RELEASE-NOTES: synced with f29f2cbd00dbe5f
+- COPYING: it's 2018!
-- [Viktor Szakats brought this change]
+- progress: calculate transfer speed on milliseconds if possible
+
+ to increase accuracy for quick transfers
+
+ Fixes #2200
+ Closes #2206
- README: use secure protocol for Git repository
+Jay Satiro (7 Jan 2018)
+- scripts: allow all perl scripts to be run directly
+
+ - Enable execute permission (chmod +x)
+
+ - Change interpreter to /usr/bin/env perl
+
+ Closes https://github.com/curl/curl/pull/2222
-- [Viktor Szakats brought this change]
+- mail-rcpt.d: fix short-text description
- HTTP2.md: use SSL/TLS IETF URLs
+- build: remove HAVE_LIMITS_H check
+
+ .. because limits.h presence isn't optional, it's required by C89.
+
+ Ref: http://port70.net/~nsz/c/c89/c89-draft.html#2.2.4.2
+
+ Closes https://github.com/curl/curl/pull/2215
-- [Viktor Szakats brought this change]
+- openssl: fix memory leak of SSLKEYLOGFILE filename
+
+ - Free the copy of SSLKEYLOGFILE env returned by curl_getenv during ossl
+ initialization.
+
+ Caught by ASAN.
- LICENSE-MIXING: update URLs
+- Revert "curl/system.h: fix compilation with gcc on AIX PPC and IA64 HP-UX"
+
+ This reverts commit c97648b55080343bb371522bf4233e94a2a13a99.
- * use SSL/TLS where available
- * follow permanent redirects
+ SIZEOF_LONG should not be checked in system.h since that macro is only
+ defined when building libcurl.
+
+ Ref: https://github.com/curl/curl/pull/2186#issuecomment-354767080
+ Ref: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
-- LICENSE-MIXING: refreshed
+Michael Kaufmann (30 Dec 2017)
+- test1554: improve the error handling
-- curl_easy_duphandle: see also *reset
+- test1554: add global initialization and cleanup
-- rtsp_do: fix DEAD CODE
-
- "At condition p_request, the value of p_request cannot be NULL."
+Daniel Stenberg (29 Dec 2017)
+- curl_version_info.3: call the argument 'age'
- Coverity CID 1306668.
+ Reported-by: Pete Lomax
+ Bug: https://curl.haxx.se/mail/lib-2017-12/0074.html
-- security:choose_mech fix DEAD CODE warning
+Patrick Monnerat (27 Dec 2017)
+- [Mikalai Ananenka brought this change]
+
+ brotli: data at the end of content can be lost
- ... by removing the "do {} while (0)" block.
+ Decoding loop implementation did not concern the case when all
+ received data is consumed by Brotli decoder and the size of decoded
+ data internally hold by Brotli decoder is greater than CURL_MAX_WRITE_SIZE.
+ For content with unencoded length greater than CURL_MAX_WRITE_SIZE this
+ can result in the loss of data at the end of content.
- Coverity CID 1306669
-
-- curl.1: netrc is in man section 5
+ Closes #2194
-- curl.1: small format fix
+Jay Satiro (26 Dec 2017)
+- examples/cacertinmem: ignore cert-already-exists error
- use \fI-style instead of .BR for references
-
-- urldata: store POST size in state.infilesize too
+ - Ignore X509_R_CERT_ALREADY_IN_HASH_TABLE errors in the CTX callback
+ since it's possible the cert may have already been loaded by libcurl.
+
+ - Remove the EXAMPLE code in the CURLOPT_SSL_CTX_FUNCTION.3 doc.
+ Instead have it direct the reader to this cacertinmem.c example.
- ... to simplify checking when PUT _or_ POST have completed.
+ - Fix the CA certificate to use the right CA for example.com, Digicert.
- Reported-by: Frank Meier
- Bug: http://curl.haxx.se/mail/lib-2015-06/0019.html
+ Bug: https://curl.haxx.se/mail/lib-2017-12/0057.html
+ Reported-by: Thomas van Hesteren
+
+ Closes https://github.com/curl/curl/pull/2182
-Dan Fandrich (14 Jun 2015)
-- test1530: added http to required features
+- [Gisle Vanem brought this change]
-Jay Satiro (14 Jun 2015)
-- [Drake Arconis brought this change]
+ tool_getparam: Support size modifiers for --max-filesize
+
+ - Move the size modifier detection code from limit-rate to its own
+ function so that it can also be used with max-filesize.
+
+ Size modifiers are the suffixes such as G (gigabyte), M (megabyte) etc.
+
+ For example --max-filesize 1G
+
+ Ref: https://curl.haxx.se/mail/archive-2017-12/0000.html
+
+ Closes https://github.com/curl/curl/pull/2179
- build: Fix typo from OpenSSL 1.0.2 version detection fix
+Steve Holme (22 Dec 2017)
+- build: Fixed incorrect script termination from commit ad1dc10e61
-- [Drake Arconis brought this change]
+- Makefile.vc: Added our standard copyright header
- build: Properly detect OpenSSL 1.0.2 when using configure
+- winbuild: Added support for VC15
-- curl_multi_info_read.3: fix example formatting
+- build: Added Visual Studio 2017 project files
-Daniel Stenberg (13 Jun 2015)
-- BINDINGS: there's a new R binding in town!
+- build-wolfssl.bat: Added support for VC15
-- BINDINGS: added the Xojo binding
+- build-openssl.bat: Added support for VC15
-Jay Satiro (11 Jun 2015)
-- [Joel Depooter brought this change]
+Jay Satiro (22 Dec 2017)
+- [Dimitrios Apostolou brought this change]
- schannel: Add support for optional client certificates
+ curl/system.h: fix compilation with gcc on AIX PPC and IA64 HP-UX
- Some servers will request a client certificate, but not require one.
- This change allows libcurl to connect to such servers when using
- schannel as its ssl/tls backend. When a server requests a client
- certificate, libcurl will now continue the handshake without one,
- rather than terminating the handshake. The server can then decide
- if that is acceptable or not. Prior to this change, libcurl would
- terminate the handshake, reporting a SEC_I_INCOMPLETE_CREDENTIALS
- error.
-
-Daniel Stenberg (11 Jun 2015)
-- curl_easy_cleanup.3: provide more SEE ALSO
+ Closes https://github.com/curl/curl/pull/2186
-- debug: remove http2 debug leftovers
+- [Mattias Fornander brought this change]
-- VERSIONS: now using markdown
-
-- RELEASE-PROCEDURE: remove ascii logo at the top of file
-
-- INTERNALS: absorbed docs/LIBCURL-STRUCTS
+ examples/rtsp: fix error handling macros
+
+ Closes https://github.com/curl/curl/pull/2185
-- INTERNALS: cat lib/README* >> INTERNALS
+Patrick Monnerat (20 Dec 2017)
+- curl_easy_reset: release mime-related data.
- and a conversion to markdown. Removed the lib/README.* files. The idea
- being to move toward having INTERNALS as the one and only "book" of
- internals documentation.
+ Move curl_mime_initpart() and curl_mime_cleanpart() calls to lower-level
+ functions dealing with UserDefined structure contents.
+ This avoids memory leakages on curl-generated part mime headers.
+ New test 2073 checks this using the cli tool --next option: it
+ triggers a valgrind error if bug is present.
- Added a TOC to top of the document.
+ Bug: https://curl.haxx.se/mail/lib-2017-12/0060.html
+ Reported-by: Martin Galvan
-Jay Satiro (8 Jun 2015)
-- openssl: LibreSSL and BoringSSL do not use TLS_client_method
+- content_encoding: rework zlib_inflate
- Although OpenSSL 1.1.0+ deprecated SSLv23_client_method in favor of
- TLS_client_method LibreSSL and BoringSSL didn't and still use
- SSLv23_client_method.
+ - When zlib version is < 1.2.0.4, process gzip trailer before considering
+ extra data as an error.
+ - Inflate with Z_BLOCK instead of Z_SYNC_FLUSH to maximize correct data
+ and minimize corrupt data output.
+ - Do not try to restart deflate decompression in raw mode if output has
+ started or if the leading data is not available anymore.
+ - New test 232 checks inflating raw-deflated content.
- Bug: https://github.com/bagder/curl/commit/49a6642#commitcomment-11578009
- Reported-by: asavah@users.noreply.github.com
+ Closes #2068
-Daniel Stenberg (9 Jun 2015)
-- RELEASE-NOTES: synced with 20ac3458068
+- brotli: allow compiling with version 0.6.0.
+
+ Some error codes were not yet defined in brotli 0.6.0: do not issue code
+ for them in this case.
-- CURLOPT_OPENSOCKETFUNCTION: return error at once
+Daniel Stenberg (13 Dec 2017)
+- CURLOPT_READFUNCTION.3: refer to argument with correct name
- When CURL_SOCKET_BAD is returned in the callback, it should be treated
- as an error (CURLE_COULDNT_CONNECT) if no other socket is subsequently
- created when trying to connect to a server.
+ Bug: #2175
- Bug: http://curl.haxx.se/mail/lib-2015-06/0047.html
+ [ci skip]
-- fopen.c: fix a few compiler warnings
-
-- [Ville Skyttä brought this change]
-
- docs: Spelling fixes
-
-- [Ville Skyttä brought this change]
+- rand: add a clang-analyzer work-around
+
+ scan-build would warn on a potential access of an uninitialized
+ buffer. I deem it a false positive and had to add this somewhat ugly
+ work-around to silence it.
- docs: man page indentation and syntax fixes
+- krb5: fix a potential access of uninitialized memory
+
+ A scan-build warning.
-Linus Nielsen (8 Jun 2015)
-- help: Add --proxy-service-name and --service-name to the --help output
+- conncache: fix a return code [regression]
+
+ This broke in 07cb27c98e. Make sure to return 'result' properly. Pointed
+ out by scan-build!
-Jay Satiro (7 Jun 2015)
-- openssl: Fix verification of server-sent legacy intermediates
+- curl: support >256 bytes warning messsages
- - Try building a chain using issuers in the trusted store first to avoid
- problems with server-sent legacy intermediates.
+ Bug: #2174
+
+Michael Kaufmann (12 Dec 2017)
+- libssh: fix a syntax error in configure.ac
- Prior to this change server-sent legacy intermediates with missing
- legacy issuers would cause verification to fail even if the client's CA
- bundle contained a valid replacement for the intermediate and an
- alternate chain could be constructed that would verify successfully.
+ Follow-up to c92d2e1
- https://rt.openssl.org/Ticket/Display.html?id=3621&user=guest&pass=guest
+ Closes #2172
-Daniel Stenberg (5 Jun 2015)
-- BINDINGS: update several URLs
+Daniel Stenberg (12 Dec 2017)
+- examples/smtp-mail.c: use separate defines for options and mail
- Stop linking to the curl.haxx.se anchor pages, they are usually only
- themselves pointers to the real page so better point there directly
- instead.
-
-- BINDINGS: the curl-rust binding
-
-- curl.h: add CURL_HTTP_VERSION_2
+ ... to make it clearer that the options want address-only, while the
+ headers in an email can also have the real name.
- The protocol is named "HTTP/2" after all. It is an alias for the
- existing CURL_HTTP_VERSION_2_0 enum.
+ Assisted-by: Sean MacLennan
-- openssl: removed error string #ifdef
+- THANKS: added missing names
- ERR_error_string_n() was introduced in 0.9.6, no need to #ifdef anymore
+ ... as I reran the contrithanks script after the mailmap name fixups.
-- openssl: removed USERDATA_IN_PWD_CALLBACK kludge
-
- Code for OpenSSL 0.9.4 serves no purpose anymore!
+- mailmap: added/clarified several names
-- openssl: remove SSL_get_session()-using code
+- setopt: less *or equal* than INT_MAX/1000 should be fine
- It was present for OpenSSL 0.9.5 code but we only support 0.9.7 or
- later.
-
-- openssl: remove dummy callback use from SSL_CTX_set_verify()
+ ... for the CURLOPT_TIMEOUT, CURLOPT_CONNECTTIMEOUT and
+ CURLOPT_SERVER_RESPONSE_TIMEOUT range checks.
- The existing callback served no purpose.
+ Reported-by: Dominik Hölzl
+ Bug: https://curl.haxx.se/mail/lib-2017-12/0037.html
+
+ Closes #2173
-- LIBCURL-STRUCTS: clarify for multiplexing
+- [Dmitry Kostjuchenko brought this change]
-Jay Satiro (3 Jun 2015)
-- cookie: Stop exporting any-domain cookies
+ vtls: replaced getenv() with curl_getenv()
- Prior to this change any-domain cookies (cookies without a domain that
- are sent to any domain) were exported with domain name "unknown".
+ Fixed undefined symbol of getenv() which does not exist when compiling
+ for Windows 10 App (CURL_WINDOWS_APP). Replaced getenv() with
+ curl_getenv() which is aware of getenv() absence when CURL_WINDOWS_APP
+ is defined.
- Bug: https://github.com/bagder/curl/issues/292
+ Closes #2171
-Daniel Stenberg (3 Jun 2015)
-- RELEASE-PROCEDURE: refreshed 'coming dates'
+- RELEASE-NOTES: synced with 3b9ea70ee
-Jay Satiro (2 Jun 2015)
-- curl_setup: Change fopen text macros to use 't' for MSDOS
+- TODO: Expose tried IP addresses that failed
- Bug: https://github.com/bagder/curl/pull/258#issuecomment-107915198
- Reported-by: Gisle Vanem
+ Suggested-by: Rainer Canavan
+
+ Closes #2126
-Daniel Stenberg (2 Jun 2015)
-- curl_multi_timeout.3: added example
+- curl.1: mention http:// and https:// as valid proxy prefixes
-- curl_multi_perform.3: added example
+- curl.1: documented two missing valid exit codes
-- curl_multi_info_read.3: added example
+- CURLOPT_DNS_LOCAL_IP4.3: fixed the seel also to not self-reference
-- checksrc: detect fopen() for text without the FOPEN_* macros
+- Revert "curl: don't set CURLOPT_INTERLEAVEDATA"
- Follow-up to e8423f9ce150 with discussionis in
- https://github.com/bagder/curl/pull/258
+ This reverts commit 9ffad8eb1329bb35c8988115ac7ed85cf91ef955.
- This check scans for fopen() with a mode string without 'b' present, as
- it may indicate that an FOPEN_* define should rather be used.
+ It was actually added rather recently in 8e8afa82cbb629 due to a crash
+ that would otherwise happen in the RTSP code. As I don't think we've
+ fixed that behavior yet, we better keep this work-around until we have
+ fixed it better.
+
+Michael Kaufmann (10 Dec 2017)
+- tests: mark data files as non-executable in git
-- curl_getdate.3: update RFC reference
+- tests: update .gitignore for libtests
-Jay Satiro (1 Jun 2015)
-- curl_setup: Add macros for FOPEN_READTEXT, FOPEN_WRITETEXT
+Daniel Stenberg (10 Dec 2017)
+- multi_done: prune DNS cache
- - Change fopen calls to use FOPEN_READTEXT instead of "r" or "rt"
- - Change fopen calls to use FOPEN_WRITETEXT instead of "w" or "wt"
+ Prune the DNS cache immediately after the dns entry is unlocked in
+ multi_done. Timed out entries will then get discarded in a more orderly
+ fashion.
- This change is to explicitly specify when we need to read/write text.
- Unfortunately 't' is not part of POSIX fopen so we can't specify it
- directly. Instead we now have FOPEN_READTEXT, FOPEN_WRITETEXT.
+ Test506 is updated
- Prior to this change we had an issue on Windows if an application that
- uses libcurl overrides the default file mode to binary. The default file
- mode in Windows is normally text mode (translation mode) and that's what
- libcurl expects.
+ Reported-by: Oleg Pudeyev
- Bug: https://github.com/bagder/curl/pull/258#issuecomment-107093055
- Reported-by: Orgad Shaneh
+ Fixes #2169
+ Closes #2170
-Daniel Stenberg (1 Jun 2015)
-- http2-upload.c: use PIPEWAIT for playing HTTP/2 better
+- mailmap: fixup two old git Author "aliases"
-- http2-download: check for CURLPIPE_MULTIPLEX properly
+Jay Satiro (10 Dec 2017)
+- openssl: Disable file buffering for Win32 SSLKEYLOGFILE
- Bug: http://curl.haxx.se/mail/lib-2015-06/0001.html
- Reported-by: Rafayel Mkrtchyan
-
-- [Isaac Boukris brought this change]
+ Prior to this change SSLKEYLOGFILE used line buffering on WIN32 just
+ like it does for other platforms. However, the Windows CRT does not
+ actually support line buffering (_IOLBF) and will use full buffering
+ (_IOFBF) instead. We can't use full buffering because multiple processes
+ may be writing to the file and that could lead to corruption, and since
+ full buffering is the only buffering available this commit disables
+ buffering for Windows SSLKEYLOGFILE entirely (_IONBF).
+
+ Ref: https://github.com/curl/curl/pull/1346#issuecomment-350530901
- HTTP-NTLM: fail auth on connection close instead of looping
+Daniel Stenberg (10 Dec 2017)
+- RESOLVE: output verbose text when trying to set a duplicate name
- Bug: https://github.com/bagder/curl/issues/256
+ ... to help users understand what is or isn't done!
-- 5.6 Refuse "downgrade" redirects
+- CURLOPT_DNS_CACHE_TIMEOUT.3: see also CURLOPT_RESOLVE
-- README.pingpong: removed
+- [John DeHelian brought this change]
-- ROADMAP: remove HTTP/2 multiplexing - its here now
+ sftp: allow quoted commands to use relative paths
+
+ Closes #1900
-- HTTP2.md: formatted properly
+Jay Satiro (8 Dec 2017)
+- [Richard Alcock brought this change]
-- HTTP2: moved docs into docs/ and make it markdown
-
-- README.http2: refreshed and added multiplexing info
-
-- dist: add the http2 examples
+ CURLOPT_PRIVATE.3: fix grammar
+
+ - Change "never does nothing" double-negative to "never does anything".
+
+ Closes https://github.com/curl/curl/pull/2168
-- http2 examples: clean up some comments
+Daniel Stenberg (8 Dec 2017)
+- curl: remove __EMX__ #ifdefs
+
+ These are OS/2-specific things added to the code in the year 2000. They
+ were always ugly. If there's any user left, they still don't need it
+ done this way.
+
+ Closes #2166
-- examples: added two programs doing multiplexed HTTP/2
+Jay Satiro (8 Dec 2017)
+- openssl: improve data-pending check for https proxy
+
+ - Allow proxy_ssl to be checked for pending data even when connssl does
+ not yet have an SSL handle.
+
+ This change is for posterity. Currently there doesn't seem to be a code
+ path that will cause a pending data check when proxyssl could have
+ pending data and the connssl handle doesn't yet exist [1].
+
+ [1]: Recall that an https proxy connection starts out in connssl but if
+ the destination is also https then the proxy SSL backend data is moved
+ from connssl to proxyssl, which means connssl handle is temporarily
+ empty until an SSL handle for the destination can be created.
+
+ Ref: https://github.com/curl/curl/commit/f4a6238#commitcomment-24396542
+
+ Closes https://github.com/curl/curl/pull/1916
-- scripts: moved contributors.sh and contrithanks.sh into subdir
+Daniel Stenberg (8 Dec 2017)
+- curl: don't set CURLOPT_INTERLEAVEDATA
+
+ That data is only ever used by the CURLOPT_INTERLEAVEFUNCTION callback
+ and that option isn't set or used by the curl tool!
+
+ Updates the 9 tests that verify --libcurl
+
+ Closes #2167
-- RELEASE-NOTES: synced with c005790ff1c0a
+- curl.h: remove incorrect comment about ERRORBUFFER
+
+ ... error messages are _not_ sent to stderr if this is not set.
-- [Daniel Melani brought this change]
+- [Michael Felt brought this change]
- openssl: typo in comment
+ configure: add AX_CODE_COVERAGE only if using gcc
+
+ Fixes #2076
+ Closes #2125
-Jay Satiro (27 May 2015)
-- openssl: Use TLS_client_method for OpenSSL 1.1.0+
+- curl: limit -# update frequency for unknown total size
- SSLv23_client_method is deprecated starting in OpenSSL 1.1.0. The
- equivalent is TLS_client_method.
+ Make it use a max 10Hz update frequency for this case as well. Return
+ early if the "point" hasn't moved since last invoke.
- https://github.com/openssl/openssl/commit/13c9bb3#diff-708d3ae0f2c2973b272b811315381557
-
-Daniel Stenberg (26 May 2015)
-- FAQ: How do I port libcurl to my OS?
+ Reported-by: Elliot Saba
+
+ Fixes #2158
+ Closes #2163
-Jay Satiro (25 May 2015)
-- CURLOPT_COOKIELIST.3: Explain Set-Cookie without a domain
+- BINDINGS: another PostgreSQL client
- Document that if Set-Cookie is used without a domain then the cookie is
- sent for any domain and will not be modified.
+ ...the former link is dead.
- Bug: http://curl.haxx.se/mail/lib-2015-05/0137.html
- Reported-by: Alexander Dyagilev
+ Reported-by: Frank Gevaerts
-Daniel Stenberg (25 May 2015)
-- [Tatsuhiro Tsujikawa brought this change]
+- [Zachary Seguin brought this change]
- http2: Copy data passed in Curl_http2_switched into HTTP/2 connection buffer
+ CONNECT: keep close connection flag in http_connect_state struct
- Previously, after seeing upgrade to HTTP/2, we feed data followed by
- upgrade response headers directly to nghttp2_session_mem_recv() in
- Curl_http2_switched(). But it turns out that passed buffer, mem, is
- part of stream->mem, and callbacks called by
- nghttp2_session_mem_recv() will write stream specific data into
- stream->mem, overwriting input data. This will corrupt input, and
- most likely frame length error is detected by nghttp2 library. The
- fix is first copy the passed data to HTTP/2 connection buffer,
- httpc->inbuf, and call nghttp2_session_mem_recv().
+ Fixes #2088
+ Closes #2157
+
+- [Per Malmberg brought this change]
-Jay Satiro (24 May 2015)
-- CURLOPT_COOKIE.3: Explain that the cookies won't be modified
+ include: get netinet/in.h before linux/tcp.h
- The CURLOPT_COOKIE doc says it "sets the cookie header explicitly in the
- outgoing request(s)." However there seems to be some user confusion
- about cookie modification. Document that the cookies set by this option
- are not modified by the cookie engine.
+ ... to allow build on older Linux dists (specifically CentOS 4.8 on gcc
+ 4.8.5)
- Bug: http://curl.haxx.se/mail/lib-2015-05/0115.html
- Reported-by: Alexander Dyagilev
+ Closes #2160
-- CURLOPT_COOKIELIST.3: Add example
+- openldap: fix checksrc nits
+
+- [Stepan Broz brought this change]
+
+ openldap: add commented out debug possibilities
+
+ ... to aid debugging openldap library using its built-in debug messages.
+
+ Closes #2159
-Dan Fandrich (24 May 2015)
-- testcurl.pl: use rel2abs to make the source directory absolute
+- examples: move threaded-shared-conn.c to the "complicated" ones
- This function makes a platform-specific absolute path which uses
- backslashes on Windows. This form works when passing it on the
- command-line, as well as if the source is on another drive.
+ ... due it relying on pthreads to link.
-- conncache: fixed memory leak on OOM (torture tests)
+- RELEASE-NOTES: synced with b261c44e8
+
+ ... and bump next release version to 7.58.0
-Daniel Stenberg (24 May 2015)
-- perl: remove subdir, not touched in 9 years
+- [Jan Ehrhardt brought this change]
-- log2changes.pl: moved to scripts/
+ URL: tolerate backslash after drive letter for FILE:
+
+ ... as in "file://c:\some\path\curl.out"
+
+ Reviewed-by: Matthew Kerwin
+ Closes #2154
-- [Alessandro Ghedini brought this change]
+- [Randall S. Becker brought this change]
- scripts: add zsh.pl for generating zsh completion
+ tests: added netinet/in6.h includes in test servers
-Dan Fandrich (23 May 2015)
-- test1510: another flaky test
+- [Randall S. Becker brought this change]
-Daniel Stenberg (22 May 2015)
-- security: fix "Unchecked return value" from sscanf()
+ configure: check for netinet/in6.h
- By (void) prefixing it and adding a comment. Did some minor related
- cleanups.
+ Needed by HPE NonStop NSE and NSX systems
- Coverity CID 1299423.
+ Fixes #2146
+ Closes #2155
-- security: simplify choose_mech
+- curl-config: add --ssl-backends
- Coverity CID 1299424 identified dead code because of checks that could
- never equal true (if the mechanism's name was NULL).
+ Lists all SSL backends that were enabled at build-time.
- Simplified the function by removing a level of pointers and removing the
- loop and array that weren't used.
+ Suggested-by: Oleg Pudeyev
+ Fixes #2128
-- RTSP: catch attempted unsupported requests better
+- conncache: only allow multiplexing within same multi handle
- Replace use of assert with code that properly catches bad input at
- run-time even in non-debug builds.
+ Connections that are used for HTTP/1.1 Pipelining or HTTP/2 multiplexing
+ only get additional transfers added to them if the existing connection
+ is held by the same multi or easy handle. libcurl does not support doing
+ HTTP/2 streams in different threads using a shared connection.
- This flaw was sort of detected by Coverity CID 1299425 which claimed the
- "case RTSPREQ_NONE" was dead code.
+ Closes #2152
-- share_init: fix OOM crash
+- threaded-shared-conn.c: fixed typo in commenta
+
+- threaded-shared-conn.c: new example
+
+- conncache: fix several lock issues
- A failed calloc() would lead to NULL pointer use.
+ If the lock is released before the dealings with the bundle is over, it may
+ have changed by another thread in the mean time.
- Coverity CID 1299427.
+ Fixes #2132
+ Fixes #2151
+ Closes #2139
-- parse_proxy: switch off tunneling if non-HTTP proxy
+- libssh: remove dead code in sftp_qoute
- non-HTTP proxy implies not using CURLOPT_HTTPPROXYTUNNEL
+ ... by removing a superfluous NULL pointer check that also confuses
+ Coverity.
- Bug: http://curl.haxx.se/mail/lib-2015-05/0056.html
- Reported-by: Sean Boudreau
+ Fixes #2143
+ Closes #2153
-- curl: fix potential NULL dereference
+- sasl_getmesssage: make sure we have a long enough string to pass
+
+ For pop3/imap/smtp, added test 891 to somewhat verify the pop3
+ case.
+
+ For this, I enhanced the pingpong test server to be able to send back
+ responses with LF-only instead of always using CRLF.
- Coverity CID 1299428: Dereference after null check (FORWARD_NULL)
+ Closes #2150
-- http2: on_frame_recv: return early on stream 0
+- libssh2: remove dead code from SSH_SFTP_QUOTE
- Coverity CID 1299426 warned about possible NULL dereference otherwise,
- but that would only ever happen if we get invalid HTTP/2 data with
- frames for stream 0. Avoid this risk by returning early when stream 0 is
- used.
+ Figured out while reviewing code in the libssh backend. The pointer was
+ checked for NULL after having been dereferenced, so we know it would
+ always equal true or it would've crashed.
+
+ Pointed-out-by: Nikos Mavrogiannopoulos
+
+ Bug #2143
+ Closes #2148
-- http: removed self assignment
+- ssh-libssh.c: please checksrc
+
+Nikos Mavrogiannopoulos (4 Dec 2017)
+- libssh: fixed dereference in statvfs access
- Follow-up fix from b0143a2a33f0
+ The behavior is now equivalent to ssh.c when SSH_SFTP_QUOTE_STATVFS
+ handling fails.
- Detected by coverity. CID 1299429
+ Fixes #2142
-- [Tatsuhiro Tsujikawa brought this change]
+Daniel Stenberg (4 Dec 2017)
+- [Guitared brought this change]
- http2: Make HTTP Upgrade work
+ RESOURCES: update spec names
- This commit just add implicitly opened stream 1 to streams hash.
+ Closes #2145
-Jay Satiro (22 May 2015)
-- strerror: Change SEC_E_ILLEGAL_MESSAGE description
+Nikos Mavrogiannopoulos (3 Dec 2017)
+- libssh: corrected use of sftp_statvfs() in SSH_SFTP_QUOTE_STATVFS
- Prior to this change the description for SEC_E_ILLEGAL_MESSAGE was OS
- and language specific, and invariably translated to something not very
- helpful like: "The message received was unexpected or badly formatted."
+ The previous code was incorrectly following the libssh2 error detection
+ for libssh2_sftp_statvfs, which is not correct for libssh's sftp_statvfs.
- Bug: https://github.com/bagder/curl/issues/267
- Reported-by: Michael Osipov
-
-- telnet: Fix read-callback change for Windows builds
+ Fixes #2142
- Refer to b0143a2 for more information on the read-callback change.
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
-Daniel Stenberg (21 May 2015)
-- CURLOPT_HTTPPROXYTUNNEL.3: only works with a HTTP proxy!
-
-Dan Fandrich (21 May 2015)
-- testcurl.pl: allow source to be in an arbitrary directory
+- libssh: no need to call sftp_get_error as ssh_get_error is sufficient
- This way, the build directory can be located on an entirely different
- filesystem from the source code (e.g. a tmpfs).
-
-Daniel Stenberg (20 May 2015)
-- read_callback: move to SessionHandle from connectdata
+ Fixes #2141
- With many easy handles using the same connection for multiplexing, it is
- important we store and keep the transfer-oriented stuff in the
- SessionHandle so that callbacks and callback data work fine even when
- many easy handles share the same physical connection.
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
-- http2: show stream IDs in decimal
+Daniel Stenberg (2 Dec 2017)
+- libssh: fix minor static code analyzer nits
- It makes them easier to match output from the nghttpd test server.
-
-- [Tatsuhiro Tsujikawa brought this change]
-
- http2: Faster http2 upload
+ - remove superfluous NULL check which otherwise tricks the static code
+ analyzers to assume NULL pointer dereferences.
- Previously, when we send all given buffer in data_source_callback, we
- return NGHTTP2_ERR_DEFERRED, and nghttp2 library removes this stream
- temporarily for writing. This itself is good. If this is the sole
- stream in the session, nghttp2_session_want_write() returns zero,
- which means that libcurl does not check writeability of the underlying
- socket. This leads to very slow upload, because it seems curl only
- upload 16k something per 1 second. To fix this, if we still have data
- to send, call nghttp2_session_resume_data after nghttp2_session_send.
- This makes nghttp2_session_want_write() returns nonzero (if connection
- window still opens), and as a result, socket writeability is checked,
- and upload speed becomes normal.
-
-- [Dmitry Eremin-Solenikov brought this change]
-
- gtls: don't fail on non-fatal alerts during handshake
+ - fix fallthrough in switch()
- Stop curl from failing when non-fatal alert is received during
- handshake. This e.g. fixes lots of problems when working with https
- sites through proxies.
+ - indent mistake
-- curl_easy_unescape.3: update RFC reference
+- openssl: pkcs12 is supported by boringssl
- Reported-by: bsammon
- Bug: https://github.com/bagder/curl/issues/282
-
-Jay Satiro (20 May 2015)
-- CURLOPT_POSTFIELDS.3: Mention curl_easy_escape
+ Removes another #ifdef for BoringSSL
- .. also correct some variable naming in curl_easy_escape.3
+ Pointed-out-by: David Benjamin
- Bug: https://github.com/bagder/curl/issues/281
- Reported-by: bsammon@users.noreply.github.com
+ Closes #2134
-Daniel Stenberg (19 May 2015)
-- [Brian Prodoehl brought this change]
+- [Jay Satiro brought this change]
- openssl: Use SSL_CTX_set_msg_callback and SSL_CTX_set_msg_callback_arg
+ travis: use pip2 instead of pip
- BoringSSL removed support for direct callers of SSL_CTX_callback_ctrl
- and SSL_CTX_ctrl, so move to a way that should work on BoringSSL and
- OpenSSL.
+ .. since now mac osx image expects pip2 or pip3, and doesn't know pip:
- re #275
-
-Jay Satiro (19 May 2015)
-- curl.1: fix missing space in section --data
+ 0.01s$ pip install --user cpp-coveralls
+ /Users/travis/.travis/job_stages: line 57: pip: command not found
+
+ Ref: https://github.com/travis-ci/travis-ci/issues/8829
+
+ Closes https://github.com/curl/curl/pull/2133
-Daniel Stenberg (19 May 2015)
-- transfer: remove erroneous and misleading comment
+- [Nikos Mavrogiannopoulos brought this change]
-Kamil Dudka (19 May 2015)
-- http: silence compile-time warnings without USE_NGHTTP2
+ lib582: do not verify host for SFTP
+
+ This SFTP test fails with libssh back-end due to failure to verify
+ the peer. Disable peer verification in the test as there seems to
+ be the intention of the test.
- Error: CLANG_WARNING:
- lib/http.c:173:16: warning: Value stored to 'http' during its initialization is never read
+ Note that the libssh back-end automatically verifies the peer's
+ host using the default known_hosts file.
- Error: COMPILER_WARNING:
- lib/http.c: scope_hint: In function ‘http_disconnect’
- lib/http.c:173:16: warning: unused variable ‘http’ [-Wunused-variable]
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
-Jay Satiro (19 May 2015)
-- transfer: Replace __func__ instances with function name
+- [Nikos Mavrogiannopoulos brought this change]
+
+ libssh: added SFTP support
- .. also make __func__ replacement in multi.
+ The SFTP back-end supports asynchronous reading only, limited
+ to 32-bit file length. Writing is synchronous with no other
+ limitations.
- Prior to this change debug builds would fail to build if the compiler
- was building pre-c99 and didn't support __func__.
-
-Daniel Stenberg (19 May 2015)
-- [Viktor Szakats brought this change]
+ This also brings keyboard-interactive authentication.
+
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
- build: bump version in default nghttp2 paths
+- [Nikos Mavrogiannopoulos brought this change]
-- INTERNALS: we require nghttp2 1.0.0+ now
+ symbols-in-versions: added new symbols with 7.56.3 version
+
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
-Jay Satiro (18 May 2015)
-- http: Add some include guards for the new HTTP/2 stuff
+- [Nikos Mavrogiannopoulos brought this change]
-Daniel Stenberg (18 May 2015)
-- http2: store upload state per stream
+ .travis.yml: added build --with-libssh
- Use a curl_off_t for upload left
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
-- http2: fix build when NOT h2-enabled
+- [Nikos Mavrogiannopoulos brought this change]
-- http2: switch to use Curl_hash_destroy()
+ libssh2: return CURLE_UPLOAD_FAILED on failure to upload
- as after 4883f7019d3, the *_clean() function only flushes the hash.
-
-- curlver: restore LIBCURL_VERSION_NUM defined as a full number
+ This brings its in sync with the error code returned by the
+ libssh backend.
- As it breaks configure, curl-config and test 1023 if not.
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
-- [Anthony Avina brought this change]
+- [Nikos Mavrogiannopoulos brought this change]
- hostip: fix unintended destruction of hash table
+ libssh2: send the correct CURLE error code on scp file not found
+
+ That also updates tests to expect the right error code
+
+ libssh2 back-end returns CURLE_SSH error if the remote file
+ is not found. Expect instead CURLE_REMOTE_FILE_NOT_FOUND
+ which is sent by the libssh backend.
- .. and added unit1602 for hash.c
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
-- curlver: introducing new version number (checking) macros
+- [Nikos Mavrogiannopoulos brought this change]
-- runtests.pl: use 'h2c' now, no -14 anymore
+ Added support for libssh SSH SCP back-end
+
+ libssh is an alternative library to libssh2.
+ https://www.libssh.org/
+
+ That patch set also introduces support for ECDSA
+ ed25519 keys, as well as gssapi authentication.
+
+ Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
-- [Tatsuhiro Tsujikawa brought this change]
+- RELEASE-NOTES: synced with af8cc7a69
- http2: Ignore if we have stream ID not in hash in on_stream_close
-
- We could get stream ID not in the hash in on_stream_close. For
- example, if we decided to reject stream (e.g., PUSH_PROMISE), then we
- don't create stream and store it in hash with its stream ID.
+- curlver: towards 7.57.1
-- [Tatsuhiro Tsujikawa brought this change]
+- [W. Mark Kubacki brought this change]
- Require nghttp2 v1.0.0
+ lib: don't export all symbols, just everything curl_*
- This commit requires nghttp2 v1.0.0 to compile, and migrate to v1.0.0,
- and utilize recent version of nghttp2 to simplify the code,
+ Absent any 'symbol map' or script to limit what gets exported, static
+ linking of libraries previously resulted in a libcurl with curl's and
+ those other symbols being (re-)exported.
- First we use nghttp2_option_set_no_recv_client_magic function to
- detect nghttp2 v1.0.0. That function only exists since v1.0.0.
+ This did not happen if 'versioned symbols' were enabled (which is not
+ the default) because then a version script is employed.
- Since nghttp2 v0.7.5, nghttp2 ensures header field ordering, and
- validates received header field. If it found error, RST_STREAM with
- PROTOCOL_ERROR is issued. Since we require v1.0.0, we can utilize
- this feature to simplify libcurl code. This commit does this.
+ This limits exports to everything starting in 'curl_*'., which is
+ what "libcurl.vers" exports.
- Migration from 0.7 series are done based on nghttp2 migration
- document. For libcurl, we removed the code sending first 24 bytes
- client magic. It is now done by nghttp2 library.
- on_invalid_frame_recv callback signature changed, and is updated
- accordingly.
+ This avoids strange side-effects such as with mixing methods
+ from system libraries and those erroneously offered by libcurl.
+
+ Closes #2127
-- http2: infof length in on_frame_send()
+- [Johannes Schindelin brought this change]
-- pipeline: switch some code over to functions
+ SSL: Avoid magic allocation of SSL backend specific data
+
+ Originally, my idea was to allocate the two structures (or more
+ precisely, the connectdata structure and the four SSL backend-specific
+ strucutres required for ssl[0..1] and proxy_ssl[0..1]) in one go, so
+ that they all could be free()d together.
+
+ However, getting the alignment right is tricky. Too tricky.
+
+ So let's just bite the bullet and allocate the SSL backend-specific
+ data separately.
- ... to "compartmentalize" a bit and make it easier to change behavior
- when multiplexing is used instead of good old pipelining.
+ As a consequence, we now have to be very careful to release the memory
+ allocated for the SSL backend-specific data whenever we release any
+ connectdata.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+ Closes #2119
-- symbols-in-versions: add CURLOPT_PIPEWAIT
+- examples/xmlstream.c: don't switch off CURL_GLOBAL_SSL
+
+ Reported-by: Dima Tisnek
-- CURLOPT_PIPEWAIT: added
+- travis: add boringssl build
+
+ Uses a separate build without --enable-debug and no valgrind.
- By setting this option to 1 libcurl will wait for a connection to reveal
- if it is possible to pipeline/multiplex on before it continues.
+ The debug option causes far too many warnings in boringssl's headers
+ (C++ comments, trailing commas etc). Valgrind triggers some false
+ positive errors in thread-local data used by boringssl.
+
+ Closes #2118
-- Curl_http_readwrite_headers: minor code simplification
+Version 7.57.0 (29 Nov 2017)
-- IsPipeliningPossible: fixed for http2
+Daniel Stenberg (29 Nov 2017)
+- RELEASE-NOTES: curl 7.57.0
-- http2: bump the h2 buffer size to 32K for speed
+- THANKS: added contributors from 7.57.0 release
-- http2: remove the stream from the hash in stream_close callback
+- openssl: fix boringssl build again
+
+ commit d3ab7c5a21e broke the boringssl build since it doesn't have
+ RSA_flags(), so we disable that code block for boringssl builds.
- ... and suddenly things work much better!
+ Reported-by: W. Mark Kubacki
+ Fixes #2117
-- http2: if there is paused data, do not clear the drain field
+- curl_ntlm_core.c: use the limits.h's SIZE_T_MAX if provided
-- http2: rename s/data/pausedata
+- libcurl-share.3: the connection cache is shareable now
-- http2: "stream %x" in all outputs to make it easier to search for
+- global_init: ignore CURL_GLOBAL_SSL's absense
+
+ This bit is no longer used. It is not clear what it meant for users to
+ "init the TLS" in a world with different TLS backends and since the
+ introduction of multissl, libcurl didn't properly work if inited without
+ this bit set.
+
+ Not a single user responded to the call for users of it:
+ https://curl.haxx.se/mail/lib-2017-11/0072.html
+
+ Reported-by: Evgeny Grin
+ Assisted-by: Jay Satiro
+
+ Fixes #2089
+ Fixes #2083
+ Closes #2107
-- http2: Curl_expire() all handles with incoming traffic
+- ntlm: avoid integer overflow for malloc size
+
+ Reported-by: Alex Nichols
+ Assisted-by: Kamil Dudka and Max Dymond
+
+ CVE-2017-8816
- ... so that they'll get handled next in the multi loop.
+ Bug: https://curl.haxx.se/docs/adv_2017-11e7.html
-- http2: don't signal settings change for same values
+- wildcardmatch: fix heap buffer overflow in setcharset
+
+ The code would previous read beyond the end of the pattern string if the
+ match pattern ends with an open bracket when the default pattern
+ matching function is used.
+
+ Detected by OSS-Fuzz:
+ https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4161
+
+ CVE-2017-8817
+
+ Bug: https://curl.haxx.se/docs/adv_2017-ae72.html
-- http2: set default concurrency, fix ConnectionExists for multiplex
+- [Jay Satiro brought this change]
-- bundles: store no/default/pipeline/multiplex
+ url: fix alignment of ssl_backend_data struct
- to allow code to act differently on the situation.
+ - Align the array of ssl_backend_data on a max 32 byte boundary.
- Also added some more info message for the connection re-use function to
- make it clearer when connections are not re-used.
-
-- http2: lazy init header_recvbuf
+ 8 is likely to be ok but I went with 32 for posterity should one of
+ the ssl_backend_data structs change to contain a larger sized variable
+ in the future.
- It makes us use less memory when not doing HTTP/2 and subsequently also
- makes us not have to cleanup HTTP/2 related data when not using HTTP/2!
-
-- http2: separate multiplex/pipelining + cleanup memory leaks
+ Prior to this change (since dev 70f1db3, release 7.56) the connectdata
+ structure was undersized by 4 bytes in 32-bit builds with ssl enabled
+ because long long * was mistakenly used for alignment instead of
+ long long, with the intention being an 8 byte boundary. Also long long
+ may not be an available type.
+
+ The undersized connectdata could lead to oob read/write past the end in
+ what was expected to be the last 4 bytes of the connection's secondary
+ socket https proxy ssl_backend_data struct (the secondary socket in a
+ connection is used by ftp, others?).
+
+ Closes https://github.com/curl/curl/issues/2093
+
+ CVE-2017-8818
+
+ Bug: https://curl.haxx.se/docs/adv_2017-af0a.html
-- CURLMOPT_PIPELINE: bit 1 is for multiplexing
+- ssh: remove check for a NULL pointer (!)
+
+ With this check present, scan-build warns that we might dereference this
+ point in other places where it isn't first checked for NULL. Thus, if it
+ *can* be NULL we have a problem on a few places. However, this pointer
+ should not be possible to be NULL here so I remove the check and thus
+ also three different scan-build warnings.
+
+ Closes #2111
-- [Tatsuhiro Tsujikawa brought this change]
+- [Matthew Kerwin brought this change]
- http2: Fix bug that data to be drained are overwritten by pending "paused" data
+ test: add test for bad UNC/SMB path in file: URL
-- [Tatsuhiro Tsujikawa brought this change]
+- [Matthew Kerwin brought this change]
- http2: Don't call nghttp2_session_mem_recv while it is paused by a stream
+ test: add tests to ensure basic file: URLs
-- [Tatsuhiro Tsujikawa brought this change]
+- [Matthew Kerwin brought this change]
- http2: Read data left in connection buffer after pause
+ URL: update "file:" URL handling
- Previously when we do pause because of out of buffer, we just throw
- away unread data in connection buffer. This just broke protocol
- framing, and I saw occasional FRAME_SIZE_ERROR. This commit fix this
- issue by remembering how much data read, and in the next iteration, we
- process remaining data.
-
-- [Tatsuhiro Tsujikawa brought this change]
-
- http2: Fix streams get stuck
+ * LOTS of comment updates
+ * explicit error for SMB shares (e.g. "file:////share/path/file")
+ * more strict handling of authority (i.e. "//localhost/")
+ * now accepts dodgy old "C:|" drive letters
+ * more precise handling of drive letters in and out of Windows
+ (especially recognising both "file:c:/" and "file:/c:/")
- This commit fixes the bug that streams get stuck if stream gets some
- DATA, and stream->closed becomes true at the same time. Previously,
- in this condition, after we processed DATA, we are going to try to
- read data from underlying transport, but there is no data, and gets
- EAGAIN. There was no code path to evaludate stream->closed.
-
-- http2: store incoming h2 SETTINGS
+ Closes #2110
-- pipeline: move function to pipeline.c and make static
+- metalink: fix memory-leak and NULL pointer dereference
- ... as it was only used from there.
-
-- IsPipeliningPossible: http2 can always "pipeline" (multiplex)
+ Reported by scan-build
+
+ Closes #2109
-- http2: remove debug logging from on_frame_recv
+- [Alessandro Ghedini brought this change]
-- http2: remove the closed check in http2_recv
+ connect: add support for new TCP Fast Open API on Linux
- With the "drained" functionality we can get here slightly asynchronously
- so the stream have have been closed but there is pending data left to
- read.
-
-- http2: bump the h2 buffer to 8K
+ The new API added in Linux 4.11 only requires setting a socket option
+ before connecting, without the whole sento() machinery.
+
+ Notably, this makes it possible to use TFO with SSL connections on Linux
+ as well, without the need to mess around with OpenSSL (or whatever other
+ SSL library) internals.
+
+ Closes #2056
-- http2: Curl_read should not use the single buffer
+- make: fix "make distclean"
- ... as it does for pipelining when we're multiplexing, as we need the
- different buffers to store incoming data correctly for all streams.
+ Fixes #2097
+ Closes #2108
-- http2: more debug outputs
+- RELEASE-NOTES: synced with 31f18d272
-- http2: leave WAITPERFORM when conn is multiplexed
+Jay Satiro (23 Nov 2017)
+- connect: improve the bind error message
+
+ eg consider a non-existent interface eth8, curl --interface eth8
+
+ Before: curl: (45) Could not resolve host: eth8
+ After: curl: (45) Couldn't bind to 'eth8'
- No need to wait for our "spot" like for pipelining
+ Bug: https://github.com/curl/curl/issues/2104
+ Reported-by: Alfonso Martone
-- http2: force "drainage" of streams
+Daniel Stenberg (23 Nov 2017)
+- examples/rtsp: clear RANGE again after use
- ... which is necessary since the socket won't be readable but there is
- data waiting in the buffer.
+ Fixes #2106
+ Reported-by: youngchopin on github
-- http2: move the mem+len pair to the stream struct
+- [Michael Kaufmann brought this change]
-- http2: more stream-oriented data, stream ID 0 is for connections
+ test1264: verify URL with space in host name being rejected
-- http2: move lots of state data to the 'stream' struct
+- url: reject ASCII control characters and space in host names
- ... from the connection struct. The stream one being the 'struct HTTP'
- which is kept in the SessionHandle struct (easy handle).
+ Host names like "127.0.0.1 moo" would otherwise be accepted by some
+ getaddrinfo() implementations.
- lookup streams for incoming frames in the stream hash, hashing is based
- on the stream id and we get the SessionHandle for the incoming stream
- that way.
-
-- HTTP: partial start at fixing up hash-lookups on http2 frame receival
-
-- http: a stream hash for h2 multiplexing
+ Updated test 1034 and 1035 accordingly.
+
+ Fixes #2073
+ Closes #2092
-- http: a stream hash for h2 multiplexing
+- Curl_open: fix OOM return error correctly
+
+ Closes #2098
-- http2: debug log when receiving unexpected stream_id
+- http2: fix "Value stored to 'end' is never read" scan-build error
-- http2: move stream_id to the HTTP struct (per-stream)
+- http2: fix "Value stored to 'hdbuf' is never read" scan-build error
-- Curl_http2_setup: only do it once and enable multiplex on the server
-
- Once we know we are HTTP/2 enabled we know the server can multiplex.
+- openssl: fix "Value stored to 'rc' is never read" scan-build error
-- http: switch on "pipelining" (multiplexing) for HTTP/2 servers
-
- ... and do not blacklist any.
+- mime: fix "Value stored to 'sz' is never read" scan-build error
-- README.pipelining: removed
+- Curl_llist_remove: fix potential NULL pointer deref
- All the details mentioned here are better documented in man pages
+ Fixes a scan-build warning.
-Dan Fandrich (14 May 2015)
-- build: removed bundles.c from make files
-
- This file was removed in commit fd137786
+- ntlm: remove unnecessary NULL-check to please scan-build
-Daniel Stenberg (14 May 2015)
-- Curl_conncache_add_conn: fix memory leak on OOM
+- BUGS: spellchecked
-- CURLMOPT_MAX_HOST_CONNECTIONS: host = host name + port number
+Jay Satiro (18 Nov 2017)
+- [fmmedeiros brought this change]
-- conncache: keep bundles on host+port bases, not only host names
+ examples/curlx: Fix code style
- Previously we counted all connections to a specific host name and that
- would be used for the CURLMOPT_MAX_HOST_CONNECTIONS check for example,
- while servers on different port numbers are normally considered
- different "origins" on the web and should thus be considered different
- hosts.
-
-- bundles: merged into conncache.c
+ - Add braces around multi-line if statement.
- All the existing Curl_bundle* functions were only ever used from within
- the conncache.c file, so I moved them over and made them static (and
- removed the Curl_ prefix).
+ Closes https://github.com/curl/curl/pull/2096
-- hostcache: made all host caches use structs, not pointers
+Daniel Stenberg (17 Nov 2017)
+- resolve: allow IP address within [] brackets
- This avoids unnecessary dynamic allocs and as this also removed the last
- users of *hash_alloc() and *hash_destroy(), those two functions are now
- removed.
-
-- multi: converted socket hash into non-allocated struct
+ ... so that IPv6 addresses can be passed like they can for connect-to
+ and how they're used in URLs.
- avoids extra dynamic allocation
-
-- connection cache: avoid Curl_hash_alloc()
+ Added test 1324 to verify
+ Reported-by: Alex Malinovich
- ... by using plain structs instead of pointers for the connection cache,
- we can avoid several dynamic allocations that weren't necessary.
-
-- proxy: add newline to info message
+ Fixes #2087
+ Closes #2091
-Patrick Monnerat (8 May 2015)
-- FTP: fix dangling conn->ip_addr dereference on verbose EPSV.
+- [Pavol Markovic brought this change]
-- FTP: Make EPSV use the control IP address rather than the original host.
- This ensures an alternate address is not used.
- Does not apply to proxy tunnel.
+ macOS: Fix missing connectx function with Xcode version older than 9.0
+
+ The previous fix https://github.com/curl/curl/pull/1788 worked just for
+ Xcode 9. This commit extends the fix to older Xcode versions effectively
+ by not using connectx function.
+
+ Fixes https://github.com/curl/curl/issues/1330
+ Fixes https://github.com/curl/curl/issues/2080
+ Closes https://github.com/curl/curl/pull/1336
+ Closes #2082
-Daniel Stenberg (8 May 2015)
-- [Alessandro Ghedini brought this change]
+- [Dirk Feytons brought this change]
- tool_help: fix formatting for --next option
+ openssl: fix too broad use of HAVE_OPAQUE_EVP_PKEY
+
+ Fixes #2079
+ Closes #2081
-- [Egon Eckert brought this change]
+- TODO: ignore private IP addresses in PASV response
+
+ Closes #1455
- opts: improved the TCP keepalive examples
+- RELEASE-NOTES: synced with ae7369b6d
-Jay Satiro (8 May 2015)
-- winbuild: Document the option used to statically link the CRT
+Michael Kaufmann (14 Nov 2017)
+- URL: return error on malformed URLs with junk after IPv6 bracket
- - Document option RTLIBCFG (runtime library configuration).
+ Follow-up to aadb7c7. Verified by new test 1263.
- Bug: https://github.com/bagder/curl/issues/254
- Reported-by: Bert Huijben
+ Closes #2072
-- [Orgad Shaneh brought this change]
+Daniel Stenberg (14 Nov 2017)
+- INTERNALS: we may use libidn2 now, not libidn
- netrc: Read in text mode when cygwin
+Patrick Monnerat (13 Nov 2017)
+- zlib/brotli: only include header files in modules needing them
- Use text mode when cygwin to eliminate trailing carriage returns.
+ There is a conflict on symbol 'free_func' between openssl/crypto.h and
+ zlib.h on AIX. This is an attempt to resolve it.
- Bug: https://github.com/bagder/curl/pull/258
+ Bug: https://curl.haxx.se/mail/lib-2017-11/0032.html
+ Reported-By: Michael Felt
-Patrick Monnerat (5 May 2015)
-- OS400: Add SPNEGO service name options to ILE/RPG binding.
-
-Daniel Stenberg (4 May 2015)
-- curl_multi_info_read.3: fix typo
+Daniel Stenberg (13 Nov 2017)
+- SMB: fix uninitialized local variable
- Reported-by: Liviu Chircu
+ Reported-by: Brian Carpenter
+
+- [Orgad Shaneh brought this change]
-- MANUAL: language fix
+ connect.c: remove executable bit on file
- Reported-by: Fred Stluka
- Bug: https://github.com/bagder/curl/issues/255
+ Closes #2071
-- [Alessandro Ghedini brought this change]
+- [hsiao yi brought this change]
- gtls: properly retrieve certificate status
+ README.md: fixed layout
- Also print the revocation reason if appropriate.
+ Closes #2069
-- OpenSSL: conditional check for SSL3_RT_HEADER
+- setopt: split out curl_easy_setopt() to its own file
- The symbol is fairly new.
+ ... to make url.c smaller.
- Reported-by: Kamil Dudka
+ Closes #1944
-- openssl: skip trace outputs for ssl_ver == 0
+Jay Satiro (10 Nov 2017)
+- [John Starks brought this change]
+
+ cmake: Add missing setmode check
- The OpenSSL trace callback is wonderfully undocumented but given a
- journey in the source code, it seems the cases were ssl_ver is zero
- doesn't follow the same pattern and thus turned out confusing and
- misleading. For now, we skip doing any CURLINFO_TEXT logging on those
- but keep sending them as CURLINFO_SSL_DATA_OUT/IN.
+ Ensure HAVE_SETMODE is set to 1 on OSes that have setmode. Without this,
+ curl will corrupt binary files when writing them to stdout on Windows.
- Also, I added direction to the text info and I edited some functions
- slightly.
+ Closes https://github.com/curl/curl/pull/2067
+
+Daniel Stenberg (10 Nov 2017)
+- curl_share_setopt: va_end was not called if conncache errors
- Bug: https://github.com/bagder/curl/issues/219
- Reported-by: Jay Satiro, Ashish Shukla
+ CID 984459, detected by Coverity
-Marc Hoersken (2 May 2015)
-- schannel.c: Small changes
+Sergei Nikulov (10 Nov 2017)
+- [John Starks brought this change]
-- schannel.c: Improve code path and readability
+ cmake: Correctly include curl.rc in Windows builds (#2064)
+
+ Update CMakeLists.txt to add curl.rc to the correct list.
-- schannel.c: Improve error and return code handling upon aa99a63f03
+Daniel Stenberg (9 Nov 2017)
+- RELEASE-NOTES: synced with 32828cc4f
-- [Chris Araman brought this change]
+- [Luca Boccassi brought this change]
- schannel: fix regression in schannel_recv
+ --interface: add support for Linux VRF
+
+ The --interface command (CURLOPT_INTERFACE option) already uses
+ SO_BINDTODEVICE on Linux, but it tries to parse it as an interface or IP
+ address first, which fails in case the user passes a VRF.
- https://github.com/bagder/curl/issues/244
+ Try to use the socket option immediately and parse it as a fallback
+ instead. Update the documentation to mention this feature, and that it
+ requires the binary to be ran by root or with CAP_NET_RAW capabilities
+ for this to work.
- Commit 145c263 changed the behavior when Curl_read_plain returns
- CURLE_AGAIN. We now handle CURLE_AGAIN and SEC_I_CONTEXT_EXPIRED
- correctly.
+ Closes #2024
-- Bug born in changes made several days ago 9a91e80.
+- curl_share_setopt.3: document CURL_LOCK_DATA_CONNECT
- Commit: https://github.com/bagder/curl/commit/926cb9f
- Reported-by: Ray Satiro
+ Closes #2043
-Daniel Stenberg (30 Apr 2015)
-- [Michael Osipov brought this change]
+- examples: add shared-connection-cache
- configure: remove missing and make it autogenerate
-
- The missing file has not been autogenerated because a temporary fix was
- employed in acinclude.m4 which blocked update. Removed that fix and a recent
- version of missing is copied to build root.
+- test1554: verify connection cache sharing
-- [Michael Osipov brought this change]
+- share: add support for sharing the connection cache
- acinclude.m4: fix test for default CA cert bundle/path
+- imap: deal with commands case insensitively
- test(1) on HP-UX requires a single equals sign and fails with two.
- Let's use one and make every OS happy.
-
-- CONTRIBUTING.md: remove the sourceforge mention
+ As documented in RFC 3501 section 9:
+ https://tools.ietf.org/html/rfc3501#section-9
- Reported-By: Michael Osipov
+ Closes #2061
-Dan Fandrich (30 Apr 2015)
-- http_negotiate_sspi: added missing data variable
-
-Daniel Stenberg (30 Apr 2015)
-- [Michael Osipov brought this change]
-
- configure: remove --automake from libtoolize call
+- connect: store IPv6 connection status after valid connection
- That option is not mentioned in the man page of libtoolize 2.4.4.19-fda4.
- Moveover, a comment in line 2623 says "--automake is for 1.5 compatibility".
+ ... previously it would store it already in the happy eyeballs stage
+ which could lead to the IPv6 bit being set for an IPv4 connection,
+ leading to curl not wanting to do EPSV=>PASV for FTP transfers.
- This option is redundant now.
-
-- [Viktor Szakats brought this change]
+ Closes #2053
- build: update depedency versions, urls, example makefiles
+- curl_multi_fdset.3: emphasize curl_multi_timeout
- - update default versions of dependencies (except for rare/old platforms)
- - update urls
- - sync examples makefiles with main ones
- - remove line ending space
+ ... even when there's no socket to wait for, the timeout can still be
+ very short.
-- [Michael Osipov brought this change]
-
- configure: remove autogenerated files by autoconf
+Jay Satiro (9 Nov 2017)
+- content_encoding: fix inflate_stream for no bytes available
- * install-sh is always regenerated
- * mkinstalldirs was already redudant years ago. Automake uses install for
- that. See: http://lists.gnu.org/archive/html/automake/2007-03/msg00015.html
-
-- [Anders Bakken brought this change]
-
- curl_multi_add_handle: next is already NULL
-
-Jay Satiro (30 Apr 2015)
-- schannel: Fix out of bounds array
+ - Don't call zlib's inflate() when avail_in stream bytes is 0.
- Bug born in changes made several days ago 9a91e80.
+ This is a follow up to the parent commit 19e66e5. Prior to that change
+ libcurl's inflate_stream could call zlib's inflate even when no bytes
+ were available, causing inflate to return Z_BUF_ERROR, and then
+ inflate_stream would treat that as a hard error and return
+ CURLE_BAD_CONTENT_ENCODING.
- Bug: http://curl.haxx.se/mail/lib-2015-04/0199.html
- Reported-by: Brian Chrisman
-
-- docs/libcurl: gitignore libcurl-symbols.3
+ According to the zlib FAQ, Z_BUF_ERROR is not fatal.
+
+ This bug would happen randomly since packet sizes are arbitrary. A test
+ of 10,000 transfers had 55 fail (ie 0.55%).
+
+ Ref: https://zlib.net/zlib_faq.html#faq05
- Bug: http://curl.haxx.se/mail/lib-2015-04/0191.html
- Reported-by: Michael Osipov
+ Closes https://github.com/curl/curl/pull/2060
-- [Viktor Szakats brought this change]
+Patrick Monnerat (7 Nov 2017)
+- content_encoding: do not write 0 length data
- lib/makefile.m32: add arch -m32/-m64 to LDFLAGS
+Daniel Stenberg (6 Nov 2017)
+- fnmatch: remove dead code
+
+ There was a duplicate check for backslashes in the setcharset()
+ function.
- This fixes using a multi-target mingw distro to build curl .dll for the
- non-default target.
- (mirroring the same patch present in src/makefile.m32)
+ Coverity CID 1420611
-Daniel Stenberg (29 Apr 2015)
-- RELEASE-NOTES: synced with cd39b944afc
+- url: remove unncessary NULL-check
- I've not mentioned the bug fixes that were shipped in 7.42.1 from the
- 7_42 branch.
+ Since 'conn' won't be NULL in there and we also access the pointer in
+ there without the check.
+
+ Coverity CID 1420610
-- THANKS: merged from the 7.42.1 release
+Viktor Szakats (6 Nov 2017)
+- src/Makefile.m32: fix typo in brotli lib customization
+
+ Ref cc1f4436099decb9d1a7034b2bb773a9f8379d31
-- CURLOPT_HEADEROPT: default to separate
+- Makefile.m32: allow to customize brotli libs
- Make the HTTP headers separated by default for improved security and
- reduced risk for information leakage.
+ It adds the ability to link against static brotli libs.
- Bug: http://curl.haxx.se/docs/adv_20150429.html
- Reported-by: Yehezkel Horowitz, Oren Souroujon
+ Also fix brotli include path.
-Linus Nielsen (28 Apr 2015)
-- docs/libcurl: Corrected a typo in the CURLOPT_PROXY_SERVICE_NAME documentation
+Patrick Monnerat (5 Nov 2017)
+- travis: add a job with brotli enabled
-Daniel Stenberg (28 Apr 2015)
-- hash: simplify Curl_str_key_compare()
+- [Viktor Szakats brought this change]
-- dist: ship CURLOPT_PROXY_SERVICE_NAME and CURLOPT_SERVICE_NAME
+ Makefile.m32: add brotli support
-- [Linus Nielsen brought this change]
+- HTTP: implement Brotli content encoding
+
+ This uses the brotli external library (https://github.com/google/brotli).
+ Brotli becomes a feature: additional curl_version_info() bit and
+ structure fields are provided for it and CURLVERSION_NOW bumped.
+
+ Tests 314 and 315 check Brotli content unencoding with correct and
+ erroneous data.
+
+ Some tests are updated to accomodate with the now configuration dependent
+ parameters of the Accept-Encoding header.
- Negotiate: custom service names for SPNEGO.
+- HTTP: support multiple Content-Encodings
- * Add new options, CURLOPT_PROXY_SERVICE_NAME and CURLOPT_SERVICE_NAME.
- * Add new curl options, --proxy-service-name and --service-name.
+ This is implemented as an output streaming stack of unencoders, the last
+ calling the client write procedure.
+
+ New test 230 checks this feature.
+
+ Bug: https://github.com/curl/curl/pull/2002
+ Reported-By: Daniel Bankhead
-- http2: unify http_conn variable names to 'c'
+Jay Satiro (4 Nov 2017)
+- url: remove arg value check from CURLOPT_SSH_AUTH_TYPES
+
+ Since CURLSSH_AUTH_ANY (aka CURLSSH_AUTH_DEFAULT) is ~0 an arg value
+ check on this option is incorrect; we have to accept any value.
+
+ Prior to this change since f121575 (7.56.1+) CURLOPT_SSH_AUTH_TYPES
+ erroneously rejected CURLSSH_AUTH_ANY with CURLE_BAD_FUNCTION_ARGUMENT.
+
+ Bug: https://github.com/curl/curl/commit/f121575#commitcomment-25347120
-- ConnectionExists: call it multi-use instead of pipelining
+Daniel Stenberg (4 Nov 2017)
+- ntlm: avoid malloc(0) for zero length passwords
+
+ It triggers an assert() when built with memdebug since malloc(0) may
+ return NULL *or* a valid pointer.
- So that it fits HTTP/2 as well
+ Detected by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4054
+
+ Assisted-by: Max Dymond
+ Closes #2054
-Kamil Dudka (27 Apr 2015)
-- [Paul Howarth brought this change]
+- RELEASE-NOTES: synced with ee8016b3d
- nss: fix compilation failure with old versions of NSS
+- curl: speed up handling of many URLs
- Bug: http://curl.haxx.se/mail/lib-2015-04/0095.html
-
-Daniel Stenberg (27 Apr 2015)
-- sws: init http2 state properly
+ By properly keeping track of the last entry in the list of URLs/uploads
+ to handle, curl now avoids many meaningless traverses of the list which
+ speeds up many-URL handling *MASSIVELY* (several magnitudes on 100K
+ URLs).
+
+ Added test 1291, to verify that it doesn't take ages - but we don't have
+ any detection of "too slow" command in the test suite.
- It would otherwise cause problems when running tests after 1801 etc.
+ Reported-by: arainchik on github
+ Fixes #1959
+ Closes #2052
-- curl_easy_getinfo.3: document 'internals' in CURLINFO_TLS_SESSION
+- curl: pass through [] in URLs instead of calling globbing error
- ... as it was previouly undocumented what the pointer was.
+ Assisted-by: Per Lundberg
+ Fixes #2044
+ Closes #2046
+ Closes #2048
-- runtests: use a DISABLED.local file too
+- CURLOPT_INFILESIZE: accept -1
- ... and have git ignore that. Allows for a dev to add tests to ignore in
- local tests and yet don't obstruct a normal git work flow.
+ Regression since f121575
+
+ Reported-by: Petr Voytsik
+ Fixes #2047
-Marc Hoersken (26 Apr 2015)
-- schannel.c: Fix typo introduced with 3447c973d0
+Jay Satiro (2 Nov 2017)
+- url: fix CURLOPT_DNS_CACHE_TIMEOUT arg value check to allow -1
+
+ Prior to this change since f121575 (7.56.1+) CURLOPT_DNS_CACHE_TIMEOUT
+ erroneously rejected -1 with CURLE_BAD_FUNCTION_ARGUMENT.
-- schannel.c: Fix possible SEC_E_BUFFER_TOO_SMALL error
+Dan Fandrich (1 Nov 2017)
+- http2: Fixed OOM handling in upgrade request
- Reported-by: Brian Chrisman
+ This caused the torture tests on test 1800 to fail.
-Daniel Stenberg (26 Apr 2015)
-- schannel: re-indented file to follow curl style better
+- tests: Fixed torture tests on tests 556 and 650
- white space changes only
+ Test cleanup after OOM wasn't being consistently performed.
-- Curl_ossl_init: load builtin modules
+Daniel Stenberg (1 Nov 2017)
+- CURLOPT_MAXREDIRS: allow -1 as a value
- To have engine modules work, we must tell openssl to load builtin
- modules first.
+ ... which is valid according to documentation. Regression since
+ f121575c0b5f.
- Bug: https://github.com/bagder/curl/pull/206
+ Verified now in test 501.
+
+ Reported-by: cbartl on github
+ Fixes #2038
+ Closes #2039
+
+- include: remove conncache.h inclusion from where its not needed
-- configure: follow-up fix for krb5-config
+Jay Satiro (1 Nov 2017)
+- url: fix CURLOPT_POSTFIELDSIZE arg value check to allow -1
- commit 5b66860652 was incomplete so here's a follow-up fix
+ .. also add same arg value check to CURLOPT_POSTFIELDSIZE_LARGE.
- Reported-by: Dagobert Michelsen
- Bug: https://github.com/bagder/curl/commit/5b668606527613179d0349f21b4ab0df2971e3d2#commitcomment-10473445
+ Prior to this change since f121575 (7.56.1+) CURLOPT_POSTFIELDSIZE
+ erroneously rejected -1 value with CURLE_BAD_FUNCTION_ARGUMENT.
+
+ Bug: https://curl.haxx.se/mail/lib-2017-11/0000.html
+ Reported-by: Andrew Lambert
-- openssl: fix serial number output
+Daniel Stenberg (31 Oct 2017)
+- cookie: avoid NULL dereference
- The code extracting the cert serial number was broken and didn't display
- it properly.
+ ... when expiring old cookies.
- Bug: https://github.com/bagder/curl/issues/235
- Reported-by: dkjjr89
-
-- [Grant Pannell brought this change]
+ Reported-by: Pavel Gushchin
+ Fixes #2032
+ Closes #2035
- sasl_sspi: Populate domain from the realm in the challenge
+Marcel Raad (30 Oct 2017)
+- memdebug: use send/recv signature for curl_dosend/curl_dorecv
- Without this, SSPI based digest auth was broken.
+ This avoids build errors and warnings caused by implicit casts.
- Bug: https://github.com/bagder/curl/pull/141.patch
+ Closes https://github.com/curl/curl/pull/2031
-Jay Satiro (25 Apr 2015)
-- [Anthony Avina brought this change]
+Daniel Stenberg (30 Oct 2017)
+- [Juro Bystricky brought this change]
- tool: New option --data-raw to HTTP POST data, '@' allowed.
+ mkhelp.pl: support reproducible build
- Add new option --data-raw which is almost the same as --data but does
- not have a special interpretation of the @ character.
+ Do not generate line with the current date, such as:
- Prior to this change there was no (easy) way to pass the @ character as
- the first character in POST data without it being interpreted as a
- special character.
+ * Generation time: Tue Oct-24 18:01:41 2017
- Bug: https://github.com/bagder/curl/issues/198
- Reported-by: Jens Rantil
+ This will improve reproducibility. The generated string is only
+ part of a comment, so there should be no adverse consequences.
+
+ Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
+
+ closes #2026
-Dan Fandrich (25 Apr 2015)
-- test2039: fixed line endings that caused a test failure
+Dan Fandrich (30 Oct 2017)
+- runtests.pl: Fixed typo in message
-Daniel Stenberg (24 Apr 2015)
-- [Viktor Szakats brought this change]
+Daniel Stenberg (30 Oct 2017)
+- curlx: the timeval functions are no longer provided as curlx_*
+
+ Pointed-out-by: Dmitri Tikhonov
+ Bug: #2034
- netrc: add unit tests for 'default' support
+- select: update comments
+
+ s/curlx_tvnow/Curl_now
-- [Viktor Szakats brought this change]
+- INTERNALS: remove curlx_tv* functions no longer provided
- netrc: support 'default' token
+- [Dmitri Tikhonov brought this change]
+
+ timeval: use mach time on MacOS
- The 'default' token has no argument and means to match _any_ domain.
- It must be placed last if there are 'machine <name>' tokens in the same file.
+ If clock_gettime() is not supported, use mach_absolute_time() on MacOS.
- See full description here:
- https://www.gnu.org/software/inetutils/manual/html_node/The-_002enetrc-File.html
+ closes #2033
+
+monnerat (29 Oct 2017)
+- [Patrick Monnerat brought this change]
-- ROADMAP.md: extended the HTTP/2 section, reformatted
+ cli tool: improve ";type=" handling in -F option arguments
+
+- [Patrick Monnerat brought this change]
+
+ cli tool: in -F option arg, comma is a delimiter for files only
- Elaborated on several of the remaining HTTP/2 parts and made document
- use a format that ends up nicer on the web page:
- http://curl.haxx.se/dev/roadmap.html
+ Also upgrade test 1133 to cover this case and clarify man page about
+ form data quoting.
+
+ Bug: https://github.com/curl/curl/issues/2022
+ Reported-By: omau on github
+
+Daniel Stenberg (29 Oct 2017)
+- timeleft: made two more users of Curl_timeleft use timediff_t
-Kamil Dudka (23 Apr 2015)
-- curl -z: do not write empty file on unmet condition
+Jakub Zakrzewski (28 Oct 2017)
+- cmake: Export libcurl and curl targets to use by other cmake projects
- This commit fixes a regression introduced in curl-7_41_0-186-g261a0fe.
- It also introduces a regression test 1424 based on tests 78 and 1423.
+ The config files define curl and libcurl targets as imported targets
+ CURL::curl and CURL::libcurl. For backward compatibility with CMake-
+ provided find-module the CURL_INCLUDE_DIRS and CURL_LIBRARIES are
+ also set.
- Reported-by: Viktor Szakats
- Bug: https://github.com/bagder/curl/issues/237
+ Closes #1879
-Dan Fandrich (23 Apr 2015)
-- tool: fixed a comment typo
+Daniel Stenberg (28 Oct 2017)
+- RELEASE-NOTES: synced with f20cbac97
-- README: convert to UTF-8
+- [Florin Petriuc brought this change]
-Jay Satiro (22 Apr 2015)
-- cyassl: Implement public key pinning
+ auth: Added test cases for RFC7616
+
+ Updated docs to include support for RFC7616
- Also add public key extraction example to CURLOPT_PINNEDPUBLICKEY doc.
+ Signed-off-by: Florin <petriuc.florin@gmail.com>
+
+ Closes #1934
-Dan Fandrich (22 Apr 2015)
-- [Alessandro Ghedini brought this change]
+- [Florin Petriuc brought this change]
- curl.1: fix typo
+ auth: add support for RFC7616 - HTTP Digest access authentication
+
+ Signed-off-by: Florin <petriuc.florin@gmail.com>
-Kamil Dudka (22 Apr 2015)
-- docs: distribute the CURLOPT_PINNEDPUBLICKEY(3) man page, too
+- [Daniel Bankhead brought this change]
-- tests/unit/.gitignore: hide unit1601 and above, too
+ TODO: support multiple Content-Encodings
+
+ Closes #2002
-Daniel Stenberg (22 Apr 2015)
-- connectionexists: follow-up to fd9d3a1ef1f
+- ROADMAP: cleanup
- PROTOPT_CREDSPERREQUEST still needs to be checked even when NTLM is not
- enabled.
+ Removed done stuff. Removed entries no longer considered for the near
+ term.
+
+- [Magicansk brought this change]
+
+ ROADMAP.md: spelling fixes
- Mistake-caught-by: Kamil Dudka
+ Closes #2028
-- connectionexists: fix build without NTLM
+- Curl_timeleft: change return type to timediff_t
- Do not access NTLM-specific struct fields when built without NTLM
- enabled!
+ returning 'time_t' is problematic when that type is unsigned and we
+ return values less than zero to signal "already expired", used in
+ several places in the code.
- bug: http://curl.haxx.se/?i=231
- Reported-by: Patrick Rapin
+ Closes #2021
-- bump: start working toward 7.43.0
+- appveyor: add a win32 build
-Kamil Dudka (22 Apr 2015)
-- nss: implement public key pinning for NSS backend
+- setopt: fix CURLOPT_SSH_AUTH_TYPES option read
- Bug: https://bugzilla.redhat.com/1195771
-
-Daniel Stenberg (22 Apr 2015)
-- dist: include {src,lib}/checksrc.whitelist
-
-Version 7.42.0 (22 Apr 2015)
+ Regression since f121575c0b5f
+
+ Reported-by: Rob Cotrone
-Daniel Stenberg (22 Apr 2015)
-- RELEASE-NOTES: updated for 7.42.0
+Marcel Raad (27 Oct 2017)
+- resolvers: only include anything if needed
+
+ This avoids warnings about unused stuff.
+
+ Closes https://github.com/curl/curl/pull/2023
-- THANKS: added contributors from 7.42.0 release notes
+Daniel Stenberg (27 Oct 2017)
+- HELP-US: rename the subtitle too since the label is changed
+
+ "PR-welcome" was the former name.
-- THANKS-filter: a few more alterations to squash
+- curl_setup.h: oops, shorten the too long line
-- contrithanks.sh: helper script for maintaining THANKS
+- [Martin Storsjo brought this change]
-- http_done: close Negotiate connections when done
+ curl_setup: Improve detection of CURL_WINDOWS_APP
- When doing HTTP requests Negotiate authenticated, the entire connnection
- may become authenticated and not just the specific HTTP request which is
- otherwise how HTTP works, as Negotiate can basically use NTLM under the
- hood. curl was not adhering to this fact but would assume that such
- requests would also be authenticated per request.
+ If WINAPI_FAMILY is defined, it should be safe to try to include
+ winapifamily.h to check what the define evaluates to.
- CVE-2015-3148
+ This should fix detection of CURL_WINDOWS_APP if building with
+ _WIN32_WINNT set to 0x0600.
- Bug: http://curl.haxx.se/docs/adv_20150422B.html
- Reported-by: Isaac Boukris
+ Closes #2025
-- fix_hostname: zero length host name caused -1 index offset
-
- If a URL is given with a zero-length host name, like in "http://:80" or
- just ":80", `fix_hostname()` will index the host name pointer with a -1
- offset (as it blindly assumes a non-zero length) and both read and
- assign that address.
+Jay Satiro (26 Oct 2017)
+- transfer: Fix chunked-encoding upload bug
- CVE-2015-3144
+ - When uploading via chunked-encoding don't compare file size to bytes
+ sent to determine whether the upload has finished.
- Bug: http://curl.haxx.se/docs/adv_20150422D.html
- Reported-by: Hanno Böck
-
-- cookie: cookie parser out of boundary memory access
+ Chunked-encoding adds its own overhead which why the bytes sent is not
+ equal to the file size. Prior to this change if a file was uploaded in
+ chunked-encoding and its size was known it was possible that the upload
+ could end prematurely without sending the final few chunks. That would
+ result in a server hang waiting for the remaining data, likely followed
+ by a disconnect.
- The internal libcurl function called sanitize_cookie_path() that cleans
- up the path element as given to it from a remote site or when read from
- a file, did not properly validate the input. If given a path that
- consisted of a single double-quote, libcurl would index a newly
- allocated memory area with index -1 and assign a zero to it, thus
- destroying heap memory it wasn't supposed to.
+ The scope of this bug is limited to some arbitrary file sizes which have
+ not been determined. One size that triggers the bug is 475020.
- CVE-2015-3145
+ Bug: https://github.com/curl/curl/issues/2001
+ Reported-by: moohoorama@users.noreply.github.com
- Bug: http://curl.haxx.se/docs/adv_20150422C.html
- Reported-by: Hanno Böck
+ Closes https://github.com/curl/curl/pull/2010
-- ConnectionExists: for NTLM re-use, require credentials to match
+Daniel Stenberg (26 Oct 2017)
+- timeval: make timediff_t also work on 32bit windows
- CVE-2015-3143
+ ... by using curl_off_t for the typedef if time_t is larger than 4
+ bytes.
- Bug: http://curl.haxx.se/docs/adv_20150422A.html
- Reported-by: Paras Sethia
-
-Jay Satiro (21 Apr 2015)
-- [byronhe brought this change]
-
- openssl: add OPENSSL_NO_SSL3_METHOD check
+ Reported-by: Gisle Vanem
+ Bug: https://github.com/curl/curl/commit/b9d25f9a6b3ca791385b80a6a3c3fa5ae113e1e0#co
+ mmitcomment-25205058
+ Closes #2019
-Daniel Stenberg (20 Apr 2015)
-- CURLOPT_HEADERFUNCTION.3: match parameter name in synopsis and desc
+- curl_fnmatch: return error on illegal wildcard pattern
- Bug: https://github.com/bagder/curl/issues/229
- Reported-by: bsammon
-
-Kamil Dudka (20 Apr 2015)
-- [Mostyn Bramley-Moore brought this change]
+ ... instead of doing an infinite loop!
+
+ Added test 1162 to verify.
+
+ Reported-by: Max Dymond
+ Fixes #2015
+ Closes #2017
- configure --with-nss: remove unneeded libs from the fallback
+- [Max Dymond brought this change]
-Daniel Stenberg (20 Apr 2015)
-- contributors.sh: fix help output, filter out (-prefix from names
+ wildcards: don't use with non-supported protocols
+
+ Fixes timeouts in the fuzzing tests for non-FTP protocols.
+
+ Closes #2016
-- RELEASE-NOTES: synced with cc0e7ebc3be0
+- [Max Dymond brought this change]
-- [Michael Stapelberg brought this change]
+ multi: allow table handle sizes to be overridden
+
+ Allow users to specify their own hash define for
+ CURL_CONNECTION_HASH_SIZE so that both values can be overridden.
+
+ Closes #1982
- CURLMOPT_TIMERFUNCTION.3: Clarify, add an example
+- time: rename Curl_tvnow to Curl_now
+
+ ... since the 'tv' stood for timeval and this function does not return a
+ timeval struct anymore.
+
+ Also, cleaned up the Curl_timediff*() functions to avoid typecasts and
+ clean up the descriptive comments.
+
+ Closes #2011
-- [Viktor Szakáts brought this change]
+- ftplistparser: follow-up cleanup to remove PL_ERROR()
- vtls/openssl: use https in URLs and a comment typo fixed
+- [Max Dymond brought this change]
-- curl_version_info.3: fixed the 'protocols' variable type
+ ftplistparser: free off temporary memory always
- Reported-by: John Marshall
- Bug: https://github.com/bagder/curl/issues/225
-
-Dan Fandrich (18 Apr 2015)
-- test1423: added missing "file" to server section
-
-Daniel Stenberg (17 Apr 2015)
-- TheArtOfHttpScripting: Multiple URLs + Multiple HTTP methods
+ When using the FTP list parser, ensure that the memory that's
+ allocated is always freed.
- ... and some minor edits
+ Detected by OSS-fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3682
+ Closes #2013
-- Revert "HTTP: don't abort connections with pending Negotiate authentication"
+- timediff: return timediff_t from the time diff functions
- This reverts commit 5dc68dd6092a789bb5e0a67a1c1356ba87fdcbc6.
+ ... to cater for systems with unsigned time_t variables.
- Bug: https://github.com/bagder/curl/issues/223
- Reported-by: Michael Osipov
+ - Renamed the functions to curlx_timediff and Curl_timediff_us.
+
+ - Added overflow protection for both of them in either direction for
+ both 32 bit and 64 bit time_ts
+
+ - Reprefixed the curlx_time functions to use Curl_*
+
+ Reported-by: Peter Piekarski
+ Fixes #2004
+ Closes #2005
+
+- [Paul Howarth brought this change]
-Jay Satiro (17 Apr 2015)
-- cyassl: Fix include order
+ libtest: Add required test libraries for lib1552 and lib1553
+
+ They use $(TESTUTIL) and thus should use $(TESTUTIL_LIBS) too.
- Prior to this change CyaSSL's build options could redefine some generic
- build symbols.
+ This fixes build failures on Fedora 13.
- http://curl.haxx.se/mail/lib-2015-04/0069.html
+ Closes #2006
-Kamil Dudka (17 Apr 2015)
-- configure --with-nss: drop redundant if statement
+- [Alessandro Ghedini brought this change]
-- configure --with-nss=PATH: query pkg-config if available
+ libcurl-tutorial.3: fix typo
- Bug: https://github.com/bagder/curl/pull/171
+ closes #2008
+
+Alessandro Ghedini (23 Oct 2017)
+- curl_mime_filedata.3: fix typos
-Daniel Stenberg (17 Apr 2015)
-- parsecfg: do not continue past a zero termination
+Daniel Stenberg (23 Oct 2017)
+- RELEASE-NOTES: clean slate towards 7.57.0
+
+- [Max Dymond brought this change]
+
+ travis: exit if any steps fail
- When a config file line ends without newline, the parsing function could
- continue reading beyond that point in memory.
+ We don't expect any steps to fail in travis. Exit the script if they do.
- Reported-by: Hanno Böck
+ Closes #1966
-Jay Satiro (16 Apr 2015)
-- gitignore: Ignore Windows build output directories
+Version 7.56.1 (23 Oct 2017)
-Daniel Stenberg (15 Apr 2015)
-- RELEASE-NOTES: synced with 1ba6e4c88e0
+Daniel Stenberg (23 Oct 2017)
+- RELEASE-NOTES: 7.56.1
-- TODO: 17.9 Choose the name of file in braces for complex URLs
+- THANKS: update at 7.56.1 release time
-- TODO: a little caution that maybe not all ideas are still good
+- [Jon DeVree brought this change]
-- TODO: 17.8 offer color-coded HTTP header output
+ mk-ca-bundle: Remove URL for aurora
+
+ Aurora is no longer used by Mozilla
+ https://hacks.mozilla.org/2017/04/simplifying-firefox-release-channels/
-- TODO: 17.7 warning when sending binary output to terminal
+- [Jon DeVree brought this change]
-- KNOWN_BUGS: #90 IMAP "SEARCH ALL" truncates output on large boxes
+ mk-ca-bundle: Fix URL for NSS
+
+ The 'tip' is the most recent branch committed to, this should be
+ 'default' like the URLs for the browser are.
+
+ Closes #1998
-Jay Satiro (14 Apr 2015)
-- cyassl: Add support for TLS extension SNI
+- imap: if a FETCH response has no size, don't call write callback
+
+ CVE-2017-1000257
+
+ Reported-by: Brian Carpenter and 0xd34db347
+ Also detected by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3586
-Daniel Stenberg (13 Apr 2015)
-- [Matthew Hall brought this change]
+- ftp: reject illegal IP/port in PASV 227 response
+
+ ... by using range checks. Among other things, this avoids an undefined
+ behavior for a left shift that could happen on negative or very large
+ values.
+
+ Closes #1997
+
+ Detected by OSS-fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3694
- gitignore: ignore test-driver file
+Patrick Monnerat (20 Oct 2017)
+- test653: check reuse of easy handle after mime data change
+
+ See issue #1999
-- [Matthew Hall brought this change]
+- mime: do not reuse previously computed multipart size
+
+ The contents might have changed: size must be recomputed.
+
+ Reported-by: moteus on github
+ Fixes #1999
- vtls_openssl: improve PKCS#12 load failure error message
+- test308: disable if MultiSSL feature enabled
+
+ Even if OpenSSL is enabled, it might not be the default backend when
+ multi-ssl is enabled, causing the test to fail.
-- [Matthew Hall brought this change]
+- runtests: support MultiSSL client feature
- vtls_openssl: fix minor typo in PKCS#12 load routine
+- vtls: change struct Curl_ssl `close' field name to `close_one'.
+
+ On OS/400, `close' is an ASCII system macro that corrupts the code if
+ not used in a context not targetting the close() system API.
-- [Matthew Hall brought this change]
+- os400: add missing symbols in config file.
+
+ Also adjust makefile to renamed files and warn about installation dirs mix-up.
- vtls_openssl: improve client certificate load failure error messages
+- test652: curl_mime_data + base64 encoder with large contents
-- [Matthew Hall brought this change]
+- mime: limit bas64-encoded lines length to 76 characters
- vtls_openssl: remove ambiguous SSL_CLIENT_CERT_ERR constant
+Daniel Stenberg (16 Oct 2017)
+- RELEASE-NOTES: synced with f121575c0
-- BUGS: refer to the github issue tracker now as primary
+- setopt: range check most long options
+
+ ... filter early instead of risking "funny values" having to be dealt
+ with elsewhere.
-- firefox-db2pem: fix wildcard to find Firefox default profile
+- setopt: avoid integer overflows when setting millsecond values
- At some point, Firefox has changed and generates different directory
- names for the default profile that made this script fail to find them.
+ ... that are multiplied by 1000 when stored.
- Bug: https://github.com/bagder/curl/issues/207
- Reported-by: sneakyimp
-
-Jay Satiro (11 Apr 2015)
-- cyassl: Include the CyaSSL build config
+ For 32 bit long systems, the max value accepted (2147483 seconds) is >
+ 596 hours which is unlikely to ever be set by a legitimate application -
+ and previously it didn't work either, it just caused undefined behavior.
+
+ Also updated the man pages for these timeout options to mention the
+ return code.
- CyaSSL >= 2.6.0 may have an options.h that was generated during
- its build by configure.
+ Closes #1938
-- build: Generate source prerequisites for Visual Studio in generate.bat
+Viktor Szakats (15 Oct 2017)
+- makefile.m32: allow to override gcc, ar and ranlib
- Prior to this change Visual Studio builds could fail due to missing
- prerequisites src/tool_hugehelp.c and include/curl/curlbuild.h.
+ Allow to ovverride certain build tools, making it possible to
+ use LLVM/Clang to build curl. The default behavior is unchanged.
+ To build with clang (as offered by MSYS2), these settings can
+ be used:
- http://curl.haxx.se/mail/lib-2015-04/0034.html
+ CURL_CC=clang
+ CURL_AR=llvm-ar
+ CURL_RANLIB=llvm-ranlib
+
+ Closes https://github.com/curl/curl/pull/1993
-Daniel Stenberg (9 Apr 2015)
-- [Viktor Szakats brought this change]
+- ldap: silence clang warning
+
+ Use memset() to initialize a structure to avoid LLVM/Clang warning:
+ ldap.c:193:39: warning: missing field 'UserLength' initializer [-Wmissing-field-initializers]
+
+ Closes https://github.com/curl/curl/pull/1992
- lib/makefile.m32: add missing libs to build libcurl.dll
+Daniel Stenberg (14 Oct 2017)
+- runtests: use valgrind for torture as well
- Add 'gdi32' and 'crypt32' Windows implibs to avoid failure
- while building libcurl.dll using the mingw compiler.
- The same logic is used in 'src/makefile.m32' when
- building curl.exe.
+ NOTE: it makes them terribly slow. I recommend only using valgrind for
+ specific torture tests or using lots of patience.
-Kamil Dudka (8 Apr 2015)
-- test142[23]: verify that an empty file is stored on success
+- memdebug: trace send, recv and socket
+
+ ... to allow them to be included in torture tests too.
+
+ closes #1980
-- src/tool_operate: create output file on successful download
+- configure: remove the C++ compiler check
- ... of an empty file
+ ... we used it only for the fuzzer, which we now have in a separate git
+ repo.
- Bug: https://github.com/bagder/curl/issues/183
+ Closes #1990
-- src/tool_cb_wrt: separate fnc for output file creation
+Patrick Monnerat (13 Oct 2017)
+- mime: do not call failf() if easy handle is NULL.
-Daniel Stenberg (7 Apr 2015)
-- [Da-Yoon Chung brought this change]
+Daniel Stenberg (13 Oct 2017)
+- test651: curl_formadd with huge COPYCONTENTS
- lib/transfer.c: Remove factor of 8 from sleep time calculation
+- mime: fix the content reader to handle >16K data properly
- The factor of 8 is a bytes-to-bits conversion factor, but pkt_size and
- rate_bps are both in bytes. When using the rate limiting option, curl
- waits 8 times too long, and then transfers very quickly until the
- average rate reaches the limit. The average rate follows the limit over
- time, but the actual traffic is bursty.
-
- Thanks-to: Benjamin Gilbert
-
-- [Jay Satiro brought this change]
+ Reported-by: Jeroen Ooms
+ Closes #1988
- x509asn1: Silence x64 loss-of-data warning on RSA key length assignment
+Patrick Monnerat (12 Oct 2017)
+- mime: keep "text/plain" content type if user-specified.
- The key length in bits will always fit in an unsigned long so the
- loss-of-data warning assigning the result of x64 pointer arithmetic to
- an unsigned long is unnecessary.
+ Include test cases in 554, 587, 650.
+
+ Fixes https://github.com/curl/curl/issues/1986
-- [Jay Satiro brought this change]
+- cli tool: use file2memory() to buffer stdin in -F option.
+
+ Closes PR https://github.com/curl/curl/pull/1985
- cyassl: Use CYASSL_MAX_ERROR_SZ for error buffer size
+- cli tool: reimplement stdin buffering in -F option.
+
+ If stdin is not a regular file, its content is memory-buffered to enable
+ a possible data "rewind".
+ In all cases, stdin data size is determined before real use to avoid
+ having an unknown part's size.
- Also fix it so that all ERR_error_string calls use an error buffer.
- CyaSSL's implementation of ERR_error_string only writes the error when
- an error buffer is passed.
+ --libcurl generated code is left as an unbuffered stdin fread/fseek callback
+ part with unknown data size.
- http://www.yassl.com/forums/topic599-openssl-compatibility-and-errerrorstring.html
+ Buffering is not supported in deprecated curl_formadd() API.
-- [Jay Satiro brought this change]
+Daniel Stenberg (12 Oct 2017)
+- winbuild/BUILD.WINDOWS.txt: mention WITH_NGHTTP2
- cyassl: Remove 'Connecting to' message from cyassl_connect_step2
+- HELP-US: the label "PR-welcome" is now renamed to "help wanted"
- Prior to this change libcurl could show multiple 'CyaSSL: Connecting to'
- messages since cyassl_connect_step2 is called multiple times, typically.
- The message is superfluous even once since libcurl already informs the
- user elsewhere in code that it is connecting.
+ following the new github "standard"
-- [Viktor Szakats brought this change]
+- RELEASE-NOTES: synced with 5505df7d2
- checksrc.bat: quotes to support an SRC_DIR with spaces
+Jay Satiro (11 Oct 2017)
+- [Artak Galoyan brought this change]
-- hostip: fix compiler warnings
+ url: Update current connection SSL verify params in setopt
- introduced in the previous mini-series of 3 commits
+ Now VERIFYHOST, VERIFYPEER and VERIFYSTATUS options change during active
+ connection updates the current connection's (i.e.'connectdata'
+ structure) appropriate ssl_config (and ssl_proxy_config) structures
+ variables, making these options effective for ongoing connection.
+
+ This functionality was available before and was broken by the
+ following change:
+ "proxy: Support HTTPS proxy and SOCKS+HTTP(s)"
+ CommitId: cb4e2be7c6d42ca0780f8e0a747cecf9ba45f151.
+
+ Bug: https://github.com/curl/curl/issues/1941
+
+ Closes https://github.com/curl/curl/pull/1951
-- [Stefan Bühler brought this change]
+Daniel Stenberg (11 Oct 2017)
+- [David Benjamin brought this change]
- actually implement CURLOPT_RESOLVE removals
+ openssl: don't use old BORINGSSL_YYYYMM macros
+
+ Those were temporary things we'd add and remove for our own convenience
+ long ago. The last few stayed around for too long as an oversight but
+ have since been removed. These days we have a running
+ BORINGSSL_API_VERSION counter which is bumped when we find it
+ convenient, but 2015-11-19 was quite some time ago, so just check
+ OPENSSL_IS_BORINGSSL.
- - also log when a CURLOPT_RESOLVE entry couldn't get parsed
+ Closes #1979
-- [Stefan Bühler brought this change]
+- test950; verify SMTP with custom request
- move Curl_share_lock and ref counting into Curl_fetch_addr
+- ftpserver: support case insensitive commands
-- [Stefan Bühler brought this change]
+- smtp_done: free data before returning (on send failure)
+
+ ... as otherwise it could leak that memory.
+
+ Detected by OSS-fuzz:
+ https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3600
+
+ Assisted-by: Max Dymond
+ Closes #1977
- fix refreshing of obsolete dns cache entries
+- FTP: URL decode path for dir listing in nocwd mode
+
+ Reported-by: Zenju on github
- - cache entries must be also refreshed when they are in use
- - have the cache count as inuse reference too, freeing timestamp == 0 special
- value
- - use timestamp == 0 for CURLOPT_RESOLVE entries which don't get refreshed
- - remove CURLOPT_RESOLVE special inuse reference (timestamp == 0 will prevent refresh)
- - fix Curl_hostcache_clean - CURLOPT_RESOLVE entries don't have a special
- reference anymore, and it would also release non CURLOPT_RESOLVE references
- - fix locking in Curl_hostcache_clean
- - fix unit1305.c: hash now keeps a reference, need to set inuse = 1
+ Test 244 added to verify
+ Fixes #1974
+ Closes #1976
-- RELEASE-NOTES: synced with abf6bddc14a
+- test298: verify --ftp-method nowcwd with URL encoded path
+
+ Ref: #1974
-- [Jay Satiro brought this change]
+- CURLOPT_XFERINFODATA.3: fix duplicate see also
- checksrc.bat: Check lib\vtls source
+- CURLOPT_NOPROGRESS.3: also refer to xferinfofunction
-- [Jay Satiro brought this change]
+- FAQ: s/CURLOPT_PROGRESSFUNCTION/CURLOPT_XFERINFOFUNCTION
- cyassl: Set minimum protocol version before CTX callback
+- openssl: enable PKCS12 support for !BoringSSL
- This change is to allow the user's CTX callback to change the minimum
- protocol version in the CTX without us later overriding it, as we did
- prior to this change.
-
-- [Jay Satiro brought this change]
-
- build-openssl.bat: Fix mixed line endings
+ Enable PKCS12 for all non-boringssl builds without relying on configure
+ or cmake checks.
- Use LF not CRLF, throughout. msysgit will only convert a file to CRLF
- on checkout if it's not mixed.
+ Bug: https://curl.haxx.se/mail/lib-2017-10/0007.html
+ Reported-by: Christian Schmitz
+ Closes #1948
-- [Jay Satiro brought this change]
+- [Kristiyan Tsaklev brought this change]
- cyassl: Fix certificate load check
+ curl: don't pass semicolons when parsing Content-Disposition
- SSL_CTX_load_verify_locations can return negative values on fail,
- therefore to check for failure we check if load is != 1 (success)
- instead of if load is == 0 (failure), the latter being incorrect given
- that behavior.
-
-- [Tatsuhiro Tsujikawa brought this change]
+ Test 1422 updated to verify.
+
+ Closes #1964
- http2: Fix missing nghttp2_session_send call in Curl_http2_switched
+Patrick Monnerat (9 Oct 2017)
+- mime: properly unbind mime structure in curl_mime_free().
- Previously in Curl_http2_switched, we called nghttp2_session_mem_recv to
- parse incoming data which were already received while curl was handling
- upgrade. But we didn't call nghttp2_session_send, and it led to make
- curl not send any response to the received frames. Most likely, we
- received SETTINGS from server at this point, so we missed opportunity to
- send SETTINGS + ACK. This commit adds missing nghttp2_session_send call
- in Curl_http2_switched to fix this issue.
+ This allows freeing a mime structure bound to the easy handle before
+ curl_easy_cleanup().
- Bug: https://github.com/bagder/curl/issues/192
- Reported-by: Stefan Eissing
+ Fixes #1970.
-- cookie: handle spaces after the name in Set-Cookie
+Daniel Stenberg (9 Oct 2017)
+- RTSP: avoid integer overflow on funny RTSP response
- "name =value" is fine and the space should just be skipped.
+ ... like a very large non-existing RTSP version number.
- Updated test 31 to also test for this.
+ Added test 577 to verify.
- Bug: https://github.com/bagder/curl/issues/195
- Reported-by: cromestant
- Help-by: Frank Gevaerts
+ Detected by OSS-fuzz.
+ Closes #1969
-- [Jay Satiro brought this change]
+Patrick Monnerat (8 Oct 2017)
+- ftpserver: properly reset $ftptargetdir.
- cyassl: Fix library initialization return value
+- test643: verify curl_mime_subparts() rejects cyclic additions.
+
+- mime: refuse to add subparts to one of their own descendants.
- (Curl_cyassl_init)
- - Return 1 on success, 0 in failure.
+ Reported-by: Alexey Melnichuk
+ Fixes #1962
+
+- mime: avoid resetting a part's encoder when part's contents change.
+
+- mime: improve unbinding top multipart from easy handle.
- Prior to this change the fail path returned an incorrect value and the
- evaluation to determine whether CyaSSL_Init had succeeded was incorrect.
- Ironically that combined with the way curl_global_init tests SSL library
- initialization (!Curl_ssl_init()) meant that CyaSSL having been
- successfully initialized would be seen as that even though the code path
- and return value in Curl_cyassl_init were wrong.
+ Also avoid dangling pointers in referencing parts.
+
+Daniel Stenberg (8 Oct 2017)
+- RELEASE-NOTES: synced with a4c1c75da30af1
+
+- curlver.h: next expected release is 7.57.0
+
+Patrick Monnerat (8 Oct 2017)
+- mime: be tolerant about setting twice the same header list in a part.
-- [Thomas Ruecker brought this change]
+- docs: clarify form/mime usage of non-regular data files.
- CURLOPT_HTTP200ALIASES.3: Mainly SHOUTcast servers use "ICY 200"
+Daniel Stenberg (8 Oct 2017)
+- Revert "multi_done: wait for name resolve to finish if still ongoing"
- Icecast versions 1.3.0 through 1.3.12 would reply with "ICY 200"
- under certain conditions:
+ This reverts commit f3e03f6c0ac52a1bf396e03f7d7e9b5b3b7165fe.
- client_wants_icy_headers (connection_t *con)
- {
- const char *val;
+ Caused memory leaks in the fuzzer, needs to be done differently.
- if (!con)
- return 1;
+ Disable test 1553 for now too, as it causes memory leaks without this
+ commit!
+
+- remove_handle: call multi_done() first, then clear dns cache pointer
- val = get_user_agent (con);
- if (!val || !val[0] || strcmp (val, "(null)") == 0)
- return 1;
+ Closes #1960
+
+- multi_done: wait for name resolve to finish if still ongoing
- if (con->food.client->use_icy)
- return 1;
- if (strncasecmp (val, "winamp", 6) == 0)
- return 1;
- if (strncasecmp (val, "Shoutcast", 9) == 0)
- return 1;
+ ... as we must clean up memory.
+
+- pingpong: return error when trying to send without connection
- return 0;
- }
+ When imap_done() got called before a connection is setup, it would try
+ to "finish up" and dereffed a NULL pointer.
- So mainly if there is no 'user agent' or it is '(null)' or contains
- 'winamp' or 'Shoutcast'.
+ Test case 1553 managed to reproduce. I had to actually use a host name
+ to try to resolve to slow it down, as using the normal local server IP
+ will make libcurl get a connection in the first curl_multi_perform()
+ loop and then the bug doesn't trigger.
- No mainstream distribution carries Icecast 1.3.x anymore, after all
- it was released in 2002 and superseded by Icecast 2.x.
+ Fixes #1953
+ Assisted-by: Max Dymond
-Dan Fandrich (31 Mar 2015)
-- axtls: add timeout within Curl_axtls_connect
+Dan Fandrich (6 Oct 2017)
+- tests: added flaky keyword to tests 587 and 644
- This allows test 405 to pass on axTLS.
+ These are around 5% flaky in my Linux x86 autobuilds.
-Daniel Stenberg (30 Mar 2015)
-- [Jay Satiro brought this change]
+Marcel Raad (6 Oct 2017)
+- vtls: fix warnings with --disable-crypto-auth
+
+ When CURL_DISABLE_CRYPTO_AUTH is defined, Curl_none_md5sum's parameters
+ are not used.
- checksrc: Windows-specific input fixes
+Daniel Stenberg (6 Oct 2017)
+- multi_cleanup: call DONE on handles that never got that
- lib/config-win32ce.h
- - Fix whitespace for checksrc compliance.
+ ... fixes a memory leak with at least IMAP when remove_handle is never
+ called and the transfer is abruptly just abandoned early.
- lib/checksrc.pl
- - Remove trailing carriage returns from input.
+ Test 1552 added to verify
- projects/checksrc.bat
- - Ignore tool_hugehelp.c.
+ Detected by OSS-fuzz
+ Assisted-by: Max Dymond
+ Closes #1954
-- [Dagobert Michelsen brought this change]
+- [Benbuck Nason brought this change]
- configure: Use KRB5CONFIG for krb5-config
+ strtoofft: Remove extraneous null check
- Allows the user to easier override its path.
+ Fixes #1950: curlx_strtoofft() doesn't fully protect against null 'str'
+ argument.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1486
+ Closes #1952
-- multi: remove_handle: move pending connections
-
- If the handle removed from the multi handle happens to be the one
- "owning" the pipeline other transfers will be waiting indefinitely. Now
- we move such handles back to connect to have them race (again) for
- getting the connection and thus avoid hanging.
+- openssl: fix build without HAVE_OPAQUE_EVP_PKEY
- Bug: http://curl.haxx.se/bug/view.cgi?id=1465
- Reported-by: Jiri Dvorak
+ Reported-by: Javier Sixto
+ Fixes #1955
+ Closes #1956
-- KNOWN_BUGS: 89 is bug #1411
+Viktor Szakats (6 Oct 2017)
+- lib/config-win32.h: let SMB/SMBS be enabled with OpenSSL/NSS
- Disabling pipelining on multi handle with in-progress pipelined requests
- leads to heap corruption and crash
-
-- [Jay Satiro brought this change]
-
- cyassl: CTX callback cosmetic changes and doc fix
+ The source code is now prepared to handle the case when both
+ Win32 Crypto and OpenSSL/NSS crypto backends are enabled
+ at the same time, making it now possible to enable `USE_WIN32_CRYPTO`
+ whenever the targeted Windows version supports it. Since this
+ matches the minimum Windows version supported by curl
+ (Windows 2000), enable it unconditionally for the Win32 platform.
- - More descriptive fail message for NO_FILESYSTEM builds.
- - Cosmetic changes.
- - Change more of CURLOPT_SSL_CTX_* doc to not be OpenSSL specific.
-
-- RELEASE-NOTES: synced with d2feb71752f
-
-Dan Fandrich (28 Mar 2015)
-- tool_operate: only set SSL options if SSL is enabled
-
-- runtests.pl: detect WolfSSL as yassl
-
-Daniel Stenberg (27 Mar 2015)
-- [Kyle L. Huff brought this change]
-
- cyassl: add SSL context callback support for CyaSSL
+ This in turn enables SMB (and SMBS) protocol support whenever
+ Win32 Crypto is available, regardless of what other crypto backends
+ are enabled.
- Adds support for CURLOPT_SSL_CTX_FUNCTION when using CyaSSL, and better
- handles CyaSSL instances using NO_FILESYSTEM.
-
-- [Kyle L. Huff brought this change]
+ Ref: https://github.com/curl/curl/pull/1840#issuecomment-325682052
+
+ Closes https://github.com/curl/curl/pull/1943
- cyassl: remove undefined reference to CyaSSL_no_filesystem_verify
+Daniel Stenberg (5 Oct 2017)
+- build: fix --disable-crypto-auth
- CyaSSL_no_filesystem_verify is not (or no longer) defined by cURL or
- CyaSSL. This reference causes build errors when compiling with
- NO_FILESYSTEM.
+ Reported-by: Wyatt O'Day
+ Fixes #1945
+ Closes #1947
-- [Jay Satiro brought this change]
+Jay Satiro (5 Oct 2017)
+- [Nick Zitzmann brought this change]
- build: Fix libcurl.sln erroneous mixed configurations
+ darwinssl: add support for TLSv1.3
- Prior to this change some Release configurations had an active
- configuration assignment to their Debug counterpart.
-
-- [Jay Satiro brought this change]
+ Closes https://github.com/curl/curl/pull/1794
- vtls: Don't accept unknown CURLOPT_SSLVERSION values
+Daniel Stenberg (4 Oct 2017)
+- [Felix Kaiser brought this change]
-- [Jay Satiro brought this change]
+ docs: fix typo in curl_mime_data_cb man page
+
+ Closes #1946
- url: Don't accept CURLOPT_SSLVERSION unless USE_SSL is defined
+Viktor Szakats (4 Oct 2017)
+- lib/Makefile.m32: allow customizing dll suffixes
+
+ - New `CURL_DLL_SUFFIX` envvar will add a suffix to the generated
+ libcurl dll name. Useful to add `-x64` to 64-bit builds so that
+ it can live in the same directory as the 32-bit one. By default
+ this is empty.
+
+ - New `CURL_DLL_A_SUFFIX` envvar to customize the suffix of the
+ generated import library (implib) for libcurl .dll. It defaults
+ to `dll`, and it's useful to modify that to `.dll` to have the
+ standard naming scheme for mingw-built .dlls, i.e. `libcurl.dll.a`.
+
+ Closes https://github.com/curl/curl/pull/1942
-- [Paul Howarth brought this change]
+Daniel Stenberg (4 Oct 2017)
+- [Max Dymond brought this change]
- build: link curl to openssl libraries when openssl support is enabled
+ fuzzer: move to using external curl-fuzzer
- This fixes a build failure where openssl and libmetalink are used
- together and the system linker does not do implicit linking (e.g.
- Fedora 13 and later releases). The MD5 functions required for
- metalink support must be pulled in from the openssl crypto library.
+ Use the external curl-fuzzer repository for fuzzing.
- This is similar to commit c6e7cbb94e669b85d3eb8e015ec51d0072112133,
- which fixes the same sort of problem for NSS builds.
+ Closes #1923
-- multi: on a request completion, check all CONNECT_PEND transfers
+- failf: skip the sprintf() if there are no consumers
- ... even if they don't have an associated connection anymore. It could
- leave the waiting transfers pending with no active one on the
- connection.
+ Closes #1936
+
+- ftp: UBsan fixup 'pointer index expression overflowed'
- Bug: http://curl.haxx.se/bug/view.cgi?id=1465
- Reported-by: Jiri Dvorak
+ Closes #1939
-- [Emil Lerner brought this change]
+- RELEASE-PROCEDURE: update the release schedule
- globbing: fix url number calculation when using range with step
-
- In function glob_range, the number of urls was multiplied by (max - min
- + 1), regardless of step. The correct formula is (max - min) / step + 1
+Version 7.56.0 (4 Oct 2017)
-- README.http2: refreshed and added TODO items
+Daniel Stenberg (4 Oct 2017)
+- RELEASE-NOTES: curl 7.56.0
-- [Emil Lerner brought this change]
+- THANKS: added new 7.56.0 contributors
- globbing: fix step parsing for character globbing ranges
+Jay Satiro (4 Oct 2017)
+- build-openssl.bat: Warn OpenSSL 1.1.0 not yet supported
- The glob_range function used wrong offset (3 instead of 4) for parsing
- integer step inside character range specification, which led to 'bad
- range' error when using character ranges with explicitly specified step
- (such as '[a-z:2]')
+ Ref: https://github.com/curl/curl/issues/1002
-- polarssl: called mbedTLS in 1.3.10 and later
+Michael Kaufmann (3 Oct 2017)
+- idn: fix source code comment
-- polarssl: remove dead code
+- vtls: compare and clone ssl configs properly
- and simplify code by changing if-elses to a switch()
+ Compare these settings in Curl_ssl_config_matches():
+ - verifystatus (CURLOPT_SSL_VERIFYSTATUS)
+ - random_file (CURLOPT_RANDOM_FILE)
+ - egdsocket (CURLOPT_EGDSOCKET)
- CID 1291706: Logically dead code. Execution cannot reach this statement
-
-- polarssl: remove superfluous for(;;) loop
+ Also copy the setting "verifystatus" in Curl_clone_primary_ssl_config(),
+ and copy the setting "sessionid" unconditionally.
- "unreachable: Since the loop increment is unreachable, the loop body
- will never execute more than once."
+ This means that reusing connections that are secured with a client
+ certificate is now possible, and the statement "TLS session resumption
+ is disabled when a client certificate is used" in the old advisory at
+ https://curl.haxx.se/docs/adv_20170419.html is obsolete.
- Coverity CID 1291707
+ Reviewed-by: Daniel Stenberg
+
+ Closes #1917
-- Curl_ssl_md5sum: return CURLcode
+- proxy: read the "no_proxy" variable only if necessary
- ... since the funciton can fail on OOM. Check this return code.
+ Reviewed-by: Daniel Stenberg
- Coverity CID 1291705.
+ Closes #1919
-- [Jay Satiro brought this change]
+Patrick Monnerat (3 Oct 2017)
+- libcurl-tutorial: add casts in example to avoid compilation warnings.
+
+Daniel Stenberg (3 Oct 2017)
+- examples: bring back curl_formadd-using examples
+
+ ... now with a -formadd suffix. While the new mime API is introduced in
+ 7.56.0 we must acknowledge that lots of users can't upgrade their curl
+ versions immediately.
- cyassl: default to highest possible TLS version
+- test1153: verify quoted double-qoutes in PWD response
+
+- FTP: zero terminate the entry path even on bad input
- (cyassl_connect_step1)
- - Use TLS 1.0-1.2 by default when available.
+ ... a single double quote could leave the entry path buffer without a zero
+ terminating byte. CVE-2017-1000254
- CyaSSL/wolfSSL >= v3.3.0 supports setting a minimum protocol downgrade
- version.
+ Test 1152 added to verify.
- cyassl/cyassl@322f79f
+ Reported-by: Max Dymond
+ Bug: https://curl.haxx.se/docs/adv_20171004.html
-- [Jay Satiro brought this change]
+Jay Satiro (2 Oct 2017)
+- [Sergei Nikulov brought this change]
- cyassl: Check for invalid length parameter in Curl_cyassl_random
+ cmake: disable tests and man generation if perl/nroff not found
+
+ Fixes https://github.com/curl/curl/issues/1500
+ Reported-by: Jay Satiro
+
+ Fixes https://github.com/curl/curl/pull/1662
+ Assisted-by: Tom Seddon
+ Assisted-by: dpull@users.noreply.github.com
+ Assisted-by: elelel@users.noreply.github.com
+
+ Closes https://github.com/curl/curl/pull/1924
-- [Jay Satiro brought this change]
+Patrick Monnerat (2 Oct 2017)
+- libcurl-tutorial: fix two typos.
- cyassl: If wolfSSL then identify as such in version string
+- TODO: remove deprecated form API items.
-Dan Fandrich (24 Mar 2015)
-- symbols-in-versions: added CURLOPT_PATH_AS_IS
+- libcurl-tutorial: describe MIME API and deprecate form API.
+
+ Include a guide to form/mime API conversion.
-- testcurl.pl: add the --notes option to supply more info about a build
+Daniel Stenberg (30 Sep 2017)
+- cookie: fix memory leak if path was set twice in header
- Support for notes has been in place for a while, but it required
- being added to the setup file manually.
+ ... this will let the second occurance override the first.
+
+ Added test 1161 to verify.
+
+ Reported-by: Max Dymond
+ Fixes #1932
+ Closes #1933
-- curl_memory: make curl_memory.h the second-last header file loaded
+Dan Fandrich (30 Sep 2017)
+- test650: Use variable replacement to set the host address and port
- This header file must be included after all header files except
- memdebug.h, as it does similar memory function redefinitions and can be
- similarly affected by conflicting definitions in system or dependent
- library headers.
+ Otherwise, the test fails when the -b test option is used to set a
+ different test port range.
-Daniel Stenberg (24 Mar 2015)
-- openssl: do the OCSP work-around for libressl too
+- Set and use more necessary options when some protocols are disabled
- I tested with libressl git master now (v2.1.4-27-g34bf96c) and it seems to
- still require the work-around for stapling to work.
+ When curl and libcurl are built with some protocols disabled, they stop
+ setting and receiving some options that don't make sense with those
+ protocols. In particular, when HTTP is disabled many options aren't set
+ that are used only by HTTP. However, some options that appear to be
+ HTTP-only are actually used by other protocols as well (some despite
+ having HTTP in the name) and should be set, but weren't. This change now
+ causes some of these options to be set and used for more (or for all)
+ protocols. In particular, this fixes tests 646 through 649 in an
+ HTTP-disabled build, which use the MIME API in the mail protocols.
-- openssl: verifystatus: only use the OCSP work-around <= 1.0.2a
+Daniel Stenberg (29 Sep 2017)
+- test1160: verifies cookie leak for large cookies
- URL: http://curl.haxx.se/mail/lib-2015-03/0205.html
- Reported-by: Alessandro Ghedini
+ The fix done in 20ea22ff735
-- openssl: adapt to ASN1/X509 things gone opaque in 1.1
+- cookie: fix memory leak on oversized rejection
+
+ Regression brought by 2bc230de63b
+
+ Detected by OSS-fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3513
+ Assisted-by: Max Dymond
+
+ Closes #1930
-Dan Fandrich (24 Mar 2015)
-- [Jay Satiro brought this change]
+- [Anders Bakken brought this change]
- curl_easy_setopt.3: Fix misspelling in CURLOPT_PATH_AS_IS description
+ connect: fix race condition with happy eyeballs timeout
+
+ The timer should be started after conn->connecttime is set. Otherwise
+ the timer could expire without this condition being true:
+
+ /* should we try another protocol family? */
+ if(i == 0 && conn->tempaddr[1] == NULL &&
+ curlx_tvdiff(now, conn->connecttime) >= HAPPY_EYEBALLS_TIMEOUT) {
+
+ Ref: #1928
-- [Viktor Szakáts brought this change]
+Michael Kaufmann (28 Sep 2017)
+- docs: link CURLOPT_CONNECTTIMEOUT and CURLOPT_CONNECTTIMEOUT_MS
+
+ Closes #1922
- CURLOPT_HTTPHEADER.3: fix typo in recent commit
+- docs: clarify the use of environment variables for proxy
+
+ Closes #1921
-- [Viktor Szakáts brought this change]
+- http: add custom empty headers to repeated requests
+
+ Closes #1920
- CURLOPT_PATH_AS_IS.3: add type 'long' to prototype
+- reuse_conn: don't copy flags that are known to be equal
+
+ A connection can only be reused if the flags "conn_to_host" and
+ "conn_to_port" match. Therefore it is not necessary to copy these flags
+ in reuse_conn().
+
+ Closes #1918
-- vtls: fix compile with --disable-crypto-auth but with SSL
+Daniel Stenberg (27 Sep 2017)
+- curl.h: include <sys/select.h> on cygwin too
+
+ When building with -std=c++14 on cygwin, this header won't be
+ automatically included as it otherwise is.
- This is a strange combination of options, but is allowed.
+ The <sys/select.h> include decision should ideally be reversed and be
+ avoided where that header file doesn't exist.
+
+ Reported-by: Ian Fette
+ Fixes #1925
-Patrick Monnerat (24 Mar 2015)
-- os400: define new options in ILE/RPG binding.
+- RELEASE-NOTES: synced with d8ab5dc50
-Daniel Stenberg (24 Mar 2015)
-- RELEASE-NOTES: synced with f6878609361
+Michael Kaufmann (24 Sep 2017)
+- tests: adjust .gitignore for new tests
-- curl_easy_setopt.3: Add CURLOPT_PATH_AS_IS
+Jay Satiro (23 Sep 2017)
+- ntlm: move NTLM_NEEDS_NSS_INIT define into core NTLM header
+
+ .. and include the core NTLM header in all NTLM-related source files.
+
+ Follow up to 6f86022. Since then http_ntlm checks NTLM_NEEDS_NSS_INIT
+ but did not include vtls.h where it was defined.
+
+ Closes https://github.com/curl/curl/pull/1911
-- CURLOPT_PATH_AS_IS: added
+Daniel Stenberg (23 Sep 2017)
+- file_range: avoid integer overflow when figuring out byte range
- --path-as-is is the command line option
+ When trying to bump the value with one and the value is already at max,
+ it causes an integer overflow.
- Added docs in curl.1 and CURLOPT_PATH_AS_IS.3
+ Closes #1908
+ Detected by oss-fuzz:
+ https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3465
- Added test in test 1241
+ Assisted-by: Max Dymond
-- [Yamada Yasuharu brought this change]
+Michael Kaufmann (23 Sep 2017)
+- tests: fix a compiler warning in test 643
- curl_easy_recv/send: make them work with the multi interface
+Jay Satiro (23 Sep 2017)
+- symbols-in-versions: fix CURLSSLSET_NO_BACKENDS entry
- By making sure Curl_getconnectinfo() uses the correct connection cache
- to find the last connection.
-
-- http2: move the init too for when its actually needed
+ - Use spaces instead of tabs as the delimiter.
- ... it would otherwise lead to memory leakage if we never actually do
- the switch.
+ Follow up to 7c52b12 which added the entry. The entry had used tabs but
+ the symbol-scan parser doesn't recognize tabs and would fail the symbol.
-Dan Fandrich (23 Mar 2015)
-- dict: rename byte to avoid compiler shadowed declaration warning
+Viktor Szakats (22 Sep 2017)
+- metalink: fix NSS issue in MultiSSL builds
- This conflicted with a WolfSSL typedef.
-
-- cyassl: include version.h to ensure the version macros are defined
-
-- test1513: eliminated race condition in test run
+ In MultiSSL mode (i.e. when more than one SSL backend is compiled
+ in), we cannot use the compile time flag `USE_NSS` as indicator that
+ the NSS backend is in use. As far as Metalink is concerned, the SSL
+ backend is only used for MD5, SHA-1 and SHA-256 calculations,
+ therefore one of the available SSL backends is selected at compile
+ time, in a strict order of preference.
+
+ Let's introduce a new `HAVE_NSS_CONTEXT` constant that can be used
+ to determine whether the SSL backend used for Metalink is the NSS
+ backend, and use that to guard the code that wants to de-initialize
+ the NSS-specific data structure.
- It seems that some systems (e.g. fairly consistently in some recent
- Solaris autobuilds) would manage to get to the connect phase before the
- progress callback was called, resulting in a CURLE_COULDNT_CONNECT
- error. Reworked the test to point at a test server that never returns a
- full result so the progress callback always gets a chance to be called
- before the transfer can complete in some other way.
+ Ref: https://github.com/curl/curl/pull/1848
-Nick Zitzmann (21 Mar 2015)
-- darwinsssl: add support for TLS False Start
+- ntlm: use strict order for SSL backend #if branches
- TLS False Start support requires iOS 7.0 or later, or OS X 10.9 or later.
+ With the recently introduced MultiSSL support multiple SSL backends
+ can be compiled into cURL That means that now the order of the SSL
+
+ One option would be to use the same SSL backend as was configured
+ via `curl_global_sslset()`, however, NTLMv2 support would appear
+ to be available only with some SSL backends. For example, when
+ eb88d778e (ntlm: Use Windows Crypt API, 2014-12-02) introduced
+ support for NTLMv1 using Windows' Crypt API, it specifically did
+ *not* introduce NTLMv2 support using Crypt API at the same time.
+
+ So let's select one specific SSL backend for NTLM support when
+ compiled with multiple SSL backends, using a priority order such
+ that we support NTLMv2 even if only one compiled-in SSL backend can
+ be used for that.
+
+ Ref: https://github.com/curl/curl/pull/1848
-Daniel Stenberg (21 Mar 2015)
-- gtls: add check of return code
+Daniel Stenberg (22 Sep 2017)
+- symbols-in-versions: add CURLSSLSET_NO_BACKENDS
- Coverity CID 1291167 pointed out that 'rc' was received but never used when
- gnutls_credentials_set() was used. Added return code check now.
+ ...fixup from b8e0fe19ec
-- gtls: dereferencing NULL pointer
+- imap: quote atoms properly when escaping characters
+
+ Updates test 800 to verify
- Coverity CID 1291165 pointed out 'chainp' could be dereferenced when
- NULL if gnutls_certificate_get_peers() had previously failed.
+ Fixes #1902
+ Closes #1903
-- gtls: avoid uninitialized variable.
+- tests: make the imap server not verify user+password
- Coverity CID 1291166 pointed out that we could read this variable
- uninitialized.
+ ... as the test cases themselves do that and it makes it easier to add
+ crazy test cases.
+
+ Test 800 updated to use user name + password that need quoting.
+
+ Test 856 updated to trigger an auth fail differently.
+
+ Ref: #1902
-Dan Fandrich (21 Mar 2015)
-- tests/certs: rebuild certificates with modified key usage bits
+- vtls: provide curl_global_sslset() even in non-SSL builds
+
+ ... it just returns error:
- The certificates were missing the digitalSignature and keyAgreement
- usage types, of which at least digitalSignature was checked by CyaSSL.
- This caused the test server in test 310 (among others) to fail the
- startup verification and therefore run (see
- http://curl.haxx.se/mail/lib-2014-07/0303.html).
+ Bug: https://github.com/curl/curl/commit/1328f69d53f2f2e937696ea954c480412b018451#commitcomment-24470367
+ Reported-by: Marcel Raad
+
+ Closes #1906
-- tests/certs: added make target to rebuild certificates
+Patrick Monnerat (22 Sep 2017)
+- form/mime: field names are not allowed to contain zero-valued bytes.
- The certificate generation scripts were also updated to better match the
- format of the certificates currently checked in.
+ Also suppress length argument of curl_mime_name() (names are always
+ zero-terminated).
-Daniel Stenberg (21 Mar 2015)
-- x509asn1: add /* fallthrough */ in switch() case
+Daniel Stenberg (21 Sep 2017)
+- [Dirk Feytons brought this change]
-- x509asn1: minor edit to unconfuse Coverity
+ openssl: only verify RSA private key if supported
+
+ In some cases the RSA key does not support verifying it because it's
+ located on a smart card, an engine wants to hide it, ...
+ Check the flags on the key before trying to verify it.
+ OpenSSL does the same thing internally; see ssl/ssl_rsa.c
- CID 1202732 warns on the previous use, although I cannot fine any
- problems with it. I'm doing this change only to make the code use a more
- familiar approach to accomplish the same thing.
+ Closes #1904
-- [Dagobert Michelsen brought this change]
+Marcel Raad (21 Sep 2017)
+- examples/post-callback: use long for CURLOPT_POSTFIELDSIZE
+
+ Otherwise, typecheck-gcc.h warns on MinGW-w64.
- testcurl: Allow '=' in values given on command line
+Patrick Monnerat (20 Sep 2017)
+- mime: rephrase the multipart output state machine (#1898) ...
+
+ ... in hope coverity will like it much.
-- nss: error: unused variable 'connssl'
+- mime: fix an explicit null dereference (#1899)
-Dan Fandrich (21 Mar 2015)
-- test938: added missing closing tags
+Daniel Stenberg (20 Sep 2017)
+- curl: check fseek() return code and bail on error
+
+ Detected by coverity. CID 1418137.
-- cyassl: use new library version macro when available
+- smtp: fix memory leak in OOM
+
+ Regression since ce0881edee
+
+ Coverity CID 1418139 and CID 1418136 found it, but it was also seen in
+ torture testing.
-Kamil Dudka (20 Mar 2015)
-- [Alessandro Ghedini brought this change]
+- RELEASE-NOTES: synced with 5fe85587c
- curl: add --false-start option
+- [Pavel Pavlov brought this change]
-- [Alessandro Ghedini brought this change]
+ cookies: use lock when using CURLINFO_COOKIELIST
+
+ Closes #1896
- nss: add support for TLS False Start
+- [Max Dymond brought this change]
-- [Alessandro Ghedini brought this change]
+ ossfuzz: changes before merging the generated corpora
+
+ Before merging in the oss-fuzz corpora from Google, there are some changes
+ to the fuzzer.
+ - Add a read corpus script, to display corpus files nicely.
+ - Change the behaviour of the fuzzer so that TLV parse failures all now
+ go down the same execution paths, which should reduce the size of the
+ corpora.
+ - Make unknown TLVs a failure to parse, which should decrease the size
+ of the corpora as well.
+
+ Closes #1881
- url: add CURLOPT_SSL_FALSESTART option
+- mime:escape_string minor clarification change
+
+ ... as it also removes a warning with old gcc versions.
- This option can be used to enable/disable TLS False Start defined in the RFC
- draft-bmoeller-tls-falsestart.
+ Bug: https://curl.haxx.se/mail/lib-2017-09/0049.html
+ Reported-by: Ben Greear
-Patrick Monnerat (20 Mar 2015)
-- [Alessandro Ghedini brought this change]
+- [Max Dymond brought this change]
- gtls: implement CURLOPT_CERTINFO
+ ossfuzz: don't write out to stdout
+
+ Don't make the fuzzer write out to stdout - instead write some of the
+ contents to a memory block so we exercise the data output code but
+ quietly.
+
+ Closes #1885
-Daniel Stenberg (20 Mar 2015)
-- [Alessandro Ghedini brought this change]
+- cookies: reject oversized cookies
+
+ ... instead of truncating them.
+
+ There's no fixed limit for acceptable cookie names in RFC 6265, but the
+ entire cookie is said to be less than 4096 bytes (section 6.1). This is
+ also what browsers seem to implement.
+
+ We now allow max 5000 bytes cookie header. Max 4095 bytes length per
+ cookie name and value. Name + value together may not exceed 4096 bytes.
+
+ Added test 1151 to verify
+
+ Bug: https://curl.haxx.se/mail/lib-2017-09/0062.html
+ Reported-by: Kevin Smith
+
+ Closes #1894
- openssl: try to avoid accessing OCSP structs when possible
+- travis: on mac, don't install openssl or libidn
+
+ - openssl is already installed and causes warnings when trying to
+ install again
+
+ - libidn isn't used these days, and homebrew doesn't seem to have a
+ libidn2 package to replace with easily
+
+ Closes #1895
-- CURLOPT_URL.3: spelling!
+- curl: make str2udouble not return values on error
- Reported-by: Frank Gevaerts
+ ... previously it would store a return value even when it returned
+ error, which could make the value get used anyway!
+
+ Reported-by: Brian Carpenter
+ Closes #1893
-- CURLOPT_URL.3: Added "SECURITY CONCERNS"
+Jay Satiro (18 Sep 2017)
+- socks: fix incorrect port number in SOCKS4 error message
+
+ Prior to this change it appears the SOCKS5 port parsing was erroneously
+ used for the SOCKS4 error message, and as a result an incorrect port
+ would be shown in the error message.
+
+ Bug: https://github.com/curl/curl/issues/1892
+ Reported-by: Jackarain@users.noreply.github.com
-- CURLOPT_HTTPHEADER.3: add a "SECURITY CONCERNS" section
+- [Marc Aldorasi brought this change]
-Dan Fandrich (19 Mar 2015)
-- cyassl: detect the library as renamed wolfssl
+ schannel: Support partial send for when data is too large
- This change was made in CyaSSL/WolfSSL ver. 3.4.0
-
-Daniel Stenberg (19 Mar 2015)
-- HTTP: don't switch to HTTP/2 from 1.1 until we get the 101
+ Schannel can only encrypt a certain amount of data at once. Instead of
+ failing when too much data is to be sent at once, send as much data as
+ we can and let the caller send the remaining data by calling send again.
- We prematurely changed protocol handler to HTTP/2 which made things very
- slow (and wrong).
+ Bug: https://curl.haxx.se/mail/lib-2014-07/0033.html
- Reported-by: Stefan Eissing
- Bug: https://github.com/bagder/curl/issues/169
+ Closes https://github.com/curl/curl/pull/1890
-Dan Fandrich (19 Mar 2015)
-- axtls: version 1.5.2 now requires that config.h be manually included
+- [David Benjamin brought this change]
-Daniel Stenberg (19 Mar 2015)
-- metalink: fix resource leak in OOM
+ openssl: add missing includes
- Coverity CID 1288826
+ lib/vtls/openssl.c uses OpenSSL APIs from BUF_MEM and BIO APIs. Include
+ their headers directly rather than relying on other OpenSSL headers
+ including things.
+
+ Closes https://github.com/curl/curl/pull/1891
+
+Daniel Stenberg (15 Sep 2017)
+- conversions: fix several compiler warnings
-Dan Fandrich (18 Mar 2015)
-- docs/libcurl: clean up libcurl-symbols.3
+- server/getpart: provide dummy function to build conversion enabled
-- docs/libcurl: check that all options with man pages are referenced
+- non-ascii: use iconv() with 'char **' argument
- If a man page exists in the opts/ directory, it must also be referenced
- either in curl_easy_setopt.3 or curl_multi_setopt.3
+ Bug: https://curl.haxx.se/mail/lib-2017-09/0031.html
-- curl_easy_setopt.3: added a few missing options
+- escape.c: error: pointer targets differ in signedness
-Kamil Dudka (18 Mar 2015)
-- nss: explicitly tell NSS to disable NPN/ALPN
-
- ... if disabled at libcurl level. Otherwise, we would allow to
- negotiate NPN despite curl was invoked with the --no-npn option.
+- docs: clarify the CURLOPT_INTERLEAVE* options behavior
-Daniel Stenberg (18 Mar 2015)
-- [Jay Satiro brought this change]
+- [Max Dymond brought this change]
- mkhelp: Remove trailing carriage return from every line of input
+ rtsp: Segfault in rtsp.c when using WRITEDATA
- - Get rid of this flood of warnings in Windows mingw build:
- warning: missing terminating " character
+ If the INTERLEAVEFUNCTION is defined, then use that plus the
+ INTERLEAVEDATA information when writing RTP. Otherwise, use
+ WRITEFUNCTION and WRITEDATA.
- The warning is due to the carriage return. When msysgit checks out files
- from the repo by default it converts the line endings to CRLF. Prior to
- this change when mkhelp.pl processed the MANUAL and curl.1 in CRLF
- format the trailing carriage returns caused unnecessary CR in the
- output.
+ Fixes #1880
+ Closes #1884
-- RELEASE-NOTES: synced with e539f01567
-
-- [Christian Weisgerber brought this change]
+Marcel Raad (15 Sep 2017)
+- [Isaac Boukris brought this change]
- docs/libcurl: make portability fix
+ tests: enable gssapi in travis-ci linux build
- Using $< in a non-suffix rule context is a GNU make idiom. This bug was
- introduced in 7.41.0.
+ Closes https://github.com/curl/curl/pull/1687
-Dan Fandrich (17 Mar 2015)
-- checksrc: Fix whitelist on out-of-tree builds
-
-Daniel Stenberg (17 Mar 2015)
-- [Stefan Bühler brought this change]
+- [Isaac Boukris brought this change]
- Curl_sh_entry: remove unused 'timestamp'
+ tests: add initial gssapi test using stub implementation
+
+ The stub implementation is pre-loaded using LD_PRELOAD
+ and emulates common gssapi uses (only builds if curl is
+ initially built with gssapi support).
+
+ The initial tests are currently disabled for debug builds
+ as LD_PRELOAD is not used then.
+
+ Ref: https://github.com/curl/curl/pull/1687
-- HTTP: don't use Expect: headers when on HTTP/2
+Daniel Stenberg (15 Sep 2017)
+- test1150: verify same host fetch using different ports over proxy
- Reported-by: Stefan Eissing
- Bug: https://github.com/bagder/curl/issues/169
+ Closes #1889
-- checksrc: detect and remove space before trailing semicolons
+- URL: on connection re-use, still pick the new remote port
+
+ ... as when a proxy connection is being re-used, it can still get a
+ different remote port.
+
+ Fixes #1887
+ Reported-by: Oli Kingshott
-- checksrc: introduce a whitelisting concept
+- RELEASE-NOTES: synced with 87501e57f
-- checksrc: use space after comma
+- code style: remove wrong uses of multiple spaces
+
+ Closes #1878
-- checksrc: use space before paren in "return (expr);"
+- checksrc: detect and warn for multiple spaces
-- CONTRIBUTE: refer to git log instead of deprecated CHANGES file
+- code style: use space after semicolon
-- CURLOPT_*.3: more examples and edits
+- checksrc: verify space after semicolons
-- CURLOPT_*.3: added lots of small example sections
+- code style: use spaces around pluses
-- CURLOPT_PRIVATE.3: provide an example
+- checksrc: detect and warn for lack of spaces next to plus signs
-- CURLOPT_*TIMEOUT.3: provide examples
+- code style: use spaces around equals signs
-- CURLOPT_USERAGENT.3: added an example
+- checksrc: verify spaces around equals signs
+
+ ... as the code style mandates.
-- CURLOPT_STDERR.3: added an example
+- Curl_checkheaders: make it available for IMAP and SMTP too
+
+ ... not only HTTP uses this now.
+
+ Closes #1875
-- curl_easy_perform.3: remove superfluous close brace from example
+- travis: add build without HTTP/SMTP/IMAP
-- free: instead of Curl_safefree()
-
- Since we just started make use of free(NULL) in order to simplify code,
- this change takes it a step further and:
+Jay Satiro (10 Sep 2017)
+- mbedtls: enable CA path processing
- - converts lots of Curl_safefree() calls to good old free()
- - makes Curl_safefree() not check the pointer before free()
+ CA path processing was implemented when mbedtls.c was added to libcurl
+ in fe7590f, but it was never enabled.
- The (new) rule of thumb is: if you really want a function call that
- frees a pointer and then assigns it to NULL, then use Curl_safefree().
- But we will prefer just using free() from now on.
+ Bug: https://github.com/curl/curl/issues/1877
+ Reported-by: SBKarr@users.noreply.github.com
-- [Markus Elfring brought this change]
-
- Bug #149: Deletion of unnecessary checks before a few calls of cURL functions
+Daniel Stenberg (8 Sep 2017)
+- rtsp: do not call fwrite() with NULL pointer FILE *
- The following functions return immediately if a null pointer was passed.
- * Curl_cookie_cleanup
- * curl_formfree
+ If the default write callback is used and no destination has been set, a
+ NULL pointer would be passed to fwrite()'s 4th argument.
- It is therefore not needed that a function caller repeats a corresponding check.
+ OSS-fuzz bug https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3327
+ (not publicly open yet)
- This issue was fixed by using the software Coccinelle 1.0.0-rc24.
+ Detected by OSS-fuzz
+ Closes #1874
+
+- configure: use -Wno-varargs on clang 3.9[.X] debug builds
- Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
+ ... to avoid a clang bug
-- [Markus Elfring brought this change]
+- [Max Dymond brought this change]
- Bug #149: Deletion of unnecessary checks before calls of the function "free"
+ ossfuzz: add some more handled CURL options
- The function "free" is documented in the way that no action shall occur for
- a passed null pointer. It is therefore not needed that a function caller
- repeats a corresponding check.
- http://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first
+ Add support for HEADER, COOKIE, RANGE, CUSTOMREQUEST, MAIL_RECIPIENT,
+ MAIL_FROM and uploading data.
+
+- configure: check for C++ compiler after C, to make it non-fatal
- This issue was fixed by using the software Coccinelle 1.0.0-rc24.
+ The tests for object file/executable file extensions are presumably only
+ done for the first of these macros in the configure file.
- Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
-
-- [Jay Satiro brought this change]
+ Bug: https://github.com/curl/curl/pull/1851#issuecomment-327597515
+ Reported-by: Marcel Raad
+ Closes #1873
- connect: Fix happy eyeballs logic for IPv4-only builds
+Patrick Monnerat (7 Sep 2017)
+- form API: add new test 650.
- Bug: https://github.com/bagder/curl/pull/168
+ Now that the form API is deprecated and not used anymore in curl tool,
+ a lot of its features left untested. Test 650 attempts to check all these
+ features not tested elsewhere.
+
+Jay Satiro (7 Sep 2017)
+- configure: fix curl_off_t check's include order
- (trynextip)
- - Don't try the "other" protocol family unless IPv6 is available. In an
- IPv4-only build the other family can only be IPv6 which is unavailable.
+ - Prepend srcdir include path instead of append.
- This change essentially stops IPv4-only builds from attempting the
- "happy eyeballs" secondary parallel connection that is supposed to be
- used by the "other" address family.
+ Prior to this change it was possible that during the check for the size
+ of curl_off_t the include path of a user's already installed curl could
+ come before the include path of the to-be-built curl, resulting in the
+ system.h of the former being incorrectly included for that check.
- Prior to this change in IPv4-only builds that secondary parallel
- connection attempt could be erroneously used by the same family (IPv4)
- which caused a bug where every address after the first for a host could
- be tried twice, often in parallel. This change fixes that bug. An
- example of the bug is shown below.
+ Closes https://github.com/curl/curl/pull/1870
+
+Daniel Stenberg (7 Sep 2017)
+- [Jakub Zakrzewski brought this change]
+
+ KNOWN_BUGS: Remove CMake symbol hiding issue
- Assume MTEST resolves to 3 addresses 127.0.0.2, 127.0.0.3 and 127.0.0.4:
+ It has already been fixed in 6140dfc
+
+- http-proxy: when not doing CONNECT, that phase is done immediately
- * STATE: INIT => CONNECT handle 0x64f4b0; line 1046 (connection #-5000)
- * Rebuilt URL to: http://MTEST/
- * Added connection 0. The cache now contains 1 members
- * STATE: CONNECT => WAITRESOLVE handle 0x64f4b0; line 1083
- (connection #0)
- * Trying 127.0.0.2...
- * STATE: WAITRESOLVE => WAITCONNECT handle 0x64f4b0; line 1163
- (connection #0)
- * Trying 127.0.0.3...
- * connect to 127.0.0.2 port 80 failed: Connection refused
- * Trying 127.0.0.3...
- * connect to 127.0.0.3 port 80 failed: Connection refused
- * Trying 127.0.0.4...
- * connect to 127.0.0.3 port 80 failed: Connection refused
- * Trying 127.0.0.4...
- * connect to 127.0.0.4 port 80 failed: Connection refused
- * connect to 127.0.0.4 port 80 failed: Connection refused
- * Failed to connect to MTEST port 80: Connection refused
- * Closing connection 0
- * The cache now contains 0 members
- * Expire cleared
- curl: (7) Failed to connect to MTEST port 80: Connection refused
+ `conn->connect_state` is NULL when doing a regular non-CONNECT request
+ over the proxy and should therefor be considered complete at once.
- The bug was born in commit bagder/curl@2d435c7.
+ Fixes #1853
+ Closes #1862
+ Reported-by: Lawrence Wagerfield
-- mksymbolsmanpage.pl: use std header and generate better nroff header
+- [Johannes Schindelin brought this change]
-- [Frank Meier brought this change]
-
- closesocket: call multi socket cb on close even with custom close
+ OpenSSL: fix yet another mistake while encapsulating SSL backend data
- In function Curl_closesocket() in connect.c the call to
- Curl_multi_closed() was wrongly omitted if a socket close function
- (CURLOPT_CLOSESOCKETFUNCTION) is registered.
+ Another mistake in my manual fixups of the largely mechanical
+ search-and-replace ("connssl->" -> "BACKEND->"), just like the previous
+ commit concerning HTTPS proxies (and hence not caught during my
+ earlier testing).
- That would lead to not removing the socket from the internal hash table
- and not calling the multi socket callback appropriately.
+ Fixes #1855
+ Closes #1871
- Bug: http://curl.haxx.se/bug/view.cgi?id=1493
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Tobias Stoeckmann brought this change]
+- [Johannes Schindelin brought this change]
- hostip: Fix signal race in Curl_resolv_timeout.
+ OpenSSL: fix erroneous SSL backend encapsulation
+
+ In d65e6cc4f (vtls: prepare the SSL backends for encapsulated private
+ data, 2017-06-21), this developer prepared for a separation of the
+ private data of the SSL backends from the general connection data.
- A signal handler for SIGALRM is installed in Curl_resolv_timeout. It is
- configured to interrupt system calls and uses siglongjmp to return into
- the function if alarm() goes off.
+ This conversion was partially automated (search-and-replace) and
+ partially manual (e.g. proxy_ssl's backend data).
- The signal handler is installed before curl_jmpenv is initialized.
- This means that an already installed alarm timer could trigger the
- newly installed signal handler, leading to undefined behavior when it
- accesses the uninitialized curl_jmpenv.
+ Sadly, there was a crucial error in the manual part, where the wrong
+ handle was used: rather than connecting ssl[sockindex]' BIO to the
+ proxy_ssl[sockindex]', we reconnected proxy_ssl[sockindex]. The reason
+ was an incorrect location to paste "BACKEND->"... d'oh.
- Even if there is no previously installed alarm available, the code in
- Curl_resolv_timeout itself installs an alarm before the environment is
- fully set up. If the process is sent into suspend right after that, the
- signal handler could be called too early as in previous scenario.
+ Reported by Jay Satiro in https://github.com/curl/curl/issues/1855.
- To fix this, the signal handler should only be installed and the alarm
- timer only be set after sigsetjmp has been called.
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Jay Satiro brought this change]
-- http2: detect prematures close without data transfered
+ vtls: fix memory corruption
- ... by using the regular Curl_http_done() method which checks for
- that. This makes test 1801 fail consistently with error 56 (which seems
- fine) to that test is also updated here.
+ Ever since 70f1db321 (vtls: encapsulate SSL backend-specific data,
+ 2017-07-28), the code handling HTTPS proxies was broken because the
+ pointer to the SSL backend data was not swapped between
+ conn->ssl[sockindex] and conn->proxy_ssl[sockindex] as intended, but
+ instead set to NULL (causing segmentation faults).
- Reported-by: Ben Darnell
- Bug: https://github.com/bagder/curl/issues/166
-
-Dan Fandrich (13 Mar 2015)
-- test320: Expect the Host header to be the first header
+ [jes: provided the commit message, tested and verified the patch]
- Required for the test to work after a5d994941c2b.
-
-Daniel Stenberg (12 Mar 2015)
-- RELEASE-NOTES: synced with 186e46d88dd
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- openssl: use colons properly in the ciphers list
+- vtls: switch to CURL_SHA256_DIGEST_LENGTH define
- While the previous string worked, this is the documented format.
+ ... instead of the prefix-less version since WolfSSL 3.12 now uses an
+ enum with that name that causes build failures for us.
- Reported-by: Richard Moore
+ Fixes #1865
+ Closes #1867
+ Reported-by: Gisle Vanem
-- openssl: sort the ciphers on strength
-
- This makes curl pick better (stronger) ciphers by default. The strongest
- available ciphers are fine according to the HTTP/2 spec so an OpenSSL
- built curl is no longer rejected by string HTTP/2 servers.
+- travis: add c-ares enabled builds linux + osx
- Bug: http://curl.haxx.se/bug/view.cgi?id=1487
+ Closes #1868
-- [Fabian Keil brought this change]
+- HISTORY: added some recent items
- test203[0-3]: Expect the Host header to be the first header
-
- Required for the tests to work after a5d994941c2b.
+Jay Satiro (6 Sep 2017)
+- SSL: fix unused parameter warnings
-- openssl: show the cipher selection to use
+Patrick Monnerat (6 Sep 2017)
+- mime: drop internal FILE * support.
+
+ - The part kind MIMEKIND_FILE and associated code are suppressed.
+ - Seek data origin offset not used anymore: suppressed.
+ - MIMEKIND_NAMEDFILE renamed MIMEKIND_FILE; associated fields/functions
+ renamed accordingly.
+ - Curl_getformdata() processes stdin via a callback.
-- http: always send Host: header as first header
+Daniel Stenberg (6 Sep 2017)
+- configure: remove --enable-soname-bump and SONAME_BUMP
- ...after the method line:
+ Back in 2008, (and commit 3f3d6ebe665f3) we changed the logic in how we
+ determine the native type for `curl_off_t`. To really make sure we
+ didn't break ABI without bumping SONAME, we introduced logic that
+ attempted to detect that it would use a different size and thus not be
+ compatible. We also provided a manual switch that allowed users to tell
+ configure to bump SONAME by force.
- "Since the Host field-value is critical information for handling a
- request, a user agent SHOULD generate Host as the first header field
- following the request-line." / RFC 7230 section 5.4
+ Today, we know of no one who ever got a SONAME bump auto-detected and we
+ don't know of anyone who's using the manual bump feature. The auto-
+ detection is also no longer working since we introduced defining
+ curl_off_t in system.h (7.55.0).
- Additionally, this will also make libcurl ignore multiple specified
- custom Host: headers and only use the first one. Test 1121 has been
- updated accordingly
+ Finally, this bumping logic is not present in the cmake build.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1491
- Reported-by: Rainer Canavan
+ Closes #1861
-- [Alexander Pepper brought this change]
+Jay Satiro (6 Sep 2017)
+- [Gisle Vanem brought this change]
- mk-ca-bundle bugfix: Don't report SHA1 numbers with "-q".
+ vtls: select ssl backend case-insensitive (follow-up)
- Also unified printing to STDERR by creating the helper method "report".
-
-- proxy: re-use proxy connections (regression)
+ - Do a case-insensitive comparison of CURL_SSL_BACKEND env as well.
- When checking for a connection to re-use, a proxy-using request must
- check for and use a proxy connection and not one based on the host
- name!
+ - Change Curl_strcasecompare calls to strcasecompare
+ (maps to the former but shorter).
- Added test 1421 to verify
+ Follow-up to c290b8f.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1492
-
-- [Jay Satiro brought this change]
-
- memanalyze.pl: handle free(NULL)
-
-- [Jay Satiro brought this change]
+ Bug: https://github.com/curl/curl/commit/c290b8f#commitcomment-24094313
+
+ Co-authored-by: Jay Satiro
- .travis.yml: Change CI make test to make test-full
+- openssl: Integrate Peter Wu's SSLKEYLOGFILE implementation
+
+ This is an adaptation of 2 of Peter Wu's SSLKEYLOGFILE implementations.
+
+ The first one, written for old OpenSSL versions:
+ https://git.lekensteyn.nl/peter/wireshark-notes/tree/src/sslkeylog.c
+
+ The second one, written for BoringSSL and new OpenSSL versions:
+ https://github.com/curl/curl/pull/1346
+
+ Note the first one is GPL licensed but the author gave permission to
+ waive that license for libcurl.
+
+ As of right now this feature is disabled by default, and does not have
+ a configure option to enable it. To enable this feature define
+ ENABLE_SSLKEYLOGFILE when building libcurl and set environment
+ variable SSLKEYLOGFILE to a pathname that will receive the keys.
+
+ And in Wireshark change your preferences to point to that key file:
+ Edit > Preferences > Protocols > SSL > Master-Secret
- - Change the continuous integration script to use 'make test-full'
- instead of just 'make test' so that the diagnostic log output is
- printed to stdout when a test fails.
+ Co-authored-by: Peter Wu
- - Change the continuous integration script to use
- './configure --enable-debug' instead of just './configure' so that the
- memory analyzer will work during testing.
+ Ref: https://github.com/curl/curl/pull/1030
+ Ref: https://github.com/curl/curl/pull/1346
- Prior to this change Travis used its default C test script:
- ./configure && make && make test
+ Closes https://github.com/curl/curl/pull/1866
-- [Alessandro Ghedini brought this change]
+Patrick Monnerat (5 Sep 2017)
+- mime: fix a trivial warning.
- gtls: correctly align certificate status verification messages
+- mime: replace 'struct Curl_mimepart' by 'curl_mimepart' in encoder code.
+
+ mime_state is now a typedef.
-- [Alessandro Ghedini brought this change]
+- mime: implement encoders.
+
+ curl_mime_encoder() is operational and documented.
+ curl tool -F option is extended with ";encoder=".
+ curl tool --libcurl option generates calls to curl_mime_encoder().
+ New encoder tests 648 & 649.
+ Test 1404 extended with an encoder specification.
- gtls: don't print double newline after certificate dates
+- runtests.pl: support attribute "nonewline" in part verify/upload.
-- [Alessandro Ghedini brought this change]
+- [Daniel Stenberg brought this change]
+
+ fixup data/test1135
- gtls: print negotiated TLS version and full cipher suite name
+- [Daniel Stenberg brought this change]
+
+ mime: unified to use the typedef'd mime structs everywhere
- Instead of priting cipher and MAC algorithms names separately, print the
- whole cipher suite string which also includes the key exchange algorithm,
- along with the negotiated TLS version.
+ ... and slightly edited to follow our code style better.
-- gtls: fix compiler warnings
+- [Daniel Stenberg brought this change]
-- [Alessandro Ghedini brought this change]
+ curl.h: use lower case curl_mime* as for all public symbols
- gtls: add support for CURLOPT_CAPATH
+- [Daniel Stenberg brought this change]
-- [stopiccot brought this change]
+ docs/curl_mime_*.3: use correct variable types in examples
- MacOSX-Framework: use @rpath instead of @executable_path
+Kamil Dudka (5 Sep 2017)
+- openssl: use OpenSSL's default ciphers by default
- Bug: https://github.com/bagder/curl/pull/157
+ Up2date versions of OpenSSL maintain the default reasonably secure
+ without breaking compatibility, so it is better not to override the
+ default by curl. Suggested at https://bugzilla.redhat.com/1483972
+
+ Closes #1846
+
+Viktor Szakats (5 Sep 2017)
+- examples/mime: minor example code fixes
-- RELEASE-NOTES: synced with c19349951
+Daniel Stenberg (5 Sep 2017)
+- docs/curl_mime_*.3: added examples
-- multi: fix *getsock() with CONNECT
+- configure: add MultiSSL to FEATURES when enabled
- The code used some happy eyeballs logic even _after_ CONNECT has been
- sent to a proxy, while the happy eyeball phase is already (should be)
- over by then.
+ ...for curl-config and its corresponding test 1014
+
+- http-proxy: treat all 2xx as CONNECT success
- This is solved by splitting the multi state into two separate states
- introducing the new SENDPROTOCONNECT state.
+ Added test 1904 to verify.
- Bug: http://curl.haxx.se/mail/lib-2015-01/0170.html
- Reported-by: Peter Laser
+ Reported-by: Lawrence Wagerfield
+ Fixes #1859
+ Closes #1860
-- conncontrol: only log changes to the connection bit
+- MAIL-ETIQUETTE: added "1.9 Your emails are public"
-- http2: use CURL_HTTP_VERSION_* symbols instead of NPN_*
+- curl.h: fix "unused checksrc ignore", remove dangling reference
- Since they already exist and will make comparing easier
-
-- http2: make the info-message about receiving HTTP2 headers debug-only
+ ... to a README file that doesn't exist anymore
-- [Alessandro Ghedini brought this change]
+Viktor Szakats (4 Sep 2017)
+- docs: Update to secure URL versions
- urldata: remove unused asked_for_h2 field
+- mime: use CURL_ZERO_TERMINATED in examples
+
+ and some minor whitespace fixes
-- [Alessandro Ghedini brought this change]
+Daniel Stenberg (4 Sep 2017)
+- schannel: return CURLE_SSL_CACERT on failed verification
+
+ ... not *CACERT_BADFILE as it isn't really because of a bad file.
+
+ Bug: https://curl.haxx.se/mail/lib-2017-09/0002.html
+ Closes #1858
- polarssl: make it possible to enable ALPN/NPN without HTTP2
+- test1135: fixed after bd8070085f9
-- [Alessandro Ghedini brought this change]
+- examples/post-callback: stop returning one byte at a time
+
+ ... since people copy and paste code from this example and thus they get
+ an inefficient POST operation without a good reason and sometimes
+ without understanding why.
+
+ Instead this now returns as much data as possible.
- nss: make it possible to enable ALPN/NPN without HTTP2
+- RELEASE-NOTES: fixed the function counter script
-- [Alessandro Ghedini brought this change]
+- curl.h: make the curl_strequal() protos use the same style
+
+ ... as the other functions. Makes it easier to machine-parse!
- gtls: make it possible to enable ALPN/NPN without HTTP2
+- docs: curl_mime_*.3 man page formatting edits
-- [Alessandro Ghedini brought this change]
+- RELEASE-NOTES: synced with 1ab9e9b50
- openssl: make it possible to enable ALPN/NPN without HTTP2
+Patrick Monnerat (4 Sep 2017)
+- lib: bump version info (soname). Adapt and reenable test 1135.
-- metalink: add some error checks
-
- malloc() and strdup() calls without checking return codes.
+Daniel Stenberg (3 Sep 2017)
+- headers: move the global_sslset() proto from multi.h to curl.h
- Reported-by: Markus Elfring
- Bug: https://github.com/bagder/curl/issues/150
+ As it was added to multi.h simply to not break test 1135, which now has
+ been disabled due to the mime API addition anyway and su we can now move
+ the sslset stuff to where the other curl_global_* prototypes are.
-- curl_easy_setopt.3: added CURLOPT_SSL_VERIFYSTATUS
+Patrick Monnerat (3 Sep 2017)
+- mime: fix signed/unsigned conversions.
- Reported-by: Jonathan Cardoso
+ Use and generate CURL_ZERO_TERMINATED in curl tool and tests.
-- urldata: fix gnutls build
+Jay Satiro (3 Sep 2017)
+- tool_formparse: fix some trivial warnings
-Steve Holme (5 Mar 2015)
-- openssl: Removed use of USE_SSLEAY from the Visual Studio project files
+Patrick Monnerat (3 Sep 2017)
+- mime: use size_t instead of ssize_t in public API interface.
- In addition to commit 709cf76f6b, removed the USE_SSLEAY preprocessor
- variable from the Visual Studio project files as it isn't required
- anymore.
-
-Daniel Stenberg (5 Mar 2015)
-- multi: fix memory-leak on timeout (regression)
+ To support telling a string is nul-terminated, symbol CURL_ZERO_TERMINATED
+ has been introduced.
- Since 1342a96ecfe0d44, a timeout detected in the multi state machine didn't
- necesarily clear everything up, like formpost data.
+ Documentation updated accordingly.
- Bug: https://github.com/bagder/curl/issues/147
- Reported-by: Michel Promonet
- Patched-by: Michel Promonet
+ symbols in versions updated. Added form API symbols deprecation info.
-- configure: follow-up fix from 709cf76f6
+- mime: remove support "-" stdin pseudo-file name in curl_mime_filedata().
- OpenSSL handling was a little broken.
-
-- openssl: remove all uses of USE_SSLEAY
+ This feature is badly supported in Windows: as a replacement, a caller has
+ to use curl_mime_data_cb() with fread, fseek and possibly fclose
+ callbacks to process opened files.
- SSLeay was the name of the library that was subsequently turned into
- OpenSSL many moons ago (1999). curl does not work with the old SSLeay
- library since years. This is now reflected by only using USE_OPENSSL in
- code that depends on OpenSSL.
-
-- [Sergei Nikulov brought this change]
-
- cmake: handle build definitions CURLDEBUG/DEBUGBUILD
+ The cli tool and documentation are updated accordingly.
- Acked-by: Brad King
+ The feature is however kept internally for form API compatibility, with
+ the known caveats it always had.
+
+ As a side effect, stdin size is not determined by the cli tool even if
+ possible and this results in a chunked transfer encoding. Test 173 is
+ updated accordingly.
-- FAQ: 4.21 Why is there a HTTP/1.1 in my HTTP/2 request?
+- mime: fix some implicit curl_off_t --> size_t conversion warnings.
-- symbols.pl: handle '-' in the deprecated field
-
- ... which otherwise made the script skip the _LAST define for some
- symbols.
+- mime: tests and examples.
- Reported-by: Jeroen Ooms
- Bug: http://curl.haxx.se/mail/lib-2015-03/0052.html
+ Additional mime-specific tests.
+ Existing tests updated to reflect small differences (Expect: 100-continue,
+ data size change due to empty lines, etc).
+ Option -F headers= keyword added to tests.
+ test1135 disabled until the entry point order change is resolved.
+ New example smtp-mime.
+ Examples postit2 and multi-post converted from form API to mime API.
-- curl.1: fix "The the" typo
+- mime: use in curl cli tool instead of form API.
- Reported-by: Jon Seymour
+ Extended -F option syntax to support multipart mail messages.
+ -F keyword headers= added to include custom headers in parts.
+ Documentation upgraded.
-- vtls: use curl_printf.h all over
+- mime: new MIME API.
- No need to use _MPRINTF_REPLACE internally.
-
-- tool: use ENABLE_CURLX_PRINTF instead of _MPRINTF_REPLACE
+ Available in HTTP, SMTP and IMAP.
+ Deprecates the FORM API.
+ See CURLOPT_MIMEPOST.
+ Lib code and associated documentation.
-- tool_writeenv: remove _MPRINTF_REPLACE define, it wasn't used
+- test564: Add a warning comment about shell profile output.
+
+ Shell profile output makes the SSH server failing and this problem reason
+ is not easy to find when no hint is given.
-- [Sergei Nikulov brought this change]
+- checksrc: disable SPACEBEFOREPAREN for case statement.
+
+ The case keyword may be followed by a constant expression and thus should
+ allow it to start with an open parenthesis.
- libtest: fixed linker errors on msvc
+- runtests.pl: allow <file[1-4]> tags in client section.
- Bug: https://github.com/bagder/curl/pull/144
+ This enables tests to create more than one file on the client side.
-- mprintf.h: remove #ifdef CURLDEBUG
+- runtests.pl: Apply strippart to upload too.
- ... and as a consequence, introduce curl_printf.h with that re-define
- magic instead and make all libcurl code use that instead.
+ This will allow substitution of boundaries in mail messages.
-- tool_getpass: remove unused curl/mprintf.h include
+- Curl_base64_encode: always call with a real data handle.
+
+ Some calls in different modules were setting the data handle to NULL, causing
+ segmentation faults when using builds that enable character code conversions.
-- CONTRIBUTING.md: file for advice on github
+- non-ascii: allow conversion functions to be called with a NULL data handle.
-- [Viktor Szakáts brought this change]
+- http: fix a memory leakage in checkrtspprefix().
- BINDINGS: add link to Harbour bindings
-
- And UTF8-fix a few names
+Daniel Stenberg (2 Sep 2017)
+- [Max Dymond brought this change]
-- CURLOPT_HEADERFUNCTION.3: typo in error code name
+ ossfuzz: Move to C++ for curl_fuzzer.
- Reported-by: Jonathan Cardoso
+ Automake gets confused if you want to use C++ static libraries with C
+ code - basically we need to involve the clang++ linker. The easiest way
+ of achieving this is to rename the C code as C++ code. This gets us a
+ bit further along the path and ought to be compatible with Google's
+ version of clang.
-- BINDINGS: tclcurl moved
+- curl_global_sslset: select backend by name case insensitively
- Reporte-by: Steve Havelka
+ Closes #1849
-- [Jay Satiro brought this change]
+- [Max Dymond brought this change]
- opts: Fix pipelining examples
+ ossfuzz: additional seed corpora
+
+ Create simple seed corpora for:
+ - FTP
+ - telnet
+ - dict
+ - tftp
+ - imap
+ - pop3
+
+ based off the tests of the same number.
+
+ Closes #1842
-- [Jay Satiro brought this change]
+- [Max Dymond brought this change]
- curl_multi_setopt.3: Link to CURLMOPT_MAXCONNECTS
+ ossfuzz: moving towards the ideal integration
+
+ - Start with the basic code from the ossfuzz project.
+ - Rewrite fuzz corpora to be binary files full of Type-Length-Value
+ data, and write a glue layer in the fuzzing function to convert
+ corpora into CURL options.
+ - Have supporting functions to generate corpora from existing tests
+ - Integrate with Makefile.am
-- CONTRIBUTE: the new more github-friendly attitude!
+- strcase: corrected comment header for Curl_strcasecompare()
-Steve Holme (28 Feb 2015)
-- RELEASE-NOTES: Synced with 921d195187
+- unit1301: fix error message on first test
-Kamil Dudka (28 Feb 2015)
-- tool: wrap lines longer than 79 columns
+- curl_global_sslset.3: show the struct and enum too
- ... to avoid a build failure when configured with --enable-debug
-
-Steve Holme (27 Feb 2015)
-- [Tatsuhiro Tsujikawa brought this change]
+ ... so that users can actually write code based on the man page alone,
+ not having to read the header file.
- http2: Return error if stream was closed with other than NO_ERROR
+Jay Satiro (31 Aug 2017)
+- darwinssl: handle long strings in TLS certs (follow-up)
- Previously, we just ignored error code passed to
- on_stream_close_callback and just return 0 (success) after stream
- closure even if stream was reset with error. This patch records error
- code in on_stream_close_callback, and return -1 and use CURLE_HTTP2
- error code on abnormal stream closure.
-
-- tool: Updated the warnf() function to use the GlobalConfig structure
+ - Fix handling certificate subjects that are already UTF-8 encoded.
- As the 'error' and 'mute' options are now part of the GlobalConfig,
- rather than per Operation, updated the warnf() function to use this
- structure rather than the OperationConfig.
-
-- build: Removed DataExecutionPrevention directive from VC9+ project files
+ Follow-up to b3b75d1 from two days ago. Since then a copy would be
+ skipped if the subject was already UTF-8, possibly resulting in a NULL
+ deref later on.
- Removed the DataExecutionPrevention directive from the project files for
- Visual Studio 2008 and above. The XML value in the VC9 project files was
- set to "0" (Default) whilst the VC10+ project files contained an empty
- XML element.
+ Ref: https://github.com/curl/curl/issues/1823
+ Ref: https://github.com/curl/curl/pull/1831
+
+ Closes https://github.com/curl/curl/pull/1836
-- build: Use default RandomizedBaseAddress directive in VC9+ project files
+Daniel Stenberg (31 Aug 2017)
+- cyassl: call it the "WolfSSL" backend
- Visual Studio 2008 introduced support for the address space layout
- randomization (ASLR) feature of Windows Vista. However, upgrading the
- VC8 project files to VC9 and above disabled this feature.
+ ... instead of cyassl, as this is the current name for it.
- Removed the RandomizedBaseAddress directive to enabled the default
- setting (/DYNAMICBASE). Note: This doesn't appear to have any negative
- impact when compiled and ran on Windows XP.
+ Closes #1844
-- build: Added support to Generate.bat for files in the upcoming vauth folder
+- polarssl: fix multissl breakage
+
+ Reported-by: Dan Fandrich
+ Bug: https://curl.haxx.se/mail/lib-2017-08/0121.html
+ Closes #1843
-Daniel Stenberg (25 Feb 2015)
-- http2: return recv error on unexpected EOF
+- configure: remove the leading comma from the backends list
+
+ ... when darwinssl is used.
- Pointed-out-by: Tatsuhiro Tsujikawa
- Bug: http://curl.haxx.se/bug/view.cgi?id=1487
+ Reported-by: Viktor Szakats
+ Bug: https://github.com/curl/curl/commit/b0989cd3abaff4f9a0717b4875022fa79e33b481#commitcomment-23943493
+
+ Closes #1845
-Kamil Dudka (25 Feb 2015)
-- dist: add symbol-scan.pl to the tarball
+Kamil Dudka (30 Aug 2017)
+- examples/sslbackend.c: fix failure of 'make checksrc'
- ... in order to make test1135 succeed
+ ./sslbackend.c:58:3: warning: else after closing brace on same line (BRACEELSE)
+ } else if(isdigit(*name)) {
+ ^
+ ./sslbackend.c:62:3: warning: else after closing brace on same line (BRACEELSE)
+ } else
+ ^
-Daniel Stenberg (25 Feb 2015)
-- http2: move lots of verbose output to be debug-only
+Viktor Szakats (30 Aug 2017)
+- makefile.m32: add multissl support
+
+ Closes https://github.com/curl/curl/pull/1840
-Kamil Dudka (25 Feb 2015)
-- curl-config.in: eliminate double quotes around CURL_CA_BUNDLE
+Daniel Stenberg (30 Aug 2017)
+- curl.h: CURLSSLBACKEND_WOLFSSL used wrong value
+
+ The CURLSSLBACKEND_WOLFSSL is supposed to be an alias for
+ CURLSSLBACKEND_CYASSL, but used an erronous value. To reduce the risk
+ for a similar mistake, define the backend aliases to use the enum values
+ instead.
- Otherwise it expands to:
+ Reported-by: Gisle Vanem
+ Bug: https://curl.haxx.se/mail/lib-2017-08/0120.html
+
+- curl_global_sslset.3: clarify
- echo ""/etc/pki/tls/certs/ca-bundle.crt""
+ it is a one time *set*, not necessarily a one time use... it can be
+ called again if the first call failed or just listed the alternatives.
- Detected by ShellCheck:
+ clarify that the available backends are the ones this build supports
- curl-config:74:16: warning: The double quotes around this do
- nothing. Remove or escape them. [SC2140]
-
-- nss: do not skip Curl_nss_seed() if data is NULL
+ plus add some formatting
- In that case, we only skip writing the error message for failed NSS
- initialization (while still returning the correct error code).
+ Reported-by: Rich Gray
+ Bug: https://curl.haxx.se/mail/lib-2017-08/0119.html
-- nss: improve error handling in Curl_nss_random()
+- curl/multi.h: remove duplicated closing c++ brace
- The vtls layer now checks the return value, so it is no longer necessary
- to abort if a random number cannot be provided by NSS. This also fixes
- the following Coverity report:
+ Regression since 1328f69d53f2f2e93
- Error: FORWARD_NULL (CWE-476):
- lib/vtls/nss.c:1918: var_compare_op: Comparing "data" to null implies that "data" might be null.
- lib/vtls/nss.c:1923: var_deref_model: Passing null pointer "data" to "Curl_failf", which dereferences it.
- lib/sendf.c:154:3: deref_parm: Directly dereferencing parameter "data".
+ Fixes #1841
+ Reported-by: Andrei Karas
-Daniel Stenberg (25 Feb 2015)
-- RELEASE-PROCEDURE: add some more future release dates
-
- ... and remove some old ones
+- RELEASE-NOTES: synced with 8c33c963a
-- sws: timeout idle CONNECT connections
+- HELP-US.md: spelling
-- bump: start working toward 7.42.0
+- HELP-US.md: "How to get started helping out in the curl project"
+
+ Closes #1837
-Version 7.41.0 (25 Feb 2015)
+Dan Fandrich (29 Aug 2017)
+- asyn-thread: Fixed cleanup after OOM
+
+ destroy_async_data() assumes that if the flag "done" is not set yet, the
+ thread itself will clean up once the request is complete. But if an
+ error (generally OOM) occurs before the thread even has a chance to
+ start, it will never get a chance to clean up and memory will be leaked.
+ By clearing "done" only just before starting the thread, the correct
+ cleanup sequence will happen in all cases.
-Daniel Stenberg (25 Feb 2015)
-- THANKS: added contributors from the 7.41.0 RELEASE-NOTES
+Daniel Stenberg (28 Aug 2017)
+- curl_global_init.3: mention curl_global_sslset(3)
-- RELEASE-NOTES: sync with ffc2aeec6e (7.41.0 release time!)
+Dan Fandrich (28 Aug 2017)
+- unit1606: Fixed shadowed variable warning
-Marc Hoersken (25 Feb 2015)
-- Revert "telnet.c: fix handling of 0 being returned from custom read function"
-
- This reverts commit 03fa576833643c67579ae216c4e7350fa9b5f2fe.
+- asyn-thread: Improved cleanup after OOM situations
-- telnet.c: fix invalid use of custom read function if not being set
+- asyn-thread: Set errno to the proper value ENOMEM in OOM situation
- obj_count can be 1 if the custom read function is set or the stdin
- handle is a reference to a pipe. Since the pipe should be handled
- using the PeekNamedPipe-check below, the custom read function should
- only be used if it is actually enabled.
+ This used to be set in some configurations to EAI_MEMORY which is not a
+ valid value for errno and caused Curl_strerror to fail an assertion.
-- telnet.c: fix handling of 0 being returned from custom read function
+Daniel Stenberg (28 Aug 2017)
+- [Johannes Schindelin brought this change]
+
+ configure: Handle "MultiSSL" specially When versioning symbols
+
+ There is a mode in which libcurl is compiled with versioned symbols,
+ depending on the active SSL backend.
- According to [1]: "Returning 0 will signal end-of-file to the library
- and cause it to stop the current transfer."
- This change makes the Windows telnet code handle this case accordingly.
+ When multiple SSL backends are active, it does not make sense to favor
+ one over the others, so let's not: introduce a new prefix for the case
+ where multiple SSL backends are compiled into cURL.
- [1] http://curl.haxx.se/libcurl/c/CURLOPT_READFUNCTION.html
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-Daniel Stenberg (24 Feb 2015)
-- sws: stop logging about TPC_NODELAY nonsense
+- [Johannes Schindelin brought this change]
-- lib530: make it less timing sensible
+ configure: allow setting the default SSL backend
- ... by making sure the first request is completed before doing the
- remainder.
-
-Kamil Dudka (23 Feb 2015)
-- connect: wait for IPv4 connection attempts
+ Previously, we used as default SSL backend whatever was first in the
+ `available_backends` array.
+
+ However, some users may want to override that default without patching
+ the source code.
- ... even if the last IPv6 connection attempt has failed.
+ Now they can: with the --with-default-ssl-backend=<backend> option of
+ the ./configure script.
- Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1187531#c4
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- connect: avoid skipping an IPv4 address
+- [Johannes Schindelin brought this change]
+
+ vtls: use Curl_ssl_multi pseudo backend only when needed
- ... in case the protocol versions are mixed in a DNS response
- (IPv6 -> IPv4 -> IPv6).
+ When only one SSL backend is configured, it is totally unnecessary to
+ let multissl_init() configure the backend at runtime, we can select the
+ correct backend at build time already.
- Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1187531#c3
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-Daniel Stenberg (23 Feb 2015)
-- RELEASE-NOTES: synced with 5e4395eab839d
+- [Johannes Schindelin brought this change]
-- ROADMAP: curl_easy_setopt.3 has already been split up
+ version: if built with more than one SSL backend, report all of them
- Remove cmake as marked for removal. It is in much better state now.
-
-- ROADMAP: extend the HTTP/2 stuff, remove SPDY
+ To discern the active one from the inactive ones, put the latter into
+ parentheses.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Julian Ospald brought this change]
+- [Johannes Schindelin brought this change]
- configure: allow both --with-ca-bundle and --with-ca-path
-
- SSL_CTX_load_verify_locations by default (and if given non-Null
- parameters) searches the CAfile first and falls back to CApath. This
- allows for CAfile to be a basis (e.g. installed by the package manager)
- and CApath to be a user configured directory.
+ version: add the CURL_VERSION_MULTI_SSL feature flag
- This wasn't reflected by the previous configure constraint which this
- patch fixes.
+ This new feature flag reports When cURL was built with multiple SSL
+ backends.
- Bug: https://github.com/bagder/curl/pull/139
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Ben Boeckel brought this change]
+- [Johannes Schindelin brought this change]
- cmake: install the dll file to the correct directory
+ metalink: allow compiling with multiple SSL backends
+
+ Previously, the code assumed that at most one of the SSL backends would
+ be compiled in, emulating OpenSSL's functions if the configured backend
+ was not OpenSSL itself.
+
+ However, now we allow building with multiple SSL backends and choosing
+ one at runtime. Therefore, metalink needs to be adjusted to handle this
+ scenario, too.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Alessandro Ghedini brought this change]
+- [Johannes Schindelin brought this change]
- nss: fix NPN/ALPN protocol negotiation
+ docs/examples: demonstrate how to select SSL backends
- Correctly check for memcmp() return value (it returns 0 if the strings match).
+ The newly-introduced curl_global_sslset() function deserves to be
+ show-cased.
- This is not really important, since curl is going to use http/1.1 anyway, but
- it's still a bug I guess.
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Alessandro Ghedini brought this change]
+- [Johannes Schindelin brought this change]
- polarssl: fix ALPN protocol negotiation
+ Add a man page for curl_global_sslset()
- Correctly check for strncmp() return value (it returns 0 if the strings
- match).
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Sergei Nikulov brought this change]
+- [Johannes Schindelin brought this change]
- CMake: Fix generation of tool_hugehelp.c on windows
+ vtls: introduce curl_global_sslset()
- Use "cmake -E echo" instead of "echo".
+ Let's add a compile time safe API to select an SSL backend. This
+ function needs to be called *before* curl_global_init(), and can be
+ called only once.
- Reviewed-by: Brad King <brad.king@kitware.com>
-
-- [Sergei Nikulov brought this change]
+ Side note: we do not explicitly test that it is called before
+ curl_global_init(), but we do verify that it is not called multiple times
+ (even implicitly).
+
+ If SSL is used before the function was called, it will use whatever the
+ CURL_SSL_BACKEND environment variable says (or default to the first
+ available SSL backend), and if a subsequent call to
+ curl_global_sslset() disagrees with the previous choice, it will fail
+ with CURLSSLSET_TOO_LATE.
+
+ The function also accepts an "avail" parameter to point to a (read-only)
+ NULL-terminated list of available backends. This comes in real handy if
+ an application wants to let the user choose between whatever SSL backends
+ the currently available libcurl has to offer: simply call
+
+ curl_global_sslset(-1, NULL, &avail);
+
+ which will return CURLSSLSET_UNKNOWN_BACKEND and populate the avail
+ variable to point to the relevant information to present to the user.
+
+ Just like with the HTTP/2 push functions, we have to add the function
+ declaration of curl_global_sslset() function to the header file
+ *multi.h* because VMS and OS/400 require a stable order of functions
+ declared in include/curl/*.h (where the header files are sorted
+ alphabetically). This looks a bit funny, but it cannot be helped.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
- CMake: fix winsock2 detection on windows
+- [Johannes Schindelin brought this change]
+
+ vtls: refactor out essential information about the SSL backends
+
+ There is information about the compiled-in SSL backends that is really
+ no concern of any code other than the SSL backend itself, such as which
+ function (if any) implements SHA-256 summing.
- Set CMAKE_REQUIRED_DEFINITIONS to include definitions needed to get
- the winsock2 API from windows.h. Simplify the order of checks to
- avoid extra conditions.
+ And there is information that is really interesting to the user, such as
+ the name, or the curl_sslbackend value.
- Use check_include_file instead of check_include_file_concat to look
- for OpenSSL headers. They do not need to participate in a sequence
- of dependent system headers. Also they may cause winsock.h to be
- included before ws2tcpip.h, causing the latter to not be detected
- in the sequence.
+ Let's factor out the latter into a publicly visible struct. This
+ information will be used in the upcoming API to set the SSL backend
+ globally.
- Reviewed-by: Brad King <brad.king@kitware.com>
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Alessandro Ghedini brought this change]
+- [Johannes Schindelin brought this change]
- gtls: fix build with HTTP2
+ vtls: allow selecting which SSL backend to use at runtime
+
+ When building software for the masses, it is sometimes not possible to
+ decide for all users which SSL backend is appropriate.
+
+ Git for Windows, for example, uses cURL to perform clones, fetches and
+ pushes via HTTPS, and some users strongly prefer OpenSSL, while other
+ users really need to use Secure Channel because it offers
+ enterprise-ready tools to manage credentials via Windows' Credential
+ Store.
+
+ The current Git for Windows versions use the ugly work-around of
+ building libcurl once with OpenSSL support and once with Secure Channel
+ support, and switching out the binaries in the installer depending on
+ the user's choice.
+
+ Needless to say, this is a super ugly workaround that actually only
+ works in some cases: Git for Windows also comes in a portable form, and
+ in a form intended for third-party applications requiring Git
+ functionality, in which cases this "swap out libcurl-4.dll" simply is
+ not an option.
+
+ Therefore, the Git for Windows project has a vested interest in teaching
+ cURL to make the SSL backend a *runtime* option.
+
+ This patch makes that possible.
+
+ By running ./configure with multiple --with-<backend> options, cURL will
+ be built with multiple backends.
+
+ For the moment, the backend can be configured using the environment
+ variable CURL_SSL_BACKEND (valid values are e.g. "openssl" and
+ "schannel").
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-Steve Holme (16 Feb 2015)
-- Makefile.vc6: Corrected typos in rename of darwinssl.obj
+- [Johannes Schindelin brought this change]
-Nick Zitzmann (15 Feb 2015)
-- By request, change the name of "curl_darwinssl.[ch]" to "darwinssl.[ch]"
+ vtls: fold the backend ID into the Curl_ssl structure
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-Steve Holme (14 Feb 2015)
-- RELEASE-NOTES: Synced with 6f89f86c3d
+- [Johannes Schindelin brought this change]
-- tests/README: Updated to reflect email test ranges
+ curl_ntlm_core: don't complain but #include OpenSSL header if needed
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Alessandro Ghedini brought this change]
+- [Johannes Schindelin brought this change]
- curl.1: --cert-status is also supported by OpenSSL now
+ vtls: encapsulate SSL backend-specific data
+
+ So far, all of the SSL backends' private data has been declared as
+ part of the ssl_connect_data struct, in one big #if .. #elif .. #endif
+ block.
+
+ This can only work as long as the SSL backend is a compile-time option,
+ something we want to change in the next commits.
+
+ Therefore, let's encapsulate the exact data needed by each SSL backend
+ into a private struct, and let's avoid bleeding any SSL backend-specific
+ information into urldata.h. This is also necessary to allow multiple SSL
+ backends to be compiled in at the same time, as e.g. OpenSSL's and
+ CyaSSL's headers cannot be included in the same .c file.
+
+ To avoid too many malloc() calls, we simply append the private structs
+ to the connectdata struct in allocate_conn().
+
+ This requires us to take extra care of alignment issues: struct fields
+ often need to be aligned on certain boundaries e.g. 32-bit values need to
+ be stored at addresses that divide evenly by 4 (= 32 bit / 8
+ bit-per-byte).
+
+ We do that by assuming that no SSL backend's private data contains any
+ fields that need to be aligned on boundaries larger than `long long`
+ (typically 64-bit) would need. Under this assumption, we simply add a
+ dummy field of type `long long` to the `struct connectdata` struct. This
+ field will never be accessed but acts as a placeholder for the four
+ instances of ssl_backend_data instead. the size of each ssl_backend_data
+ struct is stored in the SSL backend-specific metadata, to allow
+ allocate_conn() to know how much extra space to allocate, and how to
+ initialize the ssl[sockindex]->backend and proxy_ssl[sockindex]->backend
+ pointers.
+
+ This would appear to be a little complicated at first, but is really
+ necessary to encapsulate the private data of each SSL backend correctly.
+ And we need to encapsulate thusly if we ever want to allow selecting
+ CyaSSL and OpenSSL at runtime, as their headers cannot be included within
+ the same .c file (there are just too many conflicting definitions and
+ declarations for that).
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
-- build: Removed Visual Studio SuppressStartupBanner directive for VC8+
+ vtls: prepare the SSL backends for encapsulated private data
- Visual Studio 2005 and above defaults to disabling the startup banner
- for the Compiler, Linker and MIDL tools (with /NOLOGO). As such there
- is no need to explicitly set the SuppressStartupBanner directive, as
- this is a leftover from the VC7 and VC7.1 projects being upgraded to
- VC8 and above.
+ At the moment, cURL's SSL backend needs to be configured at build time.
+ As such, it is totally okay for them to hard-code their backend-specific
+ data in the ssl_connect_data struct.
+
+ In preparation for making the SSL backend a runtime option, let's make
+ the access of said private data a bit more abstract so that it can be
+ adjusted later in an easy manner.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
-Kamil Dudka (12 Feb 2015)
-- openssl: fix a compile-time warning
+ urldata.h: move SSPI-specific #include to correct location
+
+ In 86b889485 (sasl_gssapi: Added GSS-API based Kerberos V5 variables,
+ 2014-12-03), an SSPI-specific field was added to the kerberos5data
+ struct without moving the #include "curl_sspi.h" later in the same file.
+
+ This broke the build when SSPI was enabled, unless Secure Channel was
+ used as SSL backend, because it just so happens that Secure Channel also
+ requires "curl_sspi.h" to be #included.
+
+ In f4739f639 (urldata: include curl_sspi.h when Windows SSPI is enabled,
+ 2017-02-21), this bug was fixed incorrectly: Instead of moving the
+ appropriate conditional #include, the Secure Channel-conditional part
+ was now also SSPI-conditional.
- lib/vtls/openssl.c:1450:7: warning: extra tokens at end of #endif directive
+ Fix this problem by moving the correct #include instead.
+
+ This is also required for an upcoming patch that moves all the Secure
+ Channel-specific stuff out of urldata.h and encapsulates it properly in
+ vtls/schannel.c instead.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
-Steve Holme (11 Feb 2015)
-- openssl: Use OPENSSL_IS_BORINGSSL for BoringSSL detection
+ urldata.h: remove support for obsolete PolarSSL version
- For consistency with other conditionally compiled code in openssl.c,
- use OPENSSL_IS_BORINGSSL rather than HAVE_BORINGSSL and try to use
- HAVE_BORINGSSL outside of openssl.c when the OpenSSL header files are
- not included.
+ Since 5017d5ada (polarssl: now require 1.3.0+, 2014-03-17), we require
+ a newer PolarSSL version. No need to keep code trying to support any
+ older version.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-Patrick Monnerat (11 Feb 2015)
-- ftp: accept all 2xx responses to the PORT command
+- [Johannes Schindelin brought this change]
-Steve Holme (9 Feb 2015)
-- openssl: Disable OCSP in old versions of OpenSSL
+ getinfo: access SSL internals via Curl_ssl
+
+ In the ongoing endeavor to abstract out all SSL backend-specific
+ functionality, this is the next step: Instead of hard-coding how the
+ different SSL backends access their internal data in getinfo.c, let's
+ implement backend-specific functions to do that task.
+
+ This will also allow for switching SSL backends as a runtime option.
- Versions of OpenSSL prior to v0.9.8h do not support the necessary
- functions for OCSP stapling.
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-Daniel Stenberg (9 Feb 2015)
-- [Tatsuhiro Tsujikawa brought this change]
+- [Johannes Schindelin brought this change]
- http2: Fix bug that associated stream canceled on PUSH_PROMISE
+ vtls: move SSL backends' private constants out of their header files
- Previously we don't ignore PUSH_PROMISE header fields in on_header
- callback. It makes header values mixed with following HEADERS,
- resulting protocol error.
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- [Jay Satiro brought this change]
+- [Johannes Schindelin brought this change]
+
+ axtls: use Curl_none_* versions of init() and cleanup()
+
+ There are convenient no-op versions of the init/cleanup functions now,
+ no need to define private ones for axTLS.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
- polarssl: Fix exclusive SSL protocol version options
+ vtls: remove obsolete declarations of SSL backend functionality
- Prior to this change the options for exclusive SSL protocol versions did
- not actually set the protocol exclusive.
+ These functions are all available via the Curl_ssl struct now, no need
+ to declare them separately anymore.
+
+ As the global declarations are removed, the corresponding function
+ definitions are marked as file-local. The only two exceptions here are
+ Curl_mbedtls_shutdown() and Curl_polarssl_shutdown(): only the
+ declarations were removed, there are no function definitions to mark
+ file-local.
+
+ Please note that Curl_nss_force_init() is *still* declared globally, as
+ the only SSL backend-specific function, because it was introduced
+ specifically for the use case where cURL was compiled with
+ `--without-ssl --with-nss`. For details, see f3b77e561 (http_ntlm: add
+ support for NSS, 2010-06-27).
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ schannel: reorder functions topologically
+
+ The _shutdown() function calls the _session_free() function; While this
+ is not a problem now (because schannel.h declares both functions), a
+ patch looming in the immediate future with make all of these functions
+ file-local.
+
+ So let's just move the _session_free() function's definition before it
+ is called.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ axtls: reorder functions topologically
+
+ The connect_finish() function (like many other functions after it) calls
+ the Curl_axtls_close() function; While this is not a problem now
+ (because axtls.h declares the latter function), a patch looming in the
+ immediate future with make all of these functions file-local.
+
+ So let's just move the Curl_axtls_close() function's definition before
+ it is called.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: move the SUPPORT_HTTPS_PROXY flag into the Curl_ssl struct
+
+ That will allow us to choose the SSL backend at runtime.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: convert the have_curlssl_* constants to runtime flags
+
+ The entire idea of introducing the Curl_ssl struct to describe SSL
+ backends is to prepare for choosing the SSL backend at runtime.
+
+ To that end, convert all the #ifdef have_curlssl_* style conditionals
+ to use bit flags instead.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: move sha256sum into the Curl_ssl struct
+
+ The SHA-256 checksumming is also an SSL backend-specific function.
+ Let's include it in the struct declaring the functionality of SSL
+ backends.
+
+ In contrast to MD5, there is no fall-back code. To indicate this, the
+ respective entries are NULL for those backends that offer no support for
+ SHA-256 checksumming.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: move md5sum into the Curl_ssl struct
+
+ The MD5 summing is also an SSL backend-specific function. So let's
+ include it, offering the previous fall-back code as a separate function
+ now: Curl_none_md5sum(). To allow for that, the signature had to be
+ changed so that an error could be returned from the implementation
+ (Curl_none_md5sum() can run out of memory).
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: use the Curl_ssl struct to access all SSL backends' functionality
+
+ This is the first step to unify the SSL backend handling. Now all the
+ SSL backend-specific functionality is accessed via a global instance of
+ the Curl_ssl struct.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: declare Curl_ssl structs for every SSL backend
+
+ The idea of introducing the Curl_ssl struct was to unify how the SSL
+ backends are declared and called. To this end, we now provide an
+ instance of the Curl_ssl struct for each and every SSL backend.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: introduce a new struct for SSL backends
+
+ This new struct is similar in nature to Curl_handler: it will define the
+ functions and capabilities of all the SSL backends (where Curl_handler
+ defines the functions and capabilities of protocol handlers).
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: make sure every _sha256sum()'s first arg is const
+
+ This patch makes the signature of the _sha256sum() functions consistent
+ among the SSL backends, in preparation for unifying the way all SSL
+ backends are accessed.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: make sure all _data_pending() functions return bool
+
+ This patch makes the signature of the _data_pending() functions
+ consistent among the SSL backends, in preparation for unifying the way
+ all SSL backends are accessed.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: make sure all _cleanup() functions return void
+
+ This patch makes the signature of the _cleanup() functions consistent
+ among the SSL backends, in preparation for unifying the way all SSL
+ backends are accessed.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- [Johannes Schindelin brought this change]
+
+ vtls: use consistent signature for _random() implementations
+
+ This will make the upcoming multissl backend much easier to implement.
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- strtooff: fix build for systems with long long but no strtoll option
+
+ Closes #1829
- http://curl.haxx.se/mail/lib-2015-01/0002.html
Reported-by: Dan Fandrich
+ Bug: https://github.com/curl/curl/pull/1758#issuecomment-324861615
-- [Jay Satiro brought this change]
+- darwinssl: handle long strings in TLS certs
+
+ ... as the previous fixed length 128 bytes buffer was sometimes too
+ small.
+
+ Fixes #1823
+ Closes #1831
+
+ Reported-by: Benjamin Sergeant
+ Assisted-by: Bill Pyne, Ray Satiro, Nick Zitzmann
- gskit: Fix exclusive SSLv3 option
+- system.h: include sys/poll.h for AIX
+
+ ... to get the event/revent defines that might be used for the poll
+ struct.
+
+ Reported-by: Michael Smith
+ Fixes #1828
+ Closes #1833
-- curl.1: clarify that -X is used for all requests
+Dan Fandrich (26 Aug 2017)
+- tests: Make sure libtests & unittests call curl_global_cleanup()
- Reported-by: Jon Seymour
+ These were missed in commit c468c27b.
-- curl.1: add warning when using -H and redirects
+Jay Satiro (26 Aug 2017)
+- [theantigod brought this change]
-Steve Holme (7 Feb 2015)
-- schannel: Removed curl_ prefix from source files
+ winbuild: fix embedded manifest option
- Removed the curl_ prefix from the schannel source files as discussed
- with Marc and Daniel at FOSDEM.
+ Embedded manifest option didn't work due to incorrect path.
+
+ Fixes https://github.com/curl/curl/issues/1832
-Daniel Stenberg (6 Feb 2015)
-- md5: use axTLS's own MD5 functions when available
+Daniel Stenberg (25 Aug 2017)
+- fuzz/Makefile.am: remove curlbuild.h leftovers
-- MD(4|5): make the MD4_* and MD5_* functions static
+- examples/threaded-ssl: mention that this is for openssl before 1.1
-- axtls: fix conversion from size_t to int warning
+- imap: use defined names for response codes
+
+ When working on this code I found the previous setup a bit weird while
+ using proper defines increases readability.
+
+ Closes #1824
-Steve Holme (5 Feb 2015)
-- ftp: Use 'CURLcode result' for curl result codes
+- CURLOPT_USERPWD.3: see also CURLOPT_PROXYUSERPWD
-Daniel Stenberg (5 Feb 2015)
-- openssl: SSL_SESSION->ssl_version no longer exist
+- imap: support PREAUTH
- The struct went private in 1.0.2 so we cannot read the version number
- from there anymore. Use SSL_version() instead!
+ It is a defined possible greeting at server startup that means the
+ connection is already authenticated. See
+ https://tools.ietf.org/html/rfc3501#section-7.1.4
- Reported-by: Gisle Vanem
- Bug: http://curl.haxx.se/mail/lib-2015-02/0034.html
+ Test 846 added to verify.
+
+ Fixes #1818
+ Closes #1820
+
+Jay Satiro (23 Aug 2017)
+- config-tpf: define SIZEOF_LONG
+
+ Recent changes that replaced CURL_SIZEOF_LONG in the source with
+ SIZEOF_LONG broke builds that use the premade configuration files and
+ don't have SIZEOF_LONG defined.
+
+ Bug: https://github.com/curl/curl/issues/1816
+
+Dan Fandrich (23 Aug 2017)
+- test1453: Fixed <features>
-Dan Fandrich (4 Feb 2015)
-- unit1600: Fix compilation when NTLM is disabled
+Daniel Stenberg (22 Aug 2017)
+- [Gisle Vanem brought this change]
-Daniel Stenberg (4 Feb 2015)
-- MD5: fix compiler warnings and code style nits
+ config-dos: add missing defines, SIZEOF_* and two others
+
+ Bug: #1816
-- MD5: replace implementation
+- curl: shorten and clean up CA cert verification error message
+
+ The previous message was just too long for ordinary people and it was
+ encouraging users to use `--insecure` a little too easy.
- The previous one was "encumbered" by RSA Inc - to avoid the licensing
- restrictions it has being replaced. This is the initial import,
- inserting the md5.c and md5.h files from
- http://openwall.info/wiki/people/solar/software/public-domain-source-code/md5
+ Based-on-work-by: Frank Denis
- Code-by: Alexander Peslyak
+ Closes #1810
+ Closes #1817
-- MD4: fix compiler warnings and code style nits
+- request-target.d: mention added in 7.55.0
-- MD4: replace implementation
+Marcel Raad (22 Aug 2017)
+- tool_main: turn off MinGW CRT's globbing
- The previous one was "encumbered" by RSA Inc - to avoid the licensing
- restrictions it has being replaced. This is the initial import,
- inserting the md4.c and md4.h files from
- http://openwall.info/wiki/people/solar/software/public-domain-source-code/md4
+ By default, the MinGW CRT globs command-line arguments. This prevents
+ getting a single asterisk into an argument as test 1299 does. Turn off
+ globbing by setting the global variable _CRT_glob to 0 for MinGW.
- Code-by: Alexander Peslyak
+ Fixes https://github.com/curl/curl/issues/1751
+ Closes https://github.com/curl/curl/pull/1813
-Steve Holme (4 Feb 2015)
-- telnet: Prefer 'CURLcode result' for curl result codes
+Viktor Szakats (22 Aug 2017)
+- makefile.m32: add support for libidn2
+
+ libidn was replaced with libidn2 last year in configure.
+ Caveat: libidn2 may depend on a list of further libs.
+ These can be manually specified via CURL_LDFLAG_EXTRAS.
+
+ Closes https://github.com/curl/curl/pull/1815
-- hostasyn: Prefer 'CURLcode result' for curl result codes
+Jay Satiro (22 Aug 2017)
+- [Viktor Szakats brought this change]
-- schannel: Prefer 'CURLcode result' for curl result codes
+ config-win32: define SIZEOF_LONG
+
+ Recent changes that replaced CURL_SIZEOF_LONG in the source with
+ SIZEOF_LONG broke builds that use the premade configuration files and
+ don't have SIZEOF_LONG defined.
+
+ Closes https://github.com/curl/curl/pull/1814
-Daniel Stenberg (3 Feb 2015)
-- unit1601: MD5 unit tests
+Daniel Stenberg (20 Aug 2017)
+- cmake: enable picky compiler options with clang and gcc
+
+ closes #1799
-- unit1600: unit test for Curl_ntlm_core_mk_nt_hash
+- curl/system.h: fix build for hppa
+
+ Reported-by: John David Anglin
+ Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872502#10
-- unit1600: NTLM unit test
+- [Even Rouault brought this change]
-- tests/README: add a new range, clean up some language
+ tftp: fix memory leak on too long filename
+
+ Fixes
+
+ $ valgrind --leak-check=full ~/install-curl-git/bin/curl tftp://localhost/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaz
+
+ ==9752== Memcheck, a memory error detector
+ ==9752== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
+ ==9752== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info
+ ==9752== Command: /home/even/install-curl-git/bin/curl tftp://localhost/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaz
+ ==9752==
+ curl: (71) TFTP file name too long
+
+ ==9752==
+ ==9752== HEAP SUMMARY:
+ ==9752== 505 bytes in 1 blocks are definitely lost in loss record 11 of 11
+ ==9752== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
+ ==9752== by 0x4E61CED: Curl_urldecode (in /home/even/install-curl-git/lib/libcurl.so.4.4.0)
+ ==9752== by 0x4E75868: tftp_state_machine (in /home/even/install-curl-git/lib/libcurl.so.4.4.0)
+ ==9752== by 0x4E761B6: tftp_do (in /home/even/install-curl-git/lib/libcurl.so.4.4.0)
+ ==9752== by 0x4E711B6: multi_runsingle (in /home/even/install-curl-git/lib/libcurl.so.4.4.0)
+ ==9752== by 0x4E71D00: curl_multi_perform (in /home/even/install-curl-git/lib/libcurl.so.4.4.0)
+ ==9752== by 0x4E6950D: curl_easy_perform (in /home/even/install-curl-git/lib/libcurl.so.4.4.0)
+ ==9752== by 0x40E0B7: operate_do (in /home/even/install-curl-git/bin/curl)
+ ==9752== by 0x40E849: operate (in /home/even/install-curl-git/bin/curl)
+ ==9752== by 0x402693: main (in /home/even/install-curl-git/bin/curl)
+
+ Fixes https://oss-fuzz.com/v2/testcase-detail/5232311106797568
+ Credit to OSS Fuzz
+
+ Closes #1808
-- [Jay Satiro brought this change]
+Dan Fandrich (19 Aug 2017)
+- runtests: fixed case insensitive matching of keywords
+
+ Commit 5c2aac71 didn't work in the case of mixed-case keywords given on
+ the command-line.
+
+- tests: Make sure libtests call curl_global_cleanup()
+
+ This ensures that global data allocations are freed so Valgrind stays
+ happy. This was a problem with at least PolarSSL and mbedTLS.
+
+Daniel Stenberg (18 Aug 2017)
+- RELEASE-NOTES: synced with 8baead425
+
+- scripts/contri*sh: use "git log --use-mailmap"
+
+- mailmap: de-duplify some git authors
+
+- http2_recv: return error better on fatal h2 errors
+
+ Ref #1012
+ Figured-out-by: Tatsuhiro Tsujikawa
+
+- KNOWN_BUGS: HTTP test server 'connection-monitor' problems
+
+ Closes #868
+
+- curl/system.h: check for __ppc__ as well
+
+ ... regression since issue #1774 (commit 10b3df10596a) since obviously
+ some older gcc doesn't know __powerpc__ while some newer doesn't know
+ __ppc__ ...
+
+ Fixes #1797
+ Closes #1798
+ Reported-by: Ryan Schmidt
+
+- [Jan Alexander Steffens (heftig) brought this change]
+
+ http: Don't wait on CONNECT when there is no proxy
+
+ Since curl 7.55.0, NetworkManager almost always failed its connectivity
+ check by timeout. I bisected this to 5113ad04 (http-proxy: do the HTTP
+ CONNECT process entirely non-blocking).
+
+ This patch replaces !Curl_connect_complete with Curl_connect_ongoing,
+ which returns false if the CONNECT state was left uninitialized and lets
+ the connection continue.
+
+ Closes #1803
+ Fixes #1804
+
+ Also-fixed-by: Gergely Nagy
+
+- [Johannes Schindelin brought this change]
+
+ metalink: adjust source code style
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- CURL_SIZEOF_LONG: removed, use only SIZEOF_LONG
- opts: CURLOPT_CAINFO availability depends on SSL engine
+- lib557: no longer use CURL_SIZEOF_* defines
-- getpass: protect include with proper #ifdef
+- config-win32: define SIZEOF_CURL_OFF_T
+
+- cmake: sizeof curl_off_t, remove unused detections
+
+- system.h: remove all CURL_SIZEOF_* defines
+
+ ... as they're not used externally and internally we check for the sizes
+ already in configure etc.
+
+ Closes #1767
+
+- ftp: fix CWD when doing multicwd then nocwd on same connection
+
+ Fixes #1782
+ Closes #1787
+ Reported-by: Peter Lamare
+
+- CURLOPT_SSH_COMPRESSION.3: enable with 1L
- Reported-by: Tamir
+ (leaves other values reserved for the future)
+
+- compressed-ssh.d: "Added: 7.56.0"
+
+- curl/system.h: checksrc compliance
-- getpass_r: read from stdin, not stdout!
+Jay Satiro (17 Aug 2017)
+- [Viktor Szakats brought this change]
+
+ ssh: add the ability to enable compression (for SCP/SFTP)
+
+ The required low-level logic was already available as part of
+ `libssh2` (via `LIBSSH2_FLAG_COMPRESS` `libssh2_session_flag()`[1]
+ option.)
- The file number used was wrong. This bug was introduced over 10 years
- ago, proving this function isn't used much...
+ This patch adds the new `libcurl` option `CURLOPT_SSH_COMPRESSION`
+ (boolean) and the new `curl` command-line option `--compressed-ssh`
+ to request this `libssh2` feature. To have compression enabled, it
+ is required that the SSH server supports a (zlib) compatible
+ compression method and that `libssh2` was built with `zlib` support
+ enabled.
+
+ [1] https://www.libssh2.org/libssh2_session_flag.html
+
+ Ref: https://github.com/curl/curl/issues/1732
+ Closes https://github.com/curl/curl/pull/1735
+
+- examples/ftpuploadresume: checksrc compliance
+
+- [Maksim Stsepanenka brought this change]
+
+ http_proxy: fix build error for CURL_DOES_CONVERSIONS
+
+ Closes https://github.com/curl/curl/pull/1793
+
+GitHub (16 Aug 2017)
+- [Nick Zitzmann brought this change]
+
+ configure: check for __builtin_available() availability (#1788)
+
+ This change does two things:
+ 1. It un-breaks the build in Xcode 9.0. (Xcode 9.0 is currently
+ failing trying to compile connectx() in lib/connect.c.)
+ 2. It finally weak-links the connectx() function, and falls back on
+ connect() when run on older operating systems.
+
+Daniel Stenberg (16 Aug 2017)
+- travis: add metalink to some osx builds
- Bug: http://curl.haxx.se/bug/view.cgi?id=1476
- Reported-by: Tamir
+ Closes #1790
-- test1135: verify the CURL_EXTERN order in header files
+- [Max Dymond brought this change]
-- Makefile.am: fix 'make distcheck'
+ coverage: Use two coveralls commands to get lib/vtls results
+
+ closes #1747
+
+- darwinssi: fix error: variable length array used
+
+- m4/curl-compilers.m4: use proper quotes around string, not backticks
+
+ ... when setting clang version to assume 3.7
+
+ Caused a lot of "integer expression expected" warnings by configure.
+
+- [Benbuck Nason brought this change]
+
+ cmake: remove dead code for DISABLED_THREADSAFE
+
+ Closes #1786
+
+Jay Satiro (15 Aug 2017)
+- [Jakub Zakrzewski brought this change]
+
+ curl-confopts.m4: fix --disable-threaded-resolver
+
+ Closes https://github.com/curl/curl/issues/1784
+
+Daniel Stenberg (15 Aug 2017)
+- [Ryan Winograd brought this change]
+
+ progress: Track total times following redirects
+
+ Update the progress timers `t_nslookup`, `t_connect`, `t_appconnect`,
+ `t_pretransfer`, and `t_starttransfer` to track the total times for
+ these activities when a redirect is followed. Previously, only the times
+ for the most recent request would be tracked.
+
+ Related changes:
+
+ - Rename `Curl_pgrsResetTimesSizes` to `Curl_pgrsResetTransferSizes`
+ now that the function only resets transfer sizes and no longer
+ modifies any of the progress timers.
+
+ - Add a bool to the `Progress` struct that is used to prevent
+ double-counting `t_starttransfer` times.
+
+ Added test case 1399.
+
+ Fixes #522 and Known Bug 1.8
+ Closes #1602
+ Reported-by: joshhe on github
+
+- [Benbuck Nason brought this change]
+
+ cmake: remove dead code for CURL_DISABLE_RTMP
+
+ Closes #1785
+
+Kamil Dudka (15 Aug 2017)
+- zsh.pl: produce a working completion script again
+
+ Commit curl-7_54_0-118-g8b2f22e changed the output format of curl --help
+ to use <file> and <dir> instead of FILE and DIR, which caused zsh.pl to
+ produce a broken completion script:
+
+ % curl --<TAB>
+ _curl:10: no such file or directory: seconds
+
+ Closes #1779
+
+Daniel Stenberg (15 Aug 2017)
+- curlver: toward 7.56.0?
+
+- RELEASE-NOTES: synced with 91c46dc44
+
+- test1449: FTP download range with an too large size
+
+- strtoofft: reduce integer overflow risks globally
+
+ ... make sure we bail out on overflows.
+
+ Reported-by: Brian Carpenter
+ Closes #1758
+
+- travis: build the examples too
+
+ to make sure they keep building warning-free
+
+ Closes #1777
+
+- runtests: match keywords case insensitively
+
+- examples/ftpuploadresume.c: use portable code
+
+ ... converted from the MS specific _snscanf()
+
+Version 7.55.1 (13 Aug 2017)
+
+Daniel Stenberg (13 Aug 2017)
+- RELEASE-NOTES/THANKS: curl 7.55.1 release time
+
+- gitignore: ignore .xz now instead of .lzma
+
+- [Sergei Nikulov brought this change]
+
+ cmake: Threads detection update. ref: #1702
+
+ Closes #1719
+
+- ipv6_scope: support unique local addresses
+
+ Fixes #1764
+ Closes #1773
+ Reported-by: James Slaughter
+
+- [Alex Potapenko brought this change]
+
+ curl/system.h: GCC doesn't define __ppc__ on PowerPC, uses __powerpc__
+
+ Closes #1774
+
+- test1448: verify redirect to IDN using URL
+
+ Closes #1772
+
+- [Salah-Eddin Shaban brought this change]
+
+ redirect: skip URL encoding for host names
+
+ This fixes redirects to IDN URLs
+
+ Fixes #1441
+ Closes #1762
+ Reported by: David Lord
+
+- test2032: mark as flaky (again)
+
+- travis: test cmake build on tarball too
+
+ Could've prevented #1755
+
+- [Simon Warta brought this change]
+
+ cmake: allow user to override CMAKE_DEBUG_POSTFIX
+
+ Closes #1763
+
+- connect-to.d: better language
+
+- connect-to.d: clarified
+
+- bagder/Curl_tvdiff_us: fix the math
+
+ Regression since adef394ac5 (released in 7.55.0)
+
+ Reported-by: Han Qiao
+ Fixes #1769
+ Closes #1771
+
+- curl/system.h: add Oracle Solaris Studio
+
+ Fixes #1752
+
+- [Alessandro Ghedini brought this change]
+
+ docs: fix typo funtion -> function
+
+ Closes #1770
+
+Alessandro Ghedini (12 Aug 2017)
+- docs: fix grammar in CURL_SSLVERSION_MAX_DEFAULT description
+
+- docs: fix typo stuct -> struct
+
+Dan Fandrich (12 Aug 2017)
+- test1447: require a curl with http support
+
+Daniel Stenberg (11 Aug 2017)
+- [Thomas Petazzoni brought this change]
+
+ curl/system.h: support more architectures
+
+ The long list of architectures in include/curl/system.h is annoying to
+ maintain, and needs to be extended for each and every architecture to
+ support.
+
+ Instead, let's rely on the __SIZEOF_LONG__ define of the gcc compiler
+ (we are in the GNUC condition anyway), which tells us if long is 4
+ bytes or 8 bytes.
+
+ This fixes the build of libcurl 7.55.0 on architectures such as
+ OpenRISC or ARC.
+
+ Closes #1766
+
+ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+
+- test2033: this went flaky again
+
+ Suspicion: when we enabled the threaded resolver by default.
+
+- test1447: verifies the parse proxy fix in 6e0e152ce5c
+
+- [Even Rouault brought this change]
+
+ parse_proxy(): fix memory leak in case of invalid proxy server name
+
+ Fixes the below leak:
+
+ $ valgrind --leak-check=full ~/install-curl-git/bin/curl --proxy "http://a:b@/x" http://127.0.0.1
+ curl: (5) Couldn't resolve proxy name
+ ==5048==
+ ==5048== HEAP SUMMARY:
+ ==5048== in use at exit: 532 bytes in 12 blocks
+ ==5048== total heap usage: 5,288 allocs, 5,276 frees, 445,271 bytes allocated
+ ==5048==
+ ==5048== 2 bytes in 1 blocks are definitely lost in loss record 1 of 12
+ ==5048== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
+ ==5048== by 0x4E6CB79: parse_login_details (url.c:5614)
+ ==5048== by 0x4E6BA82: parse_proxy (url.c:5091)
+ ==5048== by 0x4E6C46D: create_conn_helper_init_proxy (url.c:5346)
+ ==5048== by 0x4E6EA18: create_conn (url.c:6498)
+ ==5048== by 0x4E6F9B4: Curl_connect (url.c:6967)
+ ==5048== by 0x4E86D05: multi_runsingle (multi.c:1436)
+ ==5048== by 0x4E88432: curl_multi_perform (multi.c:2160)
+ ==5048== by 0x4E7C515: easy_transfer (easy.c:708)
+ ==5048== by 0x4E7C74A: easy_perform (easy.c:794)
+ ==5048== by 0x4E7C7B1: curl_easy_perform (easy.c:813)
+ ==5048== by 0x414025: operate_do (tool_operate.c:1563)
+ ==5048==
+ ==5048== 2 bytes in 1 blocks are definitely lost in loss record 2 of 12
+ ==5048== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
+ ==5048== by 0x4E6CBB6: parse_login_details (url.c:5621)
+ ==5048== by 0x4E6BA82: parse_proxy (url.c:5091)
+ ==5048== by 0x4E6C46D: create_conn_helper_init_proxy (url.c:5346)
+ ==5048== by 0x4E6EA18: create_conn (url.c:6498)
+ ==5048== by 0x4E6F9B4: Curl_connect (url.c:6967)
+ ==5048== by 0x4E86D05: multi_runsingle (multi.c:1436)
+ ==5048== by 0x4E88432: curl_multi_perform (multi.c:2160)
+ ==5048== by 0x4E7C515: easy_transfer (easy.c:708)
+ ==5048== by 0x4E7C74A: easy_perform (easy.c:794)
+ ==5048== by 0x4E7C7B1: curl_easy_perform (easy.c:813)
+ ==5048== by 0x414025: operate_do (tool_operate.c:1563)
+
+ Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2984
+ Credit to OSS Fuzz for discovery
+
+ Closes #1761
+
+- RELEASE-NOTES: synced with 37f2195a9
+
+- curlver: bump to 7.55.1
+
+- openssl: fix "error: this statement may fall through"
+
+ A gcc7 warning.
+
+- [David Benjamin brought this change]
+
+ openssl: remove CONST_ASN1_BIT_STRING.
+
+ Just making the pointer as const works for the pre-1.1.0 path too.
+
+ Closes #1759
+
+- maketgz: remove old *.dist files before making the tarball
+
+ To avoid "old crap" unintentionally getting shipped.
+
+ Bug: https://curl.haxx.se/mail/lib-2017-08/0050.html
+ Reported-by: Christian Weisgerber
+
+Jay Satiro (10 Aug 2017)
+- mkhelp.pl: allow executing this script directly
+
+ - Enable execute permission (chmod +x)
+
+ - Change interpreter to /usr/bin/env perl
+
+ Ref: https://github.com/curl/curl/issues/1743
+
+Daniel Stenberg (10 Aug 2017)
+- configure: use the threaded resolver backend by default if possible
+
+ Closes #1647
+
+- cmake: move cmake_uninstall.cmake to CMake/
+
+ Closes #1756
+
+- metalink: fix error: ‘*’ in boolean context, suggest ‘&&’ instead
+
+- dist: fix the cmake build by shipping cmake_uninstall.cmake.in too
+
+ Fixes #1755
+
+- travis: verify "make install"
+
+ Help-by: Jay Satiro
+ Closes #1753
+
+Marcel Raad (10 Aug 2017)
+- build: check out *.sln files with Windows line endings
+
+ Visual Studio doesn't like LF line endings in solution files and always
+ converts them to CRLF when doing changes to the solution. Notably, this
+ affects the solutions in the release archive.
+
+ Closes https://github.com/curl/curl/pull/1746
+
+- gitignore: ignore top-level .vs folder
+
+ This folder is generated when using the CMake build system from within
+ Visual Studio.
+
+ Closes https://github.com/curl/curl/pull/1746
+
+Jay Satiro (10 Aug 2017)
+- digest_sspi: Don't reuse context if the user/passwd has changed
+
+ Bug: https://github.com/curl/curl/issues/1685
+ Reported-by: paulharris@users.noreply.github.com
+
+ Assisted-by: Isaac Boukris
+
+ Closes https://github.com/curl/curl/pull/1742
+
+Daniel Stenberg (9 Aug 2017)
+- [Adam Sampson brought this change]
+
+ dist: Add dictserver.py/negtelnetserver.py to EXTRA_DIST
+
+ These weren't included in the 7.55.0 release, but are required in order
+ to run the full test suite.
+
+ Closes #1744
+
+- [Adam Sampson brought this change]
+
+ curl: do bounds check using a double comparison
+
+ The fix for this in 8661a0aacc01492e0436275ff36a21734f2541bb wasn't
+ complete: if the parsed number in num is larger than will fit in a long,
+ the conversion is undefined behaviour (causing test1427 to fail for me
+ on IA32 with GCC 7.1, although it passes on AMD64 and ARMv7). Getting
+ rid of the cast means the comparison will be done using doubles.
+
+ It might make more sense for the max argument to also be a double...
+
+ Fixes #1750
+ Closes #1749
+
+- make install: add 8 missing man pages to the installation
+
+- build: fix 'make install' with configure, install docs/libcurl/* too
+
+ Broken since d24838d4da9faa
+
+ Reported-by: Bernard Spil
+
+Version 7.55.0 (9 Aug 2017)
+
+Daniel Stenberg (9 Aug 2017)
+- RELEASE-NOTES: curl 7.55.0
+
+- THANKS: 20 new contributors in 7.55.0
+
+- [Viktor Szakats brought this change]
+
+ docs/comments: Update to secure URL versions
+
+ Closes #1741
+
+- configure: fix recv/send/select detection on Android
+
+ ... since they now provide several functions as
+ __attribute__((overloadable)), the argument detection logic need
+ updates.
+
+ Patched-by: destman at github
+
+ Fixes #1738
+ Closes #1739
+
+Marcel Raad (8 Aug 2017)
+- ax_code_coverage.m4: update to latest version
+
+ This updates the script to aad5ad5fedb306b39f901a899b7bd305b66c418d
+ from August 01, 2017. Notably, this removes the lconv version whitelist.
+
+ Closes https://github.com/curl/curl/pull/1716
+
+Daniel Stenberg (7 Aug 2017)
+- test1427: verify command line parser integer overflow detection
+
+- curl: detect and bail out early on parameter integer overflows
+
+ Make the number parser aware of the maximum limit curl accepts for a
+ value and return an error immediately if larger, instead of running an
+ integer overflow later.
+
+ Fixes #1730
+ Closes #1736
+
+- glob: do not continue parsing after a strtoul() overflow range
+
+ Added test 1289 to verify.
+
+ CVE-2017-1000101
+
+ Bug: https://curl.haxx.se/docs/adv_20170809A.html
+ Reported-by: Brian Carpenter
+
+- tftp: reject file name lengths that don't fit
+
+ ... and thereby avoid telling send() to send off more bytes than the
+ size of the buffer!
+
+ CVE-2017-1000100
+
+ Bug: https://curl.haxx.se/docs/adv_20170809B.html
+ Reported-by: Even Rouault
+
+ Credit to OSS-Fuzz for the discovery
+
+- [Even Rouault brought this change]
+
+ file: output the correct buffer to the user
+
+ Regression brought by 7c312f84ea930d8 (April 2017)
+
+ CVE-2017-1000099
+
+ Bug: https://curl.haxx.se/docs/adv_20170809C.html
+
+ Credit to OSS-Fuzz for the discovery
+
+- easy_events: make event data static
+
+ First: this function is only used in debug-builds and not in
+ release/real builds. It is used to drive tests using the event-based
+ API.
+
+ A pointer to the local struct is passed to CURLMOPT_TIMERDATA, but the
+ CURLMOPT_TIMERFUNCTION calback can in fact be called even after this
+ funtion returns, namely when curl_multi_remove_handle() is called.
+
+ Reported-by: Brian Carpenter
+
+- getparameter: avoid returning uninitialized 'usedarg'
+
+ Fixes #1728
+
+Marcel Raad (5 Aug 2017)
+- [Isaac Boukris brought this change]
+
+ gssapi: fix memory leak of output token in multi round context
+
+ When multiple rounds are needed to establish a security context
+ (usually ntlm), we overwrite old token with a new one without free.
+ Found by proposed gss tests using stub a gss implementation (by
+ valgrind error), though I have confirmed the leak with a real
+ gssapi implementation as well.
+
+ Closes https://github.com/curl/curl/pull/1733
+
+- darwinssl: fix compiler warning
+
+ clang complains:
+ vtls/darwinssl.c:40:8: error: extra tokens at end of #endif directive
+ [-Werror,-Wextra-tokens]
- ... by removing generated files from the *_DIST variable [*] and instead
- generate them with a .dist suffix, since that is then handled and put
- into the release archive by our generic dist-hook.
+ This breaks the darwinssl build on Travis. Fix it by making this token
+ a comment.
- [*] = 'make distcheck' fails with non-existing files listed there
+ Closes https://github.com/curl/curl/pull/1734
-Steve Holme (2 Feb 2015)
-- curl_sasl.c: More code policing
+- CMake: fix CURL_WERROR for MSVC
- Better use of 80 character line limit, comment corrections and line
- spacing preferences.
-
-Daniel Stenberg (2 Feb 2015)
-- libcurl-symbols: first basic shot for autogenerated docs
+ When using CURL_WERROR in MSVC builds, the debug flags were overridden
+ by the release flags and /WX got added twice in debug mode.
+
+ Closes https://github.com/curl/curl/pull/1715
-- FAQ: minor edit of 3.22
+Daniel Stenberg (4 Aug 2017)
+- RELEASE-NOTES: synced with 561e9217c
-Steve Holme (2 Feb 2015)
-- build: Added removal of Visual Studio project files
+- test1010: verify that #1718 is fixed
- Added the removal of the locally generated project files so one
- may revert to a clean repository.
+ ... by doing two transfers in nocwd mode and check that there's no
+ superfluous CWD command.
-- build: Renamed top level Visual Studio solution files
+- FTP: skip unnecessary CWD when in nocwd mode
- In preparation for adding the test suite and examples projects renamed
- the top level "all" solution files to better describe what they are.
+ ... when reusing a connection. If it didn't do any CWD previously.
- This will also enable us to use "curl" rather than "curlsrc" for the
- command line tool solution and project files, which will simplify some
- of the configuration.
+ Fixes #1718
-- build: Enabled DEBUGBUILD in Visual Studio debug builds
+Marcel Raad (4 Aug 2017)
+- travis: explicitly specify dist
- Defined the DEBUGBUILD pre-processor variable to allow extra logging,
- which is particularly useful in debug builds, as we use this and Visual
- Studio typically uses _DEBUG.
-
- We could define DEBUBBUILD, in curl_setup.h, when _MSC_VER and _DEBUG is
- defined but that would also affect the makefile based builds which we
- probably don't want to do.
-
-- build: Removed unused Visual Studio bscmake settings
-
-Daniel Stenberg (2 Feb 2015)
-- CURLOPT_HTTP_VERSION.3: CURL_HTTP_VERSION_2_0 added in 7.33.0
+ This makes the builds more reproducible as travis is currently rolling
+ out trusty as default dist [1]. Specifically, this avoids coverage
+ check failures when trusty is used as seen in [2] until we figure out
+ what's wrong.
- And modify the text to refer to HTTP 2 as it isn't called "2.0".
+ [1] https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming
+ [2] https://github.com/curl/curl/pull/1692
- Reported-By: Michael Wallner
-
-Marc Hoersken (31 Jan 2015)
-- TODO: moved WinSSL/SChannel todo items into docs
-
-Daniel Stenberg (29 Jan 2015)
-- [Michael Kaufmann brought this change]
+ Closes https://github.com/curl/curl/pull/1725
- CURLOPT_SEEKFUNCTION.3: also when server closes a connection
-
-Steve Holme (29 Jan 2015)
-- curl_sasl.c: Fixed compilation warning when cryptography is disabled
+Daniel Stenberg (4 Aug 2017)
+- travis: BUILD_TYPE => T
- curl_sasl.c:1506: warning: unused variable 'chlg'
+ (to make the full line appear nicer on travis web UI)
-- curl_sasl.c: Fixed compilation warning when verbose debug output disabled
+- travis: add osx build with darwinssl
- curl_sasl.c:1317: warning: unused parameter 'conn'
-
-- ntlm_core: Use own odd parity function when crypto engine doesn't have one
-
-- ntlm_core: Prefer sizeof(key) rather than hard coded sizes
-
-- ntlm_core: Added consistent comments to DES functions
+ Closes #1706
-- des: Added Curl_des_set_odd_parity()
+- darwin: silence compiler warnings
- Added Curl_des_set_odd_parity() for use when cryptography engines
- don't include this functionality.
-
-- tests: Grouped SMTP SASL EXTERNAL tests with other SMTP tests
+ With a clang pragma and three type fixes
+
+ Fixes #1722
-- tests: Grouped POP3 SASL EXTERNAL tests with other POP3 tests
+- BUILD.WINDOWS: mention buildconf.bat for builds off git
-- tests: Grouped IMAP SASL EXTERNAL tests with other IMAP tests
+- darwinssl: fix curlssl_sha256sum() compiler warnings on first argument
-- sasl: Minor code policing and grammar corrections
+- test130: verify comments in .netrc
-Daniel Stenberg (28 Jan 2015)
- [Gisle Vanem brought this change]
- ldap: build with BoringSSL
+ netrc: skip lines starting with '#'
+
+ Bug: https://curl.haxx.se/mail/lib-2017-08/0008.html
-- security: avoid compiler warning
+Marcel Raad (3 Aug 2017)
+- CMake: set MSVC warning level to 4
- Possible access to uninitialised memory '&nread' at line 140 of
- lib/security.c in function 'ftp_send_command'.
+ The MSVC warning level defaults to 3 in CMake. Change it to 4, which is
+ consistent with the Visual Studio and NMake builds. Disable level 4
+ warning C4127 for the library and additionally C4306 for the test
+ servers to get a clean CURL_WERROR build as that warning is raised in
+ some macros in older Visual Studio versions.
- Reported-by: Rich Burridge
-
-- runtests: identify BoringSSL and libressl
+ Ref: https://github.com/curl/curl/pull/1667#issuecomment-314082794
+ Closes https://github.com/curl/curl/pull/1711
-Patrick Monnerat (27 Jan 2015)
-- docs: cite SASL external authentication.
-
-- sasl: remove XOAUTH2 from default enabled authentication mechanism.
+Daniel Stenberg (2 Aug 2017)
+- CURLOPT_NETRC.3: fix typo in 7e48aa386156f9c2
+
+ Reported-by: Viktor Szakats
-- test: add test cases for sasl external authentication (imap/pop3/smtp).
+- CURLOPT_NETRC.3: mention the file name on windows
+
+ ... and CURLOPT_NETRC_FILE(3).
-- imap: remove automatic password setting: it breaks external sasl authentication
+- travis: build osx with libressl too
-- sasl: implement EXTERNAL authentication mechanism.
- Its use is only enabled by explicit requirement in URL (;AUTH=EXTERNAL) and
- by not setting the password.
+- travis: build osx with openssl too
-Steve Holme (27 Jan 2015)
-- openssl: Fixed Curl_ossl_cert_status_request() not returning FALSE
-
- Modified the Curl_ossl_cert_status_request() function to return FALSE
- when built with BoringSSL or when OpenSSL is missing the necessary TLS
- extensions.
+- tests/server/util: fix curltime mistake from 4dee50b9c80f9
-- openssl: Fixed compilation errors when OpenSSL built with 'no-tlsext'
+Marcel Raad (1 Aug 2017)
+- curl_threads: fix MSVC compiler warning
- Fixed the build of openssl.c when OpenSSL is built without the necessary
- TLS extensions for OCSP stapling.
+ Use LongToHandle to convert from long to HANDLE in the Win32
+ implementation.
+ This should fix the following warning when compiling with
+ MSVC 11 (2012) in 64-bit mode:
+ lib\curl_threads.c(113): warning C4306:
+ 'type cast' : conversion from 'long' to 'HANDLE' of greater size
- Reported-by: John E. Malmberg
-
-- [Brad Spencer brought this change]
-
- curl_setup: Disable SMB/CIFS support when HTTP only
+ Closes https://github.com/curl/curl/pull/1717
-- RELEASE-NOTES: Synced with 37824498a3
-
-Daniel Stenberg (22 Jan 2015)
-- configure: remove detection of the old yassl emulation API
+Daniel Stenberg (1 Aug 2017)
+- BUGS: improved phrasing about security bugs
- ... as that is ancient history and not used.
+ Reported-by: Max Dymond
-- OCSP stapling: disabled when build with BoringSSL
+- BUGS: clarify how to report security related bugs
-- [Alessandro Ghedini brought this change]
+- [Brad Spencer brought this change]
- openssl: add support for the Certificate Status Request TLS extension
+ multi: fix request timer management
- Also known as "status_request" or OCSP stapling, defined in RFC6066
- section 8.
+ There are some bugs in how timers are managed for a single easy handle
+ that causes the wrong "next timeout" value to be reported to the
+ application when a new minimum needs to be recomputed and that new
+ minimum should be an existing timer that isn't currently set for the
+ easy handle. When the application drives a set of easy handles via the
+ `curl_multi_socket_action()` API (for example), it gets told to wait the
+ wrong amount of time before the next call, which causes requests to
+ linger for a long time (or, it is my guess, possibly forever).
- Thanks-to: Joe Mason
- - for the work-around for the OpenSSL bug.
+ Bug: https://curl.haxx.se/mail/lib-2017-07/0033.html
-- BoringSSL: fix build for non-configure builds
+Jay Satiro (1 Aug 2017)
+- curl_setup: Define CURL_NO_OLDIES for building libcurl
- HAVE_BORINGSSL gets defined now by configure and should be defined by
- other build systems in case a BoringSSL build is desired.
-
-- configure: fix BoringSSL detection and detect libresssl
-
-Steve Holme (22 Jan 2015)
-- curl_sasl: Reinstate the sasl_ prefix for locally scoped functions
+ .. to catch accidental use of deprecated error codes.
- Commit 7a8b2885e2 made some functions static and removed the public
- Curl_ prefix. Unfortunately, it also removed the sasl_ prefix, which
- is the naming convention we use in this source file.
-
-- curl_sasl: Minor code policing following recent commits
+ Ref: https://github.com/curl/curl/issues/1688#issuecomment-316764237
-Daniel Stenberg (22 Jan 2015)
-- [John Malmberg brought this change]
+Daniel Stenberg (1 Aug 2017)
+- [Jeremy Tan brought this change]
- openvms: Handle openssl/0.8.9zb version parsing
+ configure: fix the check for IdnToUnicode
- packages/vms/gnv_link_curl.com was assuming only a single letter suffix
- in the openssl version. That assumption has been fixed for 7.40.
-
-- BoringSSL: detected by configure, switches off NTLM
-
-- BoringSSL: no PKCS12 support nor ERR_remove_state
+ Fixes #1669
+ Closes #1713
-- [Leith Bade brought this change]
-
- BoringSSL: fix build
+- http: fix response code parser to avoid integer overflow
+
+ test 1429 and 1433 were updated to work with the stricter HTTP status line
+ parser.
+
+ Closes #1714
+ Reported-by: Brian Carpenter
-Steve Holme (20 Jan 2015)
-- curl_sasl.c: chlglen is not used when cryptography is disabled
+Jay Satiro (31 Jul 2017)
+- [Dwarakanath Yadavalli brought this change]
-- curl_sasl.c: Fixed compilation warning when cyptography is disabled
+ libcurl: Stop using error codes defined under CURL_NO_OLDIES
- curl_sasl.c:1453: warning C4101: 'serverdata' : unreferenced local
- variable
+ Fixes https://github.com/curl/curl/issues/1688
+ Closes https://github.com/curl/curl/pull/1712
-- curl_sasl.c: Fixed compilation error when USE_WINDOWS_SSPI defined
+- include.d: clarify --include is only for response headers
- curl_sasl.c:1221: error C2065: 'mechtable' : undeclared identifier
+ Follow-up to 171f8de and de6de94.
- This error could also happen for non-SSPI builds when cryptography is
- disabled (CURL_DISABLE_CRYPTO_AUTH is defined).
-
-Patrick Monnerat (20 Jan 2015)
-- SASL: make some procedures local-scoped
+ Bug: https://github.com/curl/curl/commit/de6de94#commitcomment-23370851
+ Reported-by: Daniel Stenberg
-- SASL: common state engine for imap/pop3/smtp
+Daniel Stenberg (30 Jul 2017)
+- [Jason Juang brought this change]
-- SASL: common URL option and auth capabilities decoders for all protocols
-
-- IMAP/POP3/SMTP: use a per-connection sub-structure for SASL parameters.
-
-Daniel Stenberg (20 Jan 2015)
-- ipv6: enclose AF_INET6 uses with proper #ifdefs for ipv6
+ cmake: support make uninstall
- Reported-by: Chris Young
+ Closes #1674
-- [Chris Young brought this change]
+- RELEASE-NOTES: synced with 001701c47
- timeval: typecast for better type (on Amiga)
+Marcel Raad (29 Jul 2017)
+- AppVeyor: now really use CURL_WERROR
- There is an issue with conflicting "struct timeval" definitions with
- certain AmigaOS releases and C libraries, depending on what gets
- included when. It's a minor difference - the OS one is unsigned,
- whereas the common structure has signed elements. If the OS one ends up
- getting defined, this causes a timing calculation error in curl.
+ It was misspelled as CURL_ERROR in commit
+ 2d86e8d1286e0fbe3d811e2e87fa0b5e53722db4.
- It's easy enough to resolve this at the curl end, by casting the
- potentially errorneous calculation to a signed long.
+ Closes https://github.com/curl/curl/pull/1686
-- openssl: do public key pinning check independently
+Jay Satiro (29 Jul 2017)
+- tool_help: clarify --include is only for response headers
- ... of the other cert verification checks so that you can set verifyhost
- and verifypeer to FALSE and still check the public key.
+ Follow-up to 171f8de.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1471
- Reported-by: Kyle J. McKay
+ Ref: https://github.com/curl/curl/issues/1704
-Patrick Monnerat (19 Jan 2015)
-- OS400: CURLOPT_SSL_VERIFYSTATUS for ILE/RPG too.
-
-Steve Holme (18 Jan 2015)
-- ldap: Renamed the CURL_LDAP_WIN definition to USE_WIN32_LDAP
+- splay: fix signed/unsigned mismatch warning
+
+ Follow-up to 4dee50b.
- For consistency with other USE_WIN32_ defines as well as the
- USE_OPENLDAP define.
+ Ref: https://github.com/curl/curl/pull/1693
-- http_negotiate: Use dynamic buffer for SPN generation
+Daniel Stenberg (28 Jul 2017)
+- include.d: clarify that it concerns the response headers
- Use a dynamicly allocated buffer for the temporary SPN variable similar
- to how the SASL GSS-API code does, rather than using a fixed buffer of
- 2048 characters.
+ Reported-by: olesteban at github
+ Fixes #1704
-- sasl_gssapi: Make Curl_sasl_build_gssapi_spn() public
+- [Johannes Schindelin brought this change]
-- sasl_gssapi: Fixed memory leak with local SPN variable
+ curl_rtmp: fix a compiler warning
+
+ The headers of librtmp declare the socket as `int`, and on Windows, that
+ disagrees with curl_socket_t.
+
+ Bug: #1652
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
+
+- test1323: verify curlx_tvdiff
-Daniel Stenberg (17 Jan 2015)
-- http_negotiate.c: unused variable 'ret'
+- timeval: struct curltime is a struct timeval replacement
+
+ ... to make all libcurl internals able to use the same data types for
+ the struct members. The timeval struct differs subtly on several
+ platforms so it makes it cumbersome to use everywhere.
+
+ Ref: #1652
+ Closes #1693
-Steve Holme (17 Jan 2015)
-- gskit.h: Code policing of function pointer arguments
+- darwinssl: fix variable type mistake (regression)
+
+ ... which made --tlsv1.2 not work because it would blank the max tls
+ version variable.
+
+ Reported-by: Nick Miyake
+ Bug: #1703
-- vtls: Removed unimplemented overrides of curlssl_close_all()
+- multi: mention integer overflow risk if using > 500 million sockets
- Carrying on from commit 037cd0d991, removed the following unimplemented
- instances of curlssl_close_all():
+ Reported-by: ovidiu-benea@users.noreply.github.com
- Curl_axtls_close_all()
- Curl_darwinssl_close_all()
- Curl_cyassl_close_all()
- Curl_gskit_close_all()
- Curl_gtls_close_all()
- Curl_nss_close_all()
- Curl_polarssl_close_all()
+ Closes #1675
+ Closes #1683
-- vtls: Separate the SSL backend definition from the API setup
+- checksrc: escape open brace in regex
- Slight code cleanup as the SSL backend #define is mixed up with the API
- function setup.
+ ... to silence warning.
-- vtls: Fixed compilation errors when SSL not used
+Kamil Dudka (20 Jul 2017)
+- nss: fix a possible use-after-free in SelectClientCert()
- Fixed the following warning and error from commit 3af90a6e19 when SSL
- is not being used:
+ ... causing a SIGSEGV in showit() in case the handle used to initiate
+ the connection has already been freed.
- url.c:2004: warning C4013: 'Curl_ssl_cert_status_request' undefined;
- assuming extern returning int
+ This commit fixes a bug introduced in curl-7_19_5-204-g5f0cae803.
- error LNK2019: unresolved external symbol Curl_ssl_cert_status_request
- referenced in function Curl_setopt
+ Reported-by: Rob Sanders
+ Bug: https://bugzilla.redhat.com/1436158
-- http_negotiate: Added empty decoded challenge message info text
+- nss: unify the coding style of nss_send() and nss_recv()
+
+ No changes in behavior intended by this commit.
-- http_negotiate: Return CURLcode in Curl_input_negotiate() instead of int
+Marcel Raad (18 Jul 2017)
+- tests/server/resolve.c: fix deprecation warning
+
+ MSVC warns that gethostbyname is deprecated. Always use getaddrinfo
+ instead to fix this when IPv6 is enabled, also for IPv4 resolves. This
+ is also consistent with what libcurl does.
+
+ Closes https://github.com/curl/curl/pull/1682
-- http_negotiate_sspi: Prefer use of 'attrs' for context attributes
+Jay Satiro (17 Jul 2017)
+- darwinssl: fix pinnedpubkey build error
+
+ - s/SessionHandle/Curl_easy/
- Use the same variable name as other areas of SSPI code.
+ Bug: https://github.com/curl/curl/commit/eb16305#commitcomment-23035670
+ Reported-by: Gisle Vanem
-- http_negotiate_sspi: Use correct return type for QuerySecurityPackageInfo()
+Marcel Raad (16 Jul 2017)
+- rtspd: fix GCC warning after MSVC warning fix
+
+ Older GCC warns:
+ /tests/server/rtspd.c:1194:10: warning: missing braces around
+ initializer [-Wmissing-braces]
- Use the SECURITY_STATUS typedef rather than a unsigned long for the
- QuerySecurityPackageInfo() return and rename the variable as per other
- areas of SSPI code.
+ Fix this by using memset instead of an initializer.
-- http_negotiate_sspi: Use 'CURLcode result' for CURL result code
+- libtest: fix MSVC warning C4706
+
+ With warning level 4, MSVC warns about assignments within conditional
+ expressions. Change the while loop to a do-while loop to fix this. This
+ change is also consistent with CODE_STYLE.md.
-- curl_endian: Fixed build when 64-bit integers are not supported (Part 2)
+- sockfilt: suppress conversion warning with explicit cast
- Missed Curl_read64_be() in commit bb12d44471 :(
+ MSVC warns when implicitly casting -1 to unsigned long.
-Daniel Stenberg (16 Jan 2015)
-- CURLOPT_SSL_VERIFYSTATUS.3: mention it is added in version 7.41.0
+- rtspd: fix MSVC level 4 warning
+
+ warning C4701: potentially uninitialized local variable 'req' used
-- curlver.h: next release is 7.41.0 due to the changes
+- winbuild: re-enable warning C4127 for curl tool
+
+ Disabled in cda19a345f6970e22fe8b7a808aeb8f086a21eac. It only needs to
+ be disabled for libcurl.
-- RELEASE-NOTES: mention the new OCSP stapling options, bump version
+- winbuild: build with warning level 4
+
+ This is consistent with 7bc64561a2e63ca93e4b0b31d350773ba80955c2, which
+ changed the warning level from 3 to 4 for the Visual Studio project
+ files. But disable the level 4 warning C4127 "conditional expression is
+ constant", as that one is issued by older versions of the Windows SDK
+ as well as curl itself under some circumstances.
+
+ Closes https://github.com/curl/curl/pull/1667
-- opts: add CURLOPT_SSL_VERIFYSTATUS* to docs/Makefile
+Jay Satiro (12 Jul 2017)
+- [Max Dymond brought this change]
-- help: add --cert-status to --help output
+ travis: install libidn2
+
+ Install libidn2 to increase test coverage (IDN tests)
+
+ Closes https://github.com/curl/curl/pull/1673
-- copyright years: after OCSP stapling changes
+Marcel Raad (12 Jul 2017)
+- travis: enable warnings also in release mode
+
+ ... to get warnings also on Linux/GCC and OSX/clang.
+
+ Closes https://github.com/curl/curl/pull/1666
-- [Alessandro Ghedini brought this change]
+Daniel Stenberg (12 Jul 2017)
+- [Max Dymond brought this change]
- curl: add --cert-status option
+ travis: install libssh2
- This enables the CURLOPT_SSL_VERIFYSTATUS functionality.
+ Install libssh2 to increase test coverage (SFTP, SCP)
-- [Alessandro Ghedini brought this change]
+Marcel Raad (12 Jul 2017)
+- system.h: include winsock2.h before windows.h
+
+ ... to avoid compiler warnings if the user doesn't want
+ WIN32_LEAN_AND_MEAN.
- nss: add support for the Certificate Status Request TLS extension
+- build: remove WIN32_LEAN_AND_MEAN from individual build systems
- Also known as "status_request" or OCSP stapling, defined in RFC6066 section 8.
+ It's defined for all build systems in curl_setup.h since commit
+ beb08481d01a07a8b10938b1078a5e298b1c2912. This caused macro
+ redefinition warnings in the configure builds.
- This requires NSS 3.15 or higher.
+ Closes https://github.com/curl/curl/pull/1677
-- [Alessandro Ghedini brought this change]
+Jay Satiro (11 Jul 2017)
+- ISSUE_TEMPLATE: Add a comment not to file security issues on github
- gtls: add support for the Certificate Status Request TLS extension
+Marcel Raad (11 Jul 2017)
+- curl_setup: always define WIN32_LEAN_AND_MEAN on Windows
- Also known as "status_request" or OCSP stapling, defined in RFC6066 section 8.
+ Make sure to always define WIN32_LEAN_AND_MEAN before including any
+ Windows headers to avoid pulling in unnecessary headers. This avoids
+ unnecessary macro clashes and compiler warnings.
- This requires GnuTLS 3.1.3 or higher to build, however it's recommended to use
- at least GnuTLS 3.3.11 since previous versions had a bug that caused the OCSP
- response verfication to fail even on valid responses.
-
-- [Alessandro Ghedini brought this change]
+ Ref: https://github.com/curl/curl/issues/1562
+ Closes https://github.com/curl/curl/pull/1672
- url: add CURLOPT_SSL_VERIFYSTATUS option
+Jay Satiro (11 Jul 2017)
+- strerror: Preserve Windows error code in some functions
- This option can be used to enable/disable certificate status verification using
- the "Certificate Status Request" TLS extension defined in RFC6066 section 8.
+ This is a follow-up to af02162 which removed (SET_)ERRNO macros. That
+ commit was an earlier draft that I committed by mistake, which was then
+ remedied by a5834e5 and e909de6, and now this commit. With this commit
+ there is now no difference between the current code and the changes that
+ were approved in the final draft.
- This also adds the CURLE_SSL_INVALIDCERTSTATUS error, to be used when the
- certificate status verification fails, and the Curl_ssl_cert_status_request()
- function, used to check whether the SSL backend supports the status_request
- extension.
-
-- TheArtOfHttpScripting: skip the date at the top, we have git
-
-- TheArtOfHttpScripting: phrase it TLS lib agnostic
-
-Steve Holme (16 Jan 2015)
-- TODO: Added some SMB ideas
+ Thanks-to: Max Dymond, Marcel Raad, Daniel Stenberg, Gisle Vanem
+ Ref: https://github.com/curl/curl/pull/1589
-- RELEASE-NOTES: Synced with 5f09947d28
+Marcel Raad (10 Jul 2017)
+- [Max Dymond brought this change]
-- build-openssl.bat: Added check for Perl installation
-
-- checksrc.bat: Better detection of Perl installation
-
-- curl_endian: Fixed build when 64-bit integers are not supported
+ tests: Fix up issues with errno in test files
- Bug: http://curl.haxx.se/mail/lib-2015-01/0094.html
- Reported-by: John E. Malmberg
+ Closes https://github.com/curl/curl/pull/1671
-Daniel Stenberg (15 Jan 2015)
-- [Yun SangHo brought this change]
+Daniel Stenberg (10 Jul 2017)
+- errno: fix non-windows builds after af0216251b94e7
- curl.h: remove extra space
+- [Ryan Winograd brought this change]
-- Curl_pretransfer: reset expected transfer sizes
+ make: fix docs build on OpenBSD
- Reported-by: Mohammad AlSaleh
- Bug: http://curl.haxx.se/mail/lib-2015-01/0065.html
+ Ref: #1591
-Marc Hoersken (12 Jan 2015)
-- curl_schannel.c: mark session as removed from cache if not freed
+Marcel Raad (10 Jul 2017)
+- ldap: fix MinGW compiler warning
- If the session is still used by active SSL/TLS connections, it
- cannot be closed yet. Thus we mark the session as not being cached
- any longer so that the reference counting mechanism in
- Curl_schannel_shutdown is used to close and free the session.
+ ldap_bind_s is marked as deprecated in w32api's winldap.h shipping with
+ the latest original MinGW, resulting in compiler warnings since commit
+ f0fe66f13c93d3d0af45d9fb1231c9164e0f9dc8. Fix this for the non-SSPI
+ case by using ldap_simple_bind_s again instead of ldap_bind_s with
+ LDAP_AUTH_SIMPLE.
- Reported-by: Jean-Francois Durand
+ Closes https://github.com/curl/curl/pull/1664
-Steve Holme (9 Jan 2015)
-- RELEASE-NOTES: Synced with d21b66835f
-
-Guenter Knauf (9 Jan 2015)
-- Merge pull request #134 from vszakats/mingw-m64
+- curl-compilers.m4: disable warning spam with Cygwin's clang
- add -m64 CFLAGS when targeting mingw64, add -m32/-m64 to LDFLAGS
-
-- Merge pull request #136 from vszakats/mingw-allow-custom-cflags
+ When building with Cygwin or MinGW, libtool uses a wrapper executable
+ instead of a wrapper script [1], which is written in C and throws
+ missing-variable-declarations warnings. Don't enable these warnings on
+ Cygwin and MinGW in order to avoid warnings for every executable built,
+ which spams the test suite output when using Cygwin's clang.
- mingw build: allow to pass custom CFLAGS
-
-Daniel Stenberg (9 Jan 2015)
-- NSS: fix compiler error when built http2-enabled
+ [1] https://www.gnu.org/software/libtool/manual/html_node/Wrapper-executables.html
+
+ Closes https://github.com/curl/curl/pull/1665
-Steve Holme (9 Jan 2015)
-- gssapi: Remove need for duplicated GSS_C_NT_HOSTBASED_SERVICE definitions
+Jay Satiro (10 Jul 2017)
+- curl_setup_once: Remove ERRNO/SET_ERRNO macros
+
+ Prior to this change (SET_)ERRNO mapped to GetLastError/SetLastError
+ for Win32 and regular errno otherwise.
+
+ I reviewed the code and found no justifiable reason for conflating errno
+ on WIN32 with GetLastError/SetLastError. All Win32 CRTs support errno,
+ and any Win32 multithreaded CRT supports thread-local errno.
- Better code reuse and consistency in calls to gss_import_name().
+ Fixes https://github.com/curl/curl/issues/895
+ Closes https://github.com/curl/curl/pull/1589
-Viktor Szakats (9 Jan 2015)
-- mingw build: allow to pass custom CFLAGS
+- tool_getparam: fix potentially uninitialized err
-Daniel Stenberg (8 Jan 2015)
-- FTP: if EPSV fails on IPV6 connections, bail out
+Marcel Raad (9 Jul 2017)
+- smb: rename variable to fix shadowing warning
- ... instead of trying PASV, since PASV can't work with IPv6.
+ GCC 4.6.3 on travis complains:
+ smb.c: In function ‘get_posix_time’:
+ smb.c:725:13: error: declaration of ‘time’ shadows a global declaration
+ [-Werror=shadow]
- Reported-by: Vojtěch Král
+ Fix this by renaming the variable.
-- FTP: fix IPv6 host using link-local address
+- tool_cb_wrt: fix variable shadowing warning
- ... and make sure we can connect the data connection to a host name that
- is longer than 48 bytes.
+ GCC 4.4 complains:
+ tool_cb_wrt.c:81: error: declaration of ‘isatty’ shadows a global
+ declaration
+ /usr/include/unistd.h:782: error: shadowed declaration is here
- Also simplifies the code somewhat by re-using the original host name
- more, as it is likely still in the DNS cache.
+ Fix this by renaming the variable.
- Original-Patch-by: Vojtěch Král
- Bug: http://curl.haxx.se/bug/view.cgi?id=1468
+ Closes https://github.com/curl/curl/pull/1661
-Steve Holme (8 Jan 2015)
-- [Sam Schanken brought this change]
+Daniel Stenberg (8 Jul 2017)
+- RELEASE-NOTES: synced with be2c999b8
- winbuild: Added option to build with c-ares
-
- Added support for a WITH_CARES option to be used when invoking nmake
- via Makefile.vc. This option enables linking against both the DLL and
- static versions of the c-ares libraries, as well as the debug and
- release varients, depending on the value of DEBUG. The USE_ARES
- preprocessor symbol is also defined.
+- travis: install stunnel
-Guenter Knauf (8 Jan 2015)
-- NetWare build: added TLS-SRP enabled build.
+- valgrind.supp: supress OpenSSL false positive seen on travis
-Steve Holme (8 Jan 2015)
-- sasl_gssapi: Fixed build on NetBSD with built-in GSS-API
+- travis: detect and use valgrind for normal builds
- Bug: http://curl.haxx.se/bug/view.cgi?id=1469
- Reported-by: Thomas Klausner
+ Closes #1653
-Viktor Szakats (8 Jan 2015)
-- add -m64 clags when targeting mingw64, add -m32/-m64 to LDFLAGS
+- travis: add SMB, DICT, TELNET torture to coverage test
-Daniel Stenberg (8 Jan 2015)
-- bump: start working towards 7.40.1
+- [Paul Harris brought this change]
-- THANKS: 14 new contributors from the 7.40.0 release notes
+ cmake: offer CMAKE_DEBUG_POSTFIX when building with MSVC
+
+ Removes BUILD_RELEASE_DEBUG_DIRS since it wasn't used anywhere.
+
+ Closes #1649
-Version 7.40.0 (7 Jan 2015)
+- CURLOPT_POSTFIELDS.3: explain the 100-continue magic better
-Daniel Stenberg (7 Jan 2015)
-- RELEASE-NOTES: version 7.40.0
+- [Max Dymond brought this change]
-- darwinssl: fix session ID keys to only reuse identical sessions
+ test1452: add telnet negotiation
- ...to avoid a session ID getting cached without certificate checking and
- then after a subsequent _enabling_ of the check libcurl could still
- re-use the session done without cert checks.
+ Add a basic telnet server for negotiating some telnet options before
+ echoing back any data that's sent to it.
- Bug: http://curl.haxx.se/docs/adv_20150108A.html
- Reported-by: Marc Hesse
+ Closes #1645
-- tests: make sure CRLFs can't be used in URLs passed to proxy
+- travis: do more tests in the coverage run
- Bug: http://curl.haxx.se/docs/adv_20150108B.html
+ I added a selection of torture and event tests that run "fast enough"
-- url-parsing: reject CRLFs within URLs
+- curl_easy_escape.3: mention the (lack of) encoding
- Bug: http://curl.haxx.se/docs/adv_20150108B.html
- Reported-by: Andrey Labunets
-
-Steve Holme (7 Jan 2015)
-- ldap: Convert attribute output to UTF-8 when Unicode
-
-- ldap: Convert DN output to UTF-8 when Unicode
+ Fixes #1612
+ Reported-by: Jeroen Ooms
-Daniel Stenberg (7 Jan 2015)
-- hostip: remove 'stale' argument from Curl_fetch_addr proto
-
- Also, remove the log output of the resolved name is NOT in the cache in
- the spirit of only telling when something is actually happening.
+- [Gisle Vanem brought this change]
-Steve Holme (7 Jan 2015)
-- ldap/imap: Fixed spelling mistake in comments and variable names
+ memdebug: don't setbuf() if the file open failed
- Reported-by: Michael Osipov
+ Bug: https://github.com/curl/curl/issues/828#issuecomment-313475151
-Daniel Stenberg (7 Jan 2015)
-- RELEASE-NOTES: updated with ./contributors.sh output
+- appveyor: enable CURL_WERROR on all builds
-Dan Fandrich (5 Jan 2015)
-- curl_multibyte.h: Eliminated some trailing whitespace
+- cmake: add CURL_WERROR for enabling "warning as errors"
-Steve Holme (4 Jan 2015)
-- RELEASE-NOTES: Synced with ea93252ef1
+- [Hannes Magnusson brought this change]
-- ldap: Fixed Unicode usage for all Win32 builds
+ cmake: remove spurious "-l" from linker flags
- Otherwise, the fixes in the previous commits would only be applicable
- to IDN and SSPI based builds and not others such as OpenSSL with LDAP
- enabled.
-
-- ldap: Fixed memory leak from commit efb64fdf80
+ Fixes #1552
-- ldap: Fix memory leak from commit 3a805c5cc1
+- test506: skip if threaded-resolver
-- ldap: Fixed attribute variable warnings when Unicode is enabled
+- runtests: support "threaded-resolver" as a feature
- Use 'TCHAR *' for local attribute variable rather than 'char *'.
+ ... to let tests require it or skip if present
-- ldap: Fixed DN variable warnings when Unicode is enabled
-
- Use 'TCHAR *' for local DN variable rather than 'char *'.
+- asyn-thread.c: fix unused variable warnings on macOS
-- ldap: Remove the unescape_elements() function
+- http: s/TINY_INITIAL_POST_SIZE/EXPECT_100_THRESHOLD
- Due to the recent modifications this function is no longer used.
+ Make the name reflect its use better, and add a short comment describing
+ what it's for.
-- ldap.c: Fixed compilation warning
+- cmake: if inet_pton is used, bump _WIN32_WINNT
- ldap.c:98: warning: extra tokens at end of #endif directive
-
-- ldap: Fixed support for Unicode filter in Win32 search call
-
-- ldap.c: Fixed compilation warning
+ ... and make sure inet_pton is always checked for when *not* using Windows,
+ which is a regression from 4fc6ebe18.
- ldap.c:802: warning: comparison between signed and unsigned integer
- expressions
+ Idea-by: Sergei Nikulov
-- ldap: Fixed support for Unicode attributes in Win32 search call
+- select.h: avoid macro redefinition harder
+
+ ... by checking the POLLIN define, as the header file checks don't work
+ on Windows.
-- ldap: Fixed memory leak from commit efb64fdf80
+- inet_pton: fix include on windows to get prototype
- The unescapped DN was not freed after a successful character conversion.
+ inet_pton() exists on Windows and gets used by our cmake builds. Make
+ sure the correct header file is included to avoid compiler warnings.
+
+ Closes #1639
-- ldap.c: Fixed compilation error
+- TODO: 1.10 auto-detect proxy
- ldap.c:738: error: macro "LDAP_TRACE" passed 2 arguments, but takes
- just 1
+ Closes #1572
+
+- TODO: HTTP proxy CONNECT is non-blocking now
-- ldap.c: Fixed compilation warning
+- cmake: fix send/recv argument scanner for windows
- ldap.c:89: warning: extra tokens at end of #endif directive
+ ... by simply trying the Windows argument types first.
+
+ Fixes #1640
-- ldap: Fixed support for Unicode DN in Win32 search call
+- RELEASE-NOTES: synced with 596cfb6c0
-- ldap: Fixed Unicode user and password in Win32 bind calls
+- [Gisle Vanem brought this change]
-- ldap: Fixed Unicode host name in Win32 initialisation calls
+ smb: add support for CURLOPT_FILETIME
+
+ Bug: https://curl.haxx.se/mail/lib-2017-07/0005.html
+
+ Closes #1643
-- ldap: Use host.dispname for infof() connection failure messages
+- travis: install nghttp2 on linux builds
- As host.name may be encoded use dispname for infof() failure messages.
+ Closes #1642
-- ldap: Prefer 'CURLcode result' for curl result codes
+- [Gisle Vanem brought this change]
-- ldap: Pass write length in all Curl_client_write() calls
+ smb: fix build for djgpp/MSDOS
- As we get the length for the DN and attribute variables, and we know
- the length for the line terminator, pass the length values rather than
- zero as this will save Curl_client_write() from having to perform an
- additional strlen() call.
+ bug: https://curl.haxx.se/mail/lib-2017-07/0005.html
-- ldap: Fixed attribute memory leaks on failed client write
+- configure: try ldap/lber in reversed order first
- Fixed memory leaks from commit 086ad79970 as was noted in the commit
- comments.
-
-- ldap: Fixed DN memory leaks on failed client write
+ When scanning for which LDAP libraries to use, try the -lldap -llber
+ combination before the reversed order since it has a greater chance of
+ working when linking with libcurl statically.
- Fixed memory leaks from commit 086ad79970 as was noted in the commit
- comments.
+ Fixes #1619
+ Closes #1634
+ Reported-by: David E. Narváez
-- curl_ntlm_core.c: Fixed compilation warning from commit 1cb17b2a5d
+- configure: remove checks for 5 functions never used
- curl_ntlm_core.c:146: warning: passing 'DES_cblock' (aka 'unsigned char
- [8]') to parameter of type 'char *' converts
- between pointers to integer types with different
- sign
-
-- ntlm: Use extend_key_56_to_64() for all cryptography engines
+ fork, getprotobyname, inet_addr, perror, uname
- Rather than duplicate the code in setup_des_key() for OpenSSL and in
- extend_key_56_to_64() for non-OpenSSL based crypto engines, as it is
- the same, use extend_key_56_to_64() for all engines.
+ closes #1638
-- RELEASE-NOTES: Synced with 34f0bd110f
+- dist: add SMB python deps into the tarball
-- curl_ntlm_core.c: Fixed compilation warning
-
- curl_ntlm_core.c:458: warning: 'ascii_uppercase_to_unicode_le' defined
- but not used
+- [Max Dymond brought this change]
-- endian: Fixed bit-shift in 64-bit integer read functions
+ test1451: add SMB support to the testbed
- From commit 43792592ca and 4bb5a351b2.
+ Add test 1451 which does some very basic SMB testing using the impacket
+ SMB server.
- Reported-by: Michael Osipov
+ Closes #1630
-- smb: Use endian functions for reading NBT and message size values
+- [Max Dymond brought this change]
-- endian: Added big endian read functions
-
-- endian: Added 64-bit integer read function
-
-- COPYING: Bumped copyright year to 2015
+ test: add impacket for SMB testing
+
+ Import impacket 0.9.15 for use in SMB testing. This was generated by
+ doing "pip2.7 install -t . impacket"
+
+ Unnecessary files for current testing were deleted.
-- version: Bump copyright year to 2015
+- travis.yml: use --enable-werror on debug builds
+
+ ... to better detect and fault on compiler warnings/errors
+
+ Closes #1637
-- smb.c: Fixed compilation warnings
+- tool_sleep: typecast to avoid macos compiler warning
- smb.c:780: warning: passing 'char *' to parameter of type 'unsigned
- char *' converts between pointers to integer types with
- different sign
- smb.c:781: warning: passing 'char *' to parameter of type 'unsigned
- char *' converts between pointers to integer types with
- different sign
- smb.c:804: warning: passing 'char *' to parameter of type 'unsigned
- char *' converts between pointers to integer types with
- different sign
+ tool_sleep.c:54:24: error: implicit conversion loses integer precision:
+ 'long' to '__darwin_suseconds_t' (aka 'int')
+ [-Werror,-Wshorten-64-to-32]
-- smb: Use endian functions for reading length and offset values
+- [Martin Kepplinger brought this change]
-- endian: Added 16-bit integer write function
+ timeval.c: Use long long constant type for timeval assignment
+
+ On a 64 bit host, sparse says:
+
+ timeval.c:148:15: warning: constant 0x7fffffffffffffff is so big it is long
+ timeval.c:149:12: warning: constant 0x7fffffffffffffff is so big it is long
+
+ so let's use long long constant types in order to prevent undesired overflow
+ failures.
+
+ Bug: https://curl.haxx.se/mail/lib-2017-07/0003.html
+
+ Closes #1636
+
+ Signed-off-by: Martin Kepplinger <martink@posteo.de>
-- endian: Fixed Linux compilation issues
+- url: make the original string get used on subsequent transfers
- Having files named endian.[c|h] seemed to cause issues under Linux so
- renamed them both to have the curl_ prefix in the filenames.
+ ... since CURLOPT_URL should follow the same rules as other options:
+ they remain set until changed or cleared.
+
+ Added test 1551 to verify.
+
+ Fixes #1631
+ Closes #1632
+ Reported-by: Pavel Rochnyak
-- [Julien Nabet brought this change]
+- [Johannes Schindelin brought this change]
- lib1900.c: Fixed cppcheck error
+ gtls: fix build when sizeof(long) < sizeof(void *)
- lib1900.c:182: (style) Array index 'handlenum' is used before limits
- check
+ - Change gnutls pointer/int macros to pointer/curl_socket_t.
+ Prior to this change they used long type as well.
- Bug: https://github.com/bagder/curl/pull/133
-
-- endian: Added standard function descriptions
+ The size of the `long` data type can be shorter than that of pointer
+ types. This is the case most notably on Windows.
+
+ If C99 were acceptable, we could simply use `intptr_t` here. But we
+ want to retain C89 compatibility.
+
+ Simply use the trick of performing pointer arithmetic with the NULL
+ pointer: to convert an integer `i` to a pointer, simply take the
+ address of the `i`th element of a hypothetical character array
+ starting at address NULL. To convert back, simply cast the pointer
+ difference.
+
+ Thanks to Jay Satiro for the initial modification to use curl_socket_t
+ instead of int/long.
+
+ Closes #1617
+
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-- endian: Renamed functions for curl API naming convention
+- [Ryan Winograd brought this change]
-- endian: Moved write functions to new module
+ unit1399: fix integer overflow
+
+ Bug: #1616
+ Closes #1633
-- endian: Moved read functions to new module
+- [Per Malmberg brought this change]
-- endian: Introduced endian module
+ cmake: Added compatibility options for older Windows versions
+
+ CURL_STATIC_CRT and ENABLE_INET_PTON
- To allow the little endian functions, currently used in two of the NTLM
- source files, to be used by other modules such as the SMB module.
+ Closes #1621
-- sepheaders.c: Applied curl oding standards
+- unit1399: add logging to time comparison
+
+ ... to enable tracking down why autobuilds fail on this
+
+ Bug: #1616
-- [Julien Nabet brought this change]
+- make: build the docs subdir only from within src
+
+ ... and don't build at all in include
+
+ Prompted-by-work-by: Simon Warta
+ Ref: #1590
+ Closes #1591
- sepheaders.c: Fixed resource leak on failure
+- [Max Dymond brought this change]
-- vtls: Use '(void) arg' for unused parameters
+ test1450: fix up DICT server in torture mode
- Prefer void for unused parameters, rather than assigning an argument to
- itself as a) unintelligent compilers won't optimize it out, b) it can't
- be used for const parameters, c) it will cause compilation warnings for
- clang with -Wself-assign and d) is inconsistent with other areas of the
- curl source code.
-
-- smb.c: Fixed compilation warning
+ As per https://github.com/curl/curl/pull/1615, the DICT server is a
+ little spammy in torture mode due to the sockets being torn down
+ unexpectedly. Fix this by adding some error handling to the handling
+ function.
- smb.c:586: warning: conversion to 'short unsigned int' from 'int' may
- alter its value
+ Closes #1629
-- [Bill Nagel brought this change]
+- [Max Dymond brought this change]
- smb: Use the connection's upload buffer
+ test1450: add simple testing for DICT
+
+ Add a new server which provides a DICT interface. This is intended to
+ begin coverage testing for lib/dict.c
- Use the connection's upload buffer instead of allocating our own send
- buffer.
+ Closes #1615
-- RELEASE-NOTES: Synced with 1933f9d33c
+- [Dan Fandrich brought this change]
-- schannel: Moved the ISC return flag definitions to the SSPI module
+ test1521: fix out-of-tree builds, broken with 467da3af
- Moved our Initialize Security Context return attribute definitions to
- the SSPI module, as a) these can be used by other SSPI based providers
- and b) the ISC required attributes are defined there.
-
-- [Bill Nagel brought this change]
+ The test.h file is no longer in the same directory as the source file,
+ so that directory needs to be added to the include path.
+
+ Fixes #1627
+ Closes #1628
- smb: Close the connection after a failed client write
+- [Max Dymond brought this change]
-- darwinssl: Fixed compilation warning
+ http2: handle PING frames
- vtls.c:683:43: warning: unused parameter 'data'
-
-- sockfilt.c: Fixed compilation warnings
+ Add a connection check function to HTTP2 based off RTSP. This causes
+ PINGs to be handled the next time the connection is reused.
- sockfilt.c:288: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
- sockfilt.c:291: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
- sockfilt.c:323: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
- sockfilt.c:326: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
+ Closes #1521
+
+- [Max Dymond brought this change]
-- test1509: Fixed compilation warning
+ handler: refactor connection checking
- lib1509.c:93:18: warning: conversion to 'long int' from 'size_t' may
- alter its value
+ Add a new type of callback to Curl_handler which performs checks on
+ the connection. Alter RTSP so that it uses this callback to do its
+ own check on connection health.
-- test556: Fixed compilation warning
+- [Dmitry Kostjuchenko brought this change]
+
+ openssl: improve fallback seed of PRNG with a time based hash
- lib556.c:90: warning: conversion to 'unsigned int' from 'size_t' may
- alter its value
+ Fixes #1620
-- sasl_gssapi: Fixed use of dummy username with real username
+- [Ryan Winograd brought this change]
-- vtls: Fixed compilation warning and an ignored return code
+ progress: prevent resetting t_starttransfer
- curl_schannel.h:123: warning: right-hand operand of comma expression
- has no effect
+ Prevent `Curl_pgrsTime` from modifying `t_starttransfer` when invoked
+ with `TIMER_STARTTRANSFER` more than once during a single request.
- Some instances of the curlssl_close_all() function were declared with a
- void return type whilst others as int. The schannel version returned
- CURLE_NOT_BUILT_IN and others simply returned zero, but in all cases the
- return code was ignored by the calling function Curl_ssl_close_all().
+ When a redirect occurs, this is considered a new request and
+ `t_starttransfer` can be updated to reflect the `t_starttransfer` time
+ of the redirect request.
- For the time being and to keep the internal API consistent, changed all
- declarations to use a void return type.
+ Closes #1616
- To reduce code we might want to consider removing the unimplemented
- versions and use a void #define like schannel does.
-
-Daniel Stenberg (28 Dec 2014)
-- TODO: 2.3 Better support for same name resolves
+ Bug: https://github.com/curl/curl/pull/1602#issuecomment-310267370
-Steve Holme (28 Dec 2014)
-- test1520: Fixed initial teething problems
+- curl_strequal.3: fix typo in SYNOPSIS
- * Missing initialisation of upload status caused a seg fault
- * Missing data termination caused corrupt data to be uploaded
- * Data verification should be performed in <upload> element
- * Added missing recipient list cleanup
+ Reported-by: Jesse Chisholm
+
+ Fixes #1623
-- test1520: Fixed compilation errors
+- RELEASE-NOTES: synced with ce2c3ebda
-- tests: Added test for bug #1456
+Kamil Dudka (28 Jun 2017)
+- curl --socks5-{basic,gssapi}: control socks5 auth
+
+ Closes https://github.com/curl/curl/pull/1454
-- checksrc.bat: Fixed a problem opening files with spaces in the filename
+- CURLOPT_SOCKS5_AUTH: allowed methods for SOCKS5 proxy auth
+
+ If libcurl was built with GSS-API support, it unconditionally advertised
+ GSS-API authentication while connecting to a SOCKS5 proxy. This caused
+ problems in environments with improperly configured Kerberos: a stock
+ libcurl failed to connect, despite libcurl built without GSS-API
+ connected fine using username and password.
+
+ This commit introduces the CURLOPT_SOCKS5_AUTH option to control the
+ allowed methods for SOCKS5 authentication at run time.
+
+ Note that a new option was preferred over reusing CURLOPT_PROXYAUTH
+ for compatibility reasons because the set of authentication methods
+ allowed by default was different for HTTP and SOCKS5 proxies.
+
+ Bug: https://curl.haxx.se/mail/lib-2017-01/0005.html
+ Closes https://github.com/curl/curl/pull/1454
-- openldap: Prefer use of 'CURLcode result'
+- socks: deduplicate the code for auth request
-- openldap: Use 'LDAPMessage *msg' for messages
+- socks: use proxy_user instead of proxy_name
- This frees up the 'result' variable for CURLcode based result codes.
+ ... to make it obvious what the data is used for
-- nss: Don't ignore Curl_extract_certinfo() OOM failure
-
-- nss: Don't ignore Curl_ssl_init_certinfo() OOM failure
+Daniel Stenberg (27 Jun 2017)
+- libtest/make: generate lib1521.c
+
+ ... instead of having the generated code checked in. This saves space in
+ the tarball but primarily automatically adapts to newly added options.
+
+ Closes #1614
-- nss: Use 'CURLcode result' for curl result codes
+Jay Satiro (26 Jun 2017)
+- tool_getparam: fix memory leak on test 1147 OOM (torture tests)
- ...and don't use CURLE_OK in failure/success comparisons.
+ Bug: https://github.com/curl/curl/pull/1486#issuecomment-310926872
+ Reported-by: Dan Fandrich
-- getinfo: Code style policing
+Dan Fandrich (25 Jun 2017)
+- test1537: fixed memory leak on OOM
-- getinfo: Use 'CURLcode result' for curl result codes
+Marcel Raad (25 Jun 2017)
+- test1521: fix compiler warnings
+
+ The integer literal 3123123123 doesn't fit into a 32-bit signed
+ integer, so GCC with 32-bit long warns in C90 mode:
+ this decimal constant is unsigned only in ISO C90 [enabled by default]
+ Fix this by using ULONG_MAX, which should fit in any curl_off_t and has
+ the correct suffix to not issue any warnings.
+ Also adds the missing CURLOPT_REQUEST_TARGET from commit
+ 9b167fd090f596eac828817d48c247eeae53407f.
+
+ Closes https://github.com/curl/curl/pull/1611
-- darwinssl: Use 'CURLcode result' for curl result codes
+Daniel Stenberg (24 Jun 2017)
+- curl/system.h: add check for XTENSA for 32bit gcc
+
+ Reported-by: Neil Kolban
+ Fixes: 1598
-- polarssl: Use 'CURLcode result' for curl result codes
+- [Henrik S. Gaßmann brought this change]
-- docs: Updated following the addition of SASL GSSAPI via GSS-API libraries
+ winbuild: fix boringssl build
- As this feature has been implemented for 7.40.0.
-
-- asiohiper.cpp: No need to initialise members of ConnInfo
+ Compile with `WIN32_LEAN_AND_MEAN` which prevents `windows.h` from
+ including too much clutter including `wincrypt.h` which in turn contains
+ some preprocessor macros that clash with boringssl symbols.
- ...as calloc() automatically clears the area of memory with zeros.
-
-- asiohiper.cpp: Updated for curl coding standards
+ Detect boringssl by checking the existance of `is_boringssl.h` and set
+ the corresponding `HAVE_BORINGSSL` for compilation which is used in
+ `ldap.c` to undefine the evil macros.
- ...with the exception of the start of block statement curly brackets.
+ Closes #1610
-- code/docs: Use correct case for IPv4 and IPv6
+- progress: progress.timespent needs to be us
- For consistency, as we seem to have a bit of a mixed bag, changed all
- instances of ipv4 and ipv6 in comments and documentations to use the
- correct case.
+ follow-up to 64ed44a815e4e to fix test 500 failures
-- runtests: Fixed detection of Unix Sockets feature
+Marcel Raad (24 Jun 2017)
+- curl-compilers.m4: fix unknown-warning-option on Apple clang
+
+ Since 5598b0bd63f690c151074494ce47ef872f004ab4, clang -v is used to
+ detect the clang version. The version number was expected to come after
+ the word "version". For Apple clang, this doesn't work as it has its
+ own versioning scheme.
+ The version number is now first searched after the string
+ "based on LLVM". This works for Apple clang before version 7, and also
+ for e.g. Ubuntu's clang up to version 3.7. If it's not found and the
+ version string contains "Apple LLVM version", clang version 3.7 is
+ assumed, which is the version that comes with Xcode 7. Otherwise, the
+ version number is still expected after the word "version", which works
+ for very old Apple clang versions.
- ...following change in curl --version output.
+ Ref: https://trac.macports.org/wiki/XcodeVersionInfo
+ Fixes https://github.com/curl/curl/issues/1606
+ Closes https://github.com/curl/curl/pull/1607
-- code/docs: Use Unix rather than UNIX to avoid use of the trademark
+Daniel Stenberg (24 Jun 2017)
+- progress: fix "time spent", broke in adef394ac
+
+- CURLINFO_REDIRECT_URL.3: mention the CURLOPT_MAXREDIRS case
- Use Unix when generically writing about Unix based systems as UNIX is
- the trademark and should only be used in a particular product's name.
+ ... supported since 7.54.1
-- ip2ip.c: Fixed compilation warning when IPv6 Scope ID not supported
+- maketgz: switch to -6e for xz
- if2ip.c:119: warning: unused parameter 'remote_scope_id'
+ To reduce the memory requirement for decompress, and still do almost as
+ good compression as with -9e.
- ...and some minor code style policing in the same function.
+ Pointed-out-by: Dan Fandrich
-- vtls: Don't set cert info count until memory allocation is successful
-
- Otherwise Curl_ssl_init_certinfo() can fail and set the num_of_certs
- member variable to the requested count, which could then be used
- incorrectly as libcurl closes down.
+- libtest/Makefile: remove unused lib1541 variables
-- vtls: Use CURLcode for Curl_ssl_init_certinfo() return type
+- CONTRIBUTE.md: mention the out-of-tree build test too
+
+- maketgz: switch to xz instead of lzma
- The return type for this function was 0 on success and 1 on error. This
- was then examined by the calling functions and, in most cases, used to
- return CURLE_OUT_OF_MEMORY.
+ The compressed output size seems to be a tad bit smaller, but generally
+ xz seems more preferred these days and is used directly by for example
+ gentoo instead of bz2.
- Instead use CURLcode for the return type and return the out of memory
- error directly, propagating it up the call stack.
-
-- configure: Use camel case for UNIX sockets feature output
+ "Users of LZMA Utils should move to XZ Utils" =>
+ https://tukaani.org/lzma/
- To match the curl --version output.
+ Closes #1604
-Marc Hoersken (26 Dec 2014)
-- sockfilt.c: Reduce the number of individual memory allocations
+- --request-target: instead of --strip-path-slash
- Merge multiple internal arrays into one, even if some variables
- will not not be used. They are all created with the number of
- file descriptors as their size.
+ ... and CURLOPT_REQUEST_TARGET instead of CURLOPT_STRIP_PATH_SLASH.
- Also fix possible thread handle leak in CloseHandle-loop.
-
-- sockfilt.c: Replace 100ms sleep with thread throttle
+ This option instead provides the full "alternative" target to use in the
+ request, instead of extracting the path from the URL.
+
+ Test 1298 and 1299 updated accordingly.
- Improves performance of test cases 574 and 575 by 50%.
+ Idea-by: Evert Pot
+ Suggestion: https://daniel.haxx.se/blog/2017/06/19/options-with-curl/comment-page-1/#comment-18373
- A value of zero causes the thread to relinquish the remainder
- of its time slice to any other thread of equal priority that is
- ready to run. If there are no other threads of equal priority
- ready to run, the function returns immediately, and the thread
- continues execution.
+ Closes #1593
+
+Marcel Raad (21 Jun 2017)
+- lib1521: fix missing-variable-declarations clang warnings
- http://msdn.microsoft.com/library/windows/desktop/ms686307.aspx
+ Declare TU-local variables static.
-Steve Holme (25 Dec 2014)
-- tool_help: Use camel case for UNIX sockets feature output
+- travis: enable typecheck-gcc warnings
+
+ - switch debug and release configurations so that we get an optimized
+ build with GCC 4.3+ as required by typecheck-gcc
+ - enable warnings-as-errors for release builds
+ (which have warnings disabled)
- In line with the other features listed in the --version output,
- capitalise the UNIX socket feature.
+ Closes https://github.com/curl/curl/pull/1595
-- vtls: Use bool for Curl_ssl_getsessionid() return type
+- typecheck-gcc: add support for CURLINFO_OFF_T
- The return type of this function is a boolean value, and even uses a
- bool internally, so use bool in the function declaration as well as
- the variables that store the return value, to avoid any confusion.
+ typecheck-gcc expected curl_socket_t instead of curl_off_t arguments
+ for CURLINFO_OFF_T. Detected by test1521, unfortunately only when run
+ locally.
+
+ Closes https://github.com/curl/curl/pull/1592
-- schannel: Minor code style policing for casts
+Daniel Stenberg (21 Jun 2017)
+- [Simon Warta brought this change]
-- schannel: Prefer 'CURLcode result' for curl result codes
+ ci: whitelist branches to avoid testing feature branches twice
-- cyassl: Prefer 'CURLcode result' for curl result codes
+- [Gisle Vanem brought this change]
-- tool_xattr: Use 'CURLcode result' for curl result codes
+ lib: fix the djgpp build
+
+ Bug: https://github.com/curl/curl/commit/73a2fcea0b4adea6ba342cd7ed1149782c214ae3#commitcomment-22655993
-- curl_ntlm_core.c: Fixed compilation warnings
+Marcel Raad (20 Jun 2017)
+- if2ip: fix compiler warning in ISO C90 mode
- curl_ntlm_core.c:301: warning: pointer targets in passing argument 2 of
- 'CryptImportKey' differ in signedness
- curl_ntlm_core.c:310: warning: passing argument 6 of 'CryptEncrypt' from
- incompatible pointer type
- curl_ntlm_core.c:540: warning: passing argument 4 of 'CryptGetHashParam'
- from incompatible pointer type
+ remote_scope_id is only used when both HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID
+ and ENABLE_IPV6 are defined instead of only one of them.
-- RELEASE-NOTES: Synced with 8830df8b66
+Daniel Stenberg (20 Jun 2017)
+- travis: do the distcheck test build out-of-tree as well
-- gtls: Use preferred 'CURLcode result'
+- http: add --strip-path-slash and CURLOPT_STRIP_PATH_SLASH
+
+ ... to enable sending "OPTIONS *" which wasn't possible previously.
+
+ This option currently only works for HTTP.
+
+ Added test cases 1298 + 1299 to verify
+
+ Fixes #1280
+ Closes #1462
-- openldap: Use standard naming for setup connection function
+- test1521: test getinfo's OFF_T types too
- Renamed ldap_setup() to ldap_setup_connection() to follow more widely
- used function naming.
+ Closes #1588
-- rtmp: Use standard naming for setup connection function
+- lib1521: add curl_easy_getinfo calls to the test set
- Renamed rtmp_setup() to rtmp_setup_connection() to follow more widely
- used function naming.
+ Also added return value checks to make sure no unexpected return codes
+ are used.
+
+- [Simon Warta brought this change]
-- smb: Use standard naming for setup connection function
+ automake: use $(MKHELP) variable instead if constant mkhelp.pl
- Renamed smb_setup() to smb_setup_connection() to follow more widely
- used function naming.
+ this improves symmetry with the rule above
-- config-win32.h: Fixed line length > 79 columns
+- [Simon Warta brought this change]
-- openssl: Prefer we don't use NULL in comparisons
+ mkhelp.pl: fix script name in usage text
-- build: Removed WIN32 definition from the Visual Studio projects
-
- As this pre-processor definition is defined in curl_setup.h there is no
- need to include it in the Visual Studio project files.
+- RELEASE-NOTES: synced with 3b80d3ca4
-- build: Removed WIN64 definition from the libcurl Visual Studio projects
+- getinfo: return sizes as curl_off_t
+
+ This change introduces new alternatives for the existing six
+ curl_easy_getinfo() options that return sizes or speeds as doubles. The
+ new versions are named like the old ones but with an appended '_T':
- Removed the WIN64 pre-processor definition from the libcurl project
- files as:
+ CURLINFO_CONTENT_LENGTH_DOWNLOAD_T
+ CURLINFO_CONTENT_LENGTH_UPLOAD_T
+ CURLINFO_SIZE_DOWNLOAD_T
+ CURLINFO_SIZE_UPLOAD_T
+ CURLINFO_SPEED_DOWNLOAD_T
+ CURLINFO_SPEED_UPLOAD_T
- * WIN64 is not used in our source code
- * The curl projects files don't define it
- * It isn't required by or used in the platform SDK
- * For backwards compatability curl_setup.h defines WIN32
- * The compiler automatically defines _WIN64 for x64 builds
+ Closes #1511
+
+- PIPELINING_SERVER_BL: cleanup the internal list use
- Historically Visual Studio projects have defined WIN32, in addition to
- the compiler defined _WIN32 definition, and I had incorrectly changed
- that to WIN64 for the x64 libcurl builds but not in the curl projects.
+ The list was freed incorrectly since the llist refactor of
+ cbae73e1dd959. Added test 1550 to verify that it works and avoid future
+ regressions.
- As such, it is questionable whether this should be defined or not. For
- more information see the following cache of a discussion that took
- place on the microsoft.public.vc.mfc newsgroup:
+ Reported-by: Pascal Terjan
- http://www.tech-archive.net/Archive/VC/microsoft.public.vc.mfc/2008-06/msg00074.html
+ Fixes #1584
+ Closes #1585
-- openssl.c Fix for compilation errors with older versions of OpenSSL
+- http2: fix OOM crash
- openssl.c:1408: error: 'TLS1_1_VERSION' undeclared
- openssl.c:1411: error: 'TLS1_2_VERSION' undeclared
+ torture mode with test 1021 found it
-Daniel Stenberg (22 Dec 2014)
-- [John Malmberg brought this change]
+- CURLOPT_PREQUOTE.3: spellfix man page reference
- Fix comment edit in vms/backup_gnv_curl_src.com
+Marcel Raad (18 Jun 2017)
+- http_proxy: fix build with http and proxy
- packages/vms/backup_gnv_curl_src.com: Originally copied from Bash port.
+ After deff7de0eb0e22d2d142b96b9cc84cd8db5d2a48, the build without
+ CURL_DISABLE_PROXY and CURL_DISABLE_HTTP was failing because of missing
+ includes.
-- curl: show size of inhibited data when using -v
+- http_proxy: fix compiler warning
- To offer some more info and yet it doesn't use more lines.
-
-- openssl: fix SSL/TLS versions in verbose output
-
-- openssl: make it compile against openssl 1.1.0-DEV master branch
-
-Marc Hoersken (22 Dec 2014)
-- sshserver.pl: clarify and streamline variable names
+ With CURL_DISABLE_PROXY or CURL_DISABLE_HTTP, GCC complained about a
+ missing prototype for Curl_connect_free.
-Daniel Stenberg (21 Dec 2014)
-- openssl: warn for SRP set if SSLv3 is used, not for TLS version
-
- ... as it requires TLS and it was was left to warn on the default from
- when default was SSL...
+Daniel Stenberg (18 Jun 2017)
+- TODO: update the TOC too
-- smb: use memcpy() instead of strncpy()
+- TODO: implement support for CURLOPT_PREQUOTE with SFTP
- ... as it never copies the trailing zero anyway and always just the four
- bytes so let's not mislead anyone into thinking it is actually treated
- as a string.
+ ... also updated the CURLOPT_PREQUOTE.3 man page to mention the correct
+ protocol support.
- Coverity CID: 1260214
-
-- [John E. Malmberg brought this change]
+ Closes #1514
- VMS: Updates for 0740-0D1220
+- tool_wrte_cb: remove check for config == NULL
- lib/setup-vms.h : VAX HP OpenSSL port is ancient, needs help.
- More defines to set symbols to uppercase.
+ ... as it really cannot have reached this far with config being NULL,
+ thus this is unnecesary and misleading.
- src/tool_main.c : Fix parameter to vms_special_exit() call.
+ Bug: https://news.ycombinator.com/item?id=14577585 and
+ https://daniel.haxx.se/blog/2017/06/17/curl-doesnt-spew-binary-anymore/comment-page-1/#comment-18356
- packages/vms/ :
- backup_gnv_curl_src.com : Fix the error message to have the correct package.
+ Forwarded-to-us-by: Jakub Wilk
+
+- curl: prevent binary output spewed to terminal
- build_curl-config_script.com : Rewrite to be more accurate.
+ ... unless "--output -" is used. Binary detection is done by simply
+ checking for a binary zero in early data.
- build_libcurl_pc.com : Use tool_version.h now.
+ Added test 1425 1426 to verify.
- build_vms.com : Fix to handle lib/vtls directory.
+ Closes #1512
+
+Marcel Raad (16 Jun 2017)
+- Makefile.m32: enable -W for MinGW32 build
- curl_gnv_build_steps.txt : Updated build procedure documentation.
+ The configure-based build also has this in addition to -Wall.
- generate_config_vms_h_curl.com :
- * VAX does not support 64 bit ints, so no NTLM support for now.
- * VAX HP SSL port is ancient, needs some help.
- * Disable NGHTTP2 for now, not ported to VMS.
- * Disable UNIX_SOCKETS, not available on VMS yet.
- * HP GSSAPI port does not have gss_nt_service_name.
+ Closes https://github.com/curl/curl/pull/1578
+
+- curl-compilers.m4: enable comma clang warning
- gnv_link_curl.com : Update for new curl structure.
+ It usually warns when using commas instead of semicolons or other
+ operators by accident.
- pcsi_product_gnv_curl.com : Set up to optionally do a complete build.
+ Closes https://github.com/curl/curl/pull/1578
-Marc Hoersken (21 Dec 2014)
-- sockfilt.c: use non-Ex functions that are available before WinXP
+- curl-compilers.m4: enable missing-variable-declarations clang warning
+
+ It usually warns when forgetting to declare TU-local variables static.
- It was initially reported by Guenter that GetFileSizeEx
- requires (_WIN32_WINNT >= 0x0500) to be true.
+ Closes https://github.com/curl/curl/pull/1578
-- tests: use Cygwin-style paths in SSH, SSHD and SFTP config files
+- curl-compilers.m4: enable double-promotion warning
- Second patch to enable Windows support using Cygwin-based OpenSSH.
+ Enable -Wdouble-promotion for both GCC and clang. It warns on implicit
+ promotion from float to double.
- Tested with CopSSH 5.0.0 free edition using an msys shell on Windows 7.
+ Closes https://github.com/curl/curl/pull/1578
-- tests: support spaces in paths to SSH, SSHD and SFTP binaries
+- curl-compilers.m4: enable vla warning for clang
- First patch to enable Windows support using Cygwin-based OpenSSH.
-
-Steve Holme (20 Dec 2014)
-- non-ascii: Reduce variable usage
+ Previously, that warning was only implicitly active in C90 mode.
+ Enable it unconditionally as already done for GCC.
- Removed 'next' variable in Curl_convert_form(). Rather than setting it
- from 'form->next' and using that to set 'form' after the conversion
- just use 'form = form->next' instead.
+ Closes https://github.com/curl/curl/pull/1578
-- non-ascii: Prefer while loop rather than a do loop
+Daniel Stenberg (16 Jun 2017)
+- http-proxy: fix chunked-encoded CONNECT responses
- This also removes the need to check that the 'form' argument is valid.
-
-- non-ascii: Reduce variable scope
+ Regression since 5113ad0424.
- As 'result' isn't used out side the conversion callback code and
- previously caused variable shadowing in the libiconv based code.
-
-- non-ascii: We prefer 'CURLcode result'
+ ... and remove 'flaky' from test 1061 again
- This also fixes a variable shadowing issue when HAVE_ICONV is defined
- as rc was declared for the result code of libiconv based functions.
+ Closes #1579
-Marc Hoersken (19 Dec 2014)
-- secureserver.pl: clean up formatting of config and fix verbose output
+- http-proxy: deal with EAGAIN
- Verbose output was not matching the actual configuration file,
- because FIPS and Windows conditions were ignored.
-
-- secureserver.pl: update Windows detection and fix path conversion
-
-- secureserver.pl: make OpenSSL CApath and cert absolute path values
+ ... the previous code would reset the header length wrongly (since
+ 5113ad0424). This makes test 1060 reliable again.
- Recent stunnel versions (5.08) seem to have trouble with relative
- paths on Windows. This turns the relative paths into absolute ones.
-
-Patrick Monnerat (18 Dec 2014)
-- if2ip: dummy scope parameter for Curl_if2ip() call in SIOCGIFADDR-enabled code.
+ Also: make sws send even smaller chunks of data to increase the
+ likeliness of this happening.
-- [Kyle J. McKay brought this change]
+- libtest/libntlmconnect: fix compiler warnings from f94fcdb
- parseurlandfillconn(): fix improper non-numeric scope_id stripping.
- Fixes SF bug 1149: http://sourceforge.net/p/curl/bugs/1449/
+- [Jay Satiro brought this change]
-- IPV6: address scope != scope id
- There was a confusion between these: this commit tries to disambiguate them.
- - Scope can be computed from the address itself.
- - Scope id is scope dependent: it is currently defined as 1-based local
- interface index for link-local scoped addresses, and as a site index(?) for
- (obsolete) site-local addresses. Linux only supports it for link-local
- addresses.
- The URL parser properly parses a scope id as an interface index, but stores it
- in a field named "scope": confusion. The field has been renamed into "scope_id".
- Curl_if2ip() used the scope id as it was a scope. This caused failures
- to bind to an interface.
- Scope is now computed from the addresses and Curl_if2ip() matches them.
- If redundantly specified in the URL, scope id is check for mismatch with
- the interface index.
+ HTTPS-Proxy: don't offer h2 for https proxy connections
- This commit should fix SF bug #1451.
-
-- connect: singleipconnect(): properly try other address families after failure
-
-Daniel Stenberg (16 Dec 2014)
-- SFTP: work-around servers that return zero size on STAT
+ Bug: https://github.com/curl/curl/issues/1254
- Bug: http://curl.haxx.se/mail/lib-2014-12/0103.html
- Pathed-by: Marc Renault
+ Closes #1546
-- glob_next_url: make the loop count upwards
+- tests: stabilize test 2032 and 2033
- As the former contruct apparently caused a compiler warning, mentioned
- in d8efde07e556c.
-
-- tool_operate: we prefer 'CURLcode result'
-
-- tool_urlglob: unify return codes to use CURLcode
+ Both these tests run the same underlying test code: libntlmconnect.c -
+ this test code made some assumptions about socket ordering when it used
+ curl_easy_fdset() and when we changed timing or got accidental changes
+ in libcurl the tests would fail.
- There was a mix of GlobCode, CURLcode and ints and they were mostly
- passing around CURLcode errors. This change makes the functions use only
- CURLcode and removes the GlobCode type completely.
-
-- tool_urlglob.c: partly reverse dc19789444
+ The tests verify that the different transfers keep using the same
+ connections, which I now instead made sure by adding the number of bytes
+ each transfer gets and then verifies that they always get the same
+ amount as when these tests worked.
- The loop in glob_next_url() needs to be done backwards to maintain the
- logic. dc19789444 caused test 1235 to fail.
-
-- KNOWN_BUGS: the SFTP code doesn't support CURLINFO_FILETIME
-
-- [Jay Satiro brought this change]
+ Closes #1576
- opts: Warn CURLOPT_TIMEOUT overrides when set after CURLOPT_TIMEOUT_MS
-
- Change CURLOPT_TIMEOUT doc to warn that if CURLOPT_TIMEOUT and
- CURLOPT_TIMEOUT_MS are both set whichever one is set last is the one
- that will be used.
+- test1148: verify the -# progressbar
- Prior to this change that behavior was only noted in the
- CURLOPT_TIMEOUT_MS doc.
+ Closes #1569
-Nick Zitzmann (15 Dec 2014)
-- darwinssl: fix incorrect usage of aprintf()
+- test1061: mark as flaky
- Commit b13923f changed an snprintf() to use aprintf(), but the API usage
- wasn't correct, and was causing a crash to occur. This fixes it.
+ Fails intermittently on travis builds since a few days. Likely due to
+ 5113ad0424.
-Steve Holme (14 Dec 2014)
-- copyright: Updated the copyright year following recent updates
-
-Daniel Stenberg (14 Dec 2014)
-- tool_urlglob.c: reverse two loops
+Jay Satiro (16 Jun 2017)
+- url: refactor the check for Windows drive letter in path
- By counting from 0 and up instead of backwards like before, we remove
- the need for the "funny" check of the unsigned variable when decreased
- passed zero. Easier to read and less risk for compiler warnings.
-
-Marc Hoersken (14 Dec 2014)
-- tool_urlglob.c: Added braces to clarify the conditions
-
-- tool_urlglob.c: Silence warning C6293: Ill-defined for-loop
+ - Move the logic to detect a Windows drive letter prefix
+ (eg c: in c:foo) into a function-like macro.
- The >= 0 is actually not required, since i underflows and
- the for-loop is stopped using the < condition, but this
- makes the VS2012 compiler and code analysis happy.
+ Closes https://github.com/curl/curl/pull/1571
-- tool_binmode.c: Explicitly ignore the return code of setmode
+- mk-ca-bundle.pl: Check curl's exit code after certdata download
- Fixes code analysis warning C6031:
- return value ignored: <function> could return unexpected value
-
-- lib: Fixed multiple code analysis warnings if SAL are available
+ - No longer allow partial downloads of certdata.
- warning C28252: Inconsistent annotation for function:
- parameter has another annotation on this instance
-
-Steve Holme (14 Dec 2014)
-- smb.c: Fixed code analysis warning
+ Prior to this change partial downloads were (erroneously?) allowed since
+ only the server code was checked to be 200.
- smb.c:320: warning C6297: Arithmetic overflow: 32-bit value is shifted,
- then cast to 64-bit value. Result may not be an expected
- value
+ Bug: https://github.com/curl/curl/pull/1577
+ Reported-by: Matteo B.
-Marc Hoersken (14 Dec 2014)
-- tool_util.c: Use GetTickCount64 if it is available
+Daniel Stenberg (16 Jun 2017)
+- dist: add the fuzz dir to the tarball
-Steve Holme (14 Dec 2014)
-- smb: Use HAVE_PROCESS_H for process.h inclusion
-
- Rather than testing against _WIN32 use the preferred HAVE_PROCESS_H
- pre-processor define when including process.h.
+- configure: disable nghttp2 too if HTTP has been disabled
-Daniel Stenberg (14 Dec 2014)
-- darwinssl: aprintf() to allocate the session key
+- http-proxy: fix build with --disable-proxy or --disable-http
- ... to avoid using a fixed memory size that risks being too large or too
- small.
+ Reported-by: Dan Fandrich
-Marc Hoersken (14 Dec 2014)
-- curl_schannel: Improvements to memory re-allocation strategy
+- fuzz/README: document how to build
- - do not grow memory by doubling its size
- - do not leak previously allocated memory if reallocation fails
- - replace while-loop with a single check to make sure
- that the requested amount of data fits into the buffer
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1450
- Reported-by: Warren Menzer
+ Fixes #1476
-Steve Holme (14 Dec 2014)
-- asyn-ares: We prefer use of 'CURLcode result'
+- [Frederik B brought this change]
-Marc Hoersken (14 Dec 2014)
-- curl_schannel.c: Data may be available before connection shutdown
+ fuzz: corpora file structure, initial commit
-Steve Holme (14 Dec 2014)
-- http2: Use 'CURLcode result' for curl result codes
+- [Frederik B brought this change]
-- asyn-thread: We prefer 'CURLcode result'
+ fuzz: bring oss-fuzz initial code converted to C89
-- smb: Fixed unnecessary initialisation of struct member variables
+- http-proxy: only attempt FTP over HTTP proxy
- There is no need to set the 'state' and 'result' member variables to
- SMB_REQUESTING (0) and CURLE_OK (0) after the allocation via calloc()
- as calloc() initialises the contents to zero.
-
-- ntlm: Fixed return code for bad type-2 Target Info
+ ... all other non-HTTP protocol schemes are now defaulting to "tunnel
+ trough" mode if a HTTP proxy is specified. In reality there are no HTTP
+ proxies out there that allow those other schemes.
- Use CURLE_BAD_CONTENT_ENCODING for bad type-2 Target Info security
- buffers just like we do for bad decodes.
-
-- ntlm: Remove unnecessary casts in readshort_le()
+ Assisted-by: Ray Satiro, Michael Kaufmann
- I don't think both of my fix ups from yesterday were needed to fix the
- compilation warning, so remove the one that I think is unnecessary and
- let the next Android autobuild prove/disprove it.
+ Closes #1505
-- curl_ntlm_msgs.c: Another attempt to fix compilation warning
+- TODO: the generated include file is gone
- curl_ntlm_msgs.c:170: warning: conversion to 'short unsigned int' from
- 'int' may alter its value
-
-Guenter Knauf (13 Dec 2014)
-- synctime.c: added own user-agent string.
+ ... since commit 73a2fcea0b
-Steve Holme (13 Dec 2014)
-- smb.c: Fixed line longer than 79 columns
-
-- curl_ntlm_msgs.c: Fixed compilation warning from commit 783b5c3b11
+- curl_setup.h: error out on CURL_WANTS_CA_BUNDLE_ENV use
- curl_ntlm_msgs.c:169: warning: conversion to 'short unsigned int' from
- 'int' may alter its value
-
-Guenter Knauf (13 Dec 2014)
-- mk-ca-bundle.pl: restored forced run again.
-
-- synctime.c: removed another timeserver URL.
+ ... to make it really apparent if there's any user using this on purpose.
- worldtimeserver.com seems also no longer available.
-
-- synctime.c: fixed timeserver URLs.
+ Suggested-by: Jay Satiro
- For getting the date header its not necessary to access special
- pages or even CGI scripts - all pages including the main index
- reply with the date header, therefore shortened URLs to domain.
- Removed worldtime.com; added pool.ntp.org.
+ Closes #1542
-Steve Holme (13 Dec 2014)
-- ftp.c: Fixed compilation warning when no verbose string support
+- lib/curl_setup.h: remove CURL_WANTS_CA_BUNDLE_ENV
+
+ When this define was set, libcurl would check the environment variable
+ named CURL_CA_BUNDLE at run-time and use that CA cert bundle. This
+ feature was only defined by the watcom and m32 makefiles and caused
+ inconsistent behaviours among libcurls built on different platforms.
+
+ The curl tool does already feature its own similar logic and the library
+ does not really need it, and it isn't documented libcurl behavior. So
+ this change removes it.
- ftp.c:819: warning: unused parameter 'lineno'
+ Ref: #1538
-- smb: Added state change functions to assist with debugging
+- test1147: verify -H on a file
+
+- curl: allow --header and --proxy-header read from file
+
+ So many headers can be provided as @filename.
- For debugging purposes, and as per other protocols within curl, added
- state change functions rather than changing the states directly.
+ Suggested-by: Timothe Litt
+
+ Closes #1486
-- ntlm: Use short integer when decoding 16-bit values
+- RELEASE-NOTES: synced with 2ad80eec5
-- RELEASE-NOTES: Synced with 6291a16b20
+- curl/curlver.h: start working on 7.55.0
-- smtp.c: Fixed compilation warnings
+- http-proxy: do the HTTP CONNECT process entirely non-blocking
- smtp.c:2357 warning: adding 'size_t' (aka 'unsigned long') to a string
- does not append to the string
- smtp.c:2375 warning: adding 'size_t' (aka 'unsigned long') to a string
- does not append to the string
- smtp.c:2386 warning: adding 'size_t' (aka 'unsigned long') to a string
- does not append to the string
+ Mentioned as a problem since 2007 (8f87c15bdac63) and of course it
+ existed even before that.
- Used array index notation instead.
+ Closes #1547
-- smb: Disable SMB when 64-bit integers are not supported
+- progress: let "current speed" be UL + DL speeds combined
- This fixes compilation issues with compilers that don't support 64-bit
- integers through long long or __int64.
+ Bug #1556
+ Reported-by: Paul Harris
+ Closes #1559
-- ntlm: Disable NTLM v2 when 64-bit integers are not supported
+Marcel Raad (14 Jun 2017)
+- system.h: fix MinGW build
- This fixes compilation issues with compilers that don't support 64-bit
- integers through long long or __int64 which was introduced in commit
- 07b66cbfa4.
+ CURLSYS_PULL_WS2TCPIP_H got renamed to CURL_PULL_WS2TCPIP_H in commit
+ 73a2fcea0b4adea6ba342cd7ed1149782c214ae3.
-- ntlm: Allow NTLM2Session messages when USE_NTRESPONSES manually defined
+Daniel Stenberg (14 Jun 2017)
+- timers: store internal time stamps as time_t instead of doubles
- Previously USE_NTLM2SESSION would only be defined automatically when
- USE_NTRESPONSES wasn't already defined. Separated the two definitions
- so that the user can manually set USE_NTRESPONSES themselves but
- USE_NTLM2SESSION is defined automatically if they don't define it.
-
-- smtp.c: Fixed line longer than 79 columns
-
-- config-win32.h: Don't enable Windows Crypt API if using OpenSSL
+ This gives us accurate precision and it allows us to avoid storing "no
+ time" for systems with too low timer resolution as we then bump the time
+ up to 1 microsecond. Should fix test 573 on windows.
+
+ Remove the now unused curlx_tvdiff_secs() function.
- As the OpenSSL and NSS Crypto engines are prefered by the core NTLM
- routines, to the Windows Crypt API, don't define USE_WIN32_CRYPT
- automatically when either OpenSSL or NSS are in use - doing so would
- disable NTLM2Session responses in NTLM type-3 messages.
+ Maintains the external getinfo() API with using doubles.
+
+ Fixes #1531
-- smtp: Fixed inappropriate free of the scratch buffer
+- dist: make the hugehelp.c not get regenerated unnecessarily
- If the scratch buffer was allocated in a previous call to
- Curl_smtp_escape_eob(), a new buffer not allocated in the subsequent
- call and no action taken by that call, then an attempt would be made to
- try and free the buffer which, by now, would be part of the data->state
- structure.
+ The maketgz script now makes sure the generated hugehelp.c file in the
+ tarball is newer than the generated curl.1 man page, so that it doesn't
+ have to get unnecessarily rebuilt first thing in a typical build. It
+ thus also removes the need for perl to build off a plain release
+ tarball.
- This bug was introduced in commit 4bd860a001.
+ Fixes #1565
-- smtp: Fixed dot stuffing when EOL characters were at end of input buffers
+- includes: remove curl/curlbuild.h and curl/curlrules.h
- Fixed a problem with the CRLF. detection when multiple buffers were
- used to upload an email to libcurl and the line ending character(s)
- appeared at the end of each buffer. This meant any lines which started
- with . would not be escaped into .. and could be interpreted as the end
- of transmission string instead.
+ Rely entirely on curl/system.h now.
- This only affected libcurl based applications that used a read function
- and wasn't reproducible with the curl command-line tool.
+ Introduced in Aug 2008 with commit 14240e9e109f. Now gone.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1456
- Assisted-by: Patrick Monnerat
+ Fixes #1456
-Daniel Stenberg (11 Dec 2014)
-- telnet: fix "cast increases required alignment of target type"
+Version 7.54.1 (14 Jun 2017)
-- ntlm_wb_response: fix "statement not reached"
-
- ... and I could use a break instead of a goto to end the loop.
-
- Bug: http://curl.haxx.se/mail/lib-2014-12/0089.html
- Reported-by: Tor Arntsen
+Daniel Stenberg (14 Jun 2017)
+- release: 7.54.1
-Steve Holme (10 Dec 2014)
-- RELEASE-NOTES: Synced with 1cc5194337
-
- Added some bug fixes that I had missed in previous synchronisations.
+Dan Fandrich (13 Jun 2017)
+- mk-lib1521.pl: updated to match the test changes in 916ec30a
-Daniel Stenberg (10 Dec 2014)
-- Curl_unix2addr: avoid using the variable name 'sun'
-
- I suspect this causes compile failures on Solaris:
-
- Bug: http://curl.haxx.se/mail/lib-2014-12/0081.html
+Daniel Stenberg (13 Jun 2017)
+- [Stuart Henderson brought this change]
-Steve Holme (10 Dec 2014)
-- url.c: Fixed compilation warning when USE_NTLM is not defined
+ libressl: OCSP and intermediate certs workaround no longer needed
+
+ lib/vtls/openssl.c has a workaround for a bug with OCSP responses signed
+ by intermediate certs, this was fixed in LibreSSL in
+ https://github.com/libressl-portable/openbsd/commit/912c64f68f7ac4f225b7d1fdc8fbd43168912ba0
- url.c:3078: warning: variable 'credentialsMatch' set but not used
+ Bug: https://curl.haxx.se/mail/lib-2017-06/0038.html
-- parsedate.c: Fixed compilation warning
+- url: fix buffer overwrite with file protocol (CVE-2017-9502)
- parsedate.c:548: warning: 'parsed' may be used uninitialized in this
- function
+ Bug: https://github.com/curl/curl/issues/1540
+ Advisory: https://curl.haxx.se/docs/adv_20170614.html
- As curl_getdate() returns -1 when parsedate() fails we can initialise
- parsed to -1.
+ Assisted-by: Ray Satiro
+ Reported-by: Marcel Raad
-Daniel Stenberg (10 Dec 2014)
-- TODO: Cache negative name resolves
+- urlglob: fix division by zero
- Worth exploring
-
-- ldap: check Curl_client_write() return codes
+ The multiply() function that is used to avoid integer overflows, was
+ itself reason for a possible division by zero error when passed a
+ specially formatted glob.
- There might be one or two memory leaks left in the error paths.
+ Reported-by: GwanYeong Kim
-- ldap: rename variables to comply to curl standards
+- configure: update the copyright year in the output
-Dan Fandrich (10 Dec 2014)
-- sws.c: Fixed 'rc' may be used uninitialized warning
+- [ygrek brought this change]
-- cookies: Improved OOM handling in cookies
-
- This fixes the test 506 torture test. The internal cookie API really
- ought to be improved to separate cookie parsing errors (which may be
- ignored) with OOM errors (which should be fatal).
+ BINDINGS: update SP-Forth and OCaml urls
-Guenter Knauf (9 Dec 2014)
-- synctime.c: fixed user-agent setting.
+Michael Kaufmann (11 Jun 2017)
+- FindWin32CACert: Use a temporary buffer on the stack
- Some websites meanwhile refuse to reply to requests from ancient
- browsers like IE6, therefore I've comment out this setting, but
- also fixed the string to now fake IE8 if someone enables it.
+ Don't malloc() the temporary buffer, and use the correct type:
+ SearchPath() works with TCHAR, but SearchPathA() works with char.
+ Set the buffer size to MAX_PATH, because the terminating null byte
+ is already included in MAX_PATH.
+
+ Reviewed-by: Daniel Stenberg
+ Reviewed-by: Marcel Raad
+
+ Closes #1548
-Daniel Stenberg (9 Dec 2014)
-- smb: fix unused return code warning
+Dan Fandrich (11 Jun 2017)
+- test1521: fixed OOM handling
-Patrick Monnerat (9 Dec 2014)
-- Curl_client_write() & al.: chop long data, convert data only once.
+Daniel Stenberg (9 Jun 2017)
+- RELEASE-PROCEDURE: updated future release dates
-Guenter Knauf (9 Dec 2014)
-- VC build: added sspi define for winssl-zlib builds.
+- [Paul Harris brought this change]
-Daniel Stenberg (9 Dec 2014)
-- schannel_recv: return the correct code
+ gitignore: ignore all vim swap files
- Bug: http://curl.haxx.se/bug/view.cgi?id=1462
- Reported-by: Tae Hyoung Ahn
+ Closes #1561
-- http2: avoid logging neg "failure" if h2 was not requested
-
-- openldap: do not ignore Curl_client_write() return codes
+- lib1521: fix compiler warnings on the use of bad 'long' values
+
+ Reported-by: Marcel Raad
+ Bug: https://github.com/curl/curl/commit/cccac4fb2b20d6ed87da7978408c3ecacc464fe4#commitcomment-22453387
-- compile: warn on unused return code from Curl_client_write()
+- setopt: check CURLOPT_ADDRESS_SCOPE option range
+
+ ... and return error instead of triggering an assert() when being way
+ out of range.
-Patrick Monnerat (8 Dec 2014)
-- SMB: Fix a data size mismatch that broke SMB on big-endian platforms
+Jay Satiro (8 Jun 2017)
+- [TheAssassin brought this change]
-Steve Holme (7 Dec 2014)
-- smb: Fixed Windows autoconf builds following commit eb88d778e7
+ cmake: Fix inconsistency regarding mbed TLS include directory
- As Windows based autoconf builds don't yet define USE_WIN32_CRYPTO
- either explicitly through --enable-win32-cypto or automatically on
- _WIN32 based platforms, subsequent builds broke with the following
- error message:
+ Previously, one had to set MBEDTLS_INCLUDE_DIR to make CMake find the
+ headers, but the system complained that mbed TLS wasn't found due to
+ MBEDTLS_INCLUDE_DIRS (note the trailing s) was not set. This commit
+ attempts to fix that.
- "Can't compile NTLM support without a crypto library."
-
-- RELEASE-NOTES: Synced with 526603ff05
+ Closes https://github.com/curl/curl/pull/1541
-- [Bill Nagel brought this change]
+Daniel Stenberg (8 Jun 2017)
+- [Ryuichi KAWAMATA brought this change]
- smb: Build with SSPI enabled
+ examples/multi-uv.c: fix deprecated symbol
- Build SMB/CIFS protocol support when SSPI is enabled.
+ Closes #1557
-- [Bill Nagel brought this change]
+- asyn-ares: s/Curl_expire_latest/Curl_expire
- ntlm: Use Windows Crypt API
+- expire: remove Curl_expire_latest()
- Allow the use of the Windows Crypt API for NTLMv1 functions.
-
-Dan Fandrich (7 Dec 2014)
-- cookie.c: Refactored cleanup code to simplify
+ With the introduction of expire IDs and the fact that existing timers
+ can be removed now and thus never expire, the concept with adding a
+ "latest" timer is not working anymore as it risks to not expire at all.
- Also, fixed the outdated comments on the cookie API.
-
-- get_url_file_name: Fixed crash on OOM on debug build
+ So, to be certain the timers actually are in line and will expire, the
+ plain Curl_expire() needs to be used. The _latest() function was added
+ as a sort of shortcut in the past that's quite simply not necessary
+ anymore.
+
+ Follow-up to 31b39c40cf90
- This caused a null-pointer dereference which caused a few dozen
- torture tests to fail.
+ Reported-by: Paul Harris
+
+ Closes #1555
+
+- [Chris Carlmar brought this change]
-Steve Holme (6 Dec 2014)
-- sws.c: Fixed compilation warning
+ configure: fix link with librtmp when specifying path
- sws.c:2191 warning: 'rc' may be used uninitialized in this function
+ Bug: https://curl.haxx.se/mail/lib-2017-06/0017.html
-- ftp.c: Fixed compilation warnings when proxy support disabled
+- file: make speedcheck use current time for checks
- ftp.c:1827 warning: unused parameter 'newhost'
- ftp.c:1827 warning: unused parameter 'newport'
+ ... as it would previously just get the "now" timestamp before the
+ transfer starts and then not update it again.
+
+ Closes #1550
+
+- metalink: remove unused printf() argument
-- smb: Fixed a problem with large file transfers
+- travis: let some builds *not* use --enable-debug
- Fixed an issue with the message size calculation where the raw bytes
- from the buffer were interpreted as signed values rather than unsigned
- values.
+ typecheck-gcc and other things require optimized builds
- Reported-by: Gisle Vanem
- Assisted-by: Bill Nagel
+ Closes #1544
-- smb: Moved the URL decoding into a separate function
+- README.md: show the coverall coverage on github
-- smb: Fixed URL encoded URLs not working
+- lib1521: fix compiler warnings
-- Makefile.inc: Added our standard header and updated file formatting
+- test1521: make the code < 80 columns wide
-- Makefile.inc: Updated file formatting
-
- Aligned continuation character and used space as the separator
- character as per other makefile files.
+- test1121: use stricter types to work with typcheck-gcc
+
+- typecheck-gcc: allow CURLOPT_STDERR to be NULL too
-- curl_md4.h: Updated copyright year following recent edit
+- test1521: test *all* curl_easy_setopt options
+
+ mk-lib1521.pl generates a test program (lib1521.c) that calls
+ curl_easy_setopt() for every known option with a few typical values to
+ make sure they work (ignoring the return codes).
+
+ Some small changes were necessary to avoid asserts and NULL accesses
+ when doing this.
- ...and minor layout adjustment.
+ The perl script needs to be manually rerun when we add new options.
+
+ Closes #1543
-Patrick Monnerat (5 Dec 2014)
-- SMB: Fix big endian problems. Make it OS/400 aware.
+Dan Fandrich (5 Jun 2017)
+- test1538: added "verbose logs" keyword
+
+ These error messages are not displayed with --disable-verbose
-- OS400: enable NTLM authentication
+Daniel Stenberg (5 Jun 2017)
+- test1262: verify ftp download with -z for "if older than this"
-Steve Holme (5 Dec 2014)
-- multi.c: Fixed compilation warning
+Marcel Raad (5 Jun 2017)
+- curl_ntlm_core: use Curl_raw_toupper instead of toupper
- multi.c:2695: warning: declaration of `exp' shadows a global declaration
-
-Guenter Knauf (5 Dec 2014)
-- build: updated dependencies in makefiles.
+ This was the only remaining use of toupper in the entire source code.
+
+ Suggested-by: Daniel Stenberg
-Steve Holme (5 Dec 2014)
-- sasl: Corrected formatting of function descriptions
+Daniel Stenberg (4 Jun 2017)
+- RELEASE-NOTES: synced with 65ba92650
projects / platform / upstream / curl.git / blobdiff