platform/upstream/connman.git
2 years agoRegister with system bus in container environment 26/266426/1 accepted/tizen/unified/20211129.120836 submit/tizen/20211117.050637 submit/tizen/20211125.124313 submit/tizen/20211126.045758
Jaehyun Kim [Fri, 12 Nov 2021 06:15:06 +0000 (15:15 +0900)]
Register with system bus in container environment

Change-Id: I5fe36fdce42ffca6f3f6587923b42d4b5fec61d4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Disabled in container environment" into tizen
Jaehyun Kim [Thu, 11 Nov 2021 09:03:50 +0000 (09:03 +0000)]
Merge "Disabled in container environment" into tizen

2 years agoAdd dbus configuration for robot profile 19/266219/2
cheoleun moon [Tue, 9 Nov 2021 07:56:05 +0000 (16:56 +0900)]
Add dbus configuration for robot profile

Change-Id: If05b36fbbbb58a428d9c5b2c01da8a4d4892e3e5

2 years agoDisabled in container environment 41/265841/3
Jaehyun Kim [Fri, 29 Oct 2021 10:16:39 +0000 (19:16 +0900)]
Disabled in container environment

Disable the container's network daemons to avoid conflicts
because they use the same network namespace.

Change-Id: I0e19fc7df608df39f5936f3082858f6f16415f3d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoRemove net-config dependency 21/265821/1 submit/tizen/20211029.071904
Jaehyun Kim [Fri, 29 Oct 2021 07:08:46 +0000 (16:08 +0900)]
Remove net-config dependency

Change-Id: I28e301a36dbf59cf529fe9c945a4c6278357d77b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Update settings when device information in device_list is changed" into tizen
Jaehyun Kim [Fri, 29 Oct 2021 06:56:00 +0000 (06:56 +0000)]
Merge "Update settings when device information in device_list is changed" into tizen

2 years agoUpdated libbpf.so to link with libelf.so.1 01/265401/2 submit/tizen/20211021.102523
Nishant Chaprana [Mon, 18 Oct 2021 07:35:42 +0000 (13:05 +0530)]
Updated libbpf.so to link with libelf.so.1

Change-Id: Id2328db95c05e74cfdd7baaa4ff5476181b3a601
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoUpdate settings when device information in device_list is changed 98/265398/1
Jaehyun Kim [Mon, 18 Oct 2021 07:30:41 +0000 (16:30 +0900)]
Update settings when device information in device_list is changed

Modified to update enabled device information in settings
when the powered value of each device in device_list is changed.

Change-Id: I3ed4f236d747b9f979b23da19edbe1c248783f54
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix incorrect handling in multi-interface environment 71/265371/2
Jaehyun Kim [Fri, 15 Oct 2021 11:59:35 +0000 (20:59 +0900)]
Fix incorrect handling in multi-interface environment

1. Modified to save enabled device information
   in settings after device_list is updated.
2. Modified to save enabled device information
   in settings only for wifi technology.

Change-Id: I1b05319adcd3fa7796e764912c9369a5ac28ab7e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Reply all multiple/simultaenous SetDevicePower method call" into tizen accepted/tizen/6.5/unified/20211028.225128 accepted/tizen/unified/20210928.073034 submit/tizen/20210928.013804 submit/tizen_6.5/20211028.163301 tizen_6.5.m2_release
Jaehyun Kim [Mon, 27 Sep 2021 06:47:38 +0000 (06:47 +0000)]
Merge "Reply all multiple/simultaenous SetDevicePower method call" into tizen

2 years agoReply all multiple/simultaenous SetDevicePower method call 75/264575/1
Nishant Chaprana [Fri, 24 Sep 2021 13:05:37 +0000 (18:35 +0530)]
Reply all multiple/simultaenous SetDevicePower method call

This patch fixes an issue where Multiple/Simultaenous SetDevicePower
method calls are made and reply is sent to only last dbus caller.

Change-Id: I61e1f5e5b8645dee41910a1b6ea51a405e6024a4
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoUpdate connman settings for single device as well 96/264496/1
Niraj Kumar Goit [Thu, 23 Sep 2021 08:01:50 +0000 (13:31 +0530)]
Update connman settings for single device as well

Change-Id: Ic1ee92050bebd631d1738b9b68152052589e3e77
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoFix: Memory leak issue when tokenizing string 56/264456/1 accepted/tizen/unified/20210924.055913 submit/tizen/20210924.013637
Nishant Chaprana [Mon, 20 Sep 2021 07:26:32 +0000 (12:56 +0530)]
Fix: Memory leak issue when tokenizing string

Change-Id: I71e88bb35384cf919263fa5dda8c4f0f06be6ef2
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoAdd support of bpf 49/263749/5 accepted/tizen/unified/20210916.005908 submit/tizen/20210915.122117 submit/tizen/20210915.152151
Jaehyun Kim [Thu, 9 Sep 2021 09:07:45 +0000 (18:07 +0900)]
Add support of bpf

Change-Id: Iaa5566a1be143ede38832cdd8639111fc26b4586
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoEnable Downgrade dbus method. 52/263752/1
Niraj Kumar Goit [Thu, 9 Sep 2021 09:34:10 +0000 (15:04 +0530)]
Enable Downgrade dbus method.

When offline is detected in device, downgrade service state to ready
and start online check in connman.

Change-Id: Ic5abf9050c51b853ee36fa8067b221c3e9c63eec
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoFix resource leak 10/263710/1 accepted/tizen/unified/20210915.025055 submit/tizen/20210908.150016 submit/tizen/20210909.045500
Jaehyun Kim [Wed, 8 Sep 2021 12:44:57 +0000 (21:44 +0900)]
Fix resource leak

Change-Id: Ic3c9199d0dac7e614743043cdeb5ad1616eb1aa1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Fix build failure when tizen-maintain-online feature is enabled" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:51:07 +0000 (06:51 +0000)]
Merge "Fix build failure when tizen-maintain-online feature is enabled" into tizen

2 years agoFix Crash in connman-vpnd in reboot scenario when config file is present 10/262610/2
Niraj Kumar Goit [Mon, 16 Aug 2021 12:15:49 +0000 (17:45 +0530)]
Fix Crash in connman-vpnd in reboot scenario when config file is present

Change-Id: I3cfccf9f53bfbd92974e1dbba65a6952f21f6c19
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoMerge "wireguard: Add routes for allowedIPs" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:45:19 +0000 (06:45 +0000)]
Merge "wireguard: Add routes for allowedIPs" into tizen

2 years agoMerge "wireguard: Save plugin related settings in config file" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:45:07 +0000 (06:45 +0000)]
Merge "wireguard: Save plugin related settings in config file" into tizen

2 years agoMerge "vpn: Make domain parameter optional" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:53 +0000 (06:44 +0000)]
Merge "vpn: Make domain parameter optional" into tizen

2 years agoMerge "Enable Wireguard VPN Plugin" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:35 +0000 (06:44 +0000)]
Merge "Enable Wireguard VPN Plugin" into tizen

2 years agoMerge "wireguard: Copy interfance names obeying lengths rules" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:16 +0000 (06:44 +0000)]
Merge "wireguard: Copy interfance names obeying lengths rules" into tizen

2 years agoMerge "vpn: Export vpn_ipconfig_foreach as linker symbol" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:05 +0000 (06:44 +0000)]
Merge "vpn: Export vpn_ipconfig_foreach as linker symbol" into tizen

2 years agoMerge "wireguard: Fix struct sockaddr usage" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:43:51 +0000 (06:43 +0000)]
Merge "wireguard: Fix struct sockaddr usage" into tizen

2 years agoMerge "wireguard: Regular reresolve endpoint address" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:43:40 +0000 (06:43 +0000)]
Merge "wireguard: Regular reresolve endpoint address" into tizen

2 years agowireguard: Add routes for allowedIPs 20/262220/4
Nishant Chaprana [Wed, 4 Aug 2021 11:45:01 +0000 (17:15 +0530)]
wireguard: Add routes for allowedIPs

Change-Id: Iad4c994dc7e40589f17db7c1b590cf7673b21bc0
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoFix build failure when tizen-maintain-online feature is enabled 67/263567/1
Nishant Chaprana [Mon, 6 Sep 2021 11:10:36 +0000 (16:40 +0530)]
Fix build failure when tizen-maintain-online feature is enabled

Below are the build fail logs when tizen-maintain-online feature is enabled in spec file.
======================================================================================
[   37s] src/service.c: At top level:
[   37s] src/service.c:9432:17: error: redefinition of 'redo_wispr_ipv4'
[   37s]  9432 | static gboolean redo_wispr_ipv4(gpointer user_data)
[   37s]       |                 ^~~~~~~~~~~~~~~
[   37s] src/service.c:9413:17: note: previous definition of 'redo_wispr_ipv4' was here
[   37s]  9413 | static gboolean redo_wispr_ipv4(gpointer user_data)
[   37s]       |                 ^~~~~~~~~~~~~~~
[   37s] src/service.c: In function 'service_connect':
=====================================================================================

Change-Id: I1516358e55bba73af6383a8f7c8cc29c74f736fc
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoFix referencing incorrect bssid_list 06/263406/1
Jaehyun Kim [Thu, 2 Sep 2021 02:51:56 +0000 (11:51 +0900)]
Fix referencing incorrect bssid_list

Change-Id: Ie8cc971deb699250f9d6fbbbb1d37ed4ecf3fbf1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix NULL pointer dereference 94/263394/2
Jaehyun Kim [Thu, 2 Sep 2021 01:26:57 +0000 (10:26 +0900)]
Fix NULL pointer dereference

Thread 1 (LWP 13957):
>0  count_assoc_reject (key=0x0, value=0x0, user_data=0xbe0a3928) at src/service.c:843 --> connman (rpm)
>1  0xb6654674 in g_hash_table_foreach (hash_table=0x533200, func=0x4700ad <count_assoc_reject>, user_data=user_data@entry=0xbe0a3928) at ../glib/ghash.c:2056 --> libglib (rpm)
>2  0x0047bf9a in update_assoc_reject (service=0x4fb2a0, service=0x4fb2a0) at src/service.c:857 --> connman (rpm)
>3  __connman_service_update_from_network (network=network@entry=0x50d6a0) at src/service.c:11004 --> connman (rpm)
>4  0x0046a9f4 in connman_network_set_group (network=network@entry=0x50d6a0, group=group@entry=0x560ff8 "") at src/network.c:1587 --> connman (rpm)
>5  0x0044f12c in network_added (supplicant_network=0x51d430) at plugins/wifi.c:5031 --> connman (rpm)
>6  0x004516ba in callback_network_added (network=<optimized out>) at gsupplicant/supplicant.c:828 --> connman (rpm)
>7  scan_network_update (iter=<optimized out>, user_data=0x4f0380) at gsupplicant/supplicant.c:3790 --> connman (rpm)

Change-Id: I2f6e86c492dbc621b1c9f48506e8a89326568664
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoUse SNR and estimated throughput for BSS scoring 08/262708/1
Jaehyun Kim [Wed, 18 Aug 2021 08:02:06 +0000 (17:02 +0900)]
Use SNR and estimated throughput for BSS scoring

Change-Id: Ie80ad47361166cd3b22a430111dda5c91791dca2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agowireguard: Save plugin related settings in config file 09/262209/2
Nishant Chaprana [Wed, 4 Aug 2021 08:08:44 +0000 (13:38 +0530)]
wireguard: Save plugin related settings in config file

Change-Id: I76d12fa347d1211958463ccf38a043a0c6272ece
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoAdded a dbus property 'TimeUpdated' 47/261447/2 accepted/tizen/unified/20210726.135508 submit/tizen/20210723.060030
Jaehyun Kim [Mon, 19 Jul 2021 07:36:36 +0000 (16:36 +0900)]
Added a dbus property 'TimeUpdated'

A property has been added to indicate
whether the time has been updated by NTP.

Change-Id: I86b8a0c2df377168f98656618efd82bb7da91800
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agovpn: Make domain parameter optional 11/261311/1
Nishant Chaprana [Thu, 15 Jul 2021 06:04:16 +0000 (11:34 +0530)]
vpn: Make domain parameter optional

There is no technical requirement to provide the domain name. Thus,
make the domain paremeter optional.

Reported by Christian Hewitt
Upstream Patch: https://git.kernel.org/pub/scm/network/connman/connman.git/patch/?id=82699007fa89e26206771047d8cbb7c160fd2990

Change-Id: Iac21532e3e310d67c633874a95566413beb4b3a4
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoEnable Wireguard VPN Plugin 92/261192/1
Nishant Chaprana [Tue, 6 Jul 2021 12:15:42 +0000 (17:45 +0530)]
Enable Wireguard VPN Plugin

Change-Id: Ic1edd8f5ea13e965ecd57499b51b8652604f5f71
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agowireguard: Copy interfance names obeying lengths rules 91/261191/1
Daniel Wagner [Mon, 5 Apr 2021 15:25:27 +0000 (17:25 +0200)]
wireguard: Copy interfance names obeying lengths rules

gcc points out the destination buffer has the same size the specified
bound for the string.

  warning: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]

Let's make sure we do not overflow the buffer (should not happen as
the names are provide by the kernel and hence should fit).

Change-Id: I1e8818f0820ffb32083e14cb88e4919fd8b12798
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agovpn: Export vpn_ipconfig_foreach as linker symbol 90/261190/1
Daniel Wagner [Fri, 11 Dec 2020 17:02:41 +0000 (18:02 +0100)]
vpn: Export vpn_ipconfig_foreach as linker symbol

Commit 95b25140bec7 ("vpn: Add WireGuard support") introduced
a plugin dependency to __vpn_ipconfig_foreach. Because the linker does
not export the prefixed functions, we need to rename it to
vpn_ipconfig_foreach in order to export the linker symbol.

Change-Id: I105159739dece4a675fa074ef304c6fd4d7b88bf
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agowireguard: Fix struct sockaddr usage 89/261189/1
Daniel Wagner [Fri, 9 Oct 2020 07:28:00 +0000 (09:28 +0200)]
wireguard: Fix struct sockaddr usage

wg_dns_reresolve_cb() tries to read 16 bytes from the addr variable in
case of IPv6 but struct sockaddr has size of 8 bytes. Introduce a
helper struct containing IPv4 and IPv6 sockaddr as superset of all IP
based sockaddr.

This helper struct is identically to the 'union endpoint' in
wireguard.h. But we don't want to touch this header file as it is 100%
copy from the upstream WireGuard project.

Fixes: 90592f7a5835 ("wireguard: Regular reresolve endpoint address")
Change-Id: I2b262e61e52c795ab0cab4b206bd25df8ae57738
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agowireguard: Regular reresolve endpoint address 88/261188/1
Daniel Wagner [Sun, 22 Mar 2020 19:50:52 +0000 (20:50 +0100)]
wireguard: Regular reresolve endpoint address

In case the WireGuard endpoint is hosted on a dynamic IP address, the
endpoint might change during runtime. Reresolve the endpoint on a
regular basis and update the WireGuard device when it IP address has
changed.

Reported by Christian Hewitt

Change-Id: Ice3b554a064585fb03ae8a7a89baccbe53e8576b
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoUse the last updated MAC address before turning on wifi 52/260852/2 accepted/tizen/unified/20210708.131505 submit/tizen/20210706.115004
Jaehyun Kim [Mon, 5 Jul 2021 13:46:19 +0000 (22:46 +0900)]
Use the last updated MAC address before turning on wifi

MAC randomization does not work properly when there are multiple wifi interfaces
or in some devices that do not create a .mac.info file.
So, to solve this problem, a permanent MAC address that is set before wifi up is used.

If a permanent MAC address is in built-in physical device,
it's hardly get it at an initial creation.
So, if there is a MAC address updated from netlink before wifi is on, it is used.
* MAC randomization works only when wifi is turned on.

Change-Id: Ia7a9ad0affaa6deca974199100a56e7378b6c195
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix memory leaks and dereference without null check 35/259635/1 accepted/tizen/unified/20210616.132525 submit/tizen/20210615.081101
Jaehyun Kim [Thu, 10 Jun 2021 09:20:00 +0000 (18:20 +0900)]
Fix memory leaks and dereference without null check

Change-Id: I7accd1386302c26e5bdfa8aee224fe60defc50af
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoCheck the reply of SignalPoll method correctly 34/259634/1
Jaehyun Kim [Thu, 10 Jun 2021 09:17:25 +0000 (18:17 +0900)]
Check the reply of SignalPoll method correctly

Change-Id: Id48cb699743e62484fac775c7348c34f1e80ac8f
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoAdded dbus method 'GetConnectedService' 15/258415/7 accepted/tizen/unified/20210601.135338 submit/tizen/20210528.085525
Jaehyun Kim [Mon, 17 May 2021 07:20:43 +0000 (16:20 +0900)]
Added dbus method 'GetConnectedService'

CAPI is fetching the full list of services
and looking for the service that is connected,
but this is an inefficient way,
so a dbus method to provide that information is added in connman.

Change-Id: I825682b3a1c01de3926145df499321ef161c4af7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoRemove wrong rules from connman dbus conf 81/258481/1
Nishant Chaprana [Tue, 18 May 2021 09:39:46 +0000 (15:09 +0530)]
Remove wrong rules from connman dbus conf

MacPolicy, PreassocMacPolicy and RandomMacLifetime are properties
of technology interface and method rules cannot be applied for them.

Change-Id: I5dd381d1fac44f23f62f5cf1a1b9cccf859ffec8
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoAdd TIZEN_EXT macro to Tizen specific code 80/258480/1
Nishant Chaprana [Tue, 18 May 2021 09:38:42 +0000 (15:08 +0530)]
Add TIZEN_EXT macro to Tizen specific code

Change-Id: I322c8866eee025d868593a5110186fe581b3d939
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoAdded support to get country-code. 72/258472/1
Niraj Kumar Goit [Tue, 18 May 2021 07:54:27 +0000 (13:24 +0530)]
Added support to get country-code.

Change-Id: I880450f406c48490f5952452f0e586ca4d0d3c9e
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoAdded support to set country-code. 37/258237/1
Niraj Kumar Goit [Wed, 12 May 2021 14:26:20 +0000 (19:56 +0530)]
Added support to set country-code.

Change-Id: I6919f3ca4a794eeee7d75a3824c0fc3a22031d06
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoModified to handle WPA3/WPA2 mixed mode as WPA3-SAE 20/258020/1 submit/tizen/20210512.013459 submit/tizen/20210513.084419
Jaehyun Kim [Fri, 7 May 2021 13:39:18 +0000 (22:39 +0900)]
Modified to handle WPA3/WPA2 mixed mode as WPA3-SAE

Change-Id: Ib9d5240a4673f08f65dd13db3eb59bbb1b4da80d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoSend Mac policy parameters in CreateInterface dbus call. 86/257686/1 accepted/tizen/unified/20210506.103545 submit/tizen/20210503.112345
Nishant Chaprana [Thu, 29 Apr 2021 10:01:45 +0000 (15:31 +0530)]
Send Mac policy parameters in CreateInterface dbus call.

This patch will send mac policy parameters in CreateInteraface dbus call
and will make 3 dbus calls to set mac policy parameters when interface is
already created in wpa_supplicant.

Change-Id: Icd7ce43d1b67fe5211ab15d2ab20fd47038907f1
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoFix Wi-Fi activation issue in TM1 23/257323/2 submit/tizen/20210427.065300
Nishant Chaprana [Tue, 27 Apr 2021 04:22:32 +0000 (09:52 +0530)]
Fix Wi-Fi activation issue in TM1

Increased timeout to 10 seconds in case of device activation
This is required because the Mac Randomizaiton parameters need
to be set by dbus calls, to retains previous boot settings.

The timeout value is already less because wifi_manager_activate() API
has 120 seconds timeout to turn on the device, however current timeout
emits failure callback post 4 seconds, when -EINPROGRESS is returned
from device plugin.

Change-Id: I92041dbd9898f1f6b0a59f895bcd06fb5f6e1e91
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoFix autoconnect issue at reboot in TW3 81/256581/5 submit/tizen/20210421.161229
Nishant Chaprana [Wed, 7 Apr 2021 11:21:44 +0000 (16:51 +0530)]
Fix autoconnect issue at reboot in TW3

Change-Id: I7104f40a29f5e45cd2b6ba0391f36d7c37bfa0a2
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoAdd setter/getter for handling MAC randomization policy 63/255263/15
Nishant Chaprana [Thu, 18 Mar 2021 06:08:16 +0000 (11:38 +0530)]
Add setter/getter for handling MAC randomization policy

Change-Id: I978ab95f02d04574efc7c3455b71f72841956c36
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoFix NULL pointer dereference 03/256003/2
Nishant Chaprana [Fri, 26 Mar 2021 08:38:15 +0000 (14:08 +0530)]
Fix NULL pointer dereference

Core was generated by `/usr/bin/connmand -n --nobacktrace --noplugin vpn'.
Program terminated with signal SIGSEGV, Segmentation fault.
>0  connman_device_get_last_connected_ident (device=0x0) at src/device.c:842
842 return device->last_connected_ident;
(gdb) bt
>0  connman_device_get_last_connected_ident (device=0x0) at src/device.c:842
>1  0x0098ec70 in calculate_score_last_connected (service=0x1ef9eb8) at src/service.c:7900
>2  calculate_score (service=0x1ef9eb8) at src/service.c:7994
>3  calculate_score (service=0x1ef9eb8) at src/service.c:7977
>4  0x0098eed8 in service_compare (a=0x1ef9eb8, b=0x1f010a0) at src/service.c:8138

Change-Id: I7e412f68f71472e28669941b9346ba73281ccd39
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoUse dbus_free for deallocation, when allocated with dbus_malloc0 12/255412/3
Nishant Chaprana [Thu, 18 Mar 2021 04:46:52 +0000 (10:16 +0530)]
Use dbus_free for deallocation, when allocated with dbus_malloc0

Change-Id: I003118f70353bf949f050a6e863c9152be8b6e8e
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoMerge "Error checking in passphrase decryption method." into tizen accepted/tizen/unified/20210225.130544 submit/tizen/20210224.083420
Jaehyun Kim [Wed, 24 Feb 2021 08:31:21 +0000 (08:31 +0000)]
Merge "Error checking in passphrase decryption method." into tizen

3 years agoMerge "Fix svace 'UNREACHABLE_CODE.NO_PATH' warnings" into tizen
Jaehyun Kim [Wed, 24 Feb 2021 08:30:41 +0000 (08:30 +0000)]
Merge "Fix svace 'UNREACHABLE_CODE.NO_PATH' warnings" into tizen

3 years agoFix svace 'UNREACHABLE_CODE.NO_PATH' warnings 49/253449/1
Nishant Chaprana [Wed, 10 Feb 2021 05:39:40 +0000 (11:09 +0530)]
Fix svace 'UNREACHABLE_CODE.NO_PATH' warnings

Change-Id: Ibefe7a09903f2d05e7aa12e9262f820d4e7feb71
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoChange systemd-devel package name 56/252956/1 accepted/tizen/unified/20210217.120449 submit/tizen/20210217.025918
INSUN PYO [Wed, 3 Feb 2021 08:48:16 +0000 (17:48 +0900)]
Change systemd-devel package name

Change-Id: I0c553dd40bda63b08846e66bbcdd9955d882ef41

3 years agoError checking in passphrase decryption method. 03/252403/1
Niraj Kumar Goit [Wed, 27 Jan 2021 13:44:08 +0000 (19:14 +0530)]
Error checking in passphrase decryption method.

If Dbus fails to append argument in dbus-message,
do not call a dbus method to decrypt passphrase.

Change-Id: Ic3b63ea9e6827ca1bf3753d750026119ec1bfd1a
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
3 years agomerge tag upstream/1.38 84/252384/1 accepted/tizen/unified/20210129.002142 submit/tizen/20210127.105449
Seonah Moon [Wed, 27 Jan 2021 08:38:08 +0000 (17:38 +0900)]
merge tag upstream/1.38

Change-Id: Ic98cd483e7e21143bb1102a781643c06ce9f628d

3 years agoOn device reboot enable wpa-supplicant for EAPoL. 11/250511/3 submit/tizen/20210126.062930
Niraj Kumar Goit [Mon, 28 Dec 2020 20:07:12 +0000 (01:37 +0530)]
On device reboot enable wpa-supplicant for EAPoL.

In case of device reboot enable wpa-supplicant for eapol
connection if last connection was EAP over ethernet.

Change-Id: Ia264accac74ecffdba6c2b116807e45f675ef3db
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
3 years agoAdded Dbus method 'IsEapolEnabled'. 88/249788/2
Niraj Kumar Goit [Wed, 16 Dec 2020 15:54:16 +0000 (21:24 +0530)]
Added Dbus method 'IsEapolEnabled'.

This patch fixes EAPoL enabled status on device reboot scenario.

Change-Id: Ib9fcbed659996eae42c6a30e7ee5f584aeaa19d2
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
3 years agoMerge "Imported Upstream connman version 1.38" into tizen
Jaehyun Kim [Mon, 25 Jan 2021 06:15:21 +0000 (06:15 +0000)]
Merge "Imported Upstream connman version 1.38" into tizen

3 years agoAdded timer delay to get the response 62/251762/3 accepted/tizen/unified/20210122.123012 submit/tizen/20210119.130611
Prasadam Prashath Kumar [Tue, 19 Jan 2021 06:12:28 +0000 (11:42 +0530)]
Added timer delay to get the response

In Tizen6.5 to avoid continious loop in udp_listner_event
added timer delay, so connman can receive response from telephony deamon and wpa_supplicant

Change-Id: I88a74d6d4fe3f91be27b24949f8fc14edd3f7143
Signed-off-by: Prasadam Prashath Kumar <prasadam.p@samsung.com>
3 years agoImported Upstream connman version 1.38 29/246129/6
Niraj Kumar Goit [Tue, 1 Dec 2020 12:44:19 +0000 (18:14 +0530)]
Imported Upstream connman version 1.38

Change-Id: I9e650762f3b2b2a31945b66e044e67a77e3b4b12
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
3 years agoFix derefrencing of NULL pointer 94/248794/1 submit/tizen/20201217.131910 submit/tizen/20201229.102954
Jaehyun Kim [Wed, 2 Dec 2020 08:50:42 +0000 (17:50 +0900)]
Fix derefrencing of NULL pointer

Return value of a function '__connman_service_get_network' is dereferenced without checking.

Change-Id: Ib66474b2fc6924d50eb8b35206251938ba63baad
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMerge "Fix derefrencing of NULL pointer" into tizen submit/tizen/20201116.030352 submit/tizen/20201127.052752
Jaehyun Kim [Wed, 11 Nov 2020 11:30:56 +0000 (11:30 +0000)]
Merge "Fix derefrencing of NULL pointer" into tizen

3 years agoFix derefrencing of NULL pointer 17/247517/2
Jaehyun Kim [Wed, 11 Nov 2020 11:00:54 +0000 (20:00 +0900)]
Fix derefrencing of NULL pointer

In some cases network->device could be NULL which leads to crash

Change-Id: I3cc5401b37fd48d8d702935bef7afa7e277222f2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoRename EAPoL configuration file path to /var/lib/connman 01/247301/1
Niraj Kumar Goit [Mon, 9 Nov 2020 15:39:41 +0000 (21:09 +0530)]
Rename EAPoL configuration file path to /var/lib/connman

Change-Id: I5a14fb736b0b3b842eaedfce53303c6a6d143aa9
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
3 years agoEmit StateChangedProperties post emitting service state's PropertyChanged 12/245012/2 submit/tizen/20201106.060323
Nishant Chaprana [Mon, 2 Nov 2020 11:05:11 +0000 (16:35 +0530)]
Emit StateChangedProperties post emitting service state's PropertyChanged

wifi-manager and libnet-client can use this signal instead of
[PropertyChanged(state) signal + GetProperties call] combination
for updating service information.

Change-Id: I0203cb7df202ff3767a2c4d25e8ca685e4eb8ba8
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoMerge "[gdhcp/client] Reopen socket GIO channel when failed" into tizen accepted/tizen/unified/20201029.124906 submit/tizen/20201028.023046
Jaehyun Kim [Tue, 27 Oct 2020 03:06:27 +0000 (03:06 +0000)]
Merge "[gdhcp/client] Reopen socket GIO channel when failed" into tizen

3 years agoMerge "[src/rtnl] Add retry mechanism when socket GIO channel fails" into tizen
Jaehyun Kim [Tue, 27 Oct 2020 03:06:18 +0000 (03:06 +0000)]
Merge "[src/rtnl] Add retry mechanism when socket GIO channel fails" into tizen

3 years agoFix an issue where the log option is not applied properly 24/245824/2
Jaehyun Kim [Fri, 16 Oct 2020 07:51:48 +0000 (16:51 +0900)]
Fix an issue where the log option is not applied properly

Change-Id: Ibb5305175a1987d74f0a24ba413a664940233e76
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoFix auto connection failure 76/245776/1
Jaehyun Kim [Thu, 15 Oct 2020 13:32:17 +0000 (22:32 +0900)]
Fix auto connection failure

If there is more than one connection history, auto-connection is failing.
This problem occurs because two APs try to connect to the same interface at the same time.
So fixed to prevent duplicate connection attempts on the same interface.

Change-Id: If5da80db089c9607579f943d023565c999a5576b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoImported Upstream version 1.38 91/245691/1 upstream/1.38
Nishant Chaprana [Wed, 14 Oct 2020 08:29:23 +0000 (13:59 +0530)]
Imported Upstream version 1.38

Change-Id: I7cada2367329445e1d200055e21d96e7e9c05047
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years ago[gdhcp/client] Reopen socket GIO channel when failed 65/245565/4
Nishant Chaprana [Mon, 12 Oct 2020 09:12:00 +0000 (14:42 +0530)]
[gdhcp/client] Reopen socket GIO channel when failed

Change-Id: Ib63b6f194e67fc4d7cfc3f223afa064761dff578
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years ago[src/rtnl] Add retry mechanism when socket GIO channel fails 64/245564/5
Nishant Chaprana [Mon, 12 Oct 2020 08:03:23 +0000 (13:33 +0530)]
[src/rtnl] Add retry mechanism when socket GIO channel fails

Change-Id: I21f1d8c970f1053ce4337dc0d251d2fa20bbd509
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoFix an issue where the log option is applied incorrectly 53/245353/1 accepted/tizen/6.0/unified/20201030.105121 accepted/tizen/6.0/unified/hotfix/20201102.235749 accepted/tizen/unified/20201008.043010 submit/tizen/20201007.120259 submit/tizen_6.0/20201029.205501 submit/tizen_6.0_hotfix/20201102.192901 submit/tizen_6.0_hotfix/20201103.115101 tizen_6.0.m2_release
Jaehyun Kim [Wed, 7 Oct 2020 11:57:48 +0000 (20:57 +0900)]
Fix an issue where the log option is applied incorrectly

Change-Id: I57db81c2670b769bbedafb3e3d9db02218516bca
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMerge "Add support for dlog" into tizen
Jaehyun Kim [Wed, 7 Oct 2020 11:08:12 +0000 (11:08 +0000)]
Merge "Add support for dlog" into tizen

3 years agoAdd support for dlog 02/245302/3
Jaehyun Kim [Wed, 7 Oct 2020 02:08:26 +0000 (11:08 +0900)]
Add support for dlog

1. Add support for dlog
2. Add some log options to main.conf
3. Allow to simplify the amount of logs by option

Change-Id: I8c1202ae267aca9bb2c18d44c2ccd3e6d5a74a73
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years ago[Fix][src/service] Add 'fall through' comment when break statement is not needed 69/245069/2
Nishant Chaprana [Wed, 30 Sep 2020 10:36:19 +0000 (16:06 +0530)]
[Fix][src/service] Add 'fall through' comment when break statement is not needed

Change-Id: Iff3cac79bc3f3ede61f90ab688cfbebcbc374221
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years ago[Fix][plugin/ethernet] SVACE warning DEREF_AFTER_NULL 67/245067/2
Nishant Chaprana [Wed, 30 Sep 2020 10:10:18 +0000 (15:40 +0530)]
[Fix][plugin/ethernet] SVACE warning DEREF_AFTER_NULL

Change-Id: Ie3a9044de3be7ce46d05052920f9d5b5d99cd15f
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoFix incorrect dbus usage that caused crash 52/244852/1 accepted/tizen/unified/20201006.044352 submit/tizen/20200925.132900 submit/tizen/20201005.112026
Jaehyun Kim [Fri, 25 Sep 2020 05:45:55 +0000 (14:45 +0900)]
Fix incorrect dbus usage that caused crash

Change-Id: Ifd11a65d3182533d210401fbce4c5fb9b6504b0d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoThe order between the device signal and the service signal has been changed 73/244273/1 accepted/tizen/unified/20200921.095121 submit/tizen/20200917.115639 submit/tizen/20200918.062939
Jaehyun Kim [Wed, 16 Sep 2020 13:39:40 +0000 (22:39 +0900)]
The order between the device signal and the service signal has been changed

Net-config is implemented assuming that the DeviceChanged signal comes before the service PropertyChanged signal.
Therefore, the event order has been adjusted accordingly.

Change-Id: I134ec7152a0e40bbfe317c704a91ca81fc01dc1c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoFix build warnings 44/243944/1
Jaehyun Kim [Fri, 11 Sep 2020 08:29:38 +0000 (17:29 +0900)]
Fix build warnings

Change-Id: I43c65427f5b6e0eb003ac3c17c012cd9b7db0f76
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoRemove DefaultDependencies=false at connman.service 61/243861/1
Jaehyun Kim [Thu, 10 Sep 2020 13:05:00 +0000 (22:05 +0900)]
Remove DefaultDependencies=false at connman.service

connman.service has "After=net-config.service" dependency.
But net-config.service don't have DefaultDependencies=no.

So "DefaultDependencies=false" does not have any effect on connman.service, but instead it is confusing.

Change-Id: I52dff5dc4a33deceed87b47ff1aaa05b2f049f8e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoFix derefrencing of NULL pointer 13/242813/1 accepted/tizen/unified/20200903.151723 submit/tizen/20200901.053326 submit/tizen/20200902.111409 submit/tizen/20200903.044940
Jaehyun Kim [Tue, 1 Sep 2020 05:20:41 +0000 (14:20 +0900)]
Fix derefrencing of NULL pointer

In some cases wifi->network is NULL which leads to crash

Change-Id: Ie02bb6a84f25d816935b492169feed2aca7f76b8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMove GetInterfaces method to Manager interface 07/242807/1
Jaehyun Kim [Tue, 1 Sep 2020 03:11:34 +0000 (12:11 +0900)]
Move GetInterfaces method to Manager interface

Change-Id: I4e9cd93717a04457f97bf13fc389075a3e5c0e54
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoAdd support for handling multiple wifi interfaces 43/242543/1 submit/tizen/20200828.142119
Jaehyun Kim [Thu, 27 Aug 2020 14:32:34 +0000 (23:32 +0900)]
Add support for handling multiple wifi interfaces

Change-Id: I4762c8d3444167dce34498634de4948e822f865f
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoSvace Fix: memory leak 99/240799/4
Rahul Jain [Tue, 11 Aug 2020 12:04:12 +0000 (17:34 +0530)]
Svace Fix: memory leak

Change-Id: Id10ede540b99d028f6ff40225b4dfcccb46d7fe0

3 years agoUse ref counting for network during SignalPoll method call of wpa_supplicant. 30/240230/3 accepted/tizen/unified/20200812.144017 submit/tizen/20200811.004738
Nishant Chaprana [Tue, 4 Aug 2020 12:45:24 +0000 (18:15 +0530)]
Use ref counting for network during SignalPoll method call of wpa_supplicant.

Description: This patch fixes the issue in which dangling network pointer
is present as user_data of signalpoll_callback.

This dangling pointer crashes connman with below backtrace:-

>>> bt
\#0  connman_device_get_ident (device=0x6e6f632f) at src/device.c:592
\#1  0xb6f54994 in __connman_network_get_ident (network=network@entry=0xb87715b0) at src/network.c:1560
\#2  0xb6f652da in connman_service_lookup_from_network (network=network@entry=0xb87715b0) at src/service.c:10177
\#3  0xb6f655ee in __connman_service_notify_strength_changed (network=network@entry=0xb87715b0) at src/service.c:10523
\#4  0xb6f5527c in connman_network_set_strength (network=network@entry=0xb87715b0, strength=strength@entry=69 'E') at src/network.c:2704
\#5  0xb6f36ac0 in signalpoll_callback (result=<optimized out>, maxspeed=39, strength=69, user_data=0xb87715b0) at plugins/wifi.c:3866
\#6  0xb6f3b68e in interface_signalpoll_result (error=<optimized out>, iter=<optimized out>, user_data=0xb8782af8) at gsupplicant/supplicant.c:6348
\#7  0xb6f4335a in method_call_reply (call=0xb8771ec0, user_data=0xb8782c98) at gsupplicant/dbus.c:476
\#8  0xb6da23a4 in ?? () from /lib/libdbus-1.so.3
\#9  0xb6da5fa0 in dbus_connection_dispatch () from /lib/libdbus-1.so.3
\#10 0xb6f94dce in message_dispatch (data=0xb875fe78) at gdbus/mainloop.c:72
\#11 0xb6e21d84 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
\#12 0xb6e22008 in ?? () from /lib/libglib-2.0.so.0
\#13 0xb6e22268 in g_main_loop_run () from /lib/libglib-2.0.so.0
\#14 0xb6f29d3e in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:1373

Change-Id: Ia171c2ddabf6a4f9c3d6a6bbd3763398b6e0ce46
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoSvace issues: Null check and memory leaks 70/239070/2 accepted/tizen/unified/20200805.122502 submit/tizen/20200730.084504 submit/tizen/20200804.104340
Rahul Jain [Tue, 21 Jul 2020 11:18:45 +0000 (16:48 +0530)]
Svace issues: Null check and memory leaks

Change-Id: I937af7e6dbe3a919c1d0b0d7dee4b481c2ef0982

3 years agoChange the service file path for 64bit build 26/237026/1 accepted/tizen/unified/20200626.133553 submit/tizen/20200624.065138
Jaehyun Kim [Wed, 24 Jun 2020 06:27:40 +0000 (15:27 +0900)]
Change the service file path for 64bit build

Change-Id: I4ae421d7428aa3d0a70f1c66fef736b5710739b2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMerge "Add to check ins status on client" into tizen submit/tizen/20200610.045555
hyunuk tak [Wed, 10 Jun 2020 04:54:48 +0000 (04:54 +0000)]
Merge "Add to check ins status on client" into tizen

3 years agoAdd omitted TIZEN_EXT 88/235688/1
Jaehyun Kim [Tue, 9 Jun 2020 02:23:36 +0000 (11:23 +0900)]
Add omitted TIZEN_EXT

Change-Id: I44227340c3a408711756a2bf4ccfb860ef44170b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoAdd to check ins status on client 83/234483/1
hyunuk.tak [Tue, 26 May 2020 23:33:52 +0000 (08:33 +0900)]
Add to check ins status on client

Change-Id: I3224dc06110f6c0063fa082b713cb2aaa13a3a1f
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
3 years agoMerge "supported OWE Transition mode" into tizen accepted/tizen/unified/20200529.124226 submit/tizen/20200528.074637
Jiung Yu [Mon, 25 May 2020 04:27:36 +0000 (04:27 +0000)]
Merge "supported OWE Transition mode" into tizen

3 years agoMerge "Block all extra scans caused by ConnMan" into tizen
cheoleun moon [Mon, 25 May 2020 02:17:01 +0000 (02:17 +0000)]
Merge "Block all extra scans caused by ConnMan" into tizen

3 years agosupported OWE Transition mode 06/234106/2
Jinwon Kim [Wed, 20 May 2020 04:28:12 +0000 (13:28 +0900)]
supported OWE Transition mode

Change-Id: I6dd1cb437ac16c0428df4d5bc812fefb36543c6d
Signed-off-by: Jinwon Kim <jinwon0325.kim@samsung.com>
3 years agoFix wrong length for format string 42/233742/1 accepted/tizen/unified/20200519.035055 submit/tizen/20200519.021428
Yu [Tue, 19 May 2020 01:37:39 +0000 (10:37 +0900)]
Fix wrong length for format string

Change-Id: I11c0eee0076be37b17ec5ffaff92c72975d29d8f
Signed-off-by: Yu jiung <jiung.yu@samsung.com>