platform/upstream/connman.git
5 weeks agoFix appending NULL to dbus message 94/307494/1 accepted/tizen_7.0_unified accepted/tizen/7.0/unified/20240311.170201
Jaehyun Kim [Mon, 11 Mar 2024 06:52:42 +0000 (15:52 +0900)]
Fix appending NULL to dbus message

Change-Id: Ibbc16488acb93f1ecfd5a8f34c52b78510b412a6
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoFix build warnings 62/305962/1 accepted/tizen/7.0/unified/20240215.160539
Jaehyun Kim [Wed, 14 Feb 2024 07:48:01 +0000 (16:48 +0900)]
Fix build warnings

Change-Id: I94cbd056deb226561f057613454417f497bf94a1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoFix NTP not restarted when timeserver changed 20/305920/1
Jaehyun Kim [Tue, 13 Feb 2024 12:07:06 +0000 (21:07 +0900)]
Fix NTP not restarted when timeserver changed

NTP client is restarted when the Timeserver list is changed,
but NTP client is not started because the config value is not changed first.
So, it was modified to change the config value first.

Change-Id: I1dd02a355507c66404b2073f0a708d3884815394
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoIgnore unassigned service->network when adding services 16/305916/1
Jaehyun Kim [Tue, 13 Feb 2024 11:09:21 +0000 (20:09 +0900)]
Ignore unassigned service->network when adding services

When a newly created service is added to the service list,
service->network may be accessed even though
it has not yet been assigned for sorting purposes.
In this case, it was modified to skip the related logic.

Change-Id: I458b14c1f65afdb55dd1e9c7dd04e2ddc82de6b6
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoDisallow duplicate passphrase decryption requests 53/304853/2 accepted/tizen/7.0/unified/20240130.230247 accepted/tizen/7.0/unified/20240130.230329
Jaehyun Kim [Wed, 24 Jan 2024 09:37:37 +0000 (18:37 +0900)]
Disallow duplicate passphrase decryption requests

If a passphrase decryption request is sent again before a response
to the previous request is received, a memory issue may occur.
To avoid this issue,
a fix has been made to disallow duplicate requests.
And related memory handling errors have also been fixed.

Change-Id: I4a79b1fa9fcd7f14c20497a55a1b8f0a85d5f82a
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoAdd a missing dbus rule for Clock interface 29/304329/1 accepted/tizen/7.0/unified/20240119.092440 accepted/tizen/7.0/unified/20240119.100214
Jaehyun Kim [Tue, 16 Jan 2024 05:14:31 +0000 (14:14 +0900)]
Add a missing dbus rule for Clock interface

Change-Id: I89517116d534248f53c85c46de7dff00e65287a8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 months agoSend power off before DeviceDetected signal 79/303679/1
Jaehyun Kim [Wed, 3 Jan 2024 09:25:09 +0000 (18:25 +0900)]
Send power off before DeviceDetected signal

When the wifi module is removed,
the removed device detected signal is sent before the power off signal,
so there are cases where the power off signal is ignored
on the receiving side.

To solve this issue,
it has been modified to send the power off signal first.

Change-Id: I574bf39ac55b3c8f4555eefeb598c8d28d1a8885
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 months agoRemove unnecessary legacy code 06/303106/1 accepted/tizen/7.0/unified/20231221.170318
Jaehyun Kim [Wed, 20 Dec 2023 04:56:29 +0000 (13:56 +0900)]
Remove unnecessary legacy code

Some legacy code remains that gives wifi the highest priority.
This may cause side effects.
So the relevant code was removed.

Change-Id: Ic5c67081a75a342861c37319382da98c89d3dff8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 months agoMerge "Save newly found APs through spec scan as hidden" into tizen_7.0 accepted/tizen/7.0/unified/20231204.175243
Jaehyun Kim [Thu, 30 Nov 2023 02:18:13 +0000 (02:18 +0000)]
Merge "Save newly found APs through spec scan as hidden" into tizen_7.0

4 months agoSave newly found APs through spec scan as hidden 39/301839/2
Jaehyun Kim [Fri, 24 Nov 2023 09:22:05 +0000 (18:22 +0900)]
Save newly found APs through spec scan as hidden

The specific scan logic has been modified
so that when new APs are discovered through this scan method,
they are all saved as hidden APs.

Change-Id: I194c71f3c29215bad78db171f181593e4c281960
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 months agoFix the use of uninitialized values 48/301948/2 accepted/tizen/7.0/unified/20231128.175801
Jaehyun Kim [Tue, 28 Nov 2023 06:56:45 +0000 (15:56 +0900)]
Fix the use of uninitialized values

Fix the use of uninitialized values
and Remove redundant code.

Change-Id: I70108055a662b0e895e34f67ab6726d3e4b338a8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 months agoAdd Preference-based Network Selection 09/301609/2 accepted/tizen/7.0/unified/20231124.024935
Jaehyun Kim [Mon, 20 Nov 2023 15:23:10 +0000 (00:23 +0900)]
Add Preference-based Network Selection

PNS(Preference-based Network Selectio) feature has been added
as a method for selecting AP.

Change-Id: I73b2a37acb3ccd6c4d2daf9d98ef48732f3d776f
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 months agoAdd ApSelectionMethod config option 08/301608/1
Jaehyun Kim [Mon, 20 Nov 2023 14:35:58 +0000 (23:35 +0900)]
Add ApSelectionMethod config option

Global config option, which allow to select the AP selection method
to use when connecting to an AP.
Existing AP selection methods have also been modified to use this option.

Change-Id: I90b4fc162de6ce435aa691951ad1404c92821bf5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 months agoAdd some options in main.conf for wifi roaming 71/298971/2 accepted/tizen/7.0/unified/20231114.180329
Jaehyun Kim [Mon, 18 Sep 2023 03:05:16 +0000 (12:05 +0900)]
Add some options in main.conf for wifi roaming

1. An option to change the roaming scan interval is added.
2. An option to do a full scan every time
   when try to auto-connect is added.
3. Remove the network added to wpa_supplicant
   when the driver disconnects current network
   if the wifi roaming option is enabled.

Change-Id: Ib4399284ad50b3fd86aeb6d34b1c620a806c8897
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
7 months agoReset wifi roaming scan timer when connected 63/298063/1 accepted/tizen/7.0/unified/20230831.170950
Jaehyun Kim [Thu, 31 Aug 2023 01:25:49 +0000 (10:25 +0900)]
Reset wifi roaming scan timer when connected

- Reset the wifi roaming scan timer when wifi roaming is complete.
- If any of est_throughput is 0 when check the bss condition,
  the est_throughput comparison is ignored.
- Change the roaming scan interval for considering moving devices.

Change-Id: I9fc00e2ca09709f5e23ddc225e02279ca341feaf
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
8 months agoUse estimated throughput for wifi roaming 26/296126/2 accepted/tizen/7.0/unified/20230822.163535
Jaehyun Kim [Tue, 18 Jul 2023 04:21:45 +0000 (13:21 +0900)]
Use estimated throughput for wifi roaming

Added setting options for minimum roaming conditions,
and use estimated throughput for AP-to-AP comparisons.

Change-Id: Ie4eb5930a0511e252f16169c31b439c9f37cba33
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
8 months agoDo not include related code if INS is not enabled 25/296125/1
Jaehyun Kim [Thu, 20 Jul 2023 05:56:25 +0000 (14:56 +0900)]
Do not include related code if INS is not enabled

Change-Id: Idc315a20afb9279fe5b70b4c4582497964882af9
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
8 months agoDo not create config file for ext properties 15/296115/1
Jaehyun Kim [Fri, 26 May 2023 08:38:24 +0000 (17:38 +0900)]
Do not create config file for ext properties

If the service config file does not exist when saving the extended
properties, creating a new config file will create a file
containing only the extended properties.
This is obviously an invalid file and should be handled with
an ERROR in such case.

Change-Id: Ia34da215e1b8a704d16cda572df1acd6d037b3e9
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
8 months agoFix crash issue when passphrase decryption fails 14/296114/1
Jaehyun Kim [Fri, 31 Mar 2023 13:38:29 +0000 (22:38 +0900)]
Fix crash issue when passphrase decryption fails

If the decryption request is successful
and there is an error in response,
memory is not allocated to the data->sid->passphrase.
However, even in this case, it is freed and it cause a crash.
So it has been modified to free only when memory is allocated.

In addition to this, there are other variables
that have similar problems,
so the related codes have also been modified.

Change-Id: If83febbccfcff82cf83279f7186df73aaee0854c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
9 months agoAdd default NTP server in "/var/lib/connman/settings" file 75/294575/1 accepted/tizen/7.0/unified/20230622.035133
Anjali Nijhara [Mon, 19 Jun 2023 08:02:04 +0000 (13:32 +0530)]
Add default NTP server in "/var/lib/connman/settings" file

Change-Id: I57035ce418730c570f562ec690db7f278f0cc0e7

10 months agoclock: Fix TimeserverSynced property updation 94/293494/1 accepted/tizen/7.0/unified/20230601.105725
Jaehyun Kim [Fri, 26 May 2023 04:27:35 +0000 (13:27 +0900)]
clock: Fix TimeserverSynced property updation

Change-Id: I3c66fcf7c639d6a12bbba3e57c153a9c9c712e16
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
13 months agoDA: Fix Profile Save Issue in case of Association Failed 91/289391/2 accepted/tizen/7.0/unified/20230330.152420
Anjali Nijhara [Tue, 7 Mar 2023 04:00:14 +0000 (09:30 +0530)]
DA: Fix Profile Save Issue in case of Association Failed

Change-Id: I8cd918f53ad89e8bf43c76e6efe400d2a058dc3d

15 months agoAdd a dbus signal and a property for DHCP status 58/286658/1 accepted/tizen/7.0/unified/20230118.093741
Jaehyun Kim [Wed, 11 Jan 2023 09:28:18 +0000 (18:28 +0900)]
Add a dbus signal and a property for DHCP status

Signal for DHCP start point has been added.
And the interface name is also delivered to distinguish devices.

Change-Id: I30ac4a48309c5324efb66a36c9dd431e0c847f5e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
15 months agoUpdate client help description for nameservers 38/286238/1
Jaehyun Kim [Mon, 2 Jan 2023 09:46:59 +0000 (18:46 +0900)]
Update client help description for nameservers

Nameserver configuration method can be changed via connmanctl,
but there is no such information in help description.
So help description for nameservers is updated.

Change-Id: I446daa5ed19fbfecc8b58387f37e81a894579bc7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
15 months agoAdd a missing dbus rule for Manager interface 04/285804/1 accepted/tizen/7.0/unified/20221226.020029
Jaehyun Kim [Tue, 20 Dec 2022 10:30:53 +0000 (19:30 +0900)]
Add a missing dbus rule for Manager interface

Change-Id: Id2ce7ea7bbfa0e1da35ae6d40264ea21712fb55d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
16 months agoDA: Modify DHCP request retries count 98/285398/1 accepted/tizen/7.0/unified/20221216.024728
Jaehyun Kim [Mon, 12 Dec 2022 06:18:05 +0000 (15:18 +0900)]
DA: Modify DHCP request retries count

Change-Id: Ib8a332412a954992d20d5f9db3fcd9d0f23eb9e4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
16 months agoDA: Fix build warnings 95/285395/2
Jaehyun Kim [Mon, 12 Dec 2022 06:00:59 +0000 (15:00 +0900)]
DA: Fix build warnings

Change-Id: I7034b55da0b5c364ec5dbbc0395465e700dc3f75
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
16 months agoAdd exception handling for null best_bss 84/285384/1
Jaehyun Kim [Mon, 12 Dec 2022 01:44:25 +0000 (10:44 +0900)]
Add exception handling for null best_bss

Change-Id: Idfed20c90265d4e3df4cd2011a46ff52a72f2872
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
16 months agoSupport PSK_SHA256 for ieee80211w 58/285158/1 accepted/tizen/7.0/unified/20221209.015645
Jaehyun Kim [Wed, 7 Dec 2022 04:25:30 +0000 (13:25 +0900)]
Support PSK_SHA256 for ieee80211w

Change-Id: I4017d2b245a9a5a65fcbbd4ca6c31f45e98b77f2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Reduce debug log 32/283632/1 accepted/tizen/7.0/unified/20221206.171101
Jaehyun Kim [Mon, 31 Oct 2022 14:10:18 +0000 (23:10 +0900)]
DA: Reduce debug log

Don't print service sorting.

Change-Id: I23eab48c293b850a710596b220997afee54bca3d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Skip initializing failed_bssids list when eapol failure case 31/283631/1
Jaehyun Kim [Mon, 31 Oct 2022 14:00:17 +0000 (23:00 +0900)]
DA: Skip initializing failed_bssids list when eapol failure case

This modification is to prevent attempts to connect to only one bssid continuously
during an eapol failure in a multi bssid environment.

Change-Id: I2f5d0dea895f0f3b39bd0e0b15c59db391973b10
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Fix crash issue 30/283630/1
Jaehyun Kim [Mon, 31 Oct 2022 13:32:57 +0000 (22:32 +0900)]
DA: Fix crash issue

Change-Id: Ic46cbf033a7f9ff1b5149b9fceb08bb3cfe2a97a
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Standard error for customer self-diagnosis 29/283629/1
Jaehyun Kim [Mon, 31 Oct 2022 13:28:44 +0000 (22:28 +0900)]
DA: Standard error for customer self-diagnosis

Change-Id: Ie222bb43c0128362324db57554fb9bba3fa7f140
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Modify INS score source code 28/283628/1
Jaehyun Kim [Mon, 31 Oct 2022 13:03:14 +0000 (22:03 +0900)]
DA: Modify INS score source code

1. Modify wrong INS source code & add debug log
2. If INS score is same, align according to the signal strength.

Change-Id: I7dc469ab13c5dbf6bbae020ba711e5f15acd1fb4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Change connection error type AUTH_FAILED to INVALID_KEY in case of SAE 27/283627/1
Jaehyun Kim [Mon, 31 Oct 2022 12:19:41 +0000 (21:19 +0900)]
DA: Change connection error type AUTH_FAILED to INVALID_KEY in case of SAE

Change connman_service_error type from CONNMAN_SERVICE_ERROR_AUTH_FAILED
to CONNMAN_SERVICE_ERROR_INVALID_KEY in case of SAE security type.

Change-Id: Ia276f8da2d83e845b7431a1b89d27fe939d01536
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Set ignore field as true when assoc fails 26/283626/1
Jaehyun Kim [Mon, 31 Oct 2022 12:14:22 +0000 (21:14 +0900)]
DA: Set ignore field as true when assoc fails

Change-Id: Icec37d4758a2637acb8b1c3586c1900747d806f4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Add exception check for time logic 24/283624/1
Jaehyun Kim [Mon, 31 Oct 2022 11:46:26 +0000 (20:46 +0900)]
DA: Add exception check for time logic

1. Ignore next time server if current time server string is empty.
2. Check time_updates_config before set time.

Change-Id: Ifd617686b9eb25d75350d0af3a0f592c7d85ffed
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDA: Add DHCP state notify function 20/283620/2
Jaehyun Kim [Mon, 31 Oct 2022 11:07:34 +0000 (20:07 +0900)]
DA: Add DHCP state notify function

Change-Id: Ie4408b5db690133c74f05dcf3fb94b5dd8eee4df
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoRemove useless network path of the wifi interface when removing network 69/283569/1
Jaehyun Kim [Sat, 29 Oct 2022 05:33:50 +0000 (14:33 +0900)]
Remove useless network path of the wifi interface when removing network

When removing a network, if the network path of the interface is not NULL
and has the same information as the network to be removed, it need to be removed.

Otherwise, when a connection to the same network is attempted later,
the connection may not work normally.

Change-Id: Ia1702c05bb19c581b31070fbc7741a846d87a6ee
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
18 months agoCheck dbus path before constructing AddNetwork message 71/282371/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.061230 accepted/tizen/7.0/unified/hotfix/20221116.110650 accepted/tizen/unified/20221005.023218 tizen_7.0_m2_release
Jaehyun Kim [Fri, 30 Sep 2022 09:01:12 +0000 (18:01 +0900)]
Check dbus path before constructing AddNetwork message

>0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
>1  0xb6bf0788 in __GI_abort () at abort.c:79
>2  0xb6e63a9c in _dbus_abort () at dbus-sysdeps.c:93
>3  0xb6e58278 in _dbus_warn_check_failed (format=0xb6e69e1c "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:281
>4  0xb6e58980 in _dbus_warn_return_if_fail (function=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=line@entry=1582) at dbus-internals.c:936
>5  0xb6e47c7c in dbus_message_new_method_call (destination=0x51a004 "fi.w1.wpa_supplicant1", path=path@entry=0x6bebf8 "", iface=iface@entry=0x519fa8 "fi.w1.wpa_supplicant1.Interface", method=method@entry=0x51a4c8 "AddNetwork") at dbus-message.c:1582
>6  0x004bdbda in supplicant_dbus_method_call (path=0x6bebf8 "", interface=0x519fa8 "fi.w1.wpa_supplicant1.Interface", method=0x51a4c8 "AddNetwork", setup=0x4baf7d <interface_add_network_params>, function=0x4b985d <interface_add_network_result>, user_data=user_data@entry=0x6d05f0, caller=0x6d9900) at gsupplicant/dbus.c:508
>7  0x004b64d8 in decryption_request_reply (call=0x6b25c0, user_data=0x6d05f0) at gsupplicant/supplicant.c:7653
...

Change-Id: Ib65368a6a43c81376ae65bd5338d796bc7ad755c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
18 months agoSupport ft-psk and ft-sae connection 98/281498/2 accepted/tizen/unified/20220923.052717
Jaehyun Kim [Mon, 19 Sep 2022 12:49:30 +0000 (21:49 +0900)]
Support ft-psk and ft-sae connection

Change-Id: I05d8d3934a8a75c874b41cb44654b7bc61b34060
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
18 months agoFix dereferencing issues 17/281417/1 accepted/tizen/unified/20220920.110641
Jaehyun Kim [Fri, 16 Sep 2022 14:13:01 +0000 (23:13 +0900)]
Fix dereferencing issues

Change-Id: I8ec97355b5ebf673d792339a7d0a2911392d6a89
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
19 months agoFix crash when disabling connected wifi 35/280835/1 accepted/tizen/unified/20220908.172942
Jaehyun Kim [Mon, 5 Sep 2022 12:39:51 +0000 (21:39 +0900)]
Fix crash when disabling connected wifi

This issue is caused by trying to access invalid
connman_network when wifi is disabled.
In this case, there is no need to reset the value.

Change-Id: I3137ba91a11086ae5e8f8f976dc52f84d62d4975
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
19 months agoMaintain connection status when wifi roaming 36/280036/1 submit/tizen/20220829.114301 submit/tizen/20220902.085939
Jaehyun Kim [Mon, 22 Aug 2022 17:15:07 +0000 (02:15 +0900)]
Maintain connection status when wifi roaming

When wifi roaming, the current connection status is maintained.
If the network is changed, the connection status is reset.

Change-Id: I2680030c849c712b7d7dc68f70397514484a7fc3
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
20 months agoCheck dbus path before constructing a new message 67/279067/3 accepted/tizen/unified/20220802.144710 submit/tizen/20220802.050734
Jaehyun Kim [Mon, 1 Aug 2022 11:34:24 +0000 (20:34 +0900)]
Check dbus path before constructing a new message

>0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 --> glibc (rpm)
>1  0xf7248780 in __GI_abort () at abort.c:79 --> glibc (rpm)
>2  0xf74ba7ac in _dbus_abort () at dbus-sysdeps.c:93 --> dbus-libs (rpm)
>3  0xf74af0d0 in _dbus_warn_check_failed (format=0xf74c05fc "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:281 --> dbus-libs (rpm)
>4  0xf74af7d8 in _dbus_warn_return_if_fail (function=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=line@entry=1582) at dbus-internals.c:936 --> dbus-libs (rpm)
>5  0xf749eba0 in dbus_message_new_method_call (destination=0xaacc16a4 "fi.w1.wpa_supplicant1", path=path@entry=0xac126b78 "", iface=iface@entry=0xaacc1648 "fi.w1.wpa_supplicant1.Interface", method=method@entry=0xaacc1b40 "AddNetwork") at dbus-message.c:1582 --> dbus-libs (rpm)
>6  0xaac671d8 in supplicant_dbus_method_call (path=0xac126b78 "", interface=0xaacc1648 "fi.w1.wpa_supplicant1.Interface", method=0xaacc1b40 "AddNetwork", setup=0xaac64605 <interface_add_network_params>, function=0xaac62fb1 <interface_add_network_result>, user_data=user_data@entry=0xac125138, caller=0xac13ef30) at gsupplicant/dbus.c:505 --> connman (rpm)
>7  0xaac5faee in decryption_request_reply (call=0xac12b080, user_data=0xac125138) at gsupplicant/supplicant.c:7629 --> connman (rpm)

Change-Id: I87558f1894607bea53ecf7b3602f16d1e5aae5ac
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
22 months agoFix derefrencing of invalid pointer 93/275893/1 accepted/tizen/unified/20220620.131713 submit/tizen/20220617.053331
Jaehyun Kim [Sun, 5 Jun 2022 11:39:41 +0000 (20:39 +0900)]
Fix derefrencing of invalid pointer

Change-Id: I1414eb584a0644423aef07511f68c0be4b63c911
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
22 months agoTry to connect to another bssid in AUTH or ASSOCICATED failure case 90/275890/2
Jaehyun Kim [Sat, 4 Jun 2022 14:55:17 +0000 (23:55 +0900)]
Try to connect to another bssid in AUTH or ASSOCICATED failure case

When attempting to connect to an AP with multiple bssids,
if it fails in the AUTHENTICATING or ASSOCIATED state,
the connection continues to be attempted with the same bssid.
In this case, it has been modified to try to connect to another bssid.

Change-Id: Ied521e01c71e8c6c916d56dc825578d8edd20e0c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
22 months agowispr: Prevent use-after-free from __connman_wispr_stop() 63/275463/2 accepted/tizen/unified/20220530.140608 submit/tizen/20220527.121228
Seung-Woo Kim [Tue, 24 May 2022 09:59:21 +0000 (18:59 +0900)]
wispr: Prevent use-after-free from __connman_wispr_stop()

From __connman_wispr_stop(), list element wispr_portal freed by
g_hash_table_remove() is accessed. Prevent the use-after-free by
accessing the list element before free.

Change-Id: I17fdb38c1d9a0f8dd2980c33d3f78f319f504ed6

22 months agoFix memory leak when loading global settings 49/275449/2
Jaehyun Kim [Wed, 25 May 2022 04:24:41 +0000 (13:24 +0900)]
Fix memory leak when loading global settings

Change-Id: Ie7d00c2f856d2d6d8e7ea86d17c013e787259680
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
23 months agoReinitialize the va_list when reusing it 32/274932/1 accepted/tizen/unified/20220524.050402 submit/tizen/20220517.032302
Jaehyun Kim [Thu, 12 May 2022 07:59:13 +0000 (16:59 +0900)]
Reinitialize the va_list when reusing it

Change-Id: I4ae7c752c09f328cba522b25f8acb05e80425cef
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoAdd main.conf for robot profile 13/273813/1 accepted/tizen/unified/20220415.130340 submit/tizen/20220414.094032
Jaehyun Kim [Thu, 14 Apr 2022 04:25:20 +0000 (13:25 +0900)]
Add main.conf for robot profile

Change-Id: Ifa2f0c8ab1bbb5925bc468206ed0fe0c8b743489
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix EAP-TLS Wi-Fi connection issue 66/272466/1
Niraj Kumar Goit [Thu, 17 Mar 2022 06:48:56 +0000 (12:18 +0530)]
Fix EAP-TLS Wi-Fi connection issue

Change-Id: I70fd374d89488e1d30f489356a5d8a4041c5f491
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoFix wifi connection issue post invalid-key error occurs. 14/272314/2 accepted/tizen/unified/20220315.132317 submit/tizen/20220314.173759
Anjali Nijhara [Mon, 14 Mar 2022 11:10:24 +0000 (16:40 +0530)]
Fix wifi connection issue post invalid-key error occurs.

Change-Id: I7a9c7184502a3a74a8be6e92be7c08d41b878612

2 years agoModified vpn/vpn-dbus.conf file 16/271916/1 submit/tizen/20220304.063107 submit/tizen/20220310.020044
Anjali Nijhara [Thu, 3 Mar 2022 06:33:03 +0000 (12:03 +0530)]
Modified vpn/vpn-dbus.conf file

Change-Id: Ic2dbd5445cf89d8ad7e54787d14f4ff690b9c89c
Signed-off-by: Anjali Nijhara <a.nijhara@samsung.com>
2 years agoMerge tag 'upstream/1.40' into tizen. 79/271279/4 submit/tizen/20220224.061208
Niraj Kumar Goit [Thu, 17 Feb 2022 16:13:13 +0000 (21:43 +0530)]
Merge tag 'upstream/1.40' into tizen.

Change-Id: I4ed89827d776db6eeec11878bc1cd0cd6c5e1e80
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Signed-off-by: Anjali Nijhara <a.nijhara@samsung.com>
2 years agoImported Upstream version 1.40 64/271064/1 upstream/1.40
Niraj Kumar Goit [Tue, 15 Feb 2022 04:53:07 +0000 (10:23 +0530)]
Imported Upstream version 1.40

Change-Id: Id3e405d088ee3fb19fd0ca049e1cb7f812b40fca
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoAdd support to get PMF information 31/271031/1 accepted/tizen/unified/20220216.175734 submit/tizen/20220215.060643
Jaehyun Kim [Mon, 14 Feb 2022 10:16:29 +0000 (19:16 +0900)]
Add support to get PMF information

Change-Id: I7286c346750504175e24cbb569404e586b309a85
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix NULL dereferencing 93/269893/1 accepted/tizen/unified/20220126.213040 submit/tizen/20220125.082819
Jaehyun Kim [Fri, 21 Jan 2022 08:38:39 +0000 (17:38 +0900)]
Fix NULL dereferencing

Change-Id: I7d49d35c42e7550f42007935859609adbb938d51
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoAdd support for handling wifi authentication failure 62/269362/1 accepted/tizen/unified/20220119.121745 submit/tizen/20220118.052414
Jaehyun Kim [Thu, 13 Jan 2022 07:12:30 +0000 (16:12 +0900)]
Add support for handling wifi authentication failure

Change-Id: I770e67fa3ed17758c745469cc51ecdc08d591708
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix dereference after null check 40/269040/2 accepted/tizen/unified/20220114.130209 submit/tizen/20220111.044041
Jaehyun Kim [Fri, 7 Jan 2022 03:12:15 +0000 (12:12 +0900)]
Fix dereference after null check

Change-Id: If0c7f97ce58436c6cce1debf92f2fafb407ff9fe
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Remove libbpf code from connMan" into tizen submit/tizen/20220111.042706
Jaehyun Kim [Thu, 6 Jan 2022 05:38:04 +0000 (05:38 +0000)]
Merge "Remove libbpf code from connMan" into tizen

2 years agoEnable ipv6 again after removing autoconfigured address 22/268922/1
Seonah Moon [Wed, 5 Jan 2022 01:36:03 +0000 (10:36 +0900)]
Enable ipv6 again after removing autoconfigured address

Until now, ipv6 has been disabled to remove autoconfigured addresses quickly
when wifi disconnecting.
However, as a result, the ipv6 link local address of wlan0 was erased,
which later affected the operation of using wlan0 like softap.
This patch restores ipv6 for consistency.

Change-Id: I7cf2790d39f62579b59083d6abb136763202b2bd

2 years agoRemove libbpf code from connMan 75/268875/2
Niraj Kumar Goit [Tue, 4 Jan 2022 05:56:41 +0000 (11:26 +0530)]
Remove libbpf code from connMan

Change-Id: I63ce1f9f574b53b93da5dac9ff34031e409c8a98
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoFix WPA3 Multi-bssid Issue 07/268707/2 accepted/tizen/unified/20220105.120844 submit/tizen/20211230.103710
Anjali Nijhara [Thu, 30 Dec 2021 06:46:10 +0000 (12:16 +0530)]
Fix WPA3 Multi-bssid Issue

Change-Id: I30167b693493e4a2b260b44cac4819bc40aefd80

2 years agoChange the roaming scan interval 47/268647/1 submit/tizen/20211230.063452
Jaehyun Kim [Tue, 28 Dec 2021 13:41:31 +0000 (22:41 +0900)]
Change the roaming scan interval

If no AP is found to roam, change the scan interval
to minimize performance degradation due to frequent scans.

Change-Id: I1d655fa0d2215358531f772b6d697e537ed3a2d5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoStart wifi roaming when better BSS is found 82/268282/4
Jaehyun Kim [Mon, 20 Dec 2021 03:11:43 +0000 (12:11 +0900)]
Start wifi roaming when better BSS is found

If better BSS is found after roaming scan, roaming starts.

Change-Id: I9812f3a0205021e1cecb9696ebc29947fd44dae4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Start scan for wifi roaming when SNR and signal are weakened" into tizen
Jaehyun Kim [Sun, 19 Dec 2021 11:32:46 +0000 (11:32 +0000)]
Merge "Start scan for wifi roaming when SNR and signal are weakened" into tizen

2 years agogdhcp: Avoid reading invalid data in dhcp_get_option 89/268089/1
Niraj Kumar Goit [Thu, 16 Dec 2021 05:41:50 +0000 (11:11 +0530)]
gdhcp: Avoid reading invalid data in dhcp_get_option

Reference:
https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=58d397ba74873384aee449690a9070bacd5676fa

Change-Id: I44c6e1f0448ed8fb5b1955da6458fe67c8ff56cb
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoMerge "service: Add a new property 'SecurityList'" into tizen accepted/tizen/unified/20211216.155835 submit/tizen/20211215.063645
Jaehyun Kim [Wed, 8 Dec 2021 01:41:05 +0000 (01:41 +0000)]
Merge "service: Add a new property 'SecurityList'" into tizen

2 years agoMerge "Use the default logic when not using INS" into tizen
Jaehyun Kim [Wed, 8 Dec 2021 01:40:56 +0000 (01:40 +0000)]
Merge "Use the default logic when not using INS" into tizen

2 years agoMerge "Fix an incorrect value being used for signal score calculation" into tizen
Jaehyun Kim [Tue, 7 Dec 2021 07:39:34 +0000 (07:39 +0000)]
Merge "Fix an incorrect value being used for signal score calculation" into tizen

2 years agoservice: Add a new property 'SecurityList' 29/267529/1
Jaehyun Kim [Mon, 6 Dec 2021 17:30:13 +0000 (02:30 +0900)]
service: Add a new property 'SecurityList'

A property has been added
to get the list of supported security methods

Change-Id: I8dda00ae4cbb924436cec53acbf8693a6ef630fb
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoUse the default logic when not using INS 29/267429/2
Jaehyun Kim [Fri, 3 Dec 2021 09:48:15 +0000 (18:48 +0900)]
Use the default logic when not using INS

1. Use signal strength for bssid sorting
2. Send a signal when service->connect_reason is changed

Change-Id: Ia7b1598f9de34440ae1cad5b773784ca769603e4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Use TIZEN_EXT_INS for INS related code" into tizen
Jaehyun Kim [Thu, 2 Dec 2021 05:26:41 +0000 (05:26 +0000)]
Merge "Use TIZEN_EXT_INS for INS related code" into tizen

2 years agoFix an incorrect value being used for signal score calculation 05/265405/3
Jaehyun Kim [Mon, 18 Oct 2021 10:24:51 +0000 (19:24 +0900)]
Fix an incorrect value being used for signal score calculation

Change-Id: Ie09830257b804efdfb6990b9ea7030ba497ac542
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoRegister with system bus in container environment 26/266426/1 accepted/tizen/unified/20211129.120836 submit/tizen/20211117.050637 submit/tizen/20211125.124313 submit/tizen/20211126.045758
Jaehyun Kim [Fri, 12 Nov 2021 06:15:06 +0000 (15:15 +0900)]
Register with system bus in container environment

Change-Id: I5fe36fdce42ffca6f3f6587923b42d4b5fec61d4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Disabled in container environment" into tizen
Jaehyun Kim [Thu, 11 Nov 2021 09:03:50 +0000 (09:03 +0000)]
Merge "Disabled in container environment" into tizen

2 years agoAdd dbus configuration for robot profile 19/266219/2
cheoleun moon [Tue, 9 Nov 2021 07:56:05 +0000 (16:56 +0900)]
Add dbus configuration for robot profile

Change-Id: If05b36fbbbb58a428d9c5b2c01da8a4d4892e3e5

2 years agoDisabled in container environment 41/265841/3
Jaehyun Kim [Fri, 29 Oct 2021 10:16:39 +0000 (19:16 +0900)]
Disabled in container environment

Disable the container's network daemons to avoid conflicts
because they use the same network namespace.

Change-Id: I0e19fc7df608df39f5936f3082858f6f16415f3d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoRemove net-config dependency 21/265821/1 submit/tizen/20211029.071904
Jaehyun Kim [Fri, 29 Oct 2021 07:08:46 +0000 (16:08 +0900)]
Remove net-config dependency

Change-Id: I28e301a36dbf59cf529fe9c945a4c6278357d77b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Update settings when device information in device_list is changed" into tizen
Jaehyun Kim [Fri, 29 Oct 2021 06:56:00 +0000 (06:56 +0000)]
Merge "Update settings when device information in device_list is changed" into tizen

2 years agoUse TIZEN_EXT_INS for INS related code 27/265627/3
Nishant Chaprana [Mon, 25 Oct 2021 11:39:59 +0000 (17:09 +0530)]
Use TIZEN_EXT_INS for INS related code

Change-Id: I70f6722e1dcd8898eab2c504e377c65f425461e1
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoUpdated libbpf.so to link with libelf.so.1 01/265401/2 submit/tizen/20211021.102523
Nishant Chaprana [Mon, 18 Oct 2021 07:35:42 +0000 (13:05 +0530)]
Updated libbpf.so to link with libelf.so.1

Change-Id: Id2328db95c05e74cfdd7baaa4ff5476181b3a601
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoUpdate settings when device information in device_list is changed 98/265398/1
Jaehyun Kim [Mon, 18 Oct 2021 07:30:41 +0000 (16:30 +0900)]
Update settings when device information in device_list is changed

Modified to update enabled device information in settings
when the powered value of each device in device_list is changed.

Change-Id: I3ed4f236d747b9f979b23da19edbe1c248783f54
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix incorrect handling in multi-interface environment 71/265371/2
Jaehyun Kim [Fri, 15 Oct 2021 11:59:35 +0000 (20:59 +0900)]
Fix incorrect handling in multi-interface environment

1. Modified to save enabled device information
   in settings after device_list is updated.
2. Modified to save enabled device information
   in settings only for wifi technology.

Change-Id: I1b05319adcd3fa7796e764912c9369a5ac28ab7e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoStart scan for wifi roaming when SNR and signal are weakened 03/264903/4
Jaehyun Kim [Mon, 4 Oct 2021 16:09:08 +0000 (01:09 +0900)]
Start scan for wifi roaming when SNR and signal are weakened

If SNR is less than 20 or RSSI level is less than 3,
scan for BSS transition is started.

Change-Id: I69c1e3e9a42ddb5f6087d580ff2c15c7086317d2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Reply all multiple/simultaenous SetDevicePower method call" into tizen accepted/tizen/6.5/unified/20211028.225128 accepted/tizen/unified/20210928.073034 submit/tizen/20210928.013804 submit/tizen_6.5/20211028.163301 tizen_6.5.m2_release
Jaehyun Kim [Mon, 27 Sep 2021 06:47:38 +0000 (06:47 +0000)]
Merge "Reply all multiple/simultaenous SetDevicePower method call" into tizen

2 years agoReply all multiple/simultaenous SetDevicePower method call 75/264575/1
Nishant Chaprana [Fri, 24 Sep 2021 13:05:37 +0000 (18:35 +0530)]
Reply all multiple/simultaenous SetDevicePower method call

This patch fixes an issue where Multiple/Simultaenous SetDevicePower
method calls are made and reply is sent to only last dbus caller.

Change-Id: I61e1f5e5b8645dee41910a1b6ea51a405e6024a4
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoUpdate connman settings for single device as well 96/264496/1
Niraj Kumar Goit [Thu, 23 Sep 2021 08:01:50 +0000 (13:31 +0530)]
Update connman settings for single device as well

Change-Id: Ic1ee92050bebd631d1738b9b68152052589e3e77
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoFix: Memory leak issue when tokenizing string 56/264456/1 accepted/tizen/unified/20210924.055913 submit/tizen/20210924.013637
Nishant Chaprana [Mon, 20 Sep 2021 07:26:32 +0000 (12:56 +0530)]
Fix: Memory leak issue when tokenizing string

Change-Id: I71e88bb35384cf919263fa5dda8c4f0f06be6ef2
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2 years agoAdd support of bpf 49/263749/5 accepted/tizen/unified/20210916.005908 submit/tizen/20210915.122117 submit/tizen/20210915.152151
Jaehyun Kim [Thu, 9 Sep 2021 09:07:45 +0000 (18:07 +0900)]
Add support of bpf

Change-Id: Iaa5566a1be143ede38832cdd8639111fc26b4586
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoEnable Downgrade dbus method. 52/263752/1
Niraj Kumar Goit [Thu, 9 Sep 2021 09:34:10 +0000 (15:04 +0530)]
Enable Downgrade dbus method.

When offline is detected in device, downgrade service state to ready
and start online check in connman.

Change-Id: Ic5abf9050c51b853ee36fa8067b221c3e9c63eec
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoFix resource leak 10/263710/1 accepted/tizen/unified/20210915.025055 submit/tizen/20210908.150016 submit/tizen/20210909.045500
Jaehyun Kim [Wed, 8 Sep 2021 12:44:57 +0000 (21:44 +0900)]
Fix resource leak

Change-Id: Ic3c9199d0dac7e614743043cdeb5ad1616eb1aa1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMerge "Fix build failure when tizen-maintain-online feature is enabled" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:51:07 +0000 (06:51 +0000)]
Merge "Fix build failure when tizen-maintain-online feature is enabled" into tizen

2 years agoFix Crash in connman-vpnd in reboot scenario when config file is present 10/262610/2
Niraj Kumar Goit [Mon, 16 Aug 2021 12:15:49 +0000 (17:45 +0530)]
Fix Crash in connman-vpnd in reboot scenario when config file is present

Change-Id: I3cfccf9f53bfbd92974e1dbba65a6952f21f6c19
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoMerge "wireguard: Add routes for allowedIPs" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:45:19 +0000 (06:45 +0000)]
Merge "wireguard: Add routes for allowedIPs" into tizen

2 years agoMerge "wireguard: Save plugin related settings in config file" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:45:07 +0000 (06:45 +0000)]
Merge "wireguard: Save plugin related settings in config file" into tizen

2 years agoMerge "vpn: Make domain parameter optional" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:53 +0000 (06:44 +0000)]
Merge "vpn: Make domain parameter optional" into tizen

2 years agoMerge "Enable Wireguard VPN Plugin" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:35 +0000 (06:44 +0000)]
Merge "Enable Wireguard VPN Plugin" into tizen

2 years agoMerge "wireguard: Copy interfance names obeying lengths rules" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:16 +0000 (06:44 +0000)]
Merge "wireguard: Copy interfance names obeying lengths rules" into tizen