platform/upstream/connman.git
3 years agoFix auto connection failure 24/249824/1 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/hotfix/20201218.015407 submit/tizen_6.0_hotfix/20201217.061918
Jaehyun Kim [Thu, 15 Oct 2020 13:32:17 +0000 (22:32 +0900)]
Fix auto connection failure

If there is more than one connection history, auto-connection is failing.
This problem occurs because two APs try to connect to the same interface at the same time.
So fixed to prevent duplicate connection attempts on the same interface.

Change-Id: If5da80db089c9607579f943d023565c999a5576b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoFix derefrencing of NULL pointer 22/249822/1
Jaehyun Kim [Wed, 11 Nov 2020 11:12:49 +0000 (20:12 +0900)]
Fix derefrencing of NULL pointer

In some cases network->device could be NULL which leads to crash

Change-Id: I14210822179f0d8ecbc8bcd046700d1118409cbd
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoFix an issue where the log option is applied incorrectly 53/245353/1 accepted/tizen/6.0/unified/20201030.105121 accepted/tizen/6.0/unified/hotfix/20201102.235749 accepted/tizen/unified/20201008.043010 submit/tizen/20201007.120259 submit/tizen_6.0/20201029.205501 submit/tizen_6.0_hotfix/20201102.192901 submit/tizen_6.0_hotfix/20201103.115101 tizen_6.0.m2_release
Jaehyun Kim [Wed, 7 Oct 2020 11:57:48 +0000 (20:57 +0900)]
Fix an issue where the log option is applied incorrectly

Change-Id: I57db81c2670b769bbedafb3e3d9db02218516bca
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMerge "Add support for dlog" into tizen
Jaehyun Kim [Wed, 7 Oct 2020 11:08:12 +0000 (11:08 +0000)]
Merge "Add support for dlog" into tizen

3 years agoAdd support for dlog 02/245302/3
Jaehyun Kim [Wed, 7 Oct 2020 02:08:26 +0000 (11:08 +0900)]
Add support for dlog

1. Add support for dlog
2. Add some log options to main.conf
3. Allow to simplify the amount of logs by option

Change-Id: I8c1202ae267aca9bb2c18d44c2ccd3e6d5a74a73
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years ago[Fix][src/service] Add 'fall through' comment when break statement is not needed 69/245069/2
Nishant Chaprana [Wed, 30 Sep 2020 10:36:19 +0000 (16:06 +0530)]
[Fix][src/service] Add 'fall through' comment when break statement is not needed

Change-Id: Iff3cac79bc3f3ede61f90ab688cfbebcbc374221
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years ago[Fix][plugin/ethernet] SVACE warning DEREF_AFTER_NULL 67/245067/2
Nishant Chaprana [Wed, 30 Sep 2020 10:10:18 +0000 (15:40 +0530)]
[Fix][plugin/ethernet] SVACE warning DEREF_AFTER_NULL

Change-Id: Ie3a9044de3be7ce46d05052920f9d5b5d99cd15f
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoFix incorrect dbus usage that caused crash 52/244852/1 accepted/tizen/unified/20201006.044352 submit/tizen/20200925.132900 submit/tizen/20201005.112026
Jaehyun Kim [Fri, 25 Sep 2020 05:45:55 +0000 (14:45 +0900)]
Fix incorrect dbus usage that caused crash

Change-Id: Ifd11a65d3182533d210401fbce4c5fb9b6504b0d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoThe order between the device signal and the service signal has been changed 73/244273/1 accepted/tizen/unified/20200921.095121 submit/tizen/20200917.115639 submit/tizen/20200918.062939
Jaehyun Kim [Wed, 16 Sep 2020 13:39:40 +0000 (22:39 +0900)]
The order between the device signal and the service signal has been changed

Net-config is implemented assuming that the DeviceChanged signal comes before the service PropertyChanged signal.
Therefore, the event order has been adjusted accordingly.

Change-Id: I134ec7152a0e40bbfe317c704a91ca81fc01dc1c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoFix build warnings 44/243944/1
Jaehyun Kim [Fri, 11 Sep 2020 08:29:38 +0000 (17:29 +0900)]
Fix build warnings

Change-Id: I43c65427f5b6e0eb003ac3c17c012cd9b7db0f76
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoRemove DefaultDependencies=false at connman.service 61/243861/1
Jaehyun Kim [Thu, 10 Sep 2020 13:05:00 +0000 (22:05 +0900)]
Remove DefaultDependencies=false at connman.service

connman.service has "After=net-config.service" dependency.
But net-config.service don't have DefaultDependencies=no.

So "DefaultDependencies=false" does not have any effect on connman.service, but instead it is confusing.

Change-Id: I52dff5dc4a33deceed87b47ff1aaa05b2f049f8e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoFix derefrencing of NULL pointer 13/242813/1 accepted/tizen/unified/20200903.151723 submit/tizen/20200901.053326 submit/tizen/20200902.111409 submit/tizen/20200903.044940
Jaehyun Kim [Tue, 1 Sep 2020 05:20:41 +0000 (14:20 +0900)]
Fix derefrencing of NULL pointer

In some cases wifi->network is NULL which leads to crash

Change-Id: Ie02bb6a84f25d816935b492169feed2aca7f76b8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMove GetInterfaces method to Manager interface 07/242807/1
Jaehyun Kim [Tue, 1 Sep 2020 03:11:34 +0000 (12:11 +0900)]
Move GetInterfaces method to Manager interface

Change-Id: I4e9cd93717a04457f97bf13fc389075a3e5c0e54
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoAdd support for handling multiple wifi interfaces 43/242543/1 submit/tizen/20200828.142119
Jaehyun Kim [Thu, 27 Aug 2020 14:32:34 +0000 (23:32 +0900)]
Add support for handling multiple wifi interfaces

Change-Id: I4762c8d3444167dce34498634de4948e822f865f
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoSvace Fix: memory leak 99/240799/4
Rahul Jain [Tue, 11 Aug 2020 12:04:12 +0000 (17:34 +0530)]
Svace Fix: memory leak

Change-Id: Id10ede540b99d028f6ff40225b4dfcccb46d7fe0

3 years agoUse ref counting for network during SignalPoll method call of wpa_supplicant. 30/240230/3 accepted/tizen/unified/20200812.144017 submit/tizen/20200811.004738
Nishant Chaprana [Tue, 4 Aug 2020 12:45:24 +0000 (18:15 +0530)]
Use ref counting for network during SignalPoll method call of wpa_supplicant.

Description: This patch fixes the issue in which dangling network pointer
is present as user_data of signalpoll_callback.

This dangling pointer crashes connman with below backtrace:-

>>> bt
\#0  connman_device_get_ident (device=0x6e6f632f) at src/device.c:592
\#1  0xb6f54994 in __connman_network_get_ident (network=network@entry=0xb87715b0) at src/network.c:1560
\#2  0xb6f652da in connman_service_lookup_from_network (network=network@entry=0xb87715b0) at src/service.c:10177
\#3  0xb6f655ee in __connman_service_notify_strength_changed (network=network@entry=0xb87715b0) at src/service.c:10523
\#4  0xb6f5527c in connman_network_set_strength (network=network@entry=0xb87715b0, strength=strength@entry=69 'E') at src/network.c:2704
\#5  0xb6f36ac0 in signalpoll_callback (result=<optimized out>, maxspeed=39, strength=69, user_data=0xb87715b0) at plugins/wifi.c:3866
\#6  0xb6f3b68e in interface_signalpoll_result (error=<optimized out>, iter=<optimized out>, user_data=0xb8782af8) at gsupplicant/supplicant.c:6348
\#7  0xb6f4335a in method_call_reply (call=0xb8771ec0, user_data=0xb8782c98) at gsupplicant/dbus.c:476
\#8  0xb6da23a4 in ?? () from /lib/libdbus-1.so.3
\#9  0xb6da5fa0 in dbus_connection_dispatch () from /lib/libdbus-1.so.3
\#10 0xb6f94dce in message_dispatch (data=0xb875fe78) at gdbus/mainloop.c:72
\#11 0xb6e21d84 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
\#12 0xb6e22008 in ?? () from /lib/libglib-2.0.so.0
\#13 0xb6e22268 in g_main_loop_run () from /lib/libglib-2.0.so.0
\#14 0xb6f29d3e in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:1373

Change-Id: Ia171c2ddabf6a4f9c3d6a6bbd3763398b6e0ce46
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoSvace issues: Null check and memory leaks 70/239070/2 accepted/tizen/unified/20200805.122502 submit/tizen/20200730.084504 submit/tizen/20200804.104340
Rahul Jain [Tue, 21 Jul 2020 11:18:45 +0000 (16:48 +0530)]
Svace issues: Null check and memory leaks

Change-Id: I937af7e6dbe3a919c1d0b0d7dee4b481c2ef0982

3 years agoChange the service file path for 64bit build 26/237026/1 accepted/tizen/unified/20200626.133553 submit/tizen/20200624.065138
Jaehyun Kim [Wed, 24 Jun 2020 06:27:40 +0000 (15:27 +0900)]
Change the service file path for 64bit build

Change-Id: I4ae421d7428aa3d0a70f1c66fef736b5710739b2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMerge "Add to check ins status on client" into tizen submit/tizen/20200610.045555
hyunuk tak [Wed, 10 Jun 2020 04:54:48 +0000 (04:54 +0000)]
Merge "Add to check ins status on client" into tizen

3 years agoAdd omitted TIZEN_EXT 88/235688/1
Jaehyun Kim [Tue, 9 Jun 2020 02:23:36 +0000 (11:23 +0900)]
Add omitted TIZEN_EXT

Change-Id: I44227340c3a408711756a2bf4ccfb860ef44170b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoAdd to check ins status on client 83/234483/1
hyunuk.tak [Tue, 26 May 2020 23:33:52 +0000 (08:33 +0900)]
Add to check ins status on client

Change-Id: I3224dc06110f6c0063fa082b713cb2aaa13a3a1f
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
3 years agoMerge "supported OWE Transition mode" into tizen accepted/tizen/unified/20200529.124226 submit/tizen/20200528.074637
Jiung Yu [Mon, 25 May 2020 04:27:36 +0000 (04:27 +0000)]
Merge "supported OWE Transition mode" into tizen

3 years agoMerge "Block all extra scans caused by ConnMan" into tizen
cheoleun moon [Mon, 25 May 2020 02:17:01 +0000 (02:17 +0000)]
Merge "Block all extra scans caused by ConnMan" into tizen

3 years agosupported OWE Transition mode 06/234106/2
Jinwon Kim [Wed, 20 May 2020 04:28:12 +0000 (13:28 +0900)]
supported OWE Transition mode

Change-Id: I6dd1cb437ac16c0428df4d5bc812fefb36543c6d
Signed-off-by: Jinwon Kim <jinwon0325.kim@samsung.com>
3 years agoFix wrong length for format string 42/233742/1 accepted/tizen/unified/20200519.035055 submit/tizen/20200519.021428
Yu [Tue, 19 May 2020 01:37:39 +0000 (10:37 +0900)]
Fix wrong length for format string

Change-Id: I11c0eee0076be37b17ec5ffaff92c72975d29d8f
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
3 years agoMerge "Add logic to detect buffer overflow for snprintf" into tizen submit/tizen/20200518.041610
Jiung Yu [Mon, 18 May 2020 04:14:59 +0000 (04:14 +0000)]
Merge "Add logic to detect buffer overflow for snprintf" into tizen

3 years agoAdd logic to detect buffer overflow for snprintf 24/233524/3
Yu [Fri, 15 May 2020 07:01:39 +0000 (16:01 +0900)]
Add logic to detect buffer overflow for snprintf

Change-Id: I60f835aeed101ef61a2bbb73bf2fc8c2c7327d50
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
3 years agogsupplicant: update an interface state in GetInterface callback 22/233522/1
Seonah Moon [Fri, 15 May 2020 06:58:50 +0000 (15:58 +0900)]
gsupplicant: update an interface state in GetInterface callback

Change-Id: I9530c2c897c4ed2aae0b90580012ce6c930e3a90

3 years agoHandle the case that best_bss is NULL 78/233278/2 submit/tizen/20200513.103127
Cheoleun Moon [Wed, 13 May 2020 10:19:08 +0000 (19:19 +0900)]
Handle the case that best_bss is NULL

Change-Id: I4a813bb3327f400df0050a850ec72fa8b99c870b
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
3 years agoCreate interface first when enable Wi-Fi 07/233107/5 accepted/tizen/unified/20200512.144346 submit/tizen/20200512.123850
Seonah Moon [Tue, 12 May 2020 07:29:48 +0000 (16:29 +0900)]
Create interface first when enable Wi-Fi

Change-Id: Id801b6dd6bfcfaa2cb2daefed9e6c37d7cb861bc

3 years agoBlock all extra scans caused by ConnMan 00/232900/1
Jaehyun Kim [Fri, 8 May 2020 07:52:30 +0000 (16:52 +0900)]
Block all extra scans caused by ConnMan

Even if BackgroundScanning is disabled, a passive scan(full scan) is performed automatically after an active scan.
However, this function is not necessary because we already added a separate scan logic to fit our requirement.

Change-Id: I5ac24a35d9b61c44bbbd2ddb7688cb26a63fc2b7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoMerge "Remove RW upgrade script" into tizen
Jaehyun Kim [Fri, 8 May 2020 02:46:34 +0000 (02:46 +0000)]
Merge "Remove RW upgrade script" into tizen

3 years agoMerge "dnsproxy: send a response including queries" into tizen accepted/tizen/unified/20200507.052334 submit/tizen/20200506.120225
seonah moon [Wed, 6 May 2020 04:27:51 +0000 (04:27 +0000)]
Merge "dnsproxy: send a response including queries" into tizen

3 years agoMerge "default_changed: get default service after checking service list" into tizen
seonah moon [Wed, 6 May 2020 02:20:50 +0000 (02:20 +0000)]
Merge "default_changed: get default service after checking service list" into tizen

3 years agoethernet: Fix memory leak 35/232435/1 submit/tizen/20200504.152605
Jaehyun Kim [Mon, 4 May 2020 14:59:24 +0000 (23:59 +0900)]
ethernet: Fix memory leak

Change-Id: Ie45da69063b59bdec02e74e37dc7d38130145803
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
3 years agoUpdate EAPoL property in connman settings. 68/232368/10 submit/tizen/20200504.135236
Niraj Kumar Goit [Sat, 2 May 2020 21:56:54 +0000 (03:26 +0530)]
Update EAPoL property in connman settings.

Change-Id: I477a8ec03f791184ce3634f7c2e9903b367a5c89
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
3 years agoAdd support of EAP on Ethernet. 99/232199/10
Nishant Chaprana [Wed, 29 Apr 2020 04:29:30 +0000 (09:59 +0530)]
Add support of EAP on Ethernet.

Change-Id: I373ab90bbb699be56d9e416346a51b0795ed1e8b
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
3 years agodnsproxy: send a response including queries 75/232175/1
Seonah Moon [Wed, 29 Apr 2020 02:30:01 +0000 (11:30 +0900)]
dnsproxy: send a response including queries

This is revert patch of https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=d74bb4a97224b6382ae2f542fe3751b1904e9b2e

Some DNS API checks a query field of DNS response to verify the response.
So, DNS resolving delay is often caused in case of DNS error.
This patch makes dnsproxy send the 'whole' packet.

Change-Id: I21cd0d86ef132d8c1eadbf93e192187112191326

3 years agodefault_changed: get default service after checking service list 94/231794/2
Seonah Moon [Fri, 24 Apr 2020 07:09:30 +0000 (16:09 +0900)]
default_changed: get default service after checking service list

Sometimes, default service is changed to IMS PDN although internet PDN
is exist. It can make DNS or data packet not send to the internet.

This patch forces the services to be checked before changing default
service.

Change-Id: Id4dc9045e55df5186f823bfe70d6aaa3066aaaf4

3 years agoChange string comparison function for null string 34/231934/2 accepted/tizen/unified/20200429.032949 submit/tizen/20200427.022040 submit/tizen/20200427.073208 submit/tizen/20200428.140958
hyunuk.tak [Mon, 27 Apr 2020 01:51:49 +0000 (10:51 +0900)]
Change string comparison function for null string

1. Modify to g_strcmp0 from g_str_equal
2. Add nobacktrace option to service of tv
3. Add INS options to main configuration of tv

Change-Id: I6fa271b3b522ae5c1495714f089c69c1602a3faf
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoCheck enable arg for INS 40/231440/1 submit/tizen/20200422.050142 submit/tizen/20200423.044725
hyunuk.tak [Wed, 22 Apr 2020 04:04:13 +0000 (13:04 +0900)]
Check enable arg for INS

Change-Id: I4c8df2dd519da9bef7c763f65b1bd3c60540825a
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoVerify INS functions using connmanctl 10/231110/4 submit/tizen/20200422.012623
hyunuk.tak [Fri, 17 Apr 2020 08:32:01 +0000 (17:32 +0900)]
Verify INS functions using connmanctl

Change-Id: I498fac295defe24eab8e3d23c6e0864bfda8fd86
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoAdd intelligent Network Selection 75/229975/9 accepted/tizen/unified/20200417.152700 submit/tizen/20200417.010643
hyunuk.tak [Tue, 7 Apr 2020 03:57:45 +0000 (12:57 +0900)]
Add intelligent Network Selection

Change-Id: I049207e7d662f657ca21a4046be953f8f33bbd10
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoFix a problem where the full scan is executed twice in succession 71/226071/1 submit/tizen/20200306.121455
Jaehyun Kim [Wed, 26 Feb 2020 11:03:16 +0000 (20:03 +0900)]
Fix a problem where the full scan is executed twice in succession

Change-Id: I1f8a7ee437a6803e6857a3f1d95a964f999218f9
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoiptables: Fix memory leak 99/225099/1 accepted/tizen/unified/20200227.121046 submit/tizen/20200220.041614 submit/tizen/20200227.012332
Jaehyun Kim [Mon, 17 Feb 2020 09:22:30 +0000 (18:22 +0900)]
iptables: Fix memory leak

Change-Id: I2f5dd43703af7583d18a7be8fc10ae0e99d402d5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agogsupplicant: Fix memory leak 71/224271/1 accepted/tizen/unified/20200213.121529 submit/tizen/20200212.122721
Jaehyun Kim [Fri, 7 Feb 2020 09:18:41 +0000 (18:18 +0900)]
gsupplicant: Fix memory leak

Change-Id: I6c8b8e67dc8fc32f744e2cf715ea383745ec0a93
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoRemove useless code 69/224269/1
Jaehyun Kim [Fri, 7 Feb 2020 08:58:36 +0000 (17:58 +0900)]
Remove useless code

Change-Id: I84e0cf1eee2ab86360adf2920dac1181e91b88b5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoUpdate time when Auto Time Update event is received. 66/223166/1
Niraj Kumar Goit [Thu, 23 Jan 2020 13:58:27 +0000 (19:28 +0530)]
Update time when Auto Time Update event is received.

When Auto Time Update event is received, update the
system time although default service is not changed.

Change-Id: I205dab72879cf54e0aa31cecd0826d9c8b63736c
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoFix to handle scan events initiated by wpa_supplicant 82/218982/3 accepted/tizen/unified/20191205.091332 submit/tizen/20191204.124930 submit/tizen/20200203.052118
Jaehyun Kim [Fri, 29 Nov 2019 08:11:46 +0000 (17:11 +0900)]
Fix to handle scan events initiated by wpa_supplicant

Change-Id: I2c247dd447a569642f19ff984fb9b318cceb676c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoMerge "wifi: Fix derefrencing of NULL pointer" into tizen accepted/tizen/unified/20191129.033505 submit/tizen/20191128.114002
Jaehyun Kim [Thu, 28 Nov 2019 11:37:25 +0000 (11:37 +0000)]
Merge "wifi: Fix derefrencing of NULL pointer" into tizen

4 years agoMerge "Remove TIZEN_EXT for patch accepted by upstream community." into tizen
Jaehyun Kim [Thu, 28 Nov 2019 11:36:54 +0000 (11:36 +0000)]
Merge "Remove TIZEN_EXT for patch accepted by upstream community." into tizen

4 years agowifi: Fix derefrencing of NULL pointer 92/218392/2
Jaehyun Kim [Fri, 22 Nov 2019 02:18:11 +0000 (11:18 +0900)]
wifi: Fix derefrencing of NULL pointer

In some cases wifi->autoscan is NULL which leads to crash

Change-Id: I44d6005bcc1972aaa8f347529d7f8ac6ad22b8e3
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoMerge "[connman] Manage the MAX saved wireless profiles." into tizen accepted/tizen/unified/20191108.065921 submit/tizen/20191106.105409
Jaehyun Kim [Wed, 6 Nov 2019 10:52:07 +0000 (10:52 +0000)]
Merge "[connman] Manage the MAX saved wireless profiles." into tizen

4 years agoRemove TIZEN_EXT for patch accepted by upstream community. 37/216837/1
Nishant Chaprana [Mon, 4 Nov 2019 02:06:02 +0000 (07:36 +0530)]
Remove TIZEN_EXT for patch accepted by upstream community.

link: https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=2974287df58bb8b018c7fe6e83d4c5bac5411a47
Change-Id: I5f51ef0348af7a5a72f799c7e2e3646c5a680536
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoFix Tizen alarm dbus interface parameter 67/216367/2 accepted/tizen_5.5_unified accepted/tizen_5.5_unified_mobile_hotfix accepted/tizen_5.5_unified_wearable_hotfix tizen_5.5_mobile_hotfix tizen_5.5_tv tizen_5.5_wearable_hotfix accepted/tizen/5.5/unified/20191031.010036 accepted/tizen/5.5/unified/mobile/hotfix/20201027.062320 accepted/tizen/5.5/unified/wearable/hotfix/20201027.102538 accepted/tizen/unified/20191024.044128 submit/tizen/20191024.043646 submit/tizen_5.5/20191031.000006 submit/tizen_5.5_mobile_hotfix/20201026.185106 submit/tizen_5.5_wearable_hotfix/20201026.184306 tizen_5.5.m2_release
Semun Lee [Thu, 24 Oct 2019 04:15:58 +0000 (13:15 +0900)]
Fix Tizen alarm dbus interface parameter

alarm uses time values as 64bit integer

Change-Id: Ifc000094da6f3e5d78ea60c144b681284e06cf69
Signed-off-by: Semun Lee <semun.lee@samsung.com>
4 years ago[connman] Manage the MAX saved wireless profiles. 75/215775/1
Niraj Kumar Goit [Tue, 15 Oct 2019 13:55:40 +0000 (19:25 +0530)]
[connman] Manage the MAX saved wireless profiles.

If the number of saved profiles exceed 200, remove the
oldest profile in the list.

Change-Id: I492cb3b5480104a59dcb58499da3bc05be3ebd05
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoMerge "Use system hostname first" into tizen accepted/tizen/unified/20191022.150300 submit/tizen/20191014.125724 submit/tizen/20191016.060650 submit/tizen/20191017.072410 submit/tizen/20191021.013541 submit/tizen/20191022.003657
Jaehyun Kim [Mon, 14 Oct 2019 12:54:50 +0000 (12:54 +0000)]
Merge "Use system hostname first" into tizen

4 years agoMerge "Try to auto-connect with favorite service before full channel scan" into tizen
Jaehyun Kim [Mon, 14 Oct 2019 12:53:54 +0000 (12:53 +0000)]
Merge "Try to auto-connect with favorite service before full channel scan" into tizen

4 years agoUse system hostname first 16/215716/2
Jaehyun Kim [Mon, 14 Oct 2019 12:13:51 +0000 (21:13 +0900)]
Use system hostname first

Change-Id: If1a518bda6824919e46eca5d051bb27058fb385c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoTry to auto-connect with favorite service before full channel scan 99/215599/1
hyunuk.tak [Fri, 11 Oct 2019 08:26:34 +0000 (17:26 +0900)]
Try to auto-connect with favorite service before full channel scan

Change-Id: Ia8027c0acf87c3bf2268fa0fc81fa15f8994241c
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoExtract strength as int32 in SignalPoll method_call's reply 84/215584/1 submit/tizen/20191011.090452
Nishant Chaprana [Fri, 11 Oct 2019 06:30:56 +0000 (12:00 +0530)]
Extract strength as int32 in SignalPoll method_call's reply

WPA Supplicant sends "rssi" as int32 in SignalPoll's method_call reply.
So strength should be int32 instead of unsigned char variable.

========================
method call time=1570774928.393859 sender=:1.24 -> destination=fi.w1.wpa_supplicant1 serial=364 path=/fi/w1/wpa_supplicant1/Interfaces/0; interface=fi.w1.wpa_supplicant1.Interface; member=SignalPoll
method return time=1570774928.395629 sender=:1.47 -> destination=:1.24 serial=327 reply_serial=364
   variant       array [
         dict entry(
            string "rssi"
            variant                int32 -60
         )
         dict entry(
            string "linkspeed"
            variant                int32 24
         )
         dict entry(
            string "noise"
            variant                int32 9999
         )
         dict entry(
            string "frequency"
            variant                uint32 2452
         )
      ]
========================

Change-Id: I23d873bf0c5560cbfaee9ef9bd78fe134f4dba93
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoMerge "Change g_waring to g_message" into tizen accepted/tizen/unified/20191011.015521 submit/tizen/20191008.031603 submit/tizen/20191008.104158 submit/tizen/20191010.075458
Jaehyun Kim [Tue, 8 Oct 2019 01:51:45 +0000 (01:51 +0000)]
Merge "Change g_waring to g_message" into tizen

4 years agoMerge "Remove unwanted NULL check for service in append_properties()" into tizen
Jaehyun Kim [Tue, 8 Oct 2019 01:22:58 +0000 (01:22 +0000)]
Merge "Remove unwanted NULL check for service in append_properties()" into tizen

4 years agoMerge "[Fix] Dereference after free in sta_remove_callback()" into tizen
Jaehyun Kim [Tue, 8 Oct 2019 00:43:00 +0000 (00:43 +0000)]
Merge "[Fix] Dereference after free in sta_remove_callback()" into tizen

4 years agoAdded an option in main.conf to set global DNS. 12/214912/2
Niraj Kumar Goit [Fri, 27 Sep 2019 10:35:24 +0000 (16:05 +0530)]
Added an option in main.conf to set global DNS.

Change-Id: I52f95964f82a88389e98592c64bf4820c1da5887
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoChange g_waring to g_message 39/215339/1
INSUN PYO [Mon, 7 Oct 2019 06:43:53 +0000 (15:43 +0900)]
Change g_waring to g_message

0  0xb6ac8dc4 in raise () from /lib/libc.so.6
1  0xb6d7d774 in g_logv () from /lib/libglib-2.0.so.0
2  0xb6d7d824 in g_log () from /lib/libglib-2.0.so.0
3  0xb6e9cb86 in interface_create_result (error=0xb6ef739c "net.connman.Error.OperationAborted", iter=0x0, user_data=0xb7378bd0) at gsupplicant/supplicant.c:4875
4  0xb6ea3796 in supplicant_dbus_method_call_cancel_all (caller=caller@entry=0x0) at gsupplicant/dbus.c:451
5  0xb6ea20c2 in g_supplicant_interface_cancel (interface=0x0) at gsupplicant/supplicant.c:4581
6  0xb6e9a61c in wifi_remove (device=0xb7377e80) at plugins/wifi.c:1611
7  0xb6eb0f06 in remove_device (device=device@entry=0xb7377e80) at src/device.c:326
8  0xb6eb15a8 in connman_device_unregister (device=device@entry=0xb7377e80) at src/device.c:1013
9  0xb6ec93d4 in detect_dellink (type=<optimized out>, index=8, flags=<optimized out>, change=<optimized out>) at src/detect.c:105
10 0xb6ed386c in process_dellink (bytes=452, msg=<optimized out>, change=4294967295, flags=36866, index=8, type=1) at src/rtnl.c:626
11 rtnl_dellink (hdr=0xbef16b1c) at src/rtnl.c:1080
12 rtnl_message (len=476, buf=0xbef16b1c) at src/rtnl.c:1557
13 netlink_event (chan=<optimized out>, cond=<optimized out>, data=<optimized out>) at src/rtnl.c:1614
14 0xb6d76654 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
15 0xb6d769e4 in ?? () from /lib/libglib-2.0.so.0
16 0xb6d76d44 in g_main_loop_run () from /lib/libglib-2.0.so.0
17 0xb6eaef6e in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:953

Change-Id: Ic2280d26e288daf031572f868e5e9efa588570f4

4 years agoRemove unwanted NULL check for service in append_properties() 03/214903/2
Nishant Chaprana [Fri, 27 Sep 2019 09:51:16 +0000 (15:21 +0530)]
Remove unwanted NULL check for service in append_properties()

Description: The service will be always allocated when append_properties()
is called, so this NULL check is not required.
This NULL check generates SVACE warning which is actually a FALSE alarm.

Change-Id: I9b3a15529f6614cb375b8fb7ec656a3c44eeb180
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years ago[Fix] Dereference after free in sta_remove_callback() 96/214896/3
Nishant Chaprana [Fri, 27 Sep 2019 09:40:59 +0000 (15:10 +0530)]
[Fix] Dereference after free in sta_remove_callback()

Change-Id: I0e3e98f588ea186c514090a86a1a5a9d78e10420
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoRemove Wi-Fi device reference on wifi_disable when wifi is scanning 28/215028/2 accepted/tizen/unified/20191007.234805 submit/tizen/20191001.114836
Yu [Tue, 1 Oct 2019 05:44:11 +0000 (14:44 +0900)]
Remove Wi-Fi device reference on wifi_disable when wifi is scanning

Description: Sometimes Wi-Fi device reference didn't set to zero
when Wi-Fi is powered off like below.

src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 2 by plugins/wifi.c:1434:wifi_probe()
src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 3 by plugins/wifi.c:3183:wifi_scan()
src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 4 by plugins/wifi.c:2313:start_autoscan()
src/device.c:connman_device_unref_debug() 0xb7fd8ae0 ref 3 by plugins/wifi.c:1500:reset_autoscan()
src/device.c:connman_device_unref_debug() 0xb7fd8ae0 ref 2 by plugins/wifi.c:1606:wifi_remove()
src/device.c:connman_device_unref_debug() 0xb7fd8ae0 ref 1 by src/detect.c:106:detect_dellink()

src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 2 by plugins/wifi.c:1434:wifi_probe()
src/device.c:connman_device_ref_debug() 0xb7fcce88 ref 2 by plugins/wifi.c:1434:wifi_probe()
src/device.c:connman_device_unref_debug() 0xb7fcce88 ref 1 by plugins/wifi.c:1606:wifi_remove()
src/device.c:connman_device_unref_debug() 0xb7fcce88 ref 0 by src/detect.c:106:detect_dellink()

Change-Id: I52783152a5dd581d1af072aa5f3a0db92e8d622a
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
4 years agoAdd DPP service based on configuration file 93/213293/9 submit/tizen/20190927.130602
Yu [Wed, 4 Sep 2019 04:43:22 +0000 (13:43 +0900)]
Add DPP service based on configuration file

Description: This is incomplete solution becase there's
no defined way to connect to DPP AP for upstream connman
for current patch

Change-Id: Ia6a3188e2826708c2123d209249d8b59fb5a42dc
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
4 years agoAdded support to enable/disable Auto-IP option. 07/214507/2 accepted/tizen/unified/20190926.065658 submit/tizen/20190924.065941 submit/tizen/20190925.080914
Niraj Kumar Goit [Mon, 23 Sep 2019 10:15:33 +0000 (15:45 +0530)]
Added support to enable/disable Auto-IP option.

Added support to enable/disable Auto-IP option using main.conf

Change-Id: Iea1cae5a28681a90a5f79735c7374791a227feb7
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoFixed dbus rules for connman-vpn-dbus.conf 33/214333/1 accepted/tizen/unified/20190923.110259 submit/tizen/20190923.043320
Nishant Chaprana [Fri, 20 Sep 2019 09:47:57 +0000 (15:17 +0530)]
Fixed dbus rules for connman-vpn-dbus.conf

Change-Id: Iaa437db1f9408f34f4f95ac47bbc2a2da49b2779
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoImported Upstream version 1.37 66/214066/2 submit/tizen/20190920.082459
Nishant Chaprana [Tue, 17 Sep 2019 13:30:55 +0000 (19:00 +0530)]
Imported Upstream version 1.37

Change-Id: Idb47c1ddbedc9f97181b8e9a5eeac04ddd832a2c
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoMerge "Emit Service PropertyChanged when ConnectReason and DisconnectionRequested... accepted/tizen/unified/20190911.111656 submit/tizen/20190910.081214
Jaehyun Kim [Tue, 10 Sep 2019 08:11:13 +0000 (08:11 +0000)]
Merge "Emit Service PropertyChanged when ConnectReason and DisconnectionRequested changes" into tizen

4 years agoMerge "Update RSSI/Strength of connected service using SignalPoll event" into tizen
Jaehyun Kim [Tue, 10 Sep 2019 08:08:14 +0000 (08:08 +0000)]
Merge "Update RSSI/Strength of connected service using SignalPoll event" into tizen

4 years agoEmit Service PropertyChanged when ConnectReason and DisconnectionRequested changes 56/213556/1
Nishant Chaprana [Fri, 6 Sep 2019 15:22:47 +0000 (20:52 +0530)]
Emit Service PropertyChanged when ConnectReason and DisconnectionRequested changes

Description: The properties perform below tasks:-
1. ConnectReason: To identify whether connection was an autoconnection or user initiated.
2. DisconnectionRequested: To identify whether disconnection was user initiated or not.

Change-Id: I2ba4fc4637673571745517cdc33fc3a6d6367953
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoFixed invalid state transitions 60/213360/1 accepted/tizen/unified/20190909.010911 submit/tizen/20190906.055938
Jaehyun Kim [Wed, 4 Sep 2019 11:52:00 +0000 (20:52 +0900)]
Fixed invalid state transitions

Fixed the case where the ConnMan is changed to Idle state without going through Disconnect state in Connected state.
* Disconnect state indicates that it is going to terminate the current connection and will return to the Idle state.

Change-Id: I81becdd043d599df4257d30c94ce2a2038f72b2d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoUpdate RSSI/Strength of connected service using SignalPoll event 33/205233/3
Nishant Chaprana [Tue, 30 Apr 2019 12:22:29 +0000 (17:52 +0530)]
Update RSSI/Strength of connected service using SignalPoll event

This patch reduced the SignalPoll monitor from 30 second to 10 second frequency.
This patch also extracts already available parameter strength/RSSI in SignalPoll
and update connected service's RSSI/Strength accordingly.

Change-Id: Ie9bbb21bf50ad0b8c72e3ca2fc9f7f6500c77f23
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoSort hidden profiles based on modified time. 58/212758/1
Niraj Kumar Goit [Mon, 26 Aug 2019 12:00:39 +0000 (17:30 +0530)]
Sort hidden profiles based on modified time.

When there are multiple hidden profiles stored in connman, sort
hidden profiles based on modified time (latest on top) and then
send scan request.

Change-Id: Ib27a31db94b4fafe9521414ab19702f08f5df783
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoMerge "Remove DefaultDependencies=no at connman.service" into tizen
Jaehyun Kim [Mon, 19 Aug 2019 06:41:33 +0000 (06:41 +0000)]
Merge "Remove DefaultDependencies=no at connman.service" into tizen

4 years agoRemove RW upgrade script 61/212161/2
Kichan Kwon [Fri, 16 Aug 2019 04:22:29 +0000 (13:22 +0900)]
Remove RW upgrade script

Change-Id: Ib19bf1596320e67711645a7904bc3b81d7e546bc
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
4 years agoRemove duplicate dependency with implicit dependencies at "Type=dbus" 85/211585/2 accepted/tizen/unified/20190818.224606 submit/tizen/20190816.113014
INSUN PYO [Wed, 7 Aug 2019 02:44:29 +0000 (11:44 +0900)]
Remove duplicate dependency with implicit dependencies at "Type=dbus"

Refs: https://www.freedesktop.org/software/systemd/man/systemd.service.html
 - Services with Type=dbus set automatically acquire dependencies of type Requires= and After= on dbus.socket.

Change-Id: Ic6009027222e293f8525a6b4a97512d7580be3f0

4 years agoAdd support to find stored Hidden AP when it's channel is changed 30/211530/1 submit/tizen/20190807.124141
Jaehyun Kim [Tue, 6 Aug 2019 07:40:26 +0000 (16:40 +0900)]
Add support to find stored Hidden AP when it's channel is changed

Change-Id: Ideb03d497be9654f6b03fcd289a0b30aba42b189
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoAdd an option for gateway timeserver handling 57/211257/1 submit/tizen/20190802.071744
Jaehyun Kim [Wed, 31 Jul 2019 13:45:54 +0000 (22:45 +0900)]
Add an option for gateway timeserver handling

Change-Id: I19f09647b7471f146adb95bc7e81fd9ab11f18ac
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoMerge "Add OWE security mode support" into tizen submit/tizen/20190729.091802 submit/tizen/20190731.014248
Jaehyun Kim [Mon, 29 Jul 2019 08:58:04 +0000 (08:58 +0000)]
Merge "Add OWE security mode support" into tizen

4 years agoMerge "Refactoring of scan for stored hidden profiles." into tizen
Jaehyun Kim [Fri, 26 Jul 2019 12:22:49 +0000 (12:22 +0000)]
Merge "Refactoring of scan for stored hidden profiles." into tizen

4 years agoDo not validate the passphrase for the SAE security type when it is encrypted. 79/210879/1 submit/tizen/20190726.063122
Jaehyun Kim [Thu, 25 Jul 2019 12:58:47 +0000 (21:58 +0900)]
Do not validate the passphrase for the SAE security type when it is encrypted.

Change-Id: Ibd82d445a8c0bd80a9b0804dd3d8b639797f8cb2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoMerge "Added support to get AP hidden status." into tizen
Jaehyun Kim [Thu, 25 Jul 2019 12:34:33 +0000 (12:34 +0000)]
Merge "Added support to get AP hidden status." into tizen

4 years agoMerge "Delete meaningless configuration" into tizen
Jaehyun Kim [Thu, 25 Jul 2019 12:32:22 +0000 (12:32 +0000)]
Merge "Delete meaningless configuration" into tizen

4 years agoAdded support to get AP hidden status. 85/210185/2
Niraj Kumar Goit [Tue, 16 Jul 2019 11:20:22 +0000 (16:50 +0530)]
Added support to get AP hidden status.

Change-Id: Ib8014d9ff53d896a12d0bf985168b7df589d9f22
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoAdd OWE security mode support 10/210810/3
Yu [Thu, 25 Jul 2019 04:24:57 +0000 (13:24 +0900)]
Add OWE security mode support

Change-Id: I03ab90b8ab78e489d1ef70fbec57f10576860a57
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
4 years agoRemove unnecessary setting 55/210655/1
INSUN PYO [Tue, 23 Jul 2019 11:17:53 +0000 (20:17 +0900)]
Remove unnecessary setting

Service and Socket unit has an implicit dependencies.

Refre: https://www.freedesktop.org/software/systemd/man/systemd.socket.html
"Socket units automatically gain a Before= dependency on the service units they activate."

Change-Id: I97710fb27fd3294332283a8bffde0d3765b4428e

4 years agoRemove DefaultDependencies=no at connman.service 18/210218/1
INSUN PYO [Wed, 17 Jul 2019 04:29:12 +0000 (13:29 +0900)]
Remove DefaultDependencies=no at connman.service

net-config.service has "After=net-config.service" dependency.
But net-config.service don't have DefaultDependencies=no.

So "DefaultDependencies=no" does not have any effect on connman.service, but instead it is confusing.

Change-Id: I6a3c78f18c3029314c2a8c0e6b8c72e65c868fe8

4 years agoDelete meaningless configuration 95/209495/2
INSUN PYO [Mon, 8 Jul 2019 10:02:25 +0000 (19:02 +0900)]
Delete meaningless configuration

Change-Id: Ida02a51bc1efe14b8d271e27898b3bd0d105797b

4 years agoImported Upstream version 1.37 02/209302/1 upstream/1.37
Nishant Chaprana [Thu, 4 Jul 2019 12:11:09 +0000 (17:41 +0530)]
Imported Upstream version 1.37

Change-Id: Ib5957e7ee3a9315ee86a331189bc3e9e71751ee8
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoMerge "Change the config value of the "FreeBind=" ("true" -> "yes")" into tizen accepted/tizen/unified/20190628.120630 submit/tizen/20190628.060134
Jaehyun Kim [Fri, 28 Jun 2019 05:59:03 +0000 (05:59 +0000)]
Merge "Change the config value of the "FreeBind=" ("true" -> "yes")" into tizen

4 years agoAppend disconnect reason code in case of invalid key. 99/208599/1
Niraj Kumar Goit [Wed, 26 Jun 2019 08:02:17 +0000 (13:32 +0530)]
Append disconnect reason code in case of invalid key.

Change-Id: Ie95d9be974d685f0601b2a6592c5f2d45e88fdd7
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoChange the config value of the "FreeBind=" ("true" -> "yes") 43/208543/1
INSUN PYO [Wed, 26 Jun 2019 00:54:33 +0000 (09:54 +0900)]
Change the config value of the "FreeBind=" ("true" -> "yes")

Change-Id: I5cbc48dfe7ab4f4402d04fdb5ebba1d220e457a6

4 years agoAdded support of WPA3-SAE security mode. 84/207984/2 accepted/tizen/unified/20190624.075215 submit/tizen/20190621.094817
Niraj Kumar Goit [Thu, 30 May 2019 10:43:20 +0000 (16:13 +0530)]
Added support of WPA3-SAE security mode.

Change-Id: I8612c52dc0cc078459fa19aa8a639597f070b293
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
4 years agoFixed to prevent bssid corruption 31/207731/2 accepted/tizen/unified/20190617.061745 submit/tizen/20190614.050629
Jaehyun Kim [Tue, 11 Jun 2019 12:55:14 +0000 (21:55 +0900)]
Fixed to prevent bssid corruption

Change-Id: I26b9d81fad917939750b42c893ea5e44824ba270
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>