From: Saurav Babu <saurav.babu@samsung.com>
Date: Tue, 6 Jun 2017 06:46:34 +0000 (+0530)
Subject: service: Fix memory leak issues
X-Git-Tag: accepted/tizen/unified/20170608.072306~1
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fupstream%2Fconnman.git;a=commitdiff_plain;h=4dc972d927cd9f5854eb4f2d50cfafe931705e21

service: Fix memory leak issues

This patch fixes memory leak on loading service passphrase.
g_strdup() function returns NULL only when nameserver will be NULL and
it has already been checked before so there is no need to check for
return of g_strdup().

Change-Id: I3ddd3af135a35ba03bd01ccd5a68f822ed1dac26
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
---

diff --git a/src/service.c b/src/service.c
index 259a497..4f7b9b8 100755
--- a/src/service.c
+++ b/src/service.c
@@ -612,6 +612,8 @@ static int service_load_passphrase(struct connman_service *service)
 	if (str)
 		service->passphrase = str;
 
+	g_key_file_free(keyfile);
+
 	return 0;
 }
 
@@ -1739,9 +1741,6 @@ int __connman_service_nameserver_append(struct connman_service *service,
 		return -ENOMEM;
 
 	nameservers[len] = g_strdup(nameserver);
-	if (!nameservers[len])
-		return -ENOMEM;
-
 	nameservers[len + 1] = NULL;
 
 #ifdef TIZEN_EXT