From: Jaehyun Kim <jeik01.kim@samsung.com>
Date: Wed, 11 Nov 2020 11:00:54 +0000 (+0900)
Subject: Fix derefrencing of NULL pointer
X-Git-Tag: submit/tizen/20201116.030352^2
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fupstream%2Fconnman.git;a=commitdiff_plain;h=0a6425147f6e3bd165c8302bdc3205fb958fd065

Fix derefrencing of NULL pointer

In some cases network->device could be NULL which leads to crash

Change-Id: I3cc5401b37fd48d8d702935bef7afa7e277222f2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
---

diff --git a/packaging/connman.spec b/packaging/connman.spec
index 072e8bf..33b9ccf 100644
--- a/packaging/connman.spec
+++ b/packaging/connman.spec
@@ -5,7 +5,7 @@
 
 Name:           connman
 Version:        1.37
-Release:        49
+Release:        50
 License:        GPL-2.0+
 Summary:        Connection Manager
 Url:            http://connman.net
diff --git a/src/service.c b/src/service.c
index f77c8a5..dd4f191 100755
--- a/src/service.c
+++ b/src/service.c
@@ -7657,6 +7657,9 @@ static int calculate_score_last_user_selection(struct connman_service *service)
 	struct tm* ref_timeinfo;
 
 	device = connman_network_get_device(service->network);
+	if (!device)
+		return 0;
+
 	last_user_selection_time = connman_device_get_last_user_selection_time(device);
 	last_user_selection_ident = connman_device_get_last_user_selection_ident(device);
 	frequency = connman_network_get_frequency(service->network);