Add support for handling wifi authentication failure
[platform/upstream/connman.git] / src / service.c
index 90ff7e5..5e7eb8d 100755 (executable)
@@ -35,6 +35,8 @@
 #include <connman/setting.h>
 #include <connman/agent.h>
 
+#include "src/shared/util.h"
+
 #include "connman.h"
 
 #define CONNECT_TIMEOUT                120
@@ -42,9 +44,7 @@
 #if defined TIZEN_EXT
 #define WIFI_BSSID_STR_LEN     18
 #define MAX_WIFI_PROFILES      200
-#endif
 
-#if defined TIZEN_EXT
 #define FREQ_RANGE_24GHZ_CHANNEL_1   2412
 #define FREQ_RANGE_24GHZ_CHANNEL_14  2484
 #define FREQ_RANGE_5GHZ_CHANNEL_32   5160
@@ -53,6 +53,9 @@
 #define MAC2STR(a) (a)[0], (a)[1], (a)[2], (a)[3], (a)[4], (a)[5]
 #define MACSTR "%02x:%02x:%02x:%02x:%02x:%02x"
 #endif
+#define VPN_AUTOCONNECT_TIMEOUT_DEFAULT 1
+#define VPN_AUTOCONNECT_TIMEOUT_STEP 30
+#define VPN_AUTOCONNECT_TIMEOUT_ATTEMPTS_THRESHOLD 270
 
 static DBusConnection *connection = NULL;
 
@@ -72,9 +75,12 @@ struct saved_profiles {
        gchar *profile_name;
 };
 
+static unsigned char invalid_bssid[WIFI_BSSID_LEN_MAX] = {
+       0x00, 0x00, 0x00, 0x00, 0x00, 0x00
+};
 #endif
 
-#if defined TIZEN_EXT
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
 enum connman_ins_preferred_freq {
        CONNMAN_INS_PREFERRED_FREQ_UNKNOWN,
        CONNMAN_INS_PREFERRED_FREQ_24GHZ,
@@ -100,11 +106,7 @@ struct connman_ins_settings {
 };
 
 static struct connman_ins_settings ins_settings;
-
-static unsigned char invalid_bssid[WIFI_BSSID_LEN_MAX] = {
-       0x00, 0x00, 0x00, 0x00, 0x00, 0x00
-};
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
 struct connman_stats {
        bool valid;
@@ -137,7 +139,7 @@ struct connman_service {
        bool hidden;
        bool ignore;
        bool autoconnect;
-       GTimeVal modified;
+       struct timeval modified;
        unsigned int order;
        char *name;
        char *passphrase;
@@ -231,8 +233,6 @@ struct connman_service {
        char *connector;
        char *c_sign_key;
        char *net_access_key;
-#endif
-#if defined TIZEN_EXT
        unsigned char last_connected_bssid[WIFI_BSSID_LEN_MAX];
        bool is_internet_connection;
        int assoc_reject_count;
@@ -261,6 +261,7 @@ static struct connman_ipconfig *create_ip4config(struct connman_service *service
 static struct connman_ipconfig *create_ip6config(struct connman_service *service,
                int index);
 static void dns_changed(struct connman_service *service);
+static void vpn_auto_connect(void);
 
 struct find_data {
        const char *path;
@@ -272,9 +273,7 @@ struct assoc_reject_data {
        char *bssid;
        GSList *reject_time_list;
 };
-#endif
 
-#if defined TIZEN_EXT
 /*
  * Public APIs to use user_pdn_connection_refcount
  */
@@ -517,6 +516,10 @@ static const char *error2string(enum connman_service_error error)
                return "login-failed";
        case CONNMAN_SERVICE_ERROR_AUTH_FAILED:
                return "auth-failed";
+#ifdef TIZEN_EXT
+       case CONNMAN_SERVICE_ERROR_ASSOC_FAILED:
+               return "assoc-failed";
+#endif
        case CONNMAN_SERVICE_ERROR_INVALID_KEY:
                return "invalid-key";
        case CONNMAN_SERVICE_ERROR_BLOCKED:
@@ -638,7 +641,7 @@ int __connman_service_load_modifiable(struct connman_service *service)
        str = g_key_file_get_string(keyfile,
                                service->identifier, "Modified", NULL);
        if (str) {
-               g_time_val_from_iso8601(str, &service->modified);
+               util_iso8601_to_timeval(str, &service->modified);
                g_free(str);
        }
 
@@ -816,7 +819,8 @@ static void count_assoc_reject(gpointer key, gpointer value, gpointer user_data)
        struct assoc_reject_data *assoc_data = value;
        int *assoc_reject_count = user_data;
 
-       *assoc_reject_count += g_slist_length(assoc_data->reject_time_list);
+       if (assoc_data)
+               *assoc_reject_count += g_slist_length(assoc_data->reject_time_list);
 }
 
 static bool update_assoc_reject(struct connman_service *service)
@@ -860,10 +864,8 @@ static int service_ext_load(struct connman_service *service)
        int i;
        int err = 0;
 
-#if defined TIZEN_EXT
        if (!simplified_log)
-#endif
-       DBG("service %p", service);
+               DBG("service %p", service);
 
        if (!service->network)
                return -EINVAL;
@@ -954,7 +956,7 @@ static int service_ext_save(struct connman_service *service)
        if (service->type != CONNMAN_SERVICE_TYPE_WIFI)
                return -EINVAL;
 
-       keyfile = __connman_storage_open_service(service->identifier);
+       keyfile = g_key_file_new();
        if (!keyfile)
                return -EIO;
 
@@ -1191,7 +1193,7 @@ static int service_load(struct connman_service *service)
        str = g_key_file_get_string(keyfile,
                                service->identifier, "Modified", NULL);
        if (str) {
-               g_time_val_from_iso8601(str, &service->modified);
+               util_iso8601_to_timeval(str, &service->modified);
                g_free(str);
        }
 
@@ -1407,7 +1409,7 @@ static int service_save(struct connman_service *service)
        if (service->new_service)
                return -ESRCH;
 
-       keyfile = __connman_storage_open_service(service->identifier);
+       keyfile = g_key_file_new();
        if (!keyfile)
                return -EIO;
 
@@ -1543,9 +1545,6 @@ static int service_save(struct connman_service *service)
                g_key_file_set_boolean(keyfile, service->identifier,
                                        "Favorite", service->favorite);
 
-               g_key_file_remove_key(keyfile, service->identifier,
-                               "Failure", NULL);
-
                /* fall through */
 
        case CONNMAN_SERVICE_TYPE_ETHERNET:
@@ -1559,37 +1558,32 @@ static int service_save(struct connman_service *service)
                break;
        }
 
-       str = g_time_val_to_iso8601(&service->modified);
+       str = util_timeval_to_iso8601(&service->modified);
        if (str) {
                g_key_file_set_string(keyfile, service->identifier,
-                                                       "Modified", str);
+                               "Modified", str);
                g_free(str);
        }
 
        if (service->passphrase && strlen(service->passphrase) > 0)
                g_key_file_set_string(keyfile, service->identifier,
-                                       "Passphrase", service->passphrase);
-       else
-               g_key_file_remove_key(keyfile, service->identifier,
-                                                       "Passphrase", NULL);
+                               "Passphrase", service->passphrase);
 
        if (service->ipconfig_ipv4)
                __connman_ipconfig_save(service->ipconfig_ipv4, keyfile,
-                                       service->identifier, "IPv4.");
+                               service->identifier, "IPv4.");
 
        if (service->ipconfig_ipv6)
                __connman_ipconfig_save(service->ipconfig_ipv6, keyfile,
-                                               service->identifier, "IPv6.");
+                               service->identifier, "IPv6.");
 
        if (service->nameservers_config) {
                guint len = g_strv_length(service->nameservers_config);
 
                g_key_file_set_string_list(keyfile, service->identifier,
-                                                               "Nameservers",
+                               "Nameservers",
                                (const gchar **) service->nameservers_config, len);
-       } else
-       g_key_file_remove_key(keyfile, service->identifier,
-                                                       "Nameservers", NULL);
+       }
 
 #if defined TIZEN_EXT
        if(service->dns_config_method_ipv4 != 0) {
@@ -1617,21 +1611,17 @@ static int service_save(struct connman_service *service)
                guint len = g_strv_length(service->timeservers_config);
 
                g_key_file_set_string_list(keyfile, service->identifier,
-                                                               "Timeservers",
+                               "Timeservers",
                                (const gchar **) service->timeservers_config, len);
-       } else
-               g_key_file_remove_key(keyfile, service->identifier,
-                                                       "Timeservers", NULL);
+       }
 
        if (service->domains) {
                guint len = g_strv_length(service->domains);
 
                g_key_file_set_string_list(keyfile, service->identifier,
-                                                               "Domains",
+                               "Domains",
                                (const gchar **) service->domains, len);
-       } else
-               g_key_file_remove_key(keyfile, service->identifier,
-                                                       "Domains", NULL);
+       }
 
        cst_str = proxymethod2string(service->proxy_config);
        if (cst_str)
@@ -1644,9 +1634,7 @@ static int service_save(struct connman_service *service)
                g_key_file_set_string_list(keyfile, service->identifier,
                                "Proxy.Servers",
                                (const gchar **) service->proxies, len);
-       } else
-               g_key_file_remove_key(keyfile, service->identifier,
-                                               "Proxy.Servers", NULL);
+       }
 
        if (service->excludes) {
                guint len = g_strv_length(service->excludes);
@@ -1654,23 +1642,15 @@ static int service_save(struct connman_service *service)
                g_key_file_set_string_list(keyfile, service->identifier,
                                "Proxy.Excludes",
                                (const gchar **) service->excludes, len);
-       } else
-               g_key_file_remove_key(keyfile, service->identifier,
-                                               "Proxy.Excludes", NULL);
+       }
 
        if (service->pac && strlen(service->pac) > 0)
                g_key_file_set_string(keyfile, service->identifier,
-                                       "Proxy.URL", service->pac);
-       else
-               g_key_file_remove_key(keyfile, service->identifier,
-                                                       "Proxy.URL", NULL);
+                               "Proxy.URL", service->pac);
 
        if (service->mdns_config)
                g_key_file_set_boolean(keyfile, service->identifier,
-                                                               "mDNS", TRUE);
-       else
-               g_key_file_remove_key(keyfile, service->identifier,
-                                                               "mDNS", NULL);
+                               "mDNS", TRUE);
 
        if (service->hidden_service)
                g_key_file_set_boolean(keyfile, service->identifier, "Hidden",
@@ -1859,6 +1839,7 @@ static void __connman_manage_saved_profiles()
                if (!entry) {
                        g_sequence_free(profile_list);
                        g_key_file_free(keyfile);
+                       g_strfreev(services);
                        return;
                }
 
@@ -1882,6 +1863,7 @@ static void __connman_manage_saved_profiles()
        }
 
        g_sequence_free(profile_list);
+       g_strfreev(services);
 }
 #endif
 
@@ -2496,18 +2478,15 @@ int __connman_service_nameserver_append(struct connman_service *service,
        else
                nameservers = service->nameservers;
 
-       for (i = 0; nameservers && nameservers[i]; i++)
-#if defined TIZEN_EXT
-       {
-               DBG("nameservers[%d] %s, nameserver %s", i, nameservers[i], nameserver);
-#endif
-               if (g_strcmp0(nameservers[i], nameserver) == 0)
-                       return -EEXIST;
+       if (nameservers) {
+               for (i = 0; nameservers[i]; i++) {
 #if defined TIZEN_EXT
-       }
+                       DBG("nameservers[%d] %s, nameserver %s", i, nameservers[i], nameserver);
 #endif
+                       if (g_strcmp0(nameservers[i], nameserver) == 0)
+                               return -EEXIST;
+               }
 
-       if (nameservers) {
                len = g_strv_length(nameservers);
                nameservers = g_try_renew(char *, nameservers, len + 2);
        } else {
@@ -2743,6 +2722,56 @@ void __connman_service_nameserver_del_routes(struct connman_service *service,
                nameserver_del_routes(index, service->nameservers, type);
 }
 
+static bool check_proxy_setup(struct connman_service *service)
+{
+       /*
+        * We start WPAD if we haven't got a PAC URL from DHCP and
+        * if our proxy manual configuration is either empty or set
+        * to AUTO with an empty URL.
+        */
+
+       if (service->proxy != CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN)
+               return true;
+
+       if (service->proxy_config != CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN &&
+               (service->proxy_config != CONNMAN_SERVICE_PROXY_METHOD_AUTO ||
+                       service->pac))
+               return true;
+
+       if (__connman_wpad_start(service) < 0) {
+               service->proxy = CONNMAN_SERVICE_PROXY_METHOD_DIRECT;
+               __connman_notifier_proxy_changed(service);
+               return true;
+       }
+
+       return false;
+}
+
+static void cancel_online_check(struct connman_service *service)
+{
+       if (service->online_timeout == 0)
+               return;
+
+       g_source_remove(service->online_timeout);
+       service->online_timeout = 0;
+       connman_service_unref(service);
+}
+
+static void start_online_check(struct connman_service *service,
+                               enum connman_ipconfig_type type)
+{
+       if (!connman_setting_get_bool("EnableOnlineCheck")) {
+               connman_info("Online check disabled. "
+                       "Default service remains in READY state.");
+               return;
+       }
+
+       if (type != CONNMAN_IPCONFIG_TYPE_IPV4 || check_proxy_setup(service)) {
+               cancel_online_check(service);
+               __connman_service_wispr_start(service, type);
+       }
+}
+
 static void address_updated(struct connman_service *service,
                        enum connman_ipconfig_type type)
 {
@@ -2750,6 +2779,7 @@ static void address_updated(struct connman_service *service,
                        service == connman_service_get_default()) {
                nameserver_remove_all(service, type);
                nameserver_add_all(service, type);
+               start_online_check(service, type);
 
                __connman_timeserver_sync(service);
        }
@@ -2898,6 +2928,31 @@ struct connman_service *connman_service_get_default_connection(void)
 
        return default_service;
 }
+
+struct connman_service *connman_service_get_connected_service(const char *ifname)
+{
+       GList *list;
+       const char *svc_ifname;
+       struct connman_service *service;
+
+       if (!ifname)
+               return NULL;
+
+       for (list = service_list; list; list = list->next) {
+               service = list->data;
+
+               if (!is_connected(service->state))
+                       continue;
+
+               svc_ifname = connman_device_get_string(
+                               connman_network_get_device(service->network), "Interface");
+
+               if (svc_ifname && g_strcmp0(svc_ifname, ifname) == 0)
+                       return service;
+       }
+
+       return NULL;
+}
 #endif
 
 struct connman_service *connman_service_get_default(void)
@@ -2964,11 +3019,46 @@ static void default_changed(void)
                if (service->domainname &&
                                connman_setting_get_bool("AllowDomainnameUpdates"))
                        __connman_utsname_set_domainname(service->domainname);
+
+               /*
+                * Connect VPN automatically when new default service
+                * is set and connected, unless new default is VPN
+                */
+               if (is_connected(service->state) &&
+                               service->type != CONNMAN_SERVICE_TYPE_VPN) {
+                       DBG("running vpn_auto_connect");
+                       vpn_auto_connect();
+               }
        }
 
        __connman_notifier_default_changed(service);
 }
 
+#if defined TIZEN_EXT
+static void append_struct(gpointer value, gpointer user_data);
+
+static void emit_state_changed_with_properties(struct connman_service *service)
+{
+       DBusMessage *signal;
+       DBusMessageIter iter;
+
+       if (!service)
+               return;
+
+       signal = dbus_message_new_signal(service->path, CONNMAN_SERVICE_INTERFACE,
+                       "StateChangedProperties");
+       if (!signal)
+               return;
+
+       dbus_message_iter_init_append(signal, &iter);
+       append_struct(service, &iter);
+
+       g_dbus_send_message(connection, signal);
+
+       return;
+}
+#endif
+
 static void state_changed(struct connman_service *service)
 {
        const char *str;
@@ -2982,27 +3072,32 @@ static void state_changed(struct connman_service *service)
 #if !defined TIZEN_EXT
        if (!allow_property_changed(service))
                return;
-
-#endif
-#if defined TIZEN_EXT
+#else
        DBG(" %s, %s", str, service->path);
 #endif
+
        connman_dbus_property_changed_basic(service->path,
                                CONNMAN_SERVICE_INTERFACE, "State",
                                                DBUS_TYPE_STRING, &str);
+
+#if defined TIZEN_EXT
+       emit_state_changed_with_properties(service);
+#endif
 }
 
 #if defined TIZEN_EXT
 static void connect_reason_changed(struct connman_service *service)
 {
+#if defined TIZEN_EXT_INS
        struct connman_device *device;
-
+#endif
        if (!service->path)
                return;
 
        if (!allow_property_changed(service))
                return;
 
+#if defined TIZEN_EXT_INS
        if (service->connect_reason == CONNMAN_SERVICE_CONNECT_REASON_USER) {
                device = connman_network_get_device(service->network);
                if (device) {
@@ -3019,14 +3114,17 @@ static void connect_reason_changed(struct connman_service *service)
                                connman_device_save_last_user_selection(device);
                }
        }
+#endif
 
        connman_dbus_property_changed_basic(service->path,
-                                           CONNMAN_SERVICE_INTERFACE,
-                                           "ConnectReason",
-                                           DBUS_TYPE_INT32,
-                                           &service->connect_reason);
+                                       CONNMAN_SERVICE_INTERFACE,
+                                       "ConnectReason",
+                                       DBUS_TYPE_INT32,
+                                       &service->connect_reason);
 }
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
+#if defined TIZEN_EXT
 static void disconnection_requested_changed(struct connman_service *service)
 {
        dbus_bool_t disconnection_requested;
@@ -3154,6 +3252,18 @@ static void autoconnect_changed(struct connman_service *service)
                                DBUS_TYPE_BOOLEAN, &autoconnect);
 }
 
+bool connman_service_set_autoconnect(struct connman_service *service,
+                                                       bool autoconnect)
+{
+       if (service->autoconnect == autoconnect)
+               return false;
+
+       service->autoconnect = autoconnect;
+       autoconnect_changed(service);
+
+       return true;
+}
+
 static void append_security(DBusMessageIter *iter, void *user_data)
 {
        struct connman_service *service = user_data;
@@ -4147,6 +4257,22 @@ int connman_service_iterate_services(connman_service_iterate_cb cb,
 }
 
 #if defined TIZEN_EXT
+static void append_security_list(DBusMessageIter *iter, void *user_data)
+{
+       GSList *sec_list = (GSList *)user_data;
+       const char *sec_str;
+
+       if (sec_list) {
+               GSList *list;
+               for (list = sec_list; list; list = list->next) {
+                       sec_str = (const char *)list->data;
+
+                       dbus_message_iter_append_basic(iter,
+                                       DBUS_TYPE_STRING, &sec_str);
+               }
+       }
+}
+
 static void append_wifi_ext_info(DBusMessageIter *dict,
                                        struct connman_network *network)
 {
@@ -4166,6 +4292,7 @@ static void append_wifi_ext_info(DBusMessageIter *dict,
        char *country_code_str = country_code_buff;
        unsigned char *country_code;
        uint16_t connection_mode;
+       GSList *sec_list = NULL;
 
        ssid = connman_network_get_blob(network, "WiFi.SSID", &ssid_len);
        bssid = connman_network_get_bssid(network);
@@ -4177,12 +4304,16 @@ static void append_wifi_ext_info(DBusMessageIter *dict,
        keymgmt = connman_network_get_keymgmt(network);
        country_code = connman_network_get_countrycode(network);
        connection_mode = connman_network_get_connection_mode(network);
+       sec_list = (GSList *)connman_network_get_sec_list(network);
 
        snprintf(bssid_str, WIFI_BSSID_STR_LEN, MACSTR, MAC2STR(bssid));
 
        snprintf(country_code_str, (WIFI_COUNTRY_CODE_LEN + 1), "%c%c",
                 country_code[0], country_code[1]);
 
+       connman_dbus_dict_append_array(dict, "SecurityList",
+                                       DBUS_TYPE_STRING,
+                                       append_security_list, sec_list);
 
        connman_dbus_dict_append_fixed_array(dict, "SSID",
                                        DBUS_TYPE_BYTE, &ssid, ssid_len);
@@ -4461,7 +4592,7 @@ static void append_properties(DBusMessageIter *dict, dbus_bool_t limited,
                connman_network_append_acddbus(dict, service->network);
 }
 
-#if defined TIZEN_EXT_INS
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
 static void append_ins_bssid_info(DBusMessageIter *iter, void *user_data)
 {
        GSList *bssid_list = NULL;
@@ -4552,7 +4683,7 @@ static void append_ins_properties(DBusMessageIter *dict,
                                append_ins_bssid_info, service->network);
        }
 }
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
 static void append_struct_service(DBusMessageIter *iter,
                connman_dbus_append_cb_t function,
@@ -4591,12 +4722,7 @@ static void append_struct(gpointer value, gpointer user_data)
        append_struct_service(iter, append_dict_properties, service);
 }
 
-void __connman_service_list_struct(DBusMessageIter *iter)
-{
-       g_list_foreach(service_list, append_struct, iter);
-}
-
-#if defined TIZEN_EXT_INS
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
 static void append_dict_ins_properties(DBusMessageIter *dict, void *user_data)
 {
        struct connman_service *service = user_data;
@@ -4622,7 +4748,12 @@ void __connman_ins_list_struct(DBusMessageIter *iter)
 {
        g_list_foreach(service_list, append_ins_struct, iter);
 }
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
+
+void __connman_service_list_struct(DBusMessageIter *iter)
+{
+       g_list_foreach(service_list, append_struct, iter);
+}
 
 bool __connman_service_is_hidden(struct connman_service *service)
 {
@@ -4895,7 +5026,7 @@ bool connman_service_get_internet_connection(struct connman_service *service)
        return service->is_internet_connection;
 }
 
-DBusMessage *connman_service_get_defaut_info(DBusMessage *msg,
+DBusMessage *connman_service_create_dbus_service_reply(DBusMessage *msg,
                                                        struct connman_service *service)
 {
        DBusMessage *reply;
@@ -5341,6 +5472,16 @@ int __connman_service_get_use_eapol(struct connman_service *service)
 
        return service->use_eapol;
 }
+
+int __connman_service_get_connect_reason(struct connman_service *service)
+{
+       if (!service) {
+               DBG("Service is NULL");
+               return -1;
+       }
+
+       return service->connect_reason;
+}
 #endif /* defined TIZEN_EXT && defined TIZEN_EXT_EAP_ON_ETHERNET */
 
 static DBusMessage *get_properties(DBusConnection *conn,
@@ -5557,6 +5698,31 @@ error:
        return -EINVAL;
 }
 
+static void do_auto_connect(struct connman_service *service,
+       enum connman_service_connect_reason reason)
+{
+       /*
+        * CONNMAN_SERVICE_CONNECT_REASON_NONE must be ignored for VPNs. VPNs
+        * always have reason CONNMAN_SERVICE_CONNECT_REASON_USER/AUTO.
+        */
+       if (!service || (service->type == CONNMAN_SERVICE_TYPE_VPN &&
+                               reason == CONNMAN_SERVICE_CONNECT_REASON_NONE))
+               return;
+
+       /*
+        * Run service auto connect for other than VPN services. Afterwards
+        * start also VPN auto connect process.
+        */
+       if (service->type != CONNMAN_SERVICE_TYPE_VPN)
+               __connman_service_auto_connect(reason);
+       /* Only user interaction should get VPN connected in failure state. */
+       else if (service->state == CONNMAN_SERVICE_STATE_FAILURE &&
+                               reason != CONNMAN_SERVICE_CONNECT_REASON_USER)
+               return;
+
+       vpn_auto_connect();
+}
+
 int __connman_service_reset_ipconfig(struct connman_service *service,
                enum connman_ipconfig_type type, DBusMessageIter *array,
                enum connman_service_state *new_state)
@@ -5621,7 +5787,7 @@ int __connman_service_reset_ipconfig(struct connman_service *service,
                settings_changed(service, new_ipconfig);
                address_updated(service, type);
 
-               __connman_service_auto_connect(CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+               do_auto_connect(service, CONNMAN_SERVICE_CONNECT_REASON_AUTO);
        }
 
        DBG("err %d ipconfig %p type %d method %d state %s", err,
@@ -5654,6 +5820,9 @@ void __connman_service_wispr_start(struct connman_service *service,
        __connman_wispr_start(service, type);
 }
 
+static void set_error(struct connman_service *service,
+                                       enum connman_service_error error);
+
 static DBusMessage *set_property(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
@@ -5691,17 +5860,26 @@ static DBusMessage *set_property(DBusConnection *conn,
 
                dbus_message_iter_get_basic(&value, &autoconnect);
 
-               if (service->autoconnect == autoconnect)
-                       return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
-
-               service->autoconnect = autoconnect;
-
-               autoconnect_changed(service);
+               if (autoconnect && service->type == CONNMAN_SERVICE_TYPE_VPN) {
+                       /*
+                        * Changing the autoconnect flag on VPN to "on" should
+                        * have the same effect as user connecting the VPN =
+                        * clear previous error and change state to idle.
+                        */
+                       set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
 
-               if (autoconnect)
-                       __connman_service_auto_connect(CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+                       if (service->state == CONNMAN_SERVICE_STATE_FAILURE) {
+                               service->state = CONNMAN_SERVICE_STATE_IDLE;
+                               state_changed(service);
+                       }
+               }
 
-               service_save(service);
+               if (connman_service_set_autoconnect(service, autoconnect)) {
+                       service_save(service);
+                       if (autoconnect)
+                               do_auto_connect(service,
+                                       CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+               }
        } else if (g_str_equal(name, "Nameservers.Configuration")) {
                DBusMessageIter entry;
                GString *str;
@@ -6054,6 +6232,7 @@ static DBusMessage *set_property(DBusConnection *conn,
                if (err < 0)
                        return __connman_error_failed(msg, -err);
 
+               service->connect_reason = CONNMAN_SERVICE_CONNECT_REASON_USER;
                service_save(service);
 #endif /* defined TIZEN_EXT && defined TIZEN_EXT_EAP_ON_ETHERNET */
        } else
@@ -6119,9 +6298,9 @@ static void service_complete(struct connman_service *service)
        reply_pending(service, EIO);
 
        if (service->connect_reason != CONNMAN_SERVICE_CONNECT_REASON_USER)
-               __connman_service_auto_connect(service->connect_reason);
+               do_auto_connect(service, service->connect_reason);
 
-       g_get_current_time(&service->modified);
+       gettimeofday(&service->modified, NULL);
        service_save(service);
 }
 
@@ -6356,6 +6535,8 @@ static bool autoconnect_already_connecting(struct connman_service *service,
        return false;
 }
 
+static int service_indicate_state(struct connman_service *service);
+
 static bool auto_connect_service(GList *services,
                                enum connman_service_connect_reason reason,
                                bool preferred)
@@ -6468,11 +6649,22 @@ static bool auto_connect_service(GList *services,
                DBG("service %p %s %s", service, service->name,
                        (preferred) ? "preferred" : reason2string(reason));
 
+#if defined TIZEN_EXT
                __connman_service_connect(service, reason);
-#if !defined TIZEN_EXT
+#else
+               if (__connman_service_connect(service, reason) == 0)
+                       service_indicate_state(service);
+
                if (autoconnect_no_session_active(service))
                        return true;
 #endif
+#if defined TIZEN_EXT
+               if (service->type == CONNMAN_SERVICE_TYPE_WIFI) {
+                       int index = connman_network_get_index(service->network);
+                       wifi_ignore = g_slist_prepend(wifi_ignore, GINT_TO_POINTER(index));
+                       autoconnecting = true;
+               }
+#endif
                ignore[service->type] = true;
        }
 #if defined TIZEN_EXT
@@ -6559,8 +6751,28 @@ void __connman_service_auto_connect(enum connman_service_connect_reason reason)
 static gboolean run_vpn_auto_connect(gpointer data) {
        GList *list;
        bool need_split = false;
+       bool autoconnectable_vpns = false;
+       int attempts = 0;
+       int timeout = VPN_AUTOCONNECT_TIMEOUT_DEFAULT;
+       struct connman_service *def_service;
 
-       vpn_autoconnect_id = 0;
+       attempts = GPOINTER_TO_INT(data);
+       def_service = connman_service_get_default();
+
+       /*
+        * Stop auto connecting VPN if there is no transport service or the
+        * transport service is not connected or if the  current default service
+        * is a connected VPN (in ready state).
+        */
+       if (!def_service || !is_connected(def_service->state) ||
+               (def_service->type == CONNMAN_SERVICE_TYPE_VPN &&
+               is_connected(def_service->state))) {
+
+               DBG("stopped, default service %s connected %d",
+                       def_service ? def_service->identifier : "NULL",
+                       def_service ? is_connected(def_service->state) : -1);
+               goto out;
+       }
 
        for (list = service_list; list; list = list->next) {
                struct connman_service *service = list->data;
@@ -6570,9 +6782,17 @@ static gboolean run_vpn_auto_connect(gpointer data) {
                        continue;
 
                if (is_connected(service->state) ||
-                               is_connecting(service->state)) {
+                                       is_connecting(service->state)) {
                        if (!service->do_split_routing)
                                need_split = true;
+
+                       /*
+                        * If the service is connecting it must be accounted
+                        * for to keep the autoconnection in main loop.
+                        */
+                       if (is_connecting(service->state))
+                               autoconnectable_vpns = true;
+
                        continue;
                }
 
@@ -6590,20 +6810,64 @@ static gboolean run_vpn_auto_connect(gpointer data) {
 
                res = __connman_service_connect(service,
                                CONNMAN_SERVICE_CONNECT_REASON_AUTO);
-               if (res < 0 && res != -EINPROGRESS)
+
+               switch (res) {
+               case 0:
+                       service_indicate_state(service);
+                       /* fall through */
+               case -EINPROGRESS:
+                       autoconnectable_vpns = true;
+                       break;
+               default:
                        continue;
+               }
 
                if (!service->do_split_routing)
                        need_split = true;
        }
 
-       return FALSE;
+       /* Stop if there is no VPN to automatically connect.*/
+       if (!autoconnectable_vpns) {
+               DBG("stopping, no autoconnectable VPNs found");
+               goto out;
+       }
+
+       /* Increase the attempt count up to the threshold.*/
+       if (attempts < VPN_AUTOCONNECT_TIMEOUT_ATTEMPTS_THRESHOLD)
+               attempts++;
+
+       /*
+        * Timeout increases with 1s after VPN_AUTOCONNECT_TIMEOUT_STEP amount
+        * of attempts made. After VPN_AUTOCONNECT_TIMEOUT_ATTEMPTS_THRESHOLD is
+        * reached the delay does not increase.
+        */
+       timeout = timeout + (int)(attempts / VPN_AUTOCONNECT_TIMEOUT_STEP);
+
+       /* Re add this to main loop */
+       vpn_autoconnect_id =
+               g_timeout_add_seconds(timeout, run_vpn_auto_connect,
+                       GINT_TO_POINTER(attempts));
+
+       DBG("re-added to main loop, next VPN autoconnect in %d seconds (#%d)",
+               timeout, attempts);
+
+       return G_SOURCE_REMOVE;
+
+out:
+       vpn_autoconnect_id = 0;
+       return G_SOURCE_REMOVE;
 }
 
 static void vpn_auto_connect(void)
 {
-       if (vpn_autoconnect_id)
-               return;
+       /*
+        * Remove existing autoconnect from main loop to reset the attempt
+        * counter in order to get VPN connected when there is a network change.
+        */
+       if (vpn_autoconnect_id) {
+               if (!g_source_remove(vpn_autoconnect_id))
+                       return;
+       }
 
        vpn_autoconnect_id =
                g_idle_add(run_vpn_auto_connect, NULL);
@@ -6706,7 +6970,7 @@ static gboolean connect_timeout(gpointer user_data)
        if (autoconnect &&
                        service->connect_reason !=
                                CONNMAN_SERVICE_CONNECT_REASON_USER)
-               __connman_service_auto_connect(CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+               do_auto_connect(service, CONNMAN_SERVICE_CONNECT_REASON_AUTO);
 
        return FALSE;
 }
@@ -7213,7 +7477,7 @@ static DBusMessage *move_service(DBusConnection *conn,
                }
        }
 
-       g_get_current_time(&service->modified);
+       gettimeofday(&service->modified, NULL);
        service_save(service);
        service_save(target);
 
@@ -7257,7 +7521,27 @@ static DBusMessage *reset_counters(DBusConnection *conn,
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
-#if defined TIZEN_MAINTAIN_ONLINE
+#if defined TIZEN_EXT && defined TIZEN_EXT_EAP_ON_ETHERNET
+static DBusMessage *is_eapol_enabled(DBusConnection *conn,
+                                       DBusMessage *msg, void *user_data)
+{
+       struct connman_service *service = user_data;
+       DBG("service: %p path: %s UseEapol: %d", service, service->path, service->use_eapol);
+
+       dbus_bool_t eapol_status = service->use_eapol;
+
+       DBusMessage *reply = dbus_message_new_method_return(msg);
+       if (!reply) {
+               DBG("Failed to initialize reply");
+               return NULL;
+       }
+
+       dbus_message_append_args(reply, DBUS_TYPE_BOOLEAN, &eapol_status, DBUS_TYPE_INVALID);
+       return reply;
+}
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_EAP_ON_ETHERNET */
+
+#if defined TIZEN_EXT
 static DBusMessage *downgrade_service(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
@@ -7265,6 +7549,7 @@ static DBusMessage *downgrade_service(DBusConnection *conn,
 
        downgrade_state(service);
        __connman_connection_update_gateway();
+       start_online_check(service, CONNMAN_IPCONFIG_TYPE_IPV4);
 
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
@@ -7334,7 +7619,10 @@ static const GDBusMethodTable service_methods[] = {
                        GDBUS_ARGS({ "service", "o" }), NULL,
                        move_after) },
        { GDBUS_METHOD("ResetCounters", NULL, NULL, reset_counters) },
-#if defined TIZEN_MAINTAIN_ONLINE
+#if defined TIZEN_EXT && defined TIZEN_EXT_EAP_ON_ETHERNET
+       { GDBUS_METHOD("IsEapolEnabled", NULL, GDBUS_ARGS({ "eapol", "b" }), is_eapol_enabled) },
+#endif
+#if defined TIZEN_EXT
        { GDBUS_METHOD("Downgrade", NULL, NULL, downgrade_service) },
 #endif
        { },
@@ -7343,6 +7631,10 @@ static const GDBusMethodTable service_methods[] = {
 static const GDBusSignalTable service_signals[] = {
        { GDBUS_SIGNAL("PropertyChanged",
                        GDBUS_ARGS({ "name", "s" }, { "value", "v" })) },
+#if defined TIZEN_EXT
+       { GDBUS_SIGNAL("StateChangedProperties",
+                       GDBUS_ARGS({ "properties", "a{sv}" })) },
+#endif
        { },
 };
 
@@ -7605,7 +7897,7 @@ void connman_service_unref_debug(struct connman_service *service,
        g_hash_table_remove(service_hash, service->identifier);
 }
 
-#if defined TIZEN_EXT
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
 static int calculate_score_last_user_selection(struct connman_service *service)
 {
        int score = 0;
@@ -7618,6 +7910,9 @@ static int calculate_score_last_user_selection(struct connman_service *service)
        struct tm* ref_timeinfo;
 
        device = connman_network_get_device(service->network);
+       if (!device)
+               return 0;
+
        last_user_selection_time = connman_device_get_last_user_selection_time(device);
        last_user_selection_ident = connman_device_get_last_user_selection_ident(device);
        frequency = connman_network_get_frequency(service->network);
@@ -7661,17 +7956,22 @@ static int calculate_score_last_connected(struct connman_service *service)
        unsigned int frequency;
 
        device = connman_network_get_device(service->network);
+       if (!device)
+               return 0;
+
        last_connected_ident = connman_device_get_last_connected_ident(device);
        frequency = connman_network_get_frequency(service->network);
 
-       if (g_strcmp0(last_connected_ident, service->identifier) == 0 &&
-               (((frequency >= FREQ_RANGE_24GHZ_CHANNEL_1 &&
-               frequency <= FREQ_RANGE_24GHZ_CHANNEL_14) &&
-               service->strength >= ins_settings.signal_level3_24ghz) ||
-               ((frequency >= FREQ_RANGE_5GHZ_CHANNEL_32 &&
-               frequency <= FREQ_RANGE_5GHZ_CHANNEL_165) &&
-               service->strength >= ins_settings.signal_level3_5ghz))) {
-               score += ins_settings.last_connected_score;
+       if (ins_settings.last_connected) {
+               if (g_strcmp0(last_connected_ident, service->identifier) == 0 &&
+                               (((frequency >= FREQ_RANGE_24GHZ_CHANNEL_1 &&
+                               frequency <= FREQ_RANGE_24GHZ_CHANNEL_14) &&
+                               service->strength >= ins_settings.signal_level3_24ghz) ||
+                               ((frequency >= FREQ_RANGE_5GHZ_CHANNEL_32 &&
+                               frequency <= FREQ_RANGE_5GHZ_CHANNEL_165) &&
+                               service->strength >= ins_settings.signal_level3_5ghz))) {
+                       score += ins_settings.last_connected_score;
+               }
        }
 
        return score;
@@ -7686,7 +7986,7 @@ static int calculate_score_frequency(struct connman_service *service)
 
        switch (ins_settings.preferred_freq) {
        case CONNMAN_INS_PREFERRED_FREQ_24GHZ:
-               if ((frequency >= FREQ_RANGE_24GHZ_CHANNEL_14 &&
+               if ((frequency >= FREQ_RANGE_24GHZ_CHANNEL_1 &&
                        frequency <= FREQ_RANGE_24GHZ_CHANNEL_14) &&
                        (service->strength >= ins_settings.signal_level3_24ghz))
                        score += ins_settings.preferred_freq_score;
@@ -7765,19 +8065,17 @@ static int calculate_score(struct connman_service *service)
                score_frequency + score_security_priority +
                score_internet_connection + score_strength;
 
-#if defined TIZEN_EXT_INS
        service->score_last_user_selection = score_last_user_selection;
        service->score_last_connected = score_last_connected;
        service->score_frequency = score_frequency;
        service->score_security_priority = score_security_priority;
        service->score_internet_connection = score_internet_connection;
        service->score_strength = score_strength;
-#endif
 
        service->ins_score = score;
        return score;
 }
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
 static gint service_compare(gconstpointer a, gconstpointer b)
 {
@@ -7785,12 +8083,12 @@ static gint service_compare(gconstpointer a, gconstpointer b)
        struct connman_service *service_b = (void *) b;
        enum connman_service_state state_a, state_b;
        bool a_connected, b_connected;
-#if defined TIZEN_EXT
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
        int score_a;
        int score_b;
-#else
+#else /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
        gint strength;
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
        state_a = service_a->state;
        state_b = service_b->state;
@@ -7898,21 +8196,21 @@ static gint service_compare(gconstpointer a, gconstpointer b)
                        return 1;
        }
 
-#if defined TIZEN_EXT
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
        score_a = calculate_score(service_a);
        score_b = calculate_score(service_b);
        if (score_b != score_a)
                return score_b - score_a;
-#else
+#else /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
        strength = (gint) service_b->strength - (gint) service_a->strength;
        if (strength)
                return strength;
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
        return g_strcmp0(service_a->name, service_b->name);
 }
 
-#if defined TIZEN_EXT_INS
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
 static void print_service_sort(gpointer data, gpointer user_data)
 {
        struct connman_service *service = data;
@@ -7927,15 +8225,15 @@ static void print_service_sort(gpointer data, gpointer user_data)
                service->score_security_priority, service->score_internet_connection,
                service->score_strength);
 }
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
 static void service_list_sort(void)
 {
        if (service_list && service_list->next) {
                service_list = g_list_sort(service_list, service_compare);
-#if defined TIZEN_EXT_INS
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
                g_list_foreach(service_list, print_service_sort, NULL);
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
                service_schedule_changed();
        }
 }
@@ -8312,7 +8610,8 @@ static void report_error_cb(void *user_context, bool retry,
                service->state_ipv4 = service->state_ipv6 =
                                CONNMAN_SERVICE_STATE_IDLE;
 
-               if (service->error != CONNMAN_SERVICE_ERROR_AUTH_FAILED)
+               if (service->error != CONNMAN_SERVICE_ERROR_AUTH_FAILED &&
+                               service->error != CONNMAN_SERVICE_ERROR_ASSOC_FAILED)
                        set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
 #endif
                service_complete(service);
@@ -8376,12 +8675,15 @@ static void request_input_cb(struct connman_service *service,
                                __connman_service_return_error(service,
                                                        ECONNABORTED,
                                                        user_data);
-                       goto done;
                } else {
+                       err = -ETIMEDOUT;
+
                        if (service->hidden)
                                __connman_service_return_error(service,
                                                        ETIMEDOUT, user_data);
                }
+
+               goto done;
        }
 
        if (service->hidden && name_len > 0 && name_len <= 32) {
@@ -8513,12 +8815,15 @@ static struct connman_device *default_connecting_device = NULL;
 static void __connman_service_disconnect_default(struct connman_service *service)
 {
        struct connman_device *default_device = NULL;
+       struct connman_network *network = __connman_service_get_network(service);
+
+       if (!network)
+               return;
 
        if (default_connecting_device == NULL)
                return;
 
-       default_device = connman_network_get_device(
-                       __connman_service_get_network(service));
+       default_device = connman_network_get_device(network);
 
        DBG("Disconnecting service %p %s", service, service->path);
        DBG("Disconnecting device %p %p %s",
@@ -8830,7 +9135,7 @@ static int service_indicate_state(struct connman_service *service)
                                                        "WiFi.UseWPS", false);
                }
 
-               g_get_current_time(&service->modified);
+               gettimeofday(&service->modified, NULL);
                service_save(service);
 
                domain_changed(service);
@@ -8911,7 +9216,7 @@ static int service_indicate_state(struct connman_service *service)
                 */
                downgrade_connected_services();
 
-               __connman_service_auto_connect(CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+               do_auto_connect(service, CONNMAN_SERVICE_CONNECT_REASON_AUTO);
                break;
 
        case CONNMAN_SERVICE_STATE_FAILURE:
@@ -8939,6 +9244,55 @@ static int service_indicate_state(struct connman_service *service)
 #else
        __connman_service_connect_default(service);
 #endif
+       /* Update Wi-Fi Roaming result */
+       if (connman_setting_get_bool("WifiRoaming") &&
+                       connman_network_get_bool(service->network, "WiFi.Roaming")) {
+               const char *cur_bssid;
+               const char *dst_bssid;
+               const char *ifname;
+               struct connman_device *device;
+
+               device = connman_network_get_device(service->network);
+               if (device) {
+                       ifname = connman_device_get_string(device, "Interface");
+                       cur_bssid = connman_network_get_string(service->network,
+                                               "WiFi.RoamingCurBSSID");
+                       dst_bssid = connman_network_get_string(service->network,
+                                               "WiFi.RoamingDstBSSID");
+               }
+
+               if (device && ifname && cur_bssid && dst_bssid) {
+                       switch(new_state) {
+                       case CONNMAN_SERVICE_STATE_UNKNOWN:
+                       case CONNMAN_SERVICE_STATE_ASSOCIATION:
+                       case CONNMAN_SERVICE_STATE_CONFIGURATION:
+                               break;
+                       case CONNMAN_SERVICE_STATE_READY:
+                       case CONNMAN_SERVICE_STATE_ONLINE:
+                               __connman_technology_notify_roaming_state(ifname,
+                                               "success", cur_bssid, dst_bssid);
+                               connman_network_set_bool(service->network,
+                                               "WiFi.Roaming", false);
+                               connman_network_set_string(service->network,
+                                               "WiFi.RoamingCurBSSID", NULL);
+                               connman_network_set_string(service->network,
+                                               "WiFi.RoamingDstBSSID", NULL);
+                               break;
+                       case CONNMAN_SERVICE_STATE_DISCONNECT:
+                       case CONNMAN_SERVICE_STATE_FAILURE:
+                       case CONNMAN_SERVICE_STATE_IDLE:
+                               __connman_technology_notify_roaming_state(ifname,
+                                               "failure", cur_bssid, dst_bssid);
+                               connman_network_set_bool(service->network,
+                                               "WiFi.Roaming", false);
+                               connman_network_set_string(service->network,
+                                               "WiFi.RoamingCurBSSID", NULL);
+                               connman_network_set_string(service->network,
+                                               "WiFi.RoamingDstBSSID", NULL);
+                               break;
+                       }
+               }
+       }
 #endif
 
        __connman_connection_update_gateway();
@@ -9062,34 +9416,6 @@ enum connman_service_state __connman_service_ipconfig_get_state(
        return CONNMAN_SERVICE_STATE_UNKNOWN;
 }
 
-static void check_proxy_setup(struct connman_service *service)
-{
-       /*
-        * We start WPAD if we haven't got a PAC URL from DHCP and
-        * if our proxy manual configuration is either empty or set
-        * to AUTO with an empty URL.
-        */
-
-       if (service->proxy != CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN)
-               goto done;
-
-       if (service->proxy_config != CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN &&
-               (service->proxy_config != CONNMAN_SERVICE_PROXY_METHOD_AUTO ||
-                       service->pac))
-               goto done;
-
-       if (__connman_wpad_start(service) < 0) {
-               service->proxy = CONNMAN_SERVICE_PROXY_METHOD_DIRECT;
-               __connman_notifier_proxy_changed(service);
-               goto done;
-       }
-
-       return;
-
-done:
-       __connman_service_wispr_start(service, CONNMAN_IPCONFIG_TYPE_IPV4);
-}
-
 #if defined TIZEN_EXT
 void connman_check_proxy_setup_and_wispr_start(struct connman_service *service){
 
@@ -9169,7 +9495,13 @@ static gboolean redo_wispr_ipv4(gpointer user_data)
 {
        struct connman_service *service = user_data;
 
+#if defined TIZEN_MAINTAIN_ONLINE
+       DBG("");
+
+       __connman_wispr_start(service, CONNMAN_IPCONFIG_TYPE_IPV4);
+#else
        redo_wispr(service, CONNMAN_IPCONFIG_TYPE_IPV4);
+#endif
 
        return FALSE;
 }
@@ -9183,19 +9515,6 @@ static gboolean redo_wispr_ipv6(gpointer user_data)
        return FALSE;
 }
 
-#if defined TIZEN_MAINTAIN_ONLINE
-static gboolean redo_wispr_ipv4(gpointer user_data)
-{
-       struct connman_service *service = user_data;
-
-       DBG("");
-
-       __connman_wispr_start(service, CONNMAN_IPCONFIG_TYPE_IPV4);
-
-       return FALSE;
-}
-#endif
-
 int __connman_service_online_check_failed(struct connman_service *service,
                                        enum connman_ipconfig_type type)
 {
@@ -9225,16 +9544,6 @@ int __connman_service_online_check_failed(struct connman_service *service,
        return EAGAIN;
 }
 
-static void cancel_online_check(struct connman_service *service)
-{
-       if (service->online_timeout == 0)
-               return;
-
-       g_source_remove(service->online_timeout);
-       service->online_timeout = 0;
-       connman_service_unref(service);
-}
-
 int __connman_service_ipconfig_indicate_state(struct connman_service *service,
                                        enum connman_service_state new_state,
                                        enum connman_ipconfig_type type)
@@ -10014,7 +10323,7 @@ static int service_register(struct connman_service *service)
        if (ret == -ERANGE)
                service_ext_save(service);
        ret = __connman_config_provision_service(service);
-       if (ret < 0 && simplified_log)
+       if (ret < 0 && !simplified_log)
                DBG("Failed to provision service");
 #else
        if (__connman_config_provision_service(service) < 0)
@@ -10579,7 +10888,8 @@ struct connman_service * __connman_service_create_from_network(struct connman_ne
                        case CONNMAN_SERVICE_TYPE_VPN:
                        case CONNMAN_SERVICE_TYPE_WIFI:
                        case CONNMAN_SERVICE_TYPE_CELLULAR:
-                               __connman_service_auto_connect(CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+                               do_auto_connect(service,
+                                       CONNMAN_SERVICE_CONNECT_REASON_AUTO);
                                break;
                        }
                }
@@ -10896,7 +11206,7 @@ static struct connman_agent_driver agent_driver = {
        .context_unref  = agent_context_unref,
 };
 
-#if defined TIZEN_EXT
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
 static void ins_setting_init(void)
 {
        int i;
@@ -10953,8 +11263,13 @@ static void ins_setting_init(void)
        ins_settings.preferred_freq_score = connman_setting_get_uint("INSPreferredFreqScore");
        ins_settings.internet_score = connman_setting_get_uint("INSInternetScore");
 
-       ins_settings.signal_level3_5ghz = connman_setting_get_int("INSSignalLevel3_5GHz");
-       ins_settings.signal_level3_24ghz = connman_setting_get_int("INSSignalLevel3_24GHz");
+       /*
+        * In ConnMan, signal strength is used after being converted
+        * to positive value(signal strength + 120).
+        * So the value for comparison should also be converted to the same.
+        */
+       ins_settings.signal_level3_5ghz = connman_setting_get_int("INSSignalLevel3_5GHz") + 120;
+       ins_settings.signal_level3_24ghz = connman_setting_get_int("INSSignalLevel3_24GHz") + 120;
 
        DBG("last_user_selection [%s]", ins_settings.last_user_selection ? "true" : "false");
        DBG("last_user_selection_time [%d]", ins_settings.last_user_selection_time);
@@ -10982,7 +11297,7 @@ static void ins_setting_init(void)
        DBG("signal_level3_5ghz [%d]", ins_settings.signal_level3_5ghz);
        DBG("signal_level3_24ghz [%d]", ins_settings.signal_level3_24ghz);
 }
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
 int __connman_service_init(void)
 {
@@ -11011,9 +11326,9 @@ int __connman_service_init(void)
 
        remove_unprovisioned_services();
 
-#if defined TIZEN_EXT
+#if defined TIZEN_EXT && defined TIZEN_EXT_INS
        ins_setting_init();
-#endif
+#endif /* defined TIZEN_EXT && defined TIZEN_EXT_INS */
 
        return 0;
 }