Fix dereferencing issues
[platform/upstream/connman.git] / plugins / wifi.c
index 0b5315f..7a8eccc 100755 (executable)
@@ -49,7 +49,6 @@
 #include <connman/service.h>
 #include <connman/peer.h>
 #include <connman/log.h>
-#include <connman/option.h>
 #include <connman/storage.h>
 #include <include/setting.h>
 #include <connman/provision.h>
 #define BGSCAN_DEFAULT "simple:30:-65:300"
 #define AUTOSCAN_EXPONENTIAL "exponential:3:300"
 #define AUTOSCAN_SINGLE "single:3"
+#define SCAN_MAX_DURATION 10
 
 #define P2P_FIND_TIMEOUT 30
 #define P2P_CONNECTION_TIMEOUT 100
 #define P2P_LISTEN_PERIOD 500
 #define P2P_LISTEN_INTERVAL 2000
 
+#define ASSOC_STATUS_AUTH_TIMEOUT 16
 #define ASSOC_STATUS_NO_CLIENT 17
 #if defined TIZEN_EXT
 #define LOAD_SHAPING_MAX_RETRIES 7
 #define RSSI_LEVEL_2_24G -75
 #define RSSI_LEVEL_3_5G  -68
 #define RSSI_LEVEL_3_24G -64
-#define WIFI_BSSID_STR_LEN 18
-#define MAC2STR(a) (a)[0], (a)[1], (a)[2], (a)[3], (a)[4], (a)[5]
-#define MACSTR "%02x:%02x:%02x:%02x:%02x:%02x"
 #define ROAM_SCAN_INTERVAL 60 /* 60 seconds */
 #endif
 
@@ -210,6 +208,11 @@ struct wifi_data {
 #endif
 };
 
+struct disconnect_data {
+       struct wifi_data *wifi;
+       struct connman_network *network;
+};
+
 #if defined TIZEN_EXT
 #include "connman.h"
 #include "dbus.h"
@@ -223,7 +226,6 @@ static GHashTable *failed_bssids = NULL;
 static unsigned char buff_bssid[WIFI_BSSID_LEN_MAX] = { 0, };
 #endif
 
-
 static GList *iface_list = NULL;
 
 static GList *pending_wifi_device = NULL;
@@ -1153,15 +1155,23 @@ static GSupplicantP2PServiceParams *fill_in_peer_service_params(
 
        if (version > 0) {
                params->version = version;
-               params->service = g_memdup(spec, spec_length);
+               if (spec_length > 0) {
+                       params->service = g_malloc(spec_length);
+                       memcpy(params->service, spec, spec_length);
+               }
        } else if (query_length > 0 && spec_length > 0) {
-               params->query = g_memdup(query, query_length);
+               params->query = g_malloc(query_length);
+               memcpy(params->query, query, query_length);
                params->query_length = query_length;
 
-               params->response = g_memdup(spec, spec_length);
+               params->response = g_malloc(spec_length);
+               memcpy(params->response, spec, spec_length);
                params->response_length = spec_length;
        } else {
-               params->wfd_ies = g_memdup(spec, spec_length);
+               if (spec_length > 0) {
+                       params->wfd_ies = g_malloc(spec_length);
+                       memcpy(params->wfd_ies, spec, spec_length);
+               }
                params->wfd_ies_length = spec_length;
        }
 
@@ -1433,14 +1443,15 @@ static void wifi_newlink(unsigned flags, unsigned change, void *user_data)
        }
 
        if ((wifi->flags & IFF_LOWER_UP) != (flags & IFF_LOWER_UP)) {
-               if (flags & IFF_LOWER_UP) {
+               if (flags & IFF_LOWER_UP)
                        DBG("carrier on");
-
-                       handle_tethering(wifi);
-               } else
+               else
                        DBG("carrier off");
        }
 
+       if (flags & IFF_LOWER_UP)
+               handle_tethering(wifi);
+
        wifi->flags = flags;
 }
 
@@ -1996,11 +2007,14 @@ static int get_hidden_connections_params(struct wifi_data *wifi,
                scan_params->num_ssids = i;
                scan_params->ssids = g_slist_reverse(scan_params->ssids);
 
-               scan_params->freqs = g_memdup(orig_params->freqs,
-                               sizeof(uint16_t) * orig_params->num_freqs);
-               if (!scan_params->freqs)
+               if (orig_params->num_freqs <= 0)
                        goto err;
 
+               scan_params->freqs =
+                       g_malloc(sizeof(uint16_t) * orig_params->num_freqs);
+               memcpy(scan_params->freqs, orig_params->freqs,
+                       sizeof(uint16_t) *orig_params->num_freqs);
+
                scan_params->num_freqs = orig_params->num_freqs;
 
        } else
@@ -2160,6 +2174,59 @@ static void scan_callback_hidden(int result,
                        GSupplicantInterface *interface, void *user_data);
 
 static int network_disconnect(struct connman_network *network);
+
+static void start_roaming(struct wifi_data *wifi)
+{
+       bool roaming_ap_found = false;
+       GSList *bssid_list = NULL;
+
+       if (!wifi || !wifi->network)
+               return;
+
+       if (connman_setting_get_bool("WifiRoaming")) {
+               struct connman_network *network = wifi->network;
+               bssid_list = connman_network_get_bssid_list(network);
+
+               if (g_slist_length(bssid_list) <= 1)
+                       return;
+
+               if (!connman_network_get_connected(network))
+                       return;
+
+               if (connman_network_get_bool(network, "WiFi.Roaming"))
+                       return;
+
+               if (!need_bss_transition(
+                               connman_network_get_frequency(network),
+                               connman_network_get_snr(network),
+                               connman_network_get_strength(network)))
+                       return;
+
+               for (bssid_list; bssid_list; bssid_list = bssid_list->next) {
+                       struct g_connman_bssids *bssid = bssid_list->data;
+
+                       if (check_bss_condition(bssid->frequency,
+                                       bssid->score_snr, bssid->strength))
+                               roaming_ap_found = true;
+               }
+
+               if (roaming_ap_found) {
+                       char bssid_buff[WIFI_BSSID_STR_LEN] = {0,};
+                       char *bssid_str = bssid_buff;
+                       unsigned char *bssid;
+
+                       bssid = connman_network_get_bssid(network);
+                       snprintf(bssid_str, WIFI_BSSID_STR_LEN, MACSTR, MAC2STR(bssid));
+                       connman_network_set_string(network,
+                                       "WiFi.RoamingCurBSSID", bssid_str);
+
+                       network_disconnect(network);
+                       wifi->pending_network = network;
+                       connman_network_set_bool(network, "WiFi.Roaming", true);
+               }
+       }
+}
+
 #endif
 
 static void scan_callback(int result, GSupplicantInterface *interface,
@@ -2169,10 +2236,7 @@ static void scan_callback(int result, GSupplicantInterface *interface,
        struct wifi_data *wifi = connman_device_get_data(device);
        bool scanning;
 #if defined TIZEN_EXT
-       bool roaming_needed = false;
-       bool roaming_ap_found = false;
        GSList *list = NULL;
-       GSList *bssid_list = NULL;
        bool favorite_exists = false;
        struct connman_network *network = NULL;
        struct connman_service *service = NULL;
@@ -2289,46 +2353,8 @@ static void scan_callback(int result, GSupplicantInterface *interface,
                network_connect(wifi->scan_pending_network);
                wifi->scan_pending_network = NULL;
                connman_network_set_connecting(wifi->network);
-       } else if (connman_setting_get_bool("WifiRoaming") && wifi->network) {
-               bssid_list = connman_network_get_bssid_list(wifi->network);
-
-               if (g_slist_length(bssid_list) <= 1)
-                       goto done;
-
-               if (!connman_network_get_connected(wifi->network))
-                       goto done;
-
-               if (connman_network_get_bool(wifi->network, "WiFi.Roaming"))
-                       goto done;
-
-               if (!need_bss_transition(
-                               connman_network_get_frequency(wifi->network),
-                               connman_network_get_snr(wifi->network),
-                               connman_network_get_strength(wifi->network)))
-                       goto done;
-
-               for (bssid_list; bssid_list; bssid_list = bssid_list->next) {
-                       struct g_connman_bssids *bssid = bssid_list->data;
-
-                       if (check_bss_condition(bssid->frequency,
-                                       bssid->score_snr, bssid->strength))
-                               roaming_ap_found = true;
-               }
-
-               if (roaming_ap_found) {
-                       char bssid_buff[WIFI_BSSID_STR_LEN] = {0,};
-                       char *bssid_str = bssid_buff;
-                       unsigned char *bssid;
-
-                       bssid = connman_network_get_bssid(wifi->network);
-                       snprintf(bssid_str, WIFI_BSSID_STR_LEN, MACSTR, MAC2STR(bssid));
-                       connman_network_set_string(wifi->network,
-                                       "WiFi.RoamingCurBSSID", bssid_str);
-
-                       network_disconnect(wifi->network);
-                       wifi->pending_network = wifi->network;
-                       connman_network_set_bool(wifi->network, "WiFi.Roaming", true);
-               }
+       } else {
+               start_roaming(wifi);
        }
 
 done:
@@ -2584,6 +2610,8 @@ static void interface_create_callback(int result,
                                                        void *user_data)
 {
        struct wifi_data *wifi = user_data;
+       char *bgscan_range_max;
+       long value;
 
        DBG("result %d ifname %s, wifi %p", result,
                                g_supplicant_interface_get_ifname(interface),
@@ -2599,6 +2627,24 @@ static void interface_create_callback(int result,
                wifi->interface_ready = true;
                finalize_interface_creation(wifi);
        }
+
+       /*
+        * Set the BSS expiration age to match the long scanning
+        * interval to avoid the loss of unconnected networks between
+        * two scans.
+        */
+       bgscan_range_max = strrchr(BGSCAN_DEFAULT, ':');
+       if (!bgscan_range_max || strlen(bgscan_range_max) < 1)
+               return;
+
+       value = strtol(bgscan_range_max + 1, NULL, 10);
+       if (value <= 0 || errno == ERANGE)
+               return;
+
+       if (g_supplicant_interface_set_bss_expiration_age(interface,
+                                       value + SCAN_MAX_DURATION) < 0) {
+               connman_warn("Failed to set bss expiration age");
+       }
 }
 
 static int wifi_enable(struct connman_device *device)
@@ -2606,7 +2652,7 @@ static int wifi_enable(struct connman_device *device)
        struct wifi_data *wifi = connman_device_get_data(device);
        int index;
        char *interface;
-       const char *driver = connman_option_get_string("wifi");
+       const char *driver = connman_setting_get_string("wifi");
        int ret;
 
        DBG("device %p %p", device, wifi);
@@ -2920,7 +2966,7 @@ static void specific_scan_callback(int result, GSupplicantInterface *interface,
        struct wifi_data *wifi = connman_device_get_data(device);
        bool scanning;
 
-       DBG("result %d wifi %p", result, wifi);
+       DBG("result %d device %p wifi %p", result, device, wifi);
 
        if (wifi && wifi->scan_params) {
                g_supplicant_free_scan_params(wifi->scan_params);
@@ -2934,6 +2980,8 @@ static void specific_scan_callback(int result, GSupplicantInterface *interface,
                                CONNMAN_SERVICE_TYPE_WIFI, false);
                connman_device_unref(device);
        }
+
+       start_roaming(wifi);
 }
 
 static int wifi_specific_scan(enum connman_service_type type,
@@ -3880,7 +3928,7 @@ done:
                        connman_network_get_string(network, "WiFi.KeymgmtType"));
        ssid->phase1 = connman_network_get_string(network, "WiFi.Phase1");
 
-       if(g_strcmp0(ssid->eap, "fast") == 0)
+       if (g_strcmp0(ssid->eap, "fast") == 0)
                ssid->pac_file = g_strdup(WIFI_EAP_FAST_PAC_FILE);
 
        ssid->keymgmt = connman_network_get_keymgmt(network);
@@ -3937,11 +3985,13 @@ static int network_connect(struct connman_network *network)
 static void disconnect_callback(int result, GSupplicantInterface *interface,
                                                                void *user_data)
 {
+       struct disconnect_data *dd = user_data;
+       struct connman_network *network = dd->network;
 #if defined TIZEN_EXT
        GList *list;
-       struct wifi_data *wifi;
-       struct connman_network *network = user_data;
+       struct wifi_data *wifi = NULL;
 
+       g_free(dd);
        DBG("network %p result %d", network, result);
 
        for (list = iface_list; list; list = list->next) {
@@ -3954,16 +4004,21 @@ static void disconnect_callback(int result, GSupplicantInterface *interface,
                        goto found;
        }
 
+       if (wifi && network == wifi->pending_network)
+               wifi->pending_network = NULL;
+
        /* wifi_data may be invalid because wifi is already disabled */
        return;
 
 found:
 #else
-       struct wifi_data *wifi = user_data;
+       struct wifi_data *wifi = dd->wifi;
+       g_free(dd);
 #endif
 
-       DBG("result %d supplicant interface %p wifi %p",
-                       result, interface, wifi);
+       DBG("result %d supplicant interface %p wifi %p networks: current %p "
+               "pending %p disconnected %p", result, interface, wifi,
+               wifi->network, wifi->pending_network, network);
 
        if (result == -ECONNABORTED) {
                DBG("wifi interface no longer available");
@@ -3971,16 +4026,24 @@ found:
        }
 
 #if defined TIZEN_EXT
-       if (wifi->network &&
-                       (wifi->network != wifi->pending_network ||
-                       connman_network_get_bool(wifi->network, "WiFi.Roaming")))
+       if (g_slist_find(wifi->networks, network) &&
+                       wifi->network != wifi->pending_network)
 #else
-       if (wifi->network && wifi->network != wifi->pending_network)
+       if (g_slist_find(wifi->networks, network))
 #endif
-               connman_network_set_connected(wifi->network, false);
-       wifi->network = NULL;
+               connman_network_set_connected(network, false);
 
        wifi->disconnecting = false;
+
+       if (network != wifi->network) {
+               if (network == wifi->pending_network)
+                       wifi->pending_network = NULL;
+               DBG("current wifi network has changed since disconnection");
+               return;
+       }
+
+       wifi->network = NULL;
+
        wifi->connected = false;
 
        if (wifi->pending_network) {
@@ -3994,6 +4057,7 @@ found:
 static int network_disconnect(struct connman_network *network)
 {
        struct connman_device *device = connman_network_get_device(network);
+       struct disconnect_data *dd;
        struct wifi_data *wifi;
        int err;
 #if defined TIZEN_EXT
@@ -4036,16 +4100,16 @@ static int network_disconnect(struct connman_network *network)
 
        wifi->disconnecting = true;
 
-#if defined TIZEN_EXT
-       err = g_supplicant_interface_disconnect(wifi->interface,
-                                               disconnect_callback, network);
-#else
-       err = g_supplicant_interface_disconnect(wifi->interface,
-                                               disconnect_callback, wifi);
-#endif
+       dd = g_malloc0(sizeof(*dd));
+       dd->wifi = wifi;
+       dd->network = network;
 
-       if (err < 0)
+       err = g_supplicant_interface_disconnect(wifi->interface,
+                                               disconnect_callback, dd);
+       if (err < 0) {
                wifi->disconnecting = false;
+               g_free(dd);
+       }
 
        return err;
 }
@@ -4133,7 +4197,10 @@ static void signalpoll_callback(int result, int maxspeed, int strength,
        const char *interface = NULL;
        struct connman_device *device;
        struct connman_network *network = user_data;
+       GSupplicantNetwork *supplicant_network;
+       struct wifi_data *wifi = NULL;
        uint16_t freq = connman_network_get_frequency(network);
+       const char *group = connman_network_get_group(network);
 
        if (result != 0) {
                DBG("Failed to get maxspeed from signalpoll !");
@@ -4141,30 +4208,44 @@ static void signalpoll_callback(int result, int maxspeed, int strength,
                return;
        }
 
+       device = connman_network_get_device(network);
+       if (device)
+               wifi = connman_device_get_data(device);
+
+       if (group && wifi) {
+               supplicant_network = g_supplicant_interface_get_network(wifi->interface, group);
+               if (supplicant_network) {
+                       g_supplicant_network_set_signal(supplicant_network, strength);
+                       g_supplicant_network_set_bss_signal(supplicant_network, strength, snr);
+               }
+       }
+
        strength += 120;
        if (strength > 100)
                strength = 100;
 
-       DBG("freq = %u, maxspeed = %d, strength = %d, snr = %d", freq, maxspeed, strength, snr);
+       bssid = connman_network_get_bssid(network);
+       snprintf(bssid_str, WIFI_BSSID_STR_LEN, MACSTR, MAC2STR(bssid));
+
+       DBG("network %p, bssid %s, freq %u, maxspeed %d, strength %d, snr %d",
+                       network, bssid_str, freq, maxspeed, strength, snr);
 
        connman_network_set_strength(network, (uint8_t)strength);
        connman_network_set_snr(network, snr);
        connman_network_set_maxspeed(network, maxspeed);
        set_connection_mode(network, maxspeed);
 
+       if (connman_network_get_max_bssid_count(network) <= 1)
+               goto done;
+
        clock_gettime(CLOCK_MONOTONIC, &curr_time);
        roam_scan_time = connman_network_get_roam_scan_time(network);
        if (curr_time.tv_sec <= roam_scan_time + ROAM_SCAN_INTERVAL)
                goto done;
 
-       if (need_bss_transition(freq, snr, strength)) {
-               device = connman_network_get_device(network);
-               if (!device)
-                       goto done;
+       if (device && need_bss_transition(freq, snr, strength)) {
 
                interface = connman_device_get_string(device, "Interface");
-               bssid = connman_network_get_bssid(network);
-               snprintf(bssid_str, WIFI_BSSID_STR_LEN, MACSTR, MAC2STR(bssid));
                __connman_technology_notify_roaming_state(interface, "required", bssid_str, NULL);
 
                if (connman_setting_get_bool("WifiRoamingScan") == false)
@@ -4342,6 +4423,7 @@ static bool handle_wps_completion(GSupplicantInterface *interface,
        if (wps) {
                const unsigned char *ssid, *wps_ssid;
                unsigned int ssid_len, wps_ssid_len;
+               struct disconnect_data *dd;
                const char *wps_key;
 
                /* Checking if we got associated with requested
@@ -4354,16 +4436,16 @@ static bool handle_wps_completion(GSupplicantInterface *interface,
 
                if (!wps_ssid || wps_ssid_len != ssid_len ||
                                memcmp(ssid, wps_ssid, ssid_len) != 0) {
+                       dd = g_malloc0(sizeof(*dd));
+                       dd->wifi = wifi;
+                       dd->network = network;
+
                        connman_network_set_associating(network, false);
-#if defined TIZEN_EXT
                        g_supplicant_interface_disconnect(wifi->interface,
-                                               disconnect_callback, wifi->network);
-
+                                               disconnect_callback, dd);
+#if defined TIZEN_EXT
                        connman_network_set_bool(network, "WiFi.UseWPS", false);
                        connman_network_set_string(network, "WiFi.PinWPS", NULL);
-#else
-                       g_supplicant_interface_disconnect(wifi->interface,
-                                               disconnect_callback, wifi);
 #endif
                        return false;
                }
@@ -4406,10 +4488,12 @@ static bool handle_wps_completion(GSupplicantInterface *interface,
 static bool handle_assoc_status_code(GSupplicantInterface *interface,
                                      struct wifi_data *wifi)
 {
-       if (wifi->state == G_SUPPLICANT_STATE_ASSOCIATING &&
 #if defined TIZEN_EXT
-                       wifi->assoc_code > 0 &&
+       if ((wifi->state == G_SUPPLICANT_STATE_ASSOCIATING ||
+                       wifi->state == G_SUPPLICANT_STATE_AUTHENTICATING ||
+                       wifi->state == G_SUPPLICANT_STATE_ASSOCIATED) &&
 #else
+       if (wifi->state == G_SUPPLICANT_STATE_ASSOCIATING &&
                        wifi->assoc_code == ASSOC_STATUS_NO_CLIENT &&
 #endif
                        wifi->load_shaping_retries < LOAD_SHAPING_MAX_RETRIES) {
@@ -4424,10 +4508,10 @@ static bool handle_4way_handshake_failure(GSupplicantInterface *interface,
                                        struct connman_network *network,
                                        struct wifi_data *wifi)
 {
-#if defined TIZEN_EXT
-       const char *security;
        struct connman_service *service;
 
+#if defined TIZEN_EXT
+       const char *security;
        if (wifi->connected)
                return false;
 
@@ -4444,9 +4528,9 @@ static bool handle_4way_handshake_failure(GSupplicantInterface *interface,
        if (wifi->state != G_SUPPLICANT_STATE_4WAY_HANDSHAKE)
                return false;
 #else
-       struct connman_service *service;
-
-       if (wifi->state != G_SUPPLICANT_STATE_4WAY_HANDSHAKE)
+       if ((wifi->state != G_SUPPLICANT_STATE_4WAY_HANDSHAKE) &&
+                       !((wifi->state == G_SUPPLICANT_STATE_ASSOCIATING) &&
+                               (wifi->assoc_code == ASSOC_STATUS_AUTH_TIMEOUT)))
                return false;
 
        if (wifi->connected)
@@ -4520,6 +4604,65 @@ static bool handle_wifi_assoc_retry(struct connman_network *network,
 
        return true;
 }
+
+static void handle_wifi_roaming_complete(struct connman_network *network)
+{
+       const char *cur_bssid;
+       const char *dst_bssid;
+       const char *ifname;
+       struct connman_device *device;
+       struct connman_service *service;
+       struct connman_ipconfig *ipconfig_ipv4;
+       enum connman_ipconfig_type type;
+       enum connman_ipconfig_method method;
+
+       if (!connman_setting_get_bool("WifiRoaming") ||
+                       !connman_network_get_bool(network, "WiFi.Roaming"))
+               return;
+
+       device = connman_network_get_device(network);
+       if (device) {
+               ifname = connman_device_get_string(device, "Interface");
+               cur_bssid = connman_network_get_string(network,
+                               "WiFi.RoamingCurBSSID");
+               dst_bssid = connman_network_get_string(network,
+                               "WiFi.RoamingDstBSSID");
+       }
+
+       if (device && ifname && cur_bssid && dst_bssid) {
+               __connman_technology_notify_roaming_state(ifname,
+                               "success", cur_bssid, dst_bssid);
+               connman_network_set_bool(network,
+                               "WiFi.Roaming", false);
+               connman_network_set_string(network,
+                               "WiFi.RoamingCurBSSID", NULL);
+               connman_network_set_string(network,
+                               "WiFi.RoamingDstBSSID", NULL);
+
+               service = connman_service_lookup_from_network(network);
+               if (!service)
+                       return;
+
+               ipconfig_ipv4 = __connman_service_get_ip4config(service);
+               if (!ipconfig_ipv4) {
+                       connman_error("Service has no IPv4 configuration");
+                       return;
+               }
+
+               type = __connman_ipconfig_get_config_type(ipconfig_ipv4);
+               if (type != CONNMAN_IPCONFIG_TYPE_IPV4)
+                       return;
+
+               method = __connman_ipconfig_get_method(ipconfig_ipv4);
+               if (method != CONNMAN_IPCONFIG_METHOD_DHCP)
+                       return;
+
+               connman_network_set_bool(network, "WiFi.RoamingDHCP", true);
+
+               if (set_connected_dhcp(network) != 0)
+                       connman_network_set_bool(network, "WiFi.RoamingDHCP", false);
+       }
+}
 #endif
 
 static void interface_state(GSupplicantInterface *interface)
@@ -4580,6 +4723,8 @@ static void interface_state(GSupplicantInterface *interface)
                        wifi->automaxspeed_timeout = 0;
                        DBG("Remove signalpoll timer!!");
                }
+
+               if (!connman_network_get_bool(wifi->network, "WiFi.Roaming"))
 #endif
                if (wifi->connected)
                        connman_network_set_connected(network, false);
@@ -4593,7 +4738,9 @@ static void interface_state(GSupplicantInterface *interface)
 #else
                stop_autoscan(device);
 #endif
-
+#if defined TIZEN_EXT
+               if (!connman_network_get_bool(wifi->network, "WiFi.Roaming"))
+#endif
                if (!wifi->connected)
                        connman_network_set_associating(network, true);
 
@@ -4627,6 +4774,7 @@ static void interface_state(GSupplicantInterface *interface)
                }
 
                g_hash_table_remove_all(failed_bssids);
+               handle_wifi_roaming_complete(network);
 #else
                /* though it should be already stopped: */
                stop_autoscan(device);
@@ -4668,7 +4816,7 @@ static void interface_state(GSupplicantInterface *interface)
                        break;
 
 #if defined TIZEN_EXT
-               if (handle_assoc_status_code(interface, wifi)) {
+               if (!wifi->connected && handle_assoc_status_code(interface, wifi)) {
                        const char *group = connman_network_get_group(network);
                        GSupplicantNetwork *supplicant_network;
                        GSList *bssid_list = NULL;
@@ -4678,7 +4826,7 @@ static void interface_state(GSupplicantInterface *interface)
                                supplicant_network = g_supplicant_interface_get_network(interface, group);
 
                                connman_network_set_assoc_reject_table(network,
-                                       g_supplicant_network_get_assoc_reject_table(supplicant_network));
+                                               g_supplicant_network_clone_assoc_reject_table(supplicant_network));
 
                                g_supplicant_network_update_assoc_reject(interface, supplicant_network);
                        }
@@ -4711,9 +4859,10 @@ static void interface_state(GSupplicantInterface *interface)
 
                /* See table 8-36 Reason codes in IEEE Std 802.11 */
                switch (wifi->disconnect_code) {
+#if defined TIZEN_EXT
                case 1: /* Unspecified reason */
                        /* Let's assume it's because we got blocked */
-
+#endif
                case 6: /* Class 2 frame received from nonauthenticated STA */
                        connman_network_set_error(network,
                                                CONNMAN_NETWORK_ERROR_BLOCKED);
@@ -4732,7 +4881,7 @@ static void interface_state(GSupplicantInterface *interface)
                        break;
                }
 
-               if(wifi->disconnect_code > 0){
+               if (wifi->disconnect_code > 0){
                        DBG("Set disconnect reason code(%d)", wifi->disconnect_code);
                        connman_network_set_disconnect_reason(network, wifi->disconnect_code);
                }
@@ -5318,6 +5467,8 @@ static void network_added(GSupplicantNetwork *supplicant_network)
                        g_supplicant_network_get_enc_mode(supplicant_network));
        connman_network_set_rsn_mode(network,
                        g_supplicant_network_get_rsn_mode(supplicant_network));
+       connman_network_set_bool(network, "WiFi.PMFRequired",
+                       (bool)g_supplicant_network_is_pmf_required(supplicant_network));
        connman_network_set_keymgmt(network, keymgmt);
        connman_network_set_bool(network, "WiFi.HS20AP",
                        g_supplicant_network_is_hs20AP(supplicant_network));
@@ -5326,7 +5477,7 @@ static void network_added(GSupplicantNetwork *supplicant_network)
        connman_network_set_last_connected_bssid(network,
                        g_supplicant_network_get_last_connected_bssid(supplicant_network));
        connman_network_set_assoc_reject_table(network,
-                       g_supplicant_network_get_assoc_reject_table(supplicant_network));
+                       g_supplicant_network_clone_assoc_reject_table(supplicant_network));
 #endif
        connman_network_set_available(network, true);
        connman_network_set_string(network, "WiFi.Mode", mode);
@@ -5531,7 +5682,7 @@ static void network_changed(GSupplicantNetwork *network, const char *property)
 #if defined TIZEN_EXT
        else if (g_str_equal(property, "UpdateAssocReject")) {
                connman_network_set_assoc_reject_table(connman_network,
-                                       g_supplicant_network_get_assoc_reject_table(network));
+                               g_supplicant_network_clone_assoc_reject_table(network));
                update_needed = true;
        }
 #endif
@@ -6210,7 +6361,7 @@ static void sta_remove_callback(int result,
                                        void *user_data)
 {
        struct wifi_tethering_info *info = user_data;
-       const char *driver = connman_option_get_string("wifi");
+       const char *driver = connman_setting_get_string("wifi");
 
        DBG("ifname %s result %d ", info->ifname, result);
 
@@ -6408,7 +6559,7 @@ static void supp_ins_init(void)
        const char *string;
        GSupplicantINSPreferredFreq preferred_freq;
 
-       string = connman_option_get_string("INSPreferredFreqBSSID");
+       string = connman_setting_get_string("INSPreferredFreqBSSID");
        if (g_strcmp0(string, "5GHz") == 0)
                preferred_freq = G_SUPPLICANT_INS_PREFERRED_FREQ_5GHZ;
        else if (g_strcmp0(string, "2.4GHz") == 0)