platform/upstream/bluez.git
4 years agoFix response_needed not set issue 76/217876/1 accepted/tizen/5.5/unified/20191118.084835 accepted/tizen/5.5/unified/20191120.130938 accepted/tizen/5.5/unified/20191121.073247 accepted/tizen/unified/20191118.122944 submit/tizen/20191115.070745 submit/tizen_5.5/20191115.070441 submit/tizen_5.5/20191115.070934 submit/tizen_5.5/20191118.005342 submit/tizen_5.5/20191118.011157 submit/tizen_5.5/20191119.233738
Wootak Jung [Fri, 15 Nov 2019 06:52:40 +0000 (15:52 +0900)]
Fix response_needed not set issue

write request is failed on server side because
response_needed is not set.

Change-Id: Id63b9e8dda44917ec5442b3224c136952c69c4fc

4 years agoRevert "Fix: ConnectProfiles never be returned" 03/216303/1 accepted/tizen/unified/20191101.042116 submit/tizen/20191031.005137
Deokhyun Kim [Wed, 23 Oct 2019 07:01:42 +0000 (16:01 +0900)]
Revert "Fix: ConnectProfiles never be returned"

This reverts commit 1d77526f4dad3e322504a780770836129931796a

When prior connection fails, dev->connect was not released
Release connect resources when connection fails

// First connect
Oct 17 14:30:55 localhost bluetoothd[6459]: src/device.c:connect_profiles() /org/bluez/hci0/dev_XX_XX_XX_XX_EB_3C 0000111e-0000-1000-8000-00805f9b34fb, client :1.18
Oct 17 14:31:00 localhost bluetoothd[6459]: src/device.c:device_profile_connected() Hands-Free Audio Gateway Host is down (112)
Oct 17 14:31:00 localhost bluetoothd[6459]: src/device.c:connect_profiles() /org/bluez/hci0/dev_XX_XX_XX_XX_EB_3C 0000110b-0000-1000-8000-00805f9b34fb, client :1.18
Oct 17 14:31:01 localhost bluetoothd[6459]: src/device.c:device_profile_connected() a2dp-sink Resource temporarily unavailable (11)

// Second connect
Oct 17 14:32:10 localhost bluetoothd[6459]: src/device.c:connect_profiles() /org/bluez/hci0/dev_XX_XX_XX_XX_EB_3C 0000111e-0000-1000-8000-00805f9b34fb, client :1.18
10-17 14:32:10.327+0900 E/BLUETOOTH_FRWK_SERVICE(P 2694, T 2694): bt-service-audio.c: __bt_audio_request_cb(781) > Audio Connect/Disconnect Dbus Call Error: GDBus.Error:org.bluez.Error.InProgress: In Progress

Change-Id: I8caa4f43f51a7b302b5afc8a5028a22776d97cf5
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoFix weak point of scan filter logic 06/216206/1
Deokhyun Kim [Tue, 22 Oct 2019 08:29:20 +0000 (17:29 +0900)]
Fix weak point of scan filter logic

Change-Id: I02138cc41598cef11544ea7edf9c8d0230074a8f
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoFix : LE connection interval is not updated 35/216135/1
injun.yang [Mon, 21 Oct 2019 08:50:20 +0000 (17:50 +0900)]
Fix : LE connection interval is not updated

[Problem] If remote device use LE public address, unable to update LE connection interval
[Cause & Measure] Change the comparison logic to get object
[Checking Method] Connect BLE with LE public address > Repeat interval configuration

Change-Id: I2413e0f0c36918daba91bfb465d549c0e39532a9

4 years agoFix : LE connection interval is not updated 76/215876/1
injun.yang [Thu, 17 Oct 2019 05:23:40 +0000 (14:23 +0900)]
Fix : LE connection interval is not updated

[Problem] Unable to update LE connection interval with iPhone
[Cause & Measure] When LE connection updated callback invoked,
 bluez handle it as IDA object instead of first RPA object.
 so change the comparison logic to get RPA object
[Checking Method] Both BLE and BREDR connectd with iPhone > Repeat interval configuration

Change-Id: I87578681fc35041801e28a251a914e9bb52ff49d

4 years agoGATT Server : Handle response_needed by write request & command 61/215761/2
Deokhyun Kim [Tue, 15 Oct 2019 11:23:34 +0000 (20:23 +0900)]
GATT Server : Handle response_needed by write request & command

Change-Id: I962b9a512d9114e80ca9b5c39d62f4d76e22fce4
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoMerge "Use the systemd service for obexd" into tizen accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.004956 accepted/tizen/5.5/unified/mobile/hotfix/20201027.061849 accepted/tizen/unified/20190924.062104 submit/tizen/20190923.085748 submit/tizen_5.5/20191031.000006 submit/tizen_5.5_mobile_hotfix/20201026.185106 tizen_5.5.m2_release
Pyun DoHyun [Mon, 23 Sep 2019 08:53:52 +0000 (08:53 +0000)]
Merge "Use the systemd service for obexd" into tizen

4 years agoFix NULL pointer dereferencing issue 86/214486/1
Wootak Jung [Mon, 23 Sep 2019 08:32:09 +0000 (17:32 +0900)]
Fix NULL pointer dereferencing issue

Change-Id: I42db1cb8239519c6d796a0e83bd08c0aca5498ad

4 years agoUse the systemd service for obexd 13/214413/2
DoHyun Pyun [Mon, 23 Sep 2019 02:34:23 +0000 (11:34 +0900)]
Use the systemd service for obexd

Change-Id: I988e2e18cb168b35b5e462e0f3d80e060abd8e5b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoEnable HID device feature 52/213952/1 accepted/tizen/unified/20190918.010302 submit/tizen/20190916.233704
DoHyun Pyun [Tue, 17 Sep 2019 03:51:08 +0000 (12:51 +0900)]
Enable HID device feature

Change-Id: I5f469bb0395709eba5e730304f7fdfaa0c38d8a3
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoEmit signal for MTU changed event 53/213853/1
injun.yang [Mon, 1 Jul 2019 08:02:56 +0000 (17:02 +0900)]
Emit signal for MTU changed event

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] Unable to notice MTU changed event to application
[Cause & Measure] Send signal to detect MTU changed event on GATT server
[Checking Method] n/a

[Team] Convergence BT
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

Change-Id: Ic9446ee005211a6805a7e62791c03b410d3ff0a1
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoRestart vsc advertising after 300 ms 62/213762/1
injun.yang [Wed, 11 Sep 2019 06:02:55 +0000 (15:02 +0900)]
Restart vsc advertising after 300 ms

Change-Id: I4399f413a771a23235564d94568c92026a08b709
Signed-off-by: injun.yang <injun.yang@samsung.com>
4 years agoWhen hci event missed, send tx timeout error 77/213677/1
injun.yang [Tue, 10 Sep 2019 05:54:56 +0000 (14:54 +0900)]
When hci event missed, send tx timeout error

Change-Id: I84a677862e82aac4ad280db740d0e535b170870b
Signed-off-by: injun.yang <injun.yang@samsung.com>
4 years agoAdd adapter_send_event function 78/213278/1 accepted/tizen/unified/20190904.110702 submit/tizen/20190903.224849
Wootak Jung [Wed, 4 Sep 2019 00:26:32 +0000 (09:26 +0900)]
Add adapter_send_event function

Change-Id: If0f8c4c1e605fe415b141efeba2485d6c52efc6a

4 years agoMerge "Recover adapter when 'hci command disallowed' is responded" into tizen
Pyun DoHyun [Tue, 3 Sep 2019 04:58:51 +0000 (04:58 +0000)]
Merge "Recover adapter when 'hci command disallowed' is responded" into tizen

4 years agoRecover adapter when 'hci command disallowed' is responded 22/213222/1
Deokhyun Kim [Tue, 3 Sep 2019 04:26:58 +0000 (13:26 +0900)]
Recover adapter when 'hci command disallowed' is responded

vsc adv status of controller is abnormal while le connection & disconnection
are repeated. Recover adapter when 'hci command disallowed' is responded.

Change-Id: I1d39f3160784799ff2d7af7ded8c9ea8b7f8c579
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoUse LE pairing for the headless plugin 09/213209/1
DoHyun Pyun [Tue, 3 Sep 2019 01:39:46 +0000 (10:39 +0900)]
Use LE pairing for the headless plugin

Change-Id: Iec41908ba265bbc5eafa8b82128d4d00f63e95e6
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoNot set le_static_addr when initializing 87/212787/1 accepted/tizen/unified/20190827.110641 submit/tizen/20190827.022419
Deokhyun Kim [Tue, 27 Aug 2019 01:46:36 +0000 (10:46 +0900)]
Not set le_static_addr when initializing

Change-Id: Iebd1a33c9ffb28635336018b71cd817b2ca166d5
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoRemove OS upgrade script 98/212498/1
DoHyun Pyun [Thu, 22 Aug 2019 06:50:27 +0000 (15:50 +0900)]
Remove OS upgrade script

Since Tizen 4.0 there is no change for the file properties.
So we don't need to use the upgrade script for bluez.

Change-Id: I18b1b66a730fcbcfecfd51ade2e47de3baaefd09
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoInit le static address when adapter is enabled 37/212437/1 accepted/tizen/unified/20190822.105955 submit/tizen/20190822.022402
Deokhyun Kim [Wed, 21 Aug 2019 11:04:10 +0000 (20:04 +0900)]
Init le static address when adapter is enabled

Change-Id: I19d079c6128535c1cfc637017a1e7048e82d04a7
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoImplement interface to set advertise Tx power level 78/211078/1 accepted/tizen/unified/20190801.025409 submit/tizen/20190730.223540
injun.yang [Tue, 23 Oct 2018 00:51:21 +0000 (09:51 +0900)]
Implement interface to set advertise Tx power level

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] n/a
[Cause & Measure] Application will set advertise Tx power level
[Checking Method] n/a

[Team] Basic Connection
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

Change-Id: I8dfa4b9aa94a9f0a3e7bc71a3cf2afa48cf77095
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoApply avrcp ct connect timeout to 8 sec only for Bose speaker 58/210958/1 accepted/tizen/unified/20190729.081028 submit/tizen/20190729.004732
Deokhyun Kim [Fri, 26 Jul 2019 09:03:00 +0000 (18:03 +0900)]
Apply avrcp ct connect timeout to 8 sec only for Bose speaker

  - Race condition occurs when requesting L2CAP AVRCP connection
  Sometimes AVRCP connection request by Bose is delayed. It can conflict
  Apply avrcp ct connect timeout to 8 sec only for Bose speaker

Change-Id: Ib8ca44f61aae47b9c58af38999c6ce2959f3c6e7
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoFix the build error 11/210411/1 accepted/tizen/unified/20190719.111747 submit/tizen/20190719.013144
DoHyun Pyun [Fri, 19 Jul 2019 01:49:33 +0000 (10:49 +0900)]
Fix the build error

Change-Id: I7de706de85961109013e5e8cfa7abcea6545b22e
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoRestrict AVRCP in case A2DP is restricted 61/210361/1
Deokhyun Kim [Thu, 18 Jul 2019 08:33:02 +0000 (17:33 +0900)]
Restrict AVRCP in case A2DP is restricted

Change-Id: I39b1d0a7aebd156c23264d175a7500e1879c545c
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
4 years agoDelete meaningless configuration 03/209503/1 accepted/tizen/unified/20190715.111841 submit/tizen/20190714.235650
INSUN PYO [Mon, 8 Jul 2019 10:35:01 +0000 (19:35 +0900)]
Delete meaningless configuration

Change-Id: I4c0756152fb27edcc69bacb272cfb407b9df53c5

4 years agoRemove unused features 63/209063/1 accepted/tizen/unified/20190703.110630 submit/tizen/20190702.052010
INSUN PYO [Tue, 2 Jul 2019 05:05:40 +0000 (14:05 +0900)]
Remove unused features

Change-Id: I1e467e6e4f6cde139d5d057fd0c9da733f72ff15

4 years agoRemove unnecessary setting 07/209007/1
INSUN PYO [Tue, 2 Jul 2019 01:34:48 +0000 (10:34 +0900)]
Remove unnecessary setting

Change-Id: I49d3c7fbd7be2d455451614cf1debd1e3c23e6c7

4 years agoCancel BLE connection attempt currently in progress 05/207605/1 accepted/tizen/unified/20190611.050054 submit/tizen/20190610.063128
injun.yang [Mon, 27 May 2019 06:21:42 +0000 (15:21 +0900)]
Cancel BLE connection attempt currently in progress

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] Unable to abort BLE connection attempt
[Cause & Measure] Abort connection attempt and send "Cancelled" event to upper side
[Checking Method] Cancel BLE connection attempt

[Team] IoT Hub
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

Change-Id: I8eb1edfa33a12a39ba6abc5f3838fc73e987d0ca
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoFix : Bonding complete event is sent twice. 04/207604/1
injun.yang [Tue, 7 May 2019 04:32:44 +0000 (13:32 +0900)]
Fix : Bonding complete event is sent twice.

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] When DUT request LE pairing, bonding complete event generated twice.
[Cause & Measure] "Paired" signal emmited twice. Just send one signal
[Checking Method] Request LE pairing

[Team] IoT Hub
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

* bluetooth-frwk changes required
a29ceb772571647ec4c4b30c85f1abb034b84fed

Change-Id: I8cfa84f1d5c2ccbdbfac633cc5ab3d7e33994690
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoFix the malfunction of bonding 03/207603/1
injun.yang [Mon, 1 Apr 2019 00:27:05 +0000 (09:27 +0900)]
Fix the malfunction of bonding

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] When app request bt_device_create_bond(), host initiate BT pairing instead of BLE pairing
[Cause & Measure] Till now, bluez didn't check the link status.
 Even though BLE connected, bluez initiate BT pairing.
 To prevent the malfunction, bluez will check the link type also.
[Checking Method] Initiate pairing

[Team] IoT Hub
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

Change-Id: I5dbcc0a827ccc566b15490d3f1edc31acbac949c
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
4 years agoAdjust A2DP priority for the speaker reference board 90/206590/1 accepted/tizen/unified/20190522.085452 submit/tizen/20190522.020119
DoHyun Pyun [Wed, 22 May 2019 01:59:05 +0000 (10:59 +0900)]
Adjust A2DP priority for the speaker reference board

Change-Id: Ic059c524efd46a71267aa1b426a8327bfcb89f58
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoMerge commit 'refs/changes/82/205082/1' of ssh://review.tizen.org:29418/platform...
DoHyun Pyun [Mon, 29 Apr 2019 08:30:41 +0000 (17:30 +0900)]
Merge commit 'refs/changes/82/205082/1' of ssh://review.tizen.org:29418/platform/upstream/bluez into tizen

5 years agoUpgraded to bluez 5.50 82/205082/1
Amit Purwar [Fri, 26 Apr 2019 09:30:56 +0000 (15:00 +0530)]
Upgraded to bluez 5.50

Change-Id: I1b0a84b5993d03dd0a0e4ee16780d11130e49ea2
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoRelease 5.50 81/205081/1
Marcel Holtmann [Fri, 1 Jun 2018 08:36:21 +0000 (10:36 +0200)]
Release 5.50

Change-Id: I8c6454a39eb245de82eab22e53f569bc7f0836b2
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoFixed bluetoothd crash due to illegal access of request 80/205080/1
Amit Purwar [Fri, 26 Apr 2019 09:25:32 +0000 (14:55 +0530)]
Fixed bluetoothd crash due to illegal access of request

Change-Id: I687ae73b0faa0f1e366e72649b9a9ace5d059ad5
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agobuild: Fix issues with building dist packages 79/205079/1
Marcel Holtmann [Tue, 29 May 2018 13:32:09 +0000 (15:32 +0200)]
build: Fix issues with building dist packages

Change-Id: If61b288ffb2d12cd5c1ecb78f9a0d3a7f2045403
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoshared/btp: Change struct member order for device found as in btp 78/205078/1
Grzegorz Kolodziejczyk [Mon, 12 Feb 2018 16:01:00 +0000 (17:01 +0100)]
shared/btp: Change struct member order for device found as in btp

This patch changes member order in device found struct definition to be
compatible with btp specification.

Change-Id: I28980953fe19362254b71a42b0ec2720eeca596e
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agomgmt-tester: Add testcases for advertising while connected 77/205077/1
Łukasz Rymanowski [Mon, 12 Feb 2018 09:31:38 +0000 (10:31 +0100)]
mgmt-tester: Add testcases for advertising while connected

This patch adds testcases which verifies if Linux Kernel properly
enables advertising while is connected (LE) based on supported LE states
in the controller

Change-Id: I42e1def19ee1fcc63b621c35a1fe1ddc57431489
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agomgmt-tester: Add test_le_full 76/205076/1
Łukasz Rymanowski [Fri, 9 Feb 2018 17:26:26 +0000 (18:26 +0100)]
mgmt-tester: Add test_le_full

Change-Id: I4e36ff7f19572ede07a479929e293711c9c1989b
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotester: Enable LE Generate DHKey Complete event 75/205075/1
Tedd Ho Jeong An [Tue, 6 Feb 2018 21:03:57 +0000 (13:03 -0800)]
tester: Enable LE Generate DHKey Complete event

This patch adds LE Generate DHKey Complete event for
LE Event Mask list for 'LE Generate DHKey'.

Change-Id: Ic64ec00ef582f1d145d46eba2441e5fdb014a62d
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotester: Set event mask for LE Read Local P-256 PK Complete event 74/205074/1
Tedd Ho Jeong An [Tue, 6 Feb 2018 21:03:56 +0000 (13:03 -0800)]
tester: Set event mask for LE Read Local P-256 PK Complete event

LE Read Local P-256 PK command fails because LE Read Local P-256 PK
Complete event and LE Meta event are disabled by default.
This patch sets event masks for LE Read Local P-256 PK Complete and
LE Meta Event to receive the events for 'LE Read Local PK' test and
'LE Generate DHKey' test.

Change-Id: Ie778a43784d3a91226d9c262cedd4a300abd87cb
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoshared/btp: Use bdaddr_t for storing address 73/205073/1
Szymon Janc [Tue, 16 Jan 2018 14:02:38 +0000 (15:02 +0100)]
shared/btp: Use bdaddr_t for storing address

This is more convenient as it allows to use common helpers for address
comparison and convertion.

Change-Id: Ib94401a115f9fae11f21f7f355737489ef4ba89b
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/gatt-service: Add reference implementation for Included Service 72/205072/1
Avichal Agarwal [Tue, 20 Mar 2018 12:53:13 +0000 (18:23 +0530)]
tools/gatt-service: Add reference implementation for Included Service

Created two new primary services which will act as includes services for
first  primary service

Change-Id: Id60e1b2c240936d1186cf13b1366a7e79eec64dc
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/hcitool: Change connection handle condition for lecup 71/205071/1
Grzegorz Kolodziejczyk [Thu, 26 Apr 2018 12:31:57 +0000 (14:31 +0200)]
tools/hcitool: Change connection handle condition for lecup

According to BLUETOOTH SPECIFICATION Version 5.0 | Vol 2, Part E
7.8.18 LE Connection Update Command, connection handle range is
0x0000-0x0EFF.

Change-Id: Icbb99c777c15057a478416b0f360e9da54d57507
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools: Add initial code for btmon-logger 70/205070/1
Szymon Janc [Fri, 19 Jan 2018 15:23:20 +0000 (16:23 +0100)]
tools: Add initial code for btmon-logger

This is intended for use for automated logging or unatrended systems.
It doesn't contain any packet decoding functionality which results
in much smaller binary.

Change-Id: If61c91abab4b1ef40b276e76acc764ca28e40deb
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btmgmt: Return exit status for non-interactive 69/205069/1
ERAMOTO Masaya [Mon, 26 Mar 2018 08:31:11 +0000 (17:31 +0900)]
tools/btmgmt: Return exit status for non-interactive

Change-Id: If5aa34edd47a6405e5519bebc49a4d6814f3dfef
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: Return exit status for non-interactive 68/205068/1
ERAMOTO Masaya [Mon, 26 Mar 2018 08:31:06 +0000 (17:31 +0900)]
tools/obexctl: Return exit status for non-interactive

Change-Id: I7fa21cfaec1ce08bcac732cfd37fe9a9a368be78
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/bluetooth-player: Add item-generator for change-folder 67/205067/1
ERAMOTO Masaya [Mon, 12 Mar 2018 01:56:45 +0000 (10:56 +0900)]
tools/bluetooth-player: Add item-generator for change-folder

Change-Id: I4b0deaefa0104224a64f840319571d4cbf158302
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/bluetooth-player: Merge cmd_play{,_item}() 66/205066/1
ERAMOTO Masaya [Mon, 12 Mar 2018 01:56:12 +0000 (10:56 +0900)]
tools/bluetooth-player: Merge cmd_play{,_item}()

Change-Id: I016145a369bcfb3261c5d6beb30b69edbbdeb025
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add connect device command 65/205065/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:29 +0000 (13:41 +0100)]
tools/btpclient: Add connect device command

This patch adds support for connect device command.

Change-Id: I4249a3839ea0141a10ceba35cecc5ca621b2bc97
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add identity resolve event 64/205064/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:28 +0000 (13:41 +0100)]
tools/btpclient: Add identity resolve event

This patch adds identity resolve event handler.

Change-Id: Ib878399c46a3df3297729da76b0c92503b675472
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add solicit uuid16 service list support for ad 63/205063/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:27 +0000 (13:41 +0100)]
tools/btpclient: Add solicit uuid16 service list support for ad

This patch adds support to get/set solicit uuid16 service list in
advertising data.

Change-Id: I6088d8b4c1a1d0e926e9ade45715662dde0823b8
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Check if dev is connected in device found ev routine 62/205062/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:26 +0000 (13:41 +0100)]
tools/btpclient: Check if dev is connected in device found ev routine

Device may be connected while device found event is generated thus thus
btp should generate additional device connected event also.

Change-Id: Ifda6532b03755d24a2392e8d97d55a1a2a8358fa
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add passkey confirm event 61/205061/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:25 +0000 (13:41 +0100)]
tools/btpclient: Add passkey confirm event

This patch adds support for send passkey confirm event when requested.

Change-Id: I80af547ed278e711c5fc2040ede0a0fd13bc18bf
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add btp disconnect handler 60/205060/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:24 +0000 (13:41 +0100)]
tools/btpclient: Add btp disconnect handler

This patch adds btp disconnect handler to btp client.

Change-Id: I2f37e2914be2411c128bb6f86a50b04cfcac2ee5
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Remove btp unsupported auth request call 59/205059/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:23 +0000 (13:41 +0100)]
tools/btpclient: Remove btp unsupported auth request call

BTP don't support authorization request event.

Change-Id: I81bfbd0b03871a4802067fcc15b80dec6e282dbf
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add support for including tx-power to ad 58/205058/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:22 +0000 (13:41 +0100)]
tools/btpclient: Add support for including tx-power to ad

This patch allows to set tx-power in advertising data.

Change-Id: I6d49f5e6dc4899d2700970015d62c1f79bc7ca2a
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Fix setting supported includes includes 57/205057/1
Grzegorz Kolodziejczyk [Wed, 28 Feb 2018 12:41:21 +0000 (13:41 +0100)]
tools/btpclient: Fix setting supported includes includes

Included values should be string type instead of address of pointer to
string.

Change-Id: I011aa654ada3e2c7efed79ca6b757cf9a5c831ef
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/bluetooth-player: Fix lines going beyond 80 columns 56/205056/1
Luiz Augusto von Dentz [Thu, 1 Mar 2018 10:25:20 +0000 (12:25 +0200)]
tools/bluetooth-player: Fix lines going beyond 80 columns

Change-Id: I1e3d33673f93425666ececff44c88949bffa8292
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: mesh: Fix lines going beyond 80 columns 55/205055/1
Luiz Augusto von Dentz [Thu, 1 Mar 2018 10:23:30 +0000 (12:23 +0200)]
tools/obexctl: mesh: Fix lines going beyond 80 columns

Change-Id: I9a844beaf82aa83782776726e27356d71aee02c7
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/bluetooth-player: Use g_dbus_dict_append_entry() 54/205054/1
ERAMOTO Masaya [Thu, 1 Mar 2018 04:27:33 +0000 (13:27 +0900)]
tools/bluetooth-player: Use g_dbus_dict_append_entry()

Change-Id: Iaf97647d283bd1fd31be1749094320b03b3e0f05
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: Use g_dbus_dict_append_entry() 53/205053/1
ERAMOTO Masaya [Thu, 1 Mar 2018 04:27:29 +0000 (13:27 +0900)]
tools/obexctl: Use g_dbus_dict_append_entry()

Change-Id: I3a5631199bc151f6438735a3e5bf999e65c9c4e5
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: Quit when done with command 52/205052/1
Luiz Augusto von Dentz [Tue, 27 Feb 2018 15:44:14 +0000 (17:44 +0200)]
tools/obexctl: Quit when done with command

This ensures that the commands don't stay hanging since bt_shell no
longer quits immediatelly after executing a command.

Change-Id: I22f06ea484d35650f89575b43d34ba939d121f52
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/bluetooth-player: Quit when done with command 51/205051/1
Luiz Augusto von Dentz [Tue, 27 Feb 2018 09:30:53 +0000 (11:30 +0200)]
tools/bluetooth-player: Quit when done with command

This ensures that the commands don't stay hanging since bt_shell no
longer quits immediatelly after executing a command.

Change-Id: Ib51e65b2c4b0c7cb95b6e83070c80353a952f5c8
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: Only enable attach input when connected 50/205050/1
Luiz Augusto von Dentz [Tue, 20 Feb 2018 13:10:15 +0000 (15:10 +0200)]
tools/obexctl: Only enable attach input when connected

Change-Id: I94c4e65a1cee9507ae5d364f74b64746a75e092b
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/bluetooth-player: Only enable attach input when connected 49/205049/1
Luiz Augusto von Dentz [Tue, 20 Feb 2018 09:28:52 +0000 (11:28 +0200)]
tools/bluetooth-player: Only enable attach input when connected

Change-Id: I34996b44d520aa2f4bf0369e43a4c9230129f974
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Fix ad property manufacturer data name 48/205048/1
Grzegorz Kolodziejczyk [Mon, 12 Feb 2018 16:00:59 +0000 (17:00 +0100)]
tools/btpclient: Fix ad property manufacturer data name

This patch fixes wrong naming of advertising instance data property.

Change-Id: I77b050e95cf769d1ea521d9a93488507a210d1bf
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: Fix display of size on completion 47/205047/1
ERAMOTO Masaya [Fri, 9 Feb 2018 09:12:38 +0000 (18:12 +0900)]
tools/obexctl: Fix display of size on completion

Outputs zero as the transferred size on completion of transfer as below:

  [CHG] Transfer /org/bluez/obex/server/session3/transfer2 Transferred: 5339965 (@32KB/s 00:01)
  [CHG] Transfer /org/bluez/obex/server/session3/transfer2 Transferred: 5372726 (@32KB/s 00:00)
  [CHG] Transfer /org/bluez/obex/server/session3/transfer2 Transferred: 0 (@18446744073704178KB/s 00:00)
  [CHG] Transfer /org/bluez/obex/server/session3/transfer2 Status: complete

Change-Id: If1ea05b6126132936037860d9155e190fd87700c
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: Fix retrieving non-existent iterator 46/205046/1
ERAMOTO Masaya [Fri, 9 Feb 2018 09:12:15 +0000 (18:12 +0900)]
tools/obexctl: Fix retrieving non-existent iterator

If transfer is completed with one time file transfer,
transfer_property_changed() is called with the iter argument, which is
NULL, as below:

  #0  transfer_property_changed (proxy=<optimized out>, name=<optimized out>, iter=0x0, user_data=0x5555557b9060) at tools/obexctl.c:1896
  #1  0x000055555556e3cf in properties_changed (conn=<optimized out>, msg=<optimized out>, user_data=0x5555557c8300) at gdbus/client.c:433
  #2  0x000055555556c830 in signal_filter (connection=0x5555557c65a0, message=0x5555557ccea0, user_data=0x5555557cdbf0) at gdbus/watch.c:407
  #3  0x000055555556c291 in message_filter (connection=0x5555557c65a0, message=0x5555557ccea0, user_data=<optimized out>) at gdbus/watch.c:557
  #4  0x00007ffff7888661 in dbus_connection_dispatch () from /lib/x86_64-linux-gnu/libdbus-1.so.3
  #5  0x000055555556b010 in message_dispatch (data=0x5555557c65a0) at gdbus/mainloop.c:72
  #6  0x00007ffff7b0be25 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  #7  0x00007ffff7b0c1f0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  #8  0x00007ffff7b0c502 in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  #9  0x0000555555577594 in bt_shell_run () at src/shared/shell.c:833
  #10 0x000055555556516d in main (argc=<optimized out>, argv=<optimized out>) at tools/obexctl.c:2116

Change-Id: Ia570e8c9f140cf9795b79a9d1cc836ff174ea2c9
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add passkey confirm ev and passkey confirm rsp cmd 45/205045/1
Grzegorz Kolodziejczyk [Thu, 25 Jan 2018 15:53:33 +0000 (16:53 +0100)]
tools/btpclient: Add passkey confirm ev and passkey confirm rsp cmd

This patch adds passkey confirm command handler and passkey confirm
event.

Change-Id: I0a793a07ae0f7676e22d6870627ed4d8001a790b
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add passkey entry cmd and passkey display event 44/205044/1
Grzegorz Kolodziejczyk [Thu, 25 Jan 2018 15:53:32 +0000 (16:53 +0100)]
tools/btpclient: Add passkey entry cmd and passkey display event

This patch adds passkey entry command handler and passkey display event.

Change-Id: I646c376e81c0dfd75f9b665a5756a87c1b4d7f1f
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add pair, unpair commands 43/205043/1
Grzegorz Kolodziejczyk [Thu, 25 Jan 2018 15:53:31 +0000 (16:53 +0100)]
tools/btpclient: Add pair, unpair commands

This patch adds pair and unpair commands for btp client.

Change-Id: I04baa008741bfd6231cc95114c69c75711eb08a8
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add set io capabilities command 42/205042/1
Grzegorz Kolodziejczyk [Fri, 26 Jan 2018 10:54:02 +0000 (11:54 +0100)]
tools/btpclient: Add set io capabilities command

This patch adds support for set io capabilities command.

Change-Id: I3bb6656acb38d4833f60eb314d9d84c329b06756
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Clear advertising data on reset 41/205041/1
Grzegorz Kolodziejczyk [Thu, 25 Jan 2018 15:53:29 +0000 (16:53 +0100)]
tools/btpclient: Clear advertising data on reset

Advertising data should be cleared on gap reset command.

Change-Id: Ie54922e09a782cabe10da4742506d641bb63eead
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Restore default settings on reset 40/205040/1
Grzegorz Kolodziejczyk [Fri, 19 Jan 2018 16:41:29 +0000 (17:41 +0100)]
tools/btpclient: Restore default settings on reset

Reset command will restore default settings of adapter.

Change-Id: Ia90039f18c83be72f1e4d4f642193711d22b820b
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Initial check of ad_proxy presence in stop adv cmd 39/205039/1
Grzegorz Kolodziejczyk [Fri, 19 Jan 2018 16:41:27 +0000 (17:41 +0100)]
tools/btpclient: Initial check of ad_proxy presence in stop adv cmd

This patch covers with fail response if no advertising proxy was
registered at command beginning.

Change-Id: I6dcbf3b95e82b83c6ef782b272c924c2c9780f5d
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Fix start adv commend comment 38/205038/1
Grzegorz Kolodziejczyk [Fri, 19 Jan 2018 16:41:26 +0000 (17:41 +0100)]
tools/btpclient: Fix start adv commend comment

Comment should be aproperiate for advertising command. Device needs to
be powered to advertise.

Change-Id: I25a894da587054702ffcd00d016f11831b6919c1
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add connected, disconnected event 37/205037/1
Grzegorz Kolodziejczyk [Wed, 17 Jan 2018 10:44:11 +0000 (11:44 +0100)]
tools/btpclient: Add connected, disconnected event

This patch adds conntected, disconnected events for btp client.

Change-Id: I2700f3372433ce1fb412a37f177dd5d5bde68c38
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add connect, disconnect commands 36/205036/1
Grzegorz Kolodziejczyk [Wed, 17 Jan 2018 10:44:10 +0000 (11:44 +0100)]
tools/btpclient: Add connect, disconnect commands

This patch adds start and stop connect, disconnect commands for btp
client.

Change-Id: Ic4f3ef69664c6c9204812afc475a00e114525f11
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add start, stop advertising commands 35/205035/1
Grzegorz Kolodziejczyk [Wed, 17 Jan 2018 10:44:09 +0000 (11:44 +0100)]
tools/btpclient: Add start, stop advertising commands

This patch adds start and stop advertising commands for btp client.

Change-Id: I036d7b5dab689cfe8d79db3f1e17df15d79f0df8
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Fix setting/reseting connectable flag 34/205034/1
Grzegorz Kolodziejczyk [Fri, 12 Jan 2018 14:10:09 +0000 (15:10 +0100)]
tools/btpclient: Fix setting/reseting connectable flag

Defined setting flag is presented as mask.

Change-Id: Ib4561f41c40a1ea83ea76cb1a7ff84494eda871f
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/obexctl: Add generator for session/transfer 33/205033/1
ERAMOTO Masaya [Thu, 28 Dec 2017 05:44:23 +0000 (14:44 +0900)]
tools/obexctl: Add generator for session/transfer

Change-Id: I4c4470c84bab90759a0b1ac1199503f82c4cf5bf
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/bluetooth-player: Add generator for player/item 32/205032/1
ERAMOTO Masaya [Thu, 28 Dec 2017 05:44:20 +0000 (14:44 +0900)]
tools/bluetooth-player: Add generator for player/item

Change-Id: I7c86e9046b5d6cf63bf38eb731d6f09b2c70a779
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add set connectable command 31/205031/1
Grzegorz Kolodziejczyk [Thu, 28 Dec 2017 13:11:18 +0000 (14:11 +0100)]
tools/btpclient: Add set connectable command

This patch adds set connectable command for btp client.

Change-Id: Ibc06b6df3dfa5edfe17b2181bc76cb1677606ceb
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add start, stop discovery commands 30/205030/1
Grzegorz Kolodziejczyk [Thu, 28 Dec 2017 13:11:17 +0000 (14:11 +0100)]
tools/btpclient: Add start, stop discovery commands

This patch adds start and stop discovery command for btp client.

Change-Id: Id7740fbcf4014ff64ef0d2ea500ae8aa8080b6d1
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add device found event 29/205029/1
Grzegorz Kolodziejczyk [Thu, 28 Dec 2017 13:11:16 +0000 (14:11 +0100)]
tools/btpclient: Add device found event

This patch adds device found event handler. It's called when rssi
property of device changes and new device interface is added.

Change-Id: Iabda61beb8d68e38836135b21830318be388f64f
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Add advertising proxy to adapter 28/205028/1
Grzegorz Kolodziejczyk [Thu, 28 Dec 2017 13:11:15 +0000 (14:11 +0100)]
tools/btpclient: Add advertising proxy to adapter

Advertising manager proxy is required to handle advertise related
operations in adapter context.

Change-Id: I4e269e6e5270bd6e3061f3b5a59b280dc8b3bedb
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotools/btpclient: Move string to address conversion to helper 27/205027/1
Grzegorz Kolodziejczyk [Thu, 28 Dec 2017 13:11:14 +0000 (14:11 +0100)]
tools/btpclient: Move string to address conversion to helper

This patch makes local helper with string to address conversion.

Change-Id: I924ba5f2711d226164dd651e300d88b6db779c40
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoshared/ecc: Make ecc_make_key() a stand alone API 26/205026/1
Brian Gix [Mon, 7 May 2018 22:35:24 +0000 (15:35 -0700)]
shared/ecc: Make ecc_make_key() a stand alone API

And correct minor flaws in API descriptions

Change-Id: I0fd146cbc0c4bc0637a2c0dc894c6fed1209d30a
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agotest: Switch to Python3 25/205025/1
Krzysztof Kozlowski [Mon, 28 May 2018 11:37:08 +0000 (13:37 +0200)]
test: Switch to Python3

Python2 will be maintained till end of 2019.  Switch to Python3 by
replacing iteritems() with items() to fix error when runnig test-nap:

AttributeError: 'dbus.Dictionary' object has no attribute 'iteritems'

Change-Id: Ie810df78bbcab4c772210386643d9210d25652d1
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agogatt: Don't require prepare write authorization for trusted devices 24/205024/1
Grzegorz Kolodziejczyk [Tue, 29 May 2018 08:32:18 +0000 (10:32 +0200)]
gatt: Don't require prepare write authorization for trusted devices

This patch adds possibility to ommit prepare write authorization
request from trusted devices.

Change-Id: I3b10ec4ebe01f6f1c93bbfb43f6e79e44aa0dd79
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoclient: Don't require authorization for trusted devices 23/205023/1
Grzegorz Kolodziejczyk [Tue, 29 May 2018 08:32:17 +0000 (10:32 +0200)]
client: Don't require authorization for trusted devices

This patch adds possibility to ommit authorization request from trusted
devices.

Change-Id: Ic93b8b2c1ef4b57b9d9447a0c2581ca5c25d3566
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoshared/shell: Disable argument count check if optarg are detected 22/205022/1
Luiz Augusto von Dentz [Tue, 29 May 2018 08:26:58 +0000 (11:26 +0300)]
shared/shell: Disable argument count check if optarg are detected

Command which start with optional arguments might be using optargs
format in which case checking argument count check does not work so
this disables it which shall make things btmgmt work:

[mgmt]# add-adv --help
Usage: add-adv [options] <instance_id>
Options:
 -u, --uuid <uuid>         Service UUID
 -d, --adv-data <data>     Advertising Data bytes
 -s, --scan-rsp <data>     Scan Response Data bytes
 -t, --timeout <timeout>   Timeout in seconds
 -D, --duration <duration> Duration in seconds
 -c, --connectable         "connectable" flag
 -g, --general-discov      "general-discoverable" flag
 -l, --limited-discov      "limited-discoverable" flag
 -n, --scan-rsp-local-name "local-name" flag
 -a, --scan-rsp-appearance "appearance" flag
 -m, --managed-flags       "managed-flags" flag
 -p, --tx-power            "tx-power" flag
e.g.:
add-adv -u 180d -u 180f -d 080954657374204C45 1
[mgmt]# add-adv -u 180d -u 180f -d 080954657374204C45 1
Instance added: 1

Change-Id: I6588e8a904d669843c2da9a5c43365d16752afd7
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoclient: Add authorized property handling to characteristic attribute 21/205021/1
Grzegorz Kolodziejczyk [Mon, 28 May 2018 08:20:53 +0000 (10:20 +0200)]
client: Add authorized property handling to characteristic attribute

This patch adds handling of characteristic prepare write authorized
property to bluetoothctl.

Change-Id: Iebd336a271f02aee3c41a64aecb215257001a0d6
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoshared/gatt-server: Request authorization for prepare writes 20/205020/1
Grzegorz Kolodziejczyk [Mon, 28 May 2018 08:20:52 +0000 (10:20 +0200)]
shared/gatt-server: Request authorization for prepare writes

This patch adds gatt-server possibility to request authorization from
application if needed and previously wasn't authorized. Authorization is
requested by sending message with set prepare write authorization reqest
to client.

Change-Id: Ic1d8eca62c8df593d8f7d035451c63eb7267b889
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agodoc/gatt-api: Add authorization options for attributes 19/205019/1
Grzegorz Kolodziejczyk [Mon, 28 May 2018 08:20:51 +0000 (10:20 +0200)]
doc/gatt-api: Add authorization options for attributes

This patch adds authorization property for attributes and prepare write
request for authorization option for write request. This is require to
handle correctly prepare writes, which may response with insufficient
authorization error.

Change-Id: I11da9b9cf6982a71d66f00f1f383f71bcac1d43a
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoinput: Fix compiler error with GCC 8.0 18/205018/1
Luiz Augusto von Dentz [Mon, 28 May 2018 08:22:48 +0000 (11:22 +0300)]
input: Fix compiler error with GCC 8.0

This fixes the following error:

profiles/input/device.c: In function ‘hidp_add_connection’:
profiles/input/device.c:677:47: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size between 0 and 127 [-Werror=format-truncation=]
    snprintf(req->name, sizeof(req->name), "%s %s",
                                               ^~
         pname, sdesc);
                ~~~~~
profiles/input/device.c:677:4: note: ‘snprintf’ output between 2 and 256 bytes into a destination of size 128
    snprintf(req->name, sizeof(req->name), "%s %s",
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         pname, sdesc);

Change-Id: I36f1c408e8e30e95f81d97f5eab182cbec4c80d2
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoandroid: Fix some compilation warnings 17/205017/1
Szymon Janc [Fri, 25 May 2018 11:24:50 +0000 (13:24 +0200)]
android: Fix some compilation warnings

Change-Id: I92c2d127077f482875ea05b52e32e64163f1b2e3
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoandroid/client: Fix compilation with GCC 8 16/205016/1
Szymon Janc [Wed, 9 May 2018 12:11:13 +0000 (14:11 +0200)]
android/client: Fix compilation with GCC 8

  CC       android/client/android_haltest-if-gatt.o
android/client/if-gatt.c: In function ‘multi_adv_set_inst_data_p’:
android/client/if-gatt.c:2034:7: error: ‘set_scan_rsp’ may be used
      uninitialized in this function [-Werror=maybe-uninitialized]
  EXEC(if_gatt->client->multi_adv_set_inst_data, client_if, set_scan_rsp,
       ^~~~~~~
android/client/if-gatt.c:2034:7: error: ‘include_name’ may be used
         uninitialized in this function [-Werror=maybe-uninitialized]
android/client/if-gatt.c:2034:7: error: ‘include_txpower’ may be used
         uninitialized in this function [-Werror=maybe-uninitialized]
android/client/if-gatt.c: In function ‘set_adv_data_p’:
android/client/if-gatt.c:1859:7: error: ‘set_scan_rsp’ may be used
         uninitialized in this function [-Werror=maybe-uninitialized]
  EXEC(if_gatt->client->set_adv_data, client_if, set_scan_rsp,
       ^~~~~~~
android/client/if-gatt.c:1859:7: error: ‘include_name’ may be used
         uninitialized in this function [-Werror=maybe-uninitialized]
android/client/if-gatt.c:1859:7: error: ‘include_txpower’ may be used
         uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:6431: android/client/android_haltest-if-gatt.o] Error 1
make: *** [Makefile:3262: all] Error 2

Change-Id: Ic77375ee4c8bd608ede860dad5cc6b763d62d1c4
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agomonitor: Add command line option to disable pager support 15/205015/1
Marcel Holtmann [Thu, 24 May 2018 14:29:50 +0000 (16:29 +0200)]
monitor: Add command line option to disable pager support

Change-Id: I9d720e2947c4f65a85e5b2c9346cd879f19d7f10
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>