platform/upstream/at-spi2-core.git
2 months agoChange log level to prevent abort. 78/305678/1 accepted/tizen_unified accepted/tizen_unified_toolchain accepted/tizen_unified_x accepted/tizen/unified/20240219.160449 accepted/tizen/unified/toolchain/20240311.065925 accepted/tizen/unified/x/20240220.150030
Hosang Kim [Mon, 5 Feb 2024 09:47:16 +0000 (18:47 +0900)]
Change log level to prevent abort.

Use g_warning instead of g_error to prevent abort.

Change-Id: I52214ca6272a2f85fdbcf9e290a1604aed74c469
(cherry picked from commit 5c2763058559778440d1f2dfb78849aec57ef5ad)

2 months agoDelaying launch of screen-reader until bus name is acquired 29/305629/1 accepted/tizen/unified/20240206.161748 accepted/tizen/unified/x/20240207.075822
Lukasz Oleksak [Mon, 5 Feb 2024 12:36:46 +0000 (13:36 +0100)]
Delaying launch of screen-reader until bus name is acquired

Change-Id: Ib26202dedad5121ef29d4c1d85426f02f619ea69

2 months agoAdd -fno-omit-frame-pointer 19/304619/3 accepted/tizen/unified/20240124.163224 accepted/tizen/unified/x/20240205.064029
Artur Świgoń [Mon, 22 Jan 2024 09:39:10 +0000 (10:39 +0100)]
Add -fno-omit-frame-pointer

This option has a negligible performance impact but it gives an
opportunity to produce more meaningful stacktraces.

Change-Id: I7912367b24f34dcb01841379c40e48208c2c8327

3 months agoMerge "[TIZEN] Introduce atspi_collection_get_matches_in_matches API." into tizen
kim hosang [Mon, 15 Jan 2024 06:05:11 +0000 (06:05 +0000)]
Merge "[TIZEN] Introduce atspi_collection_get_matches_in_matches API." into tizen

3 months agoMerge "Introduce new API to get node infomation to be used in aurum side" into tizen
woochan lee [Tue, 9 Jan 2024 01:14:55 +0000 (01:14 +0000)]
Merge "Introduce new API to get node infomation to be used in aurum side" into tizen

3 months agoIncrease timeout for first dbus call 26/303626/2 accepted/tizen_unified_riscv accepted/tizen/unified/20240108.163424 accepted/tizen/unified/riscv/20240109.034838
Lukasz Oleksak [Tue, 2 Jan 2024 14:07:59 +0000 (15:07 +0100)]
Increase timeout for first dbus call

This is required to avoid crashes of AT-clients that are started before
DBUS is ready.

Change-Id: I9bef98184ee032b12249f711a1679aab4bc7bd1c

3 months agoIntroduce new API to get node infomation to be used in aurum side 84/301184/6
Woochan Lee [Fri, 10 Nov 2023 05:36:40 +0000 (14:36 +0900)]
Introduce new API to get node infomation to be used in aurum side

It can improve aurum performance.

Change-Id: I6a45794424a3dfb919b3d8405a216e321b6b4657

4 months ago[TIZEN] Introduce atspi_collection_get_matches_in_matches API. 11/302111/4
Hosang Kim [Thu, 30 Nov 2023 09:57:27 +0000 (18:57 +0900)]
[TIZEN] Introduce atspi_collection_get_matches_in_matches API.

The atspi_collection_get_matches_in_matches API retrieves all accessible objects within an AtspiCollection that match two sets of match rules.
This function takes in an AtspiCollection, two AtspiMatchRule pointers, a sorting order, and counts for each match rule.
It returns a GArray of AtspiAccessible pointers that match both rules.

This API can be used to efficiently retrieve specific subsets of accessible objects within a collection based on their properties.i
For example, you could use this API to find all buttons within a dialog box that have the word "OK" in their label.

Change-Id: Ia3c216e0800a32471b4a5251f33c8c6a7eda31aa

6 months agoProtecting against potential NULL pointer dereference 98/299098/1 accepted/tizen/8.0/unified/20231005.094628 accepted/tizen/unified/20230920.161446 tizen_8.0_m2_release
Lukasz Oleksak [Tue, 19 Sep 2023 15:37:41 +0000 (17:37 +0200)]
Protecting against potential NULL pointer dereference

Change-Id: I8cbe744fcbf440d13afe99fe8406e60bfaa6daf6

10 months agoAdd routine for releasing memory allocated to reading material structure 39/293439/3 accepted/tizen/unified/20230703.093328
Lukasz Oleksak [Fri, 26 May 2023 12:06:15 +0000 (14:06 +0200)]
Add routine for releasing memory allocated to reading material structure

This patch moves memory releasing routine from screen-reader to at-spi2-core
in order to make it available for other AT-clients that would like to use
reading material protocol.

Also new field "self" has been added to reading material structure.

Change-Id: Ic10e2d795f9f9c5dbe3cd8098d8b18965add443e

11 months agoImprove code safety 10/291710/1 accepted/tizen/unified/20230421.103346
Lukasz Oleksak [Thu, 20 Apr 2023 12:27:39 +0000 (14:27 +0200)]
Improve code safety

Change-Id: Ic8b3a449a70075d6c8778f0d2498599c1b3d3ebb

12 months agoAdd value_text to AtspiAccessibleReadingMaterial 74/291274/1
Artur Świgoń [Wed, 12 Apr 2023 13:15:26 +0000 (15:15 +0200)]
Add value_text to AtspiAccessibleReadingMaterial

This field contains the value of the org.a11y.atspi.Value.Text property.

Change-Id: I1bbcb2b391473078e8a14daf992f4d39dce79f05

12 months agoBackport atspi_value_get_text() from 2.46 66/291266/1
Artur Świgoń [Wed, 12 Apr 2023 10:21:50 +0000 (12:21 +0200)]
Backport atspi_value_get_text() from 2.46

This API provides a string value from the Value interface, customizable by the
application, which can be read as-is by the ScreenReader.

Change-Id: I054cc7253deac9d6ca9629fc2e813f7a5af24709

12 months agoRevert "[Tizen] Avoid cache-related code when atspi_no_cache flag on" 43/290343/1 accepted/tizen/unified/20230327.143732 accepted/tizen/unified/20230329.013245
Woochan Lee [Thu, 23 Mar 2023 09:16:50 +0000 (18:16 +0900)]
Revert "[Tizen] Avoid cache-related code when atspi_no_cache flag on"

This reverts commit ae24eb55b47e52da0ef9b60ec30efeafd41918af.

Change-Id: I7258c17706cf3c673c6423348d46095a632db929

13 months ago[Tizen] Avoid cache-related code when atspi_no_cache flag on 02/290002/1 accepted/tizen/unified/20230321.123155
Woochan Lee [Fri, 17 Mar 2023 03:25:43 +0000 (12:25 +0900)]
[Tizen] Avoid cache-related code when atspi_no_cache flag on

atspi_state_set_contains() is a performance degradation factor for client
that don't need cache.

Change-Id: I9110f7e5916241635a03be80c4568fb6d55c0eb3

13 months ago[Tizen] Introduce atspi_accessible_get_children API 23/289923/1
Woochan Lee [Wed, 15 Mar 2023 11:22:56 +0000 (20:22 +0900)]
[Tizen] Introduce atspi_accessible_get_children API

We called child count and child at index API to get child list.
It will helps to reduce dbus method call count and usage also better.

Change-Id: Iabd81f3988da0beb9ffcf224584f205489946872

13 months agoat-spi-bus-launcher: Added checking return value when creating directory 46/289846/4
Maria Bialota [Tue, 14 Mar 2023 15:20:38 +0000 (16:20 +0100)]
at-spi-bus-launcher: Added checking return value when creating directory

Change-Id: I44aa5995488a466a5610887bfa2067ed1b739538

13 months agoat-spi-bus-launcher: fixed memory leak 42/289842/2
Maria Bialota [Tue, 14 Mar 2023 14:04:05 +0000 (15:04 +0100)]
at-spi-bus-launcher: fixed memory leak

Change-Id: Ieb4985780a21f4608f11d1e8e51aef1c401b1637

13 months ago[Tizen] Fix build warning. 44/289544/2 accepted/tizen/unified/20230313.022910
Woochan Lee [Thu, 9 Mar 2023 10:12:37 +0000 (19:12 +0900)]
[Tizen] Fix build warning.

Change-Id: Ia163d957c06b715295c22423975fc2a9f0f95649

13 months agoMerge "[Tizen] Provide SetListenPostRender interface" into tizen
Chun [Wed, 8 Mar 2023 05:40:04 +0000 (05:40 +0000)]
Merge "[Tizen] Provide SetListenPostRender interface" into tizen

13 months ago[Tizen] Provide SetListenPostRender interface 58/288458/5 accepted/tizen/unified/20230310.062657
Woochan Lee [Fri, 17 Feb 2023 00:42:49 +0000 (09:42 +0900)]
[Tizen] Provide SetListenPostRender interface

Asks the UI Toolkit listen for post render callback to get post render event in client.

Change-Id: Ie2b95ff4f02888b1266fb621c3990565f3f69bf8

13 months agoNull-check dbus_message_get_path() result 10/288910/1 accepted/tizen/unified/20230227.152731 submit/tizen/20230227.091855
Artur Świgoń [Fri, 24 Feb 2023 08:49:55 +0000 (09:49 +0100)]
Null-check dbus_message_get_path() result

Change-Id: I0abcb6981030269af20b796e4cf68bec055328c7

13 months agoFix merging errors 09/288909/1
Artur Świgoń [Fri, 24 Feb 2023 08:49:14 +0000 (09:49 +0100)]
Fix merging errors

Change-Id: Ib0534823627f61af248909a8bb47ace6d4ee38a3

13 months agoMerge tag 'upstream/2.44.1' into tizen 41/288841/2 accepted/tizen/unified/20230227.042017
Artur Świgoń [Thu, 23 Feb 2023 09:33:38 +0000 (10:33 +0100)]
Merge tag 'upstream/2.44.1' into tizen

Change-Id: Idae0426a3de841cc09b454c20a0231d762bdfd20

13 months ago2.44.1 18/288818/1 upstream/2.44.1
Artur Świgoń [Thu, 23 Feb 2023 09:16:54 +0000 (10:16 +0100)]
2.44.1

Change-Id: Id40e27e0a19f1d06e4bd8ce9fa68e433bfb53a11

21 months agoDo not return intermediate results 99/277499/2 accepted/tizen/unified/20230220.174440
Lukasz Oleksak [Thu, 7 Jul 2022 19:00:49 +0000 (21:00 +0200)]
Do not return intermediate results

Intermediate result is a non-navigable Proxy object that is used only to
continue searching of UI element in embeded GUIs. It should never be returned
as a final result of search.

Change-Id: I1c8962154e8955526074f37f32039100b68ea363

21 months agoMerge "registryd: handle 'showing' window" into tizen accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.060546 accepted/tizen/7.0/unified/hotfix/20221116.110615 accepted/tizen/unified/20220622.134035 submit/tizen/20220621.022714 tizen_7.0_m2_release
Shinwoo Kim [Tue, 21 Jun 2022 00:40:15 +0000 (00:40 +0000)]
Merge "registryd: handle 'showing' window" into tizen

21 months agoIncreasing cache maximum size to handle complex UIs 91/276491/1
Lukasz Oleksak [Fri, 17 Jun 2022 09:11:42 +0000 (11:11 +0200)]
Increasing cache maximum size to handle complex UIs

Change-Id: I5a9072894df80214532c9521d0f30aa454d0a239

22 months agoregistryd: handle 'showing' window 50/275450/1
Shinwoo Kim [Wed, 25 May 2022 04:47:14 +0000 (13:47 +0900)]
registryd: handle 'showing' window

For multi-window case and multi-AT-client case, registryd keep the
information about 'showing' window.

This patch works well with following related patch:
https://review.tizen.org/gerrit/#/c/platform/core/accessibility/screen-reader/+/275382/
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/275412/

Change-Id: I39a7094c6745d5b83b480a589322b0bc35b9191e

22 months agoFix memory leak 00/275300/1 accepted/tizen/unified/20220524.050443 submit/tizen/20220520.094924
Shinwoo Kim [Fri, 20 May 2022 07:05:10 +0000 (16:05 +0900)]
Fix memory leak

This patch is removing memory leak detected by analysis tool.

Change-Id: I473e2a6d20b92a9e28300ed758e9bd3508b78fcb

23 months ago[Tizen] Provide GetForegroundWindows interface 44/274044/9 submit/tizen/20220520.004100
Shinwoo Kim [Wed, 20 Apr 2022 08:22:12 +0000 (17:22 +0900)]
[Tizen] Provide GetForegroundWindows interface

This interface will work for selecting a window on x,y position.
It will be needed in multi-window environment.

Change-Id: Idc86f360de0d43c867dddec5f958a26aa2693c08

2 years agoFix meson 0.60.3 errors 29/271429/3 accepted/tizen/unified/20220221.102011 submit/tizen/20220221.101853
Artur Świgoń [Mon, 21 Feb 2022 09:34:35 +0000 (10:34 +0100)]
Fix meson 0.60.3 errors

Change-Id: I74be6c48e1dd6a5120a506109a7b6849793d20ae

2 years agoMerge tag 'upstream/2.42.0' into tizen 09/270509/1 accepted/tizen/unified/20220212.064819 submit/tizen/20220211.003138
Artur Świgoń [Thu, 3 Feb 2022 17:06:03 +0000 (18:06 +0100)]
Merge tag 'upstream/2.42.0' into tizen

Change-Id: I87038728bc8e0c601919628524be8f7e0bba6c08

2 years ago2.42.0 02/270402/1 upstream/2.42.0
Artur Świgoń [Tue, 1 Feb 2022 10:01:46 +0000 (11:01 +0100)]
2.42.0

Change-Id: Ie3cf2615d77cd923b22e9f6c9a7233fe8682f95a

2 years ago[Tizen] Provide GetActiveWindow interface 13/267313/9 accepted/tizen/unified/20211228.140402 submit/tizen/20211227.065503
Shinwoo Kim [Wed, 1 Dec 2021 08:36:19 +0000 (17:36 +0900)]
[Tizen] Provide GetActiveWindow interface

If there are two AT clients, AT server does not send 'activate' signal
for the second AT client. Because AT server send the 'activate' signal
when the 'IsEnabled' status was set to be TRUE.

AT client is able to search the 'activate' window using the desktop and
its children - applications, but some times it is very slow. Probably..
It is caused by 'throttle' feature of EFL application.

We need to keep the 'activate' window information for the second client.
The at-spi2-registryd will keep the 'activate' window information.
The AT client gets the information using atspi_get_activate_window.

Change-Id: Ia5f22465b10a46411768866f245aa8309b2cc013

2 years agotest: remove warning message 26/262326/1 accepted/tizen_6.5_unified tizen_6.5 accepted/tizen/6.5/unified/20211028.223505 accepted/tizen/unified/20210816.122905 submit/tizen/20210809.014518 submit/tizen_6.5/20211028.163301 tizen_6.5.m2_release
Shinwoo Kim [Fri, 6 Aug 2021 10:29:28 +0000 (19:29 +0900)]
test: remove warning message

This change is removing following message.

 GLib-CRITICAL: g_atomic_ref_count_dec:
  assertion 'g_atomic_int_get (arc) > 0' failed

It seems that the variant is removed in g_dbus_proxy_call_sync.

Change-Id: Ibf1c5990f32a7290aa40fbbdc413c29bb125f11e

3 years agoRemoving formatted printing of accessible object path by at_spi2_tool 51/256751/2 accepted/tizen/unified/20210607.124341 submit/tizen/20210514.080747 submit/tizen/20210601.084003 submit/tizen/20210607.013021
Lukasz Oleksak [Mon, 12 Apr 2021 08:37:07 +0000 (10:37 +0200)]
Removing formatted printing of accessible object path by at_spi2_tool

Format of accessible object path (handle) may vary in different toolkits
so hardcoded formatting "%llu" cannot be used. Additionaly, the information
is redundant as unformatted (raw) object path is already printed as the
last section (after last ":") of object unique id.

Change-Id: Idedbea550e759335a10141adf4873a37737dde12

3 years agoRemoved unused unref from _atspi_dbus_get_property 18/254818/2 accepted/tizen/unified/20210323.122738 submit/tizen/20210323.004021
Bartlomiej Grzelewski [Mon, 8 Mar 2021 09:20:39 +0000 (10:20 +0100)]
Removed unused unref from _atspi_dbus_get_property

Newest at-spi2-core does not contain path that is passing
pointer to accessiblity object as "data" paramter.

There is no point in releasing data under this pointer.

Change-Id: I729db3a0aaef274657121084affb33a69fd8c02d

3 years agoAtspiDeviceListenerCB: remove const from event prototype 17/254817/1
Mike Gorse [Tue, 23 Feb 2021 16:12:15 +0000 (10:12 -0600)]
AtspiDeviceListenerCB: remove const from event prototype

The parameter is marked with (transfer full), and the code expects the caller
to free the event, so adjust the prototype to clarify the expected behavior.
Also fix a related memory leak in atspi-device-legacy.c.

Fixes #31

Change-Id: I268c80df3f251ca99456827a878e78f191a18736

3 years agoRemove debug print 16/254816/1
Mike Gorse [Mon, 22 Feb 2021 21:55:11 +0000 (15:55 -0600)]
Remove debug print

Change-Id: I1f71997aaf68f2eab803827971ffc4f2d7332657

3 years agoatspi_accessible_get_(name|description): fix memory leak 15/254815/1
Mike Gorse [Mon, 22 Feb 2021 21:53:35 +0000 (15:53 -0600)]
atspi_accessible_get_(name|description): fix memory leak

This is likely what the backed-out part of !53 was trying to do.

Change-Id: Id6f8bc3eb34caaa8df8a8734a60ce24d7f64aa9f

3 years agoVersion 2.39.90.1 34/254634/1
Bartlomiej Grzelewski [Thu, 4 Mar 2021 11:26:54 +0000 (12:26 +0100)]
Version 2.39.90.1

Change-Id: I862adfd66284175a3696f90a7c669845735dd238

3 years agoMerge branch 'upstream' into tizen 54/254554/2
Bartlomiej Grzelewski [Thu, 4 Mar 2021 09:55:38 +0000 (10:55 +0100)]
Merge branch 'upstream' into tizen

Change-Id: I729b65879ba90b87ac04e71ab775656c0168868b

3 years ago2.39.90.1 53/254553/1 upstream/2.39.90
Bartlomiej Grzelewski [Thu, 4 Mar 2021 09:43:37 +0000 (10:43 +0100)]
2.39.90.1

Change-Id: I3d30aea2ebdc1e9ff5d24b564c2977d798f285d6

3 years agoPrevent passing null to g_hash_table_unref 54/246954/1 accepted/tizen/unified/20201116.220348 submit/tizen/20201108.215920 submit/tizen/20201115.212153
Bartlomiej Grzelewski [Thu, 5 Nov 2020 09:39:36 +0000 (10:39 +0100)]
Prevent passing null to g_hash_table_unref

This commit removes annoying message from glib2:

"GLib-CRITICAL g_hash_table_unref: assertion 'hash_table != NULL'
failed"

Change-Id: Idf9eaaebc03f0b0fe8c6275c625d902e3361343a

3 years agoFix invalid memory access 59/245959/2 accepted/tizen/unified/20201028.123905 submit/tizen/20201027.091012
Bartlomiej Grzelewski [Tue, 20 Oct 2020 13:28:42 +0000 (15:28 +0200)]
Fix invalid memory access

Change-Id: I36ca4b0ac8772ba9b7e34d60449971e0b681ceda

3 years agomisc: unref bus at the end of cleanup 29/245929/1 submit/tizen/20201020.112528
Shinwoo Kim [Mon, 19 Oct 2020 05:21:29 +0000 (14:21 +0900)]
misc: unref bus at the end of cleanup

The g_object_run_dispose needs bus as below.

  g_object_run_dispose > atspi_application_dispose > _atspi_bus

So close, unref and set bus to NULL after using bus is done.

Change-Id: Idc68f7f0be02119617371efa023e7ef5b4dbb0f5

3 years agoAPI for comparing AtspiAccessible objects by unique_id 67/245767/8
Lukasz Oleksak [Thu, 15 Oct 2020 11:21:59 +0000 (13:21 +0200)]
API for comparing AtspiAccessible objects by unique_id

Change-Id: I925a9761013ac6656b1e09ac91cd79397b8b042f

3 years agoFix memory leak, handle hash table size 58/245558/7
Shinwoo Kim [Mon, 12 Oct 2020 09:17:29 +0000 (18:17 +0900)]
Fix memory leak, handle hash table size

(1) Fix memory leak of atspi_accessible_get_reading_material.
(2) Remove defunct accessible from application hash table.
  In case of chromium-efl, it emits lots of "defunct" events without
  "RemoveAccessible", and this makes application hash table too big
  which could cause a Memory Alert on TV product.
(3) If AT-server does not emit "RemoveAccessible", then there is not
  a chance to remove accessible from the application hash table. And
  then the memory usage of AT-client grows bigger and bigger. So this
  patch is using newly defined value HASH_TABLE_SIZE_MAX.

Change-Id: If60d1fa1714d8bbf73b48cf16b1e1274f5a30cb9

3 years agofix memory leak in atspi_accessible_get_default_label_info 74/245574/8
Lukasz Oleksak [Mon, 12 Oct 2020 11:03:07 +0000 (13:03 +0200)]
fix memory leak in atspi_accessible_get_default_label_info

Change-Id: I8e6094e96381fbf276556c04a1f87e0cb656d1b3

3 years agoFix memory leak 67/245867/2 submit/tizen/20201018.221456
Bartlomiej Grzelewski [Tue, 6 Oct 2020 08:30:59 +0000 (10:30 +0200)]
Fix memory leak

* Release memory before pointer overwrite.
* Free memory before overwrite pointer.
* Memory leak with ref_accessible.
* Leak in atspi_state_type_get_type.
* Remove memory leak in
  atspi_event_listener_register_from_callback_full.
* Reduce memory leaks reported on program exit.
* This api is unused by efl but still let's fix it.

Change-Id: Ifde65dd44643f2e58442cf70809703f979436e09

3 years agoAdded printing toolkit name to at_spi2_tool 17/235017/1 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.104449 accepted/tizen/6.0/unified/hotfix/20201103.000427 accepted/tizen/unified/20200608.214806 submit/tizen/20200608.010949 submit/tizen_6.0/20201029.205501 submit/tizen_6.0_hotfix/20201102.192901 submit/tizen_6.0_hotfix/20201103.115101 tizen_6.0.m2_release
Maria Bialota [Tue, 26 May 2020 16:11:38 +0000 (18:11 +0200)]
Added printing toolkit name to at_spi2_tool

Change-Id: Ia8ab65788ff932a9371dfdf8a941693b2ac8b552

3 years agoAdded printing supported actions to at_spi2_tool 00/234900/7
Maria Bialota [Tue, 26 May 2020 16:11:38 +0000 (18:11 +0200)]
Added printing supported actions to at_spi2_tool

Change-Id: I15ba50fb0b06990d314a1f8ad554baf909c2312b

3 years agospec: update license from LGPL-2.0+ to LGPL-2.1+ 59/232059/1 accepted/tizen/unified/20200510.220355 submit/tizen/20200505.220303 submit/tizen/20200506.062648 submit/tizen/20200506.224620 submit/tizen/20200507.060934 submit/tizen/20200507.214726 submit/tizen/20200508.001045
Jongmin Lee [Tue, 28 Apr 2020 04:09:55 +0000 (13:09 +0900)]
spec: update license from LGPL-2.0+ to LGPL-2.1+

Change-Id: If2866311d3282b9036c14459934d496a0ba9c7f9

4 years agoFix memory management issues 90/224990/3 accepted/tizen/unified/20200221.093534 submit/tizen/20200217.221032 submit/tizen/20200218.214546 submit/tizen/20200219.213751 submit/tizen/20200220.222107
Artur Świgoń [Fri, 14 Feb 2020 11:12:04 +0000 (12:12 +0100)]
Fix memory management issues

atspi/atspi-mutter.c

Dynamic memory referenced by 'name' was allocated at
atspi-accessible.c:307 by calling function 'atspi_accessible_get_name'
at atspi-mutter.c:398 and lost at atspi-mutter.c:401.

Pointer '&data.rd_session_path[0]' returned from function 'g_strdup' at
atspi-mutter.c:82 may be null, and it is dereferenced at
atspi-mutter.c:83.

atspi/atspi-event-listener.c

Return value of a function '_atspi_dbus_return_accessible_from_iter' is
dereferenced at atspi-event-listener.c:1094 without checking, but it is
usually checked for this function (5/6).

Change-Id: Ie311948f4d8f71025d0b1769a97e2904ee4af387

4 years agoFix upstream in .gbs.conf 81/224981/2
Artur Świgoń [Fri, 14 Feb 2020 10:28:41 +0000 (11:28 +0100)]
Fix upstream in .gbs.conf

Change-Id: Ia07c670b92bffc0e0d3ba0f7630ce8b88f5db8f1

4 years agoatspi-misc: Prevent memory leak of main_loop pointer 65/224965/1
JunsuChoi [Fri, 14 Feb 2020 08:24:14 +0000 (17:24 +0900)]
atspi-misc: Prevent memory leak of main_loop pointer

atspi_main_loop is generated with g_main_loop_new
The loop ends and a memory leak occurs.
Call unref on atspi_main_loop to prevent leaks.

Change-Id: If8158f0113bf3eb31ff7b2558c835a92219a40d2

4 years agoMerge tag 'upstream/2.34.0' into tizen 02/224302/2 submit/tizen/20200213.221652
Artur Świgoń [Fri, 7 Feb 2020 13:01:49 +0000 (14:01 +0100)]
Merge tag 'upstream/2.34.0' into tizen

Change-Id: I480c8e572f5fe7d3d7d2d6f1f0aa2a76f009c9a8

4 years ago2.34.0 73/224273/1 upstream/2.34.0
Artur Świgoń [Fri, 7 Feb 2020 06:35:42 +0000 (07:35 +0100)]
2.34.0

Change-Id: I514111ff14f955ae7cc405bf8ff6298d7e982175

4 years agoApply systemd-based dbus activation 77/216677/1 accepted/tizen/unified/20191114.123442 submit/tizen/20191111.211104 submit/tizen/20191113.212006 submit/tizen/20191113.212830
Maria Bialota [Wed, 30 Oct 2019 14:49:41 +0000 (15:49 +0100)]
Apply systemd-based dbus activation

Change-Id: I3ccf53942b6c49fbe656e2e4387cc681809c2c98

4 years agoResolve the possible use of negative value (detected by coverity tool) 49/215349/1 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix tizen_5.5_tv accepted/tizen/5.5/unified/20191031.010026 accepted/tizen/5.5/unified/mobile/hotfix/20201027.063207 accepted/tizen/unified/20191009.231729 accepted/tizen/unified/20191011.015423 submit/tizen/20191007.211537 submit/tizen/20191008.054628 submit/tizen/20191009.211935 submit/tizen_5.5/20191031.000006 submit/tizen_5.5_mobile_hotfix/20201026.185106 tizen_5.5.m2_release
Jongmin Lee [Mon, 7 Oct 2019 08:36:29 +0000 (17:36 +0900)]
Resolve the possible use of negative value (detected by coverity tool)

Change-Id: Ibb68f024ef14a0beb10d2bc63ff28fe03d55762f

4 years agoMerge "Revert "tizen: Add additional unit for "unified" user session"" into tizen accepted/tizen/unified/20190905.232214 submit/tizen/20190828.061756 submit/tizen/20190829.043227 submit/tizen/20190829.094028 submit/tizen/20190830.023608 submit/tizen/20190830.034707 submit/tizen/20190905.064609
Jongmin Lee [Thu, 22 Aug 2019 21:27:46 +0000 (21:27 +0000)]
Merge "Revert "tizen: Add additional unit for "unified" user session"" into tizen

4 years agofix for potential resource leak 45/212245/2
Radoslaw Cybulski [Mon, 19 Aug 2019 08:06:58 +0000 (10:06 +0200)]
fix for potential resource leak

fix for potential memory leak, where pointer memory allocated and
stored in a11y_bus_address property could be overwritten
without releasing.

Change-Id: I0835ec807c96192cc011374b81e2eb14bc910c58

4 years agoRevert "tizen: Add additional unit for "unified" user session" 02/212302/1
Yunmi Ha [Tue, 20 Aug 2019 07:19:22 +0000 (07:19 +0000)]
Revert "tizen: Add additional unit for "unified" user session"

This reverts commit c64ea0f61a0842c7b71c3ccb9018fd9dce088164.

We've optimized systemd-user without unified system/session.
So, we revert the patch for unified system/session.

Change-Id: I4790604bf3b41c484aef3ffd029719f04a92fbce

4 years agoMerge "at_spi2_tool is now in path'ed directory" into tizen accepted/tizen/unified/20190603.095321 accepted/tizen/unified/20190604.014643 submit/tizen/20190530.111225 submit/tizen/20190531.122943 submit/tizen/20190603.083549
Lukasz Oleksak [Tue, 21 May 2019 13:02:31 +0000 (13:02 +0000)]
Merge "at_spi2_tool is now in path'ed directory" into tizen

4 years agoat_spi2_tool is now in path'ed directory 79/206579/1
Radoslaw Cybulski [Tue, 21 May 2019 10:43:14 +0000 (12:43 +0200)]
at_spi2_tool is now in path'ed directory

Change-Id: Iee3957bc7259622191e09b2f06e6d2262e67faf5

4 years agoFix meson build error 18/205518/1 accepted/tizen/unified/20190507.221734 submit/tizen/20190507.071707
YoungGun Chun [Tue, 7 May 2019 05:53:00 +0000 (14:53 +0900)]
Fix meson build error

Change-Id: If9f9fcbd94c9f562d239d4b134f97bfb3a4ea705

4 years agoMerge "tizen: Add additional unit for "unified" user session" into tizen
Jongmin Lee [Thu, 2 May 2019 06:43:03 +0000 (06:43 +0000)]
Merge "tizen: Add additional unit for "unified" user session" into tizen

4 years agotizen: Add additional unit for "unified" user session 28/204128/1
Mateusz Moscicki [Fri, 19 Apr 2019 08:51:11 +0000 (10:51 +0200)]
tizen: Add additional unit for "unified" user session

The unified user session is about moving user session units, managed by
systemd --user, to main systemd, where it's managed as part of newly
created user@.target.

user@.target will contain same units as previously available in user/,
with same UID and environment setup.  systemd instance is used for unit
to be able to specify UID (inherited from user@.target).

The rationale behind this work is following:

* VD requirement to remove user session support
* boot time optimization requirements, due to:

   + 'systemd --user' taking 1s its own startup that could be used for
     unit startup
   + ability to better rearrange units if these managed by one systemd
     instance

Unit installed by this commit will not be used till user login mechanism
will be changed in systemd package (via changing pam_systemd to start
user@.target, rather than user@.service).

Change-Id: I232c8be6cc6fce07ae694d5b0ac2f08d8b98c3a0

4 years agoFixes SVACE issue with thread-unsafe calls to strerror 09/204009/3 accepted/tizen/unified/20190425.014541 submit/tizen/20190424.060632 submit/tizen/20190424.080239
Radoslaw Cybulski [Thu, 18 Apr 2019 10:26:46 +0000 (12:26 +0200)]
Fixes SVACE issue with thread-unsafe calls to strerror

Calls to strerror were replaced with calls to strerror_r, which
is thread-safe.

Change-Id: I6ee4908672118248b96590f375005ee424daea85

5 years agoFix for missing -fPIE build flag 52/202452/2 accepted/tizen/unified/20190404.022012 submit/tizen/20190402.051338 submit/tizen/20190402.080200 submit/tizen/20190403.050239 submit/tizen/20190403.055426 submit/tizen/20190403.063646
Radoslaw Cybulski [Thu, 28 Mar 2019 13:02:03 +0000 (14:02 +0100)]
Fix for missing -fPIE build flag

Adds -fPIE build flag to meson, which is required, because not ASLR
binaries won't be allowed to run on target.

Change-Id: I1f725eb4c7f39a32c43dd104255b16b0628d7a38

5 years agoFix for invalid at-spi configuration 08/200808/2 accepted/tizen/unified/20190327.160535 submit/tizen/20190311.042353 submit/tizen/20190311.104527 submit/tizen/20190314.062257 submit/tizen/20190314.080413 submit/tizen/20190314.103410 submit/tizen/20190318.043555 submit/tizen/20190318.114709 submit/tizen/20190319.041006 submit/tizen/20190327.041330
Radoslaw Cybulski [Mon, 4 Mar 2019 12:09:32 +0000 (13:09 +0100)]
Fix for invalid at-spi configuration

Fixes not working configuration (dbus-daemon binary not found), which
caused at-spi2-bus-launcher not to start.
Fixes crash due to missing schema for GSetting.

Change-Id: I5f1692144b4c7487f33739832780224707be001c

5 years agoresolve build error in aarch64 and x86_64 55/199655/1 accepted/tizen/unified/20190218.063851 submit/tizen/20190215.002439
Jongmin Lee [Wed, 13 Feb 2019 23:42:07 +0000 (08:42 +0900)]
resolve build error in aarch64 and x86_64

Change-Id: I7cb193c626a19a818ed0c232d3cc788866679c82

5 years agoMerge upstream branch 2.31.1 into branch origin/tizen 19/199119/6 submit/tizen/20190213.001307 submit/tizen/20190213.060634
Radoslaw Cybulski [Fri, 1 Feb 2019 11:48:14 +0000 (12:48 +0100)]
Merge upstream branch 2.31.1 into branch origin/tizen

Change-Id: I02fb778191626e1445e40c4477fc17f79ce2fcd0

5 years ago2.31.1 87/198387/2 upstream/2.31.1
Radoslaw Cybulski [Wed, 23 Jan 2019 14:38:41 +0000 (15:38 +0100)]
2.31.1

Change-Id: I5608051794e244fbcec00fbfafb9a6d71f485254

5 years agoRedefine universal-switch vconf keys. 76/167276/2 accepted/tizen_5.0_unified tizen_5.0 accepted/tizen/5.0/unified/20181102.023524 accepted/tizen/unified/20180803.172634 submit/tizen/20180802.025248 submit/tizen/20180802.030818 submit/tizen/20180803.032352 submit/tizen/20180803.043714 submit/tizen_5.0/20181101.000005
Pawel Kurowski [Tue, 16 Jan 2018 14:42:06 +0000 (15:42 +0100)]
Redefine universal-switch vconf keys.

Change-Id: Ib01e580d4b263af6694cd473a3c313d6cdfc8bd6

5 years agolaunch universal-switch, if any of associated vconf flags is set 81/166981/5
Pawel Kurowski [Sun, 14 Jan 2018 13:08:54 +0000 (14:08 +0100)]
launch universal-switch, if any of associated vconf flags is set

Change-Id: I9efc756419d76bc79b8dd9a531a775f3eacdfe13

5 years ago[prevent][73691] Fix for resource leak 67/176767/1 accepted/tizen/unified/20180430.172433 submit/tizen/20180428.005615 submit/tizen/20180430.064002
Paweł Stawicki [Mon, 23 Apr 2018 09:16:20 +0000 (11:16 +0200)]
[prevent][73691] Fix for resource leak

Change-Id: I7030fa9b835457b72ca2b826df4e2e9942d69d34

5 years ago[prevent][76366] Fix for resource leak 82/176682/1
Paweł Stawicki [Fri, 20 Apr 2018 16:15:56 +0000 (18:15 +0200)]
[prevent][76366] Fix for resource leak

Change-Id: Ieaab30db6d430f898ab3959528bacd4056bfefd8

6 years agoMerge branch 'upstream/2.26.1' into tizen 04/175804/2 accepted/tizen/unified/20180425.062248 submit/tizen/20180419.063831 submit/tizen/20180423.061623
Paweł Stawicki [Wed, 4 Apr 2018 13:39:34 +0000 (15:39 +0200)]
Merge branch 'upstream/2.26.1' into tizen

Change-Id: Iab32f00420decb25c5393dbfdf31bc6a1c7495bf

6 years agoAdd member of default label info that check for default label enabed 57/174657/1 accepted/tizen/unified/20180413.073556 submit/tizen/20180412.065812 submit/tizen/20180412.094011
JunsuChoi [Tue, 3 Apr 2018 10:02:28 +0000 (19:02 +0900)]
Add member of default label info that check for default label enabed

Change-Id: I9f20e4aed82de71c5f64210817f8b11f6505f63d

6 years ago[prevent][38358] Fix for resource leak 40/173340/2 accepted/tizen/unified/20180405.005254 submit/tizen/20180403.101617 submit/tizen/20180404.045219 submit/tizen/20180404.084838
Paweł Stawicki [Tue, 20 Mar 2018 17:32:38 +0000 (18:32 +0100)]
[prevent][38358] Fix for resource leak

Change-Id: I26e7404fa047899f55d4150e2ed427aa097a681f

6 years ago[prevent][33973] Fix for unchecked return value 39/173339/2
Paweł Stawicki [Tue, 20 Mar 2018 17:01:04 +0000 (18:01 +0100)]
[prevent][33973] Fix for unchecked return value

Change-Id: I528adb092e1f8361dfbcb95ecc2d307587e26aac

6 years ago[prevent][38682] Fix for resource leak 38/173338/2
Paweł Stawicki [Tue, 20 Mar 2018 16:19:37 +0000 (17:19 +0100)]
[prevent][38682] Fix for resource leak

Change-Id: Iea61c399f59d2ddb2b55768f325c3005e01cfcf3

6 years ago[prevent][40806] Fix for dereference after null check 17/172917/2
Paweł Stawicki [Fri, 16 Mar 2018 18:48:50 +0000 (19:48 +0100)]
[prevent][40806] Fix for dereference after null check

Change-Id: Ic7239f40dcd5270a6fa4edf95daf30459ebfcdd4

6 years ago[prevent][24443] Fix for resource leakage 16/172916/2
Paweł Stawicki [Fri, 16 Mar 2018 18:42:52 +0000 (19:42 +0100)]
[prevent][24443] Fix for resource leakage

Change-Id: Ie4377a46c1d96e2a88da9851e72e6aa7b5198d09

6 years ago[prevent][35992] Fix for resource leakage 15/172915/2
Paweł Stawicki [Fri, 16 Mar 2018 18:36:08 +0000 (19:36 +0100)]
[prevent][35992] Fix for resource leakage

Change-Id: Iee9baa0546c1aee54cd9fbea4e37b63360767759

6 years ago[prevent][23957] Remove logically dead code 14/172914/2
Paweł Stawicki [Fri, 16 Mar 2018 18:31:00 +0000 (19:31 +0100)]
[prevent][23957] Remove logically dead code

Change-Id: I63b4a859375ba2813b6805db8d00521a41fe699e

6 years ago[prevent][36018] Fix for unchecked return value 04/172904/3
Paweł Stawicki [Fri, 16 Mar 2018 16:01:03 +0000 (17:01 +0100)]
[prevent][36018] Fix for unchecked return value

Change-Id: I79eba8a9907b44a0ea349eaab0ab2704284a200f

6 years ago[prevent][35766] Fix for unchecked return value 05/172905/3
Paweł Stawicki [Fri, 16 Mar 2018 16:19:05 +0000 (17:19 +0100)]
[prevent][35766] Fix for unchecked return value

Change-Id: I5138fda2b7128e8f8bf06621fc6ec4086829d5c0

6 years ago[prevent][38655] Fix for unchecked return value 06/172906/3
Paweł Stawicki [Fri, 16 Mar 2018 16:32:19 +0000 (17:32 +0100)]
[prevent][38655] Fix for unchecked return value

Change-Id: I117d7d12d0c2aa9f0ab32c239341ed2d91a5c14a

6 years ago[prevent][25425] at_spi2_tool: make sure app_name is set in _atspi_tree_traverse 62/172762/5
Paweł Stawicki [Thu, 15 Mar 2018 17:51:27 +0000 (18:51 +0100)]
[prevent][25425] at_spi2_tool: make sure app_name is set in _atspi_tree_traverse

"prevent" bug 25425 is a false positive, but it's a good practice
to check function arguments before using them

Change-Id: I884803613b670d1126120a689bb21ac78e87b8ab

6 years ago[prevent][43479] Fix for missing va_end in _atspi_dbus_call_partial 13/172913/2
Paweł Stawicki [Fri, 16 Mar 2018 17:08:19 +0000 (18:08 +0100)]
[prevent][43479] Fix for missing va_end in _atspi_dbus_call_partial

Change-Id: Ice71e5aaa543ca7908464538f15f3fbd921c464f

6 years ago[prevent][42662] Fix for unchecked return value 09/172909/3
Paweł Stawicki [Fri, 16 Mar 2018 16:45:31 +0000 (17:45 +0100)]
[prevent][42662] Fix for unchecked return value

Change-Id: Iee850e8fb485800d5c045fe4c7cd81728defd1d6

6 years ago[prevent][42562] Fix for resource leakage 03/172903/2
Paweł Stawicki [Fri, 16 Mar 2018 15:37:03 +0000 (16:37 +0100)]
[prevent][42562] Fix for resource leakage

Change-Id: Iabf4421164e91f6bcafe3b3be43932e0cf4de098

6 years ago[prevent][32379] Fix for resource leakage 02/172902/2
Paweł Stawicki [Fri, 16 Mar 2018 15:30:53 +0000 (16:30 +0100)]
[prevent][32379] Fix for resource leakage

Change-Id: I901af1e8739151b1d13b38c7d596678e1a286704

6 years ago[prevent][42870] Fix for null pointer dereference 88/172888/2
Paweł Stawicki [Fri, 16 Mar 2018 12:05:20 +0000 (13:05 +0100)]
[prevent][42870] Fix for null pointer dereference

Change-Id: I74e51363d0e6ec34e9b771f605d283f1311af803

6 years ago[prevent][36724] Fix for resource leakage 63/172763/2
Paweł Stawicki [Thu, 15 Mar 2018 18:17:23 +0000 (19:17 +0100)]
[prevent][36724] Fix for resource leakage

Change-Id: Ib0407cf3cf1de81e7c78c9d969daa067e0af428a

6 years ago[prevent][109656] Fix for resource leakage 61/172761/1
Paweł Stawicki [Thu, 15 Mar 2018 17:21:04 +0000 (18:21 +0100)]
[prevent][109656] Fix for resource leakage

Change-Id: Ic2abd2a7c7eafd530d147711d8881fb87788e140

6 years agoFixes glib runtime warnings on freeing empty arrays 98/171698/3
Radoslaw Cybulski [Tue, 6 Mar 2018 17:24:49 +0000 (18:24 +0100)]
Fixes glib runtime warnings on freeing empty arrays

Change-Id: Iba679a3cfbcdcdfd252c291d5f8bcf433c4d7198