platform/upstream/VK-GL-CTS.git
2 years agoAdd power of two checks for physical device limits
Jari Komppa [Fri, 12 Nov 2021 11:12:15 +0000 (13:12 +0200)]
Add power of two checks for physical device limits

This change adds power of two checks for the physical device limits
minTexelBufferOffsetAlignment, minUniformBufferOffsetAlignment,
minStorageBufferOffsetAlignment, nonCoherentAtomSize,
optimalBufferCopyOffsetAlignment and optimalBuffercopyRowPitchAlignment.

Affects:
dEQP-VK.info.device_properties

Components: Vulkan
VK-GL-CTS issue: 3291

Change-Id: I09fbf054262a351eca489f1bf66bf26f6aa177a6

2 years agoModify dual source blend tests to use discard
Jari Komppa [Sat, 13 Nov 2021 18:45:18 +0000 (20:45 +0200)]
Modify dual source blend tests to use discard

This change adds discard to the shaders when testing dual source blend
shading. The reference renderer does not support discard, so the
reference image is updated after rendering to cover for this.

Affects:
dEQP-VK.pipeline.blend.dual_source.*

Components: Vulkan
VK-GL-CTS issue: 3230

Change-Id: I06b9b7fb904bc2efbd5d8758a1c5ed5b5f76b4e5

2 years agoAdd fragment operations occlusion query tests
Juha Heiskanen [Tue, 2 Nov 2021 11:46:23 +0000 (13:46 +0200)]
Add fragment operations occlusion query tests

New occlusion query tests are covering scissored draws, depth and
stencil.

Components: Vulkan

VK-GL-CTS Issue: 3082

New tests: dEQP-VK.fragment_operations.occlusion_query.*

Change-Id: I64aa6788d163f88654977138c48209e8b1d82e59

2 years agoFix wrong conversion from shared pointer to int.
Mohd Faisal [Thu, 11 Nov 2021 11:34:09 +0000 (11:34 +0000)]
Fix wrong conversion from shared pointer to int.

Dereference the correct pointer to object and converting to int (flag)
via implicit converter.

Affects:

dEQP-VK.api.buffer_memory_requirements.*

Components: Vulkan

VK-GL-CTS issue: 3300

Change-Id: Id38991211b0dd65166dec3e75cf5f5f96309e1ff

2 years agoEnable anisotropic tests for mipmap images
Arkadiusz Sarwa [Mon, 15 Nov 2021 13:34:48 +0000 (14:34 +0100)]
Enable anisotropic tests for mipmap images

Affects:
dEQP-VK.texture.filtering_anisotropy.mipmap.*

Components: Vulkan

VK-GL-CTS issue: 3309

Change-Id: Ie6ac2604f757598d25c972f569c942850849ab58

2 years agoRemove invalid semaphore import/export tests
Jason Ekstrand [Fri, 12 Nov 2021 18:23:17 +0000 (12:23 -0600)]
Remove invalid semaphore import/export tests

VUID-VkSemaphoreGetFdInfoKHR-handleType-03253:

    If handleType refers to a handle type with copy payload transference
    semantics, semaphore must have been created with a VkSemaphoreType
    of VK_SEMAPHORE_TYPE_BINARY

These tests are explicitly testing semaphore FD export with
VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD which has copy payload
transference semantics.  We need to throw out the timeline semaphore
version.

Component: Vulkan

Removes:
 - dEQP-VK.synchronization.cross_instance.*timeline_semaphore_fence_fd
 - dEQP-VK.synchronization2.cross_instance.*timeline_semaphore_fence_fd

Change-Id: I5dc5643c34cf9f06adf29545bcefcb5c577aaaef

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
Matthew Netsch [Thu, 18 Nov 2021 23:23:49 +0000 (23:23 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I70424be31ee8dc38327b852c6d8dec9137f4294d

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Matthew Netsch [Thu, 18 Nov 2021 21:53:34 +0000 (21:53 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ib23ae3a63fd65ec4aae8385d92ffd09a114c32da

2 years agoFix glcPackedPixelsTests to properly account for skip images
Antto Mäkinen [Fri, 12 Nov 2021 11:45:46 +0000 (13:45 +0200)]
Fix glcPackedPixelsTests to properly account for skip images

RectangleTest::makeGradient in glcPackedPixelsTests does not
properly account for skip images. This commit prevents it
writing over the end of an array.

Affects:

KHR-GL33.packed_pixels.*

Components: OpenGL ES

VK-GL-CTS Issue: 3275

Change-Id: I9d8a47b59c000512926c3bfc85b6c6dc66eee213

2 years agoFix out-of-bounds stack read
Ari Suonpaa [Fri, 12 Nov 2021 05:08:39 +0000 (07:08 +0200)]
Fix out-of-bounds stack read

glBufferData was given a pointer to a C struct, but
a wrong struct type was used for sizeof.

VK-GL-CTS Issue: 3294

Affects:

KHR-GLES31.core.draw_indirect.negative-noV*arrays

Components: OpenGL
Change-Id: If02916683e0fee46b05dd4774b56f7fe335cc80f

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master
Matthew Netsch [Mon, 15 Nov 2021 05:35:37 +0000 (05:35 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: I78d174cdb4ea046992e89937063efd024e3acf77

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Sat, 13 Nov 2021 16:04:04 +0000 (11:04 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I617b1cfb37d3287225a9813b09f15ef4668d613d

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
Matthew Netsch [Sat, 13 Nov 2021 16:12:01 +0000 (16:12 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I86001493b5dcb4887476aa02b689d65e66e933fe

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Matthew Netsch [Sat, 13 Nov 2021 16:11:54 +0000 (16:11 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: If02f4572aca30dfa8de4f63dbe22873efb3c7e6b

2 years agoVarious methods passing of PhysicalStorageBuffer tests
michal_jakubek [Tue, 1 Jun 2021 11:17:21 +0000 (13:17 +0200)]
Various methods passing of PhysicalStorageBuffer tests

New tests:
dEQP-VK.spirv_assembly.instruction.compute.physical_storage_buffer.*

Components: Vulkan

VK-GL-CTS issue: 2759

Change-Id: I35ec137b31472a9798ade8653e75d83ab99d4413

2 years agoImprove coverage of MSAA copies
Vihanakangas [Wed, 10 Nov 2021 07:38:12 +0000 (09:38 +0200)]
Improve coverage of MSAA copies

This commit adds tests for copying without the
use of USAGE_COLOR_ATTACHMENT_BIT.

New tests:

dEQP-VK.api.copy_and_blit.*.resolve_image.whole_copy_before_resolving_no_cab.*

Affects:

dEQP-VK.api.copy_and_blit.*.resolve_image.*

Components: Vulkan

VK-GL-CTS issue: 3071

Change-Id: Ie6e41f812264ea70e9e86020d8d7be491ff4aea3

2 years agoFix Buffer Memory Requirements tests compilation errors
michal_jakubek [Sun, 7 Nov 2021 10:03:47 +0000 (11:03 +0100)]
Fix Buffer Memory Requirements tests compilation errors

Some older C ++ compilers incorrectly prioritize
initializer-list class constructors, especially
when these are nested in other initialization lists.

This fix solves the issue by explicitly forcing
the use of appropriate constructors.

Affects: dEQP-VK.api.buffer_memory_requirements.*

Components: Vulkan

VK-GL-CTS issue: 3284

Change-Id: I8e5c112fd04392284d76f301ebdbc93a7f358d9f

2 years agoMirror existing ANGLE waiver for Samsung devices
Ralph Potter [Tue, 9 Nov 2021 12:45:38 +0000 (12:45 +0000)]
Mirror existing ANGLE waiver for Samsung devices

Some Samsung devices utilize an extended ANGLE implementation, with
a Samsung vendor string.

Components: OpenGL ES
VK-GL-CTS issue: 3255

Change-Id: I6e49ae571ee38ea8dace36103f9d62055151b520

2 years agoSupport FP16 CPU Rendering
liruoyu [Fri, 25 Jun 2021 05:54:00 +0000 (13:54 +0800)]
Support FP16 CPU Rendering

1. Support float16 reference sample result.
2. Support rounding to zero when convert float.
3. Use zero rounding mode when interpolation in fp16 mode.

Affects:
dEQP-GLES3.functional.texture.wrap.astc/eac/etc1/etc2*

Components: OpenGL

VK-GL-CTS issue: 2977

Change-Id: I68b023d42b3f633331c2bb565097e829168215d8

2 years agoAvoid OOB params access in call log wrapper
Mika Väinölä [Thu, 4 Nov 2021 13:52:05 +0000 (15:52 +0200)]
Avoid OOB params access in call log wrapper

Some negative coverage tests call glTexParameter*v and
glGetSamplerParameter*v with GL_TEXTURE_BORDER_COLOR and a pointer to
a single GLint, GLuint or GLfloat. The call log wrapper functions
attempt to log all four parameters expected for the pname and we get
OOB access for params. Avoid this by using arrays of four instead of
single values for params.

Affects:
dEQP-GLES31.functional.debug.negative_coverage.*.texture.texparameter*
dEQP-GLES31.functional.debug.negative_coverage.*.shader.get_sampler_parameter*
dEQP-GLES31.functional.debug.error_filters.case_11
dEQP-GLES31.functional.debug.error_filters.case_18
dEQP-GLES31.functional.debug.error_filters.case_22
dEQP-GLES31.functional.debug.error_groups.case_11

Components: OpenGL

VK-GL-CTS issue: 3273

Change-Id: If244a008c9cfcc6cc443e8d5475f6ce4add1c838

2 years agoFix array iteration range
Jari Komppa [Thu, 4 Nov 2021 11:25:30 +0000 (13:25 +0200)]
Fix array iteration range

The function getCompressedTexSubImage2DFormat was using function
parameter to loop through an array defined inside the function, while
these two were unrelated. The result may either not loop through the
whole array or go past the end of the array.

Affects:
dEQP-GLES2.functional.negative_api.texture.compressedtexsubimage2d_*

Components: OpenGL
VK-GL-CTS issue: 3272

Change-Id: Ie88d9330e03f56b7afe858bf51e9bf0fa41e4822

2 years agoFix source data size in SSBO array length tests
Mika Väinölä [Fri, 5 Nov 2021 11:28:04 +0000 (13:28 +0200)]
Fix source data size in SSBO array length tests

The tests were calling glBufferData with a pointer to a single
deUint32 and a size of 2 * sizeof(deUint32). Change invalidData to
an array of two deUint32s.

Affects: dEQP-GLES31.functional.ssbo.array_length.*

Components: OpenGL

VK-GL-CTS issue: 3274

Change-Id: Id318c6541bbd8b61eec6d2ca460a3404c5c887e8

2 years agoRemove few EGL robustness tests
Brandon Schade [Tue, 28 Sep 2021 19:28:20 +0000 (12:28 -0700)]
Remove few EGL robustness tests

Components: EGL

Affects:
dEQP-EGL.functional.robustness.reset_context.shaders.infinite_loop.*

VK-GL-CTS issue: 257

Change-Id: I9edb2e577fb14b98d83bb16dc31188d3a901606d

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Matthew Netsch [Fri, 12 Nov 2021 21:40:26 +0000 (21:40 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I933b783b229d5d0545f1fc58ac01f5302625f81d

2 years agoPortability: avoid triangle fans
Piotr Byszewski [Wed, 3 Nov 2021 15:30:14 +0000 (16:30 +0100)]
Portability: avoid triangle fans

When the test itself has nothing to do with triangle fans,
just uses them to perform rendering then use triangle strips
instead so that tests also work for portability.

Components: Vulkan

VK-GL-CTS issue: 3266

Affects:
dEQP-VK.pipeline.push_constant.graphics_pipeline.overwrite
dEQP-VK.pipeline.extended_dynamic_state.*
dEQP-VK.pipeline.bind_point.graphics_compute.write_write.*

Change-Id: Iefa4f70d626584e71fc4fd341cccc15023a40d2d

2 years agoAdd yuv420 format to EGL AHB tests
Alex Lan [Fri, 20 Aug 2021 10:47:25 +0000 (18:47 +0800)]
Add yuv420 format to EGL AHB tests

Create an external texture with Y8Cb8Cr8_420 buffer format,
Initialize it with glClear, and sample it.

The test's behavior is like this:
1,initialize the external yuv texture with glClear
2,using glReadPixels to store the initial value in reference
3,sample this yuv texture
4,compare the rendering result with reference

New test:
dEQP-EGL.functional.image.create.gles3_android_native_yuv420_yuv_texture

Components: EGL, Framework

Change-Id: Ie4535505ea0d8d384794df77afa6583fe99fb1e2

2 years agoSkip negative vkCreateBuffer(size_max_uint64) test for maint4
Piers Daniell [Thu, 28 Oct 2021 16:46:40 +0000 (10:46 -0600)]
Skip negative vkCreateBuffer(size_max_uint64) test for maint4

With VK_KHR_maintenance4 it become invalid usage to call vkCreateBuffer
with a size larger than VkPhysicalDeviceMaintenance4Properties.maxBufferSize.
The dEQP-VK.api.buffer.basic.size_max_uint64 did just this even on maint4
implementation, which is invalid usage.

This CL marks this test as unsupported for implementations that support
VK_KHR_maintenance4.

Affects:

dEQP-VK.api.buffer.basic.*

Components: Vulkan

VK-GL-CTS issue: 3238

Change-Id: I4754c3af4ef253e50226a31a466bfe5772e65652
(cherry picked from commit f92d3e5a35afcf9c2f9226b81d5be54d10944819)

2 years agoFix fma precision tests for Open GL 4.5
Tapani Pälli [Fri, 8 Oct 2021 12:18:03 +0000 (15:18 +0300)]
Fix fma precision tests for Open GL 4.5

Affects:
dEQP-GL45.functional.shaders.builtin_functions.precision.fma.*

Components: AOSP
VK-GL-CTS issue: 3194

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: Iac2ca4e0687742b8d24ce35bee393a952567b735

2 years agoFix sRGB cases in framebuffer_fetch tests for OpenGL 4.5
Tapani Pälli [Mon, 11 Oct 2021 06:08:02 +0000 (09:08 +0300)]
Fix sRGB cases in framebuffer_fetch tests for OpenGL 4.5

Affects:
dEQP-GL45.functional.shaders.framebuffer_fetch.framebuffer_format.srgb8_alpha8

Components: OpenGL
VK-GL-CTS issue: 3202

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: Ibe7aecb30c71733041273f537e903dbbefa10107

2 years agoFix tessellation cases using precise qualifier for OpenGL 4.5
Tapani Pälli [Mon, 11 Oct 2021 09:36:19 +0000 (12:36 +0300)]
Fix tessellation cases using precise qualifier for OpenGL 4.5

Affects:
dEQP-GL45.functional.tessellation.common_edge.*precise

Components: OpenGL
VK-GL-CTS issue: 3203

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I5dbe030adc16bc7acbe47e54afb68cfdf9c7deea

2 years agoFix error logs in ssbo/image load store tests
Laurie Hedge [Thu, 21 Oct 2021 15:59:58 +0000 (16:59 +0100)]
Fix error logs in ssbo/image load store tests

SSBO tests that failed were logging first colour instead of the colour
that mismatched.

Image load/store tests that failed were missing a closing parenthesis.

Affects:

KHR-GLES31.core.shader_image_load_store.*
KHR-GLES31.core.shader_storage_buffer_object.*

Components: OpenGL

VK-GL-CTS issue: 3241

Change-Id: I0231dd9eb78c9bba60a89e93a91303374ec1ac83

2 years agoAdd coverage for sampling compressed cubemaps that has been written
Antto Mäkinen [Mon, 16 Aug 2021 06:51:31 +0000 (09:51 +0300)]
Add coverage for sampling compressed cubemaps that has been written
to by a compute shader

This commit adds new test cases to the compressed texture sampling test
to ensure that sampling compressed cubemaps works properly.

VK-GL-CTS issue: 3088

New Tests:
dEQP-VK.image.sample_texture.128_bit_compressed_format_cubemap
dEQP-VK.image.sample_texture.64_bit_compressed_format_cubemap
dEQP-VK.image.sample_texture.64_bit_compressed_format_two_samplers_cubemap
dEQP-VK.image.sample_texture.128_bit_compressed_format_two_samplers_cubemap

Components: Vulkan
Change-Id: I26724a21b03755693e45b99c8a794a9551a66e60

2 years agoImprove coverage of MSAA copies
Vihanakangas [Wed, 13 Oct 2021 12:10:41 +0000 (15:10 +0300)]
Improve coverage of MSAA copies

This commit adds tests for copying with separate layers
along with tests for copying multiple regions.

New tests:

dEQP-VK.api.copy_and_blit.*.resolve_image.copy_with_regions_before_resolving.*
dEQP-VK.api.copy_and_blit.*.resolve_image.layer_copy_before_resolving.*

Affects:

dEQP-VK.api.copy_and_blit.*.resolve_image.*

Components: Vulkan

VK-GL-CTS issue: 3071

Change-Id: I4889383314125516a951c6034b95425d806e25fc

2 years agoExtract findLSB() and findMSB() to a separate helper file.
michal_jakubek [Fri, 22 Oct 2021 07:59:25 +0000 (09:59 +0200)]
Extract findLSB() and findMSB() to a separate helper file.

Components: Framework

VK-GL-CTS issue: 2769

Change-Id: I00845d2df592e715648e32404c0963b3a2cddaeb

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master
Matthew Netsch [Sat, 6 Nov 2021 15:37:34 +0000 (11:37 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: Ieb6a351e3c18ae8908db0735783c0540748ef235

2 years agoRemove unused tests from mustpass
Matthew Netsch [Fri, 5 Nov 2021 23:47:42 +0000 (19:47 -0400)]
Remove unused tests from mustpass

Tests were renamed and are included
in other mustpass files, this cleans up
the old references

Components: Vulkan

Affects:
dEQP-VK.*-with-dynamic-rendering.*

Change-Id: I2b3775aba51478eafd93cfe93db53b9dd47307d5

2 years agoMerge vk-gl-cts/dev/VK_KHR_dynamic_rendering into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Fri, 5 Nov 2021 23:05:51 +0000 (19:05 -0400)]
Merge vk-gl-cts/dev/VK_KHR_dynamic_rendering into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I2b3463e1006c13221698a6fbdc8a26839ed3cb9e

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/dev/VK_KHR_dynamic_rendering
Matthew Netsch [Fri, 5 Nov 2021 23:03:54 +0000 (19:03 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/dev/VK_KHR_dynamic_rendering

Change-Id: Ica7c90f88986488142bc7c2b3e9b892b8104b7a1

2 years agoRename dynamic_rendering tests
Piotr Byszewski [Wed, 27 Oct 2021 13:06:38 +0000 (15:06 +0200)]
Rename dynamic_rendering tests

Three top level groups containing *_with_dynamic_rendering,
were moved one level down. Additionaly tests from
vktDynamicRenderingTests.hpp were moved to renderpass module.

Components: Vulkan

VK-GL-CTS Issue: 3248

Affects:
dEQP-VK.draw.*
dEQP-VK.dynamic_rendering.*
dEQP-VK.fragment_shading_rate.*

Change-Id: Iba32b7c011ce33c4c8cb52f2ed7e659096db32f8

2 years agoAdd tests for VK_NV_mesh_shader
Ricardo Garcia [Thu, 28 Oct 2021 13:36:36 +0000 (15:36 +0200)]
Add tests for VK_NV_mesh_shader

Tests that verify multiple aspects of mesh shader pipelines work as
expected. This includes:

* Some basic smoke tests.
* API tests to check the new draw calls and different rules about them.
* Synchronization tests.
* Test a wide range of affected built-in variables.
* Miscellaneous tests:
  * Producing small and large amounts of different types of primitives.
  * Barriers.
  * Push constants.
  * Custom per-primitive attributes.
  * Complex structures in the task->mesh interface.

New tests:
dEQP-VK.mesh_shader.nv.*

Components: Vulkan, Framework
VK-GL-CTS issue: 2991

Change-Id: I510296e4da326a2f0a3891d55a1116848d874c3f

2 years agoFix invocation count verification
James Fitzpatrick [Wed, 3 Nov 2021 14:31:50 +0000 (14:31 +0000)]
Fix invocation count verification

The shaders in these tests track the number of invocations executed and
verify that against the expected number of invocations for the test.

The spec only guarentees that each fragment is executed at least once.
So an implementation is free to execute each fragment multiple times
if required (for example, an implementation might required a shader to
be run at sample rate).

Change this verification to only check against the minmum number of
invocations.

Affects: dEQP-VK.fragment_operations.early_fragment.samplemask_*

Components: Vulkan

VK-GL-CTS issue: 3278

Change-Id: I93f1aa42dd6a13486bed044e361671e5a2f2cb07
(cherry picked from commit 72cf9dc888972c4dc8ed95358f0f56c6a40e072e)

2 years agoAllow Vulkan CTS 1.2.8.0
Matthew Netsch [Fri, 5 Nov 2021 14:25:23 +0000 (10:25 -0400)]
Allow Vulkan CTS 1.2.8.0

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: Ie10d15a1a049584f0aac2362aeac6a64fe47b2fa

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Fri, 5 Nov 2021 14:57:55 +0000 (10:57 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ieb86d43e6e02616c6ed2153b40dcb1256be30dd6

2 years agoFix image transition in dynamic rendering tests
Charles Johnston [Tue, 26 Oct 2021 14:51:09 +0000 (10:51 -0400)]
Fix image transition in dynamic rendering tests

The images need to be translated out of undefined layout,
before using them for dynamic rendering.

VK-GL-CTS issue: 3260

Components: Vulkan

Affects:
dEQP-VK.draw_with_dynamic_rendering.multiple_interpolation.*

Change-Id: I5cd1162683f77923a273bf774456cfb22b67b7c9

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
Matthew Netsch [Fri, 5 Nov 2021 15:33:20 +0000 (11:33 -0400)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I53b0729610bd0ea14cdfc58779aa3b834df8d6f8

2 years agoPrevent RT tests from going over VkPhysicalDeviceVulkan11Properties::maxMemoryAllocat...
Lionel Landwerlin [Wed, 6 Oct 2021 14:45:53 +0000 (17:45 +0300)]
Prevent RT tests from going over VkPhysicalDeviceVulkan11Properties::maxMemoryAllocationSize

VK-GL-CTS issue: 3064
Component: Vulkan

Affects:
dEQP-VK.ray_tracing_pipeline.misc.max*

Change-Id: Ia42f5530206eeeb94fa634ad84a213c2db558946

2 years agoPause XFB during pipeline switch
Mika Väinölä [Thu, 21 Oct 2021 07:46:33 +0000 (10:46 +0300)]
Pause XFB during pipeline switch

The per pipeline provoking vertex tests call vkCmdBindPipeline while
transform feedback is active which is not allowed.

Affects:
dEQP-VK.rasterization.provoking_vertex.*

Components: Vulkan

VK-GL-CTS issue: 3207

Change-Id: I30edf010179ff9629fc90053f14d228d828551a2

2 years agoMake dynamic rendering tests match non-dynamic
Piotr Byszewski [Thu, 28 Oct 2021 12:15:35 +0000 (14:15 +0200)]
Make dynamic rendering tests match non-dynamic

Cases for attachment tests are randomly generated. When
those tests were ported to dynamic rendering they were
using a slightly different generation algorithm and this
resulted in dynamic rendering not matching renderpass
tests that had the same name.
With this change tests for dynamic rendering use
same configuration but some of those configurations
that won't add coverage are skipped.

Components: Vulkan

VK-GL-CTS issue: 3179

Affects:
dEQP-VK.renderpass.*.attachment.*
dEQP-VK.renderpass_with_dynamic_rendering.*.attachment.*

Change-Id: Id386f7dd56682ff4a54e0f9816c1752ac2fc12cd

2 years agoRemove dynamic rendering multiview tests
Piers Daniell [Thu, 28 Oct 2021 21:14:21 +0000 (15:14 -0600)]
Remove dynamic rendering multiview tests

These WIP tests don't work right now and need to be disabled,
which mirrors what was done in the vulkan-cts-1.3.0 branch.

A follow on CL will reenable them and fix them.

Affects:

dEQP-VK.draw_with_dynamic_rendering.multi_draw.*

Components: Vulkan

VK-GL-CTS Issue: 3251

Change-Id: Ib99c09d326706fadeeec962e241152bf20bf977c

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Matthew Netsch [Fri, 5 Nov 2021 14:04:48 +0000 (10:04 -0400)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ifa75c860ad2c39661494aeb086255a97672e72b0

2 years agoGCC 11 build fixes for opengl-es-cts
Tapani Pälli [Tue, 26 Oct 2021 11:12:16 +0000 (14:12 +0300)]
GCC 11 build fixes for opengl-es-cts

Add missing limits header to misc files to fix compilation.

+ changes to fix following compilation warnings:

"warning: expression does not compute the number of elements in this array;
element type is ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’},
not ‘std::string [15]’ {aka ‘std::__cxx11::basic_string<char> [15]’}
[-Wsizeof-array-div]"

"warning: loop variable ‘ext’ creates a copy from type
‘const std::__cxx11::basic_string<char>’ [-Wrange-loop-construct]"

"warning: comparison of unsigned expression in ‘>= 0’ is always true
[-Wtype-limits]"

Components: OpenGL ES
VK-GL-CTS issue: 3245

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: If62a44d47afccf1118a6fb0986d0c6e715f78c48

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Matthew Netsch [Fri, 5 Nov 2021 13:59:25 +0000 (09:59 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I81ba38a964a81a6266d2a6286cf60a42ed027885

2 years agoPortability: handle robustBufferAccess
Piotr Byszewski [Tue, 2 Nov 2021 11:13:32 +0000 (12:13 +0100)]
Portability: handle robustBufferAccess

When the VK_KHR_portability_subset extension is advertised,
robustBufferAccess is no longer a required feature.

Components: Vulkan

VK-GL-CTS issue: 3267

Affets:
dEQP-VK.robustness.*

Change-Id: I957da2a36c40662c99c0b01774a8bf03ef3f3890

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Matthew Netsch [Thu, 4 Nov 2021 20:45:41 +0000 (16:45 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I53d429b0dfc4a62a33949748ef4ce0a804f71814

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Matthew Netsch [Thu, 4 Nov 2021 20:45:39 +0000 (16:45 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I1c61bd275a7161d071ad79aa493c6634582391a2

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Matthew Netsch [Thu, 4 Nov 2021 20:45:32 +0000 (16:45 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Ice8e3ca5f949d6c134f91a7d5317ab5892d5147d

2 years agoAllow Vulkan CTS 1.2.7.2
Matthew Netsch [Mon, 1 Nov 2021 14:56:44 +0000 (10:56 -0400)]
Allow Vulkan CTS 1.2.7.2

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: I6075a82eab8f347ef5b9523a10d6e6621163bfbc

2 years agoAdd compute test with zero dispatch size
Ricardo Garcia [Wed, 20 Oct 2021 07:55:51 +0000 (09:55 +0200)]
Add compute test with zero dispatch size

Add a few tests that check vkCmdDispatch works properly even if one of
the sizes is zero.

New tests:
dEQP-VK.compute.basic.empty_workgroup_*

Components: Vulkan
VK-GL-CTS issue: 3183

Change-Id: I689469e3d0bd87a3fd92616e5ef482009e3461dd

2 years agoTest contradictory parameters on swapchain creation
Ricardo Garcia [Tue, 26 Oct 2021 11:30:52 +0000 (13:30 +0200)]
Test contradictory parameters on swapchain creation

This commit adds new tests that check the implementation properly
ignores queueFamilyIndexCount and pQueueFamilyIndices on swapchain
creation when imageSharingMode is set to VK_SHARING_MODE_EXCLUSIVE, by
providing a null pointer in pQueueFamilyIndices and a nonzero
queueFamilyIndexCount.

In addition, swapchain creation tests using VK_SHARING_MODE_EXCLUSIVE
will no longer pass 1 in queueFamilyIndexCount and a list of
surface-compatible queues in pQueueFamilyIndices, setting
queueFamilyIndexCount to 0 and passing a null pointer instead.

Finally, the commit adds de::arrayLength as a more modern and constexpr
way of obtaining the size of statically-sized arrays, similar to
DE_LENGTH_OF_ARRAY, which can be used with static_assert.

New tests:
dEQP-VK.*exclusive_nonzero_queues

Affected tests:
dEQP-VK.*.swapchain.create.*

Components: Framework, Vulkan
VK-GL-CTS issue: 3244

Change-Id: I631aba22ac18d1fe6a2fcc8bf41890b2e8a2cc91

2 years agoRevert "Exclude cov-function-with-nested-loops-called-from-nested-loops"
Paul Thomson [Tue, 28 Sep 2021 09:36:00 +0000 (10:36 +0100)]
Revert "Exclude cov-function-with-nested-loops-called-from-nested-loops"

This reverts commit b0c3e7ba7d99a3e9e2052a498569cea0721dfb09.

Components: Vulkan

Affects:
dEQP-VK.graphicsfuzz.cov-function-with-nested-loops-called-from-nested-loops

VK-GL-CTS Issue: 3171

Change-Id: I590db29c6d57b68bd76478140fef798ea6127f91

2 years agoAdd buffer feature check for depth/stencil formats
Juha Heiskanen [Tue, 26 Oct 2021 05:09:27 +0000 (08:09 +0300)]
Add buffer feature check for depth/stencil formats

Tests that check the drivers are not exposing undesired format
features for depth/stencil formats.

Components: Vulkan

VK-GL-CTS Issue: 3155

New tests: dEQP-VK.api.buffer.invalid_buffer_features.*

Change-Id: I7cc72f19ff58899e087ee0365780a5a0f50b3a47

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master
Matthew Netsch [Fri, 29 Oct 2021 17:57:43 +0000 (13:57 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: I1fcf5038213aacef0a7fe7c1d3e4cc5e04e80e64

2 years agoFix memory requirements tests for sparse images
Piotr Byszewski [Fri, 22 Oct 2021 11:42:25 +0000 (13:42 +0200)]
Fix memory requirements tests for sparse images

When memory requirements tests are executed for sparse images
we need to check sparse image format properties first.

VK-GL-CTS issue: 3201

Components: Vulkan

Affects:
dEQP-VK.memory.requirements.*.image.sparse*

Change-Id: I058d6dd6c4eeabce89c3f6835fbc16e4386712d5

2 years agoFix image requirements according to its usage
michal_jakubek [Mon, 25 Oct 2021 07:39:15 +0000 (09:39 +0200)]
Fix image requirements according to its usage

VK-GL-CTS issue: 3090

Components: Vulkan

Affects:
dEQP-VK.sparse_resources.shader_intrinsics.*

Change-Id: If6c8e55be75fd3a9a170c7d0d413dc658d40adfa

2 years agoInitialise new member of ImageTestParams struct
Graeme Leese [Fri, 22 Oct 2021 10:19:48 +0000 (11:19 +0100)]
Initialise new member of ImageTestParams struct

This doesn't appear to be used in the tests, but without this it
generates compiler warnings on some of our platforms.

Components: Vulkan
VK-GL-CTS issue: 3240
Affects: dEQP-VK.memory.requirements.*

Change-Id: I5c4dfd0443f0f318d45e89ae22d5103a1dae198e

2 years agoEnsure the vertex shader matches the vertex input definition
Piers Daniell [Wed, 15 Sep 2021 13:41:49 +0000 (15:41 +0200)]
Ensure the vertex shader matches the vertex input definition

When doing the "reversed" variants of the extended dynamic
state tests, the vertex input attribute and binding information
was reversed, but the vertex shaders were not. The meant that
in some tests the vertex shader may try to fetch from unbound
or undefined vertex attributes or vertex attribute data.

This commit fixes the issue by swapping vertex shaders for the
affected variants.

Affects:
dEQP-VK.pipeline.extended_dynamic_state.*

Components: Vulkan
VK-GL-CTS issue: 3111

Change-Id: I7d9abbe7dab0b44127f6b194ee5da79755f7658c
Co-authored-by: Ricardo Garcia <rgarcia@igalia.com>
(cherry picked from commit aebbea7b29507dfb24fb204697671ad7b4ac4fc1)

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Fri, 29 Oct 2021 15:48:02 +0000 (11:48 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ib53ac9424d4263b3114e46c532f28b55f522cf2c

2 years agoUpdate SPIRV-Headers
Paul Thomson [Mon, 25 Oct 2021 18:41:00 +0000 (19:41 +0100)]
Update SPIRV-Headers

The SPIRV-Headers version for vulkan-cts-1.2.6 was ahead of 1.2.7. This
change brings SPIRV-Headers in 1.2.7 up to the same version.

Components: Vulkan
Change-Id: Ifff93c5251183d3a6ee3ef3f508e88274332116f

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Matthew Netsch [Fri, 29 Oct 2021 14:41:15 +0000 (10:41 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I7535fbad6813c7a6dfec1324a2656329de792ebe

2 years agoRemove 64-bit int usage in dynamic_indexing test shaders
Mohankumar Nekkarakalaya [Tue, 12 Oct 2021 18:58:22 +0000 (11:58 -0700)]
Remove 64-bit int usage in dynamic_indexing test shaders

- "OpCapability Int64" is not a mandatory extension
- Replace with v2i32

Components: Vulkan

VK-GL-CTS Issue: 3205

Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.dynamic_indexing.dynamic_indexing
dEQP-VK.ray_query.acceleration_structures.dynamic_indexing.dynamic_indexing

Change-Id: I04b7cf6309b42ef4572e5c79c8e9233aee2edec7

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Matthew Netsch [Fri, 29 Oct 2021 13:52:23 +0000 (09:52 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I8a9f12e6adc0daf962a4f6f05d28216db4880ee8

2 years agoCheck shaderInt64 in workgroup memory explicit layout alias tests
Ricardo Garcia [Thu, 14 Oct 2021 11:27:46 +0000 (13:27 +0200)]
Check shaderInt64 in workgroup memory explicit layout alias tests

A few workgroup memory explicit layout alias tests were not checking
shaderInt64 while using 64-bit integers in shaders.

Affected tests:
dEQP-VK.compute.workgroup_memory_explicit_layout.alias.*u64*array*
dEQP-VK.compute.workgroup_memory_explicit_layout.alias.*array*u64*

Components: Vulkan
VK-GL-CTS issue: 3131

Change-Id: I1911018c471e9548603d5de987625163bb356eb9

2 years agoAllow NaN result when result exceeds limit
Mohankumar Nekkarakalaya [Thu, 21 Oct 2021 00:14:08 +0000 (17:14 -0700)]
Allow NaN result when result exceeds limit

Based on spec if the result is too large to be represented
in the floating point the result is undefined.

Issue was found with ldexp. Since fix is applicable in general
updated the isFinite() to take maxValue and checks the interval value
with the allowed max value in the context (and similarly for
negative numbers). If the result is beyond the 32-bit
floating-point representation expected result is unbounded

Components: Vulkan, OpenGL, Framework

VK-GL-CTS Issue: 3138

Affected tests:
dEQP-VK.glsl.builtin.function.*
dEQP-VK.glsl.builtin.precision.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.*
dEQP-GLES31.functional.shaders.builtin_functions.common.fma.*

Change-Id: Iba27d6b0d7d0bc433a1d0c055cef6f6a61b239ba

2 years agoAccept NaN as valid in atan2 precision tests
Graeme Leese [Fri, 27 Aug 2021 12:46:19 +0000 (13:46 +0100)]
Accept NaN as valid in atan2 precision tests

The Vulkan CTS has been updated
(https://gerrit.khronos.org/c/vk-gl-cts/+/7857) so that it is not
required to generate correct results for atan(inf, inf), and this makes
the corresponding change in GL. The GLSL spec is not as clear on what is
required here, but does say:
    Built-in functions not listed above and not defined as equations of
    the above have undefined precision. These include, for example, the
    trigonometric functions

In general, I think that it is expected that the default state of Vulkan
is a match for GL.

Components: OpenGL
VK-GL-CTS issue: 3073
Affects: dEQP-GLES3.functional.shaders.builtin_functions.precision.atan2.highp_*

Change-Id: Ifae97a2e86962f5aff68d5eed09ba38069445468

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
Matthew Netsch [Thu, 28 Oct 2021 21:58:12 +0000 (17:58 -0400)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I3e4f47adf9a8446556351175e63b2cf3f1e8a399

2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Matthew Netsch [Thu, 28 Oct 2021 21:57:59 +0000 (17:57 -0400)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ibee0d474561af951a4ef33db864aaa4993ca38d5

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Matthew Netsch [Thu, 28 Oct 2021 21:57:06 +0000 (17:57 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I54315f34095f396294bab85b0da4a1e3cf38aac8

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Matthew Netsch [Thu, 28 Oct 2021 21:57:00 +0000 (17:57 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I2f2be91bd696c7de227f804202f9a8eb222cab03

2 years agoFix VK_KHR_shader_clock feature checks
Ricardo Garcia [Fri, 8 Oct 2021 07:50:00 +0000 (09:50 +0200)]
Fix VK_KHR_shader_clock feature checks

The shader clock tests were not checking if the implementation supported
64-bit integers for tests that required the feature and they were
checking supported features at test instance creation time instead of
the specific checkSupport method for test cases.

Affected tests:
dEQP-VK.glsl.shader_clock.*

Components: Vulkan
VK-GL-CTS issue: 3187

Change-Id: I0dc86a4fae619c0d27628d97f0ac11c5def5ff4f

2 years agoFix dEQP-VK.tessellation.geometry_interaction.limits.output_required_max_geometry...
Juha Heiskanen [Tue, 19 Oct 2021 11:38:09 +0000 (14:38 +0300)]
Fix dEQP-VK.tessellation.geometry_interaction.limits.output_required_max_geometry validation error

Adjust numSliceNodesComponentLimit in order to keep
m_numGeometryPrimitivesPerInvocation within minimum limits defined in
the spec.

Components: Vulkan

VK-GL-CTS Issue: 3180

Affects:
dEQP-VK.tessellation.geometry_interaction.limits.output_required_max_geometry

Change-Id: I72ca43bec27256cb75a11d75aab91b9b565be9ab

2 years agoMove log prints from test-ctor to test-inst-ctor
Jari Komppa [Tue, 5 Oct 2021 09:52:03 +0000 (12:52 +0300)]
Move log prints from test-ctor to test-inst-ctor

Some of the tesselation tests were printing values into the output log
from the test constructor, which meant that said prints end up in more
or less random place in the log. Moved those prints to the test instance
instead, so the information now resides within the test output.

The prints were also done in the amber-verify run mode.

Affects:
dEQP-VK.tessellation.geometry_interaction.scatter.*
dEQP-VK.tessellation.geometry_interaction.limits.*

Components: Vulkan
VK-GL-CTS issue: 3057

Change-Id: Ic5b2ce59369d1c20f25b8dc1c6cb594baac74f8f

2 years agox11_egl: only append library path if it's not empty
Iván Briano [Mon, 11 Oct 2021 19:45:24 +0000 (12:45 -0700)]
x11_egl: only append library path if it's not empty

Pkg-config will strip out any -L if they match the default search
directory, so we ended up with a -L and no arguments to it, that would
consume whatever came next.

Components: EGL

VK-GL-CTS issue: 2726

Change-Id: Iba0f7d8e0a4ab66e5fd369f60e4d04ac5420df65

2 years agoSplit multiple interpolation tests using the sample decoration
Ricardo Garcia [Fri, 15 Oct 2021 13:48:16 +0000 (15:48 +0200)]
Split multiple interpolation tests using the sample decoration

This commit separates the multiple interpolation tests in two groups,
one including the sample decoration in the set and another one excluding
it. The goal is to avoid requiring the sampleRateShading feature in all
tests, which is mandatory when using the sample decoration.

In addition, this commit makes sure the sampleRateShading feature is
required for those cases.

New tests:
dEQP-VK.draw.multiple_interpolation.*.no_sample_decoration.*

Affected tests:
dEQP-VK.draw.multiple_interpolation.*

Components: Vulkan
VK-GL-CTS issue: 3129

Change-Id: I8c190c70db9e7fef7505dc31bbf8b6626161f60e

2 years agoFix layout transitions in dynamic_rendering tests
Jason Ekstrand [Mon, 25 Oct 2021 22:25:16 +0000 (17:25 -0500)]
Fix layout transitions in dynamic_rendering tests

With dynamic rendering, we no longer have initial and final layout
transitions provided automatically as part of vkCmdBeginRendering() and
vkCmdEndRendering().  Instead, it's the responsibility of the client to
transition the images into and out of the layout passed to
vkCmdBeginRendering().  When translating from Vulkan 1.0 style
subpasses, this means we need to do a pipeline barrier before and after
rendering.

Affects:
dEQP-VK.renderpass_with_dynamic_rendering.*

Change-Id: I56214198a8b3d81e3030164de045b8ca03a44f88

2 years agoAllow EGL tests to use ES3 with EGL_KHR_create_context
Ari Suonpaa [Thu, 16 Sep 2021 10:58:44 +0000 (13:58 +0300)]
Allow EGL tests to use ES3 with EGL_KHR_create_context

Previously EGL tests that relied on ES3 required EGL 1.5. Now
these are also run when EGL_KHR_create_context is supported.

VK-GL-CTS Issue: 3122

Affects:

dEQP-EGL.functional.image.create.gles3*

Components: EGL
Change-Id: I05fe87a0d2e321310b28df9a998006867115e0f0

2 years agoCover vkGetBufferMemoryRequirements*() routines tests
michal_jakubek [Tue, 12 Oct 2021 11:43:17 +0000 (13:43 +0200)]
Cover vkGetBufferMemoryRequirements*() routines tests

New tests:
dEQP-VK.api.buffer_memory_requirements.*

Components: Vulkan

VK-GL-CTS issue: 3163

Change-Id: I806d8a420e1e6d204061b3b740500736609263f8

2 years agoAdd missing barrier to dynamic rendering tests
jaxl [Wed, 15 Sep 2021 03:14:19 +0000 (11:14 +0800)]
Add missing barrier to dynamic rendering tests

Vulkan spec requires driver to do automatic layout transition when
subpass of render pass begins. However, for dynamic rendering,
there is no such requirement in spec, so the application should
transfer image layout.

Affected tests:
VK.renderpass_with_dynamic_rendering.suballocation.multisample_resolve.*

Components: Vulkan
VK-GL-CTS issue: 3162

Change-Id: Id3bb8fa83ac4f891150f1a8f74bf61e7d7d5e854
(cherry picked from commit 430ab25e4964bd195c58e15e7b51a7de620ebd40)

2 years agoFix stencil rendering in draw_with_dynamic_rendering.multi_draw tests
Sławomir Cygan [Thu, 21 Oct 2021 13:18:19 +0000 (15:18 +0200)]
Fix stencil rendering in draw_with_dynamic_rendering.multi_draw tests

This fixes few issues with handling depth/stencil attachment in this test:

Stencil attachment is now passed to rendering info, alongside depth attachment.

A barrier transitioning depth stencil subresource from UNFEFINED layout is added.

A barrier initializing color subresource is fixed to be executed with desition stage
that involves color.

Components: Vulkan

VK-GL-CTS Issue: 3235

Affects: dEQP-VK.draw_with_dynamic_rendering.multi_draw.*

Change-Id: I2b1a0bb04dae24328ab798a9e436e1000db901de
(cherry picked from commit 9f2876528c93cd47a59604ce4f30e8525560f280)

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master
Matthew Netsch [Fri, 22 Oct 2021 20:57:54 +0000 (16:57 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: I2aaf2dbd77937a00f045727d428fc45437ca96df

2 years agoFix multisample_with_fragment_shading_rate tests
Piotr Byszewski [Thu, 14 Oct 2021 18:29:36 +0000 (20:29 +0200)]
Fix multisample_with_fragment_shading_rate tests

Two tests in multisample group are added with helper
function addFunctionCaseWithPrograms. When those tests
were repeated for FSR then they were executed without
checking if required features are supported. This
change fixes that by reusing existing function
checkFragmentShadingRateRequirements (it was slightly
modified to work also with those two tests).

VK-GL-CTS issue: 3220

Components: Vulkan

Affects:
dEQP-VK.pipeline.multisample_with_fragment_shading_rate.*

Change-Id: I8dcbc09ac4a1d8d3c53eb95da591b916ded2f5b9

2 years agodEQP-VK.renderpass*.load_store_op_none.* tests depth-stencil format support check
Neslisah [Thu, 12 Aug 2021 15:32:21 +0000 (11:32 -0400)]
dEQP-VK.renderpass*.load_store_op_none.* tests depth-stencil format support check

In this test case, depth stencil format is set to VK_FORMAT_D24_UNORM_S8_UINT by default without checking if it is supported or not. If this format is not supported, then the test case crashes without even giving "Not Supported" result.

In this update I defined a set of depth stencil formats, and added a separate test case for each depth_stencil format. If the depth_stencil format is not supported, "Not Supported" is returned.

Affects: dEQP-VK.renderpass*.load_store_op_none.*

Components: Vulkan
VK-GL-CTS issue: 3049

Change-Id: Ifea5d0955a8325ecbed7f27296da4120e473d463
(cherry picked from commit 79c44fc79b7d17b8c70d2469e113c764011c51c6)

2 years agoIncrease tolerance for matrix precision tests
James Fitzpatrick [Wed, 6 Oct 2021 13:22:03 +0000 (14:22 +0100)]
Increase tolerance for matrix precision tests

On hardware with a RTZ rounding mode the tolerance required in these
tests was too low and valid implementations of the functions would
fail the tests.

Increase the tolerance allowed to allow RTZ hardware to pass these
tests.

Affects:
dEQP-VK.glsl.builtin.precision*.determinant.*
dEQP-VK.glsl.builtin.precision*.inverse.*

Components: Vulkan

VK-GL-CTS issue: 3182

Change-Id: I83845aec8faa01aec0820852219b6b8c4326da4e
(cherry picked from commit 0593bd63803c16159db7553d8ca5191fd42126cc)

2 years agoFix incorrect shader output format
James Fitzpatrick [Tue, 5 Oct 2021 09:12:46 +0000 (10:12 +0100)]
Fix incorrect shader output format

For test variants that write to a stencil buffer, the final attachment
will be R8_UINT. For these tests ensure the fragment shader is
outputing to this attachment as a uint.

Affects: dEQP-VK.synchronization2.none_stage.*

Components: Vulkan

VK-GL-CTS issue: 3177

Change-Id: Ia7e185c8c8486c8b0e76e11038e0a5108770f21f
(cherry picked from commit 4dbc15461d925429b6545bd162c97a86ba3f8a73)

2 years agoSlightly increase tolerance for fp64 determinant test
Iván Briano [Mon, 18 Oct 2021 20:32:00 +0000 (13:32 -0700)]
Slightly increase tolerance for fp64 determinant test

VK-GL-CTS issue: 3229

Components: Vulkan

Affects:
dEQP-VK.glsl.builtin.precision_double.determinant.compute.mat3

Change-Id: I2e4d239a33e4c82e328a3df90e7a6c38056db4d8

2 years agoFix DS Layout in LoadStoreOpNone when using dynamic_rendering
Aaron Hagan [Thu, 21 Oct 2021 13:38:17 +0000 (09:38 -0400)]
Fix DS Layout in LoadStoreOpNone when using dynamic_rendering

It's in the wrong layout when being read from.

Components: Vulkan
VK-GL-CTS issue: 3236

Affected tests:
   dEQP-VK.renderpass_with_dynamic_rendering.suballocation.load_store_op_none.*

Change-Id: I58ae176c6d179cfb262434b24937c5f278112ea6
(cherry picked from commit 12d53a826d2769990d15f78dc2210d173ad00ee0)

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Fri, 22 Oct 2021 19:54:00 +0000 (15:54 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ic672c22814f2196db26725b7b2794629bbe130b6

2 years agoUpdate drivers ids
Samuel Iglesias Gonsálvez [Fri, 1 Oct 2021 06:18:08 +0000 (08:18 +0200)]
Update drivers ids

From last version of Vulkan-Docs.

Components: Framework
VK-GL-CTS issue: 3173

Change-Id: I39aeb4f16d3bf19291a5a266595b215681ef2c83
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
2 years agoMerge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
Matthew Netsch [Fri, 22 Oct 2021 19:38:57 +0000 (15:38 -0400)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I11af39aa7fcbecb367a721b7fe3a39b67cbf8550

2 years agoRemove invalid reserved keywords tests
Graeme Leese [Wed, 7 Jul 2021 10:15:41 +0000 (11:15 +0100)]
Remove invalid reserved keywords tests

These identifiers are not listed as reserved in any spec that I can
find.

Components: OpenGLES
Removed Tests: dEQP-GLES3.functional.shaders.keywords.reserved_keywords.image*Shadow_*

Change-Id: I444d9a8a49d3dda7402faa50b79859aaef0ee690
(cherry picked from commit 99df4bc28a2e9f755467fd0c6a88702ee2428232)

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Matthew Netsch [Fri, 22 Oct 2021 18:23:39 +0000 (14:23 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I6f96b469518264e53fdd142f445187f8eb091c6d