Slawomir Cygan [Wed, 6 Sep 2017 14:47:04 +0000 (16:47 +0200)]
Use SRC image layout for copy image to buffer
The test was calling vkCmdCopyImageToBuffer with
VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout, which is not a valid
parameter value for this function (and not the layout the image is currently in).
Affects: dEQP-VK.memory.binding.*.*.image_*
Components: Vulkan
VK-GL-CTS issue: 666
Change-Id: Ifb5a1bd8726535de02a0dc134f5ac76a2734a661
Courtney Goeltzenleuchter [Tue, 5 Sep 2017 23:48:27 +0000 (17:48 -0600)]
Check for EGL_KHR_gl_colorspace before using it
Bug:
65376495
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: Ief654c998e93d72899225120b0ca1ab2fa3ca624
Alexander Galazin [Tue, 5 Sep 2017 21:44:31 +0000 (21:44 +0000)]
Merge "Add more allowed 'dot' alternatives"
am:
7e8c3b2d00
Change-Id: I8ea74cc7658e034905be82c02fafc7f01b4e3705
Treehugger Robot [Tue, 5 Sep 2017 21:35:29 +0000 (21:35 +0000)]
Merge "Add more allowed 'dot' alternatives"
Mika Isojrvi [Tue, 5 Sep 2017 19:47:23 +0000 (19:47 +0000)]
Fix unused uniform bug in EGL robustness tests
am:
7806d74666
Change-Id: I7bdb3742437ed0abe590f5c011bf1b78cade9419
Slawomir Cygan [Tue, 5 Sep 2017 14:39:12 +0000 (16:39 +0200)]
Do not use ycbcr formats if ycbcr extension is not supported
Spec says (on "vkGetPhysicalDeviceFormatProperties"):
"format must be a valid VkFormat value"
Formats from future or unsupported extensions do not
constitute a "valid VkFormat values".
Affects: dEQP-VK.memory.requirements.*.image.*
Components: Vulkan
VK-GL-CTS issue: 663
Change-Id: Ia284977b830d5fda14bcbd9d96010995d84014d5
Mika Isojärvi [Tue, 5 Sep 2017 17:33:37 +0000 (17:33 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"
am:
e19c3ff127
Change-Id: I4eadac66e4d313347a6b3fea1c4585bb98507641
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests
Bug:
64845766
Bug:
65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127
Treehugger Robot [Tue, 5 Sep 2017 17:18:37 +0000 (17:18 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"
Pyry Haulos [Tue, 5 Sep 2017 15:31:57 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2
am:
342eb176e6
Change-Id: Iad7f205649553e7096d52a0cbf16d868ba405085
Pyry Haulos [Tue, 5 Sep 2017 15:22:27 +0000 (15:22 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: I86a852a2216971095d4aa256a97f0b8e68e73646
Pyry Haulos [Tue, 5 Sep 2017 15:21:58 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Ia7cd7612e6c2f0f961837734f1900a21b52a0e39
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e
Gary Sweet [Mon, 4 Sep 2017 09:39:36 +0000 (10:39 +0100)]
Fixup some missing/incorrect flushes and invalidates
Some of the flushes were too small, and there were a few
missing invalidates.
Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
Components: Vulkan
VK-GL-CTS issue: 660
Change-Id: Id29b59d127e004a028c04a1075db563d697140a1
Alexander Galazin [Tue, 22 Aug 2017 13:59:49 +0000 (15:59 +0200)]
Add more allowed 'dot' alternatives
Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.
Components: AOSP
VK-GL-CTS issue: 634
Google issue:
28767510
Affects:
dEQP-GLES3.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES3.functional.shaders.builtin_functions.precision.reflect.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.reflect.*
Change-Id: I2a91add1b92363acab2172179320cd880da779ec
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests
Bug:
64845581
Bug:
65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0
Daniel Koch [Thu, 31 Aug 2017 13:48:53 +0000 (09:48 -0400)]
Whitelist new extensions for VK 1.0.2.6
VK-GL-CTS issue: 653
Component: Vulkan
Affects:
dEQP-VK.api.info.device.extensions
Change-Id: I7f5ef7511ce8312e67833e07c154cd6b9fea6041
Mika Isojärvi [Tue, 15 Aug 2017 23:57:24 +0000 (16:57 -0700)]
Add tests for image copies between YCbCr formats
Components: Vulkan, Framework
VK-GL-CTS issue: 111
Change-Id: I3a7050ae5605c4397cd678e14438f851a7cf48ce
(cherry picked from commit
f24269bdd0c4d3801c2118b153082f0b0223f55a)
Mika Isojärvi [Tue, 16 May 2017 21:17:49 +0000 (14:17 -0700)]
Add tests for VK_KHR_sampler_ycbcr_conversion
Components: Vulkan, Framework
VK-GL-CTS issue: 111
Change-Id: Id0810b196f0a148903922df3fc08f1c5db88f86e
(cherry picked from commit
595b5f763a8f6ef1c68bfd133a55ded9c25ac101)
Boris Zanin [Fri, 12 May 2017 08:11:01 +0000 (10:11 +0200)]
Test VK_KHR_dedicated_allocation mem requirement queries
Add tests:
* dEQP-VK.memory.requirements.dedicated_allocation.buffer.*
* dEQP-VK.memory.requirements.dedicated_allocation.image.*
Components: Vulkan
VK-GL-CTS issue: 391
Change-Id: I9510464987e33b395a5ac20c2fdb9129eefd91da
(cherry picked from commit
6c472cc5e98a1a73aeac019ce34cccac7f3fa30e)
David Sodman [Fri, 24 Feb 2017 19:04:46 +0000 (11:04 -0800)]
Add tests for FragCoord interaction with multisampling
Components: Vulkan
VK-GL-CTS issue: 89
Test: fragcoord_msaa, frontface, fragdepth, clipping
Change-Id: Ibf342e63f224b88fe0b0cffde59b10b34afd1faf
(cherry picked from commit
69a7a0079a6cc06d556ecb5314f275d2fa01a60d)
Maciej Jesionowski [Wed, 26 Jul 2017 13:53:13 +0000 (15:53 +0200)]
Fix VS12 compilation error (typedef)
Change-Id: Iebfece1455df2a49c79885d42f43817001a31b84
(cherry picked from commit
68c41978cf7a76391e898af7faaddea0598a3911)
Slawomir Cygan [Wed, 5 Jul 2017 17:17:02 +0000 (19:17 +0200)]
Fix wrong transition in dEQP-VK.glsl.builtin_var.fragdepth
The test was using vkCmdClearDepthStencilImage to clear an
image, than used this image as a depth attachment in
redering performed by VulkanDrawContext utility.
However, this utility always starts the renderpass on depth
attachment from UNDEFINED layout. As no depth clear is done
in the renderpass, the depth attachment contents are undefined
(and initially cleared image contents may be corrupted).
The easiest fix here is to move the clear to LOAD_OP - as
is already done for color, leaving the UNDEFINED layout as is.
Affects: dEQP-VK.glsl.builtin_var.fragdepth*
Components: Vulkan
VK-GL-CTS issue: 559
Change-Id: Icef3289ba62f71bf1ed989f84085a4d9d3b7218a
(cherry picked from commit
f3a36239082b721e1f5f6849afc70af65b42e3ed)
David Sodman [Fri, 24 Feb 2017 18:41:59 +0000 (10:41 -0800)]
Add test for FragDepth shader built-in
Components: Vulkan
VK-GL-CTS issue: 93
Test: fragdepth, frontface, clipping
Change-Id: I531e39a58dd6b577108bff14b2206d7bf9d9cd4f
(cherry picked from commit
3aeb0c565fe64441466247fe381fc815209d46e4)
David Sodman [Tue, 6 Sep 2016 21:05:59 +0000 (14:05 -0700)]
Extend gl_FrontFacing tests
Update gl_FrontFacing tests to include more tests as well as to use the
vktDrawUtil utility class
Change-Id: If94fb552f5f9366c79ffa3fcac6f085611a23f65
(cherry picked from commit
417115b2676c3064a06385184573b6d7a0644f42)
David Sodman [Fri, 9 Sep 2016 02:58:35 +0000 (19:58 -0700)]
Add ability to generate images with the reference renderer
*Separate DrawContext into a DrawContext and DrawContextState to reflect
graphics API's are split between state and action parts
* Add abstract DrawContext class
Test: Test clipping and synchronization primitives
Change-Id: I9f3945c6c3de169325fadea7bf70a9d5d7bfd932
(cherry picked from commit
11da53fb71eced942e89bac59407a5681dba3bb1)
David Sodman [Thu, 1 Sep 2016 17:40:21 +0000 (10:40 -0700)]
Add Vulkan DrawContext utility class
This is the first in a series of changes to move the DrawContext class
for more general use.
Test: run clipping tests on Vulkan
Affects: dEQP-VK.clipping.*
Change-Id: Ia9b8953d25c10ec2a6c227bf300637dcd62ea898
(cherry picked from commit
9a928cdc2014c830eb8cb43043746f8f2ea6969a)
Arkadiusz Sarwa [Tue, 29 Aug 2017 14:40:58 +0000 (16:40 +0200)]
VK_KHR_maintenance2: View block-compressed add check shader_read_only_optimal
Affects:
* dEQP-VK.image.texel_view_compatible.compute.extended.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texture.*
* dEQP-VK.image.texel_view_compatible.compute.extended.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_write.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: Ida0c7b8085e7ca90c325ffb0477773e8b09bf564
(cherry picked from commit
62e68c3916ce22a76b44bec91e470abc42cd6e92)
Boris Zanin [Tue, 8 Aug 2017 09:59:32 +0000 (11:59 +0200)]
VK_KHR_maintenance2: extended_usage_bit tests
Add tests:
* dEQP-VK.image.extended_usage_bit.*
Components: Vulkan
VK-GL-CTS issue: 614
Change-Id: Ied6251e642746d5f37aa7b2fe3f262061f765f8f
(cherry picked from commit
dcae428a67a0bccf2a6694075dd06115f0eb1db7)
Arkadiusz Sarwa [Tue, 29 Aug 2017 10:39:57 +0000 (12:39 +0200)]
Fix build errors with uint32_t vktImageMutableTests.cpp
Change-Id: I072fade98fd20b6a4a0389e9a63e790d36d6c0d0
Components: Vulkan
(cherry picked from commit
1afc0a15d483701f3319467f7a3f1d9b47692f66)
Boris Zanin [Thu, 24 Aug 2017 08:29:06 +0000 (10:29 +0200)]
VK_KHR_maintenance2: View block-compressed speedup
Do strict comparison first, if it fails use fuzzy.
Update tests:
* dEQP-VK.image.texel_view_compatible.compute.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I1ad580d60638ba3fce83fc913819608d5d9a8812
(cherry picked from commit
c9e2dea449429762592af0530b609cf80ab913ce)
Arkadiusz Sarwa [Fri, 21 Jul 2017 14:35:33 +0000 (16:35 +0200)]
VK_KHR_maintenance2: View block-compressed formats extended tests
Add tests:
* dEQP-VK.image.texel_view_compatible.compute.extended.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texture.*
* dEQP-VK.image.texel_view_compatible.compute.extended.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_write.*
Update tests:
* dEQP-VK.image.texel_view_compatible.compute.basic.*
* dEQP-VK.image.texel_view_compatible.graphic.basic.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: Ia51ece39a339617302ec4f2a48c9133a3f9423d4
(cherry picked from commit
90d87fdceed790f9542acb19c3da196951c4d2dc)
Fix build errors with makeViewport
Local makeViewport cannot be used in recently added tests
in vktImageMutableTests.
Fix: Remove local makeViewport and use one from vkTypeUtil.inl
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I27c9c255d9e46a74a6528327339317ba74e5eb98
(cherry picked from commit
310b00cc9869e26e85e620b55b6ad3a7efeb8d90)
Pyry Haulos [Mon, 12 Jun 2017 20:52:42 +0000 (13:52 -0700)]
Framework support for VK_KHR_sampler_ycbcr_conversion
Change-Id: I749b92c79766f933ea34bb183d3d34c102e023c2
(cherry picked from commit
e5cf8de067694afde10873b6fdbd7907486e5611)
Mika Isojärvi [Thu, 4 May 2017 22:55:19 +0000 (15:55 -0700)]
Add support for 10 and 12bit packed unorm formats
10 and 12bit unsigned normalized values are packed into highers bits
of 16bit unsigned int.
Change-Id: I18a88547ba29003961bf0806a50cb17995c72f13
Components: Framework
(cherry picked from commit
07621ffcf0362606afeccf2c2deac35bc0f3668a)
Iago Toral Quiroga [Tue, 4 Jul 2017 08:59:45 +0000 (10:59 +0200)]
Add tests for VK_KHR_image_format_list
Components: Vulkan
VK-GL-CTS issue: 550
New tests:
dEQP-VK.image.mutable.*_format_list
Change-Id: Ic72304a65c76335c98764678e056f030fafba71f
(cherry picked from commit
dcd00f2f316fae0b86e1b03a8cf22774ce312c1d)
Iago Toral Quiroga [Thu, 29 Jun 2017 05:37:41 +0000 (07:37 +0200)]
Expand tests for mutable images
Currently, only the image load/store tests use mutable images,
but these require the images's layout to be
VK_IMAGE_LAYOUT_GENERAL (requirement for image load/store) so they
don't provide coverage for the most interesting scenarios.
These tests add cases that mix combined image upload/download
methods that exercise various other image layouts and scenarios.
Specifically, it tests each of [copy, clear, draw, store] upload
methods with each of [copy, load, texture] download methods.
Components: Vulkan
VK-GL-CTS issue: 513
New Tests:
dEQP-VK.image.mutable.*
Change-Id: I01cd77ab250f9934e71f5c9997b850950c9bd552
(cherry picked from commit
16b30ca0f65fc9c6a1508d1f99ba1f6014f4e828)
Marcin Rogucki [Fri, 21 Jul 2017 11:44:23 +0000 (13:44 +0200)]
Tests for VK_KHR_bind_memory2
Regular and aliased bindings with suballocated and
dedicatedly allocated memory are exercised.
Added tests:
* dEQP-VK.memory.binding.*
Components: Vulkan
VK-GL-CTS issue: 434
Change-Id: I853ca8b007a9b2f6340ed60cca1a5cb35887ec11
(cherry picked from commit
a0aa054cbddcebe880d12836fae9a24ad4eade9f)
Arkadiusz Sarwa [Fri, 9 Jun 2017 15:58:01 +0000 (17:58 +0200)]
VK_KHR_maintenance2: View block-compressed formats
Add tests:
* dEQP-VK.image.texel_view_compatible.compute.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.texture.*
* dEQP-VK.image.texel_view_compatible.compute.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.texture_write.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I8f12778e764144198dab603dbef72257faed0503
(cherry picked from commit
52af60c002b457dbc09044dc2e88ccee9cb59555)
Boris Zanin [Mon, 10 Apr 2017 17:14:55 +0000 (19:14 +0200)]
VK_KHR_maintenance2: Point clipping
Updated tests:
* dEQP-VK.clipping.clip_volume.clipped.large_points
* dEQP-VK.rasterization.primitives.lines_wide
* dEQP-VK.rasterization.primitives.line_strip_wide
* dEQP-VK.rasterization.primitives_multisample_2_bit.lines_wide
* dEQP-VK.rasterization.primitives_multisample_4_bit.lines_wide
* dEQP-VK.rasterization.primitives_multisample_8_bit.lines_wide
Components: Vulkan
VK-GL-CTS issue: 126
Change-Id: Id0cecb96e8a448ec3eb09e2a25d6c82acd837057
(cherry picked from commit
14bfa832d795dca9057699e867d0273db95c7de4)
Mika Isojärvi [Fri, 21 Apr 2017 22:33:54 +0000 (15:33 -0700)]
VK_KHR_maintenance2: New depth and stencil layouts
New Tests:
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.*.*_depth_read_only
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.*.*_stencil_read_only
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.input.*.*_depth_read_only
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.input.*.*_stencil_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.*.*_depth_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.*.*_stencil_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.input.*.*_depth_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.input.*.*_stencil_read_only
VK-GL-CTS issues: 339
Components: Vulkan
Change-Id: Ifac0a3a5fe861440424f85029dd25bad5755cd63
(cherry picked from commit
226ae75fa4fc85eaa46b1544dc8871fceeeb759c)
Pyry Haulos [Tue, 18 Apr 2017 21:49:12 +0000 (14:49 -0700)]
VK_KHR_maintenance2: Tessellation domain origin
This change extends existing dEQP-VK.tessellation.winding tests with
variants that supply tessellation domain origin when creating the
pipeline.
Existing tests in the group have been moved under "default_domain"
group.
VK-GL-CTS issue: 127
Components: Vulkan
Change-Id: Ib3ed3fd32dc66805d139db08a2c0546650d0de5f
(cherry picked from commit
333b51b00a943447c0eb921f04b2804af428dfc9)
Jason Ekstrand [Thu, 26 Jan 2017 22:27:48 +0000 (14:27 -0800)]
Add yflip versions of tessellation winding order tests
Changed: dEQP-VK.tessellation.winding.triangles_*
Components: Vulkan
Change-Id: I3e0abc8d25132e129cb2979b1fce985ca4a60dc4
(cherry picked from commit
a9c1d0abb740baa5f368758f17142336baeb17f9)
Mika Isojärvi [Thu, 13 Apr 2017 20:53:21 +0000 (13:53 -0700)]
VK_KHR_maintenance2: Render pass input aspect specifiers
VK-GL-CTS issues: 125
Components: Vulkan
Change-Id: I32a88f1d82560df4bc1b8f7cac483a074434ec86
(cherry picked from commit
a1a041546262e8ad17fa62f40af8b293ebbb698a)
Pyry Haulos [Thu, 8 Jun 2017 19:32:17 +0000 (12:32 -0700)]
Add framework support for VK_KHR_maintenance2
Components: Vulkan
VK-GL-CTS issue: 199
Change-Id: I9112fc0c44c6516e5e65d53535c9b0247f91e272
(cherry picked from commit
59b5bb0016f0f0bc6a2e3973016ae6f90655ac7c)
Alexander Galazin [Thu, 31 Aug 2017 17:02:20 +0000 (19:02 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: I5dfa06e462512838179803963ddd04094679aa4f
Alex Walters [Thu, 17 Aug 2017 14:53:01 +0000 (15:53 +0100)]
Make create_buffer test use platform limits
The create_buffer tests use a maximum buffer size of half the heap size
as reported by vkGetPhysicalDeviceMemoryProperties. On systems where
device memory comes out of system memory, due to the memory in use in
the system the selected buffer size may be too large.
The heap size is checked against the platform limits, the min is taken
and that is used as the basis for calculating the buffer size to test
Affects:
dEQP-VK.api.buffer.createBuffer_*
Components: Vulkan
VK-GL-CTS issue: 362
Change-Id: I7a644e8e48b961dad0d19675e3d54add4b11d99c
Pyry Haulos [Thu, 9 Mar 2017 17:46:29 +0000 (09:46 -0800)]
Fix issues in pipeline.timestamp.transfer_tests
This change fixes two issues:
* Buffer overrun in vkCmdCopyBufferToImage and vkCmdCopyImageToBuffer
tests.
* Validation error (srcStageMask must not be 0).
VK-GL-CTS issue: 185
Components: Vulkan
Change-Id: I9679566f08c4a914eb6066bab248abd6d51e0f7e
Tapani Plli [Wed, 30 Aug 2017 17:51:01 +0000 (17:51 +0000)]
Require EGL_KHR_gl_colorspace for wide_color tests.
am:
2a3edba962
Change-Id: Ib187061a097641d56876d85b1af68baae7bc6f1d
Slawomir Cygan [Wed, 30 Aug 2017 13:36:27 +0000 (15:36 +0200)]
dEQP-VK.geometry: use proper layout for sampling the image
While 'GENERAL' layout is acceptable layout for sampling image, the barrier in
geometry\vktGeometryBasicGeometryShaderTests.cpp:235
transitions the image to `SHADER_READ_ONLY_OPTIMAL` layout.
Both layout must much, otherwise the behavior is undefined.
Affects:
dEQP-VK.geometry.basic.output_vary_by_texture_instancing
dEQP-VK.geometry.basic.output_vary_by_texture
Components: Vulkan
VK-GL-CTS issue: 648
Change-Id: I2b947a150173f0a060cfbf851d117ef91097c1d8
Tapani Pälli [Mon, 28 Aug 2017 06:20:53 +0000 (09:20 +0300)]
Require EGL_KHR_gl_colorspace for wide_color tests.
These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.
v2: loosen the check, only check when enum in use (Courtney)
Change-Id: I891a6fdcce49ac6dcd42577076d4cf64a143dd38
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Ian Elliott [Wed, 16 Aug 2017 21:11:57 +0000 (15:11 -0600)]
Fix flakiness in mailbox.display_timing
The "vktWsiDisplayTimingTests.cpp" file was originally written just for
a present mode of VK_PRESENT_MODE_FIFO_KHR. It has a case at image 80,
where it changes the desiredPresentTime to be 1 second earlier, and then
checks that later. Such a check doesn't work with
VK_PRESENT_MODE_MAILBOX_KHR, which can throw off the timing of images
(because some images may not be presented). This has resulted in the
test having random failures. The "image 80 test" wasn't intended to
occur with MAILBOX, and so it's now being removed.
VK-GL-CTS issue: 622
Components: Vulkan
Affects: dEQP-VK.wsi.*.display_timing.mailbox.display_timing
Change-Id: I9fbd2254b4e6fc1c7bff077c8c0a5229a6d74800
Courtney Goeltzenleuchter [Thu, 24 Aug 2017 23:11:50 +0000 (23:11 +0000)]
Merge "Check only what's needed and use threshold"
am:
923d047106
Change-Id: I375f81f9ea270da5ca86bbb9c0a0465a82dbec19
Treehugger Robot [Thu, 24 Aug 2017 22:57:17 +0000 (22:57 +0000)]
Merge "Check only what's needed and use threshold"
Mika Isojärvi [Thu, 24 Aug 2017 22:35:31 +0000 (22:35 +0000)]
Merge Vulkan CTS 1.0.2.5 into aosp/master
am:
76a147bf66
Change-Id: I05b18f9180285aa9b140b63f132020874d83e9d4
Mika Isojärvi [Thu, 24 Aug 2017 20:13:19 +0000 (13:13 -0700)]
Merge Vulkan CTS 1.0.2.5 into aosp/master
Bug:
64932237
Change-Id: Ic2758a85f3a8f8cf00985b03a89830ba509f824d
Courtney Goeltzenleuchter [Fri, 28 Jul 2017 19:51:31 +0000 (13:51 -0600)]
Check only what's needed and use threshold
Check for only the functionality needed for a specific test.
E.g. if testing floating point color, don't need to check
for support of 10:10:10:2 pixel format.
Some devices are not able to hit the exact values calculated.
Not unexpected, update tests to use thresholds.
Note: waiting on results of b/
64487716. Seeing failure on
Pixel devices. Need to make sure it's not a test issue.
Test: adb -s
0424415804161004f80d -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: I2adb31eaa3b189179aeceb9e8f6b1ac8587b6027
(cherry picked from commit
041a1b5e82db7a6945aaefd791639de1c8c9e84d)
Michael Chock [Tue, 22 Aug 2017 18:43:02 +0000 (18:43 +0000)]
Merge "Avoid thread state races in EGL multithread tests" am:
5a0d512e5b am:
0efcf60ff5
am:
d3f6571fff
Change-Id: I66748716e20fea93d29cbb114ed7301908657f16
Alexander Galazin [Tue, 22 Aug 2017 18:42:43 +0000 (18:42 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present" am:
4929480c47 am:
df3f2b14f6
am:
a7b9f7a5d9
Change-Id: I2b6fcc4798f08029ae47f83ca699aa9e6c1dc4d3
Michael Chock [Tue, 22 Aug 2017 18:39:28 +0000 (18:39 +0000)]
Merge "Avoid thread state races in EGL multithread tests" am:
5a0d512e5b
am:
0efcf60ff5
Change-Id: Ide30bf228e53857ea93ce7a91e4c2b10d8a845a0
Alexander Galazin [Tue, 22 Aug 2017 18:39:11 +0000 (18:39 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present" am:
4929480c47
am:
df3f2b14f6
Change-Id: I330781b5ea59882db46629591b30f49ae6486a6a
Michael Chock [Tue, 22 Aug 2017 18:32:44 +0000 (18:32 +0000)]
Merge "Avoid thread state races in EGL multithread tests"
am:
5a0d512e5b
Change-Id: I775814f0bfe3cad21a3cada9c017d08e5a2aa739
Alexander Galazin [Tue, 22 Aug 2017 18:32:21 +0000 (18:32 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present"
am:
4929480c47
Change-Id: Ie0e580b58bace63bb7dafc4fafdbe17f766ae3a3
Treehugger Robot [Tue, 22 Aug 2017 18:13:36 +0000 (18:13 +0000)]
Merge "Avoid thread state races in EGL multithread tests"
Treehugger Robot [Tue, 22 Aug 2017 18:10:07 +0000 (18:10 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present"
Alexander Galazin [Thu, 17 Aug 2017 14:16:09 +0000 (16:16 +0200)]
Add more allowed 'dot' alternatives
Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.
Components: Vulkan
VK-GL-CTS issue: 634
Affects:
dEQP-VK.glsl.builtin.precision.dot.*
dEQP-VK.glsl.builtin.precision.reflect.*
Change-Id: I7fecbfa1cde04eab95bb3d418972631727d6d6af
Alexander Galazin [Wed, 16 Aug 2017 09:36:01 +0000 (11:36 +0200)]
Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present
Draw*BaseVertex methods are enabled if
the EXT_draw_elements_base_vertex extension is present
Follow-up on
1b1ea05b
Components: AOSP
Affects: dEQP-GLES31.functional.draw_base_vertex.*
Change-Id: If8a4860a956c771ec5ea3341e2227f437b12a286
Mika Isojrvi [Thu, 17 Aug 2017 00:28:39 +0000 (00:28 +0000)]
Fix texture mip level size in framebuffer fetch tests am:
be0d165a5d am:
0f01836518
am:
cc06f40d06
Change-Id: Ia5336f05e320268f49b41a10f419c01b690e291f
Mika Isojrvi [Thu, 17 Aug 2017 00:17:54 +0000 (00:17 +0000)]
Fix texture mip level size in framebuffer fetch tests am:
be0d165a5d
am:
0f01836518
Change-Id: I39f281404c2497d957ae91d93d368202f83febfb
Mika Isojrvi [Thu, 17 Aug 2017 00:08:48 +0000 (00:08 +0000)]
Fix texture mip level size in framebuffer fetch tests
am:
be0d165a5d
Change-Id: I7fb9c075ee79e411ea295999e9edd7f38a5e5bc9
Mika Isojärvi [Wed, 16 Aug 2017 20:40:22 +0000 (13:40 -0700)]
Fix texture mip level size in framebuffer fetch tests
Bug:
64280744
Test: Ran tests with multiple Google devices
Change-Id: I369a3c9b16270655332d5a608207f0da2633e0fe
james.glanville [Wed, 16 Aug 2017 19:12:11 +0000 (19:12 +0000)]
Merge "Use safe glFramebufferTexture* function" am:
ec5ccbe144 am:
d4c3e6e71b
am:
1f2e434e86
Change-Id: I05b273c4c5842ef9713cea1e0ee5db14965bc6df
Michael Chock [Wed, 16 Aug 2017 19:11:52 +0000 (19:11 +0000)]
Merge "Do not use degenerate frames in EGL tests" am:
f5971fe17f am:
4a2d8af710
am:
bdab538931
Change-Id: I659eb59a332af92c90de471a3cdb6eb2ce9ec4d2
james.glanville [Wed, 16 Aug 2017 19:08:36 +0000 (19:08 +0000)]
Merge "Use safe glFramebufferTexture* function" am:
ec5ccbe144
am:
d4c3e6e71b
Change-Id: I31749dfd7ca7258c702b3d00c3f438cebbbf4056
Michael Chock [Wed, 16 Aug 2017 19:08:22 +0000 (19:08 +0000)]
Merge "Do not use degenerate frames in EGL tests" am:
f5971fe17f
am:
4a2d8af710
Change-Id: I86d818ee189deef3102b0f112378cef1723edad0
james.glanville [Wed, 16 Aug 2017 19:04:43 +0000 (19:04 +0000)]
Merge "Use safe glFramebufferTexture* function"
am:
ec5ccbe144
Change-Id: I156ecc2a6ed17e3e23ef17ebbe026be27c1670c3
Michael Chock [Wed, 16 Aug 2017 19:04:22 +0000 (19:04 +0000)]
Merge "Do not use degenerate frames in EGL tests"
am:
f5971fe17f
Change-Id: I9807e27047a0d0280e06bc826cab3e6cb88b5ab6
Treehugger Robot [Wed, 16 Aug 2017 18:59:45 +0000 (18:59 +0000)]
Merge "Use safe glFramebufferTexture* function"
Treehugger Robot [Wed, 16 Aug 2017 18:59:42 +0000 (18:59 +0000)]
Merge "Do not use degenerate frames in EGL tests"
Alexander Galazin [Wed, 16 Aug 2017 18:54:52 +0000 (18:54 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported" am:
f96636fdfa am:
eaf6e29e46
am:
3946a20ebc
Change-Id: Ifc2e7f4ef52d03eb2f6570f5fc83818ee4e2c190
Alexander Galazin [Wed, 16 Aug 2017 18:51:50 +0000 (18:51 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported" am:
f96636fdfa
am:
eaf6e29e46
Change-Id: If70e55237194763a02f31d3a20bbc475403d8670
Alexander Galazin [Wed, 16 Aug 2017 18:47:50 +0000 (18:47 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported"
am:
f96636fdfa
Change-Id: Iccb20250f9b98f983fc831911a1f9b4d4a98fbfb
Treehugger Robot [Wed, 16 Aug 2017 18:36:54 +0000 (18:36 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported"
Alexander Galazin [Wed, 16 Aug 2017 18:27:18 +0000 (18:27 +0000)]
Merge "Fix error double accounting in fuzzyCompare()" am:
0cf17c4bf8 am:
f64327185c
am:
aca02e1db5
Change-Id: I33c50071a663091adfc992b518610b68ed46b303
Alexander Galazin [Wed, 16 Aug 2017 18:23:48 +0000 (18:23 +0000)]
Merge "Fix error double accounting in fuzzyCompare()" am:
0cf17c4bf8
am:
f64327185c
Change-Id: I5a42417bee0eab58fc2cae3a653e41e4624cb2eb
Alexander Galazin [Wed, 16 Aug 2017 18:20:18 +0000 (18:20 +0000)]
Merge "Fix error double accounting in fuzzyCompare()"
am:
0cf17c4bf8
Change-Id: Ife3e4f1bd13c6f4cb939950635880ce32d2b1df3
Treehugger Robot [Wed, 16 Aug 2017 18:06:52 +0000 (18:06 +0000)]
Merge "Fix error double accounting in fuzzyCompare()"
Michael Chock [Mon, 14 Aug 2017 15:36:11 +0000 (08:36 -0700)]
Avoid thread state races in EGL multithread tests
Previously, threads objects inside dEQP-EGL.functional.multithread.*
tests would conflate thread execution status with test results. The
former would only be set inside the thread, but the latter could be set
by other threads (e.g., a test thread might set its status to RUNNING
while another test might attempt to set the status of NOT_SUPPORTED).
These race conditions could lead to incorrect results.
Fix this by moving error and not-supported states out of the thread
execution state, and instead storing them as single-purpose flags inside
the test case object, avoiding the possibility of conflicting writes.
Change-Id: I2b117aa98c1c2b69b0d134610d6fd37656083e54
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests
The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).
Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.
Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28
james.glanville [Wed, 16 Aug 2017 10:50:19 +0000 (11:50 +0100)]
Use safe glFramebufferTexture* function
glFramebufferTexture() is only supported when GL_EXT_geometry_shader is
present. Use glFramebufferTextureLayer() instead so that testing is
possible on unextended ES3.1 contexts.
Components: AOSP
Affects:
dEQP-GLES31.functional.shaders.framebuffer_fetch.basic.framebuffer_texture_level
Alexander Galazin [Wed, 16 Aug 2017 09:36:01 +0000 (11:36 +0200)]
Report tests using Draw*BaseVertex as NotSupported
Draw*BaseVertex methods were added in GLES 3.2.
Report tests using these methods as NotSupported if
GLES 3.1 context is returned.
Components: AOSP
Affects: dEQP-GLES31.functional.draw_base_vertex.*
Change-Id: I87c918d5f66a0a5b547f8e625c662203a7f85048
Alexander Galazin [Wed, 16 Aug 2017 00:51:38 +0000 (00:51 +0000)]
Check for tessellation/geometry extensions being exposed am:
573154bb7b am:
f79e5f07b3
am:
b50ad0b932
Change-Id: I766cb8e77a92f4dbe295224522a40bc568aa8bab
Alexander Galazin [Wed, 16 Aug 2017 00:41:06 +0000 (00:41 +0000)]
Check for tessellation/geometry extensions being exposed am:
573154bb7b
am:
f79e5f07b3
Change-Id: I3a2713fb0e10929d2b326443ab82beeed61df85e
Alexander Galazin [Wed, 16 Aug 2017 00:32:11 +0000 (00:32 +0000)]
Check for tessellation/geometry extensions being exposed
am:
573154bb7b
Change-Id: I86d05362cf94c693d4000969d2c177c692f07686
Alexander Galazin [Fri, 11 Aug 2017 16:32:00 +0000 (18:32 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: Iae127509ee1d187291e37c0ee9da7d331b070646
Gary Sweet [Wed, 26 Jul 2017 09:50:31 +0000 (10:50 +0100)]
Keep buffer memory alive through BufferView creation
The device memory used to create a buffer was going out
of scope and being freed too early. A buffer view was
subsequently made using the buffer. This is invalid.
This change extends the lifetime of the buffer memory to
match the buffer.
Affects:
dEQP-VK.api.buffer_view.create.*
Components: Vulkan
VK-GL-CTS issue: 574
Change-Id: I6605da750d6494587781285447a157ef12018459
Dave Airlie [Thu, 27 Jul 2017 19:43:53 +0000 (05:43 +1000)]
Fix combined depth/stencil clear colors.
This test was clearing depth to 256.0, values > 1.0 are undefined.
This fixes the the combined depth/stencil clears to use valid values
for depth and stencil.
Affects:
dEQP-VK.api.copy_and_blit.core.image_to_image.all_formats.depth_stencil.*
VK-GL-CTS Issue: 591
Change-Id: I75fd7e2bf17a84f7a2730f36b4bcdc066af1177c
Oivind Boge [Thu, 10 Aug 2017 10:24:02 +0000 (12:24 +0200)]
Fixed incorrect calculation of GCD
The calculation of greatest common divisor was
implemented incorrect when first added.
The function was using the input parameter instead
of its local copy of the input, which is updated
for each iteration of the calculation.
Affects:
dEQP-VK.api.image_clearing.*
Components: Vulkan
VK-GL-CTS issue: 625
Change-Id: I6619e4a30d89148d2567a725dbd27161fcf29a47
Oivind Boge [Sat, 8 Jul 2017 12:09:12 +0000 (14:09 +0200)]
Fix layout transition for WSI tests
The initial layout of the renderpass can't be
COLOR_ATTACHMENT_OPTIMAL without any transition
happening upfront.
Affects:
dEQP-VK.wsi.android.display_timing.*
dEQP-VK.wsi.android.incremental_present.*
Components: Vulkan
VK-GL-CTS issue: 565
Change-Id: Ie62f7aee21c52145090bf228db7031c0e4afb347
Gary Sweet [Thu, 27 Jul 2017 10:42:40 +0000 (11:42 +0100)]
Respect sampleRateShading availability in interpolate tests
Most of the tests in the dEQP-VK.pipeline.multisample_interpolation
group use one of the interpolatAt*() functions in their shaders.
These are only valid if sampleRateShading is available.
The multisampleStateInfo also blindly sets sampleShadingEnable
to true without checking.
Affects:
dEQP-VK.pipeline.multisample_interpolation.*
Components: Vulkan
VK-GL-CTS issue: 600
Change-Id: I95f91af9a7abb1e55ff2a3da0c0daefb819226f9
Slawomir Cygan [Mon, 31 Jul 2017 12:22:50 +0000 (14:22 +0200)]
Fix regressions in synchronization tests for dedicated allocations
Pass image memory requirements to allocation routine in allocateAndBindMemory.
VK_KHR_get_memory_requirements2 is a device extension (not instance).
Throw NotSupported when external handle requires dedicated allocation,
but 'suballocated' variant of test is being run.
Affects:
dEQP-VK.synchronization.cross_instance.*
Components: Vulkan
VK-GL-CTS issue: 604
Change-Id: I3636779459300f5dee2e22b0a2e04762eb7b0601