platform/upstream/VK-GL-CTS.git
6 years agoLower correlation threshold in flush-finish tests again
Gurchetan Singh [Fri, 6 Oct 2017 16:06:21 +0000 (09:06 -0700)]
Lower correlation threshold in flush-finish tests again

This test expects predictability from glFlush/glFinish timing.
In particular,  the code from FlushFinishCase::analyzeResults()
checks that the result falls within specific timing thresholds.

Notice that in the GLES3 specification, there is no requirement for
timing, just a guarantee that "commands [...] complete in finite time".
This is a problem because it makes the test very flaky, for example
if the CPU/GPU clocks are not ramping up fast enough.

BUG=b:67331095
TEST=Ran dEQP-GLES3.functional.flush_finish.finish on Elm for over 3+ hours
     Observed 1.5% to 2% flakiness without this patch. Observed no flakiness
     with this patch.

(cherry picked from commit 59f4fcde5ac1402ab3b911cf6a9f66b886c10464)
Signed-off-by: Gurchetan Singh <gurchetansingh@google.com>
6 years agoFix issues in pipeline.timestamp.transfer_tests
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am: 0f672f2a20

Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e

6 years agoFix issues in pipeline.timestamp.transfer_tests
Pyry Haulos [Thu, 9 Mar 2017 17:46:29 +0000 (09:46 -0800)]
Fix issues in pipeline.timestamp.transfer_tests

This change fixes two issues:

 * Buffer overrun in vkCmdCopyBufferToImage and vkCmdCopyImageToBuffer
tests.

 * Validation error (srcStageMask must not be 0).

VK-GL-CTS issue: 185
Components: Vulkan

Change-Id: I9679566f08c4a914eb6066bab248abd6d51e0f7e

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev
Graeme Leese [Fri, 4 Aug 2017 22:03:02 +0000 (22:03 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev
am: 4f1051ad32

Change-Id: I4f54481292ffaaf5e1cf56a05ef24f7dfa4983f3

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev
Treehugger Robot [Fri, 4 Aug 2017 21:56:36 +0000 (21:56 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev

6 years agoFix atomic ssbo xor test am: f0fa05e898
Mika Isojrvi [Wed, 19 Jul 2017 18:00:27 +0000 (18:00 +0000)]
Fix atomic ssbo xor test am: f0fa05e898
am: 14cd264501

Change-Id: Ib554d7464534203cbcde53f0ebd6931082900a82

6 years agoFix atomic ssbo xor test
Mika Isojrvi [Wed, 19 Jul 2017 17:57:28 +0000 (17:57 +0000)]
Fix atomic ssbo xor test
am: f0fa05e898

Change-Id: Ibc16a0ff1a6b1dbe764d4beafa5d9b63d9c090e9

6 years agoFix atomic ssbo xor test
Mika Isojärvi [Thu, 14 Apr 2016 17:28:16 +0000 (10:28 -0700)]
Fix atomic ssbo xor test

Allow any values in high order bits in xor tests when using uint types.

Bug: 28144118
Change-Id: I0670aa12642882a329cb923487198fdf045b912b

6 years agoMask compared bits in atomic operation tests. am: b2ed9fbe1a
Mika Isojrvi [Wed, 12 Jul 2017 22:53:28 +0000 (22:53 +0000)]
Mask compared bits in atomic operation tests. am: b2ed9fbe1a
am: 4d1d6446da

Change-Id: I9931765924b1102c011bd1d75522f9b4f7089dd2

6 years agoMask compared bits in atomic operation tests.
Mika Isojrvi [Wed, 12 Jul 2017 22:51:27 +0000 (22:51 +0000)]
Mask compared bits in atomic operation tests.
am: b2ed9fbe1a

Change-Id: I2f7b4cfbf2d926966af7c9956db670080771c164

6 years agoFix extension support checks in negative api tests
Graeme Leese [Thu, 23 Feb 2017 16:56:10 +0000 (16:56 +0000)]
Fix extension support checks in negative api tests

Add checks for tessellation and geometry shader support for negative
shader storage and primitive bounding box tests.

Move all uses of cubemap array textures inside the extension checks in
the texture tests.

Bug: 29835218
Change-Id: I6051fff231285ed7d9c71015c2bb11a9fc7b909b
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
6 years agoMask compared bits in atomic operation tests.
Mika Isojärvi [Tue, 5 Apr 2016 17:42:09 +0000 (10:42 -0700)]
Mask compared bits in atomic operation tests.

Bug: 27975797
Change-Id: Id24a784b5b8a665f509218358d58d7eca9a7bb93

7 years agoMerge "Fix color change verification in dithering tests" into nougat-cts-dev
Pyry Haulos [Wed, 3 May 2017 16:07:36 +0000 (16:07 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev
am: acf47d464f

Change-Id: I82bfed0cc9cee128a8552b4e8cf3fb87ced37c9f

7 years agoMerge "Fix color change verification in dithering tests" into nougat-cts-dev
Treehugger Robot [Wed, 3 May 2017 16:04:13 +0000 (16:04 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev

7 years agoMerge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev
Pyry Haulos [Wed, 3 May 2017 16:03:19 +0000 (16:03 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev
am: 9a83ec3f47

Change-Id: I1dfb480ed3b5fb7f384a8fe9b0a852134fde1500

7 years agoMerge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev
Alexander Galazin [Wed, 3 May 2017 16:03:07 +0000 (16:03 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev
am: eebcec1b52

Change-Id: Ib4d673157f82d00d0d27ab3496ac8a1dc6634fe1

7 years agoMerge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev
Treehugger Robot [Wed, 3 May 2017 16:01:05 +0000 (16:01 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev

7 years agoMerge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev
Treehugger Robot [Wed, 3 May 2017 15:59:50 +0000 (15:59 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev

7 years agoTry to determine renderable format in lifetime tests
Pyry Haulos [Wed, 3 May 2017 15:58:34 +0000 (15:58 +0000)]
Try to determine renderable format in lifetime tests
am: c0a5dc217f

Change-Id: I99514ee1a3ccb9a0aa397f0a8e9e7d45b47ec9ba

7 years agoFix error mask generation in checkLineContinuity
Alexander Galazin [Thu, 20 Apr 2017 12:08:44 +0000 (14:08 +0200)]
Fix error mask generation in checkLineContinuity

Even if some pixels are missing the function could return
all-zero errorMask if the messageLimitcounter was exhausted.

Components: AOSP
Affects: dEQP-GLES31.functional.primitive_bounding_box.lines.*

Google bug: 35987764

7 years agoFix color change verification in dithering tests
Pyry Haulos [Tue, 18 Apr 2017 23:13:59 +0000 (16:13 -0700)]
Fix color change verification in dithering tests

Tests were supposed to allow color change once per row/column depending
on gradient direction but instead allowed color change in constant
direction only once over whole image.

Affects:

dEQP-GLES2.functional.dither.disabled.gradient_*
dEQP-GLES3.functional.dither.disabled.gradient_*

Bug: 37477346
Change-Id: I37ef06b4ff527f8c316eae56c8a99c88cdaaf4b4

7 years agoTry to determine renderable format in lifetime tests
Pyry Haulos [Mon, 17 Apr 2017 21:34:27 +0000 (14:34 -0700)]
Try to determine renderable format in lifetime tests

Affects:

dEQP-GLES2.functional.lifetime.attach.deleted_input.renderbuffer_framebuffer
dEQP-GLES2.functional.lifetime.attach.deleted_input.texture_framebuffer
dEQP-GLES2.functional.lifetime.attach.deleted_output.renderbuffer_framebuffer
dEQP-GLES2.functional.lifetime.attach.deleted_output.texture_framebuffer

Bug: 36724173

Change-Id: I46196317c144f294adce65ff4690571d28e1caf3

7 years agoDEPTH_STENCIL_OES as tex format requires OES_depth_texture
Pyry Haulos [Mon, 17 Apr 2017 19:34:26 +0000 (12:34 -0700)]
DEPTH_STENCIL_OES as tex format requires OES_depth_texture

Affects:

dEQP-GLES2.functional.fbo.completeness.*
dEQP-GLES3.functional.fbo.completeness.*

Bug: 36727598
Merged-In: Ic79408c21b80ea458baecf79c042e2694e72e0b2
Change-Id: Ib302b21b2b28d4f13aa6df8bdcac878f22ae51be

7 years agoMerge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev
Ian Romanick [Tue, 11 Apr 2017 17:13:17 +0000 (17:13 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev
am: aeef6dd8f5

Change-Id: I8300511b30c7bd03885a6cb019970852f7e72693

7 years agoMerge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev
Treehugger Robot [Tue, 11 Apr 2017 16:56:42 +0000 (16:56 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev

7 years agoTry harder to defeat GLSL compiler dead-code optimizations
Ian Romanick [Thu, 10 Nov 2016 01:29:01 +0000 (17:29 -0800)]
Try harder to defeat GLSL compiler dead-code optimizations

A number of CTS tests generate shaders like like:

    #version 310 es

    buffer TargetInterface
    {
            highp float target;
    };

    highp vec4 readInputs()
    {
            highp vec4 retValue = vec4(0.0);
            retValue += vec4(float(target));
            return retValue;
    }

    void writeOutputs(in highp vec4 dummyValue)
    {
            target = float(dummyValue.y);
    }

    void main()
    {
            writeOutputs(readInputs());
    }

After various common optimizations this becomes:

    buffer TargetInterface
    {
            highp float target;
    };

    void main()
    {
            target = target;
    }

In the absence of memoryBarrier() or qualifiers on the buffer, there is
no guarantee about the order of writes to the buffer.  Since this write
is not guaranteed to be visible either on the GPU or the CPU, we
eliminate it.  Since there is no access to target in the shader, we
report GL_REFERENCED_BY_FRAGMENT_SHADER = GL_FALSE.  The tests expect
GL_TRUE.

The vectored versions of this test swizzle the value read from the
buffer before writing it back.  These writes are not eliminated.

Adding a uniform instead of a literal constant also prevents the reads
and writes of the SSBO from being eliminated.

v2: Ignore the uniform named "zero" in
ResourceListTestCase::verifyResourceList.  The alternative was to add
zero to the resource list, but that required making small changes
(mostly removing const) from over a dozen places in the code.  This
slightly hacky, but localized, change seemed better.

v3: Various coding standards fixes suggested by Alexander Galazin and
Pyry.  Add getDummyZeroUniformName to query name of the zero uniform and
a lot more documentation.  Both suggested by Pyry.

The following tests are affected:

- dEQP-GLES31.functional.program_interface_query.buffer_variable.random.6
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.compute.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.separable_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_geo_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_geo_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_geo_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_geo_fragment.unnamed_block.float

Change-Id: I867ad32476269ac1272c09672be0a6d6fe37e31e
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16114
Google bug: 37228062

7 years agoFix warning introduced in 2c9e3ec9
Pyry Haulos [Fri, 17 Mar 2017 12:09:41 +0000 (12:09 +0000)]
Fix warning introduced in 2c9e3ec9
am: 521361d83d

Change-Id: I82a9917cb875a166583a41e3d1bb7702ae2d3db8

7 years agoFix warning introduced in 2c9e3ec9
Pyry Haulos [Wed, 15 Mar 2017 19:23:06 +0000 (12:23 -0700)]
Fix warning introduced in 2c9e3ec9

Change-Id: I42bef21b2cc7274f107e5455dea1e382d8a419f4
(cherry picked from commit d8b452a7533c195b1328918bb696a819542ff044)

7 years agoMerge "Further relax line verification in primitive bbox tests" into nougat-cts-dev
Alexander Galazin [Wed, 15 Mar 2017 18:35:35 +0000 (18:35 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev
am: 0532365740

Change-Id: I12be73b76f9ae43955fbca0071f36b897e82f0d9

7 years agoMerge "Further relax line verification in primitive bbox tests" into nougat-cts-dev
Treehugger Robot [Wed, 15 Mar 2017 18:30:21 +0000 (18:30 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev

7 years agoUse glReadnPixels only if KHR_robustness is supported
Alexander Galazin [Wed, 15 Mar 2017 15:22:52 +0000 (15:22 +0000)]
Use glReadnPixels only if KHR_robustness is supported
am: d99ba132d9

Change-Id: Icd032ba51a9c2c6141b21083b300e8709ecd7b45

7 years agoFurther relax line verification in primitive bbox tests
Alexander Galazin [Mon, 6 Mar 2017 18:44:38 +0000 (19:44 +0100)]
Further relax line verification in primitive bbox tests

The original relaxation patch
ba45591407d0207e8ba0634ea5636fd721ed781f
allowed lines to be 1 pixel thinner or thicker compared
to the expected width. Unfortunately it missed the case
of a line with the width of 1 pixel that has extra verification
in the framework. This change covers this gap.

Google bug: 35987764

Change-Id: I193d76ae13738702c9d7361d1957f15ea7600c4f

7 years agoUse glReadnPixels only if KHR_robustness is supported
Alexander Galazin [Thu, 23 Feb 2017 12:01:18 +0000 (13:01 +0100)]
Use glReadnPixels only if KHR_robustness is supported

glReadnPixels is introduced in KHR_robustness/GLES 3.2.
Use of this function in GLES 3.1 tests will result in segfault
on implementations that don't support KHR_robustness.

Components: AOSP, Framework

Affects: dEQP-GLES31.functional.debug.negative_coverage.callbacks.buffer.read_pixels_format_mismatch

VK-GL-CTS issue: 166
Google bug: 36122027

Change-Id: Idbe8734f7d82882ea99c75a8b74d693ac6dd831f
(cherry picked from commit 219019495770c221e92f43df3e76a954c613210d)

7 years agoLimit changes by xor to upper 8 bits in mixed atomic tests
Mika Isojrvi [Thu, 9 Feb 2017 22:41:59 +0000 (22:41 +0000)]
Limit changes by xor to upper 8 bits in mixed atomic tests
am: 6bc3c7a634

Change-Id: I354ee074ad57d53c2b4b0a84d8bc02a02912f19d

7 years agoLimit changes by xor to upper 8 bits in mixed atomic tests
Mika Isojärvi [Wed, 16 Nov 2016 23:10:29 +0000 (15:10 -0800)]
Limit changes by xor to upper 8 bits in mixed atomic tests

Bug: 31270281
Test: Ran tests on multiple devices
Change-Id: I64393591171b304cd071f7a37b91efd2c7a853a6

7 years agoMerge "x11: Call XInitThreads()" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:12:27 +0000 (19:12 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev
am: cbdbf95222

Change-Id: I2531e5a260f50c8bae1a756a61026a46ae253614

7 years agox11: Call XInitThreads()
Chad Versace [Mon, 23 Jan 2017 19:12:25 +0000 (19:12 +0000)]
x11: Call XInitThreads()
am: 5d11c9d2c0

Change-Id: Ib89f9fbfaa7d0b3dcb590fc2ac20ff2c83e3fbad

7 years agoMerge "x11: Fix deadlock" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:12:12 +0000 (19:12 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev
am: 34b869eeea

Change-Id: I5ffe988c3affcd3afeaf3c63b5011e42ef9a4ba1

7 years agox11: Fix deadlock
Chad Versace [Mon, 23 Jan 2017 19:12:10 +0000 (19:12 +0000)]
x11: Fix deadlock
am: 5e863331b2

Change-Id: Ic938e269f89e59fc9ab8b43c97efcb49e0317180

7 years agoMerge "x11: Call XInitThreads()" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:09:19 +0000 (19:09 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev

7 years agoMerge "x11: Fix deadlock" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:06:21 +0000 (19:06 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev

7 years agoCP: Remove two read-backs from copy image tests
Kalle Raita [Sat, 21 Jan 2017 00:23:35 +0000 (00:23 +0000)]
CP: Remove two read-backs from copy image tests
am: 263e135474

Change-Id: I9926edda54ffa5bdb0b5b7f9aeac08aab58237e8

7 years agoCP: Non-compressed copy image target size (64,64,8
Kalle Raita [Sat, 21 Jan 2017 00:23:33 +0000 (00:23 +0000)]
CP: Non-compressed copy image target size (64,64,8
am: 7aff1a044f

Change-Id: I55e1c77eb6558a7a396707cf541d529394be34b7

7 years agox11: Fix deadlock
Chad Versace [Fri, 20 Jan 2017 22:59:10 +0000 (14:59 -0800)]
x11: Fix deadlock

When waiting for a window's MapNotify event, drain only that window's
event queue.  Do NOT drain the global event queue, which includes all
windows' events.

Fixes deadlock in test 'dEQP-EGL.functional.multithread.window_context'
on Mesa master@f57bdd48 with Intel Skylake.

Change-Id: I8c7f2db6c145f59493cb7572b20c4799e9a2cd0a
Depends-On: Ib3b535cec8295e062994fd759ae083c78641cf13

7 years agox11: Call XInitThreads()
Chad Versace [Tue, 27 Dec 2016 21:47:33 +0000 (13:47 -0800)]
x11: Call XInitThreads()

Because the X11 manual says we must.

From man:XInitThreads(3):

  The XInitThreads function initializes Xlib support for concurrent
  threads.  This function must be the first Xlib function
  a multi-threaded program calls, and it must complete before any other
  Xlib call is made.

Fixes crash in multithreaded test:

  Test case 'dEQP-EGL.functional.multithread.window_context'..
  [xcb] Unknown sequence number while processing queue
  [xcb] Most likely this is a multi-threaded client and XInitThreads has not been called
  [xcb] Aborting, sorry about that.
  deqp-egl: xcb_io.c:259: poll_for_event: Assertion `!xcb_xlib_threads_sequence_lost' failed.

Change-Id: Ib3b535cec8295e062994fd759ae083c78641cf13

7 years agoCP: Remove two read-backs from copy image tests
Kalle Raita [Thu, 1 Sep 2016 20:21:50 +0000 (13:21 -0700)]
CP: Remove two read-backs from copy image tests

Cherry pick commit b2fb8ad5ceefe26964101bd403e7786ae83274a9
from master.

Bug: 33965234

Remove two read-backs from copy image tests

Test: Ran copy_image on N6 & N9 with L MR1 image to check for
false-negatives. PixelC and Pixel XL for passing with current OS image.

Change-Id: I9f7028eb550012f8d9abe2f7afee2d1402f5abf3

7 years agoCP: Non-compressed copy image target size (64,64,8
Kalle Raita [Wed, 7 Dec 2016 17:41:41 +0000 (09:41 -0800)]
CP: Non-compressed copy image target size (64,64,8

Cherry-pick commit 8076c97ac0fc706288ef266b0cbe748012c4e0c4 from master:

Non-compressed copy image tests target size reduced to (64,64,8). The
compressed cases retain old size of (128,128,16) to ensure coverage of
all block size combinations.

Bug: 33965234
Test: Run tests on N6 and N9 on L MR 1 with known failures
Change-Id: If22e8722c1de58aa239cf6fe29e79d3bdd13c589

7 years agoMerge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:31:04 +0000 (18:31 +0000)]
Merge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev
am: e98444b9bf

Change-Id: I03190aa34e911cb4a8b174d1251a354ff6e34718

7 years agoRemove tests affected by NV/OES_viewport_array extension
Pyry Haulos [Fri, 20 Jan 2017 18:31:02 +0000 (18:31 +0000)]
Remove tests affected by NV/OES_viewport_array extension
am: 267c765690

Change-Id: I74f0255f38b618d9c72e1e48fabbda9636daf14d

7 years agoMerge "Generate flat triangles in polygon offset tests." into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:30:48 +0000 (18:30 +0000)]
Merge "Generate flat triangles in polygon offset tests." into nougat-cts-dev
am: 61d6d95a66

Change-Id: Ia7141732269df847c13bbb8b36e9f911c76d8753

7 years agoGenerate flat triangles in polygon offset tests.
Alexander Galazin [Fri, 20 Jan 2017 18:30:47 +0000 (18:30 +0000)]
Generate flat triangles in polygon offset tests.
am: 975a59ebca

Change-Id: If91ab1b34f3215705636abaa4dc52ebad5d3d3a7

7 years agoMerge "Relax line width verification in primitive bbox tests" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:30:36 +0000 (18:30 +0000)]
Merge "Relax line width verification in primitive bbox tests" into nougat-cts-dev
am: 312a550657

Change-Id: Ia8465e3ae1fb9d80125305134c157857e5e339b1

7 years agoRelax line width verification in primitive bbox tests
Pyry Haulos [Fri, 20 Jan 2017 18:30:35 +0000 (18:30 +0000)]
Relax line width verification in primitive bbox tests
am: ba45591407

Change-Id: Ia0f71e5511d1bf4bf449ef71ecf5bb822311cf08

7 years agoMerge "Fix eglBindAPI negative test" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:30:23 +0000 (18:30 +0000)]
Merge "Fix eglBindAPI negative test" into nougat-cts-dev
am: 6068dfbf3a

Change-Id: I4ca862cbe3c17c0887437a98570f16e1bfc19d34

7 years agoFix eglBindAPI negative test
Nicolas Boichat [Fri, 20 Jan 2017 18:30:22 +0000 (18:30 +0000)]
Fix eglBindAPI negative test
am: 09784f8510

Change-Id: I9f1246736de39cfc6bc6593bad465fa881f55e29

7 years agoMerge "Drop incorrect framebuffer texture subtests." into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:30:11 +0000 (18:30 +0000)]
Merge "Drop incorrect framebuffer texture subtests." into nougat-cts-dev
am: 3baf7e3be2

Change-Id: I2f95c748059d7aea5f1899ff6ee6c0fe96ea7245

7 years agoDrop incorrect framebuffer texture subtests.
Kenneth Graunke [Fri, 20 Jan 2017 18:30:10 +0000 (18:30 +0000)]
Drop incorrect framebuffer texture subtests.
am: 625d685874

Change-Id: I7b1cab296c2a61ed3e05ae52dd21fd62bc6d3c8a

7 years agoMerge "Optimize swapchain OOM tests" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:29:58 +0000 (18:29 +0000)]
Merge "Optimize swapchain OOM tests" into nougat-cts-dev
am: c811d42d99

Change-Id: I06e852cc34ee156dbd66ac36fbb052a2db8ec36f

7 years agoOptimize swapchain OOM tests
Pyry Haulos [Fri, 20 Jan 2017 18:29:57 +0000 (18:29 +0000)]
Optimize swapchain OOM tests
am: 1614827a71

Change-Id: I5ac33602999153d04624eb32504437ffff9b3b51

7 years agoMerge "Fix internal format/type for ES3 3D + depth/stencil negative API tests." into...
Tina Zhou [Fri, 20 Jan 2017 18:29:46 +0000 (18:29 +0000)]
Merge "Fix internal format/type for ES3 3D + depth/stencil negative API tests." into nougat-cts-dev
am: 0991459ed1

Change-Id: If9f75801b7ea26bec470e4dd11b318431ed56352

7 years agoFix internal format/type for ES3 3D + depth/stencil negative API tests.
Kenneth Graunke [Fri, 20 Jan 2017 18:29:45 +0000 (18:29 +0000)]
Fix internal format/type for ES3 3D + depth/stencil negative API tests.
am: 2ed3a5a66f

Change-Id: I9439b037614e52368b771e1b7a84bd4930bfbf6a

7 years agoMerge "Add support for EGL_EXT_pixel_format_float" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:29:33 +0000 (18:29 +0000)]
Merge "Add support for EGL_EXT_pixel_format_float" into nougat-cts-dev
am: 13a05434cc

Change-Id: Ic956c9c223aef327c2614b3f52ecf5c1166bec22

7 years agoAdd support for EGL_EXT_pixel_format_float
Mark Adams [Fri, 20 Jan 2017 18:29:32 +0000 (18:29 +0000)]
Add support for EGL_EXT_pixel_format_float
am: 521bf8a7c3

Change-Id: I64bda78561b2eb598e78bb2ba13b485602ea96e7

7 years agoMerge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:49 +0000 (18:28 +0000)]
Merge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev

7 years agoMerge "Generate flat triangles in polygon offset tests." into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:42 +0000 (18:28 +0000)]
Merge "Generate flat triangles in polygon offset tests." into nougat-cts-dev

7 years agoMerge "Relax line width verification in primitive bbox tests" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:34 +0000 (18:28 +0000)]
Merge "Relax line width verification in primitive bbox tests" into nougat-cts-dev

7 years agoMerge "Fix eglBindAPI negative test" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:26 +0000 (18:28 +0000)]
Merge "Fix eglBindAPI negative test" into nougat-cts-dev

7 years agoMerge "Drop incorrect framebuffer texture subtests." into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:18 +0000 (18:28 +0000)]
Merge "Drop incorrect framebuffer texture subtests." into nougat-cts-dev

7 years agoMerge "Optimize swapchain OOM tests" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:27:50 +0000 (18:27 +0000)]
Merge "Optimize swapchain OOM tests" into nougat-cts-dev

7 years agoMerge "Fix internal format/type for ES3 3D + depth/stencil negative API tests." into...
Tina Zhou [Fri, 20 Jan 2017 18:27:40 +0000 (18:27 +0000)]
Merge "Fix internal format/type for ES3 3D + depth/stencil negative API tests." into nougat-cts-dev

7 years agoMerge "Add support for EGL_EXT_pixel_format_float" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:27:14 +0000 (18:27 +0000)]
Merge "Add support for EGL_EXT_pixel_format_float" into nougat-cts-dev

7 years agoRemove tests affected by NV/OES_viewport_array extension
Pyry Haulos [Wed, 18 Jan 2017 20:28:32 +0000 (12:28 -0800)]
Remove tests affected by NV/OES_viewport_array extension

Tests were not properly taking into account viewport clamping behavior
introduced by GL_NV/OES_viewport_array extensions.

Bug: 34349411
Change-Id: I3eae36359e6408191e0fbefb20cededec2a5bd39
Merged-In: I3d3c2e32d7dd96d1db960aa53dc18cc690187ec0

7 years agoGenerate flat triangles in polygon offset tests.
Alexander Galazin [Wed, 11 Jan 2017 07:50:13 +0000 (08:50 +0100)]
Generate flat triangles in polygon offset tests.

The tests setup triangles with a depth slope and then call
glPolygonOffset(factor, units) with variable units and
always 0 slope scaled factor.

According to the GLES 3.2 spec 13.7.2 Depth Offset:
"void PolygonOffset( float factor, float units );
factor scales the maximum depth slope of the polygon, and units scales an
implementation-dependent constant that relates to the usable resolution of the
depth buffer."

If the polygon has a depth slope,
the depth slope factor has to be not equal to zero.
The rationale of the slope scaled factor is to ensure that the offset
(equation 13.11) is greater than max(dz/dx, dz/dy) for all resolutions,
which may not be the case for the constant offset since it doesn't take
the screen resolution into account.

Changed tests:

dEQP-GLES2.functional.polygon_offset.*_displacement_with_units
dEQP-GLES3.functional.polygon_offset.*_displacement_with_units

Bug: 34386628

Change-Id: Ie8009ba1766eb50c3c5a750122aa8bb231144210

7 years agoDrop incorrect framebuffer texture subtests.
Kenneth Graunke [Fri, 6 Jan 2017 08:25:28 +0000 (00:25 -0800)]
Drop incorrect framebuffer texture subtests.

This patch removes two broken subcases of:
dEQP-GLES31.functional.debug.negative_coverage.log.buffer.framebuffer_texture_layer

These were fixed in dEQP master by commit f28187809176f5eeb1ee25ccfa70d3,
but we cannot backport that to release branches because it changes the
existing expectations, which would break previously passing
implementations.  See buganizer 30287182 and 28090252.

The first subtest incorrectly checked layer (array slice) when it should
have checked miplevel.  The subtest description says:

"GL_INVALID_VALUE is generated if texture is a 2D multisample array
 texture and layer not 0."

which is wrong - array textures can certainly have multiple slices.
The ES 3.1 specification says that:

"An INVALID_VALUE error is generated if texture is not zero and level is
 not a supported texture level for texture, as described above."

and miplevel 0 is the only valid miplevel for a multisample texture.

The second subtest is no longer valid according to the resolution of
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15968.

Bug: 34281627
Merged-In: I500074c1777d88291c0b395498bb0f7d5613d27d

7 years agoRelax line width verification in primitive bbox tests
Pyry Haulos [Tue, 15 Nov 2016 18:28:48 +0000 (10:28 -0800)]
Relax line width verification in primitive bbox tests

Originally contributed by ARM to Khronos OpenGL ES CTS. Cherry-picked
with permission.

Google bug: 22713865
Khronos OpenGL issue: #19

Change-Id: I95359847611144e179819aaab6ac5dfe4bf4e4da

7 years agoSkip commit '302bd7c6b3d468e33b19b693a25d67f2b54b961c' on
Xin Li [Thu, 12 Jan 2017 23:21:25 +0000 (15:21 -0800)]
Skip commit '302bd7c6b3d468e33b19b693a25d67f2b54b961c' on
nougat-mr1-cts-dev.

BUG: 33090058
Change-Id: Ife934b6694e07b2231070cc5d05865fed78e67c4

7 years agoMerge commit '09e8b66d03077e9a9b310145112cfd0e747e06f3' from
Xin Li [Thu, 12 Jan 2017 23:09:38 +0000 (15:09 -0800)]
Merge commit '09e8b66d03077e9a9b310145112cfd0e747e06f3' from
nougat-cts-dev to nougat-cts-mr1-dev.

BUG: 33090058
Change-Id: I7a8bacd16b5d98255987c5632e73dd823d8643be

7 years agoOptimize swapchain OOM tests
Pyry Haulos [Wed, 4 Jan 2017 22:30:07 +0000 (14:30 -0800)]
Optimize swapchain OOM tests

Swapchain OOM tests were hitting timeouts on some platforms. This commit
optimizes the tests in two ways:

 * VkInstance, VkDevice, and VkSurface are now re-used across all
sub-cases.

 * Loop is re-written to avoid re-creating swapchains for parameters
0..N-1 when testing parameter combination N.

Affects: dEQP-VK.wsi.*.swapchain.simulate_oom.*

Bug: 33555898
(cherry picked from commit 2beac9057d9113ac306632d819ded852691a6842)

Change-Id: I19e9c7c8012a82cd12322a733afab961f4c7a1ae

7 years agoFix internal format/type for ES3 3D + depth/stencil negative API tests.
Kenneth Graunke [Mon, 12 Sep 2016 19:37:08 +0000 (12:37 -0700)]
Fix internal format/type for ES3 3D + depth/stencil negative API tests.

This is a port of commit ae7f8e0a07730e693b24d3dc7a23d2372319145e from
the ES 3.1 tests to the ES 3.0 tests.

According to the ES 3.2 specification:

   "Textures with a base internal format of DEPTH_COMPONENT, DEPTH_STENCIL
    or STENCIL_INDEX are supported by texture image specification commands
    only if target is TEXTURE_2D, TEXTURE_2D_MULTISAMPLE, TEXTURE_2D_ARRAY,
    TEXTURE_2D_MULTISAMPLE_ARRAY, TEXTURE_CUBE_MAP or TEXTURE_CUBE_MAP_ARRAY.
    Using these formats in conjunction with any other target will result in
    an INVALID_OPERATION error."

This subtest tried to check the above error condition, but it specified
GL_DEPTH_STENCIL / GL_DEPTH_COMPONENT as format, rather than internalFormat.
Since the above text calls out "base internal format", we should specify
it as internalFormat.

We also change GL_DEPTH_STENCIL to use GL_UNSIGNED_INT_24_8 rather than
GL_UNSIGNED_BYTE, as that combination was illegal for a different reason
than the one the test intended to check.

Affects dEQP-GLES3.functional.negative_api.texture.teximage3d.

Bug: 34103293

Change-Id: Ie01e2d130bb1cadc821153487e3e41593e3ca15e

7 years agoFix eglBindAPI negative test
Nicolas Boichat [Sun, 18 Dec 2016 16:13:28 +0000 (00:13 +0800)]
Fix eglBindAPI negative test

It is ok for an implementation to not fail eglBindAPI if the current
display does not support the specified client API. However, in that
case, getConfig must not return any configuration for that specific
API.

Bug: 33278378
Affects: dEQP-EGL.functional.negative_api.bind_api
Test: Deploy to elm Chromebook, run with Cherry, test passes.
Change-Id: Idb86971de7a30e1aa78bb0951f971ed2829e2794

7 years agoAdd support for EGL_EXT_pixel_format_float
Mark Adams [Wed, 14 Dec 2016 22:02:52 +0000 (17:02 -0500)]
Add support for EGL_EXT_pixel_format_float

This updates the egl.xml version and identifies/skips the float configs

Bug: 32969314
Change-Id: Iacfdf6b1c32c86ea0e6f80ca7ebaaeef583d1135
Merged-In: Iadeb0d4a76a06b2be716f3e76a1cc9fb69aff16a

7 years agoDO NOT MERGE: Remove changed texel buffer access tests from mustpass
Pyry Haulos [Wed, 4 Jan 2017 16:20:43 +0000 (08:20 -0800)]
DO NOT MERGE: Remove changed texel buffer access tests from mustpass

NYC CTS bug-fix changes the SPIR-V for these tests causing drivers that
passed old CTS fail the new version.

Bug: 33041922
Change-Id: I7e23a700693d5e6ee7c4264e05d449f49f820516

7 years agoDO NOT MERGE: Remove a few changed Vulkan tests from mustpass
Pyry Haulos [Wed, 4 Jan 2017 00:45:19 +0000 (16:45 -0800)]
DO NOT MERGE: Remove a few changed Vulkan tests from mustpass

Original NYC CTS was decorating struct member locations differently and
this was later fixed causing drivers that pass original NYC CTS fail.

Bug: 34060750
Bug: 33041922
Change-Id: I3fe33960a74fb8f568aa7e1327bc09de8bc3df41

7 years agoMerge "Blacklist match_different_[member_]struct_names SSO validation tests." into...
Tina Zhou [Wed, 21 Dec 2016 22:32:08 +0000 (22:32 +0000)]
Merge "Blacklist match_different_[member_]struct_names SSO validation tests." into nougat-cts-dev

7 years agoMerge "Change GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048" into nougat...
Tina Zhou [Wed, 21 Dec 2016 22:31:04 +0000 (22:31 +0000)]
Merge "Change GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048" into nougat-cts-dev

7 years agoMerge changes I7c2ffd66,Ib53b245d,I4862cca3 into nougat-cts-dev
Tina Zhou [Wed, 21 Dec 2016 22:30:03 +0000 (22:30 +0000)]
Merge changes I7c2ffd66,Ib53b245d,I4862cca3 into nougat-cts-dev

* changes:
  Update glslang to d02dc5d
  Cherry-pick SPIR-V ClipDistance validation fixes
  Cherry-pick dEQP-VK.pipeline.cache fixes to nougat-cts-dev

7 years agoGetDevices: Also allow `\.` to be part of the host name
Nicolas Boichat [Tue, 20 Dec 2016 18:55:24 +0000 (18:55 +0000)]
GetDevices: Also allow `\.` to be part of the host name
am: dbf9715509

Change-Id: I659ce579867c7ca0c9b47e3b53a734265e0fbb26

7 years agoBlacklist match_different_[member_]struct_names SSO validation tests.
Kenneth Graunke [Thu, 8 Dec 2016 22:09:31 +0000 (14:09 -0800)]
Blacklist match_different_[member_]struct_names SSO validation tests.

This patch blacklists the following tests:

- dEQP-GLES31.functional.separate_shader.validation.varying.match_different_struct_names
- dEQP-GLES31.functional.separate_shader.validation.io_blocks.match_different_member_struct_names

The resolution of Khronos bug #15866 is that the spec should be changed
to require that "structures have the same name" in order for the types
to match during SSO validation.  These structures differ in name,
so they should not match, and we should get an SSO validation failure.

See https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15866 and Khronos
legacy CTS commit 1607a3ce7caa5736471fb460d08130e62d689351.

Bug: 33457655

7 years agoGetDevices: Also allow `\.` to be part of the host name
Nicolas Boichat [Wed, 30 Nov 2016 04:14:52 +0000 (12:14 +0800)]
GetDevices: Also allow `\.` to be part of the host name

Useful when connecting over TCP to a device with a given IP.

Change-Id: Ibe3b75e5ba3ab0ff90219bb31d45e21d8f5fd61b

7 years agoUpdate glslang to d02dc5d
Pyry Haulos [Tue, 29 Nov 2016 23:24:17 +0000 (15:24 -0800)]
Update glslang to d02dc5d

Bug: 33041922

(cherry picked from commit 4e1f56d2457e0c8736e3e92c48bd8df0c309d600)

Change-Id: I7c2ffd66f55cafa402ffc7a0222973e282f4825f

7 years agoCherry-pick SPIR-V ClipDistance validation fixes
Pyry Haulos [Wed, 23 Nov 2016 00:13:32 +0000 (16:13 -0800)]
Cherry-pick SPIR-V ClipDistance validation fixes

These fixes are needed in order for SPIR-V validation to pass when
shaders are compiled with a newer glslang version.

Bug: 33041922

Explicitly declare gl_PerVertex block

This fixes SPIR-V validation error in shaders generated from GLSL (not ES)
due to missing ClipDistance capability.

(cherry picked from commit 0a6fe1448b303a6a4e4ab48712eaf1c0b16d75b1)

Explicitly declare gl_PerVertex in push constant tests

(cherry picked from commit cba5d02d184b771bc4a21b8aecbbde3377d86167)

Change tes/geom shaders in timestamp tests use 310 es

Vertex and fragment shaders were already using that GLSL version.

(cherry picked from commit d47309690aa9b2e685b267ea6395e88b32c855a8)

Change ubo and ssbo tests to use 310 es shaders

(cherry picked from commit 4d36051923691c5f92cf3615e82d30d54ed3b09b)

Explicitly declare gl_PerVertex in dynamic viewport state tests

(cherry picked from commit 816c46d518d08a4ff321ca93780f2786fa86ba60)

Explicitly declare gl_PerVertex in occlusion query tests

(cherry picked from commit a1257f69aa6008d4e5a22148a43d59692eb24822)

Change-Id: Ib53b245d25c6cbc345a88e8b247f01ac7cf8a541

7 years agoCherry-pick dEQP-VK.pipeline.cache fixes to nougat-cts-dev
Pyry Haulos [Mon, 21 Nov 2016 23:54:55 +0000 (15:54 -0800)]
Cherry-pick dEQP-VK.pipeline.cache fixes to nougat-cts-dev

Bug: 33041922

Validation fixes in dEQP-VK.pipeline

- Corrected out of range minDepthBounds value
- Added missing image layout transitions
- timestamp, cache tests: pass data through geometry shader
- cache test: use correct initialLayout in attachment when starting
  a second render pass

(cherry picked from commit 1d3585c5ec71cf90d6519913db6a01ef2c0f840c)

Fix use of out-of-scope struct in pipeline cache tests

Fixes #363

(cherry picked from commit 1ec71c633e5755a1932c1da7692aef69b66999db)

Pipeline cache test: fix SPIRV validation error

(cherry picked from commit 89cce75bae9beb123311281386fb59b8da59052b)

Change-Id: I4862cca352955c33d04540f2f881760f4e4ffd65

7 years agoChange GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048
Pyry Haulos [Tue, 15 Nov 2016 18:34:57 +0000 (10:34 -0800)]
Change GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048

Google bug: 33105204
Khronos bug: 12823

(cherry picked from commit fe6bb67987a4d7fc59739c878e658f2a6d071cde)

Change-Id: I56fcc4ce527c31e48004c43e43e2ec994675e1b4

7 years agoMerge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmal...
Tina Zhou [Thu, 17 Nov 2016 17:10:28 +0000 (17:10 +0000)]
Merge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmallow-cts-dev
am: a5af1b076f

Change-Id: I01c65d693d7ad5befe9244cb0d24814750a80bd2

7 years agoFix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA.
Kenneth Graunke [Thu, 17 Nov 2016 17:10:28 +0000 (17:10 +0000)]
Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA.
am: ea5589c748

Change-Id: I7358276f100608371da5b44ebc8e102a54706197

7 years agoMerge "Fix internal format/type for 3D + depth/stencil negative API tests." into...
Tina Zhou [Thu, 17 Nov 2016 17:10:12 +0000 (17:10 +0000)]
Merge "Fix internal format/type for 3D + depth/stencil negative API tests." into marshmallow-cts-dev
am: d962b86909

Change-Id: I6a82d71f2fed9f848a953ae21c30079bacb07052

7 years agoFix internal format/type for 3D + depth/stencil negative API tests.
Kenneth Graunke [Thu, 17 Nov 2016 17:10:05 +0000 (17:10 +0000)]
Fix internal format/type for 3D + depth/stencil negative API tests.
am: d2f3b468db

Change-Id: Id43b369d67e04cf3a6d6b5b4e3303f02c7a35b87

7 years agoMerge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmal...
Tina Zhou [Thu, 17 Nov 2016 17:03:36 +0000 (17:03 +0000)]
Merge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmallow-cts-dev

7 years agoMerge "Fix internal format/type for 3D + depth/stencil negative API tests." into...
Tina Zhou [Thu, 17 Nov 2016 17:02:44 +0000 (17:02 +0000)]
Merge "Fix internal format/type for 3D + depth/stencil negative API tests." into marshmallow-cts-dev

7 years agoMerge "Add the support to device connection via TCP/IP" into marshmallow-cts-dev
Tina Zhou [Thu, 17 Nov 2016 00:43:40 +0000 (00:43 +0000)]
Merge "Add the support to device connection via TCP/IP" into marshmallow-cts-dev
am: 6cea9dbc62

Change-Id: I3525d88dbc3e04b702cef54d1759f406222047b2