dm: uclass: don't assign aliased seq numbers
authorMichael Walle <michael@walle.cc>
Mon, 1 Jun 2020 23:47:09 +0000 (01:47 +0200)
committerSimon Glass <sjg@chromium.org>
Fri, 12 Jun 2020 02:52:11 +0000 (20:52 -0600)
commitbe1a6e94254af205bd67d69e3bdb26b161ccd72f
tree5bff9218c993494bbb5cbfa8d817b31f2c13d682
parent0a6b75f7d8cbf7edc62c7d132b521703f1e2a53d
dm: uclass: don't assign aliased seq numbers

If there are aliases for an uclass, set the base for the "dynamically"
allocated numbers next to the highest alias.

Please note, that this might lead to holes in the sequences, depending
on the device tree. For example if there is only an alias "ethernet1",
the next device seq number would be 2.

In particular this fixes a problem with boards which are using ethernet
aliases but also might have network add-in cards like the E1000. If the
board is started with the add-in card and depending on the order of the
drivers, the E1000 might occupy the first ethernet device and mess up
all the hardware addresses, because the devices are now shifted by one.

Also adapt the test cases to the new handling and add test cases
checking the holes in the seq numbers.

Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Alex Marginean <alexandru.marginean@nxp.com>
Tested-by: Alex Marginean <alexandru.marginean@nxp.com>
Acked-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Michal Simek <michal.simek@xilinx.com> [on zcu102-revA]
arch/sandbox/dts/test.dts
drivers/core/uclass.c
include/configs/sandbox.h
test/dm/eth.c
test/dm/test-fdt.c