From 06f031f6ebb6a68de286405f67283ce964130754 Mon Sep 17 00:00:00 2001 From: Hosung Kim Date: Fri, 14 Jul 2023 13:30:18 +0900 Subject: [PATCH] fix: fix build break on gcc13 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Change-Id: Ia80c76cf98dc5dd8ab435eb03a3d80845731341e Signed-off-by: Hosung Kim hs852.kim@samsung.com --- src/api-exception.cc | 10 ++++------ src/api-handles.cc | 31 ++++++++++++------------------- src/api/engine.h | 2 +- src/api/utils/logger/logger-impl.cc | 2 +- src/api/utils/sf-vector.h | 3 --- 5 files changed, 18 insertions(+), 30 deletions(-) diff --git a/src/api-exception.cc b/src/api-exception.cc index 449aef3..e3e48dd 100644 --- a/src/api-exception.cc +++ b/src/api-exception.cc @@ -82,18 +82,16 @@ v8::TryCatch::~TryCatch() { } void* v8::TryCatch::operator new(size_t) { - LWNODE_UNIMPLEMENT; - return new TryCatch(nullptr); + std::abort(); } void* v8::TryCatch::operator new[](size_t) { - LWNODE_UNIMPLEMENT; - return new TryCatch(nullptr); + std::abort(); } void v8::TryCatch::operator delete(void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } void v8::TryCatch::operator delete[](void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } bool v8::TryCatch::HasCaught() const { diff --git a/src/api-handles.cc b/src/api-handles.cc index 71d99ef..4beacb3 100644 --- a/src/api-handles.cc +++ b/src/api-handles.cc @@ -43,19 +43,16 @@ HandleScope::~HandleScope() { } void* HandleScope::operator new(size_t) { - LWNODE_UNIMPLEMENT; - // TODO: abort : only stack is available - return new HandleScope(nullptr); + std::abort(); } void* HandleScope::operator new[](size_t) { - LWNODE_UNIMPLEMENT; - return new HandleScope(nullptr); + std::abort(); } void HandleScope::operator delete(void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } void HandleScope::operator delete[](void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } int HandleScope::NumberOfHandles(Isolate* isolate) { @@ -120,18 +117,16 @@ i::Address* EscapableHandleScope::Escape(i::Address* escape_value) { } void* EscapableHandleScope::operator new(size_t) { - LWNODE_UNIMPLEMENT; - return new EscapableHandleScope(nullptr); + std::abort(); } void* EscapableHandleScope::operator new[](size_t) { - LWNODE_UNIMPLEMENT; - return new EscapableHandleScope(nullptr); + std::abort(); } void EscapableHandleScope::operator delete(void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } void EscapableHandleScope::operator delete[](void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } SealHandleScope::SealHandleScope(Isolate* isolate) @@ -147,18 +142,16 @@ SealHandleScope::~SealHandleScope() { } void* SealHandleScope::operator new(size_t) { - LWNODE_UNIMPLEMENT; - return new SealHandleScope(nullptr); + std::abort(); } void* SealHandleScope::operator new[](size_t) { - LWNODE_UNIMPLEMENT; - return new SealHandleScope(nullptr); + std::abort(); } void SealHandleScope::operator delete(void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } void SealHandleScope::operator delete[](void*, size_t) { - LWNODE_UNIMPLEMENT; + std::abort(); } void Context::Enter() { diff --git a/src/api/engine.h b/src/api/engine.h index 6a99b63..a6cd0a1 100644 --- a/src/api/engine.h +++ b/src/api/engine.h @@ -88,7 +88,7 @@ class GCHeap : public gc { void* data = nullptr; }; typedef GC_word GC_heap_pointer; - typedef std::pair HeapSegment; + typedef std::pair HeapSegment; void acquire(void* address, Kind kind, void* data); void release(void* address, Kind kind); diff --git a/src/api/utils/logger/logger-impl.cc b/src/api/utils/logger/logger-impl.cc index a1e88b2..f6a80dd 100644 --- a/src/api/utils/logger/logger-impl.cc +++ b/src/api/utils/logger/logger-impl.cc @@ -167,7 +167,7 @@ Logger& Logger::flush() { void StdOut::flush(std::stringstream& stream, std::shared_ptr config) { - std::cerr << stream.str(); + fprintf(stdout, "%s", stream.str().c_str()); } // --- Option --- diff --git a/src/api/utils/sf-vector.h b/src/api/utils/sf-vector.h index 04395a2..941cd05 100644 --- a/src/api/utils/sf-vector.h +++ b/src/api/utils/sf-vector.h @@ -148,7 +148,6 @@ class Vector { void erase(size_t start, size_t end) { if (start == end) return; - assert(start >= 0); assert(end <= m_size); size_t howMuch = end - start; @@ -351,7 +350,6 @@ class Vector { size_t end = start + sizeToErase; assert(start < end); - assert(start >= 0); assert(end <= m_size); size_t c = end - start; @@ -384,7 +382,6 @@ class Vector { size_t end = start + sizeToErase; assert(start < end); - assert(start >= 0); assert(end <= m_size); size_t c = end - start; -- 2.7.4