#include "base/compiler_specific.h"
#include "ui/gl/gl_bindings.h"
#include "ui/gl/gl_context.h"
+#include "ui/gl/gl_version_info.h"
namespace {
// We will arbitrarily return TRUE for consistency.
glGenFencesNV(1, &fence_);
glSetFenceNV(fence_, GL_ALL_COMPLETED_NV);
- if (flush)
+ if (flush) {
glFlush();
+ } else {
+ flush_event_ = gfx::GLContext::GetCurrent()->SignalFlush();
+ }
}
virtual bool HasCompleted() OVERRIDE {
}
virtual void ClientWait() OVERRIDE {
- glFinishFenceNV(fence_);
+ if (!flush_event_ || flush_event_->IsSignaled()) {
+ glFinishFenceNV(fence_);
+ } else {
+ LOG(ERROR) << "Trying to wait for uncommitted fence. Skipping...";
+ }
}
virtual void ServerWait() OVERRIDE {
- glFinishFenceNV(fence_);
+ ClientWait();
}
private:
}
GLuint fence_;
+ scoped_refptr<gfx::GLContext::FlushEvent> flush_event_;
};
class GLFenceARBSync: public gfx::GLFence {
public:
GLFenceARBSync(bool flush) {
sync_ = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
- if (flush)
+ if (flush) {
glFlush();
+ } else {
+ flush_event_ = gfx::GLContext::GetCurrent()->SignalFlush();
+ }
}
virtual bool HasCompleted() OVERRIDE {
}
virtual void ClientWait() OVERRIDE {
- glClientWaitSync(sync_, GL_SYNC_FLUSH_COMMANDS_BIT, GL_TIMEOUT_IGNORED);
+ if (!flush_event_ || flush_event_->IsSignaled()) {
+ glClientWaitSync(sync_, GL_SYNC_FLUSH_COMMANDS_BIT, GL_TIMEOUT_IGNORED);
+ } else {
+ LOG(ERROR) << "Trying to wait for uncommitted fence. Skipping...";
+ }
}
virtual void ServerWait() OVERRIDE {
- glWaitSync(sync_, 0, GL_TIMEOUT_IGNORED);
+ if (!flush_event_ || flush_event_->IsSignaled()) {
+ glWaitSync(sync_, 0, GL_TIMEOUT_IGNORED);
+ } else {
+ LOG(ERROR) << "Trying to wait for uncommitted fence. Skipping...";
+ }
}
private:
}
GLsync sync_;
+ scoped_refptr<gfx::GLContext::FlushEvent> flush_event_;
};
#if !defined(OS_MACOSX)
EGLFenceSync(bool flush) {
display_ = eglGetCurrentDisplay();
sync_ = eglCreateSyncKHR(display_, EGL_SYNC_FENCE_KHR, NULL);
- if (flush)
+ if (flush) {
glFlush();
+ } else {
+ flush_event_ = gfx::GLContext::GetCurrent()->SignalFlush();
+ }
}
virtual bool HasCompleted() OVERRIDE {
}
virtual void ClientWait() OVERRIDE {
- EGLint flags = 0;
- EGLTimeKHR time = EGL_FOREVER_KHR;
- eglClientWaitSyncKHR(display_, sync_, flags, time);
+ if (!flush_event_ || flush_event_->IsSignaled()) {
+ EGLint flags = 0;
+ EGLTimeKHR time = EGL_FOREVER_KHR;
+ eglClientWaitSyncKHR(display_, sync_, flags, time);
+ } else {
+ LOG(ERROR) << "Trying to wait for uncommitted fence. Skipping...";
+ }
}
virtual void ServerWait() OVERRIDE {
- EGLint flags = 0;
- eglWaitSyncKHR(display_, sync_, flags);
+ if (!flush_event_ || flush_event_->IsSignaled()) {
+ EGLint flags = 0;
+ eglWaitSyncKHR(display_, sync_, flags);
+ } else {
+ LOG(ERROR) << "Trying to wait for uncommitted fence. Skipping...";
+ }
}
EGLSyncKHR sync_;
EGLDisplay display_;
+ scoped_refptr<gfx::GLContext::FlushEvent> flush_event_;
};
#endif // !OS_MACOSX
// static
gfx::GLFence* CreateFence(bool flush) {
+ DCHECK(gfx::GLContext::GetCurrent())
+ << "Trying to create fence with no context";
+
+ // Prefer ARB_sync which supports server-side wait.
+ if (gfx::g_driver_gl.ext.b_GL_ARB_sync ||
+ gfx::GLContext::GetCurrent()->GetVersionInfo()->is_es3)
+ return new GLFenceARBSync(flush);
#if !defined(OS_MACOSX)
if (gfx::g_driver_egl.ext.b_EGL_KHR_fence_sync)
return new EGLFenceSync(flush);
#endif
- // Prefer ARB_sync which supports server-side wait.
- if (gfx::g_driver_gl.ext.b_GL_ARB_sync)
- return new GLFenceARBSync(flush);
if (gfx::g_driver_gl.ext.b_GL_NV_fence)
return new GLFenceNVFence(flush);
return NULL;