void AddDelayedSocketDataToFactory(MockClientSocketFactory* factory,
size_t delay) {
- MockRead* reads = reads_.empty() ? NULL : &reads_[0];
- MockWrite* writes = writes_.empty() ? NULL : &writes_[0];
+ MockRead* reads = reads_.empty() ? nullptr : &reads_[0];
+ MockWrite* writes = writes_.empty() ? nullptr : &writes_[0];
socket_data_.reset(new DelayedSocketData(
delay, reads, reads_.size(), writes, writes_.size()));
factory->AddSocketDataProvider(socket_data_.get());
auth_handler_factory_(
HttpAuthHandlerFactory::CreateDefault(&host_resolver_)),
random_generator_(0),
- hanging_data_(NULL, 0, NULL, 0) {
+ hanging_data_(nullptr, 0, nullptr, 0) {
request_.method = "GET";
request_.url = GURL("http://www.google.com/");
request_.load_flags = 0;
clock_->AdvanceTime(QuicTime::Delta::FromMilliseconds(20));
}
- virtual void SetUp() {
+ void SetUp() override {
NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests();
base::MessageLoop::current()->RunUntilIdle();
}
- virtual void TearDown() {
+ void TearDown() override {
NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests();
// Empty the current queue.
base::MessageLoop::current()->RunUntilIdle();
if (use_next_protos) {
params_.use_alternate_protocols = true;
- params_.next_protos = NextProtosSpdy3();
+ params_.next_protos = NextProtosWithSpdyAndQuic(true, true);
}
session_ = new HttpNetworkSession(params_);
void CheckWasQuicResponse(const scoped_ptr<HttpNetworkTransaction>& trans) {
const HttpResponseInfo* response = trans->GetResponseInfo();
- ASSERT_TRUE(response != NULL);
- ASSERT_TRUE(response->headers.get() != NULL);
+ ASSERT_TRUE(response != nullptr);
+ ASSERT_TRUE(response->headers.get() != nullptr);
EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine());
EXPECT_TRUE(response->was_fetched_via_spdy);
EXPECT_TRUE(response->was_npn_negotiated);
void CheckWasHttpResponse(const scoped_ptr<HttpNetworkTransaction>& trans) {
const HttpResponseInfo* response = trans->GetResponseInfo();
- ASSERT_TRUE(response != NULL);
- ASSERT_TRUE(response->headers.get() != NULL);
+ ASSERT_TRUE(response != nullptr);
+ ASSERT_TRUE(response->headers.get() != nullptr);
EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine());
EXPECT_FALSE(response->was_fetched_via_spdy);
EXPECT_FALSE(response->was_npn_negotiated);
const AlternateProtocolInfo alternate =
session_->http_server_properties()->GetAlternateProtocol(
HostPortPair::FromURL(request_.url));
- EXPECT_EQ(ALTERNATE_PROTOCOL_BROKEN, alternate.protocol);
+ EXPECT_TRUE(alternate.is_broken);
}
void ExpectQuicAlternateProtocolMapping() {
MockRead(ASYNC, OK)
};
- StaticSocketDataProvider data(http_reads, arraysize(http_reads), NULL, 0);
+ StaticSocketDataProvider data(http_reads, arraysize(http_reads), nullptr, 0);
socket_factory_.AddSocketDataProvider(&data);
SSLSocketDataProvider ssl(ASYNC, OK);
socket_factory_.AddSSLSocketDataProvider(&ssl);
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
MockQuicData mock_quic_data;
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
MockQuicData mock_quic_data;
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
socket_factory_.AddSocketDataProvider(&http_data);
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
socket_factory_.AddSocketDataProvider(&http_data);
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
MockQuicData mock_quic_data;
DEFAULT_PRIORITY,
&address,
CompletionCallback(),
- NULL,
+ nullptr,
net_log_.bound());
CreateSessionWithNextProtos();
DEFAULT_PRIORITY,
&address,
CompletionCallback(),
- NULL,
+ nullptr,
net_log_.bound());
CreateSessionWithNextProtos();
HostResolver::RequestInfo info(HostPortPair("www.google.com", 80));
AddressList address;
host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address,
- CompletionCallback(), NULL, net_log_.bound());
+ CompletionCallback(), nullptr, net_log_.bound());
CreateSessionWithNextProtos();
session_->quic_stream_factory()->set_require_confirmation(true);
MockRead(ASYNC, OK), // EOF
};
StaticSocketDataProvider quic_data(quic_reads, arraysize(quic_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&quic_data);
// Main job which will succeed even though the alternate job fails.
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
CreateSessionWithNextProtos();
MockRead(ASYNC, ERR_SOCKET_NOT_CONNECTED),
};
StaticSocketDataProvider quic_data(quic_reads, arraysize(quic_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&quic_data);
// Main job which will succeed even though the alternate job fails.
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
CreateSessionWithNextProtos();
MockRead(ASYNC, ERR_SOCKET_NOT_CONNECTED),
};
StaticSocketDataProvider quic_data(quic_reads, arraysize(quic_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&quic_data);
// Main job will also fail.
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
http_data.set_connect_data(MockConnect(ASYNC, ERR_SOCKET_NOT_CONNECTED));
socket_factory_.AddSocketDataProvider(&http_data);
MockRead(ASYNC, ERR_SOCKET_NOT_CONNECTED),
};
StaticSocketDataProvider quic_data(quic_reads, arraysize(quic_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&quic_data);
AddHangingNonAlternateProtocolSocketData();
// Second Alternate-protocol job which will race with the TCP job.
StaticSocketDataProvider quic_data2(quic_reads, arraysize(quic_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&quic_data2);
// Final job that will proceed when the QUIC job fails.
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
CreateSessionWithNextProtos();
MockRead(ASYNC, ERR_IO_PENDING),
};
StaticSocketDataProvider quic_data(quic_reads, arraysize(quic_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&quic_data);
// Main job that will proceed when the QUIC job fails.
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
CreateSessionWithNextProtos();
TEST_P(QuicNetworkTransactionTest, BrokenAlternateProtocolOnConnectFailure) {
// Alternate-protocol job will fail before creating a QUIC session.
- StaticSocketDataProvider quic_data(NULL, 0, NULL, 0);
+ StaticSocketDataProvider quic_data(nullptr, 0, nullptr, 0);
quic_data.set_connect_data(MockConnect(SYNCHRONOUS,
ERR_INTERNET_DISCONNECTED));
socket_factory_.AddSocketDataProvider(&quic_data);
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
CreateSessionWithNextProtos();
};
StaticSocketDataProvider http_data(http_reads, arraysize(http_reads),
- NULL, 0);
+ nullptr, 0);
socket_factory_.AddSocketDataProvider(&http_data);
// In order for a new QUIC session to be established via alternate-protocol
DEFAULT_PRIORITY,
&address,
CompletionCallback(),
- NULL,
+ nullptr,
net_log_.bound());
CreateSessionWithNextProtos();