# which would force scons to always rebuild.
}
-def AddTest(env, test_variant, envlist, settings, is_broken):
+def AddTest(env, test_variant, envlist, settings):
envlist = list(envlist)
settings = dict(settings)
# Add custom CFLAGS: this must be done here, since PNaClGetNNaClEnv
stdout_golden=nodes[0])
env.AddNodeToTestSuite(node, ['medium_tests', 'nonpexe_tests'],
- 'run_' + test_variant + '_test',
- is_broken=is_broken)
+ 'run_' + test_variant + '_test')
if env.Bit('bitcode'):
settings = dict(base_settings)
envlist = [base_env]
link_env = base_env
- AddTest(base_env, 'callingconv_self', envlist, settings, is_broken=False)
+ AddTest(base_env, 'callingconv_self', envlist, settings)
# (2) Cross-check.
if env.Bit('target_arm'):
- # BUG: http://code.google.com/p/nativeclient/issues/detail?id=2378
+ # Constant pool items are sometimes too far away with nacl-gcc.
+ # BUG: http://code.google.com/p/nativeclient/issues/detail?id=3205
settings['allow_double'] = 0
- # BUG: http://code.google.com/p/nativeclient/issues/detail?id=3143
- settings['allow_struct'] = 0
envlist = []
pnacl_env = base_env.Clone()
envlist.append(native_env)
link_env = pnacl_env
- # TODO(mcgrathr): Remove after fix for ARM:
- # https://code.google.com/p/nativeclient/issues/detail?id=3143
- # Also broken on x86_32:
- # https://code.google.com/p/nativeclient/issues/detail?id=3650
- is_broken = env.Bit('target_arm') or env.Bit('target_x86_32')
- AddTest(base_env, 'callingconv', envlist, settings, is_broken)
+ AddTest(base_env, 'callingconv', envlist, settings)
else:
# For NNaCl toolchain, just test self-consistency.
settings = dict(base_settings)
# Constant pool items sometimes too far away:
# BUG: http://code.google.com/p/nativeclient/issues/detail?id=3205
settings['allow_double'] = 0
- AddTest(base_env, 'callingconv', envlist, settings, is_broken=False)
+ AddTest(base_env, 'callingconv', envlist, settings)