Upstream version 9.38.198.0

[platform/framework/web/crosswalk.git] / src / gin / interceptor_unittest.cc

diff --git a/src/gin/interceptor_unittest.cc b/src/gin/interceptor_unittest.cc
index ee6b7dc..e25005b 100644 (file)
--- a/src/gin/interceptor_unittest.cc
+++ b/src/gin/interceptor_unittest.cc
@@ -13,6 +13,7 @@
 #include "gin/try_catch.h"
 #include "gin/wrappable.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "v8/include/v8-util.h"
 
 namespace gin {
 
@@ -36,19 +37,19 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
     if (property == "value") {
       return ConvertToV8(isolate, value_);
     } else if (property == "func") {
-      return CreateFunctionTemplate(isolate,
-                                    base::Bind(&MyInterceptor::Call),
-                                    HolderIsFirstArgument)->GetFunction();
+      return GetFunctionTemplate(isolate, "func")->GetFunction();
     } else {
       return v8::Local<v8::Value>();
     }
   }
-  virtual void SetNamedProperty(v8::Isolate* isolate,
+  virtual bool SetNamedProperty(v8::Isolate* isolate,
                                 const std::string& property,
                                 v8::Local<v8::Value> value) OVERRIDE {
-    if (property != "value")
-      return;
-    ConvertFromV8(isolate, value, &value_);
+    if (property == "value") {
+      ConvertFromV8(isolate, value, &value_);
+      return true;
+    }
+    return false;
   }
   virtual std::vector<std::string> EnumerateNamedProperties(
       v8::Isolate* isolate) OVERRIDE {
@@ -65,12 +66,15 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
       return ConvertToV8(isolate, value_);
     return v8::Local<v8::Value>();
   }
-  virtual void SetIndexedProperty(v8::Isolate* isolate,
+  virtual bool SetIndexedProperty(v8::Isolate* isolate,
                                   uint32_t index,
                                   v8::Local<v8::Value> value) OVERRIDE {
-    if (index != 0)
-      return;
-    ConvertFromV8(isolate, value, &value_);
+    if (index == 0) {
+      ConvertFromV8(isolate, value, &value_);
+      return true;
+    }
+    // Don't allow bypassing the interceptor.
+    return true;
   }
   virtual std::vector<uint32_t> EnumerateIndexedProperties(v8::Isolate* isolate)
       OVERRIDE {
@@ -83,7 +87,8 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
   explicit MyInterceptor(v8::Isolate* isolate)
       : NamedPropertyInterceptor(isolate, this),
         IndexedPropertyInterceptor(isolate, this),
-        value_(0) {}
+        value_(0),
+        template_cache_(isolate) {}
   virtual ~MyInterceptor() {}
 
   // gin::Wrappable
@@ -100,7 +105,23 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
     return tmp;
   }
 
+  v8::Local<v8::FunctionTemplate> GetFunctionTemplate(v8::Isolate* isolate,
+                                                      const std::string& name) {
+    v8::Local<v8::FunctionTemplate> function_template =
+        template_cache_.Get(name);
+    if (!function_template.IsEmpty())
+      return function_template;
+    function_template = CreateFunctionTemplate(
+        isolate, base::Bind(&MyInterceptor::Call), HolderIsFirstArgument);
+    template_cache_.Set(name, function_template);
+    return function_template;
+  }
+
   int value_;
+
+  v8::StdPersistentValueMap<std::string, v8::FunctionTemplate> template_cache_;
+
+  DISALLOW_COPY_AND_ASSIGN(MyInterceptor);
 };
 
 WrapperInfo MyInterceptor::kWrapperInfo = {kEmbedderNativeGin};
@@ -156,4 +177,20 @@ TEST_F(InterceptorTest, IndexedInterceptor) {
       "   else obj[0] = 191; })");
 }
 
+TEST_F(InterceptorTest, BypassInterceptorAllowed) {
+  RunInterceptorTest(
+      "(function (obj) {"
+      "   obj.value = 191 /* make test happy */;"
+      "   obj.foo = 23;"
+      "   if (obj.foo !== 23) throw 'FAIL'; })");
+}
+
+TEST_F(InterceptorTest, BypassInterceptorForbidden) {
+  RunInterceptorTest(
+      "(function (obj) {"
+      "   obj.value = 191 /* make test happy */;"
+      "   obj[1] = 23;"
+      "   if (obj[1] === 23) throw 'FAIL'; })");
+}
+
 }  // namespace gin