Upstream version 9.38.198.0

[platform/framework/web/crosswalk.git] / src / components / policy / core / common / policy_loader_win.cc

diff --git a/src/components/policy/core/common/policy_loader_win.cc b/src/components/policy/core/common/policy_loader_win.cc
index c956a74..2e2ddc8 100644 (file)
--- a/src/components/policy/core/common/policy_loader_win.cc
+++ b/src/components/policy/core/common/policy_loader_win.cc
@@ -30,6 +30,7 @@
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
+#include "base/metrics/sparse_histogram.h"
 #include "base/scoped_native_library.h"
 #include "base/sequenced_task_runner.h"
 #include "base/stl_util.h"
@@ -72,15 +73,29 @@ const char kExpectedWebStoreUrl[] =
 // String to be prepended to each blocked entry.
 const char kBlockedExtensionPrefix[] = "[BLOCKED]";
 
+// List of policies that are considered only if the user is part of a AD domain.
+const char* kInsecurePolicies[] = {
+    key::kMetricsReportingEnabled,
+    key::kDefaultSearchProviderEnabled,
+    key::kHomepageIsNewTabPage,
+    key::kHomepageLocation,
+    key::kRestoreOnStartup,
+    key::kRestoreOnStartupURLs
+};
+
 // The GUID of the registry settings group policy extension.
 GUID kRegistrySettingsCSEGUID = REGISTRY_EXTENSION_GUID;
 
 // The list of possible errors that can occur while collecting information about
 // the current enterprise environment.
+// This enum is used to define the buckets for an enumerated UMA histogram.
+// Hence,
+//   (a) existing enumerated constants should never be deleted or reordered, and
+//   (b) new constants should only be appended at the end of the enumeration.
 enum DomainCheckErrors {
   DOMAIN_CHECK_ERROR_GET_JOIN_INFO = 0,
-  DOMAIN_CHECK_ERROR_DS_BIND,
-  DOMAIN_CHECK_ERROR_LAST,
+  DOMAIN_CHECK_ERROR_DS_BIND = 1,
+  DOMAIN_CHECK_ERROR_SIZE,  // Not a DomainCheckError.  Must be last.
 };
 
 // If the LBS extension is found and contains a schema in the registry then this
@@ -122,10 +137,10 @@ void FilterUntrustedPolicy(PolicyMap* policy) {
   if (base::win::IsEnrolledToDomain())
     return;
 
+  int invalid_policies = 0;
   const PolicyMap::Entry* map_entry =
       policy->Get(policy::key::kExtensionInstallForcelist);
   if (map_entry && map_entry->value) {
-    int invalid_policies = 0;
     const base::ListValue* policy_list_value = NULL;
     if (!map_entry->value->GetAsList(&policy_list_value))
       return;
@@ -147,13 +162,33 @@ void FilterUntrustedPolicy(PolicyMap* policy) {
 
       filtered_values->AppendString(entry);
     }
-    policy->Set(policy::key::kExtensionInstallForcelist,
-                map_entry->level, map_entry->scope,
-                filtered_values.release(),
-                map_entry->external_data_fetcher);
-    UMA_HISTOGRAM_COUNTS("EnterpriseCheck.InvalidPoliciesDetected",
-                         invalid_policies);
+    if (invalid_policies) {
+      policy->Set(policy::key::kExtensionInstallForcelist,
+                  map_entry->level, map_entry->scope,
+                  filtered_values.release(),
+                  map_entry->external_data_fetcher);
+
+      const PolicyDetails* details = policy::GetChromePolicyDetails(
+          policy::key::kExtensionInstallForcelist);
+      UMA_HISTOGRAM_SPARSE_SLOWLY("EnterpriseCheck.InvalidPolicies",
+                                  details->id);
+    }
   }
+
+  for (size_t i = 0; i < arraysize(kInsecurePolicies); ++i) {
+    if (policy->Get(kInsecurePolicies[i])) {
+      // TODO(pastarmovj): Surface this issue in the about:policy page.
+      policy->Erase(kInsecurePolicies[i]);
+      invalid_policies++;
+      const PolicyDetails* details =
+          policy::GetChromePolicyDetails(kInsecurePolicies[i]);
+      UMA_HISTOGRAM_SPARSE_SLOWLY("EnterpriseCheck.InvalidPolicies",
+                                  details->id);
+    }
+  }
+
+  UMA_HISTOGRAM_COUNTS("EnterpriseCheck.InvalidPoliciesDetected",
+                       invalid_policies);
 }
 
 // A helper class encapsulating run-time-linked function calls to Wow64 APIs.
@@ -304,7 +339,7 @@ void CollectEnterpriseUMAs() {
   if (NERR_Success != ::NetGetJoinInformation(NULL, &domain, &join_status)) {
     UMA_HISTOGRAM_ENUMERATION("EnterpriseCheck.DomainCheckFailed",
                               DOMAIN_CHECK_ERROR_GET_JOIN_INFO,
-                              DOMAIN_CHECK_ERROR_LAST);
+                              DOMAIN_CHECK_ERROR_SIZE);
     return;
   }
   ::NetApiBufferFree(domain);
@@ -321,7 +356,7 @@ void CollectEnterpriseUMAs() {
     } else {
       UMA_HISTOGRAM_ENUMERATION("EnterpriseCheck.DomainCheckFailed",
                                 DOMAIN_CHECK_ERROR_DS_BIND,
-                                DOMAIN_CHECK_ERROR_LAST);
+                                DOMAIN_CHECK_ERROR_SIZE);
     }
   }
 }