#include "chrome/browser/chromeos/options/wifi_config_view.h"
-#include "ash/system/chromeos/network/network_connect.h"
#include "base/bind.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
+#include "ui/chromeos/network/network_connect.h"
#include "ui/events/event.h"
#include "ui/views/controls/button/checkbox.h"
#include "ui/views/controls/button/image_button.h"
width_(width) {
}
virtual ~ComboboxWithWidth() {}
- virtual gfx::Size GetPreferredSize() const OVERRIDE {
+ virtual gfx::Size GetPreferredSize() const override {
gfx::Size size = Combobox::GetPreferredSize();
size.set_width(width_);
return size;
virtual ~SecurityComboboxModel();
// Overridden from ui::ComboboxModel:
- virtual int GetItemCount() const OVERRIDE;
- virtual base::string16 GetItemAt(int index) OVERRIDE;
+ virtual int GetItemCount() const override;
+ virtual base::string16 GetItemAt(int index) override;
private:
DISALLOW_COPY_AND_ASSIGN(SecurityComboboxModel);
virtual ~EAPMethodComboboxModel();
// Overridden from ui::ComboboxModel:
- virtual int GetItemCount() const OVERRIDE;
- virtual base::string16 GetItemAt(int index) OVERRIDE;
+ virtual int GetItemCount() const override;
+ virtual base::string16 GetItemAt(int index) override;
private:
DISALLOW_COPY_AND_ASSIGN(EAPMethodComboboxModel);
virtual ~Phase2AuthComboboxModel();
// Overridden from ui::ComboboxModel:
- virtual int GetItemCount() const OVERRIDE;
- virtual base::string16 GetItemAt(int index) OVERRIDE;
+ virtual int GetItemCount() const override;
+ virtual base::string16 GetItemAt(int index) override;
private:
views::Combobox* eap_method_combobox_;
virtual ~ServerCACertComboboxModel();
// Overridden from ui::ComboboxModel:
- virtual int GetItemCount() const OVERRIDE;
- virtual base::string16 GetItemAt(int index) OVERRIDE;
+ virtual int GetItemCount() const override;
+ virtual base::string16 GetItemAt(int index) override;
private:
DISALLOW_COPY_AND_ASSIGN(ServerCACertComboboxModel);
virtual ~UserCertComboboxModel();
// Overridden from ui::ComboboxModel:
- virtual int GetItemCount() const OVERRIDE;
- virtual base::string16 GetItemAt(int index) OVERRIDE;
+ virtual int GetItemCount() const override;
+ virtual base::string16 GetItemAt(int index) override;
private:
WifiConfigView* owner_;
if (index < 0)
return false;
// Currently only hardware-backed user certificates are valid.
- if (CertLibrary::Get()->IsHardwareBacked() &&
- !CertLibrary::Get()->IsCertHardwareBackedAt(
- CertLibrary::CERT_TYPE_USER, index))
+ if (!CertLibrary::Get()->IsCertHardwareBackedAt(CertLibrary::CERT_TYPE_USER,
+ index)) {
return false;
+ }
return true;
}
if (error_msg.empty() && !service_path_.empty()) {
const NetworkState* network = GetNetworkState();
if (network && network->connection_state() == shill::kStateFailure) {
- error_msg = ash::network_connect::ErrorString(
+ error_msg = ui::NetworkConnect::Get()->GetErrorString(
network->last_error(), network->path());
}
}
}
} else {
security = shill::kSecurity8021x;
- SetEapProperties(&properties);
+ SetEapProperties(&properties, false /* not configured */);
}
properties.SetStringWithoutPathExpansion(
shill::kSecurityProperty, security);
// Configure and connect to network.
- ash::network_connect::CreateConfigurationAndConnect(&properties,
- share_network);
+ ui::NetworkConnect::Get()->CreateConfigurationAndConnect(&properties,
+ share_network);
} else {
if (!network) {
// Shill no longer knows about this network (edge case).
return true; // Close dialog
}
if (eap_method_combobox_) {
- SetEapProperties(&properties);
+ SetEapProperties(&properties, true /* configured */);
properties.SetBooleanWithoutPathExpansion(
shill::kSaveCredentialsProperty, GetSaveCredentials());
} else {
properties.SetStringWithoutPathExpansion(shill::kTypeProperty,
shill::kTypeEthernetEap);
share_network = false;
- ash::network_connect::CreateConfiguration(&properties, share_network);
+ ui::NetworkConnect::Get()->CreateConfiguration(&properties,
+ share_network);
} else {
- ash::network_connect::ConfigureNetworkAndConnect(
+ ui::NetworkConnect::Get()->ConfigureNetworkAndConnect(
service_path_, properties, share_network);
}
}
return base::UTF16ToUTF8(identity_anonymous_textfield_->text());
}
-void WifiConfigView::SetEapProperties(base::DictionaryValue* properties) {
+void WifiConfigView::SetEapProperties(base::DictionaryValue* properties,
+ bool configured) {
properties->SetStringWithoutPathExpansion(
shill::kEapIdentityProperty, GetEapIdentity());
properties->SetStringWithoutPathExpansion(
properties->SetBooleanWithoutPathExpansion(
shill::kEapUseSystemCasProperty, GetEapUseSystemCas());
- properties->SetStringWithoutPathExpansion(
- shill::kEapPasswordProperty, GetPassphrase());
-
+ if (!configured || passphrase_textfield_->changed()) {
+ properties->SetStringWithoutPathExpansion(
+ shill::kEapPasswordProperty, GetPassphrase());
+ }
base::ListValue* pem_list = new base::ListValue;
std::string ca_cert_pem = GetEapServerCaCertPEM();
if (!ca_cert_pem.empty())