#include "base/sequenced_task_runner.h"
#include "base/threading/thread_restrictions.h"
#include "chrome/browser/chromeos/drive/drive.pb.h"
+#include "chrome/browser/drive/drive_api_util.h"
#include "third_party/leveldatabase/env_chromium.h"
#include "third_party/leveldatabase/src/include/leveldb/db.h"
#include "third_party/leveldatabase/src/include/leveldb/write_batch.h"
DB_INIT_MAX_VALUE,
};
+// Enum to describe DB validity check failure reason.
+enum CheckValidityFailureReason {
+ CHECK_VALIDITY_FAILURE_INVALID_HEADER,
+ CHECK_VALIDITY_FAILURE_BROKEN_ID_ENTRY,
+ CHECK_VALIDITY_FAILURE_BROKEN_ENTRY,
+ CHECK_VALIDITY_FAILURE_INVALID_LOCAL_ID,
+ CHECK_VALIDITY_FAILURE_INVALID_PARENT_ID,
+ CHECK_VALIDITY_FAILURE_BROKEN_CHILD_MAP,
+ CHECK_VALIDITY_FAILURE_CHILD_ENTRY_COUNT_MISMATCH,
+ CHECK_VALIDITY_FAILURE_ITERATOR_ERROR,
+ CHECK_VALIDITY_FAILURE_MAX_VALUE,
+};
+
// The name of the DB which stores the metadata.
const base::FilePath::CharType kResourceMapDBName[] =
FILE_PATH_LITERAL("resource_metadata_resource_map.db");
return !base::PathExists(from) || base::Move(from, to);
}
+void RecordCheckValidityFailure(CheckValidityFailureReason reason) {
+ UMA_HISTOGRAM_ENUMERATION("Drive.MetadataDBValidityCheckFailureReason",
+ reason,
+ CHECK_VALIDITY_FAILURE_MAX_VALUE);
+}
+
} // namespace
ResourceMetadataStorage::Iterator::Iterator(scoped_ptr<leveldb::Iterator> it)
// static
bool ResourceMetadataStorage::UpgradeOldDB(
- const base::FilePath& directory_path,
- const ResourceIdCanonicalizer& id_canonicalizer) {
+ const base::FilePath& directory_path) {
base::ThreadRestrictions::AssertIOAllowed();
COMPILE_ASSERT(
kDBVersion == 13,
// The resource ID might be in old WAPI format. We need to canonicalize
// to the format of API service currently in use.
const std::string& id = GetIdFromCacheEntryKey(it->key());
- const std::string& id_new = id_canonicalizer.Run(id);
+ const std::string& id_new = util::CanonicalizeResourceId(id);
// Before v11, resource ID was directly used as local ID. Such entries
// can be migrated by adding an identity ID mapping.
!header.ParseFromArray(it->value().data(), it->value().size()) ||
header.version() != kDBVersion) {
DLOG(ERROR) << "Invalid header detected. version = " << header.version();
+ RecordCheckValidityFailure(CHECK_VALIDITY_FAILURE_INVALID_HEADER);
return false;
}
leveldb::Slice(GetIdEntryKey(entry.resource_id())) == it->key();
if (!ok) {
DLOG(ERROR) << "Broken ID entry. status = " << status.ToString();
+ RecordCheckValidityFailure(CHECK_VALIDITY_FAILURE_BROKEN_ID_ENTRY);
return false;
}
continue;
// Check if stored data is broken.
if (!entry.ParseFromArray(it->value().data(), it->value().size())) {
DLOG(ERROR) << "Broken entry detected";
+ RecordCheckValidityFailure(CHECK_VALIDITY_FAILURE_BROKEN_ENTRY);
return false;
}
if (leveldb::Slice(entry.local_id()) != it->key()) {
DLOG(ERROR) << "Wrong local ID.";
+ RecordCheckValidityFailure(CHECK_VALIDITY_FAILURE_INVALID_LOCAL_ID);
return false;
}
&serialized_entry);
if (!status.ok()) {
DLOG(ERROR) << "Can't get parent entry. status = " << status.ToString();
+ RecordCheckValidityFailure(CHECK_VALIDITY_FAILURE_INVALID_PARENT_ID);
return false;
}
&child_id);
if (!status.ok() || leveldb::Slice(child_id) != it->key()) {
DLOG(ERROR) << "Child map is broken. status = " << status.ToString();
+ RecordCheckValidityFailure(CHECK_VALIDITY_FAILURE_BROKEN_CHILD_MAP);
return false;
}
++num_entries_with_parent;
}
}
- if (!it->status().ok() || num_child_entries != num_entries_with_parent) {
+ if (!it->status().ok()) {
DLOG(ERROR) << "Error during checking resource map. status = "
<< it->status().ToString();
+ RecordCheckValidityFailure(CHECK_VALIDITY_FAILURE_ITERATOR_ERROR);
+ return false;
+ }
+ if (num_child_entries != num_entries_with_parent) {
+ DLOG(ERROR) << "Child entry count mismatch";
+ RecordCheckValidityFailure(
+ CHECK_VALIDITY_FAILURE_CHILD_ENTRY_COUNT_MISMATCH);
return false;
}
return true;