From 99f61c1d99374aac7d8af2021af98e7d20082d3d Mon Sep 17 00:00:00 2001 From: Myung Jin Kim Date: Wed, 2 Oct 2013 17:34:41 +0900 Subject: [PATCH] fix klocwork issue Change-Id: Id904789d20dc73620936d3dc9fd811d22ac9624c --- src/ui/FUi_AccessibilityElement.cpp | 45 ------------------- src/ui/FUi_DataBinding.cpp | 66 +--------------------------- src/ui/inc/FUi_ResourceManager.h | 5 --- src/ui/resource/FUi_ResourceStringLoader.cpp | 1 - 4 files changed, 1 insertion(+), 116 deletions(-) diff --git a/src/ui/FUi_AccessibilityElement.cpp b/src/ui/FUi_AccessibilityElement.cpp index f070bd4..5b93da3 100644 --- a/src/ui/FUi_AccessibilityElement.cpp +++ b/src/ui/FUi_AccessibilityElement.cpp @@ -31,51 +31,6 @@ using namespace Tizen::Graphics; namespace Tizen { namespace Ui { -const wchar_t* _traitString[] = -{ - L"",//ACCESSIBILITY_TRAITS_NONE, - L"TITLE",//ACCESSIBILITY_TRAITS_TITLE, - L"OPTION HEADER",//ACCESSIBILITY_TRAITS_OPTION_HEADER, - L"PICTURE",//ACCESSIBILITY_TRAITS_PICTURE, - L"STATUS BAR",//ACCESSIBILITY_TRAITS_STATUS_BAR, - L"TEXT FIELD",//ACCESSIBILITY_TRAITS_TEXT_FIELD, - L"RATING",//ACCESSIBILITY_TRAITS_RATING, - L"ACTION BAR",//ACCESSIBILITY_TRAITS_ACTION_BAR, - L"ACTION BAR MENU",//ACCESSIBILITY_TRAITS_ACTION_BAR_MENU, - L"BACK BUTTON",//ACCESSIBILITY_TRAITS_BUTTON, - L"BUTTON",//ACCESSIBILITY_TRAITS_BUTTON, - L"LABEL",//ACCESSIBILITY_TRAITS_LABEL, - L"LIST",//ACCESSIBILITY_TRAITS_LIST, - L"SELECTOR",//ACCESSIBILITY_TRAITS_DATA_SELECTOR, - L"SCROLL",//ACCESSIBILITY_TRAITS_DRAG_SCROLL, - L"EXPAND BUTTON",//ACCESSIBILITY_TRAITS_EXPAND_BUTTON, - L"FUNCTION PANEL",//ACCESSIBILITY_TRAITS_FUNCTION_PANEL, - L"IN DEPTH BUTTON",//ACCESSIBILITY_TRAITS_IN_DEPTH_BUTTON, - L"INDEX SCROLL",//ACCESSIBILITY_TRAITS_INDEX_SCROLL, - L"IMAGE",//ACCESSIBILITY_TRAITS_IMAGE - L"INDICATOR",//ACCESSIBILITY_TRAITS_INDICATOR, - L"NOTIFICATION",//ACCESSIBILITY_TRAITS_NOTIFICATION, - L"RADIO BUTTON",//ACCESSIBILITY_TRAITS_RADIO_BUTTON, - L"SCROLL BAR",//ACCESSIBILITY_TRAITS_SCROLL_BAR, - L"SEARCH FIELD",//ACCESSIBILITY_TRAITS_SEARCH_FIELD, - L"SEGMENT",//ACCESSIBILITY_TRAITS_SEGMENT, - L"SLIDER",//ACCESSIBILITY_TRAITS_SLIDER, - L"SOFT KEY",//ACCESSIBILITY_TRAITS_SOFT_KEY, - L"SUB MENU TITLE",//ACCESSIBILITY_TRAITS_SUB_MENU_TITLE, - L"TAB",//ACCESSIBILITY_TRAITS_TAB, - L"TICK BOX",//ACCESSIBILITY_TRAITS_TICKBOX, - L"TIME SELECTOR",//ACCESSIBILITY_TRAITS_TIME_SELECTOR, - L"VOLUME SLIDER",//ACCESSIBILITY_TRAITS_VOLUME_SLIDER, - L"HOUR",//ACCESSIBILITY_TRAITS_HOUR, - L"MINUTE",//ACCESSIBILITY_TRAITS_MINUTE, - L"SECOND",//ACCESSIBILITY_TRAITS_SECOND, - L"YEAR",//ACCESSIBILITY_TRAITS_YEAR, - L"MONTH",//ACCESSIBILITY_TRAITS_MONTH, - L"DAY",//ACCESSIBILITY_TRAITS_DAY, - L"END",//ACCESSIBILITY_TRAITS_END = 0xff -}; - - _AccessibilityElement::_AccessibilityElement(bool systemElement) : __name(L"") , __bounds(0,0,0,0) diff --git a/src/ui/FUi_DataBinding.cpp b/src/ui/FUi_DataBinding.cpp index e843d31..7a71e1e 100644 --- a/src/ui/FUi_DataBinding.cpp +++ b/src/ui/FUi_DataBinding.cpp @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -1388,71 +1389,6 @@ ConvertVariantTypeToDataBindingDataType(VariantType variantType) return dataType; } -VariantType -ConvertDataBindingDataTypeToVariantType(DataBindingDataType dataType) -{ - VariantType variantType = VARIANT_TYPE_NONE; - switch (dataType) - { - case DATA_BINDING_DATA_TYPE_BOOLEAN: - variantType = VARIANT_TYPE_BOOL; - break; - - case DATA_BINDING_DATA_TYPE_COLOR: - variantType = VARIANT_TYPE_COLOR; - break; - - case DATA_BINDING_DATA_TYPE_DIMENSION: - variantType = VARIANT_TYPE_DIMENSION; - break; - - case DATA_BINDING_DATA_TYPE_DOUBLE: - variantType = VARIANT_TYPE_DOUBLE; - break; - - case DATA_BINDING_DATA_TYPE_FLOAT: - variantType = VARIANT_TYPE_FLOAT; - break; - - case DATA_BINDING_DATA_TYPE_INTEGER: - variantType = VARIANT_TYPE_INT; - break; - - case DATA_BINDING_DATA_TYPE_LONG: - variantType = VARIANT_TYPE_LONG; - break; - - case DATA_BINDING_DATA_TYPE_POINT: - variantType = VARIANT_TYPE_POINT; - break; - - case DATA_BINDING_DATA_TYPE_RECTANGLE: - variantType = VARIANT_TYPE_RECTANGLE; - break; - - case DATA_BINDING_DATA_TYPE_STRING: - variantType = VARIANT_TYPE_STRING; - break; - - case DATA_BINDING_DATA_TYPE_FLOAT_DIMENSION: - variantType = VARIANT_TYPE_FLOAT_DIMENSION; - break; - - case DATA_BINDING_DATA_TYPE_FLOAT_POINT: - variantType = VARIANT_TYPE_FLOAT_POINT; - break; - - case DATA_BINDING_DATA_TYPE_FLOAT_RECTANGLE: - variantType = VARIANT_TYPE_FLOAT_RECTANGLE; - break; - - default: - break; - } - return variantType; -} - - class _DataBindingPropertyChangeEventListner : public _IPropertyChangeEventListener , virtual public Tizen::Base::Runtime::IEventListener diff --git a/src/ui/inc/FUi_ResourceManager.h b/src/ui/inc/FUi_ResourceManager.h index 978a40e..d62c571 100644 --- a/src/ui/inc/FUi_ResourceManager.h +++ b/src/ui/inc/FUi_ResourceManager.h @@ -123,11 +123,6 @@ enum _ResourceFeedbackPattern _RESOURCE_FEEDBACK_PATTERN_SLIDER_SWEEP }; // enum _ResourceFeedbackPattern - namespace Controls { namespace __Internal - { - const int OVERLAY_REGION_MIN_LENGTH = 16; - }}//Tizen::Ui::Controls::__Internal - #define GET_SHAPE_CONFIG(shapeId, orientation, x)\ Tizen::Ui::_ResourceManager::GetInstance()->GetShape(Tizen::Ui::_Resource::_##shapeId##_SHAPE, orientation, x) diff --git a/src/ui/resource/FUi_ResourceStringLoader.cpp b/src/ui/resource/FUi_ResourceStringLoader.cpp index 65b5b14..c08dd7c 100644 --- a/src/ui/resource/FUi_ResourceStringLoader.cpp +++ b/src/ui/resource/FUi_ResourceStringLoader.cpp @@ -25,7 +25,6 @@ using namespace Tizen::Base; namespace { -const char* const SLP_SYSTEM_DOMAIN ="sys_string"; const char* const OSP_DOMAIN ="osp"; } -- 2.7.4