From 679d8feda43ee31cf28d7504a76a5d0834dfab29 Mon Sep 17 00:00:00 2001 From: Jiyun Yang Date: Tue, 13 Jul 2021 19:21:52 +0900 Subject: [PATCH] Change default value of WebView::Property::VIDEO_HOLE_ENABLED to false Change-Id: I5d3cd11ea1ce5a0b510b45a316c17aae16c0a82b Signed-off-by: Jiyun Yang --- automated-tests/src/dali-toolkit/utc-Dali-WebView.cpp | 4 ++-- dali-toolkit/devel-api/controls/web-view/web-view.h | 2 +- dali-toolkit/internal/controls/web-view/web-view-impl.cpp | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/automated-tests/src/dali-toolkit/utc-Dali-WebView.cpp b/automated-tests/src/dali-toolkit/utc-Dali-WebView.cpp index 302deb6..87ec45b 100755 --- a/automated-tests/src/dali-toolkit/utc-Dali-WebView.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-WebView.cpp @@ -670,8 +670,8 @@ int UtcDaliWebViewPropertyVideoHoleEnabled(void) WebView view = WebView::New(); DALI_TEST_CHECK( view ); - const bool kDefaultValue = true; - const bool kTestValue = false; + const bool kDefaultValue = false; + const bool kTestValue = true; // Check default value bool output; diff --git a/dali-toolkit/devel-api/controls/web-view/web-view.h b/dali-toolkit/devel-api/controls/web-view/web-view.h index 37c46f8..744425a 100755 --- a/dali-toolkit/devel-api/controls/web-view/web-view.h +++ b/dali-toolkit/devel-api/controls/web-view/web-view.h @@ -117,7 +117,7 @@ public: /** * @brief Whether video hole is enabled or not. * @details name "videoHoleEnabled", type Property::BOOLEAN. - * @note The value is read-only. + * @note False by default. */ VIDEO_HOLE_ENABLED, diff --git a/dali-toolkit/internal/controls/web-view/web-view-impl.cpp b/dali-toolkit/internal/controls/web-view/web-view-impl.cpp index 5adfe5d..7ae7543 100644 --- a/dali-toolkit/internal/controls/web-view/web-view-impl.cpp +++ b/dali-toolkit/internal/controls/web-view/web-view-impl.cpp @@ -125,7 +125,7 @@ WebView::WebView(const std::string& locale, const std::string& timezoneId) mPageLoadErrorSignal(), mUrlChangedSignal(), mWebViewArea(0, 0, mWebViewSize.width, mWebViewSize.height), - mVideoHoleEnabled(true), + mVideoHoleEnabled(false), mMouseEventsEnabled(true), mKeyEventsEnabled(true), mScreenshotCapturedCallback(nullptr) @@ -149,7 +149,7 @@ WebView::WebView(uint32_t argc, char** argv) mPageLoadErrorSignal(), mUrlChangedSignal(), mWebViewArea(0, 0, mWebViewSize.width, mWebViewSize.height), - mVideoHoleEnabled(true), + mVideoHoleEnabled(false), mMouseEventsEnabled(true), mKeyEventsEnabled(true), mScreenshotCapturedCallback(nullptr) -- 2.7.4