From efd1fbb41ae3c7cab8edf40e22aa30b111fdd63b Mon Sep 17 00:00:00 2001 From: "Eunki, Hong" Date: Thu, 18 Feb 2021 01:59:22 -0800 Subject: [PATCH] Remove unused internal API at SVG (DeleteImage) DeleteImage(VectorImageRenderer) API not be used for any codes. Change-Id: I66abdf10bc52ebda717a8974b20fa3741028c12b Signed-off-by: Eunki, Hong --- .../internal/visuals/svg/svg-rasterize-thread.cpp | 21 --------------------- .../internal/visuals/svg/svg-rasterize-thread.h | 10 ---------- 2 files changed, 31 deletions(-) diff --git a/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.cpp b/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.cpp index e2b55b5..767bfb0 100644 --- a/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.cpp +++ b/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.cpp @@ -224,32 +224,11 @@ void SvgRasterizeThread::RemoveTask(SvgVisual* visual) UnregisterProcessor(); } -void SvgRasterizeThread::DeleteImage(VectorImageRenderer vectorRenderer) -{ - // Lock while adding image to the delete queue - ConditionalWait::ScopedLock lock(mConditionalWait); - - if(mIsThreadWaiting) // no rasterization is ongoing, save to delete - { - // TODO: what? - } - else // wait to delete until current rasterization completed. - { - mDeleteSvg.PushBack(&vectorRenderer); - } -} - RasterizingTaskPtr SvgRasterizeThread::NextTaskToProcess() { // Lock while popping task out from the queue ConditionalWait::ScopedLock lock(mConditionalWait); - // Delete the image here to make sure that it is not used in the nsvgRasterize() - if(!mDeleteSvg.Empty()) - { - mDeleteSvg.Clear(); - } - // conditional wait while(mRasterizeTasks.empty()) { diff --git a/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.h b/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.h index 9e54e61..b915b13 100644 --- a/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.h +++ b/dali-toolkit/internal/visuals/svg/svg-rasterize-thread.h @@ -164,15 +164,6 @@ public: void RemoveTask(SvgVisual* visual); /** - * Delete the parsed SVG image, called by main thread. - * - * The parsed svg should be deleted in worker thread, as the main thread does not know whether a rasterization of this svg is ongoing. - * - * @param[in] VectorImage The image to be deleted - */ - void DeleteImage(VectorImageRenderer vectorImage); - - /** * @copydoc Dali::Integration::Processor::Process() */ void Process() override; @@ -225,7 +216,6 @@ private: private: std::vector mRasterizeTasks; //The queue of the tasks waiting to rasterize the SVG image std::vector mCompletedTasks; //The queue of the tasks with the SVG rasterization completed - Vector mDeleteSvg; //The images that the event thread requested to delete ConditionalWait mConditionalWait; Dali::Mutex mMutex; -- 2.7.4