From dc998c4a0369a447f61fad4729bf3a8b9151f181 Mon Sep 17 00:00:00 2001 From: Kimmo Hoikka Date: Mon, 7 Nov 2016 18:44:07 +0000 Subject: [PATCH] Fix an errornous test case and corresponding wrong implementation in popup - test was assuming POPUP_BACKGROUND_IMAGE returns different URL in Get than what was set in Set Change-Id: I1ad8046e1d10da1f3336cf0bb0c0b14563bca5c5 --- automated-tests/src/dali-toolkit/utc-Dali-Popup.cpp | 4 ++-- dali-toolkit/internal/controls/popup/popup-impl.cpp | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/automated-tests/src/dali-toolkit/utc-Dali-Popup.cpp b/automated-tests/src/dali-toolkit/utc-Dali-Popup.cpp index c3eaa4b..1cd8ad6 100644 --- a/automated-tests/src/dali-toolkit/utc-Dali-Popup.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-Popup.cpp @@ -1014,11 +1014,11 @@ int UtcDaliPopupPropertyBackgroundImage(void) Popup popup = Popup::New(); Stage::GetCurrent().Add( popup ); - // Check setting an invalid image. + // Check setting an image popup.SetProperty( Toolkit::Popup::Property::POPUP_BACKGROUND_IMAGE, "invalid-image.png" ); std::string resultString; popup.GetProperty( Toolkit::Popup::Property::POPUP_BACKGROUND_IMAGE ).Get( resultString ); - DALI_TEST_EQUALS( resultString, std::string(""), TEST_LOCATION ); + DALI_TEST_EQUALS( resultString, "invalid-image.png", TEST_LOCATION ); END_TEST; } diff --git a/dali-toolkit/internal/controls/popup/popup-impl.cpp b/dali-toolkit/internal/controls/popup/popup-impl.cpp index f1fea71..7ac2a28 100755 --- a/dali-toolkit/internal/controls/popup/popup-impl.cpp +++ b/dali-toolkit/internal/controls/popup/popup-impl.cpp @@ -28,7 +28,6 @@ #include #include #include -#include #include #include #include @@ -1382,10 +1381,10 @@ Property::Value Popup::GetProperty( BaseObject* object, Property::Index property } case Toolkit::Popup::Property::POPUP_BACKGROUND_IMAGE: { - ResourceImage image = ResourceImage::DownCast( popupImpl.GetPopupBackgroundImage() ); - if( image ) + Toolkit::ImageView imageView = Toolkit::ImageView::DownCast( popupImpl.GetPopupBackgroundImage() ); + if( imageView ) { - value = image.GetUrl(); + value = imageView.GetProperty( Toolkit::ImageView::Property::IMAGE ); } break; } -- 2.7.4