From d559bcfd3dacea3441cf649b28687a0ea8bb1912 Mon Sep 17 00:00:00 2001 From: Adeel Kazmi Date: Tue, 23 Jul 2019 17:14:09 +0100 Subject: [PATCH 1/1] Applying changes to Scene::New() Change-Id: Ifb45d1e05d161387dba09574e63cb832e8c21d28 --- .../dali-toolkit-test-utils/test-application.cpp | 3 +-- .../dali-toolkit-test-utils/toolkit-window.cpp | 15 +++++---------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.cpp b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.cpp index 7ffb5e5..f3029fa 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.cpp +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.cpp @@ -78,8 +78,7 @@ void TestApplication::CreateCore() void TestApplication::CreateScene() { mRenderSurface = new TestRenderSurface( Dali::PositionSize( 0, 0, mSurfaceWidth, mSurfaceHeight ) ); - mScene = Dali::Integration::Scene::New( Vector2( static_cast( mSurfaceWidth ), static_cast( mSurfaceHeight ) ) ); - mScene.SetSurface( *mRenderSurface ); + mScene = Dali::Integration::Scene::New( *mRenderSurface ); mScene.SetDpi( Vector2( static_cast( mDpi.x ), static_cast( mDpi.y ) ) ); } diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp index 1b8cdbd..2726434 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp @@ -45,25 +45,20 @@ class Window : public Dali::BaseObject public: Window( const PositionSize& positionSize ) - : mScene( Dali::Integration::Scene::New( Size( positionSize.width, positionSize.height ) ) ), - mRenderSurface( new TestRenderSurface( positionSize ) ) + : mRenderSurface( positionSize ), + mScene( Dali::Integration::Scene::New( mRenderSurface ) ) { - mScene.SetSurface( *mRenderSurface ); } - virtual ~Window() - { - delete mRenderSurface; - mRenderSurface = nullptr; - } + virtual ~Window() = default; static Window* New(const PositionSize& positionSize, const std::string& name, const std::string& className, bool isTransparent) { return new Window( positionSize ); } + TestRenderSurface mRenderSurface; Integration::Scene mScene; - TestRenderSurface* mRenderSurface; }; } // Adaptor @@ -124,7 +119,7 @@ Integration::Scene Window::GetScene() Integration::RenderSurface& Window::GetRenderSurface() { - return *GetImplementation( *this ).mRenderSurface; + return GetImplementation( *this ).mRenderSurface; } namespace DevelWindow -- 2.7.4