From b618a881f27fb24039f51d5bbf083d74d120205e Mon Sep 17 00:00:00 2001 From: Bowon Ryu Date: Thu, 22 Jul 2021 18:14:32 +0900 Subject: [PATCH] Fix coverity issue in text layout-engine middleLineIndex is always bigger than 0u by the while condition (0u < middleLineIndex). therefore execution cannot reach the expression 0u inside the statement below. : ellipsisLineIndex = middleLineIndex > 0u ? middleLineIndex - 1u : 0u; Change-Id: I1f2f85768ba638d3493f62a22b3d89a75ef462ae Signed-off-by: Bowon Ryu --- dali-toolkit/internal/text/layouts/layout-engine.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dali-toolkit/internal/text/layouts/layout-engine.cpp b/dali-toolkit/internal/text/layouts/layout-engine.cpp index 077b598..cee3a09 100644 --- a/dali-toolkit/internal/text/layouts/layout-engine.cpp +++ b/dali-toolkit/internal/text/layouts/layout-engine.cpp @@ -1881,7 +1881,7 @@ struct Engine::Impl linesBuffer[lineIndex].ellipsis = false; } numberOfLines--; - ellipsisLineIndex = middleLineIndex > 0u ? middleLineIndex - 1u : 0u; + ellipsisLineIndex = middleLineIndex - 1u; middleLineIndex = (numberOfLines) / 2u; } -- 2.7.4