From 403ee2c915ca37f3b768bc1567229393adf1f7ed Mon Sep 17 00:00:00 2001 From: Adeel Kazmi Date: Tue, 5 Jan 2016 15:08:39 +0000 Subject: [PATCH] (ImageView) Reinstated RESOURCE_URL property for source compatibility with release - But marked as deprecated Change-Id: I000b9684d9e94a77d477997a3b5fdfaea7b6cacd --- .../src/dali-toolkit/utc-Dali-ImageView.cpp | 13 +++++++++++++ .../controls/image-view/image-view-impl.cpp | 21 +++++++++++++++++++++ .../public-api/controls/image-view/image-view.h | 3 ++- 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/automated-tests/src/dali-toolkit/utc-Dali-ImageView.cpp b/automated-tests/src/dali-toolkit/utc-Dali-ImageView.cpp index cfe23c3..2feeee2 100644 --- a/automated-tests/src/dali-toolkit/utc-Dali-ImageView.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-ImageView.cpp @@ -551,3 +551,16 @@ int UtcDaliImageViewSetImageTypeChangesP(void) END_TEST; } + +int UtcDaliImageViewResourceUrlP(void) +{ + ToolkitTestApplication application; + + ImageView imageView = ImageView::New(); + DALI_TEST_CHECK( imageView.GetProperty( ImageView::Property::RESOURCE_URL ).Get< std::string >().empty() ); + + imageView.SetProperty( ImageView::Property::RESOURCE_URL, "TestString" ); + DALI_TEST_EQUALS( imageView.GetProperty( ImageView::Property::RESOURCE_URL ).Get< std::string >(), "TestString", TEST_LOCATION ); + + END_TEST; +} diff --git a/dali-toolkit/internal/controls/image-view/image-view-impl.cpp b/dali-toolkit/internal/controls/image-view/image-view-impl.cpp index 714701a..e98f539 100644 --- a/dali-toolkit/internal/controls/image-view/image-view-impl.cpp +++ b/dali-toolkit/internal/controls/image-view/image-view-impl.cpp @@ -33,6 +33,7 @@ BaseHandle Create() // Setup properties, signals and actions using the type-registry. DALI_TYPE_REGISTRATION_BEGIN( Toolkit::ImageView, Toolkit::Control, Create ); +DALI_PROPERTY_REGISTRATION( Toolkit, ImageView, "resourceUrl", STRING, RESOURCE_URL ) DALI_PROPERTY_REGISTRATION( Toolkit, ImageView, "image", MAP, IMAGE ) DALI_TYPE_REGISTRATION_END() @@ -231,6 +232,16 @@ void ImageView::SetProperty( BaseObject* object, Property::Index index, const Pr { switch ( index ) { + case Toolkit::ImageView::Property::RESOURCE_URL: + { + std::string imageUrl; + if( value.Get( imageUrl ) ) + { + GetImpl( imageView ).SetImage( imageUrl, ImageDimensions() ); + } + break; + } + case Toolkit::ImageView::Property::IMAGE: { std::string imageUrl; @@ -264,6 +275,16 @@ Property::Value ImageView::GetProperty( BaseObject* object, Property::Index prop { switch ( propertyIndex ) { + case Toolkit::ImageView::Property::RESOURCE_URL: + { + ImageView& impl = GetImpl( imageview ); + if ( !impl.mUrl.empty() ) + { + value = impl.mUrl; + } + break; + } + case Toolkit::ImageView::Property::IMAGE: { ImageView& impl = GetImpl( imageview ); diff --git a/dali-toolkit/public-api/controls/image-view/image-view.h b/dali-toolkit/public-api/controls/image-view/image-view.h index f3b5416..efbc884 100644 --- a/dali-toolkit/public-api/controls/image-view/image-view.h +++ b/dali-toolkit/public-api/controls/image-view/image-view.h @@ -62,7 +62,8 @@ public: { enum { - IMAGE = PROPERTY_START_INDEX, ///< name "image", @see SetImage(), type string if it is a url, map otherwise + RESOURCE_URL = PROPERTY_START_INDEX, ///< name "resourceUrl", @deprecated DALi 1.1.16 Use IMAGE instead. type string + IMAGE, ///< name "image", @see SetImage(), type string if it is a url, map otherwise }; }; -- 2.7.4