From 18b2fbead069731d9deb5a634cf98c433d172bbe Mon Sep 17 00:00:00 2001 From: Francisco Santos Date: Tue, 19 Sep 2017 14:00:09 +0100 Subject: [PATCH] Change raw pointer to unique_ptr Change-Id: Iac87ac8bfa4e9677dd5e4d13c7b37a3b4d515f79 --- dali-toolkit/internal/visuals/image/image-visual.cpp | 9 ++++----- dali-toolkit/internal/visuals/image/image-visual.h | 4 +++- dali-toolkit/internal/visuals/texture-manager-impl.h | 4 +++- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/dali-toolkit/internal/visuals/image/image-visual.cpp b/dali-toolkit/internal/visuals/image/image-visual.cpp index 8961b4b..5dbd3cd 100644 --- a/dali-toolkit/internal/visuals/image/image-visual.cpp +++ b/dali-toolkit/internal/visuals/image/image-visual.cpp @@ -261,7 +261,7 @@ ImageVisual::ImageVisual( VisualFactoryCache& factoryCache, mPixelArea( FULL_TEXTURE_RECT ), mPlacementActor(), mImageUrl( imageUrl ), - mMaskingData( NULL ), + mMaskingData( ), mDesiredSize( size ), mTextureId( TextureManager::INVALID_TEXTURE_ID ), mFittingMode( fittingMode ), @@ -279,7 +279,7 @@ ImageVisual::ImageVisual( VisualFactoryCache& factoryCache, const Image& image ) mPixelArea( FULL_TEXTURE_RECT ), mPlacementActor(), mImageUrl(), - mMaskingData( NULL ), + mMaskingData( ), mDesiredSize(), mTextureId( TextureManager::INVALID_TEXTURE_ID ), mFittingMode( FittingMode::DEFAULT ), @@ -304,7 +304,6 @@ ImageVisual::~ImageVisual() textureManager.Remove( mMaskingData->mAlphaMaskId ); } } - delete mMaskingData; } void ImageVisual::DoSetProperties( const Property::Map& propertyMap ) @@ -509,9 +508,9 @@ void ImageVisual::DoSetProperty( Property::Index index, const Property::Value& v void ImageVisual::AllocateMaskData() { - if( mMaskingData == NULL ) + if( !mMaskingData ) { - mMaskingData = new TextureManager::MaskingData(); + mMaskingData.reset(new TextureManager::MaskingData()); } } diff --git a/dali-toolkit/internal/visuals/image/image-visual.h b/dali-toolkit/internal/visuals/image/image-visual.h index bee6067..a95753c 100644 --- a/dali-toolkit/internal/visuals/image/image-visual.h +++ b/dali-toolkit/internal/visuals/image/image-visual.h @@ -19,6 +19,8 @@ */ // EXTERNAL INCLUDES +#include + #include #include #include @@ -319,7 +321,7 @@ private: Vector4 mPixelArea; WeakHandle mPlacementActor; VisualUrl mImageUrl; - TextureManager::MaskingData* mMaskingData; + TextureManager::MaskingDataPointer mMaskingData; Dali::ImageDimensions mDesiredSize; TextureManager::TextureId mTextureId; diff --git a/dali-toolkit/internal/visuals/texture-manager-impl.h b/dali-toolkit/internal/visuals/texture-manager-impl.h index 868afdc..7a243fd 100644 --- a/dali-toolkit/internal/visuals/texture-manager-impl.h +++ b/dali-toolkit/internal/visuals/texture-manager-impl.h @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include @@ -115,6 +116,7 @@ public: float mContentScaleFactor; bool mCropToMask; }; + using MaskingDataPointer = std::unique_ptr; /** * Constructor. @@ -131,7 +133,7 @@ public: TextureSet LoadTexture(VisualUrl& url, Dali::ImageDimensions desiredSize, Dali::FittingMode::Type fittingMode, Dali::SamplingMode::Type samplingMode, - MaskingData* maskInfo, bool synchronousLoading, + const MaskingDataPointer& maskInfo, bool synchronousLoading, TextureManager::TextureId& textureId, Vector4& textureRect, bool& atlasingStatus, bool& loadingStatus, Dali::WrapMode::Type wrapModeU, Dali::WrapMode::Type wrapModeV, TextureUploadObserver* textureObserver, -- 2.7.4