From 08ac586b9e0ce6ac9a0ad11a390572731c2426f1 Mon Sep 17 00:00:00 2001 From: Victor Cebollada Date: Thu, 3 Jul 2014 11:53:42 +0100 Subject: [PATCH] Fix TET cases for toolkit Change-Id: I0b75c7b8aaa749ac335f251b00f193800ffc3f34 Signed-off-by: Victor Cebollada Signed-off-by: Adeel Kazmi --- .../dali-toolkit-test-utils/test-platform-abstraction.cpp | 12 +++++------- .../dali-toolkit-test-utils/test-platform-abstraction.h | 15 +++++++++------ 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.cpp b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.cpp index 218279a..6b6a8f8 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.cpp +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.cpp @@ -160,7 +160,7 @@ bool TestPlatformAbstraction::IsLoading() /** * @copydoc PlatformAbstraction::GetDefaultFontFamily() */ -std::string TestPlatformAbstraction::GetDefaultFontFamily() const +const std::string& TestPlatformAbstraction::GetDefaultFontFamily() const { mTrace.PushCall("GetDefaultFontFamily", ""); return mGetDefaultFontFamilyResult; @@ -169,13 +169,13 @@ std::string TestPlatformAbstraction::GetDefaultFontFamily() const /** * @copydoc PlatformAbstraction::GetDefaultFontSize() */ -const float TestPlatformAbstraction::GetDefaultFontSize() const +float TestPlatformAbstraction::GetDefaultFontSize() const { mTrace.PushCall("GetDefaultFontSize", ""); return mGetDefaultFontSizeResult; } -const PixelSize TestPlatformAbstraction::GetFontLineHeightFromCapsHeight(const std::string& fontFamily, const std::string& fontStyle, const CapsHeight& capsHeight) const +PixelSize TestPlatformAbstraction::GetFontLineHeightFromCapsHeight(const std::string& fontFamily, const std::string& fontStyle, CapsHeight capsHeight) const { mTrace.PushCall("GetFontLineHeightFromCapsHeight", ""); // LineHeight will be bigger than CapsHeight, so return capsHeight + 1 @@ -310,7 +310,7 @@ void TestPlatformAbstraction::SetDpi (unsigned int dpiHorizontal, unsigned int d /** * @copydoc PlatformAbstraction::GetFontFamilyForChars() */ -std::string TestPlatformAbstraction::GetFontFamilyForChars(const TextArray& charsRequested) const +const std::string& TestPlatformAbstraction::GetFontFamilyForChars(const TextArray& charsRequested) const { mTrace.PushCall("GetFontFamilyForChars", ""); return mGetDefaultFontFamilyResult; @@ -337,12 +337,10 @@ bool TestPlatformAbstraction::ValidateFontFamilyName(const std::string& fontFami /** * @copydoc PlatformAbstraction::GetFontList() */ -std::vector TestPlatformAbstraction::GetFontList( PlatformAbstraction::FontListMode mode ) const +void TestPlatformAbstraction::GetFontList( PlatformAbstraction::FontListMode mode, std::vector& fonstList ) const { mFontListMode = mode; mTrace.PushCall("ValidateGetFontList", ""); - std::vector fontList; - return fontList; } /** diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.h b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.h index fb66434..4723d90 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.h +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-platform-abstraction.h @@ -19,11 +19,11 @@ */ // EXTERNAL INCLUDES -#include #include #include // INTERNAL INCLUDES +#include #include #include @@ -139,14 +139,17 @@ public: /** * @copydoc PlatformAbstraction::GetDefaultFontFamily() */ - virtual std::string GetDefaultFontFamily() const; + virtual const std::string& GetDefaultFontFamily() const; /** * @copydoc PlatformAbstraction::GetDefaultFontSize() */ - virtual const float GetDefaultFontSize() const; + virtual float GetDefaultFontSize() const; - virtual const Dali::PixelSize GetFontLineHeightFromCapsHeight(const std::string& fontFamily, const std::string& fontStyle, const CapsHeight& capsHeight) const; + /** + * @copydoc PlatformAbstraction::GetFontLineHeightFromCapsHeight() + */ + virtual Dali::PixelSize GetFontLineHeightFromCapsHeight(const std::string& fontFamily, const std::string& fontStyle, CapsHeight capsHeight) const; /** * @copydoc PlatformAbstraction::GetGlyphData() @@ -182,7 +185,7 @@ public: /** * @copydoc PlatformAbstraction::GetFontFamilyForChars() */ - virtual std::string GetFontFamilyForChars(const TextArray& charsRequested) const; + virtual const std::string& GetFontFamilyForChars(const TextArray& charsRequested) const; /** * @copydoc PlatformAbstraction::AllGlyphsSupported() @@ -197,7 +200,7 @@ public: /** * @copydoc PlatformAbstraction::GetFontList() */ - virtual std::vector GetFontList( PlatformAbstraction::FontListMode mode ) const; + virtual void GetFontList( PlatformAbstraction::FontListMode mode, std::vector& fontList ) const; /** * @copydoc PlatformAbstraction::LoadFile() -- 2.7.4