platform/core/uifw/dali-toolkit.git
3 months agofix incorrect calculaion of natural size in text 13/276413/1
Bowon Ryu [Thu, 16 Jun 2022 02:16:34 +0000 (11:16 +0900)]
fix incorrect calculaion of natural size in text

In DoRelayout of GetNaturalSize/GetHeightForWidth,
operationsPending should inlcude LAYOUT.
Without this, incorrect size calculations will occur.

Change-Id: I4cfcf392d07eac2b5929b7b2cc36d08c8fc519a8
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 months agoAdd observer during ProcessLoadQueue 26/276326/6
Eunki, Hong [Tue, 14 Jun 2022 12:21:44 +0000 (21:21 +0900)]
Add observer during ProcessLoadQueue

Due to we request LoadTexture multiple time during ProcessLoadQueue,
same AnimatedImageLoading can be requested on multiple ImageLoadThread.

Decode same textureId in multiple thread is just waste the CPU resource.

This patch make we add observer in ProcessLoadQueue.

Change-Id: I5656befa209db967e0a6f1ccd90959f38ff731fc
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoThe FocusChanged event callback is called before the FocusLost 89/276289/7
joogab.yun [Tue, 14 Jun 2022 05:37:42 +0000 (14:37 +0900)]
The FocusChanged event callback is called before the FocusLost

Change-Id: I131c7e32a4372b54b2b57c5acf53bfdc5a82c15a

3 months agoMerge "[AT-SPI] Fix EditableTextControlAccessible::InsertText()" into devel/master
Lukasz Oleksak [Mon, 13 Jun 2022 06:31:58 +0000 (06:31 +0000)]
Merge "[AT-SPI] Fix EditableTextControlAccessible::InsertText()" into devel/master

3 months agoDALi Version 2.1.26 74/276174/1 dali_2.1.26
Adam Bialogonski [Fri, 10 Jun 2022 08:53:42 +0000 (09:53 +0100)]
DALi Version 2.1.26

Change-Id: I653b9e9c59e0273ff52582a065e13d836f00cf04

3 months ago[AT-SPI] Fix EditableTextControlAccessible::InsertText() 82/276082/5
Artur Świgoń [Thu, 9 Jun 2022 09:31:37 +0000 (11:31 +0200)]
[AT-SPI] Fix EditableTextControlAccessible::InsertText()

This method did not work when appending to the end of the text
(including the case where the text was initially empty).

Change-Id: I981531feb1eea3d067a06292104145d48de0a76f

3 months agoMerge "Fix text AutoScroll ellipsis issue" into devel/master
Bowon Ryu [Thu, 9 Jun 2022 10:28:54 +0000 (10:28 +0000)]
Merge "Fix text AutoScroll ellipsis issue" into devel/master

3 months agoMerge "Resolve incorrect position for Ellipsis when mixed LTR & RTL languages and...
Bowon Ryu [Thu, 9 Jun 2022 09:49:27 +0000 (09:49 +0000)]
Merge "Resolve incorrect position for Ellipsis when mixed LTR & RTL languages and set layout direction RTL" into devel/master

3 months agoMerge "Remove useless iteration when debug mode" into devel/master
Eunki Hong [Thu, 9 Jun 2022 09:30:56 +0000 (09:30 +0000)]
Merge "Remove useless iteration when debug mode" into devel/master

3 months agoRemove useless iteration when debug mode 68/276068/2
Eunki, Hong [Thu, 9 Jun 2022 06:24:54 +0000 (15:24 +0900)]
Remove useless iteration when debug mode

Some API; like fontClient.GetDescription, are very slow.
But these result values only used for debug log printing.

This patch make some useless iteration will not works for
normal debug mode + NoLogging level.

Change-Id: I1feafda4d18b46902724a3cd305a1a87e030bfd5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoFix include path value of scene-loader 71/276071/1
Heeyong Song [Thu, 9 Jun 2022 06:41:44 +0000 (15:41 +0900)]
Fix include path value of scene-loader

Change-Id: I9753119ea72cc3db33f7251ef5d9235389f6c5a8

3 months agoMerge "Free GlyphData buffer" into devel/master
Adeel Kazmi [Wed, 8 Jun 2022 15:39:40 +0000 (15:39 +0000)]
Merge "Free GlyphData buffer" into devel/master

3 months agoResolve incorrect position for Ellipsis when mixed LTR & RTL languages and set layout... 95/275895/6
ssabah [Sun, 5 Jun 2022 12:08:04 +0000 (15:08 +0300)]
Resolve incorrect position for Ellipsis when mixed LTR & RTL languages and set layout direction RTL

Here's sample code for issues:
    //Case 1:
    TextLabel textLabel = TextLabel::New("Projector استكشاف");
    textLabel.SetProperty(Dali::Toolkit::DevelTextLabel::Property::ELLIPSIS, true);
    textLabel.SetProperty(Dali::Toolkit::DevelTextLabel::Property::ELLIPSIS_POSITION, Dali::Toolkit::DevelText::EllipsisPosition::END);
    textLabel.SetProperty(Dali::Actor::Property::LAYOUT_DIRECTION, LayoutDirection::RIGHT_TO_LEFT);
    textLabel.SetProperty(Actor::Property::SIZE, Vector2(145.0f, 60.0f)); // minimize width until the ellipsis comes between two languages

    //Case 2:
    TextLabel textLabel = TextLabel::New("استكشاف Projector");
    textLabel.SetProperty(Dali::Toolkit::DevelTextLabel::Property::ELLIPSIS, true);
    textLabel.SetProperty(Dali::Toolkit::DevelTextLabel::Property::ELLIPSIS_POSITION, Dali::Toolkit::DevelText::EllipsisPosition::START);
    textLabel.SetProperty(Dali::Actor::Property::LAYOUT_DIRECTION, LayoutDirection::RIGHT_TO_LEFT);
    textLabel.SetProperty(Actor::Property::SIZE, Vector2(145.0f, 60.0f)); // minimize width until the ellipsis comes between two languages

Change-Id: Ia645d143083074383f4db3b8b2407810b69e4862

3 months agoMake visualOffset as Absolute scale. 18/276018/1
Eunki, Hong [Wed, 8 Jun 2022 12:05:13 +0000 (21:05 +0900)]
Make visualOffset as Absolute scale.

offset / uSize.xy might make some precision issue.
For example, tiling use TRANSFORM_OFFSET.
If tiling has some high value, vertex position might missmatched.

This patch will reduce precision.

Change-Id: I185595680c882d75e989d864053079f801d14440
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoFix text AutoScroll ellipsis issue 97/275997/1
Bowon Ryu [Tue, 7 Jun 2022 16:19:50 +0000 (01:19 +0900)]
Fix text AutoScroll ellipsis issue

Text should ellipsis while AutoScroll is running
when text length is bigger than MaxTextureSize.

this issue occurs as a side effect of another patch.
74f7af1b08ce65dde5959d22b2d533cbc64b9d2e

the height comparison condition is for another AutoScroll ellipsis issue
and this should not be removed.

Change-Id: I18a4011bec882e483bc0c184417403661a9fa635
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 months agoFree GlyphData buffer 79/275979/1
Eunki, Hong [Wed, 8 Jun 2022 04:55:40 +0000 (13:55 +0900)]
Free GlyphData buffer

We make GlyphData's buffer as malloc.
So, we need to change the release method as free.

Change-Id: Id3c1b7ed9f6b8683b05440edc1c6f52fca5fb6c1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoMerge "Fix bug when we use bitmap font." into devel/master
Adeel Kazmi [Tue, 7 Jun 2022 15:33:13 +0000 (15:33 +0000)]
Merge "Fix bug when we use bitmap font." into devel/master

3 months agoFix bug when we use bitmap font. 68/275968/2
Eunki, Hong [Tue, 7 Jun 2022 13:42:50 +0000 (22:42 +0900)]
Fix bug when we use bitmap font.

We can use custom bitmap font without using glyph.
In this case, glyphBuffer can be RGBA.

Current logic assume that glyphBuffer only L8 if isColor is false.
This patch it that case works well

Change-Id: Ia68bfb4a292cb4bc34f4041b55f2a9d661e58df7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoMake some visual use DecoratedVisualRenderer 63/274263/16
Eunki, Hong [Mon, 25 Apr 2022 10:41:39 +0000 (19:41 +0900)]
Make some visual use DecoratedVisualRenderer

Make some visual use DecoratedVisualRenderer s.t. use some properties as default :
 CORNER_RADIUS
 CORNER_RADIUS_POLICY
 BORDERLINE_WIDTH
 BORDERLINE_COLOR
 BORDERLINE_OFFSET
 BLUR_RADIUS

Now BORDERLINE_WIDTH and BLUR_RADIUS informations can be accessed in
dali-core level. So we can calculate update size

Change-Id: Ib9d20d202a939acf70eac12f602b05c1451e1030
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoMerge "Minor reduce textlabel creation time." into devel/master
Adeel Kazmi [Tue, 7 Jun 2022 09:59:22 +0000 (09:59 +0000)]
Merge "Minor reduce textlabel creation time." into devel/master

3 months agoDelete useless define of default shaders 56/275156/5
Eunki, Hong [Tue, 17 May 2022 09:51:37 +0000 (18:51 +0900)]
Delete useless define of default shaders

We can use #if defined(~~) instead of #ifndef ~~ #define ~~ 0
Now we can check the shader more clean environment.

Change-Id: Icaf79367ccdeb0a3bd53d47aaacd00ad8f352a64
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoMinor reduce textlabel creation time. 81/275581/11
Eunki, Hong [Thu, 26 May 2022 12:54:19 +0000 (21:54 +0900)]
Minor reduce textlabel creation time.

1. Reduce the multiply operations during TypeSetter
combine each glyph on bitmap.

2. Every textlabel hold it's own TextController
and each TextController try to get StyleManager's configure.

In this case, there was some operation
from const Property::Map to Property::Map. It required vector copy.
So I make that we don't copy the vector anymore.

Change-Id: Ie2853b54d8dc0e6685bb11afe7d91faaae0b5acd
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoMerge "Fix visual defect during text scroll" into devel/master
Eunki Hong [Fri, 3 Jun 2022 11:37:42 +0000 (11:37 +0000)]
Merge "Fix visual defect during text scroll" into devel/master

3 months agoSync UTC with text shape method. 69/275869/1
Eunki, Hong [Fri, 3 Jun 2022 09:10:49 +0000 (18:10 +0900)]
Sync UTC with text shape method.

Harfbuzz shape algorithm have some bug if we use Emoji.
So, make UTC don't check advance value if we test Emoji.

Change-Id: I502c6b9ed4233b27723d9f379c958fb718d9c928
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoFix visual defect during text scroll 14/275814/2
Eunki, Hong [Thu, 2 Jun 2022 05:54:18 +0000 (14:54 +0900)]
Fix visual defect during text scroll

Change-Id: Idf9d2f3bbf08dcb0832b1493ce9c3526f12440ae
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 months agoMerge "DALi Version 2.1.25" into devel/master
David Steele [Wed, 1 Jun 2022 10:56:18 +0000 (10:56 +0000)]
Merge "DALi Version 2.1.25" into devel/master

3 months agoDALi Version 2.1.25 71/275771/1 dali_2.1.25
Richard Huang [Wed, 1 Jun 2022 10:15:11 +0000 (11:15 +0100)]
DALi Version 2.1.25

Change-Id: I87da0bfd9384da3a3d9c3a1192d7e6234925cd11

3 months agoMerge "Fix svace issue for dli-extra" into devel/master
David Steele [Wed, 1 Jun 2022 08:42:40 +0000 (08:42 +0000)]
Merge "Fix svace issue for dli-extra" into devel/master

3 months agoMerge "Refactoring related-runs for the mutable-markup (Spannable)" into devel/master
Bowon Ryu [Tue, 31 May 2022 10:55:22 +0000 (10:55 +0000)]
Merge "Refactoring related-runs for the mutable-markup (Spannable)" into devel/master

4 months agoRefactoring related-runs for the mutable-markup (Spannable) 00/275100/3
ssabah [Mon, 16 May 2022 13:51:13 +0000 (16:51 +0300)]
Refactoring related-runs for the mutable-markup (Spannable)

We created common abstract class to inherit all run class that are needed for mutable-markup (Spannable)
  - ColorRun
  - CharacterSpacingCharacterRun
  - FontDescriptionRun
  - UnderlinedCharacterRun
  - StrikethroughCharacterRun
  - BoundedParagraphRun

Change-Id: I47cea29e0c9d833068b731402de68ae20cabb9d9

4 months agoIgnore vertical line alignment when the line spacing is negative 03/274903/5
ssabah [Wed, 11 May 2022 14:21:06 +0000 (17:21 +0300)]
Ignore vertical line alignment when the line spacing is negative

This is to resolved cut-off in first-line when line-spacing is negative
 and vertical line alignment is bottom or middle.

Testing code:
https://github.com/wonrst/NUI-Test/blob/main/text-vertical-line-align/verticalline.cs

This patch should be preceded by the patch below:
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/274097

Change-Id: I80e6d838ad08f7f34d79f6018bb44ae467c7a89a

4 months agofix issue with VerticalLineAlignment with multiple font sizes 97/274097/6
Abdulleh Ghujeh [Wed, 20 Apr 2022 10:07:07 +0000 (13:07 +0300)]
fix issue with VerticalLineAlignment with multiple font sizes

when having multi-line, every line contains text that have different font size.
VerticalLineAlignment does not work properly.

Change-Id: I89b2a1b0c3a01c6cd79dc8de3c0e42876e2b7251

4 months agoFix svace issue for dli-extra 80/275680/1
seungho [Mon, 30 May 2022 04:55:50 +0000 (13:55 +0900)]
Fix svace issue for dli-extra

Change-Id: Ide4188cd0df8b114428175c0a490f46dc0d43a54
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoEnable to use GPU masking in image visual 26/275226/16
seungho [Wed, 18 May 2022 12:08:22 +0000 (21:08 +0900)]
Enable to use GPU masking in image visual

Change-Id: I37673b02dfa6764a1ebf87a68193c839a6b6212d
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoMerge "DALi Version 2.1.24" into devel/master
Adeel Kazmi [Fri, 27 May 2022 12:18:51 +0000 (12:18 +0000)]
Merge "DALi Version 2.1.24" into devel/master

4 months agoMerge "GPU Alpha Masking for Animated Image Visual" into devel/master
Seungho BAEK [Fri, 27 May 2022 12:13:16 +0000 (12:13 +0000)]
Merge "GPU Alpha Masking for Animated Image Visual" into devel/master

4 months agoDALi Version 2.1.24 38/275638/1 dali_2.1.24
Adeel Kazmi [Fri, 27 May 2022 12:01:05 +0000 (13:01 +0100)]
DALi Version 2.1.24

Change-Id: I84e156bccaccb2b977b1ddca2c59d6f58a75bf86

4 months agoGPU Alpha Masking for Animated Image Visual 61/275061/14
seungho [Mon, 16 May 2022 06:09:59 +0000 (15:09 +0900)]
GPU Alpha Masking for Animated Image Visual

Change-Id: I7d0f44a73063a16d1e57acf40739c58239487c43
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoFix automated test failures about the SvgVisual 05/275605/1
Heeyong Song [Fri, 27 May 2022 02:52:42 +0000 (11:52 +0900)]
Fix automated test failures about the SvgVisual

Change-Id: I4aef4278e54337e484ef66a4dfa5229c407fbd5e

4 months agoMerge "Apply premultiply in animated image visual" into devel/master
sunghyun kim [Thu, 26 May 2022 10:10:30 +0000 (10:10 +0000)]
Merge "Apply premultiply in animated image visual" into devel/master

4 months agoMerge "Fix key event propagation in text controller" into devel/master
Bowon Ryu [Thu, 26 May 2022 09:38:52 +0000 (09:38 +0000)]
Merge "Fix key event propagation in text controller" into devel/master

4 months agoMerge "Trigger svg loading early" into devel/master
Heeyong Song [Thu, 26 May 2022 01:08:39 +0000 (01:08 +0000)]
Merge "Trigger svg loading early" into devel/master

4 months agoTrigger svg loading early 61/275161/4
Heeyong Song [Tue, 17 May 2022 10:41:10 +0000 (19:41 +0900)]
Trigger svg loading early

Change-Id: Ie715e242d32ca68060c8503809222960f545ae60

4 months agoApply premultiply in animated image visual 08/275308/4
tscholb [Fri, 20 May 2022 09:38:29 +0000 (18:38 +0900)]
Apply premultiply in animated image visual

animated-image-visual not properly apply premultiply.
so i make this patch to apply it.

Change-Id: I8b0a2b123ba6789f91163169ded93e07c6170e49

4 months agoThe FocusChanged event callback is called before the FocusLost and FocusGained event... 56/275456/2
joogab.yun [Wed, 25 May 2022 05:15:23 +0000 (14:15 +0900)]
The FocusChanged event callback is called before the FocusLost and FocusGained event callbacks.

Change-Id: Idb145bdd0f9f74e84287ab783a34a72485667ae8

4 months agoFix key event propagation in text controller 11/275411/3
Bowon Ryu [Tue, 24 May 2022 12:05:06 +0000 (21:05 +0900)]
Fix key event propagation in text controller

The KeyEvent::UP of DALI_KEY_BACK is not propagated from text controller,
this interferes with the behavior of the parent view in some cases.

Change-Id: Ib20c6f91203af2c27d1030cc2025964f87834195
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
4 months agoMerge "Add text selection popup style" into devel/master
Bowon Ryu [Mon, 23 May 2022 05:11:56 +0000 (05:11 +0000)]
Merge "Add text selection popup style" into devel/master

4 months agoMerge "DALi Version 2.1.23" into devel/master
Adeel Kazmi [Fri, 20 May 2022 12:26:35 +0000 (12:26 +0000)]
Merge "DALi Version 2.1.23" into devel/master

4 months agoDALi Version 2.1.23 12/275312/1 dali_2.1.23
Adam Bialogonski [Fri, 20 May 2022 10:16:31 +0000 (11:16 +0100)]
DALi Version 2.1.23

Change-Id: I1699d66d1291c2cc98b22a5bd4ada63b25aa10be

4 months ago[AT-SPI] Make DevelControl::GetAccessibilityRelations() equivalent to Accessible... 35/275035/5
Artur Świgoń [Fri, 13 May 2022 11:42:32 +0000 (13:42 +0200)]
[AT-SPI] Make DevelControl::GetAccessibilityRelations() equivalent to Accessible::GetRelationSet()

The previous std::vector<std::vector<Address>> return type, in which the
RelationType enumeration value served as an index to the outer vector,
can be changed to std::vector<Relation>, which is more compact (there
are very few relations per control in practice). Also, the relation
target type is now Accessible*, which is more useful than Address.

Change-Id: I9f7b86d7415e1711b8a81cd66e271ff9cdffd5c2

4 months agoAdd text selection popup style 01/273601/9
Bowon Ryu [Fri, 8 Apr 2022 09:59:45 +0000 (18:59 +0900)]
Add text selection popup style

Change-Id: I8d9a34784d485a70fb244b1eaecca0e299a4b90b
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
4 months agoFix text render issue when use tiling 22/275222/1
Eunki, Hong [Wed, 18 May 2022 11:22:32 +0000 (20:22 +0900)]
Fix text render issue when use tiling

Due to the "uTextColorAnimatable" uniform values are not registered
into tiling renderer, It show some strange color when we required
some tiling text feature.

This patch make that all other renderers in mRenderList also have
there own constraint relative with TextLabel's TEXT_COLOR index
so tilied renderes also rendering well

Change-Id: I36198372f1a585529b25080919bf96be939577fa
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
4 months agoStore VisualUrl's hash result, and reuse it 71/275071/2
Eunki, Hong [Mon, 16 May 2022 08:48:14 +0000 (17:48 +0900)]
Store VisualUrl's hash result, and reuse it

When we request load of animated image visual,
It will generate the image url's hash for every frame.

This patch cache the VisualUrl's hash result so
We don't need to re-calculate hash for the same image url.

Change-Id: I637e7d2dc141f25164fb96337d76031f44c2152f
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
4 months agoMerge "Change conflict of some visual's Impl namespace" into devel/master
Eunki Hong [Wed, 18 May 2022 09:09:18 +0000 (09:09 +0000)]
Merge "Change conflict of some visual's Impl namespace" into devel/master

4 months agoMerge "Optimize some text-typesetter rendering operations" into devel/master
Eunki Hong [Wed, 18 May 2022 08:04:33 +0000 (08:04 +0000)]
Merge "Optimize some text-typesetter rendering operations" into devel/master

4 months agoMerge "Fix Textlabel bug if size height is bigger than 16384" into devel/master
Eunki Hong [Wed, 18 May 2022 08:04:08 +0000 (08:04 +0000)]
Merge "Fix Textlabel bug if size height is bigger than 16384" into devel/master

4 months agoOptimize some text-typesetter rendering operations 09/275009/11
Eunki, Hong [Fri, 13 May 2022 06:30:25 +0000 (15:30 +0900)]
Optimize some text-typesetter rendering operations

1. Make pixelwise iterations range more tightly.
ex) for(i=0;~~) if(i<X) continue; --> for(i=X;~~)

2. Make some pixelwise operations use precalculated color
ex) in DrawBackgroundColor, we don't change the target color.
So, we can specificate that color will be writed for each pixel.

It can reduce some float point data operations.

3. Make CombineImageBuffer reuse the memory.
CombineImageBuffer only used in Typesetter class. (It was private API)
and this API never use it's member value.
And also, All that API caller replace one of pixel buffer
either top or bottom.

So now, I move this API in unnamed namespace function +
store the result into already exist pixel buffer
so we can reduce some memory allocation time.

Change-Id: Id20b2b75e39ccf56b7d08f0b8c8e1e6bea4b7820
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
4 months agoMerge "Make highp for some variable for 3d model shader" into devel/master
Seungho BAEK [Tue, 17 May 2022 10:53:44 +0000 (10:53 +0000)]
Merge "Make highp for some variable for 3d model shader" into devel/master

4 months agoFix Textlabel bug if size height is bigger than 16384 54/275154/4
Eunki, Hong [Tue, 17 May 2022 09:12:36 +0000 (18:12 +0900)]
Fix Textlabel bug if size height is bigger than 16384

Instance fix bug.
text-style shader requied both style texture and overlay style texture.
But for some special case, overlay style texture didnt applied.

TODO : Actually, we need to shrink text relative shaders.
It should be done in future.

Change-Id: Ib2239d5e3b13b946cac964e494027dbaebfe6a02
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
4 months agoMerge "Support asynchronous svg loading" into devel/master
Heeyong Song [Tue, 17 May 2022 10:11:45 +0000 (10:11 +0000)]
Merge "Support asynchronous svg loading" into devel/master

4 months agoMake highp for some variable for 3d model shader 98/275098/3
seungho [Mon, 16 May 2022 13:54:41 +0000 (22:54 +0900)]
Make highp for some variable for 3d model shader

Change-Id: Iecff23b041466ef4d9086989813da85715a2c115
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoMake shader version be top of the code 87/275087/2
seungho [Mon, 16 May 2022 11:35:30 +0000 (20:35 +0900)]
Make shader version be top of the code

Change-Id: Iaa2ab8e68bd43ea8e439cbfbc1fd04f0a45349a5
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoChange conflict of some visual's Impl namespace 78/275078/1
Eunki, Hong [Mon, 16 May 2022 10:33:40 +0000 (19:33 +0900)]
Change conflict of some visual's Impl namespace

ConnectionTracker now use struct Impl.
So, some namespaces conflict with that names usage.

Change-Id: Iae4e1d165e624c331e7c6e6035727a29bcdd9e20
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
4 months agoModify default shader according to the gltf pbr spec 75/274275/27
seungho [Mon, 25 Apr 2022 14:38:15 +0000 (23:38 +0900)]
Modify default shader according to the gltf pbr spec

 - Add uColorFactor.
   In glTF, color factor can be used as a color when there isn't color texture,
   but it is also used to be multiplied with base color that is sampled from color texture.
   In previous implementation, when there isn't color texture, color factor is converted
   as single pixel texture.
   If the texture is from color factor, we shouldn't multiply color factor again.
   But, we couldn't notify whether the texture is from image file or color factor.

 - Add vertex color

 - Add uMetallicFactor, uRoughnessFactor

 - Use #ifdef instead of single value texture.

 - Use pre-computed brdf texture.

 - Modify alpha mode

Change-Id: I048b793a4481b65da5ce07d0d3e263ae74b2ab59
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoMerge "Apply EncodedImageBuffer with Atlas" into devel/master
David Steele [Fri, 13 May 2022 15:43:39 +0000 (15:43 +0000)]
Merge "Apply EncodedImageBuffer with Atlas" into devel/master

4 months agoMerge "DALi Version 2.1.22" into devel/master
Adeel Kazmi [Fri, 13 May 2022 11:06:29 +0000 (11:06 +0000)]
Merge "DALi Version 2.1.22" into devel/master

4 months agoDALi Version 2.1.22 20/275020/1 dali_2.1.22
Richard Huang [Fri, 13 May 2022 11:01:20 +0000 (12:01 +0100)]
DALi Version 2.1.22

Change-Id: I89d8996908f0852cd10939a7223c6a02036cedc5

4 months agoSupport asynchronous svg loading 81/274881/4
Heeyong Song [Wed, 11 May 2022 09:54:06 +0000 (18:54 +0900)]
Support asynchronous svg loading

Change-Id: I46e977fa00fd9a173663b253867e198ac9c40cc8

4 months ago1. Rather than DoMoveFocusWithinLayoutControl() being done from the parent If the... 11/274611/5
joogab.yun [Tue, 3 May 2022 09:43:16 +0000 (18:43 +0900)]
1. Rather than DoMoveFocusWithinLayoutControl() being done from the parent If the currently focused actor is also a layout Control,
DoMoveFocusWithinLayoutControl() should be performed starting from the currently focused actor.

2. If the actor returned through GetNextKeyboardFocusableActor() is itself, it becomes an infinite loop.
So It should recurse DoMoveFocusWithinLayoutControl() only when not yourself.

Change-Id: I8ad1f868151337a9e13869682c99c5a19b82bb0f

4 months agoReverts the patch that prevents focus set when parent is visible when false due to... 74/274974/1
joogab.yun [Fri, 13 May 2022 03:25:36 +0000 (12:25 +0900)]
Reverts the patch that prevents focus set when parent is visible when false due to backward compatibility issue.

https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/274317/

Change-Id: I5a2152395238596dbccd4e6b064c990a0d802930

4 months agoMerge "Cache animated image's frame index" into devel/master
Eunki Hong [Fri, 13 May 2022 03:00:54 +0000 (03:00 +0000)]
Merge "Cache animated image's frame index" into devel/master

4 months agoApply EncodedImageBuffer with Atlas 46/265346/14
Eunki Hong [Fri, 15 Oct 2021 07:05:58 +0000 (00:05 -0700)]
Apply EncodedImageBuffer with Atlas

Allow to use atlas with EncodedImageBuffer.

Change-Id: Id98ac9507327215c8a8c4b6b04b3460214ac654d
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
4 months agoMerge "[AT-SPI] Call EmbedAtkSocket() from WebViewAccessible" into devel/master
Lukasz Oleksak [Thu, 12 May 2022 13:03:26 +0000 (13:03 +0000)]
Merge "[AT-SPI] Call EmbedAtkSocket() from WebViewAccessible" into devel/master

4 months agoCache animated image's frame index 94/274094/17
Eunki, Hong [Thu, 21 Apr 2022 07:34:31 +0000 (16:34 +0900)]
Cache animated image's frame index

There is no reason to multiple decoding for same-image's same-frame loading.
It just increase our memory useage and CPU usage.

This patch cache animated image's frame index so
we can re-use already decoded frame informations.

+

For more, Due to the animated image decoding can hold big amount of observers
in one frame, we need to reduce runtime of NotifyObservers API.
This patch also reduce NotifyObservers time complexity from O(N^2) to O(N).
Note : We can't add additional observer due to the mQueueLoadFlag flag is true.

Change-Id: I829704c638ce7b6a5feca13cc1bcf75b4bd9e35e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
4 months ago[AT-SPI] Call EmbedAtkSocket() from WebViewAccessible 15/274515/4
Artur Świgoń [Fri, 29 Apr 2022 17:12:36 +0000 (19:12 +0200)]
[AT-SPI] Call EmbedAtkSocket() from WebViewAccessible

This is necessary for the ATK-based AT-SPI subtree of the web content to
know the address of its parent.

Change-Id: I98ad98bc5d016df9a827d733451a4ceda5b429c3

4 months agoDelete YGNode only root of Flex::Node 01/274901/2
Eunki, Hong [Wed, 11 May 2022 14:10:11 +0000 (23:10 +0900)]
Delete YGNode only root of Flex::Node

YGNode remove the memory recursively internally.
If we delete childe node's YGNode, it become double free.

This patch make Flex::Node free only it's own YGNode.

Change-Id: I1f68552ee79d1aa6a503ae67f1b3c1d45c77985b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
4 months agoCPU Alpha Masking for Animated Image Visual 20/274420/10
seungho [Thu, 28 Apr 2022 05:54:59 +0000 (14:54 +0900)]
CPU Alpha Masking for Animated Image Visual

Change-Id: I3b6abac73d248f70998bb992945b96a25c6fb7c8
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoMerge "[AT-SPI] remove isRoot param from Accessible::Get" into devel/master
Shinwoo Kim [Tue, 10 May 2022 05:14:27 +0000 (05:14 +0000)]
Merge "[AT-SPI] remove isRoot param from Accessible::Get" into devel/master

4 months agoMerge "Fix glTF loading issue." into devel/master
Seungho BAEK [Mon, 9 May 2022 02:17:14 +0000 (02:17 +0000)]
Merge "Fix glTF loading issue." into devel/master

4 months ago[AT-SPI] remove isRoot param from Accessible::Get 50/274750/1
Shinwoo Kim [Mon, 9 May 2022 01:54:57 +0000 (10:54 +0900)]
[AT-SPI] remove isRoot param from Accessible::Get

The Accessibility::Accessible::Get for a window could be called
before getting accessible to add window accessible.

So far, we thought that the next part creates an accessible for
window for the first time.

  accessible = Accessibility::Accessible::Get(rootLayer, true);
  bridge->AddTopLevelWindow(accessible);

However, there is a case where it is created before this part
caused by following symbol

  CSharp_Dali_Toolkit_DevelControl_GetAccessibilityStates+0x144

In this case, isRoot is set to `false`. Then window will have
incorrect accessible information.

For more information, please refer to the following.

  https://github.sec.samsung.net/tizen/atspi/issues/60

[Dependency]
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/274737/

Change-Id: Iadca9c42aa2027f372838247ac23b27d484e4c8d

4 months agoMerge "Check window validity" into devel/master
Heeyong Song [Mon, 9 May 2022 00:59:26 +0000 (00:59 +0000)]
Merge "Check window validity" into devel/master

4 months agoDALi Version 2.1.21 13/274713/1 dali_2.1.21
David Steele [Fri, 6 May 2022 11:37:19 +0000 (12:37 +0100)]
DALi Version 2.1.21

Change-Id: Ifd1fa240f5e970e38c3cc3b41c263467b5e93013

4 months agoFix glTF loading issue. 88/274688/2
seungho [Fri, 6 May 2022 05:17:53 +0000 (14:17 +0900)]
Fix glTF loading issue.

Change-Id: Ie6de25d1723d1dcbf739230dc9ea89b411958989
Signed-off-by: seungho <sbsh.baek@samsung.com>
4 months agoCheck window validity 84/274684/1
Heeyong Song [Tue, 26 Apr 2022 03:24:59 +0000 (12:24 +0900)]
Check window validity

Change-Id: I104882efa0cd8506388ddb92328adc4152cdc1b1

4 months agoMerge "Changed default font family of 7.0 IoT UX" into devel/master
Bowon Ryu [Wed, 4 May 2022 07:27:38 +0000 (07:27 +0000)]
Merge "Changed default font family of 7.0 IoT UX" into devel/master

4 months agoMerge "Remove ResourceReady before rasterization in SvgVisual" into devel/master
Heeyong Song [Wed, 4 May 2022 07:05:43 +0000 (07:05 +0000)]
Merge "Remove ResourceReady before rasterization in SvgVisual" into devel/master

4 months agoChanged default font family of 7.0 IoT UX 47/274647/1
Bowon Ryu [Wed, 4 May 2022 06:14:31 +0000 (15:14 +0900)]
Changed default font family of 7.0 IoT UX

SamsungOneUI -> BreezeSans
SamsungOneUI font can not be used as default due to license problem

Change-Id: Ic07defb74bd2205d9aaaae121d405d6f77a8fa65
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
4 months agoMerge "Allows you to specify the root when calculating the focus movement algorithm...
joogab yun [Tue, 3 May 2022 06:56:51 +0000 (06:56 +0000)]
Merge "Allows you to specify the root when calculating the focus movement algorithm." into devel/master

4 months agoMerge "[AT-SPI] ScrollView: Use child postion for ScrollToChild" into devel/master
Shinwoo Kim [Tue, 3 May 2022 03:31:22 +0000 (03:31 +0000)]
Merge "[AT-SPI] ScrollView: Use child postion for ScrollToChild" into devel/master

4 months agoAllows you to specify the root when calculating the focus movement algorithm. 22/274422/5
joogab.yun [Thu, 28 Apr 2022 01:55:01 +0000 (10:55 +0900)]
Allows you to specify the root when calculating the focus movement algorithm.

Change-Id: Id0b1a191301008c979cc00258a75d380e25ca99e

4 months agoRemove ResourceReady before rasterization in SvgVisual 56/273956/4
Heeyong Song [Tue, 19 Apr 2022 03:23:40 +0000 (12:23 +0900)]
Remove ResourceReady before rasterization in SvgVisual

It will use a default size of the content file if the size is not set.

Change-Id: I5dbfe79146a461d412c39ab5dcf37fabd94b683c

4 months agoFix svace error about initialization of member variable 27/274527/1
seungho [Mon, 2 May 2022 01:53:28 +0000 (10:53 +0900)]
Fix svace error about initialization of member variable

 - ShaderDefinition::mUseBuiltInShader

Change-Id: Iec6b11efb6324aac84cf7215dfec7424d68a1ea0
Signed-off-by: seungho <sbsh.baek@samsung.com>
5 months agoRefactoring TextureManager cache as Dali::FreeList 69/270969/53
Eunki, Hong [Fri, 11 Feb 2022 13:36:39 +0000 (22:36 +0900)]
Refactoring TextureManager cache as Dali::FreeList

Apply additional container as Dali::FreeList as TextureIdConverter;
From TextureId to TextureCacheIndex.
and add mTextureHashContainer, key is TextureHash and value is list of TextureId.
These things will make us access mTextureInfoContainer more faster.

Previous code iterate whole std::vector list to find cached texture.
This patch make we can get cacheIndex from textureId as O(1) by Dali::FreeList
and get textureId from textureHash as O(1 * collision)
by std::unordered_map<TextureHash, vector<TextureId>>.

This patch make TextureCacheIndex as a kind of structure. named TextureCacheIndexData.
This data use 4 bit as "TextueCacheIndexType" and 28 bit as "Index".
By this structure, we can use only one TextureIdConverter.
We can know what this TextureId come from ;
NormalImage or ExternalTextures or EncodedImageBuffer.

So now, we can do all API things as near O(1). Without useless iteratating.

It will reduce ImageView's SceneOn and SceneOff time.
And also, reduce AsyncLoadComplete API runtime, that animated image used
every image frame.

Note : After this patch, TextureId will not be unique anymore.
TODO : Masking feature still works on O(N). We need to make new container for it in future.

Change-Id: I37777ccc05fc0541e1f0e65f1d6306d9436c1245
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
5 months agoMerge "DALi Version 2.1.20" into devel/master
Adeel Kazmi [Fri, 29 Apr 2022 12:22:47 +0000 (12:22 +0000)]
Merge "DALi Version 2.1.20" into devel/master

5 months agoDALi Version 2.1.20 01/274501/1 dali_2.1.20
Adam Bialogonski [Fri, 29 Apr 2022 09:52:55 +0000 (10:52 +0100)]
DALi Version 2.1.20

Change-Id: If7d4f644122b73eef460e41fa7ca3c261f8723ad

5 months agoMerge "Fix webp&gif issue" into devel/master
sunghyun kim [Fri, 29 Apr 2022 06:58:41 +0000 (06:58 +0000)]
Merge "Fix webp&gif issue" into devel/master

5 months agoMerge "Caching cropToMask in texture manager" into devel/master
sunghyun kim [Fri, 29 Apr 2022 06:58:21 +0000 (06:58 +0000)]
Merge "Caching cropToMask in texture manager" into devel/master

5 months agoMerge changes I7b63ee17,I61bd1ed2 into devel/master
Seungho BAEK [Fri, 29 Apr 2022 06:48:30 +0000 (06:48 +0000)]
Merge changes I7b63ee17,I61bd1ed2 into devel/master

* changes:
  Use default PBR shader to the scene-loader
  Fix Scene3d-View light issue

5 months agoCaching cropToMask in texture manager 67/272467/4
sunghyun kim [Thu, 17 Mar 2022 06:11:41 +0000 (15:11 +0900)]
Caching cropToMask in texture manager

cropToMask need to be cahing,
so i added this patch

Change-Id: I6fecdfd8bc12a0c5d270c50da50340331ce0917f

5 months agoMerge "Add ECORE_IMF_CALLBACK_SELECTION_SET to IMFContext" into devel/master
Bowon Ryu [Thu, 28 Apr 2022 08:51:47 +0000 (08:51 +0000)]
Merge "Add ECORE_IMF_CALLBACK_SELECTION_SET to IMFContext" into devel/master