From: taeyoon0.lee Date: Wed, 11 Oct 2017 09:05:09 +0000 (+0900) Subject: Revert "[4.0] Change raw pointer to unique_ptr" X-Git-Tag: accepted/tizen/4.0/unified/20171012.230025~16 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=cabdb0d7881466c573d94c82b045a053bd8d2727 Revert "[4.0] Change raw pointer to unique_ptr" This reverts commit 0b5699811bac5ff1b3c92a2245d4ec594cade5e6. Change-Id: Iede97efc88a7935f0fd182137cecb070b71966e9 --- diff --git a/dali-toolkit/internal/visuals/image/image-visual.cpp b/dali-toolkit/internal/visuals/image/image-visual.cpp index 5dbd3cd..8961b4b 100644 --- a/dali-toolkit/internal/visuals/image/image-visual.cpp +++ b/dali-toolkit/internal/visuals/image/image-visual.cpp @@ -261,7 +261,7 @@ ImageVisual::ImageVisual( VisualFactoryCache& factoryCache, mPixelArea( FULL_TEXTURE_RECT ), mPlacementActor(), mImageUrl( imageUrl ), - mMaskingData( ), + mMaskingData( NULL ), mDesiredSize( size ), mTextureId( TextureManager::INVALID_TEXTURE_ID ), mFittingMode( fittingMode ), @@ -279,7 +279,7 @@ ImageVisual::ImageVisual( VisualFactoryCache& factoryCache, const Image& image ) mPixelArea( FULL_TEXTURE_RECT ), mPlacementActor(), mImageUrl(), - mMaskingData( ), + mMaskingData( NULL ), mDesiredSize(), mTextureId( TextureManager::INVALID_TEXTURE_ID ), mFittingMode( FittingMode::DEFAULT ), @@ -304,6 +304,7 @@ ImageVisual::~ImageVisual() textureManager.Remove( mMaskingData->mAlphaMaskId ); } } + delete mMaskingData; } void ImageVisual::DoSetProperties( const Property::Map& propertyMap ) @@ -508,9 +509,9 @@ void ImageVisual::DoSetProperty( Property::Index index, const Property::Value& v void ImageVisual::AllocateMaskData() { - if( !mMaskingData ) + if( mMaskingData == NULL ) { - mMaskingData.reset(new TextureManager::MaskingData()); + mMaskingData = new TextureManager::MaskingData(); } } diff --git a/dali-toolkit/internal/visuals/image/image-visual.h b/dali-toolkit/internal/visuals/image/image-visual.h index a95753c..bee6067 100644 --- a/dali-toolkit/internal/visuals/image/image-visual.h +++ b/dali-toolkit/internal/visuals/image/image-visual.h @@ -19,8 +19,6 @@ */ // EXTERNAL INCLUDES -#include - #include #include #include @@ -321,7 +319,7 @@ private: Vector4 mPixelArea; WeakHandle mPlacementActor; VisualUrl mImageUrl; - TextureManager::MaskingDataPointer mMaskingData; + TextureManager::MaskingData* mMaskingData; Dali::ImageDimensions mDesiredSize; TextureManager::TextureId mTextureId; diff --git a/dali-toolkit/internal/visuals/texture-manager-impl.h b/dali-toolkit/internal/visuals/texture-manager-impl.h index 7a243fd..868afdc 100644 --- a/dali-toolkit/internal/visuals/texture-manager-impl.h +++ b/dali-toolkit/internal/visuals/texture-manager-impl.h @@ -21,7 +21,6 @@ #include #include #include -#include #include #include #include @@ -116,7 +115,6 @@ public: float mContentScaleFactor; bool mCropToMask; }; - using MaskingDataPointer = std::unique_ptr; /** * Constructor. @@ -133,7 +131,7 @@ public: TextureSet LoadTexture(VisualUrl& url, Dali::ImageDimensions desiredSize, Dali::FittingMode::Type fittingMode, Dali::SamplingMode::Type samplingMode, - const MaskingDataPointer& maskInfo, bool synchronousLoading, + MaskingData* maskInfo, bool synchronousLoading, TextureManager::TextureId& textureId, Vector4& textureRect, bool& atlasingStatus, bool& loadingStatus, Dali::WrapMode::Type wrapModeU, Dali::WrapMode::Type wrapModeV, TextureUploadObserver* textureObserver,