From: Seoyeon Kim Date: Wed, 22 Jan 2020 06:37:52 +0000 (+0900) Subject: Fix Coverity issue X-Git-Tag: dali_1.4.56~3^2 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=c81df74b4066a9c6d6f4c4565cbd0a7985f5e068 Fix Coverity issue - If the variable 'pixelFormat' is deliberately set to RGB16F or RGB32F, then Pixel::GetBytesPerPixel() returns 12u or 24u. - Then, 'Out-of-bound' error may occur because the return value exceeds the scope of 'outputColor' array. Change-Id: I5674b20d8976b925e12444eb9fc611e0d5633f49 Signed-off-by: Seoyeon Kim --- diff --git a/dali-toolkit/devel-api/text/text-utils-devel.cpp b/dali-toolkit/devel-api/text/text-utils-devel.cpp index fae3c10..fc8afb9 100755 --- a/dali-toolkit/devel-api/text/text-utils-devel.cpp +++ b/dali-toolkit/devel-api/text/text-utils-devel.cpp @@ -1241,7 +1241,7 @@ void UpdateBuffer(Devel::PixelBuffer src, Devel::PixelBuffer dst, unsigned int x } const unsigned int bytesPerPixel = Dali::Pixel::GetBytesPerPixel(pixelFormat); - if( bytesPerPixel == 0u ) + if( bytesPerPixel == 0u || bytesPerPixel == 12u || bytesPerPixel == 24u ) { return; }