From: Agnelo Vaz <agnelo.vaz@samsung.com>
Date: Tue, 12 Dec 2017 10:19:46 +0000 (+0000)
Subject: SVACE Error fix TextureManager Thread bounds
X-Git-Tag: dali_1.3.4~8^2
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=b83a595d3a301c81b697826a48c69f58635f83fb

SVACE Error fix TextureManager Thread bounds

Should be able to resolve SVACE error by asserting on the maximum number allowed.

Preventing TextureManager sign-compare Error with strtoul (old arch)

Change-Id: I081635e8f1f1a69e7426041344440a53c5b80121
---

diff --git a/dali-toolkit/internal/visuals/texture-manager-impl.cpp b/dali-toolkit/internal/visuals/texture-manager-impl.cpp
index b2e0d03..c867b91 100644
--- a/dali-toolkit/internal/visuals/texture-manager-impl.cpp
+++ b/dali-toolkit/internal/visuals/texture-manager-impl.cpp
@@ -47,7 +47,9 @@ size_t GetNumberOfThreads(const char* environmentVariable, size_t defaultValue)
 {
   using Dali::EnvironmentVariable::GetEnvironmentVariable;
   auto numberString = GetEnvironmentVariable(environmentVariable);
-  auto numberOfThreads = numberString ? std::strtol(numberString, nullptr, 10) : 0;
+  auto numberOfThreads = numberString ? std::strtoul(numberString, nullptr, 10) : 0;
+  constexpr auto MAX_NUMBER_OF_THREADS = 100u;
+  DALI_ASSERT_ALWAYS( numberOfThreads < MAX_NUMBER_OF_THREADS );
   return (numberOfThreads > 0) ? numberOfThreads : defaultValue;
 }