From: Bowon Ryu Date: Thu, 22 Jul 2021 09:14:32 +0000 (+0900) Subject: Fix coverity issue in text layout-engine X-Git-Tag: dali_2.0.36~3 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=b618a881f27fb24039f51d5bbf083d74d120205e Fix coverity issue in text layout-engine middleLineIndex is always bigger than 0u by the while condition (0u < middleLineIndex). therefore execution cannot reach the expression 0u inside the statement below. : ellipsisLineIndex = middleLineIndex > 0u ? middleLineIndex - 1u : 0u; Change-Id: I1f2f85768ba638d3493f62a22b3d89a75ef462ae Signed-off-by: Bowon Ryu --- diff --git a/dali-toolkit/internal/text/layouts/layout-engine.cpp b/dali-toolkit/internal/text/layouts/layout-engine.cpp index 077b598..cee3a09 100644 --- a/dali-toolkit/internal/text/layouts/layout-engine.cpp +++ b/dali-toolkit/internal/text/layouts/layout-engine.cpp @@ -1881,7 +1881,7 @@ struct Engine::Impl linesBuffer[lineIndex].ellipsis = false; } numberOfLines--; - ellipsisLineIndex = middleLineIndex > 0u ? middleLineIndex - 1u : 0u; + ellipsisLineIndex = middleLineIndex - 1u; middleLineIndex = (numberOfLines) / 2u; }