From: Adeel Kazmi Date: Thu, 3 Sep 2020 19:35:37 +0000 (+0000) Subject: Merge "Removed REQUIRES_STYLE_CHANGE_SIGNALS" into devel/master X-Git-Tag: dali_1.9.28~1 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=a7c4e86e15b7eef5b0d50b12f6da4b1c650b8c33;hp=01777a3489f027123010b281e58efbc9f0a93db7 Merge "Removed REQUIRES_STYLE_CHANGE_SIGNALS" into devel/master --- diff --git a/automated-tests/src/dali-toolkit/utc-Dali-ControlWrapper.cpp b/automated-tests/src/dali-toolkit/utc-Dali-ControlWrapper.cpp index 5390b5c..e60505d 100644 --- a/automated-tests/src/dali-toolkit/utc-Dali-ControlWrapper.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-ControlWrapper.cpp @@ -127,7 +127,7 @@ struct TestCustomControl : public Toolkit::Internal::ControlWrapper { Control::OnChildRemove(child); } - virtual void OnPropertySet( Property::Index index, Property::Value propertyValue ) + virtual void OnPropertySet( Property::Index index, const Property::Value& propertyValue ) { Control::OnPropertySet(index, propertyValue); } diff --git a/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp index 48718b3..d40cd76 100755 --- a/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp @@ -927,7 +927,7 @@ float TextLabel::GetHeightForWidth( float width ) return mController->GetHeightForWidth( width ) + padding.top + padding.bottom; } -void TextLabel::OnPropertySet( Property::Index index, Property::Value propertyValue ) +void TextLabel::OnPropertySet( Property::Index index, const Property::Value& propertyValue ) { DALI_LOG_INFO( gLogFilter, Debug::Verbose, "TextLabel::OnPropertySet index[%d]\n", index ); diff --git a/dali-toolkit/internal/controls/text-controls/text-label-impl.h b/dali-toolkit/internal/controls/text-controls/text-label-impl.h index 85e94ab..17bf6e5 100644 --- a/dali-toolkit/internal/controls/text-controls/text-label-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-label-impl.h @@ -103,7 +103,7 @@ private: // From Control /** * @copydoc Control::OnPropertySet() */ - virtual void OnPropertySet( Property::Index index, Property::Value propertyValue ) override ; + void OnPropertySet( Property::Index index, const Property::Value& propertyValue ) override ; // From ControlInterface diff --git a/dali-toolkit/public-api/controls/control-impl.cpp b/dali-toolkit/public-api/controls/control-impl.cpp index 41c1274..5224db1 100644 --- a/dali-toolkit/public-api/controls/control-impl.cpp +++ b/dali-toolkit/public-api/controls/control-impl.cpp @@ -595,7 +595,7 @@ void Control::OnChildRemove(Actor& child) { } -void Control::OnPropertySet( Property::Index index, Property::Value propertyValue ) +void Control::OnPropertySet( Property::Index index, const Property::Value& propertyValue ) { // If the clipping mode has been set, we may need to create a renderer. // Only do this if we are already on-stage as the OnSceneConnection will handle the off-stage clipping controls. diff --git a/dali-toolkit/public-api/controls/control-impl.h b/dali-toolkit/public-api/controls/control-impl.h index 611659e..74117e9 100644 --- a/dali-toolkit/public-api/controls/control-impl.h +++ b/dali-toolkit/public-api/controls/control-impl.h @@ -324,7 +324,7 @@ protected: // From CustomActorImpl * @copydoc CustomActorImpl::OnPropertySet() * @note If overridden, then an up-call to Control::OnChildRemove MUST be made at the end. */ - virtual void OnPropertySet( Property::Index index, Property::Value propertyValue ) override; + void OnPropertySet( Property::Index index, const Property::Value& propertyValue ) override; /** * @copydoc CustomActorImpl::OnSizeSet()