From: Richard Huang Date: Fri, 29 May 2015 10:36:42 +0000 (+0100) Subject: Update keyboard focus direction enum for Control X-Git-Tag: dali_1.0.43~13^2 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=a78bb823aebc305823855ac35b3413aaff7bc684;ds=sidebyside Update keyboard focus direction enum for Control Change-Id: I0c1c9c6c6ea54effd98a46e36118c677db3d3d51 --- diff --git a/automated-tests/src/dali-toolkit/utc-Dali-ControlImpl.cpp b/automated-tests/src/dali-toolkit/utc-Dali-ControlImpl.cpp index 23b0a94..d1f6925 100644 --- a/automated-tests/src/dali-toolkit/utc-Dali-ControlImpl.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-ControlImpl.cpp @@ -934,7 +934,7 @@ int UtcDaliControlImplGetNextKeyboardFocusableActorP(void) Toolkit::Internal::Control& controlImpl = Toolkit::Internal::GetImplementation( dummy ); Actor currentFocusedActor; - Actor result = controlImpl.GetNextKeyboardFocusableActor( currentFocusedActor, Control::Left, false ); + Actor result = controlImpl.GetNextKeyboardFocusableActor( currentFocusedActor, Control::KeyboardFocus::LEFT, false ); DALI_TEST_EQUALS( result, currentFocusedActor, TEST_LOCATION ); diff --git a/automated-tests/src/dali-toolkit/utc-Dali-ItemLayout.cpp b/automated-tests/src/dali-toolkit/utc-Dali-ItemLayout.cpp index 8dd9e24..67a2287 100644 --- a/automated-tests/src/dali-toolkit/utc-Dali-ItemLayout.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-ItemLayout.cpp @@ -295,7 +295,7 @@ int UtcDaliItemLayoutSetAndGetOrientation(void) DALI_TEST_EQUALS(position, 0.0f, TEST_LOCATION); - int focusItem = layout->GetNextFocusItemID(0, TOTAL_ITEM_NUMBER, Control::Left, true); + int focusItem = layout->GetNextFocusItemID(0, TOTAL_ITEM_NUMBER, Control::KeyboardFocus::LEFT, true); DALI_TEST_CHECK(focusItem != 0); @@ -352,8 +352,8 @@ int UtcDaliItemLayoutGetNextFocusItemID(void) TestItemLayoutPtr layout = TestItemLayout::New(); DALI_TEST_CHECK( layout ); - DALI_TEST_EQUALS(layout->GetNextFocusItemID(0, 100, Control::Left, true), 99, TEST_LOCATION ); - DALI_TEST_EQUALS(layout->GetNextFocusItemID(110, 100, Control::Right, true), 0, TEST_LOCATION ); + DALI_TEST_EQUALS(layout->GetNextFocusItemID(0, 100, Control::KeyboardFocus::LEFT, true), 99, TEST_LOCATION ); + DALI_TEST_EQUALS(layout->GetNextFocusItemID(110, 100, Control::KeyboardFocus::RIGHT, true), 0, TEST_LOCATION ); END_TEST; } diff --git a/automated-tests/src/dali-toolkit/utc-Dali-KeyboardFocusManager.cpp b/automated-tests/src/dali-toolkit/utc-Dali-KeyboardFocusManager.cpp index 05f0e26..e902ec0 100644 --- a/automated-tests/src/dali-toolkit/utc-Dali-KeyboardFocusManager.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-KeyboardFocusManager.cpp @@ -51,11 +51,11 @@ public: : mSignalVerified(signalReceived), mCurrentFocusedActor(), mProposedActorToFocus(), - mDirection(Control::Left) + mDirection(Control::KeyboardFocus::LEFT) { } - Actor Callback(Actor currentFocusedActor, Actor proposedActorToFocus, Control::KeyboardFocusNavigationDirection direction) + Actor Callback(Actor currentFocusedActor, Actor proposedActorToFocus, Control::KeyboardFocus::Direction direction) { tet_infoline("Verifying PreFocusChangeCallback()"); @@ -73,13 +73,13 @@ public: mSignalVerified = false; mCurrentFocusedActor = Actor(); mProposedActorToFocus = Actor(); - mDirection = Control::Left; + mDirection = Control::KeyboardFocus::LEFT; } bool& mSignalVerified; Actor mCurrentFocusedActor; Actor mProposedActorToFocus; - Control::KeyboardFocusNavigationDirection mDirection; + Control::KeyboardFocus::Direction mDirection; }; // Functors to test whether focus changed signal is emitted when the keyboard focus is changed @@ -295,13 +295,13 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) Stage::GetCurrent().Add(second); // Move the focus to the right - DALI_TEST_CHECK(manager.MoveFocus(Control::Right) == false); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::RIGHT) == false); // Because no layout control in the stage and no actor is focused, it should emit the PreFocusChange signal DALI_TEST_CHECK(preFocusChangeCallback.mSignalVerified); DALI_TEST_CHECK(preFocusChangeCallback.mCurrentFocusedActor == Actor()); DALI_TEST_CHECK(preFocusChangeCallback.mProposedActorToFocus == Actor()); - DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::Right); + DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::KeyboardFocus::RIGHT); preFocusChangeCallback.Reset(); // Check that the focus is set on the first actor @@ -313,13 +313,13 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) focusChangedCallback.Reset(); // Move the focus towards right - DALI_TEST_CHECK(manager.MoveFocus(Control::Right) == false); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::RIGHT) == false); // Because no layout control in the stage and the first actor is focused, it should emit the PreFocusChange signal DALI_TEST_CHECK(preFocusChangeCallback.mSignalVerified); DALI_TEST_CHECK(preFocusChangeCallback.mCurrentFocusedActor == first); DALI_TEST_CHECK(preFocusChangeCallback.mProposedActorToFocus == Actor()); - DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::Right); + DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::KeyboardFocus::RIGHT); preFocusChangeCallback.Reset(); // Check that the focus is set on the second actor @@ -331,13 +331,13 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) focusChangedCallback.Reset(); // Move the focus towards up - DALI_TEST_CHECK(manager.MoveFocus(Control::Up) == false); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::UP) == false); // Because no layout control in the stage and no actor is focused, it should emit the PreFocusChange signal DALI_TEST_CHECK(preFocusChangeCallback.mSignalVerified); DALI_TEST_CHECK(preFocusChangeCallback.mCurrentFocusedActor == second); DALI_TEST_CHECK(preFocusChangeCallback.mProposedActorToFocus == Actor()); - DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::Up); + DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::KeyboardFocus::UP); preFocusChangeCallback.Reset(); DALI_TEST_CHECK(!focusChangedCallback.mSignalVerified); @@ -368,7 +368,7 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) focusChangedCallback.Reset(); // Move the focus towards right - DALI_TEST_CHECK(manager.MoveFocus(Control::Right) == true); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::RIGHT) == true); DALI_TEST_CHECK(manager.GetCurrentFocusActor() == second); DALI_TEST_CHECK(focusChangedCallback.mSignalVerified); DALI_TEST_CHECK(focusChangedCallback.mOriginalFocusedActor == first); @@ -376,7 +376,7 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) focusChangedCallback.Reset(); // Move the focus towards down - DALI_TEST_CHECK(manager.MoveFocus(Control::Down) == true); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::DOWN) == true); DALI_TEST_CHECK(manager.GetCurrentFocusActor() == fourth); DALI_TEST_CHECK(focusChangedCallback.mSignalVerified); DALI_TEST_CHECK(focusChangedCallback.mOriginalFocusedActor == second); @@ -384,7 +384,7 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) focusChangedCallback.Reset(); // Move the focus towards left - DALI_TEST_CHECK(manager.MoveFocus(Control::Left) == true); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::LEFT) == true); DALI_TEST_CHECK(manager.GetCurrentFocusActor() == third); DALI_TEST_CHECK(focusChangedCallback.mSignalVerified); DALI_TEST_CHECK(focusChangedCallback.mOriginalFocusedActor == fourth); @@ -392,7 +392,7 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) focusChangedCallback.Reset(); // Move the focus towards up - DALI_TEST_CHECK(manager.MoveFocus(Control::Up) == true); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::UP) == true); DALI_TEST_CHECK(manager.GetCurrentFocusActor() == first); DALI_TEST_CHECK(focusChangedCallback.mSignalVerified); DALI_TEST_CHECK(focusChangedCallback.mOriginalFocusedActor == third); @@ -400,12 +400,12 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) focusChangedCallback.Reset(); // Move the focus towards left. The focus move will fail as no way to move it upwards - DALI_TEST_CHECK(manager.MoveFocus(Control::Left) == false); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::LEFT) == false); DALI_TEST_CHECK(manager.GetCurrentFocusActor() == first); DALI_TEST_CHECK(preFocusChangeCallback.mSignalVerified); DALI_TEST_CHECK(preFocusChangeCallback.mCurrentFocusedActor == first); DALI_TEST_CHECK(preFocusChangeCallback.mProposedActorToFocus == Actor()); - DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::Left); + DALI_TEST_CHECK(preFocusChangeCallback.mDirection == Control::KeyboardFocus::LEFT); preFocusChangeCallback.Reset(); DALI_TEST_CHECK(!focusChangedCallback.mSignalVerified); @@ -414,7 +414,7 @@ int UtcDaliKeyboardFocusManagerMoveFocus(void) DALI_TEST_CHECK(manager.GetFocusGroupLoop() == true); // Move the focus towards left again. The focus should move to the fourth actor. - DALI_TEST_CHECK(manager.MoveFocus(Control::Left) == true); + DALI_TEST_CHECK(manager.MoveFocus(Control::KeyboardFocus::LEFT) == true); DALI_TEST_CHECK(manager.GetCurrentFocusActor() == fourth); DALI_TEST_CHECK(focusChangedCallback.mSignalVerified); DALI_TEST_CHECK(focusChangedCallback.mOriginalFocusedActor == first); diff --git a/dali-toolkit/internal/controls/popup/popup-impl.cpp b/dali-toolkit/internal/controls/popup/popup-impl.cpp index dd4c3d5..719cfe9 100755 --- a/dali-toolkit/internal/controls/popup/popup-impl.cpp +++ b/dali-toolkit/internal/controls/popup/popup-impl.cpp @@ -810,7 +810,7 @@ float Popup::GetWidthForHeight( float height ) return GetNaturalSize().width; } -Actor Popup::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled) +Actor Popup::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled) { Actor nextFocusableActor( currentFocusedActor ); @@ -853,7 +853,7 @@ Actor Popup::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::C { switch ( direction ) { - case Toolkit::Control::Left: + case Toolkit::Control::KeyboardFocus::LEFT: { if ( iter == focusableActors.begin() ) { @@ -865,7 +865,7 @@ Actor Popup::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::C } break; } - case Toolkit::Control::Right: + case Toolkit::Control::KeyboardFocus::RIGHT: { if ( iter == focusableActors.end() - 1 ) { @@ -878,7 +878,7 @@ Actor Popup::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::C break; } - case Toolkit::Control::Up: + case Toolkit::Control::KeyboardFocus::UP: { if ( *iter == mContent ) { @@ -905,7 +905,7 @@ Actor Popup::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::C break; } - case Toolkit::Control::Down: + case Toolkit::Control::KeyboardFocus::DOWN: { if ( mContent && mContent.IsKeyboardFocusable() ) { diff --git a/dali-toolkit/internal/controls/popup/popup-impl.h b/dali-toolkit/internal/controls/popup/popup-impl.h index 3d361fe..099e5e6 100755 --- a/dali-toolkit/internal/controls/popup/popup-impl.h +++ b/dali-toolkit/internal/controls/popup/popup-impl.h @@ -279,7 +279,7 @@ private: /** * @copydoc Control::GetNextKeyboardFocusableActor() */ - Actor GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled); + Actor GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled); /** * Create the root actor for the footer diff --git a/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.cpp b/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.cpp index 34838ad..2fa572d 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.cpp +++ b/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.cpp @@ -567,11 +567,11 @@ float DepthLayout::GetClosestOnScreenLayoutPosition(int itemID, float currentLay return scrollTo; } -int DepthLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled) +int DepthLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled) { switch( direction ) { - case Toolkit::Control::Left: + case Toolkit::Control::KeyboardFocus::LEFT: { itemID--; if( itemID < 0 ) @@ -580,7 +580,7 @@ int DepthLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Con } break; } - case Toolkit::Control::Up: + case Toolkit::Control::KeyboardFocus::UP: { itemID += mImpl->mNumberOfColumns; if( itemID >= maxItems ) @@ -589,7 +589,7 @@ int DepthLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Con } break; } - case Toolkit::Control::Right: + case Toolkit::Control::KeyboardFocus::RIGHT: { itemID++; if( itemID >= maxItems ) @@ -598,7 +598,7 @@ int DepthLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Con } break; } - case Toolkit::Control::Down: + case Toolkit::Control::KeyboardFocus::DOWN: { itemID -= mImpl->mNumberOfColumns; if( itemID < 0 ) diff --git a/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.h b/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.h index 1d16a03..c1f18f9 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.h +++ b/dali-toolkit/internal/controls/scrollable/item-view/depth-layout.h @@ -156,7 +156,7 @@ public: /** * @copydoc ItemLayout::GetNextFocusItemID() */ - virtual int GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled); + virtual int GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled); private: diff --git a/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.cpp b/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.cpp index 020bbcf..9339f0a 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.cpp +++ b/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.cpp @@ -676,11 +676,11 @@ Vector3 GridLayout::GetItemPosition(int itemID, float currentLayoutPosition, con return itemPosition; } -int GridLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled) +int GridLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled) { switch( direction ) { - case Toolkit::Control::Left: + case Toolkit::Control::KeyboardFocus::LEFT: { itemID--; if( itemID < 0 ) @@ -689,7 +689,7 @@ int GridLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Cont } break; } - case Toolkit::Control::Up: + case Toolkit::Control::KeyboardFocus::UP: { itemID -= mImpl->mNumberOfColumns; if( itemID < 0 ) @@ -698,7 +698,7 @@ int GridLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Cont } break; } - case Toolkit::Control::Right: + case Toolkit::Control::KeyboardFocus::RIGHT: { itemID++; if( itemID >= maxItems ) @@ -707,7 +707,7 @@ int GridLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Cont } break; } - case Toolkit::Control::Down: + case Toolkit::Control::KeyboardFocus::DOWN: { itemID += mImpl->mNumberOfColumns; if( itemID >= maxItems ) diff --git a/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.h b/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.h index 0031559..b2b3bd9 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.h +++ b/dali-toolkit/internal/controls/scrollable/item-view/grid-layout.h @@ -199,7 +199,7 @@ public: /** * @copydoc ItemLayout::GetNextFocusItemID() */ - virtual int GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled); + virtual int GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled); private: diff --git a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp index 972d04f..e56760f 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp +++ b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp @@ -1201,7 +1201,7 @@ bool ItemView::OnAccessibilityPan(PanGesture gesture) return true; } -Actor ItemView::GetNextKeyboardFocusableActor(Actor actor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled) +Actor ItemView::GetNextKeyboardFocusableActor(Actor actor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled) { Actor nextFocusActor; if(mActiveLayout) diff --git a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h index 995e4eb..16f0b0a 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h +++ b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h @@ -364,7 +364,7 @@ private: // From Control /** * @copydoc Toolkit::Control::GetNextKeyboardFocusableActor() */ - virtual Actor GetNextKeyboardFocusableActor(Actor actor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled); + virtual Actor GetNextKeyboardFocusableActor(Actor actor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled); /** * @copydoc Toolkit::Control::OnKeyboardFocusChangeCommitted() diff --git a/dali-toolkit/internal/controls/table-view/table-view-impl.cpp b/dali-toolkit/internal/controls/table-view/table-view-impl.cpp index 5a49cf4..bd96f77 100644 --- a/dali-toolkit/internal/controls/table-view/table-view-impl.cpp +++ b/dali-toolkit/internal/controls/table-view/table-view-impl.cpp @@ -1142,7 +1142,7 @@ TableView::~TableView() // nothing to do } -Actor TableView::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled) +Actor TableView::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled) { Actor nextFocusableActor; @@ -1165,7 +1165,7 @@ Actor TableView::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolki switch ( direction ) { - case Toolkit::Control::Left: + case Toolkit::Control::KeyboardFocus::LEFT: { if(--currentColumn < 0) { @@ -1178,7 +1178,7 @@ Actor TableView::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolki } break; } - case Toolkit::Control::Right: + case Toolkit::Control::KeyboardFocus::RIGHT: { if(++currentColumn > numberOfColumns - 1) { @@ -1191,7 +1191,7 @@ Actor TableView::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolki } break; } - case Toolkit::Control::Up: + case Toolkit::Control::KeyboardFocus::UP: { if(--currentRow < 0) { @@ -1200,7 +1200,7 @@ Actor TableView::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolki } break; } - case Toolkit::Control::Down: + case Toolkit::Control::KeyboardFocus::DOWN: { if(++currentRow > numberOfRows - 1) diff --git a/dali-toolkit/internal/controls/table-view/table-view-impl.h b/dali-toolkit/internal/controls/table-view/table-view-impl.h index be41e47..d1d8aef 100644 --- a/dali-toolkit/internal/controls/table-view/table-view-impl.h +++ b/dali-toolkit/internal/controls/table-view/table-view-impl.h @@ -261,7 +261,7 @@ private: // From Control /** * @copydoc Control::GetNextKeyboardFocusableActor */ - virtual Actor GetNextKeyboardFocusableActor( Actor currentFocusedActor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled ); + virtual Actor GetNextKeyboardFocusableActor( Actor currentFocusedActor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled ); /** * @copydoc Control::GetNaturalSize() diff --git a/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.cpp b/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.cpp index 4f4bf57..fb20d56 100644 --- a/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.cpp +++ b/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.cpp @@ -216,7 +216,7 @@ Toolkit::Control KeyboardFocusManager::GetParentLayoutControl(Actor actor) const return Toolkit::Control::DownCast(parent); } -bool KeyboardFocusManager::MoveFocus(Toolkit::Control::KeyboardFocusNavigationDirection direction) +bool KeyboardFocusManager::MoveFocus(Toolkit::Control::KeyboardFocus::Direction direction) { Actor currentFocusActor = GetCurrentFocusActor(); @@ -257,7 +257,7 @@ bool KeyboardFocusManager::MoveFocus(Toolkit::Control::KeyboardFocusNavigationDi return succeed; } -bool KeyboardFocusManager::DoMoveFocusWithinLayoutControl(Toolkit::Control control, Actor actor, Toolkit::Control::KeyboardFocusNavigationDirection direction) +bool KeyboardFocusManager::DoMoveFocusWithinLayoutControl(Toolkit::Control control, Actor actor, Toolkit::Control::KeyboardFocus::Direction direction) { // Ask the control for the next actor to focus Actor nextFocusableActor = GetImplementation( control ).GetNextKeyboardFocusableActor(actor, direction, mFocusGroupLoopEnabled); @@ -329,7 +329,7 @@ bool KeyboardFocusManager::DoMoveFocusToNextFocusGroup(bool forward) { // If the current focus group has a parent layout control, we can probably automatically // move the focus to the next focus group in the forward or backward direction. - Toolkit::Control::KeyboardFocusNavigationDirection direction = forward ? Toolkit::Control::Right : Toolkit::Control::Left; + Toolkit::Control::KeyboardFocus::Direction direction = forward ? Toolkit::Control::KeyboardFocus::RIGHT : Toolkit::Control::KeyboardFocus::LEFT; succeed = DoMoveFocusWithinLayoutControl(parentLayoutControl, GetCurrentFocusActor(), direction); parentLayoutControl = GetParentLayoutControl(parentLayoutControl); } @@ -542,7 +542,7 @@ void KeyboardFocusManager::OnKeyEvent(const KeyEvent& event) else { // Move the focus towards left - MoveFocus(Toolkit::Control::Left); + MoveFocus(Toolkit::Control::KeyboardFocus::LEFT); } isFocusStartableKey = true; @@ -565,7 +565,7 @@ void KeyboardFocusManager::OnKeyEvent(const KeyEvent& event) else { // Move the focus towards right - MoveFocus(Toolkit::Control::Right); + MoveFocus(Toolkit::Control::KeyboardFocus::RIGHT); } } else @@ -586,7 +586,7 @@ void KeyboardFocusManager::OnKeyEvent(const KeyEvent& event) else { // Move the focus towards up - MoveFocus(Toolkit::Control::Up); + MoveFocus(Toolkit::Control::KeyboardFocus::UP); } isFocusStartableKey = true; @@ -601,7 +601,7 @@ void KeyboardFocusManager::OnKeyEvent(const KeyEvent& event) else { // Move the focus towards down - MoveFocus(Toolkit::Control::Down); + MoveFocus(Toolkit::Control::KeyboardFocus::DOWN); } isFocusStartableKey = true; @@ -687,7 +687,7 @@ void KeyboardFocusManager::OnKeyEvent(const KeyEvent& event) { // No actor is focused but keyboard focus is activated by the key press // Let's try to move the initial focus - MoveFocus(Toolkit::Control::Right); + MoveFocus(Toolkit::Control::KeyboardFocus::RIGHT); } else if(mFocusIndicatorActor) { diff --git a/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.h b/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.h index 1cd958a..bc456c2 100644 --- a/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.h +++ b/dali-toolkit/internal/focus-manager/keyboard-focus-manager-impl.h @@ -65,7 +65,7 @@ public: /** * @copydoc Toolkit::KeyboardFocusManager::MoveFocus */ - bool MoveFocus(Toolkit::Control::KeyboardFocusNavigationDirection direction); + bool MoveFocus(Toolkit::Control::KeyboardFocus::Direction direction); /** * @copydoc Toolkit::KeyboardFocusManager::ClearFocus @@ -171,7 +171,7 @@ private: * @param direction The direction of focus movement * @return Whether the focus is successful or not */ - bool DoMoveFocusWithinLayoutControl(Toolkit::Control control, Actor actor, Toolkit::Control::KeyboardFocusNavigationDirection direction); + bool DoMoveFocusWithinLayoutControl(Toolkit::Control control, Actor actor, Toolkit::Control::KeyboardFocus::Direction direction); /** * Move the focus to the first focusable actor in the next focus group in the forward diff --git a/dali-toolkit/public-api/controls/control-impl.cpp b/dali-toolkit/public-api/controls/control-impl.cpp index eb7c14b..bb2732c 100644 --- a/dali-toolkit/public-api/controls/control-impl.cpp +++ b/dali-toolkit/public-api/controls/control-impl.cpp @@ -734,7 +734,7 @@ bool Control::OnAccessibilityValueChange(bool isIncrease) return false; // Accessibility value change action is not handled by default } -Actor Control::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled) +Actor Control::GetNextKeyboardFocusableActor(Actor currentFocusedActor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled) { return Actor(); } diff --git a/dali-toolkit/public-api/controls/control-impl.h b/dali-toolkit/public-api/controls/control-impl.h index ce46319..9deae8f 100644 --- a/dali-toolkit/public-api/controls/control-impl.h +++ b/dali-toolkit/public-api/controls/control-impl.h @@ -493,7 +493,7 @@ public: // API for derived classes to override * @param[in] loopEnabled Whether the focus movement should be looped within the control. * @return the next keyboard focusable actor in this control or an empty handle if no actor can be focused. */ - virtual Actor GetNextKeyboardFocusableActor( Actor currentFocusedActor, Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled ); + virtual Actor GetNextKeyboardFocusableActor( Actor currentFocusedActor, Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled ); /** * @brief Informs this control that its chosen focusable actor will be focused. diff --git a/dali-toolkit/public-api/controls/control.h b/dali-toolkit/public-api/controls/control.h index 7742bb7..e7511a1 100644 --- a/dali-toolkit/public-api/controls/control.h +++ b/dali-toolkit/public-api/controls/control.h @@ -94,12 +94,15 @@ public: /** * @brief Describes the direction to move the keyboard focus towards. */ - enum KeyboardFocusNavigationDirection + struct KeyboardFocus { - Left, ///< Move keyboard focus towards the left direction - Right, ///< Move keyboard focus towards the right direction - Up, ///< Move keyboard focus towards the up direction - Down ///< Move keyboard focus towards the down direction + enum Direction + { + LEFT, ///< Move keyboard focus towards the left direction + RIGHT, ///< Move keyboard focus towards the right direction + UP, ///< Move keyboard focus towards the up direction + DOWN ///< Move keyboard focus towards the down direction + }; }; // Typedefs diff --git a/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.cpp b/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.cpp index 39e09a3..0dc2bb4 100644 --- a/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.cpp +++ b/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.cpp @@ -95,12 +95,12 @@ float ItemLayout::GetClosestOnScreenLayoutPosition(int itemID, float currentLayo return currentLayoutPosition; } -int ItemLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled) +int ItemLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled) { switch( direction ) { - case Control::Left: - case Control::Up: + case Control::KeyboardFocus::LEFT: + case Control::KeyboardFocus::UP: { itemID--; if( itemID < 0 ) @@ -109,8 +109,8 @@ int ItemLayout::GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Cont } break; } - case Control::Right: - case Control::Down: + case Control::KeyboardFocus::RIGHT: + case Control::KeyboardFocus::DOWN: { itemID++; if( itemID >= maxItems ) diff --git a/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.h b/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.h index 5eda5d4..2ed5f1e 100644 --- a/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.h +++ b/dali-toolkit/public-api/controls/scrollable/item-view/item-layout.h @@ -304,7 +304,7 @@ public: * @param[in] loopEnabled Whether the KeyboardFocusManager is set to wrap around between first and last item * @return The next item ID. */ - DALI_IMPORT_API virtual int GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocusNavigationDirection direction, bool loopEnabled); + DALI_IMPORT_API virtual int GetNextFocusItemID(int itemID, int maxItems, Dali::Toolkit::Control::KeyboardFocus::Direction direction, bool loopEnabled); /** * @brief Query the flick speed factor of the layout while swipping. diff --git a/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.cpp b/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.cpp index 316af96..2e0ffbe 100644 --- a/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.cpp +++ b/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.cpp @@ -60,7 +60,7 @@ Actor KeyboardFocusManager::GetCurrentFocusActor() return GetImpl(*this).GetCurrentFocusActor(); } -bool KeyboardFocusManager::MoveFocus(Control::KeyboardFocusNavigationDirection direction) +bool KeyboardFocusManager::MoveFocus(Control::KeyboardFocus::Direction direction) { return GetImpl(*this).MoveFocus(direction); } diff --git a/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.h b/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.h index 68638a3..6afcd6b 100644 --- a/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.h +++ b/dali-toolkit/public-api/focus-manager/keyboard-focus-manager.h @@ -55,7 +55,7 @@ class DALI_IMPORT_API KeyboardFocusManager : public BaseHandle public: /// @brief Pre focus change signal - typedef Signal< Actor ( Actor, Actor, Control::KeyboardFocusNavigationDirection ) > PreFocusChangeSignalType; + typedef Signal< Actor ( Actor, Actor, Control::KeyboardFocus::Direction ) > PreFocusChangeSignalType; /// @brief Focus changed signal typedef Signal< void ( Actor, Actor ) > FocusChangedSignalType; @@ -117,7 +117,7 @@ public: * @param direction The direction of focus movement * @return true if the movement was successful */ - bool MoveFocus(Control::KeyboardFocusNavigationDirection direction); + bool MoveFocus(Control::KeyboardFocus::Direction direction); /** * @brief Clear the focus from the current focused actor if any, so @@ -214,7 +214,7 @@ public: // Signals * * A callback of the following type may be connected: * @code - * Actor YourCallbackName(Actor currentFocusedActor, Actor proposedActorToFocus, Control::KeyboardFocusNavigationDirection direction); + * Actor YourCallbackName(Actor currentFocusedActor, Actor proposedActorToFocus, Control::KeyboardFocus::Direction direction); * @endcode * @pre The Object has been initialized. * @return The signal to connect to. diff --git a/plugins/dali-script-v8/src/signals/signal-manager.cpp b/plugins/dali-script-v8/src/signals/signal-manager.cpp index 8adcabd..e5cfb67 100644 --- a/plugins/dali-script-v8/src/signals/signal-manager.cpp +++ b/plugins/dali-script-v8/src/signals/signal-manager.cpp @@ -312,7 +312,7 @@ public: Actor PreFocusChangeSignal(Actor currentFocusedActor, Actor proposedActorToFocus, - Toolkit::Control::KeyboardFocusNavigationDirection direction ) + Toolkit::Control::KeyboardFocus::Direction direction ) { std::vector< Dali::Any > arguments; Dali::Any returnValue = Actor(); // we want an actor as a return value diff --git a/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-api.cpp b/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-api.cpp index d39276c..b43e703 100644 --- a/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-api.cpp +++ b/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-api.cpp @@ -34,29 +34,29 @@ namespace // un named namespace { -Toolkit::Control::KeyboardFocusNavigationDirection GetDirection( std::string name, v8::Isolate* isolate ) +Toolkit::Control::KeyboardFocus::Direction GetDirection( std::string name, v8::Isolate* isolate ) { if( name == "left") { - return Dali::Toolkit::Control::Left; + return Dali::Toolkit::Control::KeyboardFocus::LEFT; } if( name == "right") { - return Dali::Toolkit::Control::Right; + return Dali::Toolkit::Control::KeyboardFocus::RIGHT; } if( name == "up") { - return Dali::Toolkit::Control::Up; + return Dali::Toolkit::Control::KeyboardFocus::UP; } if( name == "down") { - return Dali::Toolkit::Control::Down; + return Dali::Toolkit::Control::KeyboardFocus::DOWN; } DALI_SCRIPT_EXCEPTION( isolate, "direction not found ( wanted left,right,up,down)" ); - return Dali::Toolkit::Control::Up; + return Dali::Toolkit::Control::KeyboardFocus::UP; } }; //un-named namespace @@ -124,7 +124,7 @@ void KeyboardFocusManagerApi::MoveFocus( const v8::FunctionCallbackInfo< v8::Val return; } - Toolkit::Control::KeyboardFocusNavigationDirection dir = GetDirection( direction, isolate ); + Toolkit::Control::KeyboardFocus::Direction dir = GetDirection( direction, isolate ); Toolkit::KeyboardFocusManager::Get().MoveFocus( dir ); } diff --git a/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.cpp b/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.cpp index 0ab6ea9..5bab6a1 100644 --- a/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.cpp +++ b/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.cpp @@ -109,26 +109,26 @@ v8::Local KeyboardFocusManagerWrapper::GetKeyboardFocusManag } -std::string KeyboardFocusManagerWrapper::GetDirectionName( Toolkit::Control::KeyboardFocusNavigationDirection dir ) +std::string KeyboardFocusManagerWrapper::GetDirectionName( Toolkit::Control::KeyboardFocus::Direction dir ) { switch( dir ) { - case Dali::Toolkit::Control::Left: + case Dali::Toolkit::Control::KeyboardFocus::LEFT: { return "left"; break; } - case Dali::Toolkit::Control::Right: + case Dali::Toolkit::Control::KeyboardFocus::RIGHT: { return "right"; break; } - case Dali::Toolkit::Control::Up: + case Dali::Toolkit::Control::KeyboardFocus::UP: { return "up"; break; } - case Dali::Toolkit::Control::Down: + case Dali::Toolkit::Control::KeyboardFocus::DOWN: { return "down"; break; diff --git a/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.h b/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.h index 3889021..ae1dff3 100644 --- a/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.h +++ b/plugins/dali-script-v8/src/toolkit/focus-manager/keyboard-focus-manager-wrapper.h @@ -66,7 +66,7 @@ public: virtual SignalManager* GetSignalManager() { return &mSignalManager;} - static std::string GetDirectionName( Toolkit::Control::KeyboardFocusNavigationDirection dir ); + static std::string GetDirectionName( Toolkit::Control::KeyboardFocus::Direction dir ); private: