From: Seoyeon Kim Date: Tue, 12 Dec 2017 10:21:28 +0000 (+0000) Subject: Merge "Send the empty string to IME when PlaceholderText shows" into devel/master X-Git-Tag: dali_1.3.4~11 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=a40939e617ca1a0b79aeb6af999cda7c70418be1;hp=fc4c605d282d2f667af3504d93958db64ca692aa Merge "Send the empty string to IME when PlaceholderText shows" into devel/master --- diff --git a/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Controller.cpp b/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Controller.cpp index 8d73622..02f2e66 100644 --- a/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Controller.cpp +++ b/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Controller.cpp @@ -184,9 +184,16 @@ int UtcDaliTextControllerImfEvent(void) // Enables the text input. controller->EnableTextInput( decorator ); + // Set the placeholder text. + controller->SetPlaceholderText( Controller::PLACEHOLDER_TYPE_INACTIVE, "Hello Dali" ); + // Creates an ImfManager. ImfManager imfManager = ImfManager::Get(); + // For coverage. + imfEvent = ImfManager::ImfEventData( ImfManager::GETSURROUNDING, "", 0, 0 ); + controller->OnImfEvent( imfManager, imfEvent ); + // Send VOID event. imfEvent = ImfManager::ImfEventData( ImfManager::VOID, "", 0, 0 ); controller->OnImfEvent( imfManager, imfEvent ); diff --git a/dali-toolkit/internal/text/text-controller.cpp b/dali-toolkit/internal/text/text-controller.cpp index 850352b..9fa42f1 100755 --- a/dali-toolkit/internal/text/text-controller.cpp +++ b/dali-toolkit/internal/text/text-controller.cpp @@ -2744,7 +2744,17 @@ ImfManager::ImfCallbackData Controller::OnImfEvent( ImfManager& imfManager, cons if( retrieveText ) { - mImpl->GetText( numberOfWhiteSpaces, text ); + if( !mImpl->IsShowingPlaceholderText() ) + { + // Retrieves the normal text string. + mImpl->GetText( numberOfWhiteSpaces, text ); + } + else + { + // When the current text is Placeholder Text, the surrounding text should be empty string. + // It means DALi should send empty string ("") to IME. + text = ""; + } } ImfManager::ImfCallbackData callbackData( ( retrieveText || retrieveCursor ), cursorPosition, text, false );