From: Artur Świgoń Date: Mon, 14 Mar 2022 09:34:11 +0000 (+0100) Subject: [AT-SPI] Rename AccessibleImpl to Accessible X-Git-Tag: dali_2.1.14~2^2~3 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=9c1f4310db72879676b5aca2875fbf67b97a4b0a [AT-SPI] Rename AccessibleImpl to Accessible This change finishes establishing the new naming convention for Accessible objects, which now mirror the names of DALi/NUI classes, e.g. ActorAccessible, ControlAccessible (previously AccessibleImpl), NUIViewAccessible (previously AccessibleImpl_NUI), and now ::AccessibleImpl becomes ::Accessible. Change-Id: I8ba65736da4527d19107cee877541f776ba017ca --- diff --git a/dali-toolkit/internal/controls/buttons/button-impl.cpp b/dali-toolkit/internal/controls/buttons/button-impl.cpp index 7fb1ab8..e4a41a1 100644 --- a/dali-toolkit/internal/controls/buttons/button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/button-impl.cpp @@ -1303,7 +1303,7 @@ Padding Button::GetForegroundPadding() return mForegroundPadding; } -std::string Button::AccessibleImpl::GetNameRaw() const +std::string Button::ButtonAccessible::GetNameRaw() const { std::string labelText; auto slf = Toolkit::Button::DownCast(Self()); @@ -1318,7 +1318,7 @@ std::string Button::AccessibleImpl::GetNameRaw() const return labelText; } -Property::Index Button::AccessibleImpl::GetNamePropertyIndex() +Property::Index Button::ButtonAccessible::GetNamePropertyIndex() { Property::Index label = Toolkit::Button::Property::LABEL; Property::Map labelMap = Self().GetProperty(label); @@ -1333,7 +1333,7 @@ Property::Index Button::AccessibleImpl::GetNamePropertyIndex() } } -Dali::Accessibility::States Button::AccessibleImpl::CalculateStates() +Dali::Accessibility::States Button::ButtonAccessible::CalculateStates() { auto tmp = DevelControl::ControlAccessible::CalculateStates(); tmp[Dali::Accessibility::State::SELECTABLE] = true; diff --git a/dali-toolkit/internal/controls/buttons/button-impl.h b/dali-toolkit/internal/controls/buttons/button-impl.h index 3e36873..c13fc3f 100644 --- a/dali-toolkit/internal/controls/buttons/button-impl.h +++ b/dali-toolkit/internal/controls/buttons/button-impl.h @@ -535,13 +535,25 @@ private: bool mClickActionPerforming; ///< Used to manage signal emissions during action protected: - struct AccessibleImpl : public DevelControl::ControlAccessible + class ButtonAccessible : public DevelControl::ControlAccessible { + public: using DevelControl::ControlAccessible::ControlAccessible; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::CalculateStates() + */ Dali::Accessibility::States CalculateStates() override; - std::string GetNameRaw() const override; - Property::Index GetNamePropertyIndex() override; + + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::GetNameRaw() + */ + std::string GetNameRaw() const override; + + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::GetNamePropertyIndex() + */ + Property::Index GetNamePropertyIndex() override; }; }; diff --git a/dali-toolkit/internal/controls/buttons/check-box-button-impl.cpp b/dali-toolkit/internal/controls/buttons/check-box-button-impl.cpp index 98733ea..3fcaae2 100644 --- a/dali-toolkit/internal/controls/buttons/check-box-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/check-box-button-impl.cpp @@ -78,14 +78,13 @@ void CheckBoxButton::OnInitialize() Button::OnInitialize(); DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::CHECK_BOX)); + return std::make_unique(actor, Dali::Accessibility::Role::CHECK_BOX); }); } -Dali::Accessibility::States CheckBoxButton::AccessibleImpl::CalculateStates() +Dali::Accessibility::States CheckBoxButton::CheckBoxButtonAccessible::CalculateStates() { - auto state = Button::AccessibleImpl::CalculateStates(); + auto state = Button::ButtonAccessible::CalculateStates(); auto self = Toolkit::Button::DownCast(Self()); if(self.GetProperty(Toolkit::Button::Property::SELECTED)) { diff --git a/dali-toolkit/internal/controls/buttons/check-box-button-impl.h b/dali-toolkit/internal/controls/buttons/check-box-button-impl.h index ffae507..a6154d5 100644 --- a/dali-toolkit/internal/controls/buttons/check-box-button-impl.h +++ b/dali-toolkit/internal/controls/buttons/check-box-button-impl.h @@ -71,12 +71,17 @@ private: CheckBoxButton& operator=(const CheckBoxButton&); protected: - struct AccessibleImpl : public Button::AccessibleImpl + class CheckBoxButtonAccessible : public Button::ButtonAccessible { - using Button::AccessibleImpl::AccessibleImpl; + public: + using Button::ButtonAccessible::ButtonAccessible; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::CalculateStates() + */ Dali::Accessibility::States CalculateStates() override; }; + void OnStateChange(State newState) override; }; diff --git a/dali-toolkit/internal/controls/buttons/push-button-impl.cpp b/dali-toolkit/internal/controls/buttons/push-button-impl.cpp index 2958766..2906245 100644 --- a/dali-toolkit/internal/controls/buttons/push-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/push-button-impl.cpp @@ -96,8 +96,7 @@ void PushButton::OnInitialize() self.SetProperty(Actor::Property::LEAVE_REQUIRED, true); DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::PUSH_BUTTON)); + return std::make_unique(actor, Dali::Accessibility::Role::PUSH_BUTTON); }); } @@ -194,9 +193,9 @@ Property::Value PushButton::GetProperty(BaseObject* object, Property::Index prop return value; } -Dali::Accessibility::States PushButton::AccessibleImpl::CalculateStates() +Dali::Accessibility::States PushButton::PushButtonAccessible::CalculateStates() { - auto state = Button::AccessibleImpl::CalculateStates(); + auto state = Button::ButtonAccessible::CalculateStates(); auto self = Toolkit::Button::DownCast(Self()); state[Dali::Accessibility::State::PRESSED] = self.GetProperty(Toolkit::Button::Property::SELECTED); return state; diff --git a/dali-toolkit/internal/controls/buttons/push-button-impl.h b/dali-toolkit/internal/controls/buttons/push-button-impl.h index 6300fe2..b04f6b7 100644 --- a/dali-toolkit/internal/controls/buttons/push-button-impl.h +++ b/dali-toolkit/internal/controls/buttons/push-button-impl.h @@ -119,12 +119,17 @@ private: IconAlignment mIconAlignment; ///< The alignment of the icon against the label. protected: - struct AccessibleImpl : public Button::AccessibleImpl + class PushButtonAccessible : public Button::ButtonAccessible { - using Button::AccessibleImpl::AccessibleImpl; + public: + using Button::ButtonAccessible::ButtonAccessible; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::CalculateStates() + */ Dali::Accessibility::States CalculateStates() override; }; + void OnStateChange(State newState) override; }; diff --git a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp index 4b4e070..ae0d4d7 100644 --- a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp @@ -72,8 +72,7 @@ void RadioButton::OnInitialize() Button::OnInitialize(); DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::RADIO_BUTTON)); + return std::make_unique(actor, Dali::Accessibility::Role::RADIO_BUTTON); }); } @@ -112,9 +111,9 @@ void RadioButton::OnStateChange(State newState) } } -Dali::Accessibility::States RadioButton::AccessibleImpl::CalculateStates() +Dali::Accessibility::States RadioButton::RadioButtonAccessible::CalculateStates() { - auto state = Button::AccessibleImpl::CalculateStates(); + auto state = Button::ButtonAccessible::CalculateStates(); auto self = Toolkit::Button::DownCast(Self()); if(self.GetProperty(Toolkit::Button::Property::SELECTED)) diff --git a/dali-toolkit/internal/controls/buttons/radio-button-impl.h b/dali-toolkit/internal/controls/buttons/radio-button-impl.h index b172750..8c3289d 100644 --- a/dali-toolkit/internal/controls/buttons/radio-button-impl.h +++ b/dali-toolkit/internal/controls/buttons/radio-button-impl.h @@ -82,10 +82,14 @@ private: RadioButton& operator=(const RadioButton& origin); protected: - struct AccessibleImpl : public Button::AccessibleImpl + class RadioButtonAccessible : public Button::ButtonAccessible { - using Button::AccessibleImpl::AccessibleImpl; + public: + using Button::ButtonAccessible::ButtonAccessible; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::CalculateStates() + */ Dali::Accessibility::States CalculateStates() override; }; }; diff --git a/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp b/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp index 3010e69..490085a 100644 --- a/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp @@ -107,8 +107,7 @@ void ToggleButton::OnInitialize() self.SetProperty(Actor::Property::LEAVE_REQUIRED, true); DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::TOGGLE_BUTTON)); + return std::make_unique(actor, Dali::Accessibility::Role::TOGGLE_BUTTON); }); } @@ -372,9 +371,9 @@ void ToggleButton::OnPressed() RelayoutRequest(); } -Dali::Accessibility::States ToggleButton::AccessibleImpl::CalculateStates() +Dali::Accessibility::States ToggleButton::ToggleButtonAccessible::CalculateStates() { - auto states = Button::AccessibleImpl::CalculateStates(); + auto states = Button::ButtonAccessible::CalculateStates(); auto button = Toolkit::ToggleButton::DownCast(Self()); if(button.GetProperty(Toolkit::ToggleButton::Property::CURRENT_STATE_INDEX)) { @@ -383,7 +382,7 @@ Dali::Accessibility::States ToggleButton::AccessibleImpl::CalculateStates() return states; } -std::string ToggleButton::AccessibleImpl::GetDescriptionRaw() const +std::string ToggleButton::ToggleButtonAccessible::GetDescriptionRaw() const { auto button = Toolkit::ToggleButton::DownCast(Self()); auto index = button.GetProperty(Toolkit::ToggleButton::Property::CURRENT_STATE_INDEX); @@ -392,7 +391,7 @@ std::string ToggleButton::AccessibleImpl::GetDescriptionRaw() const return tooltips[index].Get(); } -Property::Index ToggleButton::AccessibleImpl::GetDescriptionPropertyIndex() +Property::Index ToggleButton::ToggleButtonAccessible::GetDescriptionPropertyIndex() { return Toolkit::ToggleButton::Property::TOOLTIPS; } diff --git a/dali-toolkit/internal/controls/buttons/toggle-button-impl.h b/dali-toolkit/internal/controls/buttons/toggle-button-impl.h index 6629d40..587c54e 100644 --- a/dali-toolkit/internal/controls/buttons/toggle-button-impl.h +++ b/dali-toolkit/internal/controls/buttons/toggle-button-impl.h @@ -152,15 +152,29 @@ private: std::vector mToggleDisabledSelectedVisuals; ///< Save all disabled selected visuals. std::vector mToggleTooltips; ///< Toggle tooltips. unsigned int mCurrentToggleIndex; ///< The index of state. + protected: - struct AccessibleImpl : public Button::AccessibleImpl + class ToggleButtonAccessible : public Button::ButtonAccessible { - using Button::AccessibleImpl::AccessibleImpl; + public: + using Button::ButtonAccessible::ButtonAccessible; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::CalculateStates() + */ Dali::Accessibility::States CalculateStates() override; - std::string GetDescriptionRaw() const override; - Property::Index GetDescriptionPropertyIndex() override; + + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::GetDescriptionRaw() + */ + std::string GetDescriptionRaw() const override; + + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::GetDescriptionPropertyIndex() + */ + Property::Index GetDescriptionPropertyIndex() override; }; + void OnStateChange(State newState) override; }; diff --git a/dali-toolkit/internal/controls/popup/popup-impl.cpp b/dali-toolkit/internal/controls/popup/popup-impl.cpp index f811812..cf4e02c 100644 --- a/dali-toolkit/internal/controls/popup/popup-impl.cpp +++ b/dali-toolkit/internal/controls/popup/popup-impl.cpp @@ -346,7 +346,7 @@ void Popup::OnInitialize() DevelControl::AppendAccessibilityAttribute(Toolkit::Control::DownCast(self), "sub-role", "Alert"); DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr(new AccessibleImpl(actor, Dali::Accessibility::Role::DIALOG, true)); + return std::make_unique(actor, Dali::Accessibility::Role::DIALOG, true); }); } @@ -1994,7 +1994,7 @@ void Popup::SetupTouch() } } -std::string Popup::AccessibleImpl::GetNameRaw() const +std::string Popup::PopupAccessible::GetNameRaw() const { auto popup = Toolkit::Popup::DownCast(Self()); std::string title; @@ -2016,7 +2016,7 @@ std::string Popup::AccessibleImpl::GetNameRaw() const return title; } -Dali::Accessibility::States Popup::AccessibleImpl::CalculateStates() +Dali::Accessibility::States Popup::PopupAccessible::CalculateStates() { auto states = DevelControl::ControlAccessible::CalculateStates(); auto popup = Toolkit::Popup::DownCast(Self()); diff --git a/dali-toolkit/internal/controls/popup/popup-impl.h b/dali-toolkit/internal/controls/popup/popup-impl.h index 50a2fd6..2445ac6 100644 --- a/dali-toolkit/internal/controls/popup/popup-impl.h +++ b/dali-toolkit/internal/controls/popup/popup-impl.h @@ -241,11 +241,19 @@ public: static Property::Value GetProperty(BaseObject* object, Property::Index propertyIndex); protected: - struct AccessibleImpl : public DevelControl::ControlAccessible + class PopupAccessible : public DevelControl::ControlAccessible { + public: using DevelControl::ControlAccessible::ControlAccessible; - std::string GetNameRaw() const override; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::GetNameRaw() + */ + std::string GetNameRaw() const override; + + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::CalculateStates() + */ Dali::Accessibility::States CalculateStates() override; }; diff --git a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp index 1a243a2..42d2189 100644 --- a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp +++ b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp @@ -166,8 +166,7 @@ ProgressBar::~ProgressBar() void ProgressBar::OnInitialize() { DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::PROGRESS_BAR)); + return std::make_unique(actor, Dali::Accessibility::Role::PROGRESS_BAR); }); //Enable highightability Self().SetProperty(Toolkit::DevelControl::Property::ACCESSIBILITY_HIGHLIGHTABLE, true); @@ -676,23 +675,23 @@ void ProgressBar::OnSceneConnection(int depth) } } -double ProgressBar::AccessibleImpl::GetMinimum() const +double ProgressBar::ProgressBarAccessible::GetMinimum() const { return DEFAULT_LOWER_BOUND; } -double ProgressBar::AccessibleImpl::GetCurrent() const +double ProgressBar::ProgressBarAccessible::GetCurrent() const { auto self = Toolkit::ProgressBar::DownCast(Self()); return self.GetProperty(Toolkit::ProgressBar::Property::PROGRESS_VALUE).Get(); } -double ProgressBar::AccessibleImpl::GetMaximum() const +double ProgressBar::ProgressBarAccessible::GetMaximum() const { return DEFAULT_UPPER_BOUND; } -bool ProgressBar::AccessibleImpl::SetCurrent(double current) +bool ProgressBar::ProgressBarAccessible::SetCurrent(double current) { if(current < GetMinimum() || current > GetMaximum()) { @@ -704,7 +703,7 @@ bool ProgressBar::AccessibleImpl::SetCurrent(double current) return true; } -double ProgressBar::AccessibleImpl::GetMinimumIncrement() const +double ProgressBar::ProgressBarAccessible::GetMinimumIncrement() const { return 0.0; } diff --git a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h index 96540d2..0879d97 100644 --- a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h +++ b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h @@ -265,15 +265,35 @@ private: Property::Map mSecondaryProgressVisualMap; ///< To backup visual properties when switching determinate/indeterminate. protected: - struct AccessibleImpl : public DevelControl::ControlAccessible, - public virtual Dali::Accessibility::Value + class ProgressBarAccessible : public DevelControl::ControlAccessible, + public virtual Dali::Accessibility::Value { + public: using DevelControl::ControlAccessible::ControlAccessible; + /** + * @copydoc Dali::Accessibility::Value::GetMinimum() + */ double GetMinimum() const override; + + /** + * @copydoc Dali::Accessibility::Value::GetCurrent() + */ double GetCurrent() const override; + + /** + * @copydoc Dali::Accessibility::Value::GetMaximum() + */ double GetMaximum() const override; - bool SetCurrent(double) override; + + /** + * @copydoc Dali::Accessibility::Value::SetCurrent() + */ + bool SetCurrent(double) override; + + /** + * @copydoc Dali::Accessibility::Value::GetMinimumIncrement() + */ double GetMinimumIncrement() const override; }; }; diff --git a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp index 1fef71b..93773e9 100644 --- a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp +++ b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp @@ -213,8 +213,7 @@ void ScrollBar::OnInitialize() Self().SetProperty(Actor::Property::DRAW_MODE, DrawMode::OVERLAY_2D); DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::SCROLL_BAR)); + return std::make_unique(actor, Dali::Accessibility::Role::SCROLL_BAR); }); } @@ -861,28 +860,28 @@ Toolkit::ScrollBar ScrollBar::New(Toolkit::ScrollBar::Direction direction) return handle; } -double ScrollBar::AccessibleImpl::GetMinimum() const +double ScrollBar::ScrollBarAccessible::GetMinimum() const { auto self = Toolkit::ScrollBar::DownCast(Self()); Handle scrollableHandle = GetImpl(self).mScrollableObject.GetHandle(); return scrollableHandle ? scrollableHandle.GetCurrentProperty(GetImpl(self).mPropertyMinScrollPosition) : 0.0f; } -double ScrollBar::AccessibleImpl::GetCurrent() const +double ScrollBar::ScrollBarAccessible::GetCurrent() const { auto self = Toolkit::ScrollBar::DownCast(Self()); Handle scrollableHandle = GetImpl(self).mScrollableObject.GetHandle(); return scrollableHandle ? scrollableHandle.GetCurrentProperty(GetImpl(self).mPropertyScrollPosition) : 0.0f; } -double ScrollBar::AccessibleImpl::GetMaximum() const +double ScrollBar::ScrollBarAccessible::GetMaximum() const { auto self = Toolkit::ScrollBar::DownCast(Self()); Handle scrollableHandle = GetImpl(self).mScrollableObject.GetHandle(); return scrollableHandle ? scrollableHandle.GetCurrentProperty(GetImpl(self).mPropertyMaxScrollPosition) : 1.0f; } -bool ScrollBar::AccessibleImpl::SetCurrent(double current) +bool ScrollBar::ScrollBarAccessible::SetCurrent(double current) { if(current < GetMinimum() || current > GetMaximum()) { @@ -910,7 +909,7 @@ bool ScrollBar::AccessibleImpl::SetCurrent(double current) return true; } -double ScrollBar::AccessibleImpl::GetMinimumIncrement() const +double ScrollBar::ScrollBarAccessible::GetMinimumIncrement() const { return 1.0; } diff --git a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h index 97a7daa..f50009f 100644 --- a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h +++ b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h @@ -314,15 +314,35 @@ private: bool mIndicatorFirstShow : 1; ///< True if the indicator has never been shown protected: - struct AccessibleImpl : public DevelControl::ControlAccessible, - public virtual Dali::Accessibility::Value + class ScrollBarAccessible : public DevelControl::ControlAccessible, + public virtual Dali::Accessibility::Value { + public: using DevelControl::ControlAccessible::ControlAccessible; + /** + * @copydoc Dali::Accessibility::Value::GetMinimum() + */ double GetMinimum() const override; + + /** + * @copydoc Dali::Accessibility::Value::GetCurrent() + */ double GetCurrent() const override; + + /** + * @copydoc Dali::Accessibility::Value::GetMaximum() + */ double GetMaximum() const override; - bool SetCurrent(double) override; + + /** + * @copydoc Dali::Accessibility::Value::SetCurrent() + */ + bool SetCurrent(double) override; + + /** + * @copydoc Dali::Accessibility::Value::GetMinimumIncrement() + */ double GetMinimumIncrement() const override; }; }; diff --git a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp index e9b58c8..5984721 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp +++ b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.cpp @@ -368,7 +368,7 @@ void ItemView::OnInitialize() self.WheelEventSignal().Connect(this, &ItemView::OnWheelEvent); DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr(new AccessibleImpl(actor, Dali::Accessibility::Role::SCROLL_PANE)); + return std::make_unique(actor, Dali::Accessibility::Role::SCROLL_PANE); }); } @@ -1345,7 +1345,7 @@ void ItemView::OnKeyboardFocusChangeCommitted(Actor commitedFocusableActor) } } -bool ItemView::AccessibleImpl::ScrollToChild(Actor child) +bool ItemView::ItemViewAccessible::ScrollToChild(Actor child) { auto itemView = Dali::Toolkit::ItemView::DownCast(Self()); Toolkit::GetImpl(itemView).OnKeyboardFocusChangeCommitted(child); diff --git a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h index 7e3d8c1..2201c84 100644 --- a/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h +++ b/dali-toolkit/internal/controls/scrollable/item-view/item-view-impl.h @@ -434,10 +434,14 @@ private: // From Control void OnKeyboardFocusChangeCommitted(Actor commitedFocusableActor) override; protected: - struct AccessibleImpl : public Scrollable::AccessibleImpl + class ItemViewAccessible : public Scrollable::ScrollableAccessible { - using Scrollable::AccessibleImpl::AccessibleImpl; + public: + using Scrollable::ScrollableAccessible::ScrollableAccessible; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::ScrollToChild() + */ bool ScrollToChild(Actor child) override; }; diff --git a/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.cpp b/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.cpp index 712cb17..331ec0c 100644 --- a/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.cpp +++ b/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.cpp @@ -681,8 +681,7 @@ void ScrollView::OnInitialize() self.WheelEventSignal().Connect(this, &ScrollView::OnWheelEvent); DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::SCROLL_PANE)); + return std::make_unique(actor, Dali::Accessibility::Role::SCROLL_PANE); }); } @@ -1262,7 +1261,7 @@ Toolkit::ScrollView::SnapStartedSignalType& ScrollView::SnapStartedSignal() return mSnapStartedSignal; } -bool ScrollView::AccessibleImpl::ScrollToChild(Actor child) +bool ScrollView::ScrollViewAccessible::ScrollToChild(Actor child) { auto scrollView = Dali::Toolkit::ScrollView::DownCast(Self()); if(Toolkit::GetImpl(scrollView).FindClosestActor() == child) diff --git a/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.h b/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.h index 4061727..5bfcb04 100644 --- a/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.h +++ b/dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.h @@ -841,10 +841,14 @@ private: void WrapPosition(Vector2& position) const; protected: - struct AccessibleImpl : public Scrollable::AccessibleImpl + class ScrollViewAccessible : public Scrollable::ScrollableAccessible { - using Scrollable::AccessibleImpl::AccessibleImpl; + public: + using Scrollable::ScrollableAccessible::ScrollableAccessible; + /** + * @copydoc Dali::Toolkit::DevelControl::ControlAccessible::ScrollToChild() + */ bool ScrollToChild(Actor child) override; }; diff --git a/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp b/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp index ea3240f..8cf0856 100644 --- a/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp +++ b/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp @@ -92,7 +92,7 @@ Scrollable::~Scrollable() { } -bool Scrollable::AccessibleImpl::IsScrollable() const +bool Scrollable::ScrollableAccessible::IsScrollable() const { return true; } @@ -100,8 +100,7 @@ bool Scrollable::AccessibleImpl::IsScrollable() const void Scrollable::OnInitialize() { DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::SCROLL_PANE)); + return std::make_unique(actor, Dali::Accessibility::Role::SCROLL_PANE); }); } diff --git a/dali-toolkit/internal/controls/scrollable/scrollable-impl.h b/dali-toolkit/internal/controls/scrollable/scrollable-impl.h index 44d9a33..cbed9c1 100644 --- a/dali-toolkit/internal/controls/scrollable/scrollable-impl.h +++ b/dali-toolkit/internal/controls/scrollable/scrollable-impl.h @@ -117,10 +117,14 @@ public: virtual void SetOvershootSize(const Vector2& size) = 0; protected: // From Control - struct AccessibleImpl : public DevelControl::ControlAccessible + class ScrollableAccessible : public DevelControl::ControlAccessible { + public: using DevelControl::ControlAccessible::ControlAccessible; + /** + * @copydoc Dali::Accessibility::Component::IsScrollable() + */ bool IsScrollable() const override; }; diff --git a/dali-toolkit/internal/controls/slider/slider-impl.cpp b/dali-toolkit/internal/controls/slider/slider-impl.cpp index 7e6370d..49bb8cb 100644 --- a/dali-toolkit/internal/controls/slider/slider-impl.cpp +++ b/dali-toolkit/internal/controls/slider/slider-impl.cpp @@ -209,8 +209,7 @@ void Slider::OnInitialize() self.TouchedSignal().Connect(this, &Slider::OnTouch); DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::SLIDER)); + return std::make_unique(actor, Dali::Accessibility::Role::SLIDER); }); } @@ -1411,25 +1410,25 @@ Property::Value Slider::GetProperty(BaseObject* object, Property::Index property return value; } -double Slider::AccessibleImpl::GetMinimum() const +double Slider::SliderAccessible::GetMinimum() const { auto self = Toolkit::Slider::DownCast(Self()); return self.GetProperty(Toolkit::Slider::Property::LOWER_BOUND).Get(); } -double Slider::AccessibleImpl::GetCurrent() const +double Slider::SliderAccessible::GetCurrent() const { auto self = Toolkit::Slider::DownCast(Self()); return self.GetProperty(Toolkit::Slider::Property::VALUE).Get(); } -double Slider::AccessibleImpl::GetMaximum() const +double Slider::SliderAccessible::GetMaximum() const { auto self = Toolkit::Slider::DownCast(Self()); return self.GetProperty(Toolkit::Slider::Property::UPPER_BOUND).Get(); } -bool Slider::AccessibleImpl::SetCurrent(double current) +bool Slider::SliderAccessible::SetCurrent(double current) { if(current < GetMinimum() || current > GetMaximum()) return false; @@ -1477,7 +1476,7 @@ bool Slider::AccessibleImpl::SetCurrent(double current) return true; } -double Slider::AccessibleImpl::GetMinimumIncrement() const +double Slider::SliderAccessible::GetMinimumIncrement() const { auto self = Toolkit::Slider::DownCast(Self()); diff --git a/dali-toolkit/internal/controls/slider/slider-impl.h b/dali-toolkit/internal/controls/slider/slider-impl.h index 7385953..b34f30c 100644 --- a/dali-toolkit/internal/controls/slider/slider-impl.h +++ b/dali-toolkit/internal/controls/slider/slider-impl.h @@ -749,15 +749,35 @@ private: mSnapToMarks : 1; ///< Turn on or off snapping to marks protected: - struct AccessibleImpl : public DevelControl::ControlAccessible, - public virtual Dali::Accessibility::Value + class SliderAccessible : public DevelControl::ControlAccessible, + public virtual Dali::Accessibility::Value { + public: using DevelControl::ControlAccessible::ControlAccessible; + /** + * @copydoc Dali::Accessibility::Value::GetMinimum() + */ double GetMinimum() const override; + + /** + * @copydoc Dali::Accessibility::Value::GetCurrent() + */ double GetCurrent() const override; + + /** + * @copydoc Dali::Accessibility::Value::GetMaximum() + */ double GetMaximum() const override; - bool SetCurrent(double) override; + + /** + * @copydoc Dali::Accessibility::Value::SetCurrent() + */ + bool SetCurrent(double) override; + + /** + * @copydoc Dali::Accessibility::Value::GetMinimumIncrement() + */ double GetMinimumIncrement() const override; }; }; diff --git a/dali-toolkit/internal/controls/text-controls/text-anchor-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-anchor-impl.cpp index 37831ea..88fa3d3 100644 --- a/dali-toolkit/internal/controls/text-controls/text-anchor-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-anchor-impl.cpp @@ -149,8 +149,7 @@ void TextAnchor::OnInitialize() self.SetProperty(Toolkit::DevelControl::Property::ACCESSIBILITY_HIGHLIGHTABLE, true); DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::LINK)); + return std::make_unique(actor, Dali::Accessibility::Role::LINK); }); } @@ -166,35 +165,35 @@ TextAnchor::~TextAnchor() { } -int32_t TextAnchor::AccessibleImpl::GetEndIndex() const +int32_t TextAnchor::TextAnchorAccessible::GetEndIndex() const { auto self = Toolkit::TextAnchor::DownCast(Self()); return self.GetProperty(Toolkit::TextAnchor::Property::END_CHARACTER_INDEX).Get(); } -int32_t TextAnchor::AccessibleImpl::GetStartIndex() const +int32_t TextAnchor::TextAnchorAccessible::GetStartIndex() const { auto self = Toolkit::TextAnchor::DownCast(Self()); return self.GetProperty(Toolkit::TextAnchor::Property::START_CHARACTER_INDEX).Get(); } -int32_t TextAnchor::AccessibleImpl::GetAnchorCount() const +int32_t TextAnchor::TextAnchorAccessible::GetAnchorCount() const { return 1; } -Dali::Accessibility::Accessible* TextAnchor::AccessibleImpl::GetAnchorAccessible(int32_t anchorIndex) const +Dali::Accessibility::Accessible* TextAnchor::TextAnchorAccessible::GetAnchorAccessible(int32_t anchorIndex) const { return Control::Impl::GetAccessibilityObject(Self()); } -std::string TextAnchor::AccessibleImpl::GetAnchorUri(int32_t anchorIndex) const +std::string TextAnchor::TextAnchorAccessible::GetAnchorUri(int32_t anchorIndex) const { auto self = Toolkit::TextAnchor::DownCast(Self()); return self.GetProperty(Toolkit::TextAnchor::Property::URI).Get(); } -bool TextAnchor::AccessibleImpl::IsValid() const +bool TextAnchor::TextAnchorAccessible::IsValid() const { return !GetAnchorUri(0).empty(); } diff --git a/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h b/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h index e26006d..75ef5a2 100644 --- a/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h @@ -105,10 +105,12 @@ protected: /** * @brief This structure is to connect TextAnchor with Accessible functions. */ - struct AccessibleImpl : public DevelControl::ControlAccessible, - public virtual Dali::Accessibility::Hyperlink + class TextAnchorAccessible : public DevelControl::ControlAccessible, + public virtual Dali::Accessibility::Hyperlink { + public: using DevelControl::ControlAccessible::ControlAccessible; + /** * @copydoc Dali::Accessibility::Hyperlink::GetEndIndex() */ diff --git a/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp index 6202c8f..5707e48 100644 --- a/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp @@ -604,8 +604,7 @@ void TextEditor::OnInitialize() self.Add(mStencil); DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::ENTRY)); + return std::make_unique(actor, Dali::Accessibility::Role::ENTRY); }); Accessibility::Bridge::EnabledSignal().Connect(this, &TextEditor::OnAccessibilityStatusChanged); @@ -1349,13 +1348,13 @@ TextEditor::~TextEditor() } } -std::string TextEditor::AccessibleImpl::GetName() const +std::string TextEditor::TextEditorAccessible::GetName() const { auto self = Toolkit::TextEditor::DownCast(Self()); return self.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); } -std::string TextEditor::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) const +std::string TextEditor::TextEditorAccessible::GetText(size_t startOffset, size_t endOffset) const { if(endOffset <= startOffset) { @@ -1373,7 +1372,7 @@ std::string TextEditor::AccessibleImpl::GetText(size_t startOffset, size_t endOf return text.substr(startOffset, endOffset - startOffset); } -size_t TextEditor::AccessibleImpl::GetCharacterCount() const +size_t TextEditor::TextEditorAccessible::GetCharacterCount() const { auto self = Toolkit::TextEditor::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); @@ -1381,13 +1380,13 @@ size_t TextEditor::AccessibleImpl::GetCharacterCount() const return text.size(); } -size_t TextEditor::AccessibleImpl::GetCursorOffset() const +size_t TextEditor::TextEditorAccessible::GetCursorOffset() const { auto slf = Toolkit::TextEditor::DownCast(Self()); return Dali::Toolkit::GetImpl(slf).GetTextController()->GetCursorPosition(); } -bool TextEditor::AccessibleImpl::SetCursorOffset(size_t offset) +bool TextEditor::TextEditorAccessible::SetCursorOffset(size_t offset) { auto slf = Toolkit::TextEditor::DownCast(Self()); auto txt = slf.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); @@ -1403,7 +1402,7 @@ bool TextEditor::AccessibleImpl::SetCursorOffset(size_t offset) return true; } -Dali::Accessibility::Range TextEditor::AccessibleImpl::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) const +Dali::Accessibility::Range TextEditor::TextEditorAccessible::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) const { auto self = Toolkit::TextEditor::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); @@ -1494,7 +1493,7 @@ Dali::Accessibility::Range TextEditor::AccessibleImpl::GetTextAtOffset(size_t of return range; } -Dali::Accessibility::Range TextEditor::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) const +Dali::Accessibility::Range TextEditor::TextEditorAccessible::GetRangeOfSelection(size_t selectionIndex) const { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1511,7 +1510,7 @@ Dali::Accessibility::Range TextEditor::AccessibleImpl::GetRangeOfSelection(size_ return {static_cast(indices.first), static_cast(indices.second), value}; } -bool TextEditor::AccessibleImpl::RemoveSelection(size_t selectionIndex) +bool TextEditor::TextEditorAccessible::RemoveSelection(size_t selectionIndex) { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1524,7 +1523,7 @@ bool TextEditor::AccessibleImpl::RemoveSelection(size_t selectionIndex) return true; } -bool TextEditor::AccessibleImpl::SetRangeOfSelection(size_t selectionIndex, size_t startOffset, size_t endOffset) +bool TextEditor::TextEditorAccessible::SetRangeOfSelection(size_t selectionIndex, size_t startOffset, size_t endOffset) { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1537,7 +1536,7 @@ bool TextEditor::AccessibleImpl::SetRangeOfSelection(size_t selectionIndex, size return true; } -Rect<> TextEditor::AccessibleImpl::GetRangeExtents(size_t startOffset, size_t endOffset, Accessibility::CoordinateType type) +Rect<> TextEditor::TextEditorAccessible::GetRangeExtents(size_t startOffset, size_t endOffset, Accessibility::CoordinateType type) { if (endOffset <= startOffset || endOffset <= 0) { @@ -1555,7 +1554,7 @@ Rect<> TextEditor::AccessibleImpl::GetRangeExtents(size_t startOffset, size_t en return rect; } -bool TextEditor::AccessibleImpl::CopyText(size_t startPosition, size_t endPosition) +bool TextEditor::TextEditorAccessible::CopyText(size_t startPosition, size_t endPosition) { if(endPosition <= startPosition) { @@ -1569,7 +1568,7 @@ bool TextEditor::AccessibleImpl::CopyText(size_t startPosition, size_t endPositi return true; } -bool TextEditor::AccessibleImpl::CutText(size_t startPosition, size_t endPosition) +bool TextEditor::TextEditorAccessible::CutText(size_t startPosition, size_t endPosition) { if(endPosition <= startPosition) { @@ -1585,7 +1584,7 @@ bool TextEditor::AccessibleImpl::CutText(size_t startPosition, size_t endPositio return true; } -bool TextEditor::AccessibleImpl::DeleteText(size_t startPosition, size_t endPosition) +bool TextEditor::TextEditorAccessible::DeleteText(size_t startPosition, size_t endPosition) { if(endPosition <= startPosition) { @@ -1600,7 +1599,7 @@ bool TextEditor::AccessibleImpl::DeleteText(size_t startPosition, size_t endPosi return true; } -Dali::Accessibility::States TextEditor::AccessibleImpl::CalculateStates() +Dali::Accessibility::States TextEditor::TextEditorAccessible::CalculateStates() { using namespace Dali::Accessibility; @@ -1617,7 +1616,7 @@ Dali::Accessibility::States TextEditor::AccessibleImpl::CalculateStates() return states; } -bool TextEditor::AccessibleImpl::InsertText(size_t startPosition, std::string text) +bool TextEditor::TextEditorAccessible::InsertText(size_t startPosition, std::string text) { auto self = Toolkit::TextEditor::DownCast(Self()); auto insertedText = self.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); @@ -1629,20 +1628,20 @@ bool TextEditor::AccessibleImpl::InsertText(size_t startPosition, std::string te return true; } -bool TextEditor::AccessibleImpl::SetTextContents(std::string newContents) +bool TextEditor::TextEditorAccessible::SetTextContents(std::string newContents) { auto self = Toolkit::TextEditor::DownCast(Self()); self.SetProperty(Toolkit::TextEditor::Property::TEXT, std::move(newContents)); return true; } -int32_t TextEditor::AccessibleImpl::GetLinkCount() const +int32_t TextEditor::TextEditorAccessible::GetLinkCount() const { auto self = Toolkit::TextEditor::DownCast(Self()); return Dali::Toolkit::GetImpl(self).mAnchorActors.size(); } -Accessibility::Hyperlink* TextEditor::AccessibleImpl::GetLink(int32_t linkIndex) const +Accessibility::Hyperlink* TextEditor::TextEditorAccessible::GetLink(int32_t linkIndex) const { if(linkIndex < 0 || linkIndex >= GetLinkCount()) { @@ -1653,7 +1652,7 @@ Accessibility::Hyperlink* TextEditor::AccessibleImpl::GetLink(int32_t linkIndex) return dynamic_cast(Dali::Accessibility::Accessible::Get(anchorActor)); } -int32_t TextEditor::AccessibleImpl::GetLinkIndex(int32_t characterOffset) const +int32_t TextEditor::TextEditorAccessible::GetLinkIndex(int32_t characterOffset) const { auto self = Toolkit::TextEditor::DownCast(Self()); auto controller = Dali::Toolkit::GetImpl(self).GetTextController(); diff --git a/dali-toolkit/internal/controls/text-controls/text-editor-impl.h b/dali-toolkit/internal/controls/text-controls/text-editor-impl.h index 8a96a13..e72f19e 100644 --- a/dali-toolkit/internal/controls/text-controls/text-editor-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-editor-impl.h @@ -577,10 +577,11 @@ private: // Data /** * @brief This structure is to connect TextEditor with Accessible functions. */ - struct AccessibleImpl : public DevelControl::ControlAccessible, - public virtual Dali::Accessibility::EditableText, - public virtual Dali::Accessibility::Hypertext + class TextEditorAccessible : public DevelControl::ControlAccessible, + public virtual Dali::Accessibility::EditableText, + public virtual Dali::Accessibility::Hypertext { + public: using DevelControl::ControlAccessible::ControlAccessible; /** diff --git a/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp index 35d06ea..c48f814 100644 --- a/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp @@ -561,8 +561,7 @@ void TextField::OnInitialize() } DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::ENTRY)); + return std::make_unique(actor, Dali::Accessibility::Role::ENTRY); }); Accessibility::Bridge::EnabledSignal().Connect(this, &TextField::OnAccessibilityStatusChanged); @@ -1192,7 +1191,7 @@ Vector TextField::GetTextPosition(const uint32_t startIndex, const uint return mController->GetTextPosition(startIndex, endIndex); } -std::string TextField::AccessibleImpl::GetName() const +std::string TextField::TextFieldAccessible::GetName() const { auto self = Toolkit::TextField::DownCast(Self()); if(IsHiddenInput(self)) @@ -1203,7 +1202,7 @@ std::string TextField::AccessibleImpl::GetName() const return self.GetProperty(Toolkit::TextField::Property::TEXT).Get(); } -std::string TextField::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) const +std::string TextField::TextFieldAccessible::GetText(size_t startOffset, size_t endOffset) const { if(endOffset <= startOffset) { @@ -1224,7 +1223,7 @@ std::string TextField::AccessibleImpl::GetText(size_t startOffset, size_t endOff return text.substr(startOffset, endOffset - startOffset); } -size_t TextField::AccessibleImpl::GetCharacterCount() const +size_t TextField::TextFieldAccessible::GetCharacterCount() const { auto self = Toolkit::TextField::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextField::Property::TEXT).Get(); @@ -1232,13 +1231,13 @@ size_t TextField::AccessibleImpl::GetCharacterCount() const return text.size(); } -size_t TextField::AccessibleImpl::GetCursorOffset() const +size_t TextField::TextFieldAccessible::GetCursorOffset() const { auto self = Toolkit::TextField::DownCast(Self()); return Dali::Toolkit::GetImpl(self).GetTextController()->GetCursorPosition(); } -bool TextField::AccessibleImpl::SetCursorOffset(size_t offset) +bool TextField::TextFieldAccessible::SetCursorOffset(size_t offset) { auto self = Toolkit::TextField::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextField::Property::TEXT).Get(); @@ -1254,7 +1253,7 @@ bool TextField::AccessibleImpl::SetCursorOffset(size_t offset) return true; } -Dali::Accessibility::Range TextField::AccessibleImpl::GetTextAtOffset( +Dali::Accessibility::Range TextField::TextFieldAccessible::GetTextAtOffset( size_t offset, Dali::Accessibility::TextBoundary boundary) const { auto self = Toolkit::TextField::DownCast(Self()); @@ -1353,7 +1352,7 @@ Dali::Accessibility::Range TextField::AccessibleImpl::GetTextAtOffset( return range; } -Dali::Accessibility::Range TextField::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) const +Dali::Accessibility::Range TextField::TextFieldAccessible::GetRangeOfSelection(size_t selectionIndex) const { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1378,7 +1377,7 @@ Dali::Accessibility::Range TextField::AccessibleImpl::GetRangeOfSelection(size_t return {startOffset, endOffset, value}; } -bool TextField::AccessibleImpl::RemoveSelection(size_t selectionIndex) +bool TextField::TextFieldAccessible::RemoveSelection(size_t selectionIndex) { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1391,7 +1390,7 @@ bool TextField::AccessibleImpl::RemoveSelection(size_t selectionIndex) return true; } -bool TextField::AccessibleImpl::SetRangeOfSelection(size_t selectionIndex, size_t startOffset, size_t endOffset) +bool TextField::TextFieldAccessible::SetRangeOfSelection(size_t selectionIndex, size_t startOffset, size_t endOffset) { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1404,7 +1403,7 @@ bool TextField::AccessibleImpl::SetRangeOfSelection(size_t selectionIndex, size_ return true; } -Rect<> TextField::AccessibleImpl::GetRangeExtents(size_t startOffset, size_t endOffset, Accessibility::CoordinateType type) +Rect<> TextField::TextFieldAccessible::GetRangeExtents(size_t startOffset, size_t endOffset, Accessibility::CoordinateType type) { if (endOffset <= startOffset || endOffset <= 0) { @@ -1422,7 +1421,7 @@ Rect<> TextField::AccessibleImpl::GetRangeExtents(size_t startOffset, size_t end return rect; } -bool TextField::AccessibleImpl::CopyText(size_t startPosition, size_t endPosition) +bool TextField::TextFieldAccessible::CopyText(size_t startPosition, size_t endPosition) { if(endPosition <= startPosition) { @@ -1436,7 +1435,7 @@ bool TextField::AccessibleImpl::CopyText(size_t startPosition, size_t endPositio return true; } -bool TextField::AccessibleImpl::CutText(size_t startPosition, size_t endPosition) +bool TextField::TextFieldAccessible::CutText(size_t startPosition, size_t endPosition) { if(endPosition <= startPosition) { @@ -1452,7 +1451,7 @@ bool TextField::AccessibleImpl::CutText(size_t startPosition, size_t endPosition return true; } -bool TextField::AccessibleImpl::DeleteText(size_t startPosition, size_t endPosition) +bool TextField::TextFieldAccessible::DeleteText(size_t startPosition, size_t endPosition) { if(endPosition <= startPosition) { @@ -1467,7 +1466,7 @@ bool TextField::AccessibleImpl::DeleteText(size_t startPosition, size_t endPosit return true; } -Dali::Accessibility::States TextField::AccessibleImpl::CalculateStates() +Dali::Accessibility::States TextField::TextFieldAccessible::CalculateStates() { using namespace Dali::Accessibility; @@ -1485,7 +1484,7 @@ Dali::Accessibility::States TextField::AccessibleImpl::CalculateStates() return states; } -bool TextField::AccessibleImpl::InsertText(size_t startPosition, std::string text) +bool TextField::TextFieldAccessible::InsertText(size_t startPosition, std::string text) { auto self = Toolkit::TextField::DownCast(Self()); auto insertedText = self.GetProperty(Toolkit::TextField::Property::TEXT).Get(); @@ -1497,20 +1496,20 @@ bool TextField::AccessibleImpl::InsertText(size_t startPosition, std::string tex return true; } -bool TextField::AccessibleImpl::SetTextContents(std::string newContents) +bool TextField::TextFieldAccessible::SetTextContents(std::string newContents) { auto self = Toolkit::TextField::DownCast(Self()); self.SetProperty(Toolkit::TextField::Property::TEXT, std::move(newContents)); return true; } -int32_t TextField::AccessibleImpl::GetLinkCount() const +int32_t TextField::TextFieldAccessible::GetLinkCount() const { auto self = Toolkit::TextField::DownCast(Self()); return Dali::Toolkit::GetImpl(self).mAnchorActors.size(); } -Accessibility::Hyperlink* TextField::AccessibleImpl::GetLink(int32_t linkIndex) const +Accessibility::Hyperlink* TextField::TextFieldAccessible::GetLink(int32_t linkIndex) const { if(linkIndex < 0 || linkIndex >= GetLinkCount()) { @@ -1521,7 +1520,7 @@ Accessibility::Hyperlink* TextField::AccessibleImpl::GetLink(int32_t linkIndex) return dynamic_cast(Dali::Accessibility::Accessible::Get(anchorActor)); } -int32_t TextField::AccessibleImpl::GetLinkIndex(int32_t characterOffset) const +int32_t TextField::TextFieldAccessible::GetLinkIndex(int32_t characterOffset) const { auto self = Toolkit::TextField::DownCast(Self()); auto controller = Dali::Toolkit::GetImpl(self).GetTextController(); diff --git a/dali-toolkit/internal/controls/text-controls/text-field-impl.h b/dali-toolkit/internal/controls/text-controls/text-field-impl.h index c10dd51..47783e3 100644 --- a/dali-toolkit/internal/controls/text-controls/text-field-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-field-impl.h @@ -526,10 +526,11 @@ protected: /** * @brief This structure is to connect TextField with Accessible functions. */ - struct AccessibleImpl : public DevelControl::ControlAccessible, - public virtual Dali::Accessibility::EditableText, - public virtual Dali::Accessibility::Hypertext + class TextFieldAccessible : public DevelControl::ControlAccessible, + public virtual Dali::Accessibility::EditableText, + public virtual Dali::Accessibility::Hypertext { + public: using DevelControl::ControlAccessible::ControlAccessible; /** diff --git a/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp index fa9c6c0..ee4ce64 100644 --- a/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp @@ -900,8 +900,7 @@ void TextLabel::OnInitialize() engine.SetCursorWidth(0u); // Do not layout space for the cursor. DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { - return std::unique_ptr( - new AccessibleImpl(actor, Dali::Accessibility::Role::LABEL)); + return std::make_unique(actor, Dali::Accessibility::Role::LABEL); }); Accessibility::Bridge::EnabledSignal().Connect(this, &TextLabel::OnAccessibilityStatusChanged); @@ -1198,18 +1197,18 @@ Vector TextLabel::GetTextPosition(const uint32_t startIndex, const uint return mController->GetTextPosition(startIndex, endIndex); } -std::string TextLabel::AccessibleImpl::GetNameRaw() const +std::string TextLabel::TextLabelAccessible::GetNameRaw() const { auto self = Toolkit::TextLabel::DownCast(Self()); return self.GetProperty(Toolkit::TextLabel::Property::TEXT).Get(); } -Property::Index TextLabel::AccessibleImpl::GetNamePropertyIndex() +Property::Index TextLabel::TextLabelAccessible::GetNamePropertyIndex() { return Toolkit::TextLabel::Property::TEXT; } -std::string TextLabel::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) const +std::string TextLabel::TextLabelAccessible::GetText(size_t startOffset, size_t endOffset) const { if(endOffset <= startOffset) { @@ -1227,7 +1226,7 @@ std::string TextLabel::AccessibleImpl::GetText(size_t startOffset, size_t endOff return text.substr(startOffset, endOffset - startOffset); } -size_t TextLabel::AccessibleImpl::GetCharacterCount() const +size_t TextLabel::TextLabelAccessible::GetCharacterCount() const { auto self = Toolkit::TextLabel::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextLabel::Property::TEXT).Get(); @@ -1235,17 +1234,17 @@ size_t TextLabel::AccessibleImpl::GetCharacterCount() const return text.size(); } -size_t TextLabel::AccessibleImpl::GetCursorOffset() const +size_t TextLabel::TextLabelAccessible::GetCursorOffset() const { return {}; } -bool TextLabel::AccessibleImpl::SetCursorOffset(size_t offset) +bool TextLabel::TextLabelAccessible::SetCursorOffset(size_t offset) { return {}; } -Dali::Accessibility::Range TextLabel::AccessibleImpl::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) const +Dali::Accessibility::Range TextLabel::TextLabelAccessible::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) const { auto self = Toolkit::TextLabel::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextLabel::Property::TEXT).Get(); @@ -1336,7 +1335,7 @@ Dali::Accessibility::Range TextLabel::AccessibleImpl::GetTextAtOffset(size_t off return range; } -Dali::Accessibility::Range TextLabel::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) const +Dali::Accessibility::Range TextLabel::TextLabelAccessible::GetRangeOfSelection(size_t selectionIndex) const { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1353,7 +1352,7 @@ Dali::Accessibility::Range TextLabel::AccessibleImpl::GetRangeOfSelection(size_t return {static_cast(indices.first), static_cast(indices.second), value}; } -bool TextLabel::AccessibleImpl::RemoveSelection(size_t selectionIndex) +bool TextLabel::TextLabelAccessible::RemoveSelection(size_t selectionIndex) { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1366,7 +1365,7 @@ bool TextLabel::AccessibleImpl::RemoveSelection(size_t selectionIndex) return true; } -bool TextLabel::AccessibleImpl::SetRangeOfSelection(size_t selectionIndex, size_t startOffset, size_t endOffset) +bool TextLabel::TextLabelAccessible::SetRangeOfSelection(size_t selectionIndex, size_t startOffset, size_t endOffset) { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1379,7 +1378,7 @@ bool TextLabel::AccessibleImpl::SetRangeOfSelection(size_t selectionIndex, size_ return true; } -Rect<> TextLabel::AccessibleImpl::GetRangeExtents(size_t startOffset, size_t endOffset, Accessibility::CoordinateType type) +Rect<> TextLabel::TextLabelAccessible::GetRangeExtents(size_t startOffset, size_t endOffset, Accessibility::CoordinateType type) { if (endOffset <= startOffset || endOffset <= 0) { @@ -1397,13 +1396,13 @@ Rect<> TextLabel::AccessibleImpl::GetRangeExtents(size_t startOffset, size_t end return rect; } -int32_t TextLabel::AccessibleImpl::GetLinkCount() const +int32_t TextLabel::TextLabelAccessible::GetLinkCount() const { auto self = Toolkit::TextLabel::DownCast(Self()); return Dali::Toolkit::GetImpl(self).mAnchorActors.size(); } -Accessibility::Hyperlink* TextLabel::AccessibleImpl::GetLink(int32_t linkIndex) const +Accessibility::Hyperlink* TextLabel::TextLabelAccessible::GetLink(int32_t linkIndex) const { if(linkIndex < 0 || linkIndex >= GetLinkCount()) { @@ -1414,7 +1413,7 @@ Accessibility::Hyperlink* TextLabel::AccessibleImpl::GetLink(int32_t linkIndex) return dynamic_cast(Dali::Accessibility::Accessible::Get(anchorActor)); } -int32_t TextLabel::AccessibleImpl::GetLinkIndex(int32_t characterOffset) const +int32_t TextLabel::TextLabelAccessible::GetLinkIndex(int32_t characterOffset) const { auto self = Toolkit::TextLabel::DownCast(Self()); auto controller = Dali::Toolkit::GetImpl(self).GetTextController(); diff --git a/dali-toolkit/internal/controls/text-controls/text-label-impl.h b/dali-toolkit/internal/controls/text-controls/text-label-impl.h index 9cba1c4..4c2ca97 100644 --- a/dali-toolkit/internal/controls/text-controls/text-label-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-label-impl.h @@ -246,10 +246,11 @@ protected: /** * @brief This structure is to connect TextLabel with Accessible functions. */ - struct AccessibleImpl : public DevelControl::ControlAccessible, - public virtual Dali::Accessibility::Text, - public virtual Dali::Accessibility::Hypertext + class TextLabelAccessible : public DevelControl::ControlAccessible, + public virtual Dali::Accessibility::Text, + public virtual Dali::Accessibility::Hypertext { + public: using DevelControl::ControlAccessible::ControlAccessible; /**