From: Artur Świgoń Date: Fri, 3 Dec 2021 13:00:20 +0000 (+0100) Subject: [AT-SPI] Synchronize with AT-SPI cleanup in dali-adaptor X-Git-Tag: dali_2.1.4~8 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=9a5ce98a301f74f8df8a3be6d223b525c8839b0b [AT-SPI] Synchronize with AT-SPI cleanup in dali-adaptor A related dali-adaptor change adds const-correctness and introduces a new, more coherent naming convention for Accessible objects. The name ControlAccessible now matches ApplicationAccessible, ProxyAccessible etc. and the upcoming ActorAccessible. Change-Id: I63a6887e1c291fbfb475fd8c2384126a31981d6b --- diff --git a/automated-tests/src/dali-toolkit-internal/utc-Dali-Accessibility-Controls-BridgeUp.cpp b/automated-tests/src/dali-toolkit-internal/utc-Dali-Accessibility-Controls-BridgeUp.cpp index 684d70d..9e352e5 100644 --- a/automated-tests/src/dali-toolkit-internal/utc-Dali-Accessibility-Controls-BridgeUp.cpp +++ b/automated-tests/src/dali-toolkit-internal/utc-Dali-Accessibility-Controls-BridgeUp.cpp @@ -1077,11 +1077,11 @@ int UtcDaliAccessibilityScrollToChildScrollView(void) Wait(application); - auto* accessibleParent = dynamic_cast(Dali::Accessibility::Accessible::Get(scrollView)); + auto* accessibleParent = dynamic_cast(Dali::Accessibility::Accessible::Get(scrollView)); DALI_TEST_CHECK(accessibleParent); - auto* accessibleA = dynamic_cast(Dali::Accessibility::Accessible::Get(actorA)); + auto* accessibleA = dynamic_cast(Dali::Accessibility::Accessible::Get(actorA)); DALI_TEST_CHECK(accessibleA); - auto* accessibleB = dynamic_cast(Dali::Accessibility::Accessible::Get(actorB)); + auto* accessibleB = dynamic_cast(Dali::Accessibility::Accessible::Get(actorB)); DALI_TEST_CHECK(accessibleB); accessibleA->GrabHighlight(); // == scrollView.ScrollTo(actorA) @@ -1132,11 +1132,11 @@ int UtcDaliAccessibilityScrollToChildItemView(void) Wait(application); - auto* accessibleParent = dynamic_cast(Dali::Accessibility::Accessible::Get(view)); + auto* accessibleParent = dynamic_cast(Dali::Accessibility::Accessible::Get(view)); DALI_TEST_CHECK(accessibleParent); - auto* accessibleA = dynamic_cast(Dali::Accessibility::Accessible::Get(view.GetItem(0))); + auto* accessibleA = dynamic_cast(Dali::Accessibility::Accessible::Get(view.GetItem(0))); DALI_TEST_CHECK(accessibleA); - auto* accessibleB = dynamic_cast(Dali::Accessibility::Accessible::Get(view.GetItem(1))); + auto* accessibleB = dynamic_cast(Dali::Accessibility::Accessible::Get(view.GetItem(1))); DALI_TEST_CHECK(accessibleB); accessibleA->GrabHighlight(); // == view.ScrollToItem(view.GetItemId(actorA)) @@ -1155,7 +1155,7 @@ int UtcDaliAccessibilityScrollToChildNonScrollable(void) TextLabel label = TextLabel::New("123"); - auto* accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(label)); + auto* accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(label)); DALI_TEST_CHECK(accessible); DALI_TEST_EQUALS(accessible->IsScrollable(), false, TEST_LOCATION); @@ -1197,7 +1197,7 @@ int UtcDaliAccessibilityCheckHighlight(void) Wait(application); // Set highlight to first child (A) to enable movement tracking - auto* accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(buttonA)); + auto* accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(buttonA)); DALI_TEST_CHECK(accessible); accessible->GrabHighlight(); Wait(application); @@ -1223,7 +1223,7 @@ int UtcDaliAccessibilityCheckHighlight(void) Dali::Accessibility::TestResetMoveOutedCalled(); // Set highlight to second child (B) to enable movement tracking - accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(buttonB)); + accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(buttonB)); DALI_TEST_CHECK(accessible); accessible->GrabHighlight(); Wait(application); @@ -1261,7 +1261,7 @@ int UtcDaliAccessibilityCheckHighlight(void) Dali::Accessibility::TestResetMoveOutedCalled(); // Disable movement tracking on B by giving highlight to A - accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(buttonA)); + accessible = dynamic_cast(Dali::Accessibility::Accessible::Get(buttonA)); DALI_TEST_CHECK(accessible); accessible->GrabHighlight(); Wait(application); diff --git a/dali-toolkit/devel-api/controls/accessible-impl.cpp b/dali-toolkit/devel-api/controls/control-accessible.cpp similarity index 83% rename from dali-toolkit/devel-api/controls/accessible-impl.cpp rename to dali-toolkit/devel-api/controls/control-accessible.cpp index e01bcb5..7010a6c 100644 --- a/dali-toolkit/devel-api/controls/accessible-impl.cpp +++ b/dali-toolkit/devel-api/controls/control-accessible.cpp @@ -16,7 +16,7 @@ */ // CLASS HEADER -#include "accessible-impl.h" +#include "control-accessible.h" // EXTERNAL INCLUDES #ifdef DGETTEXT_ENABLED @@ -66,7 +66,7 @@ static Dali::Actor CreateHighlightIndicatorActor() } } // unnamed namespace -AccessibleImpl::AccessibleImpl(Dali::Actor self, Dali::Accessibility::Role role, bool modal) +ControlAccessible::ControlAccessible(Dali::Actor self, Dali::Accessibility::Role role, bool modal) : mSelf(self), mIsModal(modal) { @@ -103,7 +103,7 @@ AccessibleImpl::AccessibleImpl(Dali::Actor self, Dali::Accessibility::Role role, }); } -std::string AccessibleImpl::GetName() +std::string ControlAccessible::GetName() const { auto control = Dali::Toolkit::Control::DownCast(Self()); @@ -136,12 +136,12 @@ std::string AccessibleImpl::GetName() return GetLocaleText(name); } -std::string AccessibleImpl::GetNameRaw() +std::string ControlAccessible::GetNameRaw() const { return {}; } -std::string AccessibleImpl::GetDescription() +std::string ControlAccessible::GetDescription() const { auto control = Dali::Toolkit::Control::DownCast(Self()); @@ -169,27 +169,27 @@ std::string AccessibleImpl::GetDescription() return GetLocaleText(description); } -std::string AccessibleImpl::GetDescriptionRaw() +std::string ControlAccessible::GetDescriptionRaw() const { return {}; } -Dali::Accessibility::Accessible* AccessibleImpl::GetParent() +Dali::Accessibility::Accessible* ControlAccessible::GetParent() { return Dali::Accessibility::Accessible::Get(Self().GetParent()); } -size_t AccessibleImpl::GetChildCount() +size_t ControlAccessible::GetChildCount() const { return Self().GetChildCount(); } -Dali::Accessibility::Accessible* AccessibleImpl::GetChildAtIndex(size_t index) +Dali::Accessibility::Accessible* ControlAccessible::GetChildAtIndex(size_t index) { return Dali::Accessibility::Accessible::Get(Self().GetChildAt(static_cast(index))); } -size_t AccessibleImpl::GetIndexInParent() +size_t ControlAccessible::GetIndexInParent() { auto self = Self(); auto parent = self.GetParent(); @@ -208,17 +208,17 @@ size_t AccessibleImpl::GetIndexInParent() return static_cast(-1); } -Dali::Accessibility::Role AccessibleImpl::GetRole() +Dali::Accessibility::Role ControlAccessible::GetRole() const { return Self().GetProperty(Toolkit::DevelControl::Property::ACCESSIBILITY_ROLE); } -std::string AccessibleImpl::GetLocalizedRoleName() +std::string ControlAccessible::GetLocalizedRoleName() const { return GetLocaleText(GetRoleName()); } -bool AccessibleImpl::IsShowing() +bool ControlAccessible::IsShowing() { Dali::Actor self = Self(); if(!self.GetProperty(Actor::Property::VISIBLE) || self.GetProperty(Actor::Property::WORLD_COLOR).a == 0 || self.GetProperty(Dali::DevelActor::Property::CULLED)) @@ -227,7 +227,7 @@ bool AccessibleImpl::IsShowing() } auto* child = this; - auto* parent = dynamic_cast(child->GetParent()); + auto* parent = dynamic_cast(child->GetParent()); if(!parent) { return true; @@ -247,13 +247,13 @@ bool AccessibleImpl::IsShowing() { return false; } - parent = dynamic_cast(parent->GetParent()); + parent = dynamic_cast(parent->GetParent()); } return true; } -Dali::Accessibility::States AccessibleImpl::CalculateStates() +Dali::Accessibility::States ControlAccessible::CalculateStates() { Dali::Actor self = Self(); Dali::Accessibility::States state; @@ -283,12 +283,12 @@ Dali::Accessibility::States AccessibleImpl::CalculateStates() return state; } -Dali::Accessibility::States AccessibleImpl::GetStates() +Dali::Accessibility::States ControlAccessible::GetStates() { return CalculateStates(); } -Dali::Accessibility::Attributes AccessibleImpl::GetAttributes() +Dali::Accessibility::Attributes ControlAccessible::GetAttributes() const { std::unordered_map attributeMap; auto control = Dali::Toolkit::Control::DownCast(Self()); @@ -316,12 +316,12 @@ Dali::Accessibility::Attributes AccessibleImpl::GetAttributes() return attributeMap; } -Dali::Accessibility::ComponentLayer AccessibleImpl::GetLayer() +Dali::Accessibility::ComponentLayer ControlAccessible::GetLayer() const { return Dali::Accessibility::ComponentLayer::WINDOW; } -Dali::Rect<> AccessibleImpl::GetExtents(Dali::Accessibility::CoordinateType type) +Dali::Rect<> ControlAccessible::GetExtents(Dali::Accessibility::CoordinateType type) const { Dali::Actor self = Self(); @@ -343,24 +343,25 @@ Dali::Rect<> AccessibleImpl::GetExtents(Dali::Accessibility::CoordinateType type } } -int16_t AccessibleImpl::GetMdiZOrder() +int16_t ControlAccessible::GetMdiZOrder() const { return 0; } -double AccessibleImpl::GetAlpha() + +double ControlAccessible::GetAlpha() const { return 0; } -bool AccessibleImpl::GrabFocus() +bool ControlAccessible::GrabFocus() { return Toolkit::KeyboardFocusManager::Get().SetCurrentFocusActor(Self()); } -void AccessibleImpl::ScrollToSelf() +void ControlAccessible::ScrollToSelf() { auto* child = this; - auto* parent = dynamic_cast(child->GetParent()); + auto* parent = dynamic_cast(child->GetParent()); while (parent) { @@ -369,11 +370,11 @@ void AccessibleImpl::ScrollToSelf() parent->ScrollToChild(child->Self()); } - parent = dynamic_cast(parent->GetParent()); + parent = dynamic_cast(parent->GetParent()); } } -void AccessibleImpl::RegisterPositionPropertyNotification() +void ControlAccessible::RegisterPositionPropertyNotification() { auto control = Dali::Toolkit::Control::DownCast(Self()); Internal::Control& internalControl = Toolkit::Internal::GetImplementation(control); @@ -381,7 +382,7 @@ void AccessibleImpl::RegisterPositionPropertyNotification() controlImpl.RegisterAccessibilityPositionPropertyNotification(); } -void AccessibleImpl::UnregisterPositionPropertyNotification() +void ControlAccessible::UnregisterPositionPropertyNotification() { auto control = Dali::Toolkit::Control::DownCast(Self()); Internal::Control& internalControl = Toolkit::Internal::GetImplementation(control); @@ -389,7 +390,7 @@ void AccessibleImpl::UnregisterPositionPropertyNotification() controlImpl.UnregisterAccessibilityPositionPropertyNotification(); } -bool AccessibleImpl::GrabHighlight() +bool ControlAccessible::GrabHighlight() { Dali::Actor self = Self(); auto oldHighlightedActor = GetCurrentlyHighlightedActor(); @@ -426,8 +427,8 @@ bool AccessibleImpl::GrabHighlight() highlight.SetProperty(Actor::Property::POSITION, Vector2(0.0f, 0.0f)); // Need to set resize policy again, to update SIZE property which is set by - // AccessibleImpl_NUI. The highlight could move from AccessibleImpl_NUI to - // AccessibleImpl. In this case, highlight has incorrect size. + // NUIViewAccessible. The highlight could move from NUIViewAccessible to + // ControlAccessible. In this case, highlight has incorrect size. highlight.SetResizePolicy(ResizePolicy::FILL_TO_PARENT, Dimension::ALL_DIMENSIONS); // Remember the highlight actor, so that when the default is changed with @@ -442,7 +443,7 @@ bool AccessibleImpl::GrabHighlight() return true; } -bool AccessibleImpl::ClearHighlight() +bool ControlAccessible::ClearHighlight() { Dali::Actor self = Self(); @@ -463,7 +464,7 @@ bool AccessibleImpl::ClearHighlight() return false; } -std::string AccessibleImpl::GetActionName(size_t index) +std::string ControlAccessible::GetActionName(size_t index) const { if(index >= GetActionCount()) { @@ -476,17 +477,17 @@ std::string AccessibleImpl::GetActionName(size_t index) return type.GetActionName(index); } -std::string AccessibleImpl::GetLocalizedActionName(size_t index) +std::string ControlAccessible::GetLocalizedActionName(size_t index) const { return GetLocaleText(GetActionName(index)); } -std::string AccessibleImpl::GetActionDescription(size_t index) +std::string ControlAccessible::GetActionDescription(size_t index) const { return {}; } -size_t AccessibleImpl::GetActionCount() +size_t ControlAccessible::GetActionCount() const { Dali::TypeInfo type; Self().GetTypeInfo(type); @@ -494,23 +495,23 @@ size_t AccessibleImpl::GetActionCount() return type.GetActionCount(); } -std::string AccessibleImpl::GetActionKeyBinding(size_t index) +std::string ControlAccessible::GetActionKeyBinding(size_t index) const { return {}; } -bool AccessibleImpl::DoAction(size_t index) +bool ControlAccessible::DoAction(size_t index) { std::string actionName = GetActionName(index); return Self().DoAction(actionName, {}); } -bool AccessibleImpl::DoAction(const std::string& name) +bool ControlAccessible::DoAction(const std::string& name) { return Self().DoAction(name, {}); } -bool AccessibleImpl::DoGesture(const Dali::Accessibility::GestureInfo& gestureInfo) +bool ControlAccessible::DoGesture(const Dali::Accessibility::GestureInfo& gestureInfo) { auto control = Dali::Toolkit::Control::DownCast(Self()); @@ -527,7 +528,7 @@ bool AccessibleImpl::DoGesture(const Dali::Accessibility::GestureInfo& gestureIn return false; } -std::vector AccessibleImpl::GetRelationSet() +std::vector ControlAccessible::GetRelationSet() { auto control = Dali::Toolkit::Control::DownCast(Self()); @@ -551,32 +552,32 @@ std::vector AccessibleImpl::GetRelationSet() return ret; } -Dali::Actor AccessibleImpl::GetInternalActor() +Dali::Actor ControlAccessible::GetInternalActor() { return Dali::Actor{}; } -bool AccessibleImpl::ScrollToChild(Actor child) +bool ControlAccessible::ScrollToChild(Actor child) { return false; } -Dali::Property::Index AccessibleImpl::GetNamePropertyIndex() +Dali::Property::Index ControlAccessible::GetNamePropertyIndex() { return Actor::Property::NAME; } -Dali::Property::Index AccessibleImpl::GetDescriptionPropertyIndex() +Dali::Property::Index ControlAccessible::GetDescriptionPropertyIndex() { return Dali::Property::INVALID_INDEX; } -void AccessibleImpl::SetLastPosition(Vector2 position) +void ControlAccessible::SetLastPosition(Vector2 position) { mLastPosition = position; } -Vector2 AccessibleImpl::GetLastPosition() const +Vector2 ControlAccessible::GetLastPosition() const { return mLastPosition; } diff --git a/dali-toolkit/devel-api/controls/accessible-impl.h b/dali-toolkit/devel-api/controls/control-accessible.h similarity index 80% rename from dali-toolkit/devel-api/controls/accessible-impl.h rename to dali-toolkit/devel-api/controls/control-accessible.h index f1f62a7..5e576fd 100644 --- a/dali-toolkit/devel-api/controls/accessible-impl.h +++ b/dali-toolkit/devel-api/controls/control-accessible.h @@ -1,5 +1,6 @@ -#ifndef DALI_TOOLKIT_ACCESSIBLE_IMPL_H -#define DALI_TOOLKIT_ACCESSIBLE_IMPL_H +#ifndef DALI_TOOLKIT_CONTROL_ACCESSIBLE_H +#define DALI_TOOLKIT_CONTROL_ACCESSIBLE_H + /* * Copyright (c) 2021 Samsung Electronics Co., Ltd. * @@ -16,6 +17,7 @@ * limitations under the License. * */ + // EXTERNAL INCLUDES #include #include @@ -45,10 +47,10 @@ namespace Dali::Toolkit::DevelControl { * @see Dali::Accessibility::Text * @see Dali::Accessibility::EditableText */ -struct DALI_TOOLKIT_API AccessibleImpl : public virtual Dali::Accessibility::Accessible, - public virtual Dali::Accessibility::Component, - public virtual Dali::Accessibility::Collection, - public virtual Dali::Accessibility::Action +struct DALI_TOOLKIT_API ControlAccessible : public virtual Dali::Accessibility::Accessible, + public virtual Dali::Accessibility::Component, + public virtual Dali::Accessibility::Collection, + public virtual Dali::Accessibility::Action { protected: Vector2 mLastPosition{0.0f, 0.0f}; @@ -87,27 +89,27 @@ protected: bool IsShowing(); public: - AccessibleImpl(Dali::Actor self, Dali::Accessibility::Role role, bool modal = false); + ControlAccessible(Dali::Actor self, Dali::Accessibility::Role role, bool modal = false); /** * @copydoc Dali::Accessibility::Accessible::GetName() */ - std::string GetName() override; + std::string GetName() const override; /** * @brief Returns the actor's name in the absence of ACCESSIBILITY_NAME property */ - virtual std::string GetNameRaw(); + virtual std::string GetNameRaw() const; /** * @copydoc Dali::Accessibility::Accessible::GetDescription() */ - std::string GetDescription() override; + std::string GetDescription() const override; /** * @brief Returns the actor's description in the absence of ACCESSIBILITY_DESCRIPTION property */ - virtual std::string GetDescriptionRaw(); + virtual std::string GetDescriptionRaw() const; /** * @copydoc Dali::Accessibility::Accessible::GetParent() @@ -117,7 +119,7 @@ public: /** * @copydoc Dali::Accessibility::Accessible::GetChildCount() */ - size_t GetChildCount() override; + size_t GetChildCount() const override; /** * @copydoc Dali::Accessibility::Accessible::GetChildAtIndex() @@ -132,12 +134,12 @@ public: /** * @copydoc Dali::Accessibility::Accessible::GetRole() */ - Dali::Accessibility::Role GetRole() override; + Dali::Accessibility::Role GetRole() const override; /** * @copydoc Dali::Accessibility::Accessible::GetLocalizedRoleName() */ - std::string GetLocalizedRoleName() override; + std::string GetLocalizedRoleName() const override; /** * @copydoc Dali::Accessibility::Accessible::GetStates() @@ -147,22 +149,22 @@ public: /** * @copydoc Dali::Accessibility::Accessible::GetAttributes() */ - Dali::Accessibility::Attributes GetAttributes() override; + Dali::Accessibility::Attributes GetAttributes() const override; /** * @copydoc Dali::Accessibility::Component::GetExtents() */ - Dali::Rect<> GetExtents(Accessibility::CoordinateType type) override; + Dali::Rect<> GetExtents(Accessibility::CoordinateType type) const override; /** * @copydoc Dali::Accessibility::Component::GetLayer() */ - Dali::Accessibility::ComponentLayer GetLayer() override; + Dali::Accessibility::ComponentLayer GetLayer() const override; /** * @copydoc Dali::Accessibility::Component::GetMdiZOrder() */ - int16_t GetMdiZOrder() override; + int16_t GetMdiZOrder() const override; /** * @copydoc Dali::Accessibility::Component::GrabFocus() @@ -172,7 +174,7 @@ public: /** * @copydoc Dali::Accessibility::Component::GetAlpha() */ - double GetAlpha() override; + double GetAlpha() const override; /** * @copydoc Dali::Accessibility::Component::GrabHighlight() @@ -187,30 +189,30 @@ public: /** * @copydoc Dali::Accessibility::Action::GetActionName() */ - std::string GetActionName(size_t index) override; + std::string GetActionName(size_t index) const override; /** * @copydoc Dali::Accessibility::Action::GetLocalizedActionName() */ - std::string GetLocalizedActionName(size_t index) override; + std::string GetLocalizedActionName(size_t index) const override; /** * @copydoc Dali::Accessibility::Action::GetActionDescription() */ - std::string GetActionDescription(size_t index) override; + std::string GetActionDescription(size_t index) const override; /** * @copydoc Dali::Accessibility::Action::GetActionCount() */ - size_t GetActionCount() override; + size_t GetActionCount() const override; /** * @copydoc Dali::Accessibility::Action::GetActionKeyBinding() */ - std::string GetActionKeyBinding(size_t index) override; + std::string GetActionKeyBinding(size_t index) const override; /** - * @copydoc Dali::Accessibility::Action::DoAction(size_t) + * @copydoc Dali::Accessibility::Action::DoAction(std::size_t) */ bool DoAction(size_t index) override; @@ -270,4 +272,4 @@ public: } // namespace Dali::Toolkit::DevelControl -#endif // DALI_TOOLKIT_ACCESSIBLE_IMPL_H +#endif // DALI_TOOLKIT_CONTROL_ACCESSIBLE_H diff --git a/dali-toolkit/devel-api/controls/control-devel.h b/dali-toolkit/devel-api/controls/control-devel.h index 00ff6a0..5d276cb 100644 --- a/dali-toolkit/devel-api/controls/control-devel.h +++ b/dali-toolkit/devel-api/controls/control-devel.h @@ -24,7 +24,7 @@ #include // INTERNAL INCLUDES -#include +#include #include #include @@ -563,7 +563,7 @@ DALI_TOOLKIT_API void NotifyAccessibilityStateChange(Dali::Actor control, Dali:: * @code * SetAccessibilityConstructor( []( Dali::Actor actor ) { return std::unique_ptr< Dali::Accessibility::Accessible >( - new AccessibleImpl( actor, Dali::Accessibility::Role::DIALOG, true ) ); + new ControlAccessible( actor, Dali::Accessibility::Role::DIALOG, true ) ); } ); * @endcode * diff --git a/dali-toolkit/devel-api/file.list b/dali-toolkit/devel-api/file.list index 3a40bc9..cc5abef 100755 --- a/dali-toolkit/devel-api/file.list +++ b/dali-toolkit/devel-api/file.list @@ -9,8 +9,8 @@ SET( devel_api_src_files ${devel_api_src_dir}/builder/builder.cpp ${devel_api_src_dir}/builder/json-parser.cpp ${devel_api_src_dir}/builder/tree-node.cpp - ${devel_api_src_dir}/controls/accessible-impl.cpp ${devel_api_src_dir}/controls/canvas-view/canvas-view.cpp + ${devel_api_src_dir}/controls/control-accessible.cpp ${devel_api_src_dir}/controls/control-devel.cpp ${devel_api_src_dir}/controls/control-wrapper.cpp ${devel_api_src_dir}/controls/control-wrapper-impl.cpp @@ -86,8 +86,8 @@ SET( devel_api_accessibility-manager_header_files ) SET( devel_api_controls_header_files - ${devel_api_src_dir}/controls/accessible-impl.h ${devel_api_src_dir}/controls/canvas-view/canvas-view.h + ${devel_api_src_dir}/controls/control-accessible.h ${devel_api_src_dir}/controls/control-depth-index-ranges.h ${devel_api_src_dir}/controls/control-devel.h ${devel_api_src_dir}/controls/control-wrapper.h diff --git a/dali-toolkit/internal/controls/alignment/alignment-impl.cpp b/dali-toolkit/internal/controls/alignment/alignment-impl.cpp index 1c2271c..d9b3b4d 100644 --- a/dali-toolkit/internal/controls/alignment/alignment-impl.cpp +++ b/dali-toolkit/internal/controls/alignment/alignment-impl.cpp @@ -189,7 +189,7 @@ void Alignment::OnInitialize() { DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/bloom-view/bloom-view-impl.cpp b/dali-toolkit/internal/controls/bloom-view/bloom-view-impl.cpp index 55259db..5ed17c8 100644 --- a/dali-toolkit/internal/controls/bloom-view/bloom-view-impl.cpp +++ b/dali-toolkit/internal/controls/bloom-view/bloom-view-impl.cpp @@ -219,7 +219,7 @@ void BloomView::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::ANIMATION)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::ANIMATION)); }); } diff --git a/dali-toolkit/internal/controls/buttons/button-impl.cpp b/dali-toolkit/internal/controls/buttons/button-impl.cpp index 7ff5875..7fb1ab8 100644 --- a/dali-toolkit/internal/controls/buttons/button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/button-impl.cpp @@ -1303,7 +1303,7 @@ Padding Button::GetForegroundPadding() return mForegroundPadding; } -std::string Button::AccessibleImpl::GetNameRaw() +std::string Button::AccessibleImpl::GetNameRaw() const { std::string labelText; auto slf = Toolkit::Button::DownCast(Self()); @@ -1335,7 +1335,7 @@ Property::Index Button::AccessibleImpl::GetNamePropertyIndex() Dali::Accessibility::States Button::AccessibleImpl::CalculateStates() { - auto tmp = DevelControl::AccessibleImpl::CalculateStates(); + auto tmp = DevelControl::ControlAccessible::CalculateStates(); tmp[Dali::Accessibility::State::SELECTABLE] = true; auto slf = Toolkit::Button::DownCast(Self()); tmp[Dali::Accessibility::State::ENABLED] = !slf.GetProperty(Toolkit::Button::Property::DISABLED); diff --git a/dali-toolkit/internal/controls/buttons/button-impl.h b/dali-toolkit/internal/controls/buttons/button-impl.h index ced51fd..3e36873 100644 --- a/dali-toolkit/internal/controls/buttons/button-impl.h +++ b/dali-toolkit/internal/controls/buttons/button-impl.h @@ -535,12 +535,12 @@ private: bool mClickActionPerforming; ///< Used to manage signal emissions during action protected: - struct AccessibleImpl : public DevelControl::AccessibleImpl + struct AccessibleImpl : public DevelControl::ControlAccessible { - using DevelControl::AccessibleImpl::AccessibleImpl; + using DevelControl::ControlAccessible::ControlAccessible; Dali::Accessibility::States CalculateStates() override; - std::string GetNameRaw() override; + std::string GetNameRaw() const override; Property::Index GetNamePropertyIndex() override; }; }; diff --git a/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp b/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp index 1697b20..3010e69 100644 --- a/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/toggle-button-impl.cpp @@ -383,7 +383,7 @@ Dali::Accessibility::States ToggleButton::AccessibleImpl::CalculateStates() return states; } -std::string ToggleButton::AccessibleImpl::GetDescriptionRaw() +std::string ToggleButton::AccessibleImpl::GetDescriptionRaw() const { auto button = Toolkit::ToggleButton::DownCast(Self()); auto index = button.GetProperty(Toolkit::ToggleButton::Property::CURRENT_STATE_INDEX); diff --git a/dali-toolkit/internal/controls/buttons/toggle-button-impl.h b/dali-toolkit/internal/controls/buttons/toggle-button-impl.h index 322285b..6629d40 100644 --- a/dali-toolkit/internal/controls/buttons/toggle-button-impl.h +++ b/dali-toolkit/internal/controls/buttons/toggle-button-impl.h @@ -158,7 +158,7 @@ protected: using Button::AccessibleImpl::AccessibleImpl; Dali::Accessibility::States CalculateStates() override; - std::string GetDescriptionRaw() override; + std::string GetDescriptionRaw() const override; Property::Index GetDescriptionPropertyIndex() override; }; void OnStateChange(State newState) override; diff --git a/dali-toolkit/internal/controls/canvas-view/canvas-view-impl.cpp b/dali-toolkit/internal/controls/canvas-view/canvas-view-impl.cpp index e8fefbf..6ec6fc9 100644 --- a/dali-toolkit/internal/controls/canvas-view/canvas-view-impl.cpp +++ b/dali-toolkit/internal/controls/canvas-view/canvas-view-impl.cpp @@ -99,7 +99,7 @@ void CanvasView::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::IMAGE)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::IMAGE)); }); Adaptor::Get().RegisterProcessor(*this, true); diff --git a/dali-toolkit/internal/controls/control/control-data-impl.cpp b/dali-toolkit/internal/controls/control/control-data-impl.cpp index 4aecc29..a476eca 100644 --- a/dali-toolkit/internal/controls/control/control-data-impl.cpp +++ b/dali-toolkit/internal/controls/control/control-data-impl.cpp @@ -411,11 +411,11 @@ void SetVisualsOffScene(const RegisteredVisualContainer& container, Actor parent } } -Dali::Rect<> GetShowingGeometry(Dali::Rect<> rect, Dali::Toolkit::DevelControl::AccessibleImpl* accessibleImpl) +Dali::Rect<> GetShowingGeometry(Dali::Rect<> rect, Dali::Toolkit::DevelControl::ControlAccessible* accessible) { Rect<> parentRect; Vector2 currentPosition; - auto parent = dynamic_cast(accessibleImpl->GetParent()); + auto parent = dynamic_cast(accessible->GetParent()); while(parent) { @@ -434,7 +434,7 @@ Dali::Rect<> GetShowingGeometry(Dali::Rect<> rect, Dali::Toolkit::DevelControl:: return rect; } - parent = dynamic_cast(parent->GetParent()); + parent = dynamic_cast(parent->GetParent()); } return rect; @@ -513,7 +513,7 @@ Control::Impl::Impl(Control& controlImpl) }); mAccessibilityConstructor = [](Dali::Actor actor) -> std::unique_ptr { - return std::unique_ptr(new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::UNKNOWN)); + return std::unique_ptr(new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::UNKNOWN)); }; } @@ -551,16 +551,16 @@ const Control::Impl& Control::Impl::Get(const Internal::Control& internalControl void Control::Impl::CheckHighlightedObjectGeometry() { - auto accessibleImpl = dynamic_cast(mAccessibilityObject.get()); - if(!accessibleImpl) + auto accessible = dynamic_cast(mAccessibilityObject.get()); + if(!accessible) { - DALI_LOG_ERROR("accessibleImpl is not a pointer to a DevelControl::AccessibleImpl type"); + DALI_LOG_ERROR("accessible is not a pointer to a DevelControl::ControlAccessible type"); return; } - auto lastPosition = accessibleImpl->GetLastPosition(); - auto accessibleRect = accessibleImpl->GetExtents(Dali::Accessibility::CoordinateType::WINDOW); - auto rect = GetShowingGeometry(accessibleRect, accessibleImpl); + auto lastPosition = accessible->GetLastPosition(); + auto accessibleRect = accessible->GetExtents(Dali::Accessibility::CoordinateType::WINDOW); + auto rect = GetShowingGeometry(accessibleRect, accessible); switch(mAccessibilityLastScreenRelativeMoveType) { @@ -608,7 +608,7 @@ void Control::Impl::CheckHighlightedObjectGeometry() } } - accessibleImpl->SetLastPosition(Vector2(accessibleRect.x, accessibleRect.y)); + accessible->SetLastPosition(Vector2(accessibleRect.x, accessibleRect.y)); } void Control::Impl::RegisterAccessibilityPositionPropertyNotification() diff --git a/dali-toolkit/internal/controls/control/control-data-impl.h b/dali-toolkit/internal/controls/control/control-data-impl.h index c81be41..e616e52 100644 --- a/dali-toolkit/internal/controls/control/control-data-impl.h +++ b/dali-toolkit/internal/controls/control/control-data-impl.h @@ -71,7 +71,7 @@ typedef Dali::OwnerContainer RegisteredVisualContainer; */ class Control::Impl : public ConnectionTracker, public Visual::EventObserver { - friend class Toolkit::DevelControl::AccessibleImpl; + friend class Toolkit::DevelControl::ControlAccessible; public: /** diff --git a/dali-toolkit/internal/controls/effects-view/effects-view-impl.cpp b/dali-toolkit/internal/controls/effects-view/effects-view-impl.cpp index 88fa83f..0f3e141 100644 --- a/dali-toolkit/internal/controls/effects-view/effects-view-impl.cpp +++ b/dali-toolkit/internal/controls/effects-view/effects-view-impl.cpp @@ -236,7 +236,7 @@ void EffectsView::OnInitialize() DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/flex-container/flex-container-impl.cpp b/dali-toolkit/internal/controls/flex-container/flex-container-impl.cpp index 4a3b065..964afe2 100644 --- a/dali-toolkit/internal/controls/flex-container/flex-container-impl.cpp +++ b/dali-toolkit/internal/controls/flex-container/flex-container-impl.cpp @@ -837,7 +837,7 @@ void FlexContainer::OnInitialize() DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/gaussian-blur-view/gaussian-blur-view-impl.cpp b/dali-toolkit/internal/controls/gaussian-blur-view/gaussian-blur-view-impl.cpp index 29d36b1..64d5ecb 100644 --- a/dali-toolkit/internal/controls/gaussian-blur-view/gaussian-blur-view-impl.cpp +++ b/dali-toolkit/internal/controls/gaussian-blur-view/gaussian-blur-view-impl.cpp @@ -297,7 +297,7 @@ void GaussianBlurView::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/image-view/image-view-impl.cpp b/dali-toolkit/internal/controls/image-view/image-view-impl.cpp index 1a653a1..c299886 100644 --- a/dali-toolkit/internal/controls/image-view/image-view-impl.cpp +++ b/dali-toolkit/internal/controls/image-view/image-view-impl.cpp @@ -96,7 +96,7 @@ void ImageView::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::IMAGE)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::IMAGE)); }); } diff --git a/dali-toolkit/internal/controls/magnifier/magnifier-impl.cpp b/dali-toolkit/internal/controls/magnifier/magnifier-impl.cpp index e37a534..c4e8ce2 100644 --- a/dali-toolkit/internal/controls/magnifier/magnifier-impl.cpp +++ b/dali-toolkit/internal/controls/magnifier/magnifier-impl.cpp @@ -220,7 +220,7 @@ void Magnifier::Initialize() DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/model3d-view/model3d-view-impl.cpp b/dali-toolkit/internal/controls/model3d-view/model3d-view-impl.cpp index f9bf491..b9ee873 100644 --- a/dali-toolkit/internal/controls/model3d-view/model3d-view-impl.cpp +++ b/dali-toolkit/internal/controls/model3d-view/model3d-view-impl.cpp @@ -282,7 +282,7 @@ void Model3dView::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::IMAGE)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::IMAGE)); }); } diff --git a/dali-toolkit/internal/controls/navigation-view/navigation-view-impl.cpp b/dali-toolkit/internal/controls/navigation-view/navigation-view-impl.cpp index 3dd6909..9eab290 100644 --- a/dali-toolkit/internal/controls/navigation-view/navigation-view-impl.cpp +++ b/dali-toolkit/internal/controls/navigation-view/navigation-view-impl.cpp @@ -72,7 +72,7 @@ void NavigationView::OnInitialize() { DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/page-turn-view/page-turn-view-impl.cpp b/dali-toolkit/internal/controls/page-turn-view/page-turn-view-impl.cpp index d74574c..69369de 100644 --- a/dali-toolkit/internal/controls/page-turn-view/page-turn-view-impl.cpp +++ b/dali-toolkit/internal/controls/page-turn-view/page-turn-view-impl.cpp @@ -416,7 +416,7 @@ void PageTurnView::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::PAGE_TAB_LIST)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::PAGE_TAB_LIST)); }); } diff --git a/dali-toolkit/internal/controls/popup/popup-impl.cpp b/dali-toolkit/internal/controls/popup/popup-impl.cpp index 9abcfe0..5331e74 100644 --- a/dali-toolkit/internal/controls/popup/popup-impl.cpp +++ b/dali-toolkit/internal/controls/popup/popup-impl.cpp @@ -1994,7 +1994,7 @@ void Popup::SetupTouch() } } -std::string Popup::AccessibleImpl::GetNameRaw() +std::string Popup::AccessibleImpl::GetNameRaw() const { auto popup = Toolkit::Popup::DownCast(Self()); std::string title; @@ -2018,7 +2018,7 @@ std::string Popup::AccessibleImpl::GetNameRaw() Dali::Accessibility::States Popup::AccessibleImpl::CalculateStates() { - auto states = DevelControl::AccessibleImpl::CalculateStates(); + auto states = DevelControl::ControlAccessible::CalculateStates(); auto popup = Toolkit::Popup::DownCast(Self()); auto displayState = popup.GetProperty(Toolkit::Popup::Property::DISPLAY_STATE); diff --git a/dali-toolkit/internal/controls/popup/popup-impl.h b/dali-toolkit/internal/controls/popup/popup-impl.h index 630caa8..50a2fd6 100644 --- a/dali-toolkit/internal/controls/popup/popup-impl.h +++ b/dali-toolkit/internal/controls/popup/popup-impl.h @@ -241,11 +241,11 @@ public: static Property::Value GetProperty(BaseObject* object, Property::Index propertyIndex); protected: - struct AccessibleImpl : public DevelControl::AccessibleImpl + struct AccessibleImpl : public DevelControl::ControlAccessible { - using DevelControl::AccessibleImpl::AccessibleImpl; + using DevelControl::ControlAccessible::ControlAccessible; - std::string GetNameRaw() override; + std::string GetNameRaw() const override; Dali::Accessibility::States CalculateStates() override; }; diff --git a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp index 1006307..1a243a2 100644 --- a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp +++ b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp @@ -676,18 +676,18 @@ void ProgressBar::OnSceneConnection(int depth) } } -double ProgressBar::AccessibleImpl::GetMinimum() +double ProgressBar::AccessibleImpl::GetMinimum() const { return DEFAULT_LOWER_BOUND; } -double ProgressBar::AccessibleImpl::GetCurrent() +double ProgressBar::AccessibleImpl::GetCurrent() const { auto self = Toolkit::ProgressBar::DownCast(Self()); return self.GetProperty(Toolkit::ProgressBar::Property::PROGRESS_VALUE).Get(); } -double ProgressBar::AccessibleImpl::GetMaximum() +double ProgressBar::AccessibleImpl::GetMaximum() const { return DEFAULT_UPPER_BOUND; } @@ -704,7 +704,7 @@ bool ProgressBar::AccessibleImpl::SetCurrent(double current) return true; } -double ProgressBar::AccessibleImpl::GetMinimumIncrement() +double ProgressBar::AccessibleImpl::GetMinimumIncrement() const { return 0.0; } diff --git a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h index c6729bb..96540d2 100644 --- a/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h +++ b/dali-toolkit/internal/controls/progress-bar/progress-bar-impl.h @@ -265,15 +265,16 @@ private: Property::Map mSecondaryProgressVisualMap; ///< To backup visual properties when switching determinate/indeterminate. protected: - struct AccessibleImpl : public DevelControl::AccessibleImpl, + struct AccessibleImpl : public DevelControl::ControlAccessible, public virtual Dali::Accessibility::Value { - using DevelControl::AccessibleImpl::AccessibleImpl; - double GetMinimum() override; - double GetCurrent() override; - double GetMaximum() override; + using DevelControl::ControlAccessible::ControlAccessible; + + double GetMinimum() const override; + double GetCurrent() const override; + double GetMaximum() const override; bool SetCurrent(double) override; - double GetMinimumIncrement() override; + double GetMinimumIncrement() const override; }; }; diff --git a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp index 1da4297..1fef71b 100644 --- a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp +++ b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp @@ -861,21 +861,21 @@ Toolkit::ScrollBar ScrollBar::New(Toolkit::ScrollBar::Direction direction) return handle; } -double ScrollBar::AccessibleImpl::GetMinimum() +double ScrollBar::AccessibleImpl::GetMinimum() const { auto self = Toolkit::ScrollBar::DownCast(Self()); Handle scrollableHandle = GetImpl(self).mScrollableObject.GetHandle(); return scrollableHandle ? scrollableHandle.GetCurrentProperty(GetImpl(self).mPropertyMinScrollPosition) : 0.0f; } -double ScrollBar::AccessibleImpl::GetCurrent() +double ScrollBar::AccessibleImpl::GetCurrent() const { auto self = Toolkit::ScrollBar::DownCast(Self()); Handle scrollableHandle = GetImpl(self).mScrollableObject.GetHandle(); return scrollableHandle ? scrollableHandle.GetCurrentProperty(GetImpl(self).mPropertyScrollPosition) : 0.0f; } -double ScrollBar::AccessibleImpl::GetMaximum() +double ScrollBar::AccessibleImpl::GetMaximum() const { auto self = Toolkit::ScrollBar::DownCast(Self()); Handle scrollableHandle = GetImpl(self).mScrollableObject.GetHandle(); @@ -910,7 +910,7 @@ bool ScrollBar::AccessibleImpl::SetCurrent(double current) return true; } -double ScrollBar::AccessibleImpl::GetMinimumIncrement() +double ScrollBar::AccessibleImpl::GetMinimumIncrement() const { return 1.0; } diff --git a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h index 8c6ef2a..97a7daa 100644 --- a/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h +++ b/dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.h @@ -314,15 +314,16 @@ private: bool mIndicatorFirstShow : 1; ///< True if the indicator has never been shown protected: - struct AccessibleImpl : public DevelControl::AccessibleImpl, + struct AccessibleImpl : public DevelControl::ControlAccessible, public virtual Dali::Accessibility::Value { - using DevelControl::AccessibleImpl::AccessibleImpl; - double GetMinimum() override; - double GetCurrent() override; - double GetMaximum() override; + using DevelControl::ControlAccessible::ControlAccessible; + + double GetMinimum() const override; + double GetCurrent() const override; + double GetMaximum() const override; bool SetCurrent(double) override; - double GetMinimumIncrement() override; + double GetMinimumIncrement() const override; }; }; diff --git a/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp b/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp index 609476a..ea3240f 100644 --- a/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp +++ b/dali-toolkit/internal/controls/scrollable/scrollable-impl.cpp @@ -92,7 +92,7 @@ Scrollable::~Scrollable() { } -bool Scrollable::AccessibleImpl::IsScrollable() +bool Scrollable::AccessibleImpl::IsScrollable() const { return true; } diff --git a/dali-toolkit/internal/controls/scrollable/scrollable-impl.h b/dali-toolkit/internal/controls/scrollable/scrollable-impl.h index 4240a1e..44d9a33 100644 --- a/dali-toolkit/internal/controls/scrollable/scrollable-impl.h +++ b/dali-toolkit/internal/controls/scrollable/scrollable-impl.h @@ -117,11 +117,11 @@ public: virtual void SetOvershootSize(const Vector2& size) = 0; protected: // From Control - struct AccessibleImpl : public DevelControl::AccessibleImpl + struct AccessibleImpl : public DevelControl::ControlAccessible { - using DevelControl::AccessibleImpl::AccessibleImpl; + using DevelControl::ControlAccessible::ControlAccessible; - bool IsScrollable() override; + bool IsScrollable() const override; }; /** diff --git a/dali-toolkit/internal/controls/shadow-view/shadow-view-impl.cpp b/dali-toolkit/internal/controls/shadow-view/shadow-view-impl.cpp index 612a9a4..1197a46 100644 --- a/dali-toolkit/internal/controls/shadow-view/shadow-view-impl.cpp +++ b/dali-toolkit/internal/controls/shadow-view/shadow-view-impl.cpp @@ -258,7 +258,7 @@ void ShadowView::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/slider/slider-impl.cpp b/dali-toolkit/internal/controls/slider/slider-impl.cpp index 8cac5ed..7e6370d 100644 --- a/dali-toolkit/internal/controls/slider/slider-impl.cpp +++ b/dali-toolkit/internal/controls/slider/slider-impl.cpp @@ -1411,19 +1411,19 @@ Property::Value Slider::GetProperty(BaseObject* object, Property::Index property return value; } -double Slider::AccessibleImpl::GetMinimum() +double Slider::AccessibleImpl::GetMinimum() const { auto self = Toolkit::Slider::DownCast(Self()); return self.GetProperty(Toolkit::Slider::Property::LOWER_BOUND).Get(); } -double Slider::AccessibleImpl::GetCurrent() +double Slider::AccessibleImpl::GetCurrent() const { auto self = Toolkit::Slider::DownCast(Self()); return self.GetProperty(Toolkit::Slider::Property::VALUE).Get(); } -double Slider::AccessibleImpl::GetMaximum() +double Slider::AccessibleImpl::GetMaximum() const { auto self = Toolkit::Slider::DownCast(Self()); return self.GetProperty(Toolkit::Slider::Property::UPPER_BOUND).Get(); @@ -1477,7 +1477,7 @@ bool Slider::AccessibleImpl::SetCurrent(double current) return true; } -double Slider::AccessibleImpl::GetMinimumIncrement() +double Slider::AccessibleImpl::GetMinimumIncrement() const { auto self = Toolkit::Slider::DownCast(Self()); diff --git a/dali-toolkit/internal/controls/slider/slider-impl.h b/dali-toolkit/internal/controls/slider/slider-impl.h index 082f066..7385953 100644 --- a/dali-toolkit/internal/controls/slider/slider-impl.h +++ b/dali-toolkit/internal/controls/slider/slider-impl.h @@ -749,15 +749,16 @@ private: mSnapToMarks : 1; ///< Turn on or off snapping to marks protected: - struct AccessibleImpl : public DevelControl::AccessibleImpl, + struct AccessibleImpl : public DevelControl::ControlAccessible, public virtual Dali::Accessibility::Value { - using DevelControl::AccessibleImpl::AccessibleImpl; - double GetMinimum() override; - double GetCurrent() override; - double GetMaximum() override; + using DevelControl::ControlAccessible::ControlAccessible; + + double GetMinimum() const override; + double GetCurrent() const override; + double GetMaximum() const override; bool SetCurrent(double) override; - double GetMinimumIncrement() override; + double GetMinimumIncrement() const override; }; }; diff --git a/dali-toolkit/internal/controls/super-blur-view/super-blur-view-impl.cpp b/dali-toolkit/internal/controls/super-blur-view/super-blur-view-impl.cpp index 6325e62..fef8956 100644 --- a/dali-toolkit/internal/controls/super-blur-view/super-blur-view-impl.cpp +++ b/dali-toolkit/internal/controls/super-blur-view/super-blur-view-impl.cpp @@ -151,7 +151,7 @@ void SuperBlurView::OnInitialize() DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::FILLER)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::FILLER)); }); } diff --git a/dali-toolkit/internal/controls/table-view/table-view-impl.cpp b/dali-toolkit/internal/controls/table-view/table-view-impl.cpp index 9aec5ba..2426775 100644 --- a/dali-toolkit/internal/controls/table-view/table-view-impl.cpp +++ b/dali-toolkit/internal/controls/table-view/table-view-impl.cpp @@ -1121,7 +1121,7 @@ void TableView::OnInitialize() DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::TABLE)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::TABLE)); }); } diff --git a/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h b/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h index 6e595b1..e26006d 100644 --- a/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-anchor-impl.h @@ -105,10 +105,10 @@ protected: /** * @brief This structure is to connect TextAnchor with Accessible functions. */ - struct AccessibleImpl : public DevelControl::AccessibleImpl, + struct AccessibleImpl : public DevelControl::ControlAccessible, public virtual Dali::Accessibility::Hyperlink { - using DevelControl::AccessibleImpl::AccessibleImpl; + using DevelControl::ControlAccessible::ControlAccessible; /** * @copydoc Dali::Accessibility::Hyperlink::GetEndIndex() */ diff --git a/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp index 5e9e7d9..d35e92b 100644 --- a/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp @@ -1289,13 +1289,13 @@ TextEditor::~TextEditor() } } -std::string TextEditor::AccessibleImpl::GetName() +std::string TextEditor::AccessibleImpl::GetName() const { auto self = Toolkit::TextEditor::DownCast(Self()); return self.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); } -std::string TextEditor::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) +std::string TextEditor::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) const { if(endOffset <= startOffset) { @@ -1313,7 +1313,7 @@ std::string TextEditor::AccessibleImpl::GetText(size_t startOffset, size_t endOf return text.substr(startOffset, endOffset - startOffset); } -size_t TextEditor::AccessibleImpl::GetCharacterCount() +size_t TextEditor::AccessibleImpl::GetCharacterCount() const { auto self = Toolkit::TextEditor::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); @@ -1321,7 +1321,7 @@ size_t TextEditor::AccessibleImpl::GetCharacterCount() return text.size(); } -size_t TextEditor::AccessibleImpl::GetCursorOffset() +size_t TextEditor::AccessibleImpl::GetCursorOffset() const { auto slf = Toolkit::TextEditor::DownCast(Self()); return Dali::Toolkit::GetImpl(slf).GetTextController()->GetCursorPosition(); @@ -1343,7 +1343,7 @@ bool TextEditor::AccessibleImpl::SetCursorOffset(size_t offset) return true; } -Dali::Accessibility::Range TextEditor::AccessibleImpl::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) +Dali::Accessibility::Range TextEditor::AccessibleImpl::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) const { auto self = Toolkit::TextEditor::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextEditor::Property::TEXT).Get(); @@ -1434,7 +1434,7 @@ Dali::Accessibility::Range TextEditor::AccessibleImpl::GetTextAtOffset(size_t of return range; } -Dali::Accessibility::Range TextEditor::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) +Dali::Accessibility::Range TextEditor::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) const { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1526,12 +1526,12 @@ Dali::Accessibility::States TextEditor::AccessibleImpl::CalculateStates() { using namespace Dali::Accessibility; - auto states = DevelControl::AccessibleImpl::CalculateStates(); + auto states = DevelControl::ControlAccessible::CalculateStates(); states[State::EDITABLE] = true; states[State::FOCUSABLE] = true; Toolkit::Control focusControl = Toolkit::KeyInputFocusManager::Get().GetCurrentFocusControl(); - if(mSelf == focusControl) + if(Self() == focusControl) { states[State::FOCUSED] = true; } diff --git a/dali-toolkit/internal/controls/text-controls/text-editor-impl.h b/dali-toolkit/internal/controls/text-controls/text-editor-impl.h index 50ecda5..6ea1cc8 100644 --- a/dali-toolkit/internal/controls/text-controls/text-editor-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-editor-impl.h @@ -556,32 +556,31 @@ private: // Data /** * @brief This structure is to connect TextEditor with Accessible functions. */ - struct AccessibleImpl : public DevelControl::AccessibleImpl, - public virtual Dali::Accessibility::Text, + struct AccessibleImpl : public DevelControl::ControlAccessible, public virtual Dali::Accessibility::EditableText, public virtual Dali::Accessibility::Hypertext { - using DevelControl::AccessibleImpl::AccessibleImpl; + using DevelControl::ControlAccessible::ControlAccessible; /** * @copydoc Dali::Accessibility::Accessible::GetName() */ - std::string GetName() override; + std::string GetName() const override; /** * @copydoc Dali::Accessibility::Text::GetText() */ - std::string GetText(size_t startOffset, size_t endOffset) override; + std::string GetText(size_t startOffset, size_t endOffset) const override; /** * @copydoc Dali::Accessibility::Text::GetCharacterCount() */ - size_t GetCharacterCount() override; + size_t GetCharacterCount() const override; /** * @copydoc Dali::Accessibility::Text::GetCursorOffset() */ - size_t GetCursorOffset() override; + size_t GetCursorOffset() const override; /** * @copydoc Dali::Accessibility::Text::SetCursorOffset() @@ -591,12 +590,12 @@ private: // Data /** * @copydoc Dali::Accessibility::Text::GetTextAtOffset() */ - Accessibility::Range GetTextAtOffset(size_t offset, Accessibility::TextBoundary boundary) override; + Accessibility::Range GetTextAtOffset(size_t offset, Accessibility::TextBoundary boundary) const override; /** * @copydoc Dali::Accessibility::Text::GetRangeOfSelection() */ - Accessibility::Range GetRangeOfSelection(size_t selectionIndex) override; + Accessibility::Range GetRangeOfSelection(size_t selectionIndex) const override; /** * @copydoc Dali::Accessibility::Text::RemoveSelection() diff --git a/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp index 9cefc6c..7eec04e 100644 --- a/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-field-impl.cpp @@ -1138,7 +1138,7 @@ Vector TextField::GetTextPosition(const uint32_t startIndex, const uint return mController->GetTextPosition(startIndex, endIndex); } -std::string TextField::AccessibleImpl::GetName() +std::string TextField::AccessibleImpl::GetName() const { auto self = Toolkit::TextField::DownCast(Self()); if(IsHiddenInput(self)) @@ -1149,7 +1149,7 @@ std::string TextField::AccessibleImpl::GetName() return self.GetProperty(Toolkit::TextField::Property::TEXT).Get(); } -std::string TextField::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) +std::string TextField::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) const { if(endOffset <= startOffset) { @@ -1170,7 +1170,7 @@ std::string TextField::AccessibleImpl::GetText(size_t startOffset, size_t endOff return text.substr(startOffset, endOffset - startOffset); } -size_t TextField::AccessibleImpl::GetCharacterCount() +size_t TextField::AccessibleImpl::GetCharacterCount() const { auto self = Toolkit::TextField::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextField::Property::TEXT).Get(); @@ -1178,7 +1178,7 @@ size_t TextField::AccessibleImpl::GetCharacterCount() return text.size(); } -size_t TextField::AccessibleImpl::GetCursorOffset() +size_t TextField::AccessibleImpl::GetCursorOffset() const { auto self = Toolkit::TextField::DownCast(Self()); return Dali::Toolkit::GetImpl(self).GetTextController()->GetCursorPosition(); @@ -1201,7 +1201,7 @@ bool TextField::AccessibleImpl::SetCursorOffset(size_t offset) } Dali::Accessibility::Range TextField::AccessibleImpl::GetTextAtOffset( - size_t offset, Dali::Accessibility::TextBoundary boundary) + size_t offset, Dali::Accessibility::TextBoundary boundary) const { auto self = Toolkit::TextField::DownCast(Self()); auto range = Dali::Accessibility::Range{}; @@ -1299,7 +1299,7 @@ Dali::Accessibility::Range TextField::AccessibleImpl::GetTextAtOffset( return range; } -Dali::Accessibility::Range TextField::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) +Dali::Accessibility::Range TextField::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) const { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) @@ -1399,13 +1399,13 @@ Dali::Accessibility::States TextField::AccessibleImpl::CalculateStates() { using namespace Dali::Accessibility; - auto states = DevelControl::AccessibleImpl::CalculateStates(); + auto states = DevelControl::ControlAccessible::CalculateStates(); states[State::EDITABLE] = true; states[State::FOCUSABLE] = true; Toolkit::Control focusControl = Toolkit::KeyInputFocusManager::Get().GetCurrentFocusControl(); - if(mSelf == focusControl) + if(Self() == focusControl) { states[State::FOCUSED] = true; } diff --git a/dali-toolkit/internal/controls/text-controls/text-field-impl.h b/dali-toolkit/internal/controls/text-controls/text-field-impl.h index 6efd495..e53189e 100644 --- a/dali-toolkit/internal/controls/text-controls/text-field-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-field-impl.h @@ -504,32 +504,31 @@ protected: /** * @brief This structure is to connect TextField with Accessible functions. */ - struct AccessibleImpl : public DevelControl::AccessibleImpl, - public virtual Dali::Accessibility::Text, + struct AccessibleImpl : public DevelControl::ControlAccessible, public virtual Dali::Accessibility::EditableText, public virtual Dali::Accessibility::Hypertext { - using DevelControl::AccessibleImpl::AccessibleImpl; + using DevelControl::ControlAccessible::ControlAccessible; /** * @copydoc Dali::Accessibility::Accessible::GetName() */ - std::string GetName() override; + std::string GetName() const override; /** * @copydoc Dali::Accessibility::Text::GetText() */ - std::string GetText(size_t startOffset, size_t endOffset) override; + std::string GetText(size_t startOffset, size_t endOffset) const override; /** * @copydoc Dali::Accessibility::Text::GetCharacterCount() */ - size_t GetCharacterCount() override; + size_t GetCharacterCount() const override; /** * @copydoc Dali::Accessibility::Text::GetCursorOffset() */ - size_t GetCursorOffset() override; + size_t GetCursorOffset() const override; /** * @copydoc Dali::Accessibility::Text::SetCursorOffset() @@ -539,12 +538,12 @@ protected: /** * @copydoc Dali::Accessibility::Text::GetTextAtOffset() */ - Accessibility::Range GetTextAtOffset(size_t offset, Accessibility::TextBoundary boundary) override; + Accessibility::Range GetTextAtOffset(size_t offset, Accessibility::TextBoundary boundary) const override; /** * @copydoc Dali::Accessibility::Text::GetRangeOfSelection() */ - Accessibility::Range GetRangeOfSelection(size_t selectionIndex) override; + Accessibility::Range GetRangeOfSelection(size_t selectionIndex) const override; /** * @copydoc Dali::Accessibility::Text::RemoveSelection() diff --git a/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp index 9e15b34..ae948e2 100644 --- a/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-label-impl.cpp @@ -1146,7 +1146,7 @@ Vector TextLabel::GetTextPosition(const uint32_t startIndex, const uint return mController->GetTextPosition(startIndex, endIndex); } -std::string TextLabel::AccessibleImpl::GetNameRaw() +std::string TextLabel::AccessibleImpl::GetNameRaw() const { auto self = Toolkit::TextLabel::DownCast(Self()); return self.GetProperty(Toolkit::TextLabel::Property::TEXT).Get(); @@ -1157,7 +1157,7 @@ Property::Index TextLabel::AccessibleImpl::GetNamePropertyIndex() return Toolkit::TextLabel::Property::TEXT; } -std::string TextLabel::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) +std::string TextLabel::AccessibleImpl::GetText(size_t startOffset, size_t endOffset) const { if(endOffset <= startOffset) { @@ -1175,7 +1175,7 @@ std::string TextLabel::AccessibleImpl::GetText(size_t startOffset, size_t endOff return text.substr(startOffset, endOffset - startOffset); } -size_t TextLabel::AccessibleImpl::GetCharacterCount() +size_t TextLabel::AccessibleImpl::GetCharacterCount() const { auto self = Toolkit::TextLabel::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextLabel::Property::TEXT).Get(); @@ -1183,7 +1183,7 @@ size_t TextLabel::AccessibleImpl::GetCharacterCount() return text.size(); } -size_t TextLabel::AccessibleImpl::GetCursorOffset() +size_t TextLabel::AccessibleImpl::GetCursorOffset() const { return {}; } @@ -1193,7 +1193,7 @@ bool TextLabel::AccessibleImpl::SetCursorOffset(size_t offset) return {}; } -Dali::Accessibility::Range TextLabel::AccessibleImpl::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) +Dali::Accessibility::Range TextLabel::AccessibleImpl::GetTextAtOffset(size_t offset, Dali::Accessibility::TextBoundary boundary) const { auto self = Toolkit::TextLabel::DownCast(Self()); auto text = self.GetProperty(Toolkit::TextLabel::Property::TEXT).Get(); @@ -1284,7 +1284,7 @@ Dali::Accessibility::Range TextLabel::AccessibleImpl::GetTextAtOffset(size_t off return range; } -Dali::Accessibility::Range TextLabel::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) +Dali::Accessibility::Range TextLabel::AccessibleImpl::GetRangeOfSelection(size_t selectionIndex) const { // Since DALi supports only one selection indexes higher than 0 are ignored if(selectionIndex > 0) diff --git a/dali-toolkit/internal/controls/text-controls/text-label-impl.h b/dali-toolkit/internal/controls/text-controls/text-label-impl.h index 3f1080c..8bedc5b 100644 --- a/dali-toolkit/internal/controls/text-controls/text-label-impl.h +++ b/dali-toolkit/internal/controls/text-controls/text-label-impl.h @@ -243,26 +243,26 @@ protected: /** * @brief This structure is to connect TextLabel with Accessible functions. */ - struct AccessibleImpl : public DevelControl::AccessibleImpl, + struct AccessibleImpl : public DevelControl::ControlAccessible, public virtual Dali::Accessibility::Text, public virtual Dali::Accessibility::Hypertext { - using DevelControl::AccessibleImpl::AccessibleImpl; + using DevelControl::ControlAccessible::ControlAccessible; /** * @copydoc Dali::Accessibility::Text::GetText() */ - std::string GetText(size_t startOffset, size_t endOffset) override; + std::string GetText(size_t startOffset, size_t endOffset) const override; /** * @copydoc Dali::Accessibility::Text::GetCharacterCount() */ - size_t GetCharacterCount() override; + size_t GetCharacterCount() const override; /** * @copydoc Dali::Accessibility::Text::GetCursorOffset() */ - size_t GetCursorOffset() override; + size_t GetCursorOffset() const override; /** * @copydoc Dali::Accessibility::Text::SetCursorOffset() @@ -272,12 +272,12 @@ protected: /** * @copydoc Dali::Accessibility::Text::GetTextAtOffset() */ - Accessibility::Range GetTextAtOffset(size_t offset, Accessibility::TextBoundary boundary) override; + Accessibility::Range GetTextAtOffset(size_t offset, Accessibility::TextBoundary boundary) const override; /** * @copydoc Dali::Accessibility::Text::GetRangeOfSelection() */ - Accessibility::Range GetRangeOfSelection(size_t selectionIndex) override; + Accessibility::Range GetRangeOfSelection(size_t selectionIndex) const override; /** * @copydoc Dali::Accessibility::Text::RemoveSelection() @@ -292,7 +292,7 @@ protected: /** * @copydoc Dali::Accessibility::Text::GetNameRaw() */ - std::string GetNameRaw() override; + std::string GetNameRaw() const override; /** * @copydoc Dali::Accessibility::Text::GetNamePropertyIndex() diff --git a/dali-toolkit/internal/controls/text-controls/text-selection-popup-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-selection-popup-impl.cpp index e2d9f91..2ff1bd4 100644 --- a/dali-toolkit/internal/controls/text-controls/text-selection-popup-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-selection-popup-impl.cpp @@ -399,7 +399,7 @@ void TextSelectionPopup::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::DIALOG, true)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::DIALOG, true)); }); //Enable highightability diff --git a/dali-toolkit/internal/controls/text-controls/text-selection-toolbar-impl.cpp b/dali-toolkit/internal/controls/text-controls/text-selection-toolbar-impl.cpp index ba2b8d5..3220328 100644 --- a/dali-toolkit/internal/controls/text-controls/text-selection-toolbar-impl.cpp +++ b/dali-toolkit/internal/controls/text-controls/text-selection-toolbar-impl.cpp @@ -166,7 +166,7 @@ void TextSelectionToolbar::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::TOOL_BAR)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::TOOL_BAR)); }); } diff --git a/dali-toolkit/internal/controls/tool-bar/tool-bar-impl.cpp b/dali-toolkit/internal/controls/tool-bar/tool-bar-impl.cpp index 2aefaaf..0e894df 100644 --- a/dali-toolkit/internal/controls/tool-bar/tool-bar-impl.cpp +++ b/dali-toolkit/internal/controls/tool-bar/tool-bar-impl.cpp @@ -313,7 +313,7 @@ void ToolBar::OnInitialize() DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::TOOL_BAR)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::TOOL_BAR)); }); } diff --git a/dali-toolkit/internal/controls/video-view/video-view-impl.cpp b/dali-toolkit/internal/controls/video-view/video-view-impl.cpp index 181a47e..9934f3b 100644 --- a/dali-toolkit/internal/controls/video-view/video-view-impl.cpp +++ b/dali-toolkit/internal/controls/video-view/video-view-impl.cpp @@ -120,7 +120,7 @@ void VideoView::OnInitialize() DevelControl::SetAccessibilityConstructor(self, [](Dali::Actor actor) { return std::unique_ptr( - new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::VIDEO)); + new DevelControl::ControlAccessible(actor, Dali::Accessibility::Role::VIDEO)); }); //Enable highightability