From: Joogab Yun Date: Mon, 12 Aug 2019 04:44:06 +0000 (+0900) Subject: Revert "[Tizen] Connect KeyEventGeneratedSignal for Get KeyEvent" X-Git-Tag: submit/tizen/20190812.050445~4 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=921a837e960459e187221bf811647b676c81d0b9 Revert "[Tizen] Connect KeyEventGeneratedSignal for Get KeyEvent" This reverts commit 4dc14515fa751f4a5be2548f88880de3a13ae822. --- diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp index 0eccfad..2726434 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.cpp @@ -23,7 +23,6 @@ #include #include #include -#include // INTERNAL INCLUDES #include "test-render-surface.h" @@ -141,11 +140,6 @@ KeyEventSignalType& KeyEventSignal( Window window ) return GetImplementation( window ).mScene.KeyEventSignal(); } -KeyEventGeneratedSignalType& KeyEventGeneratedSignal( Window window ) -{ - return DevelStage::KeyEventGeneratedSignal( Dali::Stage::GetCurrent() ); -} - TouchSignalType& TouchSignal( Window window ) { return GetImplementation( window ).mScene.TouchSignal(); diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.h b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.h index 2692761..c830af5 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.h +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/toolkit-window.h @@ -68,7 +68,6 @@ namespace DevelWindow { typedef Signal< void () > EventProcessingFinishedSignalType; typedef Signal< void (const KeyEvent&) > KeyEventSignalType; -typedef Signal< bool (const KeyEvent&) > KeyEventGeneratedSignalType; typedef Signal< void (const TouchData&) > TouchSignalType; typedef Signal< void (const WheelEvent&) > WheelEventSignalType; @@ -76,7 +75,6 @@ Dali::Window Get( Actor actor ); EventProcessingFinishedSignalType& EventProcessingFinishedSignal( Window window ); KeyEventSignalType& KeyEventSignal( Dali::Window window ); -KeyEventGeneratedSignalType& KeyEventGeneratedSignal( Dali::Window window ); TouchSignalType& TouchSignal( Dali::Window window ); WheelEventSignalType& WheelEventSignal( Window window ); diff --git a/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.cpp b/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.cpp index 71bc352..f188281 100644 --- a/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.cpp +++ b/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.cpp @@ -23,8 +23,6 @@ #include #include #include -#include -#include // INTERNAL INCLUDES #include @@ -52,26 +50,13 @@ KeyInputFocusManager::KeyInputFocusManager() : mSlotDelegate( this ), mCurrentFocusControl() { - // Retrieve all the existing widnows - Dali::WindowContainer windows = Adaptor::Get().GetWindows(); - for ( auto iter = windows.begin(); iter != windows.end(); ++iter ) - { - DevelWindow::KeyEventGeneratedSignal( *iter ).Connect( mSlotDelegate, &KeyInputFocusManager::OnKeyEvent); - } - - // Get notified when any new window is created afterwards - Adaptor::Get().WindowCreatedSignal().Connect( mSlotDelegate, &KeyInputFocusManager::OnWindowCreated); + DevelStage::KeyEventGeneratedSignal( Stage::GetCurrent() ).Connect(mSlotDelegate, &KeyInputFocusManager::OnKeyEvent); } KeyInputFocusManager::~KeyInputFocusManager() { } -void KeyInputFocusManager::OnWindowCreated( Dali::Window& window ) -{ - DevelWindow::KeyEventGeneratedSignal( window ).Connect( mSlotDelegate, &KeyInputFocusManager::OnKeyEvent); -} - void KeyInputFocusManager::SetFocus( Toolkit::Control control ) { if( !control ) diff --git a/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.h b/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.h index 0f066c5..f7886c2 100644 --- a/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.h +++ b/dali-toolkit/internal/focus-manager/keyinput-focus-manager-impl.h @@ -30,8 +30,6 @@ namespace Dali { -class Window; - namespace Toolkit { @@ -92,11 +90,6 @@ protected: virtual ~KeyInputFocusManager(); private: - /** - * This will be called when a new window is created - * @param window The new window - */ - void OnWindowCreated( Dali::Window& window ); /** * Callback for the key event when no actor in the stage has gained the key input focus