From: David Steele <david.steele@samsung.com>
Date: Fri, 13 Jul 2018 15:44:06 +0000 (+0100)
Subject: Modified StyleManager::SetTheme to prevent ApplyDefaultTheme breaking
X-Git-Tag: dali_1.3.35~2^2
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=91190f9b68b47fd181e5d71ce72f9622330e0aa6;ds=sidebyside

Modified StyleManager::SetTheme to prevent ApplyDefaultTheme breaking

Change-Id: I6066314d734b87eb1b13ed7946f5e14ef40e4e70
---

diff --git a/dali-toolkit/internal/styling/style-manager-impl.cpp b/dali-toolkit/internal/styling/style-manager-impl.cpp
index df885d9..106ec54 100644
--- a/dali-toolkit/internal/styling/style-manager-impl.cpp
+++ b/dali-toolkit/internal/styling/style-manager-impl.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016 Samsung Electronics Co., Ltd.
+ * Copyright (c) 2018 Samsung Electronics Co., Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -45,6 +45,10 @@ const char* APPLICATION_RESOURCE_PATH_KEY = "APPLICATION_RESOURCE_PATH";
 
 const char* DEFAULT_PACKAGE_PATH = DALI_DATA_READ_ONLY_DIR "/toolkit/";
 
+#if defined(DEBUG_ENABLED)
+Debug::Filter* gLogFilter = Debug::Filter::New( Debug::NoLogging, false, "LOG_STYLE");
+#endif
+
 } // namespace
 
 namespace Dali
@@ -227,42 +231,52 @@ Toolkit::StyleManager::StyleChangedSignalType& StyleManager::ControlStyleChangeS
 void StyleManager::SetTheme( const std::string& themeFile )
 {
   bool themeLoaded = false;
+  bool loading = false;
 
-  if( mThemeFile.compare(DEFAULT_THEME) == 0 && mThemeBuilder )
+  // If we haven't loaded a theme, or the stored theme file is empty, or
+  // the previously loaded theme is different to the requested theme,
+  // first reset the builder and load the default theme.
+  if( ! mThemeBuilder || mThemeFile.empty() || mThemeFile.compare( themeFile ) != 0 )
   {
-    // We have already loaded the default theme into mThemeBuilder
-  }
-  else
-  {
-    // Reload the default theme
+    loading = true;
     mThemeBuilder = CreateBuilder( mThemeBuilderConstants );
-    themeLoaded = LoadJSON( mThemeBuilder, DEFAULT_THEME );
+    themeLoaded = LoadJSON( mThemeBuilder, DEFAULT_THEME ); // Sets themeLoaded to true if theme exists
   }
 
   if( themeFile.compare(DEFAULT_THEME) != 0 )
   {
     // The theme is different to the default: Merge it
-    themeLoaded = LoadJSON( mThemeBuilder, themeFile );
-    mThemeFile = themeFile;
+    loading = true;
+    themeLoaded |= LoadJSON( mThemeBuilder, themeFile );
   }
 
-  if( themeLoaded )
+  if( loading )
   {
-    if(mFeedbackStyle)
+    mThemeFile = themeFile;
+
+    if( themeLoaded )
     {
-      mFeedbackStyle->StyleChanged( mThemeFile, StyleChange::THEME_CHANGE );
-    }
+      // We've successfully loaded the theme file
+      if(mFeedbackStyle)
+      {
+        mFeedbackStyle->StyleChanged( mThemeFile, StyleChange::THEME_CHANGE );
+      }
 
-    EmitStyleChangeSignals(StyleChange::THEME_CHANGE);
-  }
-  else
-  {
-    mThemeBuilder.Reset();
+      EmitStyleChangeSignals(StyleChange::THEME_CHANGE);
+    }
+    else
+    {
+      // We tried to load a theme, but it failed. Ensure the builder is reset
+      mThemeBuilder.Reset();
+      mThemeFile.clear();
+    }
   }
 }
 
 const Property::Map StyleManager::GetConfigurations()
 {
+  DALI_LOG_STREAM( gLogFilter, Debug::Concise, "GetConfigurations()\n On entry, mThemeBuilder: " << (bool(mThemeBuilder)?"Created":"Empty") << "  mThemeFile: " << mThemeFile);
+
   Property::Map result;
   if( mThemeBuilder )
   {
@@ -270,6 +284,8 @@ const Property::Map StyleManager::GetConfigurations()
   }
   else
   {
+    DALI_LOG_STREAM( gLogFilter, Debug::Concise, "GetConfigurations()  Loading default theme" );
+
     bool themeLoaded = false;
 
     mThemeBuilder = CreateBuilder( mThemeBuilderConstants );
@@ -282,8 +298,12 @@ const Property::Map StyleManager::GetConfigurations()
     {
       result = mThemeBuilder.GetConfigurations();
     }
+    DALI_LOG_STREAM( gLogFilter, Debug::Concise, "  themeLoaded" << (themeLoaded?"success":"failure") );
   }
 
+  DALI_LOG_STREAM( gLogFilter, Debug::Concise, "GetConfigurations()\n On exit, result Count: " << (result.Count() != 0) );
+  DALI_LOG_STREAM( gLogFilter, Debug::Verbose, "          result: " << result );
+
   return result;
 }