From: Shinwoo Kim Date: Fri, 12 Nov 2021 01:46:10 +0000 (+0900) Subject: [ATSPI] make ScrollToChild use descendant X-Git-Tag: dali_2.0.53~3^2 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=90168515fb4b80ff64c068769420c0235a225d71;hp=2a1d671b3526a30bfb8698a8bde4496b82be7f35 [ATSPI] make ScrollToChild use descendant It is not make a child visible if the child is 1st generation child. Usually the 1st generation child is content container. So we need to use descendant. This patch makes the CollectionView work with following change; https://github.com/Samsung/TizenFX/pull/3726 We need to enhance this part and related places later. Change-Id: I9e88312b7b1936909dc350cc1154f2a18e900748 --- diff --git a/dali-toolkit/devel-api/controls/accessible-impl.cpp b/dali-toolkit/devel-api/controls/accessible-impl.cpp index bd4a649..9f6f4f9 100644 --- a/dali-toolkit/devel-api/controls/accessible-impl.cpp +++ b/dali-toolkit/devel-api/controls/accessible-impl.cpp @@ -363,7 +363,6 @@ void AccessibleImpl::ScrollToSelf() parent->ScrollToChild(child->Self()); } - child = parent; parent = dynamic_cast(parent->GetParent()); } } diff --git a/dali-toolkit/devel-api/controls/accessible-impl.h b/dali-toolkit/devel-api/controls/accessible-impl.h index 18b77f5..8bd0714 100644 --- a/dali-toolkit/devel-api/controls/accessible-impl.h +++ b/dali-toolkit/devel-api/controls/accessible-impl.h @@ -236,7 +236,7 @@ public: virtual Dali::Accessibility::States CalculateStates(); /** - * @brief Makes sure that a given child of this container (e.g. ItemView) is visible + * @brief Makes sure that a given child (descendant) of this container (e.g. ItemView) is visible * @return false if scrolling is not supported or child is already visible */ virtual bool ScrollToChild(Actor child);