From: Eunki Hong Date: Fri, 3 Jun 2022 11:37:42 +0000 (+0000) Subject: Merge "Fix visual defect during text scroll" into devel/master X-Git-Tag: dali_2.1.26~11 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=8e8d63d501dc8c26f84932dfad3a9e3a9083cfb1;hp=7cd51e51add5d6682ef7535b9bce454043b2dad3 Merge "Fix visual defect during text scroll" into devel/master --- diff --git a/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Shaping.cpp b/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Shaping.cpp index 80624a8..301f191 100755 --- a/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Shaping.cpp +++ b/automated-tests/src/dali-toolkit-internal/utc-Dali-Text-Shaping.cpp @@ -87,7 +87,7 @@ bool IsEqualGlyph(const GlyphInfoData& glyphData, const GlyphInfo& glyph) { return false; } - if(fabsf(glyphData.advance - floor(glyph.advance)) > Math::MACHINE_EPSILON_1000) + if(glyphData.advance >= 0.0f && fabsf(glyphData.advance - floor(glyph.advance)) > Math::MACHINE_EPSILON_1000) { return false; } @@ -961,9 +961,10 @@ int UtcDaliTextShapeEmojiSequences(void) bool sizeDefined = false; // variation selector 16 (Emoji) + // Note : Non-scalable font's advance value is undefined. See https://github.com/harfbuzz/harfbuzz/discussions/3023. 2022-06-03 updated. struct GlyphInfoData glyphsVS16[] = { - {2u, 74u, 0.f, 0.f, 0.f, 0.f, 39.0f, 0.f, false, false}, + {2u, 74u, 0.f, 0.f, 0.f, 0.f, -1.0f /* Special value that we don't check it */, 0.f, false, false}, }; CharacterIndex characterIndicesVS16[] = {0u, 1u}; Length charactersPerGlyphVS16[] = {2u};