From: Paul Wisbey Date: Fri, 21 Oct 2016 16:24:21 +0000 (-0700) Subject: Merge "Fix for a single line text's vertical alignment." into devel/master X-Git-Tag: dali_1.2.12~16 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=5b71e5d95f63c4aad74ffefe112fd13813cd90dc;hp=3a0e332bcbb81df7de0a571f8b694b20bdbb12be Merge "Fix for a single line text's vertical alignment." into devel/master --- diff --git a/dali-toolkit/internal/visuals/text/text-visual.cpp b/dali-toolkit/internal/visuals/text/text-visual.cpp index 48f9a04..31dc8bb 100644 --- a/dali-toolkit/internal/visuals/text/text-visual.cpp +++ b/dali-toolkit/internal/visuals/text/text-visual.cpp @@ -810,6 +810,13 @@ Dali::Property::Value TextVisual::DoGetProperty( Dali::Property::Index index ) void TextVisual::RenderText() { + Actor self = mSelf.GetHandle(); + if( !self ) + { + // Nothing to do if the handle is not initialized. + return; + } + Actor renderableActor; if( mRenderer ) @@ -826,7 +833,7 @@ void TextVisual::RenderText() const Vector2& scrollOffset = mController->GetScrollPosition(); renderableActor.SetPosition( scrollOffset.x, scrollOffset.y ); - mSelf.Add( renderableActor ); + self.Add( renderableActor ); } mRenderableActor = renderableActor; @@ -847,6 +854,13 @@ void TextVisual::StopTextAutoScrolling() void TextVisual::SetUpAutoScrolling() { + Actor self = mSelf.GetHandle(); + if( !self ) + { + // Nothing to do if the handle is not initialized. + return; + } + const Text::ScrollerData* const data = mController->GetAutoScrollData(); if( NULL != data ) @@ -860,8 +874,8 @@ void TextVisual::SetUpAutoScrolling() mTextScroller->StartScrolling( mRenderableActor, *data ); - mSelf.Add( mTextScroller->GetScrollingText() ); - mSelf.Add( mTextScroller->GetSourceCamera() ); + self.Add( mTextScroller->GetScrollingText() ); + self.Add( mTextScroller->GetSourceCamera() ); } } diff --git a/dali-toolkit/internal/visuals/text/text-visual.h b/dali-toolkit/internal/visuals/text/text-visual.h index a57ddba..47289d1 100644 --- a/dali-toolkit/internal/visuals/text/text-visual.h +++ b/dali-toolkit/internal/visuals/text/text-visual.h @@ -19,6 +19,7 @@ */ // EXTERNAL INCLUDES +#include #include // INTERNAL INCLUDES @@ -168,7 +169,7 @@ private: private: Text::ControllerPtr mController; ///< The text's controller. - Actor mSelf; + WeakHandle mSelf; Text::RendererPtr mRenderer; Text::TextScrollerPtr mTextScroller; diff --git a/dali-toolkit/public-api/dali-toolkit-version.cpp b/dali-toolkit/public-api/dali-toolkit-version.cpp index c15604b..8c9ed00 100644 --- a/dali-toolkit/public-api/dali-toolkit-version.cpp +++ b/dali-toolkit/public-api/dali-toolkit-version.cpp @@ -31,7 +31,7 @@ namespace Toolkit const unsigned int TOOLKIT_MAJOR_VERSION = 1; const unsigned int TOOLKIT_MINOR_VERSION = 2; -const unsigned int TOOLKIT_MICRO_VERSION = 10; +const unsigned int TOOLKIT_MICRO_VERSION = 11; const char * const TOOLKIT_BUILD_DATE = __DATE__ " " __TIME__; #ifdef DEBUG_ENABLED diff --git a/packaging/dali-addon.spec b/packaging/dali-addon.spec index 0da6d86..b5a63b2 100644 --- a/packaging/dali-addon.spec +++ b/packaging/dali-addon.spec @@ -1,6 +1,6 @@ Name: dali-addon Summary: DALi module for Node.JS -Version: 1.2.10 +Version: 1.2.11 Release: 1 Group: Development/Libraries License: Apache License, Version 2.0 diff --git a/packaging/dali-csharp-wrapper.spec b/packaging/dali-csharp-wrapper.spec index dca178a..788769d 100755 --- a/packaging/dali-csharp-wrapper.spec +++ b/packaging/dali-csharp-wrapper.spec @@ -1,6 +1,6 @@ Name: NDalic Summary: dali wrapper -Version: 1.0.0 +Version: 1.2.11 Release: 1 Group: uifw/graphic License: TO_BE_FILLED_IN diff --git a/packaging/dali-toolkit.spec b/packaging/dali-toolkit.spec index f4e8ae0..bae76d7 100644 --- a/packaging/dali-toolkit.spec +++ b/packaging/dali-toolkit.spec @@ -1,6 +1,6 @@ Name: dali-toolkit Summary: The OpenGLES Canvas Core Library Toolkit -Version: 1.2.10 +Version: 1.2.11 Release: 1 Group: System/Libraries License: Apache-2.0 and BSD-2-Clause and MIT