From: Adeel Kazmi Date: Wed, 14 Mar 2018 10:39:55 +0000 (+0000) Subject: Merge "Fix SVACE issue" into devel/master X-Git-Tag: dali_1.3.16~1 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=4d00f5fe754246c36aba847105e7ffbb15f2fec2;hp=3bcb53e9e30f5c72741f583191e20b2f2bc0d5b9 Merge "Fix SVACE issue" into devel/master --- diff --git a/automated-tests/src/dali-toolkit/utc-Dali-VisualFactory.cpp b/automated-tests/src/dali-toolkit/utc-Dali-VisualFactory.cpp index 9556968..849cf7e 100644 --- a/automated-tests/src/dali-toolkit/utc-Dali-VisualFactory.cpp +++ b/automated-tests/src/dali-toolkit/utc-Dali-VisualFactory.cpp @@ -1882,6 +1882,30 @@ int UtcDaliVisualFactoryGetPrimitiveVisual17(void) END_TEST; } +//Test if primitive shape loads a conic section correctly. +int UtcDaliVisualFactoryGetPrimitiveVisual18(void) +{ + //Set up test application first, so everything else can be handled. + ToolkitTestApplication application; + + tet_infoline( "UtcDaliVisualFactoryGetPrimitiveVisual18: Request primitive visual to display a conic section" ); + + //Set up visual properties. + Property::Map propertyMap; + propertyMap.Insert( Toolkit::Visual::Property::TYPE, Visual::PRIMITIVE ); + propertyMap.Insert( PrimitiveVisual::Property::SHAPE, PrimitiveVisual::Shape::CONICAL_FRUSTUM ); + propertyMap.Insert( PrimitiveVisual::Property::MIX_COLOR, Vector4( 0.5, 0.5, 0.5, 1.0 ) ); + propertyMap.Insert( PrimitiveVisual::Property::SLICES, 10 ); + propertyMap.Insert( PrimitiveVisual::Property::SCALE_TOP_RADIUS, 30.0f ); + propertyMap.Insert( PrimitiveVisual::Property::SCALE_BOTTOM_RADIUS, 40.0f ); + propertyMap.Insert( PrimitiveVisual::Property::SCALE_HEIGHT, 50.0f ); + + //Test to see if shape loads correctly. + TestPrimitiveVisualWithProperties( propertyMap, application ); + + END_TEST; +} + //Test if primitive shape visual handles the case of not being passed a specific shape to use. int UtcDaliVisualFactoryGetPrimitiveVisualN1(void) { diff --git a/build/tizen/docs/dali.doxy.in b/build/tizen/docs/dali.doxy.in index 1b23769..941fdbc 100755 --- a/build/tizen/docs/dali.doxy.in +++ b/build/tizen/docs/dali.doxy.in @@ -345,6 +345,7 @@ ALIASES += clip{3}="\dontinclude \1 \n \skip \2 \n \until \3" ALIASES += SINCE_1_0="@since 1.0" ALIASES += SINCE_1_1="@since 1.1" ALIASES += SINCE_1_2="@since 1.2" +ALIASES += SINCE_1_3="@since 1.3" # Extra tags for Tizen 3.0 ALIASES += SINCE_1_2_2="@since 1.2.2" @@ -359,11 +360,13 @@ ALIASES += SINCE_1_3_4="@since 1.3.4" ALIASES += SINCE_1_3_5="@since 1.3.5" ALIASES += SINCE_1_3_9="@since 1.3.9" ALIASES += SINCE_1_3_15="@since 1.3.15" + ALIASES += DEPRECATED_1_0="@deprecated Deprecated since 1.0" ALIASES += DEPRECATED_1_1="@deprecated Deprecated since 1.1" ALIASES += DEPRECATED_1_2_8="@deprecated Deprecated since 1.2.8" ALIASES += DEPRECATED_1_2_10="@deprecated Deprecated since 1.2.10" ALIASES += DEPRECATED_1_2="@deprecated Deprecated since 1.2" +ALIASES += DEPRECATED_1_3="@deprecated Deprecated since 1.3" ALIASES += PLATFORM="" ALIASES += PRIVLEVEL_PLATFORM="" @@ -380,6 +383,7 @@ ALIASES += REMARK_RAWVIDEO="" #ALIASES += SINCE_1_0="\par Since:\n 2.4, DALi version 1.0" #ALIASES += SINCE_1_1="\par Since:\n 3.0, DALi version 1.1" #ALIASES += SINCE_1_2="\par Since:\n 4.0, DALi version 1.2" +#ALIASES += SINCE_1_3="\par Since:\n 5.0, DALi version 1.3" ## Extra tags for Tizen 3.0 #ALIASES += SINCE_1_2_2="\par Since:\n 3.0, DALi version 1.2.2" @@ -402,6 +406,7 @@ ALIASES += REMARK_RAWVIDEO="" #ALIASES += DEPRECATED_1_2_8="@deprecated Deprecated since 3.0, DALi version 1.2.8" #ALIASES += DEPRECATED_1_2_10="@deprecated Deprecated since 3.0, DALi version 1.2.10" #ALIASES += DEPRECATED_1_2="@deprecated Deprecated since 4.0, DALi version 1.2" +#ALIASES += DEPRECATED_1_3="@deprecated Deprecated since 5.0, DALi version 1.3" #ALIASES += PLATFORM="@platform" #ALIASES += PRIVLEVEL_PLATFORM="\par Privilege Level:\n platform" diff --git a/dali-toolkit/internal/accessibility-manager/accessibility-manager-impl.h b/dali-toolkit/internal/accessibility-manager/accessibility-manager-impl.h index 23da644..69e924a 100644 --- a/dali-toolkit/internal/accessibility-manager/accessibility-manager-impl.h +++ b/dali-toolkit/internal/accessibility-manager/accessibility-manager-impl.h @@ -635,14 +635,14 @@ private: /** * Perform the accessibility action to move the focus to the first item on the top - * and read from the top item continously (by three fingers single tap). + * and read from the top item continuously (by three fingers single tap). * @return whether the accessibility action is performed or not. */ virtual bool AccessibilityActionReadFromTop(); /** * Perform the accessibility action to move the focus to and read from the next item - * continously (by three fingers double tap). + * continuously (by three fingers double tap). * @return whether the accessibility action is performed or not. */ virtual bool AccessibilityActionReadFromNext(); diff --git a/dali-toolkit/internal/text/text-controller.cpp b/dali-toolkit/internal/text/text-controller.cpp index b18767b..f47b526 100755 --- a/dali-toolkit/internal/text/text-controller.cpp +++ b/dali-toolkit/internal/text/text-controller.cpp @@ -2164,7 +2164,8 @@ Toolkit::DevelText::TextDirection::Type Controller::GetTextDirection() if ( mImpl->mUpdateTextDirection ) { // Operations that can be done only once until the text changes. - const OperationsMask onlyOnceOperations = static_cast( GET_SCRIPTS | + const OperationsMask onlyOnceOperations = static_cast( CONVERT_TO_UTF32 | + GET_SCRIPTS | VALIDATE_FONTS | GET_LINE_BREAKS | GET_WORD_BREAKS | @@ -2185,6 +2186,9 @@ Toolkit::DevelText::TextDirection::Type Controller::GetTextDirection() LAYOUT | REORDER | UPDATE_DIRECTION ), naturalSize.GetVectorXY() ); + // Do not do again the only once operations. + mImpl->mOperationsPending = static_cast( mImpl->mOperationsPending & ~onlyOnceOperations ); + // Clear the update info. This info will be set the next time the text is updated. mImpl->mTextUpdateInfo.Clear(); diff --git a/dali-toolkit/internal/visuals/primitive/primitive-visual.cpp b/dali-toolkit/internal/visuals/primitive/primitive-visual.cpp index e097ec8..8a2ec88 100644 --- a/dali-toolkit/internal/visuals/primitive/primitive-visual.cpp +++ b/dali-toolkit/internal/visuals/primitive/primitive-visual.cpp @@ -46,12 +46,13 @@ namespace // shapes DALI_ENUM_TO_STRING_TABLE_BEGIN( SHAPE_TYPE ) DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, SPHERE ) -DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, CONICAL_FRUSTRUM ) +DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, CONICAL_FRUSTRUM ) // deprecated DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, CONE ) DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, CYLINDER ) DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, CUBE ) DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, OCTAHEDRON ) DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, BEVELLED_CUBE ) +DALI_ENUM_TO_STRING_WITH_SCOPE( Toolkit::PrimitiveVisual::Shape, CONICAL_FRUSTUM ) DALI_ENUM_TO_STRING_TABLE_END( SHAPE_TYPE ) //Property names @@ -70,8 +71,8 @@ const char * const LIGHT_POSITION_UNIFORM_NAME( "lightPosition" ); //Primitive property defaults const int DEFAULT_SLICES = 128; ///< For spheres and conics const int DEFAULT_STACKS = 128; ///< For spheres and conics -const float DEFAULT_SCALE_TOP_RADIUS = 1.0; ///< For conical frustrums -const float DEFAULT_SCALE_BOTTOM_RADIUS = 1.5; ///< For cones and conical frustrums +const float DEFAULT_SCALE_TOP_RADIUS = 1.0; ///< For conical frustums +const float DEFAULT_SCALE_BOTTOM_RADIUS = 1.5; ///< For cones and conical frustums const float DEFAULT_SCALE_HEIGHT = 3.0; ///< For all conics const float DEFAULT_SCALE_RADIUS = 1.0; ///< For cylinders const float DEFAULT_BEVEL_PERCENTAGE = 0.0; ///< For bevelled cubes @@ -90,11 +91,12 @@ const float MAX_SMOOTHNESS = 1.0; ///< Maximum bevel smoothness for bevell //Specific shape labels. const char * const SPHERE_LABEL( "SPHERE" ); const char * const CONE_LABEL( "CONE" ); -const char * const CONICAL_FRUSTRUM_LABEL( "CONICAL_FRUSTRUM" ); +const char * const CONICAL_FRUSTRUM_LABEL( "CONICAL_FRUSTRUM" ); // deprecated const char * const CYLINDER_LABEL( "CYLINDER" ); const char * const CUBE_LABEL( "CUBE" ); const char * const OCTAHEDRON_LABEL( "OCTAHEDRON" ); const char * const BEVELLED_CUBE_LABEL( "BEVELLED_CUBE" ); +const char * const CONICAL_FRUSTUM_LABEL( "CONICAL_FRUSTUM" ); //Shader properties const char * const OBJECT_MATRIX_UNIFORM_NAME( "uObjectMatrix" ); @@ -515,7 +517,7 @@ void PrimitiveVisual::CreateGeometry() CreateConic( vertices, indices, 0, mScaleBottomRadius, mScaleHeight, mSlices ); break; } - case Toolkit::PrimitiveVisual::Shape::CONICAL_FRUSTRUM: + case Toolkit::PrimitiveVisual::Shape::CONICAL_FRUSTRUM: // deprecated { CreateConic( vertices, indices, mScaleTopRadius, mScaleBottomRadius, mScaleHeight, mSlices ); break; @@ -543,6 +545,11 @@ void PrimitiveVisual::CreateGeometry() CreateBevelledCube( vertices, indices, mScaleDimensions, mBevelPercentage, mBevelSmoothness ); break; } + case Toolkit::PrimitiveVisual::Shape::CONICAL_FRUSTUM: + { + CreateConic( vertices, indices, mScaleTopRadius, mScaleBottomRadius, mScaleHeight, mSlices ); + break; + } } mGeometry = Geometry::New(); diff --git a/dali-toolkit/internal/visuals/primitive/primitive-visual.h b/dali-toolkit/internal/visuals/primitive/primitive-visual.h index 677df9d..6b38bd7 100644 --- a/dali-toolkit/internal/visuals/primitive/primitive-visual.h +++ b/dali-toolkit/internal/visuals/primitive/primitive-visual.h @@ -79,11 +79,11 @@ typedef IntrusivePtr< PrimitiveVisual > PrimitiveVisualPtr; * | %Property Name | Type | Shapes Affected | * |-------------------|-------------|------------------------------------------| * | shapeColor | VECTOR4 | all | - * | slices | INTEGER | sphere, cone, conical frustrum, cylinder | + * | slices | INTEGER | sphere, cone, conical frustum, cylinder | * | stacks | INTEGER | sphere | - * | scaleTopRadius | FLOAT | conical frustrum | - * | scaleBottomRadius | FLOAT | cone, conical frustrum | - * | scaleHeight | FLOAT | cone, conical frustrum, cylinder | + * | scaleTopRadius | FLOAT | conical frustum | + * | scaleBottomRadius | FLOAT | cone, conical frustum | + * | scaleHeight | FLOAT | cone, conical frustum, cylinder | * | scaleRadius | FLOAT | cylinder | * | scaleDimensions | VECTOR3 | cube, octahedron, bevelled cube | * | bevelPercentage | FLOAT | bevelled cube | diff --git a/dali-toolkit/public-api/accessibility-manager/accessibility-manager.h b/dali-toolkit/public-api/accessibility-manager/accessibility-manager.h index 4a1c148..fe9b11e 100644 --- a/dali-toolkit/public-api/accessibility-manager/accessibility-manager.h +++ b/dali-toolkit/public-api/accessibility-manager/accessibility-manager.h @@ -722,7 +722,7 @@ public: /** * @brief This is emitted when accessibility action is received to focus and read from the - * first item on the top continously (by three fingers single tap). + * first item on the top continuously (by three fingers single tap). * * A callback of the following type may be connected: * @code @@ -735,7 +735,7 @@ public: /** * @brief This is emitted when accessibility action is received to move the focus to and - * read from the next item continously (by three fingers double tap). + * read from the next item continuously (by three fingers double tap). * * A callback of the following type may be connected: * @code diff --git a/dali-toolkit/public-api/controls/flex-container/flex-container.h b/dali-toolkit/public-api/controls/flex-container/flex-container.h index 0f6f9d9..94ef744 100644 --- a/dali-toolkit/public-api/controls/flex-container/flex-container.h +++ b/dali-toolkit/public-api/controls/flex-container/flex-container.h @@ -220,7 +220,7 @@ public: { // Event side child properties FLEX = CHILD_PROPERTY_START_INDEX, ///< name "flex", The proportion of the free space in the container the flex item will receive. If all items in the container set this property, their sizes will be proportional to the specified flex factor, type FLOAT @SINCE_1_1.35 - ALIGN_SELF, ///< name "alignSelf", The alignment of the flex item along the cross axis, which, if set, overides the default alignment for all items in the container, @see FlexContainer::Alignment, type INTEGER @SINCE_1_1.35 + ALIGN_SELF, ///< name "alignSelf", The alignment of the flex item along the cross axis, which, if set, overrides the default alignment for all items in the container, @see FlexContainer::Alignment, type INTEGER @SINCE_1_1.35 FLEX_MARGIN ///< name "flexMargin", The space around the flex item, type VECTOR4 @SINCE_1_1.35 }; }; diff --git a/dali-toolkit/public-api/dali-toolkit-version.cpp b/dali-toolkit/public-api/dali-toolkit-version.cpp index 0b59ae0..59d7cb3 100644 --- a/dali-toolkit/public-api/dali-toolkit-version.cpp +++ b/dali-toolkit/public-api/dali-toolkit-version.cpp @@ -31,7 +31,7 @@ namespace Toolkit const unsigned int TOOLKIT_MAJOR_VERSION = 1; const unsigned int TOOLKIT_MINOR_VERSION = 3; -const unsigned int TOOLKIT_MICRO_VERSION = 14; +const unsigned int TOOLKIT_MICRO_VERSION = 15; const char * const TOOLKIT_BUILD_DATE = __DATE__ " " __TIME__; #ifdef DEBUG_ENABLED diff --git a/dali-toolkit/public-api/visuals/primitive-visual-properties.h b/dali-toolkit/public-api/visuals/primitive-visual-properties.h index 30477e8..1e3afcf 100644 --- a/dali-toolkit/public-api/visuals/primitive-visual-properties.h +++ b/dali-toolkit/public-api/visuals/primitive-visual-properties.h @@ -73,12 +73,12 @@ enum /** * @brief The number of slices as you go around the shape. * @details Name "slices", type Property::INTEGER. - * For spheres and conical frustrums, this determines how many divisions there are as you go around the object. + * For spheres and conical frustums, this determines how many divisions there are as you go around the object. * @SINCE_1_1.45 * @note Optional. If not specified, the default is 128. * @note Applies to: * - Shape::SPHERE - * - Shape::CONICAL_FRUSTRUM + * - Shape::CONICAL_FRUSTUM * - Shape::CONE * - Shape::CYLINDER * @note The range is from 1 to 255. @@ -98,23 +98,23 @@ enum STACKS, /** - * @brief The scale of the radius of the top circle of a conical frustrum. + * @brief The scale of the radius of the top circle of a conical frustum. * @details Name "scaleTopRadius", type Property::FLOAT. * @SINCE_1_1.45 * @note Optional. If not specified, the default is 1.0f. * @note Applies to: - * - Shape::CONICAL_FRUSTRUM + * - Shape::CONICAL_FRUSTUM * @note Only values greater than or equal to 0.0f are accepted. */ SCALE_TOP_RADIUS, /** - * @brief The scale of the radius of the bottom circle of a conical frustrum. + * @brief The scale of the radius of the bottom circle of a conical frustum. * @details Name "scaleBottomRadius", type Property::FLOAT. * @SINCE_1_1.45 * @note Optional. If not specified, the default is 1.5f. * @note Applies to: - * - Shape::CONICAL_FRUSTRUM + * - Shape::CONICAL_FRUSTUM * - Shape::CONE * @note Only values greater than or equal to 0.0f are accepted. */ @@ -126,7 +126,7 @@ enum * @SINCE_1_1.45 * @note Optional. If not specified, the default is 3.0f. * @note Applies to: - * - Shape::CONICAL_FRUSTRUM + * - Shape::CONICAL_FRUSTUM * - Shape::CONE * - Shape::CYLINDER * @note Only values greater than or equal to 0.0f are accepted. @@ -208,12 +208,13 @@ namespace Shape enum Type { SPHERE, ///< A perfectly round geometrical object in three-dimensional space. @SINCE_1_1.45 - CONICAL_FRUSTRUM, ///< The area bound between two circles, i.e. a cone with the tip removed. @SINCE_1_1.45 - CONE, ///< Equivalent to a conical frustrum with top radius of zero. @SINCE_1_1.45 - CYLINDER, ///< Equivalent to a conical frustrum with equal radii for the top and bottom circles. @SINCE_1_1.45 + CONICAL_FRUSTRUM, ///< @DEPRECATED_1_3.15, use CONICAL_FRUSTUM instead. The area bound between two circles, i.e. a cone with the tip removed. @SINCE_1_1.45 + CONE, ///< Equivalent to a conical frustum with top radius of zero. @SINCE_1_1.45 + CYLINDER, ///< Equivalent to a conical frustum with equal radii for the top and bottom circles. @SINCE_1_1.45 CUBE, ///< Equivalent to a bevelled cube with a bevel percentage of zero. @SINCE_1_1.45 OCTAHEDRON, ///< Equivalent to a bevelled cube with a bevel percentage of one. @SINCE_1_1.45 BEVELLED_CUBE, ///< A cube/cuboid with all edges flattened to some degree. @SINCE_1_1.45 + CONICAL_FRUSTUM ///< The area bound between two circles, i.e. a cone with the tip removed. @SINCE_1_3.15 }; } diff --git a/doc/dali-toolkit-doc.h b/doc/dali-toolkit-doc.h index 982583a..bc706fb 100644 --- a/doc/dali-toolkit-doc.h +++ b/doc/dali-toolkit-doc.h @@ -86,7 +86,7 @@ * * * @ref dali_toolkit_controls_image_view - * ImageView is a control displying an image. + * ImageView is a control displaying an image. * * * @ref dali_toolkit_controls_scroll_bar @@ -170,7 +170,7 @@ * @brief GaussianBlurView provides a render process that blurs an image. * @defgroup dali_toolkit_controls_image_view Image View - * @brief ImageView is a control displying an image. + * @brief ImageView is a control displaying an image. * @defgroup dali_toolkit_controls_scroll_bar Scroll Bar * @brief ScrollBar is a component that can be linked to the scrollable objects. diff --git a/packaging/dali-toolkit.spec b/packaging/dali-toolkit.spec index 0ad26c0..cb13793 100644 --- a/packaging/dali-toolkit.spec +++ b/packaging/dali-toolkit.spec @@ -1,6 +1,6 @@ Name: dali-toolkit Summary: Dali 3D engine Toolkit -Version: 1.3.14 +Version: 1.3.15 Release: 1 Group: System/Libraries License: Apache-2.0 and BSD-3-Clause and MIT