From: György Straub Date: Wed, 9 Sep 2020 13:28:55 +0000 (+0100) Subject: Adding 'override', removing 'virtual' from overriding functions' declarations in... X-Git-Tag: dali_1.9.29~4 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=3fea156f024c5b2909e6a6aa9daaffd3767d7108;hp=eccbcc0637034cc96bc6d392b297a9d99e86c442 Adding 'override', removing 'virtual' from overriding functions' declarations in tests. Change-Id: I04ba825e4125a13e27818eed9b2d9be67755b6ef Signed-off-by: György Straub --- diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/dummy-control.h b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/dummy-control.h index 9150df8..6f79c36 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/dummy-control.h +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/dummy-control.h @@ -122,7 +122,7 @@ protected: DummyControlImpl(); - virtual ~DummyControlImpl(); + ~DummyControlImpl() override; }; namespace Impl @@ -148,7 +148,7 @@ private: DummyControl(); - virtual ~DummyControl(); + ~DummyControl() override; private: // From Internal::Control diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.h b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.h index 1df0743..e224c6b 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.h +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-application.h @@ -58,7 +58,7 @@ public: void CreateCore(); void CreateScene(); void InitializeCore(); - virtual ~TestApplication(); + ~TestApplication() override; static void LogMessage( Dali::Integration::Log::DebugPriority level, std::string& message ); static void LogContext( bool start, const char* tag ); Dali::Integration::Core& GetCore(); diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-button.h b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-button.h index c9a29e4..bb361e2 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-button.h +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-button.h @@ -74,7 +74,7 @@ public: protected: TestButton(); - virtual ~TestButton(); + ~TestButton() override; public: Test::TestAnimationData mPressTransitionData; diff --git a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-gl-abstraction.h b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-gl-abstraction.h index 9f458fc..6fc7049 100644 --- a/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-gl-abstraction.h +++ b/automated-tests/src/dali-toolkit/dali-toolkit-test-utils/test-gl-abstraction.h @@ -54,19 +54,19 @@ class DALI_CORE_API TestGlAbstraction: public Dali::Integration::GlAbstraction { public: TestGlAbstraction(); - ~TestGlAbstraction(); + ~TestGlAbstraction() override; void Initialize(); - void PreRender(); - void PostRender(); + void PreRender() override; + void PostRender() override; - bool IsSurfacelessContextSupported() const; + bool IsSurfacelessContextSupported() const override; - bool TextureRequiresConverting( const GLenum imageGlFormat, const GLenum textureGlFormat, const bool isSubImage ) const; + bool TextureRequiresConverting( const GLenum imageGlFormat, const GLenum textureGlFormat, const bool isSubImage ) const override; /* OpenGL ES 2.0 */ - inline void ActiveTexture( GLenum textureUnit ) + inline void ActiveTexture( GLenum textureUnit ) override { mActiveTextureUnit = textureUnit - GL_TEXTURE0; } @@ -76,7 +76,7 @@ public: return mActiveTextureUnit + GL_TEXTURE0; } - inline void AttachShader( GLuint program, GLuint shader ) + inline void AttachShader( GLuint program, GLuint shader ) override { std::stringstream out; out << program << ", " << shader; @@ -87,21 +87,21 @@ public: mShaderTrace.PushCall("AttachShader", out.str(), namedParams); } - inline void BindAttribLocation( GLuint program, GLuint index, const char* name ) + inline void BindAttribLocation( GLuint program, GLuint index, const char* name ) override { } - inline void BindBuffer( GLenum target, GLuint buffer ) + inline void BindBuffer( GLenum target, GLuint buffer ) override { } - inline void BindFramebuffer( GLenum target, GLuint framebuffer ) + inline void BindFramebuffer( GLenum target, GLuint framebuffer ) override { //Add 010 bit; mFramebufferStatus |= 2; } - inline void BindRenderbuffer( GLenum target, GLuint renderbuffer ) + inline void BindRenderbuffer( GLenum target, GLuint renderbuffer ) override { } @@ -137,7 +137,7 @@ public: } } - inline void BindTexture( GLenum target, GLuint texture ) + inline void BindTexture( GLenum target, GLuint texture ) override { // Record the bound textures for future checks if( texture ) @@ -160,7 +160,7 @@ public: mTextureTrace.PushCall("BindTexture", out.str(), namedParams); } - inline void BlendColor(GLclampf red, GLclampf green, GLclampf blue, GLclampf alpha) + inline void BlendColor(GLclampf red, GLclampf green, GLclampf blue, GLclampf alpha) override { mLastBlendColor.r = red; mLastBlendColor.g = green; @@ -173,13 +173,13 @@ public: return mLastBlendColor; } - inline void BlendEquation( GLenum mode ) + inline void BlendEquation( GLenum mode ) override { mLastBlendEquationRgb = mode; mLastBlendEquationAlpha = mode; } - inline void BlendEquationSeparate( GLenum modeRgb, GLenum modeAlpha ) + inline void BlendEquationSeparate( GLenum modeRgb, GLenum modeAlpha ) override { mLastBlendEquationRgb = modeRgb; mLastBlendEquationAlpha = modeAlpha; @@ -195,7 +195,7 @@ public: return mLastBlendEquationAlpha; } - inline void BlendFunc(GLenum sfactor, GLenum dfactor) + inline void BlendFunc(GLenum sfactor, GLenum dfactor) override { mLastBlendFuncSrcRgb = sfactor; mLastBlendFuncDstRgb = dfactor; @@ -203,7 +203,7 @@ public: mLastBlendFuncDstAlpha = dfactor; } - inline void BlendFuncSeparate(GLenum srcRGB, GLenum dstRGB, GLenum srcAlpha, GLenum dstAlpha) + inline void BlendFuncSeparate(GLenum srcRGB, GLenum dstRGB, GLenum srcAlpha, GLenum dstAlpha) override { mLastBlendFuncSrcRgb = srcRGB; mLastBlendFuncDstRgb = dstRGB; @@ -231,17 +231,17 @@ public: return mLastBlendFuncDstAlpha; } - inline void BufferData(GLenum target, GLsizeiptr size, const void* data, GLenum usage) + inline void BufferData(GLenum target, GLsizeiptr size, const void* data, GLenum usage) override { mBufferDataCalls.push_back(size); } - inline void BufferSubData(GLenum target, GLintptr offset, GLsizeiptr size, const void* data) + inline void BufferSubData(GLenum target, GLintptr offset, GLsizeiptr size, const void* data) override { mBufferSubDataCalls.push_back(size); } - inline GLenum CheckFramebufferStatus(GLenum target) + inline GLenum CheckFramebufferStatus(GLenum target) override { //If it has the three last bits set to 1 - 111, then the three minimum functions to create a //Framebuffer texture have been called @@ -268,13 +268,13 @@ public: return mFramebufferStencilAttached; } - inline void Clear(GLbitfield mask) + inline void Clear(GLbitfield mask) override { mClearCount++; mLastClearBitMask = mask; } - inline void ClearColor(GLclampf red, GLclampf green, GLclampf blue, GLclampf alpha) + inline void ClearColor(GLclampf red, GLclampf green, GLclampf blue, GLclampf alpha) override { mLastClearColor.r = red; mLastClearColor.g = green; @@ -287,11 +287,11 @@ public: return mLastClearColor; } - inline void ClearDepthf(GLclampf depth) + inline void ClearDepthf(GLclampf depth) override { } - inline void ClearStencil(GLint s) + inline void ClearStencil(GLint s) override { std::stringstream out; out << s; @@ -302,7 +302,7 @@ public: mStencilFunctionTrace.PushCall( "ClearStencil", out.str(), namedParams ); } - inline void ColorMask(GLboolean red, GLboolean green, GLboolean blue, GLboolean alpha) + inline void ColorMask(GLboolean red, GLboolean green, GLboolean blue, GLboolean alpha) override { mColorMaskParams.red = red; mColorMaskParams.green = green; @@ -310,7 +310,7 @@ public: mColorMaskParams.alpha = alpha; } - inline void CompileShader(GLuint shader) + inline void CompileShader(GLuint shader) override { std::stringstream out; out << shader; @@ -320,7 +320,7 @@ public: mShaderTrace.PushCall("CompileShader", out.str(), namedParams); } - inline void CompressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, GLsizei imageSize, const void* data) + inline void CompressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, GLsizei imageSize, const void* data) override { std::stringstream out; out << target<<", "<second; } - inline void GetVertexAttribfv(GLuint index, GLenum pname, GLfloat* params) + inline void GetVertexAttribfv(GLuint index, GLenum pname, GLfloat* params) override { } - inline void GetVertexAttribiv(GLuint index, GLenum pname, GLint* params) + inline void GetVertexAttribiv(GLuint index, GLenum pname, GLint* params) override { } - inline void GetVertexAttribPointerv(GLuint index, GLenum pname, void** pointer) + inline void GetVertexAttribPointerv(GLuint index, GLenum pname, void** pointer) override { } - inline void Hint(GLenum target, GLenum mode) + inline void Hint(GLenum target, GLenum mode) override { } - inline GLboolean IsBuffer(GLuint buffer) + inline GLboolean IsBuffer(GLuint buffer) override { return mIsBufferResult; } - inline GLboolean IsEnabled(GLenum cap) + inline GLboolean IsEnabled(GLenum cap) override { return mIsEnabledResult; } - inline GLboolean IsFramebuffer(GLuint framebuffer) + inline GLboolean IsFramebuffer(GLuint framebuffer) override { return mIsFramebufferResult; } - inline GLboolean IsProgram(GLuint program) + inline GLboolean IsProgram(GLuint program) override { return mIsProgramResult; } - inline GLboolean IsRenderbuffer(GLuint renderbuffer) + inline GLboolean IsRenderbuffer(GLuint renderbuffer) override { return mIsRenderbufferResult; } - inline GLboolean IsShader(GLuint shader) + inline GLboolean IsShader(GLuint shader) override { return mIsShaderResult; } - inline GLboolean IsTexture(GLuint texture) + inline GLboolean IsTexture(GLuint texture) override { return mIsTextureResult; } - inline void LineWidth(GLfloat width) + inline void LineWidth(GLfloat width) override { } - inline void LinkProgram(GLuint program) + inline void LinkProgram(GLuint program) override { std::stringstream out; out << program; @@ -938,31 +939,31 @@ public: GetUniformLocation(program, "sGloss"); } - inline void PixelStorei(GLenum pname, GLint param) + inline void PixelStorei(GLenum pname, GLint param) override { } - inline void PolygonOffset(GLfloat factor, GLfloat units) + inline void PolygonOffset(GLfloat factor, GLfloat units) override { } - inline void ReadPixels(GLint x, GLint y, GLsizei width, GLsizei height, GLenum format, GLenum type, void* pixels) + inline void ReadPixels(GLint x, GLint y, GLsizei width, GLsizei height, GLenum format, GLenum type, void* pixels) override { } - inline void ReleaseShaderCompiler(void) + inline void ReleaseShaderCompiler(void) override { } - inline void RenderbufferStorage(GLenum target, GLenum internalformat, GLsizei width, GLsizei height) + inline void RenderbufferStorage(GLenum target, GLenum internalformat, GLsizei width, GLsizei height) override { } - inline void SampleCoverage(GLclampf value, GLboolean invert) + inline void SampleCoverage(GLclampf value, GLboolean invert) override { } - inline void Scissor(GLint x, GLint y, GLsizei width, GLsizei height) + inline void Scissor(GLint x, GLint y, GLsizei width, GLsizei height) override { mScissorParams.x = x; mScissorParams.y = y; @@ -979,11 +980,11 @@ public: mScissorTrace.PushCall( "Scissor", out.str(), namedParams ); } - inline void ShaderBinary(GLsizei n, const GLuint* shaders, GLenum binaryformat, const void* binary, GLsizei length) + inline void ShaderBinary(GLsizei n, const GLuint* shaders, GLenum binaryformat, const void* binary, GLsizei length) override { } - inline void ShaderSource(GLuint shader, GLsizei count, const char** string, const GLint* length) + inline void ShaderSource(GLuint shader, GLsizei count, const char** string, const GLint* length) override { std::string stringBuilder; for(int i = 0; i < count; ++i) @@ -994,7 +995,7 @@ public: mLastShaderCompiled = shader; } - inline void GetShaderSource(GLuint shader, GLsizei bufsize, GLsizei* length, char* source) + inline void GetShaderSource(GLuint shader, GLsizei bufsize, GLsizei* length, char* source) override { const std::string shaderSource = mShaderSources[shader]; const int shaderSourceLength = static_cast(shaderSource.length()); @@ -1016,7 +1017,7 @@ public: return mShaderSources[shader]; } - inline void StencilFunc(GLenum func, GLint ref, GLuint mask) + inline void StencilFunc(GLenum func, GLint ref, GLuint mask) override { std::stringstream out; out << func << ", " << ref << ", " << mask; @@ -1029,7 +1030,7 @@ public: mStencilFunctionTrace.PushCall( "StencilFunc", out.str(), namedParams ); } - inline void StencilFuncSeparate(GLenum face, GLenum func, GLint ref, GLuint mask) + inline void StencilFuncSeparate(GLenum face, GLenum func, GLint ref, GLuint mask) override { std::stringstream out; out << face << ", " << func << ", " << ref << ", " << mask; @@ -1043,7 +1044,7 @@ public: mStencilFunctionTrace.PushCall( "StencilFuncSeparate", out.str(), namedParams ); } - inline void StencilMask(GLuint mask) + inline void StencilMask(GLuint mask) override { std::stringstream out; out << mask; @@ -1054,7 +1055,7 @@ public: mStencilFunctionTrace.PushCall( "StencilMask", out.str(), namedParams ); } - inline void StencilMaskSeparate(GLenum face, GLuint mask) + inline void StencilMaskSeparate(GLenum face, GLuint mask) override { std::stringstream out; out << face << ", " << mask; @@ -1066,7 +1067,7 @@ public: mStencilFunctionTrace.PushCall( "StencilMaskSeparate", out.str(), namedParams ); } - inline void StencilOp(GLenum fail, GLenum zfail, GLenum zpass) + inline void StencilOp(GLenum fail, GLenum zfail, GLenum zpass) override { std::stringstream out; out << fail << ", " << zfail << ", " << zpass; @@ -1079,7 +1080,7 @@ public: mStencilFunctionTrace.PushCall( "StencilOp", out.str(), namedParams ); } - inline void StencilOpSeparate(GLenum face, GLenum fail, GLenum zfail, GLenum zpass) + inline void StencilOpSeparate(GLenum face, GLenum fail, GLenum zfail, GLenum zpass) override { std::stringstream out; out << face << ", " << fail << ", " << zfail << "," << zpass; @@ -1093,7 +1094,7 @@ public: mStencilFunctionTrace.PushCall( "StencilOpSeparate", out.str(), namedParams ); } - inline void TexImage2D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height, GLint border, GLenum format, GLenum type, const void* pixels) + inline void TexImage2D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height, GLint border, GLenum format, GLenum type, const void* pixels) override { std::stringstream out; out << target<<", "<